Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / external / vulkan-validation-layers / e35b66a1881d03fdd74907f055e9ddef0fe188f5
commite35b66a1881d03fdd74907f055e9ddef0fe188f5[log] [tgz]
authorTobin Ehlis <tobine@google.com>Wed Mar 15 12:18:31 2017 -0600
committerTobin Ehlis <tobine@google.com>Wed Mar 22 10:19:45 2017 -0600
tree17ef0812793f776713ed97f4fc569ed206299b1d
parent74cc6824d67bf3cbc84eebdd31c83ee94ad5c83f [diff]
layers:Refactor image layout verify/set

VerifyImageLayout had a side effect of setting image layout state if
the layout had not been seen by the cmd buffer. This update moves the
code to set the layout outside of the verify function and instead puts
it into new SetLayout* functions that are now called in the appropriate
PreCallRecord* functions.

Note that the previous behavior caused a side effect where layouts
could be updated even when the call down the chain did not occur.
The updated behavior will always update the layout to what is passed
as the explicit layout for any image copy operations whenever the
call down the chain is made. This is desirable b/c if the layout
didn't match the app saw the error during the Validate* portion of
the call and if they chose to ignore it then validation should
reflect the layout state of the image that was set by the call.

Since the side effect mentioned above is no longer present, this change
includes an update to InvalidImageLayout test where a second call to
vkCmdCopyImage() is made in order to actually transition the initial
image layout state so that expected errors are correct going fwd.
4 files changed
tree: 17ef0812793f776713ed97f4fc569ed206299b1d
  1. build-android/
  2. cmake/
  3. common/
  4. external_revisions/
  5. include/
  6. layers/
  7. loader/
  8. scripts/
  9. tests/
  10. windowsRuntimeInstaller/
  11. .appveyor.yml
  12. .clang-format
  13. .gitignore
  14. .travis.yml
  15. BUILD.md
  16. build_windows_targets.bat
  17. CMakeLists.txt
  18. CONTRIBUTING.md
  19. COPYRIGHT.txt
  20. LICENSE.txt
  21. README.md
  22. update_external_sources.bat
  23. update_external_sources.sh
README.md

Vulkan Ecosystem Components

This project provides Khronos official ICD loader and validation layers for Vulkan developers on Windows and Linux.

CI Build Status

PlatformBuild Status
Linux/AndroidBuild Status
WindowsBuild status

Introduction

Vulkan is an Explicit API, enabling direct control over how GPUs actually work. No (or very little) validation or error checking is done inside a Vulkan driver. Applications have full control and responsibility. Any errors in how Vulkan is used often result in a crash. This project provides standard validation layers that can be enabled to ease development by helping developers verify their applications correctly use the Vulkan API.

Vulkan supports multiple GPUs and multiple global contexts (VkInstance). The ICD loader is necessary to support multiple GPUs and the VkInstance level Vulkan commands. Additionally, the loader manages inserting Vulkan layer libraries, including validation layers between the application and the ICD.

The following components are available in this repository:

Contributing

If you intend to contribute, the preferred work flow is for you to develop your contribution in a fork of this repo in your GitHub account and then submit a pull request. Please see the CONTRIBUTING file in this repository for more details

How to Build and Run

BUILD.md includes directions for building all the components, running the validation tests and running the demo applications.

Information on how to enable the various Validation layers is in layers/README.md.

Architecture and interface information for the loader is in loader/LoaderAndLayerInterface.md.

NOTE: Update Nvidia Drivers

  • A recent glslang change exposed a bug in the texel fetch behavior on Nvidia devices under certain situations.
  • Previously, we reverted the glslang change which exposed it.
  • Nvidia has since resolved the issue, and we are now removing the workaround.
  • Driver installs with the fix are available on their download page, just look for:
  • Linux Drivers starting with version 367.35
  • Windows Drivers starting at version 372.54

License

This work is released as open source under a Apache-style license from Khronos including a Khronos copyright.

See COPYRIGHT.txt for a full list of licenses used in this repository.

Acknowledgements

While this project has been developed primarily by LunarG, Inc; there are many other companies and individuals making this possible: Valve Corporation, funding project development; Google providing significant contributions to the validation layers; Khronos providing oversight and hosting of the project.