commit e87f87c0247c58ea54131386c46d1c5bba967adc
author Locke <locke@lunarg.com> Tue Apr 23 17:53:10 2019 -0600
committer Locke Lin <47329816+locke-lunarg@users.noreply.github.com> Mon Apr 29 12:26:57 2019 -0600
tree 3a9811cd4737f3f2cf85ab5884670c93b9d04fbb
parent 510ed9b07df6111a8c6daf63ff9cd95dc63d69a5

layers: Validate VkExternalFormatANDROID

When VkImageCreateInfo chains VkExternalFormatANDROID and format is
VK_FORMAT_UNDEFINED, it doesn't fail.

Change-Id: I98576f2704a54596b7f40206624d0a9d7900012e

layers/buffer_validation.cpp

diff --git a/layers/buffer_validation.cpp b/layers/buffer_validation.cpp
index 0952a21..38f35d3 100644
--- a/layers/buffer_validation.cpp
+++ b/layers/buffer_validation.cpp
@@ -1343,9 +1343,12 @@
     VkImageFormatProperties format_limits = {};
     VkResult res = GetPDImageFormatProperties(pCreateInfo, &format_limits);
     if (res == VK_ERROR_FORMAT_NOT_SUPPORTED) {
-        skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, kVUIDUndefined,
-                        "vkCreateImage(): Format %s is not supported for this combination of parameters.",
-                        string_VkFormat(pCreateInfo->format));
+#ifdef VK_USE_PLATFORM_ANDROID_KHR
+        if (!lvl_find_in_chain<VkExternalFormatANDROID>(pCreateInfo->pNext))
+#endif  // VK_USE_PLATFORM_ANDROID_KHR
+            skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, kVUIDUndefined,
+                            "vkCreateImage(): Format %s is not supported for this combination of parameters.",
+                            string_VkFormat(pCreateInfo->format));
     } else {
         if (pCreateInfo->mipLevels > format_limits.maxMipLevels) {
             const char *format_string = string_VkFormat(pCreateInfo->format);