commit f4107bd768e00d0fe78bd23a9e218c4ec87439fc
author Chris Forbes <chrisf@ijw.co.nz> Fri Sep 18 13:23:32 2015 +1200
committer Chris Forbes <chrisf@ijw.co.nz> Sat Sep 19 19:48:45 2015 +1200
tree 3ab907fb27d9a1a155ab49da552292dfb52eefe5
parent 6871cda67eae32da9228295beb676dfb80a63a22

icd: fixup renderpass load ops for less waste and correct stencil clears

Previously if we asked to clear stencil but not depth, nothing was done.

Signed-off-by: Chris Forbes <chrisf@ijw.co.nz>
Reviewed-by: Courtney Goeltzenleuchter <courtney@lunarg.com>

icd/intel/cmd_pipeline.c

diff --git a/icd/intel/cmd_pipeline.c b/icd/intel/cmd_pipeline.c
index 60e0f60..4dc5abb 100644
--- a/icd/intel/cmd_pipeline.c
+++ b/icd/intel/cmd_pipeline.c
@@ -3714,31 +3714,32 @@
             &pRenderPassBegin->pClearValues[i];
         VkImageSubresourceRange range;
 
-        if (!att->clear_on_load)
-            continue;
-
         view = fb->views[i];
         range.baseMipLevel = view->mipLevel;
         range.mipLevels = 1;
         range.baseArrayLayer = view->baseArrayLayer;
         range.arraySize = view->array_size;
+        range.aspectMask = 0;
 
         if (view->is_rt) {
-            range.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT;
+            /* color */
+            if (att->clear_on_load) {
+                range.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT;
 
-            cmd_meta_clear_color_image(cmdBuffer, view->img,
-                    att->initial_layout, &clear_val->color, 1, &range);
+                cmd_meta_clear_color_image(cmdBuffer, view->img,
+                        att->initial_layout, &clear_val->color, 1, &range);
+            }
         } else {
-            range.aspectMask = VK_IMAGE_ASPECT_DEPTH_BIT;
-
-            cmd_meta_clear_depth_stencil_image(cmdBuffer,
-                    view->img, att->initial_layout,
-                    clear_val->depthStencil.depth, clear_val->depthStencil.stencil,
-                    1, &range);
+            /* depth/stencil */
+            if (att->clear_on_load) {
+                range.aspectMask |= VK_IMAGE_ASPECT_DEPTH_BIT;
+            }
 
             if (att->stencil_clear_on_load) {
-                range.aspectMask = VK_IMAGE_ASPECT_STENCIL_BIT;
+                range.aspectMask |= VK_IMAGE_ASPECT_STENCIL_BIT;
+            }
 
+            if (range.aspectMask) {
                 cmd_meta_clear_depth_stencil_image(cmdBuffer,
                         view->img, att->initial_layout,
                         clear_val->depthStencil.depth, clear_val->depthStencil.stencil,