layers: Merge Create{Non,}DispatchableObject in OT
Signed-off-by: Chris Forbes <chrisforbes@google.com>
diff --git a/layers/object_tracker.cpp b/layers/object_tracker.cpp
index a1f2307..1e9ed3e 100644
--- a/layers/object_tracker.cpp
+++ b/layers/object_tracker.cpp
@@ -243,40 +243,24 @@
}
template <typename T1, typename T2>
-static void CreateDispatchableObject(T1 dispatchable_object, T2 object, VkDebugReportObjectTypeEXT object_type, bool custom_allocator) {
+static void CreateObject(T1 dispatchable_object, T2 object, VkDebugReportObjectTypeEXT object_type, bool custom_allocator) {
layer_data *instance_data = get_my_data_ptr(get_dispatch_key(dispatchable_object), layer_data_map);
+ auto object_handle = reinterpret_cast<uint64_t &>(object);
- log_msg(instance_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, object_type, reinterpret_cast<uint64_t>(object),
+ log_msg(instance_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, object_type, object_handle,
__LINE__, OBJTRACK_NONE, LayerName, "OBJ[0x%" PRIxLEAST64 "] : CREATE %s object 0x%" PRIxLEAST64, object_track_index++,
- object_name[object_type], reinterpret_cast<uint64_t>(object));
+ object_name[object_type], object_handle);
OBJTRACK_NODE *pNewObjNode = new OBJTRACK_NODE;
pNewObjNode->object_type = object_type;
pNewObjNode->status = custom_allocator ? OBJSTATUS_CUSTOM_ALLOCATOR : OBJSTATUS_NONE;
- pNewObjNode->handle = reinterpret_cast<uint64_t>(object);
- instance_data->object_map[object_type][reinterpret_cast<uint64_t>(object)] = pNewObjNode;
+ pNewObjNode->handle = object_handle;
+ instance_data->object_map[object_type][object_handle] = pNewObjNode;
instance_data->num_objects[object_type]++;
instance_data->num_total_objects++;
}
template <typename T1, typename T2>
-static void CreateNonDispatchableObject(T1 dispatchable_object, T2 object, VkDebugReportObjectTypeEXT object_type, bool custom_allocator) {
- layer_data *device_data = get_my_data_ptr(get_dispatch_key(dispatchable_object), layer_data_map);
-
- log_msg(device_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, object_type, reinterpret_cast<uint64_t &>(object),
- __LINE__, OBJTRACK_NONE, LayerName, "OBJ[0x%" PRIxLEAST64 "] : CREATE %s object 0x%" PRIxLEAST64, object_track_index++,
- object_name[object_type], reinterpret_cast<uint64_t &>(object));
-
- OBJTRACK_NODE *pNewObjNode = new OBJTRACK_NODE;
- pNewObjNode->object_type = object_type;
- pNewObjNode->status = custom_allocator ? OBJSTATUS_CUSTOM_ALLOCATOR : OBJSTATUS_NONE;
- pNewObjNode->handle = reinterpret_cast<uint64_t &>(object);
- device_data->object_map[object_type][reinterpret_cast<uint64_t &>(object)] = pNewObjNode;
- device_data->num_objects[object_type]++;
- device_data->num_total_objects++;
-}
-
-template <typename T1, typename T2>
static void DestroyObject(T1 dispatchable_object, T2 object, VkDebugReportObjectTypeEXT object_type, bool custom_allocator) {
layer_data *device_data = get_my_data_ptr(get_dispatch_key(dispatchable_object), layer_data_map);
@@ -654,7 +638,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pMemory, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, pAllocator);
+ CreateObject(device, *pMemory, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, pAllocator);
}
}
return result;
@@ -826,7 +810,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pFence, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, pAllocator);
+ CreateObject(device, *pFence, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, pAllocator);
}
}
return result;
@@ -914,7 +898,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pSemaphore, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, pAllocator);
+ CreateObject(device, *pSemaphore, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, pAllocator);
}
}
return result;
@@ -951,7 +935,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pEvent, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, pAllocator);
+ CreateObject(device, *pEvent, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, pAllocator);
}
}
return result;
@@ -1030,7 +1014,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pQueryPool, VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, pAllocator);
+ CreateObject(device, *pQueryPool, VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, pAllocator);
}
}
return result;
@@ -1083,7 +1067,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, pAllocator);
+ CreateObject(device, *pBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, pAllocator);
}
}
return result;
@@ -1123,7 +1107,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pView, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT, pAllocator);
+ CreateObject(device, *pView, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT, pAllocator);
}
}
return result;
@@ -1160,7 +1144,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, pAllocator);
+ CreateObject(device, *pImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, pAllocator);
}
}
return result;
@@ -1214,7 +1198,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pView, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, pAllocator);
+ CreateObject(device, *pView, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, pAllocator);
}
}
return result;
@@ -1252,7 +1236,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pShaderModule, VK_DEBUG_REPORT_OBJECT_TYPE_SHADER_MODULE_EXT, pAllocator);
+ CreateObject(device, *pShaderModule, VK_DEBUG_REPORT_OBJECT_TYPE_SHADER_MODULE_EXT, pAllocator);
}
}
return result;
@@ -1291,7 +1275,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pPipelineCache, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_CACHE_EXT, pAllocator);
+ CreateObject(device, *pPipelineCache, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_CACHE_EXT, pAllocator);
}
}
return result;
@@ -1393,7 +1377,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pPipelineLayout, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_LAYOUT_EXT, pAllocator);
+ CreateObject(device, *pPipelineLayout, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_LAYOUT_EXT, pAllocator);
}
}
return result;
@@ -1431,7 +1415,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pSampler, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, pAllocator);
+ CreateObject(device, *pSampler, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, pAllocator);
}
}
return result;
@@ -1483,7 +1467,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pSetLayout, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, pAllocator);
+ CreateObject(device, *pSetLayout, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, pAllocator);
}
}
return result;
@@ -1523,7 +1507,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pDescriptorPool, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, pAllocator);
+ CreateObject(device, *pDescriptorPool, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, pAllocator);
}
}
return result;
@@ -1640,7 +1624,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pFramebuffer, VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT, pAllocator);
+ CreateObject(device, *pFramebuffer, VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT, pAllocator);
}
}
return result;
@@ -1678,7 +1662,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pRenderPass, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, pAllocator);
+ CreateObject(device, *pRenderPass, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, pAllocator);
}
}
return result;
@@ -1729,7 +1713,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pCommandPool, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT, pAllocator);
+ CreateObject(device, *pCommandPool, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT, pAllocator);
}
}
return result;
@@ -2646,7 +2630,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(device, *pSwapchain, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, pAllocator);
+ CreateObject(device, *pSwapchain, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, pAllocator);
}
}
return result;
@@ -2713,7 +2697,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(instance, *pSurface, VK_DEBUG_REPORT_OBJECT_TYPE_SURFACE_KHR_EXT, pAllocator);
+ CreateObject(instance, *pSurface, VK_DEBUG_REPORT_OBJECT_TYPE_SURFACE_KHR_EXT, pAllocator);
}
}
return result;
@@ -2752,7 +2736,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(instance, *pSurface, VK_DEBUG_REPORT_OBJECT_TYPE_SURFACE_KHR_EXT, pAllocator);
+ CreateObject(instance, *pSurface, VK_DEBUG_REPORT_OBJECT_TYPE_SURFACE_KHR_EXT, pAllocator);
}
}
return result;
@@ -2792,7 +2776,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(instance, *pSurface, VK_DEBUG_REPORT_OBJECT_TYPE_SURFACE_KHR_EXT, pAllocator);
+ CreateObject(instance, *pSurface, VK_DEBUG_REPORT_OBJECT_TYPE_SURFACE_KHR_EXT, pAllocator);
}
}
return result;
@@ -2832,7 +2816,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(instance, *pSurface, VK_DEBUG_REPORT_OBJECT_TYPE_SURFACE_KHR_EXT, pAllocator);
+ CreateObject(instance, *pSurface, VK_DEBUG_REPORT_OBJECT_TYPE_SURFACE_KHR_EXT, pAllocator);
}
}
return result;
@@ -2871,7 +2855,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(instance, *pSurface, VK_DEBUG_REPORT_OBJECT_TYPE_SURFACE_KHR_EXT, pAllocator);
+ CreateObject(instance, *pSurface, VK_DEBUG_REPORT_OBJECT_TYPE_SURFACE_KHR_EXT, pAllocator);
}
}
return result;
@@ -2911,7 +2895,7 @@
{
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
- CreateNonDispatchableObject(instance, *pSurface, VK_DEBUG_REPORT_OBJECT_TYPE_SURFACE_KHR_EXT, pAllocator);
+ CreateObject(instance, *pSurface, VK_DEBUG_REPORT_OBJECT_TYPE_SURFACE_KHR_EXT, pAllocator);
}
}
return result;
@@ -2945,7 +2929,7 @@
std::lock_guard<std::mutex> lock(global_lock);
if (result == VK_SUCCESS) {
for (i = 0; i < swapchainCount; i++) {
- CreateNonDispatchableObject(device, pSwapchains[i], VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, pAllocator);
+ CreateObject(device, pSwapchains[i], VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, pAllocator);
}
}
}
@@ -2961,7 +2945,7 @@
if (VK_SUCCESS == result) {
layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map);
result = layer_create_msg_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pCallback);
- CreateNonDispatchableObject(instance, *pCallback, VK_DEBUG_REPORT_OBJECT_TYPE_DEBUG_REPORT_EXT, pAllocator);
+ CreateObject(instance, *pCallback, VK_DEBUG_REPORT_OBJECT_TYPE_DEBUG_REPORT_EXT, pAllocator);
}
return result;
}
@@ -3168,7 +3152,7 @@
initDeviceTable(*pDevice, fpGetDeviceProcAddr, ot_device_table_map);
CheckDeviceRegisterExtensions(pCreateInfo, *pDevice);
- CreateDispatchableObject(*pDevice, *pDevice, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, pAllocator);
+ CreateObject(*pDevice, *pDevice, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, pAllocator);
return result;
}
@@ -3222,7 +3206,7 @@
InitObjectTracker(instance_data, pAllocator);
CheckInstanceRegisterExtensions(pCreateInfo, *pInstance);
- CreateDispatchableObject(*pInstance, *pInstance, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, pAllocator);
+ CreateObject(*pInstance, *pInstance, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, pAllocator);
return result;
}
@@ -3242,7 +3226,7 @@
if (result == VK_SUCCESS) {
if (pPhysicalDevices) {
for (uint32_t i = 0; i < *pPhysicalDeviceCount; i++) {
- CreateDispatchableObject(instance, pPhysicalDevices[i], VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, false);
+ CreateObject(instance, pPhysicalDevices[i], VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, false);
}
}
}
@@ -3562,7 +3546,7 @@
lock.lock();
if (result == VK_SUCCESS) {
for (uint32_t idx2 = 0; idx2 < createInfoCount; ++idx2) {
- CreateNonDispatchableObject(device, pPipelines[idx2], VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, pAllocator);
+ CreateObject(device, pPipelines[idx2], VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, pAllocator);
}
}
lock.unlock();
@@ -3603,7 +3587,7 @@
lock.lock();
if (result == VK_SUCCESS) {
for (uint32_t idx1 = 0; idx1 < createInfoCount; ++idx1) {
- CreateNonDispatchableObject(device, pPipelines[idx1], VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, pAllocator);
+ CreateObject(device, pPipelines[idx1], VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, pAllocator);
}
}
lock.unlock();