blob: 1f03b160c7547df0fe751c2b9c72daed92664f80 [file] [log] [blame]
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001/*
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002 *
Courtney Goeltzenleuchter8a17da52015-10-29 13:50:34 -06003 * Copyright (C) 2015 Valve Corporation
Michael Lentine329697b2015-10-06 14:56:18 -07004 * Copyright (C) 2015 Google, Inc.
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005 *
6 * Permission is hereby granted, free of charge, to any person obtaining a
7 * copy of this software and associated documentation files (the "Software"),
8 * to deal in the Software without restriction, including without limitation
9 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
10 * and/or sell copies of the Software, and to permit persons to whom the
11 * Software is furnished to do so, subject to the following conditions:
12 *
13 * The above copyright notice and this permission notice shall be included
14 * in all copies or substantial portions of the Software.
15 *
16 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
19 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
21 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
22 * DEALINGS IN THE SOFTWARE.
Courtney Goeltzenleuchter96cd7952015-10-30 11:14:30 -060023 *
24 * Author: Cody Northrop <cody@lunarg.com>
25 * Author: Michael Lentine <mlentine@google.com>
26 * Author: Tobin Ehlis <tobin@lunarg.com>
Tobin Ehlis63bb9482015-03-17 16:24:32 -060027 */
28
29#include <stdio.h>
30#include <stdlib.h>
31#include <string.h>
Michael Lentine329697b2015-10-06 14:56:18 -070032#include <algorithm>
33#include <memory>
Tobin Ehlis63bb9482015-03-17 16:24:32 -060034#include <unordered_map>
Michael Lentine329697b2015-10-06 14:56:18 -070035#include <unordered_set>
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -070036#include <list>
Tobin Ehlis63bb9482015-03-17 16:24:32 -060037
Tobin Ehlis7a51d902015-07-03 10:34:49 -060038#include "vk_loader_platform.h"
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -060039#include "vk_dispatch_table_helper.h"
40#include "vk_struct_string_helper_cpp.h"
Tony Barboura938abb2015-04-22 11:36:22 -060041#if defined(__GNUC__)
Tobin Ehlis63bb9482015-03-17 16:24:32 -060042#pragma GCC diagnostic ignored "-Wwrite-strings"
Tony Barboura938abb2015-04-22 11:36:22 -060043#endif
Tony Barboura938abb2015-04-22 11:36:22 -060044#if defined(__GNUC__)
Tobin Ehlis63bb9482015-03-17 16:24:32 -060045#pragma GCC diagnostic warning "-Wwrite-strings"
Tony Barboura938abb2015-04-22 11:36:22 -060046#endif
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -060047#include "vk_struct_size_helper.h"
Tobin Ehlis63bb9482015-03-17 16:24:32 -060048#include "draw_state.h"
Tobin Ehlis56d204a2015-07-03 10:15:26 -060049#include "vk_layer_config.h"
Michael Lentine8469dd62015-11-20 09:48:52 -080050#include "vulkan/vk_debug_marker_layer.h"
Tobin Ehlis56d204a2015-07-03 10:15:26 -060051#include "vk_layer_table.h"
52#include "vk_layer_debug_marker_table.h"
53#include "vk_layer_data.h"
54#include "vk_layer_logging.h"
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -060055#include "vk_layer_extension_utils.h"
Tobin Ehlisb46be812015-10-23 16:00:08 -060056#include "vk_layer_utils.h"
Tobin Ehlis63bb9482015-03-17 16:24:32 -060057
Mark Lobodzinski78940a42015-11-30 16:48:53 -070058// This definition controls whether image layout transitions are enabled/disabled.
59// disable until corner cases are fixed
60#define DISABLE_IMAGE_LAYOUT_VALIDATION
61
Tobin Ehlise6ab55a2015-10-07 09:38:40 -060062struct devExts {
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -070063 VkBool32 debug_marker_enabled;
Michael Lentine27b0f902015-10-12 11:30:14 -050064 VkBool32 wsi_enabled;
65 unordered_map<VkSwapchainKHR, SWAPCHAIN_NODE*> swapchainMap;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -060066};
67
Cody Northrop73bb6572015-09-28 15:09:32 -060068struct layer_data {
Tobin Ehlisc91330b2015-06-16 09:04:30 -060069 debug_report_data *report_data;
70 // TODO: put instance data here
Courtney Goeltzenleuchter1781b1c2015-10-05 15:58:38 -060071 std::vector<VkDbgMsgCallback> logging_callback;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -060072 VkLayerDispatchTable* device_dispatch_table;
73 VkLayerInstanceDispatchTable* instance_dispatch_table;
74 devExts device_extensions;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -060075 // Layer specific data
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -070076 unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> sampleMap;
77 unordered_map<VkImageView, unique_ptr<VkImageViewCreateInfo>> imageViewMap;
78 unordered_map<VkImage, unique_ptr<VkImageCreateInfo>> imageMap;
79 unordered_map<VkBufferView, unique_ptr<VkBufferViewCreateInfo>> bufferViewMap;
80 unordered_map<VkBuffer, unique_ptr<VkBufferCreateInfo>> bufferMap;
81 unordered_map<VkPipeline, PIPELINE_NODE*> pipelineMap;
82 unordered_map<VkCommandPool, list<VkCommandBuffer>> commandPoolMap;
83 unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE*> descriptorPoolMap;
84 unordered_map<VkDescriptorSet, SET_NODE*> setMap;
85 unordered_map<VkDescriptorSetLayout, LAYOUT_NODE*> layoutMap;
86 unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap;
87 unordered_map<VkDeviceMemory, VkImage> memImageMap;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -060088 // Map for layout chains
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -070089 unordered_map<void*, GLOBAL_CB_NODE*> commandBufferMap;
90 unordered_map<VkFramebuffer, VkFramebufferCreateInfo*> frameBufferMap;
91 unordered_map<VkImage, IMAGE_NODE*> imageLayoutMap;
92 unordered_map<VkRenderPass, RENDER_PASS_NODE*> renderPassMap;
Michael Lentine27b0f902015-10-12 11:30:14 -050093 // Current render pass
94 VkRenderPassBeginInfo renderPassBeginInfo;
95 uint32_t currentSubpass;
Cody Northrop73bb6572015-09-28 15:09:32 -060096
97 layer_data() :
98 report_data(nullptr),
Tobin Ehlise6ab55a2015-10-07 09:38:40 -060099 device_dispatch_table(nullptr),
100 instance_dispatch_table(nullptr),
101 device_extensions()
Cody Northrop73bb6572015-09-28 15:09:32 -0600102 {};
103};
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600104// TODO : Do we need to guard access to layer_data_map w/ lock?
Tobin Ehlisc91330b2015-06-16 09:04:30 -0600105static std::unordered_map<void *, layer_data *> layer_data_map;
Courtney Goeltzenleuchterc280adc2015-06-13 21:23:09 -0600106
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600107static LOADER_PLATFORM_THREAD_ONCE_DECLARATION(g_initOnce);
Jon Ashburnd9564002015-05-07 10:27:37 -0600108
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600109// TODO : This can be much smarter, using separate locks for separate global data
110static int globalLockInitialized = 0;
111static loader_platform_thread_mutex globalLock;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600112#define MAX_TID 513
113static loader_platform_thread_id g_tidMapping[MAX_TID] = {0};
114static uint32_t g_maxTID = 0;
Tobin Ehlisfde4dce2015-06-16 15:50:44 -0600115
116template layer_data *get_my_data_ptr<layer_data>(
117 void *data_key,
118 std::unordered_map<void *, layer_data *> &data_map);
119
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600120// Map actual TID to an index value and return that index
121// This keeps TIDs in range from 0-MAX_TID and simplifies compares between runs
122static uint32_t getTIDIndex() {
123 loader_platform_thread_id tid = loader_platform_get_thread_id();
124 for (uint32_t i = 0; i < g_maxTID; i++) {
125 if (tid == g_tidMapping[i])
126 return i;
127 }
128 // Don't yet have mapping, set it and return newly set index
129 uint32_t retVal = (uint32_t) g_maxTID;
130 g_tidMapping[g_maxTID++] = tid;
131 assert(g_maxTID < MAX_TID);
132 return retVal;
133}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700134
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600135// Return a string representation of CMD_TYPE enum
136static string cmdTypeToString(CMD_TYPE cmd)
137{
138 switch (cmd)
139 {
140 case CMD_BINDPIPELINE:
141 return "CMD_BINDPIPELINE";
142 case CMD_BINDPIPELINEDELTA:
143 return "CMD_BINDPIPELINEDELTA";
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -0600144 case CMD_SETVIEWPORTSTATE:
145 return "CMD_SETVIEWPORTSTATE";
146 case CMD_SETLINEWIDTHSTATE:
147 return "CMD_SETLINEWIDTHSTATE";
148 case CMD_SETDEPTHBIASSTATE:
149 return "CMD_SETDEPTHBIASSTATE";
150 case CMD_SETBLENDSTATE:
151 return "CMD_SETBLENDSTATE";
152 case CMD_SETDEPTHBOUNDSSTATE:
153 return "CMD_SETDEPTHBOUNDSSTATE";
154 case CMD_SETSTENCILREADMASKSTATE:
155 return "CMD_SETSTENCILREADMASKSTATE";
156 case CMD_SETSTENCILWRITEMASKSTATE:
157 return "CMD_SETSTENCILWRITEMASKSTATE";
158 case CMD_SETSTENCILREFERENCESTATE:
159 return "CMD_SETSTENCILREFERENCESTATE";
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600160 case CMD_BINDDESCRIPTORSETS:
161 return "CMD_BINDDESCRIPTORSETS";
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600162 case CMD_BINDINDEXBUFFER:
163 return "CMD_BINDINDEXBUFFER";
164 case CMD_BINDVERTEXBUFFER:
165 return "CMD_BINDVERTEXBUFFER";
166 case CMD_DRAW:
167 return "CMD_DRAW";
168 case CMD_DRAWINDEXED:
169 return "CMD_DRAWINDEXED";
170 case CMD_DRAWINDIRECT:
171 return "CMD_DRAWINDIRECT";
172 case CMD_DRAWINDEXEDINDIRECT:
173 return "CMD_DRAWINDEXEDINDIRECT";
174 case CMD_DISPATCH:
175 return "CMD_DISPATCH";
176 case CMD_DISPATCHINDIRECT:
177 return "CMD_DISPATCHINDIRECT";
178 case CMD_COPYBUFFER:
179 return "CMD_COPYBUFFER";
180 case CMD_COPYIMAGE:
181 return "CMD_COPYIMAGE";
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600182 case CMD_BLITIMAGE:
183 return "CMD_BLITIMAGE";
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600184 case CMD_COPYBUFFERTOIMAGE:
185 return "CMD_COPYBUFFERTOIMAGE";
186 case CMD_COPYIMAGETOBUFFER:
187 return "CMD_COPYIMAGETOBUFFER";
188 case CMD_CLONEIMAGEDATA:
189 return "CMD_CLONEIMAGEDATA";
190 case CMD_UPDATEBUFFER:
191 return "CMD_UPDATEBUFFER";
192 case CMD_FILLBUFFER:
193 return "CMD_FILLBUFFER";
194 case CMD_CLEARCOLORIMAGE:
195 return "CMD_CLEARCOLORIMAGE";
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -0600196 case CMD_CLEARATTACHMENTS:
Tobin Ehlis8cd650e2015-07-01 16:46:13 -0600197 return "CMD_CLEARCOLORATTACHMENT";
198 case CMD_CLEARDEPTHSTENCILIMAGE:
199 return "CMD_CLEARDEPTHSTENCILIMAGE";
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600200 case CMD_RESOLVEIMAGE:
201 return "CMD_RESOLVEIMAGE";
202 case CMD_SETEVENT:
203 return "CMD_SETEVENT";
204 case CMD_RESETEVENT:
205 return "CMD_RESETEVENT";
206 case CMD_WAITEVENTS:
207 return "CMD_WAITEVENTS";
208 case CMD_PIPELINEBARRIER:
209 return "CMD_PIPELINEBARRIER";
210 case CMD_BEGINQUERY:
211 return "CMD_BEGINQUERY";
212 case CMD_ENDQUERY:
213 return "CMD_ENDQUERY";
214 case CMD_RESETQUERYPOOL:
215 return "CMD_RESETQUERYPOOL";
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -0600216 case CMD_COPYQUERYPOOLRESULTS:
217 return "CMD_COPYQUERYPOOLRESULTS";
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600218 case CMD_WRITETIMESTAMP:
219 return "CMD_WRITETIMESTAMP";
220 case CMD_INITATOMICCOUNTERS:
221 return "CMD_INITATOMICCOUNTERS";
222 case CMD_LOADATOMICCOUNTERS:
223 return "CMD_LOADATOMICCOUNTERS";
224 case CMD_SAVEATOMICCOUNTERS:
225 return "CMD_SAVEATOMICCOUNTERS";
226 case CMD_BEGINRENDERPASS:
227 return "CMD_BEGINRENDERPASS";
228 case CMD_ENDRENDERPASS:
229 return "CMD_ENDRENDERPASS";
230 case CMD_DBGMARKERBEGIN:
231 return "CMD_DBGMARKERBEGIN";
232 case CMD_DBGMARKEREND:
233 return "CMD_DBGMARKEREND";
234 default:
235 return "UNKNOWN";
236 }
237}
238// Block of code at start here for managing/tracking Pipeline state that this layer cares about
239// Just track 2 shaders for now
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600240#define MAX_SLOTS 2048
241#define NUM_COMMAND_BUFFERS_TO_DISPLAY 10
242
243static uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0};
244
Chia-I Wu1f851912015-10-27 18:04:07 +0800245// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600246// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates
247// to that same cmd buffer by separate thread are not changing state from underneath us
248// Track the last cmd buffer touched by this thread
Chia-I Wu1f851912015-10-27 18:04:07 +0800249static VkCommandBuffer g_lastCommandBuffer[MAX_TID] = {NULL};
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600250// Track the last group of CBs touched for displaying to dot file
Tobin Ehlis1dce5f12015-07-07 10:42:20 -0600251static GLOBAL_CB_NODE* g_pLastTouchedCB[NUM_COMMAND_BUFFERS_TO_DISPLAY] = {NULL};
252static uint32_t g_lastTouchedCBIndex = 0;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600253// Track the last global DrawState of interest touched by any thread
Tobin Ehlis1dce5f12015-07-07 10:42:20 -0600254static GLOBAL_CB_NODE* g_lastGlobalCB = NULL;
255static PIPELINE_NODE* g_lastBoundPipeline = NULL;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600256#define MAX_BINDING 0xFFFFFFFF // Default vtxBinding value in CB Node to identify if no vtxBinding set
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600257// prototype
Chia-I Wu1f851912015-10-27 18:04:07 +0800258static GLOBAL_CB_NODE* getCBNode(layer_data*, const VkCommandBuffer);
Tobin Ehlis982099b2015-11-05 09:52:49 -0700259
Chia-I Wu1f851912015-10-27 18:04:07 +0800260// Update global ptrs to reflect that specified commandBuffer has been used
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600261static void updateCBTracking(GLOBAL_CB_NODE* pCB)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600262{
Chia-I Wu1f851912015-10-27 18:04:07 +0800263 g_lastCommandBuffer[getTIDIndex()] = pCB->commandBuffer;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600264 loader_platform_thread_lock_mutex(&globalLock);
265 g_lastGlobalCB = pCB;
266 // TODO : This is a dumb algorithm. Need smart LRU that drops off oldest
267 for (uint32_t i = 0; i < NUM_COMMAND_BUFFERS_TO_DISPLAY; i++) {
268 if (g_pLastTouchedCB[i] == pCB) {
269 loader_platform_thread_unlock_mutex(&globalLock);
270 return;
271 }
272 }
273 g_pLastTouchedCB[g_lastTouchedCBIndex++] = pCB;
274 g_lastTouchedCBIndex = g_lastTouchedCBIndex % NUM_COMMAND_BUFFERS_TO_DISPLAY;
275 loader_platform_thread_unlock_mutex(&globalLock);
276}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700277
Courtney Goeltzenleuchter1f41f542015-07-09 11:44:38 -0600278static VkBool32 hasDrawCmd(GLOBAL_CB_NODE* pCB)
Tobin Ehlis8cd650e2015-07-01 16:46:13 -0600279{
280 for (uint32_t i=0; i<NUM_DRAW_TYPES; i++) {
281 if (pCB->drawCount[i])
282 return VK_TRUE;
283 }
284 return VK_FALSE;
285}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700286
Tobin Ehlis97866202015-06-10 12:57:07 -0600287// Check object status for selected flag state
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600288static VkBool32 validate_status(layer_data* my_data, GLOBAL_CB_NODE* pNode, CBStatusFlags enable_mask, CBStatusFlags status_mask, CBStatusFlags status_flag, VkFlags msg_flags, DRAW_STATE_ERROR error_code, const char* fail_msg)
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -0600289{
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600290 // If non-zero enable mask is present, check it against status but if enable_mask
291 // is 0 then no enable required so we should always just check status
292 if ((!enable_mask) || (enable_mask & pNode->status)) {
293 if ((pNode->status & status_mask) != status_flag) {
Tobin Ehlis1dce5f12015-07-07 10:42:20 -0600294 // TODO : How to pass dispatchable objects as srcObject? Here src obj should be cmd buffer
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600295 return log_msg(my_data->report_data, msg_flags, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, error_code, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +0800296 "CB object %#" PRIxLEAST64 ": %s", reinterpret_cast<uint64_t>(pNode->commandBuffer), fail_msg);
Tobin Ehlis97866202015-06-10 12:57:07 -0600297 }
Tobin Ehlis97866202015-06-10 12:57:07 -0600298 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600299 return VK_FALSE;
Tobin Ehlis97866202015-06-10 12:57:07 -0600300}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700301
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600302// Retrieve pipeline node ptr for given pipeline object
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600303static PIPELINE_NODE* getPipeline(layer_data* my_data, const VkPipeline pipeline)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600304{
305 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +0800306 if (my_data->pipelineMap.find(pipeline) == my_data->pipelineMap.end()) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600307 loader_platform_thread_unlock_mutex(&globalLock);
308 return NULL;
309 }
310 loader_platform_thread_unlock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +0800311 return my_data->pipelineMap[pipeline];
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600312}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700313
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600314// Return VK_TRUE if for a given PSO, the given state enum is dynamic, else return VK_FALSE
315static VkBool32 isDynamic(const PIPELINE_NODE* pPipeline, const VkDynamicState state)
316{
317 if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) {
318 for (uint32_t i=0; i<pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) {
319 if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i])
320 return VK_TRUE;
321 }
322 }
323 return VK_FALSE;
324}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700325
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600326// Validate state stored as flags at time of draw call
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600327static VkBool32 validate_draw_state_flags(layer_data* my_data, GLOBAL_CB_NODE* pCB, VkBool32 indexedDraw) {
Courtney Goeltzenleuchter1f41f542015-07-09 11:44:38 -0600328 VkBool32 result;
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600329 result = validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_VIEWPORT_SET, CBSTATUS_VIEWPORT_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_VIEWPORT_NOT_BOUND, "Dynamic viewport state not set for this command buffer");
Cody Northrop22cba2c2015-10-27 13:15:41 -0600330 result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_SCISSOR_SET, CBSTATUS_SCISSOR_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_SCISSOR_NOT_BOUND, "Dynamic scissor state not set for this command buffer");
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600331 result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_LINE_WIDTH_SET, CBSTATUS_LINE_WIDTH_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer");
332 result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_DEPTH_BIAS_SET, CBSTATUS_DEPTH_BIAS_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer");
333 result |= validate_status(my_data, pCB, CBSTATUS_COLOR_BLEND_WRITE_ENABLE, CBSTATUS_BLEND_SET, CBSTATUS_BLEND_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend object state not set for this command buffer");
334 result |= validate_status(my_data, pCB, CBSTATUS_DEPTH_WRITE_ENABLE, CBSTATUS_DEPTH_BOUNDS_SET, CBSTATUS_DEPTH_BOUNDS_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer");
335 result |= validate_status(my_data, pCB, CBSTATUS_STENCIL_TEST_ENABLE, CBSTATUS_STENCIL_READ_MASK_SET, CBSTATUS_STENCIL_READ_MASK_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer");
336 result |= validate_status(my_data, pCB, CBSTATUS_STENCIL_TEST_ENABLE, CBSTATUS_STENCIL_WRITE_MASK_SET, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer");
337 result |= validate_status(my_data, pCB, CBSTATUS_STENCIL_TEST_ENABLE, CBSTATUS_STENCIL_REFERENCE_SET, CBSTATUS_STENCIL_REFERENCE_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer");
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600338 if (indexedDraw)
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600339 result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_INDEX_BUFFER_BOUND, CBSTATUS_INDEX_BUFFER_BOUND, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_INDEX_BUFFER_NOT_BOUND, "Index buffer object not bound to this command buffer when Indexed Draw attempted");
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600340 return result;
341}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700342
343// For give SET_NODE, verify that its Set is compatible w/ the setLayout corresponding to pipelineLayout[layoutIndex]
344static bool verify_set_layout_compatibility(layer_data* my_data, const SET_NODE* pSet, const VkPipelineLayout layout, const uint32_t layoutIndex, string& errorMsg)
345{
Tobin Ehliscb085292015-12-01 09:57:09 -0700346 stringstream errorStr;
Tobin Ehlis982099b2015-11-05 09:52:49 -0700347 if (my_data->pipelineLayoutMap.find(layout) == my_data->pipelineLayoutMap.end()) {
Tobin Ehliscb085292015-12-01 09:57:09 -0700348 errorStr << "invalid VkPipelineLayout (" << layout << ")";
349 errorMsg = errorStr.str();
Tobin Ehlis982099b2015-11-05 09:52:49 -0700350 return false;
351 }
352 PIPELINE_LAYOUT_NODE pl = my_data->pipelineLayoutMap[layout];
353 if (layoutIndex >= pl.descriptorSetLayouts.size()) {
Tobin Ehliscb085292015-12-01 09:57:09 -0700354 errorStr << "VkPipelineLayout (" << layout << ") only contains " << pl.descriptorSetLayouts.size() << " setLayouts corresponding to sets 0-" << pl.descriptorSetLayouts.size()-1 << ", but you're attempting to bind set to index " << layoutIndex;
355 errorMsg = errorStr.str();
Tobin Ehlis982099b2015-11-05 09:52:49 -0700356 return false;
357 }
358 // Get the specific setLayout from PipelineLayout that overlaps this set
359 LAYOUT_NODE* pLayoutNode = my_data->layoutMap[pl.descriptorSetLayouts[layoutIndex]];
360 if (pLayoutNode->layout == pSet->pLayout->layout) { // trivial pass case
361 return true;
362 }
363 uint32_t descriptorCount = pLayoutNode->descriptorTypes.size();
364 if (descriptorCount != pSet->pLayout->descriptorTypes.size()) {
Tobin Ehliscb085292015-12-01 09:57:09 -0700365 errorStr << "setLayout " << layoutIndex << " from pipelineLayout " << layout << " has " << descriptorCount << " descriptors, but corresponding set being bound has " << pSet->pLayout->descriptorTypes.size() << " descriptors.";
366 errorMsg = errorStr.str();
Tobin Ehlis982099b2015-11-05 09:52:49 -0700367 return false; // trivial fail case
368 }
369 // Now need to check set against corresponding pipelineLayout to verify compatibility
370 for (uint32_t i=0; i<descriptorCount; ++i) {
371 // Need to verify that layouts are identically defined
372 // TODO : Is below sufficient? Making sure that types & stageFlags match per descriptor
373 // do we also need to check immutable samplers?
374 if (pLayoutNode->descriptorTypes[i] != pSet->pLayout->descriptorTypes[i]) {
Tobin Ehliscb085292015-12-01 09:57:09 -0700375 errorStr << "descriptor " << i << " for descriptorSet being bound is type '" << string_VkDescriptorType(pSet->pLayout->descriptorTypes[i]) << "' but corresponding descriptor from pipelineLayout is type '" << string_VkDescriptorType(pLayoutNode->descriptorTypes[i]) << "'";
376 errorMsg = errorStr.str();
Tobin Ehlis982099b2015-11-05 09:52:49 -0700377 return false;
378 }
379 if (pLayoutNode->stageFlags[i] != pSet->pLayout->stageFlags[i]) {
Tobin Ehliscb085292015-12-01 09:57:09 -0700380 errorStr << "stageFlags " << i << " for descriptorSet being bound is " << pSet->pLayout->stageFlags[i] << "' but corresponding descriptor from pipelineLayout has stageFlags " << pLayoutNode->stageFlags[i];
381 errorMsg = errorStr.str();
Tobin Ehlis982099b2015-11-05 09:52:49 -0700382 return false;
383 }
384 }
385 return true;
386}
387
388// Check if given pipeline layouts are compatible from set 0 up through descriptorSet numDescriptorSets-1
389//static VkBool32 validate_pipeline_layout_compatibility(layer_data* my_data, const VkPipelineLayout psoLayout, const VkPipelineLayout dsLayout, const uint32_t numDescriptorSets)
390//{
391// VkBool32 skipCall = VK_FALSE;
392// // Handle trivial case of same pipeline layouts, which are obviously compatible
393// if (psoLayout == dsLayout)
394// return skipCall;
395// // Check for trivial fail cases
396// if (my_data->pipelineLayoutMap.find(psoLayout) == my_data->pipelineLayoutMap.end()) {
397// skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE_LAYOUT, (uint64_t) psoLayout, 0, DRAWSTATE_INVALID_PIPELINE_LAYOUT, "DS",
398// "PSO bound invalid pipelineLayout object %#" PRIxLEAST64, (uint64_t) psoLayout);
399//// skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE_LAYOUT, psoLayout, 0, DRAWSTATE_INVALID_PIPELINE_LAYOUT, "DS",
400//// "Created Descriptor Pool %#" PRIxLEAST64, (uint64_t) psoLayout);
401// //"PSO bound invalid pipelineLayout object %#" PRIxLEAST64, (uint64_t) psoLayout);
402// }
403// if (my_data->pipelineLayoutMap.find(dsLayout) == my_data->pipelineLayoutMap.end()) {
404// skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE_LAYOUT, (uint64_t) dsLayout, 0, DRAWSTATE_INVALID_PIPELINE_LAYOUT, "DS",
405// "Invalid pipelineLayout object (%#" PRIxLEAST64 ") bound at last vkCmdBindDescriptorSets() call.", (uint64_t) dsLayout);
406// }
407// if (skipCall) // If we hit fail case above, return early to avoid crash
408// return skipCall;
409// // Two pipeline layouts are defined to be "compatible for set N" if they were created with matching
410// // (the same, or identically defined) descriptor set layouts for sets zero through N.
411// PIPELINE_LAYOUT_NODE psoPL = my_data->pipelineLayoutMap[psoLayout];
412// PIPELINE_LAYOUT_NODE dsPL = my_data->pipelineLayoutMap[dsLayout];
413// // If either pipelineLayout doesn't have enough layouts, they can't be compatible
414// if (numDescriptorSets > psoPL.descriptorSetLayouts.size()) {
415// skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE_LAYOUT, (uint64_t) dsLayout, 0, DRAWSTATE_INVALID_PIPELINE_LAYOUT, "DS",
416// "Invalid pipelineLayout object (%#" PRIxLEAST64 ") bound at last vkCmdBindDescriptorSets() call.", (uint64_t) dsLayout);
417// }
418// if (numDescriptorSets > dsPL.descriptorSetLayouts.size()) {
419// // Not enough layouts, can't be compatible
420// }
421// // Now check each matching layout to confirm compatibility
422// LAYOUT_NODE *pPSOLayout, *pDSLayout;
423// for (uint32_t i=0; i<numDescriptorSets; ++i) {
424// pPSOLayout = my_data->layoutMap[psoPL.descriptorSetLayouts[i]];
425// pDSLayout = my_data->layoutMap[dsPL.descriptorSetLayouts[i]];
426// if (pPSOLayout == pDSLayout)
427// continue;
428// if (pPSOLayout->descriptorTypes.size() != pDSLayout->descriptorTypes.size()) {
429// // ERROR : different sizes in layouts
430// }
431// // Need to verify that layouts are identically defined
432// // TODO : Is below sufficient? Making sure that types & stageFlags match per descriptor
433// for (uint32_t j=0; j<pPSOLayout->descriptorTypes.size(); ++j) {
434// if (pPSOLayout->descriptorTypes[j] != pDSLayout->descriptorTypes[j]) {
435// // ERROR : Report type mismatch
436// }
437// if (pPSOLayout->stageFlags[j] != pDSLayout->stageFlags[j]) {
438// // ERROR : Report flags mismatch
439// }
440// }
441// }
442// return skipCall;
443//}
444
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600445// Validate overall state at the time of a draw call
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600446static VkBool32 validate_draw_state(layer_data* my_data, GLOBAL_CB_NODE* pCB, VkBool32 indexedDraw) {
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600447 // First check flag states
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600448 VkBool32 result = validate_draw_state_flags(my_data, pCB, indexedDraw);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600449 PIPELINE_NODE* pPipe = getPipeline(my_data, pCB->lastBoundPipeline);
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600450 // Now complete other state checks
Tobin Ehlis12ab7dc2015-09-09 13:31:01 -0600451 // TODO : Currently only performing next check if *something* was bound (non-zero last bound)
452 // There is probably a better way to gate when this check happens, and to know if something *should* have been bound
453 // We should have that check separately and then gate this check based on that check
Tobin Ehlis982099b2015-11-05 09:52:49 -0700454 if (pPipe && (pCB->lastBoundPipelineLayout)) {
455 // TODO : For all sets used by the PSO, need to make sure that something is bound AND that PSO pipelineLayout is compatible with each bound set
456 // first trick is how to get the sets used by PSO. ShaderChecker does this so perhaps move that code to utils
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600457 }
Tobin Ehlisd28acef2015-09-09 15:12:35 -0600458 // Verify Vtx binding
459 if (MAX_BINDING != pCB->lastVtxBinding) {
460 if (pCB->lastVtxBinding >= pPipe->vtxBindingCount) {
461 if (0 == pPipe->vtxBindingCount) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600462 result |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS",
Tobin Ehlisd28acef2015-09-09 15:12:35 -0600463 "Vtx Buffer Index %u was bound, but no vtx buffers are attached to PSO.", pCB->lastVtxBinding);
Tobin Ehlisd28acef2015-09-09 15:12:35 -0600464 }
465 else {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600466 result |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS",
Tobin Ehlisd28acef2015-09-09 15:12:35 -0600467 "Vtx binding Index of %u exceeds PSO pVertexBindingDescriptions max array index of %u.", pCB->lastVtxBinding, (pPipe->vtxBindingCount - 1));
Tobin Ehlisd28acef2015-09-09 15:12:35 -0600468 }
469 }
470 }
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600471 // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count
472 VkBool32 dynViewport = isDynamic(pPipe, VK_DYNAMIC_STATE_VIEWPORT);
473 VkBool32 dynScissor = isDynamic(pPipe, VK_DYNAMIC_STATE_SCISSOR);
474 if (dynViewport) {
475 if (pCB->viewports.size() != pPipe->graphicsPipelineCI.pViewportState->viewportCount) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600476 result |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Mark Lobodzinski2adea752015-11-10 15:25:01 -0700477 "Dynamic viewportCount from vkCmdSetViewport() is " PRINTF_SIZE_T_SPECIFIER ", but PSO viewportCount is %u. These counts must match.",
478 pCB->viewports.size(), pPipe->graphicsPipelineCI.pViewportState->viewportCount);
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600479 }
480 }
481 if (dynScissor) {
482 if (pCB->scissors.size() != pPipe->graphicsPipelineCI.pViewportState->scissorCount) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600483 result |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Mark Lobodzinski2adea752015-11-10 15:25:01 -0700484 "Dynamic scissorCount from vkCmdSetScissor() is " PRINTF_SIZE_T_SPECIFIER ", but PSO scissorCount is %u. These counts must match.",
485 pCB->scissors.size(), pPipe->graphicsPipelineCI.pViewportState->scissorCount);
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600486 }
487 }
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600488 return result;
489}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700490
Tobin Ehlisde63c532015-06-18 15:59:33 -0600491// Verify that create state for a pipeline is valid
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600492static VkBool32 verifyPipelineCreateState(layer_data* my_data, const VkDevice device, const PIPELINE_NODE* pPipeline)
Tobin Ehlisde63c532015-06-18 15:59:33 -0600493{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600494 VkBool32 skipCall = VK_FALSE;
Tobin Ehlisde63c532015-06-18 15:59:33 -0600495 // VS is required
496 if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600497 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Tobin Ehlisde63c532015-06-18 15:59:33 -0600498 "Invalid Pipeline CreateInfo State: Vtx Shader required");
Tobin Ehlisde63c532015-06-18 15:59:33 -0600499 }
500 // Either both or neither TC/TE shaders should be defined
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -0600501 if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) !=
502 ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0) ) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600503 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Tobin Ehlisde63c532015-06-18 15:59:33 -0600504 "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair");
Tobin Ehlisde63c532015-06-18 15:59:33 -0600505 }
506 // Compute shaders should be specified independent of Gfx shaders
507 if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) &&
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -0600508 (pPipeline->active_shaders & (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT |
509 VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | VK_SHADER_STAGE_GEOMETRY_BIT |
Tobin Ehlisde63c532015-06-18 15:59:33 -0600510 VK_SHADER_STAGE_FRAGMENT_BIT))) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600511 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Tobin Ehlisde63c532015-06-18 15:59:33 -0600512 "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline");
Tobin Ehlisde63c532015-06-18 15:59:33 -0600513 }
Chia-I Wu99ba2bb2015-10-31 00:31:16 +0800514 // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines.
Tobin Ehlisde63c532015-06-18 15:59:33 -0600515 // Mismatching primitive topology and tessellation fails graphics pipeline creation.
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -0600516 if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) &&
Chia-I Wu99ba2bb2015-10-31 00:31:16 +0800517 (pPipeline->iaStateCI.topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600518 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Chia-I Wu99ba2bb2015-10-31 00:31:16 +0800519 "Invalid Pipeline CreateInfo State: VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA topology for tessellation pipelines");
Tobin Ehlisde63c532015-06-18 15:59:33 -0600520 }
Chia-I Wu99ba2bb2015-10-31 00:31:16 +0800521 if (pPipeline->iaStateCI.topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) {
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -0600522 if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600523 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Chia-I Wu99ba2bb2015-10-31 00:31:16 +0800524 "Invalid Pipeline CreateInfo State: VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines");
Tobin Ehlis20693172015-09-17 08:46:18 -0600525 }
526 if (!pPipeline->tessStateCI.patchControlPoints || (pPipeline->tessStateCI.patchControlPoints > 32)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600527 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Chia-I Wu99ba2bb2015-10-31 00:31:16 +0800528 "Invalid Pipeline CreateInfo State: VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology used with patchControlPoints value %u."
Tobin Ehlis20693172015-09-17 08:46:18 -0600529 " patchControlPoints should be >0 and <=32.", pPipeline->tessStateCI.patchControlPoints);
530 }
Tobin Ehlisde63c532015-06-18 15:59:33 -0600531 }
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600532 // Viewport state must be included and viewport and scissor counts should always match
Tobin Ehlis9e839e52015-10-01 11:15:13 -0600533 // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600534 if (!pPipeline->graphicsPipelineCI.pViewportState) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600535 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600536 "Gfx Pipeline pViewportState is null. Even if viewport and scissors are dynamic PSO must include viewportCount and scissorCount in pViewportState.");
537 } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != pPipeline->graphicsPipelineCI.pViewportState->viewportCount) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600538 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Tobin Ehlis9e839e52015-10-01 11:15:13 -0600539 "Gfx Pipeline viewport count (%u) must match scissor count (%u).", pPipeline->vpStateCI.viewportCount, pPipeline->vpStateCI.scissorCount);
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600540 } else {
541 // If viewport or scissor are not dynamic, then verify that data is appropriate for count
542 VkBool32 dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT);
543 VkBool32 dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR);
544 if (!dynViewport) {
545 if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && !pPipeline->graphicsPipelineCI.pViewportState->pViewports) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600546 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Mark Lobodzinski2adea752015-11-10 15:25:01 -0700547 "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you must either include pViewports data, or "
548 "include viewport in pDynamicState and set it with vkCmdSetViewport().", pPipeline->graphicsPipelineCI.pViewportState->viewportCount);
Tobin Ehlis9e839e52015-10-01 11:15:13 -0600549 }
550 }
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600551 if (!dynScissor) {
552 if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && !pPipeline->graphicsPipelineCI.pViewportState->pScissors) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600553 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Mark Lobodzinski2adea752015-11-10 15:25:01 -0700554 "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you must either include pScissors data, or include "
555 "scissor in pDynamicState and set it with vkCmdSetScissor().", pPipeline->graphicsPipelineCI.pViewportState->scissorCount);
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600556 }
Tobin Ehlis9e839e52015-10-01 11:15:13 -0600557 }
558 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600559 return skipCall;
Tobin Ehlisde63c532015-06-18 15:59:33 -0600560}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700561
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600562// Init the pipeline mapping info based on pipeline create info LL tree
563// Threading note : Calls to this function should wrapped in mutex
Mark Lobodzinski2adea752015-11-10 15:25:01 -0700564static PIPELINE_NODE* initGraphicsPipeline(layer_data* dev_data, const VkGraphicsPipelineCreateInfo* pCreateInfo, PIPELINE_NODE* pBasePipeline)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600565{
Tobin Ehlisde63c532015-06-18 15:59:33 -0600566 PIPELINE_NODE* pPipeline = new PIPELINE_NODE;
567 if (pBasePipeline) {
568 memcpy((void*)pPipeline, (void*)pBasePipeline, sizeof(PIPELINE_NODE));
Tobin Ehlise42007c2015-06-19 13:00:59 -0600569 } else {
Tobin Ehlisde63c532015-06-18 15:59:33 -0600570 memset((void*)pPipeline, 0, sizeof(PIPELINE_NODE));
571 }
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600572 // First init create info
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -0600573 memcpy(&pPipeline->graphicsPipelineCI, pCreateInfo, sizeof(VkGraphicsPipelineCreateInfo));
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600574
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600575 size_t bufferSize = 0;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600576 const VkPipelineVertexInputStateCreateInfo* pVICI = NULL;
Tobin Ehlis59db5712015-07-13 13:14:24 -0600577 const VkPipelineColorBlendStateCreateInfo* pCBCI = NULL;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600578
579 for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) {
580 const VkPipelineShaderStageCreateInfo *pPSSCI = &pCreateInfo->pStages[i];
581
Chia-I Wu062ad152015-10-31 00:31:16 +0800582 switch (pPSSCI->stage) {
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -0600583 case VK_SHADER_STAGE_VERTEX_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600584 memcpy(&pPipeline->vsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
585 pPipeline->active_shaders |= VK_SHADER_STAGE_VERTEX_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600586 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -0600587 case VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600588 memcpy(&pPipeline->tcsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -0600589 pPipeline->active_shaders |= VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600590 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -0600591 case VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600592 memcpy(&pPipeline->tesCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -0600593 pPipeline->active_shaders |= VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600594 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -0600595 case VK_SHADER_STAGE_GEOMETRY_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600596 memcpy(&pPipeline->gsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
597 pPipeline->active_shaders |= VK_SHADER_STAGE_GEOMETRY_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600598 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -0600599 case VK_SHADER_STAGE_FRAGMENT_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600600 memcpy(&pPipeline->fsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
601 pPipeline->active_shaders |= VK_SHADER_STAGE_FRAGMENT_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600602 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -0600603 case VK_SHADER_STAGE_COMPUTE_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600604 // TODO : Flag error, CS is specified through VkComputePipelineCreateInfo
605 pPipeline->active_shaders |= VK_SHADER_STAGE_COMPUTE_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600606 break;
607 default:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600608 // TODO : Flag error
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600609 break;
610 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600611 }
Tobin Ehlisf6cb4672015-09-29 08:18:34 -0600612 // Copy over GraphicsPipelineCreateInfo structure embedded pointers
613 if (pCreateInfo->stageCount != 0) {
614 pPipeline->graphicsPipelineCI.pStages = new VkPipelineShaderStageCreateInfo[pCreateInfo->stageCount];
615 bufferSize = pCreateInfo->stageCount * sizeof(VkPipelineShaderStageCreateInfo);
616 memcpy((void*)pPipeline->graphicsPipelineCI.pStages, pCreateInfo->pStages, bufferSize);
617 }
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600618 if (pCreateInfo->pVertexInputState != NULL) {
619 memcpy((void*)&pPipeline->vertexInputCI, pCreateInfo->pVertexInputState , sizeof(VkPipelineVertexInputStateCreateInfo));
620 // Copy embedded ptrs
621 pVICI = pCreateInfo->pVertexInputState;
Chia-I Wu763a7492015-10-26 20:48:51 +0800622 pPipeline->vtxBindingCount = pVICI->vertexBindingDescriptionCount;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600623 if (pPipeline->vtxBindingCount) {
624 pPipeline->pVertexBindingDescriptions = new VkVertexInputBindingDescription[pPipeline->vtxBindingCount];
625 bufferSize = pPipeline->vtxBindingCount * sizeof(VkVertexInputBindingDescription);
626 memcpy((void*)pPipeline->pVertexBindingDescriptions, pVICI->pVertexBindingDescriptions, bufferSize);
627 }
Chia-I Wu763a7492015-10-26 20:48:51 +0800628 pPipeline->vtxAttributeCount = pVICI->vertexAttributeDescriptionCount;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600629 if (pPipeline->vtxAttributeCount) {
630 pPipeline->pVertexAttributeDescriptions = new VkVertexInputAttributeDescription[pPipeline->vtxAttributeCount];
631 bufferSize = pPipeline->vtxAttributeCount * sizeof(VkVertexInputAttributeDescription);
632 memcpy((void*)pPipeline->pVertexAttributeDescriptions, pVICI->pVertexAttributeDescriptions, bufferSize);
633 }
634 pPipeline->graphicsPipelineCI.pVertexInputState = &pPipeline->vertexInputCI;
635 }
Tony Barboure307f582015-07-10 15:29:03 -0600636 if (pCreateInfo->pInputAssemblyState != NULL) {
637 memcpy((void*)&pPipeline->iaStateCI, pCreateInfo->pInputAssemblyState, sizeof(VkPipelineInputAssemblyStateCreateInfo));
638 pPipeline->graphicsPipelineCI.pInputAssemblyState = &pPipeline->iaStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600639 }
Tony Barboure307f582015-07-10 15:29:03 -0600640 if (pCreateInfo->pTessellationState != NULL) {
641 memcpy((void*)&pPipeline->tessStateCI, pCreateInfo->pTessellationState, sizeof(VkPipelineTessellationStateCreateInfo));
642 pPipeline->graphicsPipelineCI.pTessellationState = &pPipeline->tessStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600643 }
Tony Barboure307f582015-07-10 15:29:03 -0600644 if (pCreateInfo->pViewportState != NULL) {
645 memcpy((void*)&pPipeline->vpStateCI, pCreateInfo->pViewportState, sizeof(VkPipelineViewportStateCreateInfo));
646 pPipeline->graphicsPipelineCI.pViewportState = &pPipeline->vpStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600647 }
Chia-I Wu1f851912015-10-27 18:04:07 +0800648 if (pCreateInfo->pRasterizationState != NULL) {
649 memcpy((void*)&pPipeline->rsStateCI, pCreateInfo->pRasterizationState, sizeof(VkPipelineRasterizationStateCreateInfo));
650 pPipeline->graphicsPipelineCI.pRasterizationState = &pPipeline->rsStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600651 }
Tony Barboure307f582015-07-10 15:29:03 -0600652 if (pCreateInfo->pMultisampleState != NULL) {
653 memcpy((void*)&pPipeline->msStateCI, pCreateInfo->pMultisampleState, sizeof(VkPipelineMultisampleStateCreateInfo));
654 pPipeline->graphicsPipelineCI.pMultisampleState = &pPipeline->msStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600655 }
Tobin Ehlisf6cb4672015-09-29 08:18:34 -0600656 if (pCreateInfo->pDepthStencilState != NULL) {
657 memcpy((void*)&pPipeline->dsStateCI, pCreateInfo->pDepthStencilState, sizeof(VkPipelineDepthStencilStateCreateInfo));
658 pPipeline->graphicsPipelineCI.pDepthStencilState = &pPipeline->dsStateCI;
659 }
Tony Barboure307f582015-07-10 15:29:03 -0600660 if (pCreateInfo->pColorBlendState != NULL) {
661 memcpy((void*)&pPipeline->cbStateCI, pCreateInfo->pColorBlendState, sizeof(VkPipelineColorBlendStateCreateInfo));
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600662 // Copy embedded ptrs
Tony Barboure307f582015-07-10 15:29:03 -0600663 pCBCI = pCreateInfo->pColorBlendState;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600664 pPipeline->attachmentCount = pCBCI->attachmentCount;
665 if (pPipeline->attachmentCount) {
Tony Barboure307f582015-07-10 15:29:03 -0600666 pPipeline->pAttachments = new VkPipelineColorBlendAttachmentState[pPipeline->attachmentCount];
667 bufferSize = pPipeline->attachmentCount * sizeof(VkPipelineColorBlendAttachmentState);
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600668 memcpy((void*)pPipeline->pAttachments, pCBCI->pAttachments, bufferSize);
669 }
Tony Barboure307f582015-07-10 15:29:03 -0600670 pPipeline->graphicsPipelineCI.pColorBlendState = &pPipeline->cbStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600671 }
Tobin Ehlisf6cb4672015-09-29 08:18:34 -0600672 if (pCreateInfo->pDynamicState != NULL) {
673 memcpy((void*)&pPipeline->dynStateCI, pCreateInfo->pDynamicState, sizeof(VkPipelineDynamicStateCreateInfo));
674 if (pPipeline->dynStateCI.dynamicStateCount) {
675 pPipeline->dynStateCI.pDynamicStates = new VkDynamicState[pPipeline->dynStateCI.dynamicStateCount];
676 bufferSize = pPipeline->dynStateCI.dynamicStateCount * sizeof(VkDynamicState);
677 memcpy((void*)pPipeline->dynStateCI.pDynamicStates, pCreateInfo->pDynamicState->pDynamicStates, bufferSize);
678 }
679 pPipeline->graphicsPipelineCI.pDynamicState = &pPipeline->dynStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600680 }
681
Tobin Ehlisde63c532015-06-18 15:59:33 -0600682 return pPipeline;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600683}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700684
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600685// Free the Pipeline nodes
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600686static void deletePipelines(layer_data* my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600687{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600688 if (my_data->pipelineMap.size() <= 0)
David Pinedof5997ab2015-04-27 16:36:17 -0600689 return;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600690 for (auto ii=my_data->pipelineMap.begin(); ii!=my_data->pipelineMap.end(); ++ii) {
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600691 if ((*ii).second->graphicsPipelineCI.stageCount != 0) {
692 delete[] (*ii).second->graphicsPipelineCI.pStages;
693 }
Tobin Ehliscd3109e2015-04-01 11:59:08 -0600694 if ((*ii).second->pVertexBindingDescriptions) {
695 delete[] (*ii).second->pVertexBindingDescriptions;
696 }
697 if ((*ii).second->pVertexAttributeDescriptions) {
698 delete[] (*ii).second->pVertexAttributeDescriptions;
699 }
700 if ((*ii).second->pAttachments) {
701 delete[] (*ii).second->pAttachments;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600702 }
Tobin Ehlisf6cb4672015-09-29 08:18:34 -0600703 if ((*ii).second->dynStateCI.dynamicStateCount != 0) {
704 delete[] (*ii).second->dynStateCI.pDynamicStates;
705 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600706 delete (*ii).second;
707 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600708 my_data->pipelineMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600709}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700710
Tobin Ehlis2464b882015-04-01 08:40:34 -0600711// For given pipeline, return number of MSAA samples, or one if MSAA disabled
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800712static VkSampleCountFlagBits getNumSamples(layer_data* my_data, const VkPipeline pipeline)
Tobin Ehlis2464b882015-04-01 08:40:34 -0600713{
Chia-I Wue420a332015-10-26 20:04:44 +0800714 PIPELINE_NODE* pPipe = my_data->pipelineMap[pipeline];
Tobin Ehlisb3a506f2015-07-13 14:51:15 -0600715 if (VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pPipe->msStateCI.sType) {
Chia-I Wu1f851912015-10-27 18:04:07 +0800716 return pPipe->msStateCI.rasterizationSamples;
Tobin Ehlisb3a506f2015-07-13 14:51:15 -0600717 }
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800718 return VK_SAMPLE_COUNT_1_BIT;
Tobin Ehlis2464b882015-04-01 08:40:34 -0600719}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700720
Tobin Ehlis2464b882015-04-01 08:40:34 -0600721// Validate state related to the PSO
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600722static VkBool32 validatePipelineState(layer_data* my_data, const GLOBAL_CB_NODE* pCB, const VkPipelineBindPoint pipelineBindPoint, const VkPipeline pipeline)
Tobin Ehlis2464b882015-04-01 08:40:34 -0600723{
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -0600724 if (VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) {
Tobin Ehlis2464b882015-04-01 08:40:34 -0600725 // Verify that any MSAA request in PSO matches sample# in bound FB
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800726 VkSampleCountFlagBits psoNumSamples = getNumSamples(my_data, pipeline);
Tobin Ehlis2464b882015-04-01 08:40:34 -0600727 if (pCB->activeRenderPass) {
Michael Lentine07ff1a12015-10-15 17:07:00 -0500728 const VkRenderPassCreateInfo* pRPCI = my_data->renderPassMap[pCB->activeRenderPass]->createInfo;
Chia-I Wuc278df82015-07-07 11:50:03 +0800729 const VkSubpassDescription* pSD = &pRPCI->pSubpasses[pCB->activeSubpass];
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800730 VkSampleCountFlagBits subpassNumSamples = (VkSampleCountFlagBits) 0;
Chia-I Wuc278df82015-07-07 11:50:03 +0800731 uint32_t i;
732
Chia-I Wu763a7492015-10-26 20:48:51 +0800733 for (i = 0; i < pSD->colorAttachmentCount; i++) {
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800734 VkSampleCountFlagBits samples;
Chia-I Wuc278df82015-07-07 11:50:03 +0800735
Cody Northrop6de6b0b2015-08-04 11:16:41 -0600736 if (pSD->pColorAttachments[i].attachment == VK_ATTACHMENT_UNUSED)
Chia-I Wuc278df82015-07-07 11:50:03 +0800737 continue;
738
Cody Northrop6de6b0b2015-08-04 11:16:41 -0600739 samples = pRPCI->pAttachments[pSD->pColorAttachments[i].attachment].samples;
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800740 if (subpassNumSamples == (VkSampleCountFlagBits) 0) {
Chia-I Wuc278df82015-07-07 11:50:03 +0800741 subpassNumSamples = samples;
742 } else if (subpassNumSamples != samples) {
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800743 subpassNumSamples = (VkSampleCountFlagBits) -1;
Chia-I Wuc278df82015-07-07 11:50:03 +0800744 break;
745 }
746 }
Chia-I Wuce532f72015-10-26 17:32:47 +0800747 if (pSD->pDepthStencilAttachment && pSD->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) {
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800748 const VkSampleCountFlagBits samples = pRPCI->pAttachments[pSD->pDepthStencilAttachment->attachment].samples;
749 if (subpassNumSamples == (VkSampleCountFlagBits) 0)
Chia-I Wuc278df82015-07-07 11:50:03 +0800750 subpassNumSamples = samples;
751 else if (subpassNumSamples != samples)
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800752 subpassNumSamples = (VkSampleCountFlagBits) -1;
Chia-I Wuc278df82015-07-07 11:50:03 +0800753 }
754
755 if (psoNumSamples != subpassNumSamples) {
Chia-I Wue420a332015-10-26 20:04:44 +0800756 return log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE, (uint64_t) pipeline, 0, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS",
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -0600757 "Num samples mismatch! Binding PSO (%#" PRIxLEAST64 ") with %u samples while current RenderPass (%#" PRIxLEAST64 ") w/ %u samples!",
Chia-I Wue420a332015-10-26 20:04:44 +0800758 (uint64_t) pipeline, psoNumSamples, (uint64_t) pCB->activeRenderPass, subpassNumSamples);
Tobin Ehlis2464b882015-04-01 08:40:34 -0600759 }
760 } else {
761 // TODO : I believe it's an error if we reach this point and don't have an activeRenderPass
762 // Verify and flag error as appropriate
763 }
764 // TODO : Add more checks here
765 } else {
766 // TODO : Validate non-gfx pipeline updates
767 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600768 return VK_FALSE;
Tobin Ehlis2464b882015-04-01 08:40:34 -0600769}
770
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600771// Block of code at start here specifically for managing/tracking DSs
772
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600773// Return Pool node ptr for specified pool or else NULL
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -0700774static DESCRIPTOR_POOL_NODE* getPoolNode(layer_data* my_data, const VkDescriptorPool pool)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600775{
776 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -0700777 if (my_data->descriptorPoolMap.find(pool) == my_data->descriptorPoolMap.end()) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600778 loader_platform_thread_unlock_mutex(&globalLock);
779 return NULL;
780 }
781 loader_platform_thread_unlock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -0700782 return my_data->descriptorPoolMap[pool];
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600783}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700784
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600785// Return Set node ptr for specified set or else NULL
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600786static SET_NODE* getSetNode(layer_data* my_data, const VkDescriptorSet set)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600787{
788 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +0800789 if (my_data->setMap.find(set) == my_data->setMap.end()) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600790 loader_platform_thread_unlock_mutex(&globalLock);
791 return NULL;
792 }
793 loader_platform_thread_unlock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +0800794 return my_data->setMap[set];
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600795}
796
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600797static LAYOUT_NODE* getLayoutNode(layer_data* my_data, const VkDescriptorSetLayout layout) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600798 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +0800799 if (my_data->layoutMap.find(layout) == my_data->layoutMap.end()) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600800 loader_platform_thread_unlock_mutex(&globalLock);
801 return NULL;
802 }
803 loader_platform_thread_unlock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +0800804 return my_data->layoutMap[layout];
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600805}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700806
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600807// Return VK_FALSE if update struct is of valid type, otherwise flag error and return code from callback
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600808static VkBool32 validUpdateStruct(layer_data* my_data, const VkDevice device, const GENERIC_HEADER* pUpdateStruct)
Tobin Ehlis0b551cd2015-05-28 12:10:17 -0600809{
Tobin Ehlis0b551cd2015-05-28 12:10:17 -0600810 switch (pUpdateStruct->sType)
811 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800812 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
813 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600814 return VK_FALSE;
Tobin Ehlis0b551cd2015-05-28 12:10:17 -0600815 default:
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600816 return log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_UPDATE_STRUCT, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -0600817 "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType);
Tobin Ehlis0b551cd2015-05-28 12:10:17 -0600818 }
819}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700820
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600821// Set count for given update struct in the last parameter
822// Return value of skipCall, which is only VK_TRUE is error occurs and callback signals execution to cease
Tobin Ehlise66ec962015-10-27 12:54:50 -0600823static uint32_t getUpdateCount(layer_data* my_data, const VkDevice device, const GENERIC_HEADER* pUpdateStruct)
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600824{
825 switch (pUpdateStruct->sType)
826 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800827 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
Chia-I Wu763a7492015-10-26 20:48:51 +0800828 return ((VkWriteDescriptorSet*)pUpdateStruct)->descriptorCount;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800829 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600830 // TODO : Need to understand this case better and make sure code is correct
Chia-I Wu763a7492015-10-26 20:48:51 +0800831 return ((VkCopyDescriptorSet*)pUpdateStruct)->descriptorCount;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600832 }
833}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700834
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600835// For given Layout Node and binding, return index where that binding begins
836static uint32_t getBindingStartIndex(const LAYOUT_NODE* pLayout, const uint32_t binding)
837{
838 uint32_t offsetIndex = 0;
Chia-I Wub5689ee2015-10-31 00:31:16 +0800839 for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) {
840 if (pLayout->createInfo.pBinding[i].binding == binding)
841 break;
Chia-I Wu045654f2015-11-06 06:42:02 +0800842 offsetIndex += pLayout->createInfo.pBinding[i].descriptorCount;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600843 }
844 return offsetIndex;
845}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700846
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600847// For given layout node and binding, return last index that is updated
848static uint32_t getBindingEndIndex(const LAYOUT_NODE* pLayout, const uint32_t binding)
849{
850 uint32_t offsetIndex = 0;
Chia-I Wub5689ee2015-10-31 00:31:16 +0800851 for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) {
Chia-I Wu045654f2015-11-06 06:42:02 +0800852 offsetIndex += pLayout->createInfo.pBinding[i].descriptorCount;
Chia-I Wub5689ee2015-10-31 00:31:16 +0800853 if (pLayout->createInfo.pBinding[i].binding == binding)
854 break;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600855 }
856 return offsetIndex-1;
857}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700858
Tobin Ehlise66ec962015-10-27 12:54:50 -0600859// For given layout and update, return the first overall index of the layout that is updated
Tobin Ehlisd2e246e2015-10-27 15:43:38 -0600860static uint32_t getUpdateStartIndex(layer_data* my_data, const VkDevice device, const LAYOUT_NODE* pLayout, const uint32_t binding, const uint32_t arrayIndex, const GENERIC_HEADER* pUpdateStruct)
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600861{
Tobin Ehlise66ec962015-10-27 12:54:50 -0600862 return getBindingStartIndex(pLayout, binding)+arrayIndex;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600863}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700864
Tobin Ehlisd2e246e2015-10-27 15:43:38 -0600865// For given layout and update, return the last overall index of the layout that is updated
866static uint32_t getUpdateEndIndex(layer_data* my_data, const VkDevice device, const LAYOUT_NODE* pLayout, const uint32_t binding, const uint32_t arrayIndex, const GENERIC_HEADER* pUpdateStruct)
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600867{
Tobin Ehlisd2e246e2015-10-27 15:43:38 -0600868 uint32_t count = getUpdateCount(my_data, device, pUpdateStruct);
Tobin Ehlise66ec962015-10-27 12:54:50 -0600869 return getBindingStartIndex(pLayout, binding)+arrayIndex+count-1;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600870}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700871
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600872// Verify that the descriptor type in the update struct matches what's expected by the layout
Tobin Ehlis68fbd442015-10-27 12:25:35 -0600873static VkBool32 validateUpdateConsistency(layer_data* my_data, const VkDevice device, const LAYOUT_NODE* pLayout, const GENERIC_HEADER* pUpdateStruct, uint32_t startIndex, uint32_t endIndex)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600874{
875 // First get actual type of update
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600876 VkBool32 skipCall = VK_FALSE;
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -0600877 VkDescriptorType actualType;
Tobin Ehlis68fbd442015-10-27 12:25:35 -0600878 uint32_t i = 0;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600879 switch (pUpdateStruct->sType)
880 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800881 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
882 actualType = ((VkWriteDescriptorSet*)pUpdateStruct)->descriptorType;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600883 break;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800884 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
885 /* no need to validate */
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600886 return VK_FALSE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600887 break;
888 default:
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600889 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_UPDATE_STRUCT, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -0600890 "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType);
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600891 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600892 if (VK_FALSE == skipCall) {
Tobin Ehlis68fbd442015-10-27 12:25:35 -0600893 // Set first stageFlags as reference and verify that all other updates match it
894 VkShaderStageFlags refStageFlags = pLayout->stageFlags[startIndex];
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600895 for (i = startIndex; i <= endIndex; i++) {
Tobin Ehlis91423d22015-10-20 10:11:55 -0600896 if (pLayout->descriptorTypes[i] != actualType) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600897 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS",
Tobin Ehlis68fbd442015-10-27 12:25:35 -0600898 "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!",
899 string_VkDescriptorType(actualType), string_VkDescriptorType(pLayout->descriptorTypes[i]));
900 }
901 if (pLayout->stageFlags[i] != refStageFlags) {
902 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_DESCRIPTOR_STAGEFLAGS_MISMATCH, "DS",
903 "Write descriptor update has stageFlags %x that do not match overlapping binding descriptor stageFlags of %x!",
904 refStageFlags, pLayout->stageFlags[i]);
Tobin Ehlis3b341092015-09-30 08:30:20 -0600905 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600906 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600907 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600908 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600909}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700910
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600911// Determine the update type, allocate a new struct of that type, shadow the given pUpdate
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600912// struct into the pNewNode param. Return VK_TRUE if error condition encountered and callback signals early exit.
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600913// NOTE : Calls to this function should be wrapped in mutex
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600914static VkBool32 shadowUpdateNode(layer_data* my_data, const VkDevice device, GENERIC_HEADER* pUpdate, GENERIC_HEADER** pNewNode)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600915{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600916 VkBool32 skipCall = VK_FALSE;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800917 VkWriteDescriptorSet* pWDS = NULL;
918 VkCopyDescriptorSet* pCDS = NULL;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600919 size_t array_size = 0;
920 size_t base_array_size = 0;
921 size_t total_array_size = 0;
922 size_t baseBuffAddr = 0;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600923 switch (pUpdate->sType)
924 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800925 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
926 pWDS = new VkWriteDescriptorSet;
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600927 *pNewNode = (GENERIC_HEADER*)pWDS;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800928 memcpy(pWDS, pUpdate, sizeof(VkWriteDescriptorSet));
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -0600929
930 switch (pWDS->descriptorType) {
931 case VK_DESCRIPTOR_TYPE_SAMPLER:
932 case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
933 case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
934 case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
935 {
Chia-I Wu763a7492015-10-26 20:48:51 +0800936 VkDescriptorImageInfo *info = new VkDescriptorImageInfo[pWDS->descriptorCount];
937 memcpy(info, pWDS->pImageInfo, pWDS->descriptorCount * sizeof(VkDescriptorImageInfo));
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -0600938 pWDS->pImageInfo = info;
Tobin Ehliscb085292015-12-01 09:57:09 -0700939 }
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -0600940 break;
941 case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
942 case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
943 {
Chia-I Wu763a7492015-10-26 20:48:51 +0800944 VkBufferView *info = new VkBufferView[pWDS->descriptorCount];
945 memcpy(info, pWDS->pTexelBufferView, pWDS->descriptorCount * sizeof(VkBufferView));
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -0600946 pWDS->pTexelBufferView = info;
947 }
948 break;
949 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER:
950 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER:
951 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
952 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
953 {
Chia-I Wu763a7492015-10-26 20:48:51 +0800954 VkDescriptorBufferInfo *info = new VkDescriptorBufferInfo[pWDS->descriptorCount];
955 memcpy(info, pWDS->pBufferInfo, pWDS->descriptorCount * sizeof(VkDescriptorBufferInfo));
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -0600956 pWDS->pBufferInfo = info;
957 }
958 break;
959 default:
960 return VK_ERROR_VALIDATION_FAILED;
961 break;
962 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600963 break;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800964 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
965 pCDS = new VkCopyDescriptorSet;
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600966 *pNewNode = (GENERIC_HEADER*)pCDS;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800967 memcpy(pCDS, pUpdate, sizeof(VkCopyDescriptorSet));
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600968 break;
969 default:
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600970 if (log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_UPDATE_STRUCT, "DS",
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600971 "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", string_VkStructureType(pUpdate->sType), pUpdate->sType))
972 return VK_TRUE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600973 }
974 // Make sure that pNext for the end of shadow copy is NULL
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600975 (*pNewNode)->pNext = NULL;
976 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600977}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700978
Tobin Ehlisb46be812015-10-23 16:00:08 -0600979// Verify that given sampler is valid
980static VkBool32 validateSampler(const layer_data* my_data, const VkSampler* pSampler, const VkBool32 immutable)
981{
982 VkBool32 skipCall = VK_FALSE;
Chia-I Wue420a332015-10-26 20:04:44 +0800983 auto sampIt = my_data->sampleMap.find(*pSampler);
Tobin Ehlisb46be812015-10-23 16:00:08 -0600984 if (sampIt == my_data->sampleMap.end()) {
985 if (!immutable) {
Chia-I Wue420a332015-10-26 20:04:44 +0800986 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_SAMPLER, (uint64_t) *pSampler, 0, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS",
987 "vkUpdateDescriptorSets: Attempt to update descriptor with invalid sampler %#" PRIxLEAST64, (uint64_t) *pSampler);
Tobin Ehlisb46be812015-10-23 16:00:08 -0600988 } else { // immutable
Chia-I Wue420a332015-10-26 20:04:44 +0800989 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_SAMPLER, (uint64_t) *pSampler, 0, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS",
990 "vkUpdateDescriptorSets: Attempt to update descriptor whose binding has an invalid immutable sampler %#" PRIxLEAST64, (uint64_t) *pSampler);
Tobin Ehlisb46be812015-10-23 16:00:08 -0600991 }
992 } else {
993 // TODO : Any further checks we want to do on the sampler?
994 }
995 return skipCall;
996}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700997
Tobin Ehlisb46be812015-10-23 16:00:08 -0600998// Verify that given imageView is valid
999static VkBool32 validateImageView(const layer_data* my_data, const VkImageView* pImageView, const VkImageLayout imageLayout)
1000{
1001 VkBool32 skipCall = VK_FALSE;
Chia-I Wue420a332015-10-26 20:04:44 +08001002 auto ivIt = my_data->imageViewMap.find(*pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001003 if (ivIt == my_data->imageViewMap.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +08001004 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE_VIEW, (uint64_t) *pImageView, 0, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS",
1005 "vkUpdateDescriptorSets: Attempt to update descriptor with invalid imageView %#" PRIxLEAST64, (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001006 } else {
1007 // Validate that imageLayout is compatible with aspectMask and image format
1008 VkImageAspectFlags aspectMask = ivIt->second->subresourceRange.aspectMask;
Chia-I Wue420a332015-10-26 20:04:44 +08001009 VkImage image = ivIt->second->image;
Michael Lentineee4ad4d2015-10-23 12:41:44 -07001010 // TODO : Check here in case we have a bad image
Chia-I Wue420a332015-10-26 20:04:44 +08001011 auto imgIt = my_data->imageMap.find(image);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001012 if (imgIt == my_data->imageMap.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +08001013 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE, (uint64_t) image, 0, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS",
Michael Lentineee4ad4d2015-10-23 12:41:44 -07001014 "vkUpdateDescriptorSets: Attempt to update descriptor with invalid image %#" PRIxLEAST64 " in imageView %#" PRIxLEAST64, (uint64_t) image, (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001015 } else {
1016 VkFormat format = (*imgIt).second->format;
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07001017 VkBool32 ds = vk_format_is_depth_or_stencil(format);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001018 switch (imageLayout) {
1019 case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL:
1020 // Only Color bit must be set
1021 if ((aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) != VK_IMAGE_ASPECT_COLOR_BIT) {
Chia-I Wue420a332015-10-26 20:04:44 +08001022 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE_VIEW, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001023 DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL and imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001024 " that does not have VK_IMAGE_ASPECT_COLOR_BIT set.", (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001025 }
1026 // format must NOT be DS
1027 if (ds) {
Chia-I Wue420a332015-10-26 20:04:44 +08001028 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE_VIEW, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001029 DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL and imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001030 " but the image format is %s which is not a color format.", (uint64_t) *pImageView, string_VkFormat(format));
Tobin Ehlisb46be812015-10-23 16:00:08 -06001031 }
1032 break;
1033 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL:
1034 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL:
1035 // Depth or stencil bit must be set, but both must NOT be set
1036 if (aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) {
1037 if (aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT) {
1038 // both must NOT be set
Chia-I Wue420a332015-10-26 20:04:44 +08001039 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE_VIEW, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001040 DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", "vkUpdateDescriptorSets: Updating descriptor with imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001041 " that has both STENCIL and DEPTH aspects set", (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001042 }
1043 } else if (!(aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT)) {
1044 // Neither were set
Chia-I Wue420a332015-10-26 20:04:44 +08001045 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE_VIEW, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001046 DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001047 " that does not have STENCIL or DEPTH aspect set.", string_VkImageLayout(imageLayout), (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001048 }
1049 // format must be DS
1050 if (!ds) {
Chia-I Wue420a332015-10-26 20:04:44 +08001051 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE_VIEW, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001052 DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001053 " but the image format is %s which is not a depth/stencil format.", string_VkImageLayout(imageLayout), (uint64_t) *pImageView, string_VkFormat(format));
Tobin Ehlisb46be812015-10-23 16:00:08 -06001054 }
1055 break;
1056 default:
1057 // anything to check for other layouts?
1058 break;
1059 }
1060 }
1061 }
1062 return skipCall;
1063}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001064
Tobin Ehlisb46be812015-10-23 16:00:08 -06001065// Verify that given bufferView is valid
1066static VkBool32 validateBufferView(const layer_data* my_data, const VkBufferView* pBufferView)
1067{
1068 VkBool32 skipCall = VK_FALSE;
Chia-I Wue420a332015-10-26 20:04:44 +08001069 auto sampIt = my_data->bufferViewMap.find(*pBufferView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001070 if (sampIt == my_data->bufferViewMap.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +08001071 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_BUFFER_VIEW, (uint64_t) *pBufferView, 0, DRAWSTATE_BUFFERVIEW_DESCRIPTOR_ERROR, "DS",
1072 "vkUpdateDescriptorSets: Attempt to update descriptor with invalid bufferView %#" PRIxLEAST64, (uint64_t) *pBufferView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001073 } else {
1074 // TODO : Any further checks we want to do on the bufferView?
1075 }
1076 return skipCall;
1077}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001078
Tobin Ehlisb46be812015-10-23 16:00:08 -06001079// Verify that given bufferInfo is valid
1080static VkBool32 validateBufferInfo(const layer_data* my_data, const VkDescriptorBufferInfo* pBufferInfo)
1081{
1082 VkBool32 skipCall = VK_FALSE;
Chia-I Wue420a332015-10-26 20:04:44 +08001083 auto sampIt = my_data->bufferMap.find(pBufferInfo->buffer);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001084 if (sampIt == my_data->bufferMap.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +08001085 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_BUFFER, (uint64_t) pBufferInfo->buffer, 0, DRAWSTATE_BUFFERINFO_DESCRIPTOR_ERROR, "DS",
1086 "vkUpdateDescriptorSets: Attempt to update descriptor where bufferInfo has invalid buffer %#" PRIxLEAST64, (uint64_t) pBufferInfo->buffer);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001087 } else {
1088 // TODO : Any further checks we want to do on the bufferView?
1089 }
1090 return skipCall;
1091}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001092
Tobin Ehlisb46be812015-10-23 16:00:08 -06001093static VkBool32 validateUpdateContents(const layer_data* my_data, const VkWriteDescriptorSet *pWDS, const VkDescriptorSetLayoutBinding* pLayoutBinding)
1094{
1095 VkBool32 skipCall = VK_FALSE;
1096 // First verify that for the given Descriptor type, the correct DescriptorInfo data is supplied
1097 VkBufferView* pBufferView = NULL;
1098 const VkSampler* pSampler = NULL;
1099 VkImageView* pImageView = NULL;
1100 VkImageLayout* pImageLayout = NULL;
1101 VkDescriptorBufferInfo* pBufferInfo = NULL;
1102 VkBool32 immutable = VK_FALSE;
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001103 uint32_t i = 0;
1104 // For given update type, verify that update contents are correct
1105 switch (pWDS->descriptorType) {
1106 case VK_DESCRIPTOR_TYPE_SAMPLER:
Chia-I Wu763a7492015-10-26 20:48:51 +08001107 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001108 skipCall |= validateSampler(my_data, &(pWDS->pImageInfo[i].sampler), immutable);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001109 }
1110 break;
1111 case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
Chia-I Wu763a7492015-10-26 20:48:51 +08001112 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001113 if (NULL == pLayoutBinding->pImmutableSamplers) {
1114 pSampler = &(pWDS->pImageInfo[i].sampler);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001115 if (immutable) {
Chia-I Wue420a332015-10-26 20:04:44 +08001116 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_SAMPLER, (uint64_t) *pSampler, 0, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS",
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001117 "vkUpdateDescriptorSets: Update #%u is not an immutable sampler %#" PRIxLEAST64 ", but previous update(s) from this "
1118 "VkWriteDescriptorSet struct used an immutable sampler. All updates from a single struct must either "
Chia-I Wue420a332015-10-26 20:04:44 +08001119 "use immutable or non-immutable samplers.", i, (uint64_t) *pSampler);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001120 }
Tobin Ehlisb46be812015-10-23 16:00:08 -06001121 } else {
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001122 if (i>0 && !immutable) {
Chia-I Wue420a332015-10-26 20:04:44 +08001123 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_SAMPLER, (uint64_t) *pSampler, 0, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS",
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001124 "vkUpdateDescriptorSets: Update #%u is an immutable sampler, but previous update(s) from this "
1125 "VkWriteDescriptorSet struct used a non-immutable sampler. All updates from a single struct must either "
1126 "use immutable or non-immutable samplers.", i);
1127 }
Tobin Ehlisb46be812015-10-23 16:00:08 -06001128 immutable = VK_TRUE;
1129 pSampler = &(pLayoutBinding->pImmutableSamplers[i]);
1130 }
1131 skipCall |= validateSampler(my_data, pSampler, immutable);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001132 }
1133 // Intentionally fall through here to also validate image stuff
1134 case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
1135 case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
1136 case VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT:
Chia-I Wu763a7492015-10-26 20:48:51 +08001137 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001138 skipCall |= validateImageView(my_data, &(pWDS->pImageInfo[i].imageView), pWDS->pImageInfo[i].imageLayout);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001139 }
1140 break;
1141 case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
1142 case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
Chia-I Wu763a7492015-10-26 20:48:51 +08001143 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001144 skipCall |= validateBufferView(my_data, &(pWDS->pTexelBufferView[i]));
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001145 }
1146 break;
1147 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER:
1148 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER:
1149 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
1150 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
Chia-I Wu763a7492015-10-26 20:48:51 +08001151 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001152 skipCall |= validateBufferInfo(my_data, &(pWDS->pBufferInfo[i]));
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001153 }
1154 break;
Tobin Ehlisb46be812015-10-23 16:00:08 -06001155 }
1156 return skipCall;
1157}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001158
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001159// update DS mappings based on write and copy update arrays
Chia-I Wu483e7702015-10-26 17:20:32 +08001160static VkBool32 dsUpdate(layer_data* my_data, VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet* pWDS, uint32_t descriptorCopyCount, const VkCopyDescriptorSet* pCDS)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001161{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001162 VkBool32 skipCall = VK_FALSE;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001163
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001164 loader_platform_thread_lock_mutex(&globalLock);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001165 LAYOUT_NODE* pLayout = NULL;
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06001166 VkDescriptorSetLayoutCreateInfo* pLayoutCI = NULL;
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001167 // Validate Write updates
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001168 uint32_t i = 0;
Chia-I Wu483e7702015-10-26 17:20:32 +08001169 for (i=0; i < descriptorWriteCount; i++) {
Chia-I Wu1f851912015-10-27 18:04:07 +08001170 VkDescriptorSet ds = pWDS[i].dstSet;
Chia-I Wue420a332015-10-26 20:04:44 +08001171 SET_NODE* pSet = my_data->setMap[ds];
Tobin Ehlisb46be812015-10-23 16:00:08 -06001172 GENERIC_HEADER* pUpdate = (GENERIC_HEADER*) &pWDS[i];
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001173 pLayout = pSet->pLayout;
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06001174 // First verify valid update struct
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001175 if ((skipCall = validUpdateStruct(my_data, device, pUpdate)) == VK_TRUE) {
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06001176 break;
1177 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001178 uint32_t binding = 0, endIndex = 0;
Chia-I Wu1f851912015-10-27 18:04:07 +08001179 binding = pWDS[i].dstBinding;
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001180 // Make sure that layout being updated has the binding being updated
Chia-I Wub5689ee2015-10-31 00:31:16 +08001181 if (pLayout->bindings.find(binding) == pLayout->bindings.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +08001182 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) ds, 0, DRAWSTATE_INVALID_UPDATE_INDEX, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001183 "Descriptor Set %" PRIu64 " does not have binding to match update binding %u for update type %s!", reinterpret_cast<uint64_t>(ds), binding, string_VkStructureType(pUpdate->sType));
Tobin Ehlise42007c2015-06-19 13:00:59 -06001184 } else {
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001185 // Next verify that update falls within size of given binding
Chia-I Wu1f851912015-10-27 18:04:07 +08001186 endIndex = getUpdateEndIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001187 if (getBindingEndIndex(pLayout, binding) < endIndex) {
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001188 pLayoutCI = &pLayout->createInfo;
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06001189 string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} ");
Chia-I Wue420a332015-10-26 20:04:44 +08001190 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) ds, 0, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS",
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001191 "Descriptor update type of %s is out of bounds for matching binding %u in Layout w/ CI:\n%s!", string_VkStructureType(pUpdate->sType), binding, DSstr.c_str());
Tobin Ehlise42007c2015-06-19 13:00:59 -06001192 } else { // TODO : should we skip update on a type mismatch or force it?
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001193 uint32_t startIndex;
Chia-I Wu1f851912015-10-27 18:04:07 +08001194 startIndex = getUpdateStartIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001195 // Layout bindings match w/ update, now verify that update type & stageFlags are the same for entire update
1196 if ((skipCall = validateUpdateConsistency(my_data, device, pLayout, pUpdate, startIndex, endIndex)) == VK_FALSE) {
1197 // The update is within bounds and consistent, but need to make sure contents make sense as well
Chia-I Wuf03cbf72015-10-31 00:31:16 +08001198 if ((skipCall = validateUpdateContents(my_data, &pWDS[i], &pLayout->createInfo.pBinding[binding])) == VK_FALSE) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001199 // Update is good. Save the update info
1200 // Create new update struct for this set's shadow copy
1201 GENERIC_HEADER* pNewNode = NULL;
1202 skipCall |= shadowUpdateNode(my_data, device, pUpdate, &pNewNode);
1203 if (NULL == pNewNode) {
Chia-I Wue420a332015-10-26 20:04:44 +08001204 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) ds, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Tobin Ehlisb46be812015-10-23 16:00:08 -06001205 "Out of memory while attempting to allocate UPDATE struct in vkUpdateDescriptors()");
1206 } else {
1207 // Insert shadow node into LL of updates for this set
1208 pNewNode->pNext = pSet->pUpdateStructs;
1209 pSet->pUpdateStructs = pNewNode;
1210 // Now update appropriate descriptor(s) to point to new Update node
Tobin Ehlisb46be812015-10-23 16:00:08 -06001211 for (uint32_t j = startIndex; j <= endIndex; j++) {
1212 assert(j<pSet->descriptorCount);
1213 pSet->ppDescriptors[j] = pNewNode;
1214 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001215 }
1216 }
1217 }
1218 }
1219 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001220 }
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001221 // Now validate copy updates
Chia-I Wu483e7702015-10-26 17:20:32 +08001222 for (i=0; i < descriptorCopyCount; ++i) {
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001223 SET_NODE *pSrcSet = NULL, *pDstSet = NULL;
1224 LAYOUT_NODE *pSrcLayout = NULL, *pDstLayout = NULL;
1225 uint32_t srcStartIndex = 0, srcEndIndex = 0, dstStartIndex = 0, dstEndIndex = 0;
1226 // For each copy make sure that update falls within given layout and that types match
Chia-I Wue420a332015-10-26 20:04:44 +08001227 pSrcSet = my_data->setMap[pCDS[i].srcSet];
Chia-I Wu1f851912015-10-27 18:04:07 +08001228 pDstSet = my_data->setMap[pCDS[i].dstSet];
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001229 pSrcLayout = pSrcSet->pLayout;
1230 pDstLayout = pDstSet->pLayout;
1231 // Validate that src binding is valid for src set layout
Chia-I Wub5689ee2015-10-31 00:31:16 +08001232 if (pSrcLayout->bindings.find(pCDS[i].srcBinding) == pSrcLayout->bindings.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +08001233 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pSrcSet->set, 0, DRAWSTATE_INVALID_UPDATE_INDEX, "DS",
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001234 "Copy descriptor update %u has srcBinding %u which is out of bounds for underlying SetLayout %#" PRIxLEAST64 " which only has bindings 0-%u.",
Chia-I Wu763a7492015-10-26 20:48:51 +08001235 i, pCDS[i].srcBinding, (uint64_t) pSrcLayout->layout, pSrcLayout->createInfo.bindingCount-1);
Chia-I Wub5689ee2015-10-31 00:31:16 +08001236 } else if (pDstLayout->bindings.find(pCDS[i].dstBinding) == pDstLayout->bindings.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +08001237 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDstSet->set, 0, DRAWSTATE_INVALID_UPDATE_INDEX, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08001238 "Copy descriptor update %u has dstBinding %u which is out of bounds for underlying SetLayout %#" PRIxLEAST64 " which only has bindings 0-%u.",
1239 i, pCDS[i].dstBinding, (uint64_t) pDstLayout->layout, pDstLayout->createInfo.bindingCount-1);
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001240 } else {
1241 // Proceed with validation. Bindings are ok, but make sure update is within bounds of given layout
1242 srcEndIndex = getUpdateEndIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, (const GENERIC_HEADER*)&(pCDS[i]));
Chia-I Wu1f851912015-10-27 18:04:07 +08001243 dstEndIndex = getUpdateEndIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, (const GENERIC_HEADER*)&(pCDS[i]));
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001244 if (getBindingEndIndex(pSrcLayout, pCDS[i].srcBinding) < srcEndIndex) {
1245 pLayoutCI = &pSrcLayout->createInfo;
1246 string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} ");
Chia-I Wue420a332015-10-26 20:04:44 +08001247 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pSrcSet->set, 0, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS",
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001248 "Copy descriptor src update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", pCDS[i].srcBinding, DSstr.c_str());
Chia-I Wu1f851912015-10-27 18:04:07 +08001249 } else if (getBindingEndIndex(pDstLayout, pCDS[i].dstBinding) < dstEndIndex) {
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001250 pLayoutCI = &pDstLayout->createInfo;
1251 string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} ");
Chia-I Wue420a332015-10-26 20:04:44 +08001252 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDstSet->set, 0, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08001253 "Copy descriptor dest update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", pCDS[i].dstBinding, DSstr.c_str());
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001254 } else {
1255 srcStartIndex = getUpdateStartIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, (const GENERIC_HEADER*)&(pCDS[i]));
Chia-I Wu1f851912015-10-27 18:04:07 +08001256 dstStartIndex = getUpdateStartIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, (const GENERIC_HEADER*)&(pCDS[i]));
Chia-I Wu763a7492015-10-26 20:48:51 +08001257 for (uint32_t j=0; j<pCDS[i].descriptorCount; ++j) {
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001258 // For copy just make sure that the types match and then perform the update
1259 if (pSrcLayout->descriptorTypes[srcStartIndex+j] != pDstLayout->descriptorTypes[dstStartIndex+j]) {
1260 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS",
1261 "Copy descriptor update index %u, update count #%u, has src update descriptor type %s that does not match overlapping dest descriptor type of %s!",
1262 i, j+1, string_VkDescriptorType(pSrcLayout->descriptorTypes[srcStartIndex+j]), string_VkDescriptorType(pDstLayout->descriptorTypes[dstStartIndex+j]));
1263 } else {
1264 // point dst descriptor at corresponding src descriptor
1265 pDstSet->ppDescriptors[j+dstStartIndex] = pSrcSet->ppDescriptors[j+srcStartIndex];
1266 }
1267 }
1268 }
1269 }
1270 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001271 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001272 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001273}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001274
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001275// Verify that given pool has descriptors that are being requested for allocation
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001276static VkBool32 validate_descriptor_availability_in_pool(layer_data* dev_data, DESCRIPTOR_POOL_NODE* pPoolNode, uint32_t count, const VkDescriptorSetLayout* pSetLayouts)
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001277{
1278 VkBool32 skipCall = VK_FALSE;
1279 uint32_t i = 0, j = 0;
1280 for (i=0; i<count; ++i) {
1281 LAYOUT_NODE* pLayout = getLayoutNode(dev_data, pSetLayouts[i]);
1282 if (NULL == pLayout) {
Chia-I Wue420a332015-10-26 20:04:44 +08001283 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT, (uint64_t) pSetLayouts[i], 0, DRAWSTATE_INVALID_LAYOUT, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08001284 "Unable to find set layout node for layout %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", (uint64_t) pSetLayouts[i]);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001285 } else {
Chia-I Wuc51b1212015-10-27 19:25:11 +08001286 uint32_t typeIndex = 0, poolSizeCount = 0;
Chia-I Wu763a7492015-10-26 20:48:51 +08001287 for (j=0; j<pLayout->createInfo.bindingCount; ++j) {
Chia-I Wuf03cbf72015-10-31 00:31:16 +08001288 typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBinding[j].descriptorType);
Chia-I Wu045654f2015-11-06 06:42:02 +08001289 poolSizeCount = pLayout->createInfo.pBinding[j].descriptorCount;
Chia-I Wuc51b1212015-10-27 19:25:11 +08001290 if (poolSizeCount > pPoolNode->availableDescriptorTypeCount[typeIndex]) {
Chia-I Wue420a332015-10-26 20:04:44 +08001291 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT, (uint64_t) pLayout->layout, 0, DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS",
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001292 "Unable to allocate %u descriptors of type %s from pool %#" PRIxLEAST64 ". This pool only has %u descriptors of this type remaining.",
Chia-I Wuf03cbf72015-10-31 00:31:16 +08001293 poolSizeCount, string_VkDescriptorType(pLayout->createInfo.pBinding[j].descriptorType), (uint64_t) pPoolNode->pool, pPoolNode->availableDescriptorTypeCount[typeIndex]);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001294 } else { // Decrement available descriptors of this type
Chia-I Wuc51b1212015-10-27 19:25:11 +08001295 pPoolNode->availableDescriptorTypeCount[typeIndex] -= poolSizeCount;
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001296 }
1297 }
1298 }
1299 }
1300 return skipCall;
1301}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001302
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001303// Free the shadowed update node for this Set
1304// NOTE : Calls to this function should be wrapped in mutex
1305static void freeShadowUpdateTree(SET_NODE* pSet)
1306{
1307 GENERIC_HEADER* pShadowUpdate = pSet->pUpdateStructs;
1308 pSet->pUpdateStructs = NULL;
1309 GENERIC_HEADER* pFreeUpdate = pShadowUpdate;
1310 // Clear the descriptor mappings as they will now be invalid
1311 memset(pSet->ppDescriptors, 0, pSet->descriptorCount*sizeof(GENERIC_HEADER*));
1312 while(pShadowUpdate) {
1313 pFreeUpdate = pShadowUpdate;
1314 pShadowUpdate = (GENERIC_HEADER*)pShadowUpdate->pNext;
1315 uint32_t index = 0;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001316 VkWriteDescriptorSet * pWDS = NULL;
1317 VkCopyDescriptorSet * pCDS = NULL;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001318 void** ppToFree = NULL;
1319 switch (pFreeUpdate->sType)
1320 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001321 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
1322 pWDS = (VkWriteDescriptorSet*)pFreeUpdate;
Tony Barbourf740f902015-11-02 11:46:29 -07001323 switch (pWDS->descriptorType) {
1324 case VK_DESCRIPTOR_TYPE_SAMPLER:
1325 case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
1326 case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
1327 case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
1328 {
1329 delete[] pWDS->pImageInfo;
1330 }
1331 break;
1332 case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
1333 case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
1334 {
1335 delete[] pWDS->pTexelBufferView;
1336 }
1337 break;
1338 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER:
1339 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER:
1340 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
1341 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
1342 {
1343 delete[] pWDS->pBufferInfo;
1344 }
1345 break;
1346 default:
1347 break;
Courtney Goeltzenleuchtere4099742015-10-22 15:31:56 -06001348 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001349 break;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001350 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001351 break;
1352 default:
1353 assert(0);
1354 break;
1355 }
Tobin Ehliseaf28662015-04-08 10:58:37 -06001356 delete pFreeUpdate;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001357 }
1358}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001359
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001360// Free all DS Pools including their Sets & related sub-structs
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001361// NOTE : Calls to this function should be wrapped in mutex
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001362static void deletePools(layer_data* my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001363{
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001364 if (my_data->descriptorPoolMap.size() <= 0)
David Pinedof5997ab2015-04-27 16:36:17 -06001365 return;
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001366 for (auto ii=my_data->descriptorPoolMap.begin(); ii!=my_data->descriptorPoolMap.end(); ++ii) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001367 SET_NODE* pSet = (*ii).second->pSets;
1368 SET_NODE* pFreeSet = pSet;
1369 while (pSet) {
1370 pFreeSet = pSet;
1371 pSet = pSet->pNext;
Tobin Ehliseaf28662015-04-08 10:58:37 -06001372 // Freeing layouts handled in deleteLayouts() function
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001373 // Free Update shadow struct tree
1374 freeShadowUpdateTree(pFreeSet);
1375 if (pFreeSet->ppDescriptors) {
Chris Forbes4506d3f2015-06-04 10:49:27 +12001376 delete[] pFreeSet->ppDescriptors;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001377 }
1378 delete pFreeSet;
1379 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001380 delete (*ii).second;
1381 }
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001382 my_data->descriptorPoolMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001383}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001384
Tobin Ehliseaf28662015-04-08 10:58:37 -06001385// WARN : Once deleteLayouts() called, any layout ptrs in Pool/Set data structure will be invalid
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001386// NOTE : Calls to this function should be wrapped in mutex
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001387static void deleteLayouts(layer_data* my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001388{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001389 if (my_data->layoutMap.size() <= 0)
David Pinedof5997ab2015-04-27 16:36:17 -06001390 return;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001391 for (auto ii=my_data->layoutMap.begin(); ii!=my_data->layoutMap.end(); ++ii) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001392 LAYOUT_NODE* pLayout = (*ii).second;
Chia-I Wuf03cbf72015-10-31 00:31:16 +08001393 if (pLayout->createInfo.pBinding) {
Chia-I Wu763a7492015-10-26 20:48:51 +08001394 for (uint32_t i=0; i<pLayout->createInfo.bindingCount; i++) {
Chia-I Wuf03cbf72015-10-31 00:31:16 +08001395 if (pLayout->createInfo.pBinding[i].pImmutableSamplers)
1396 delete[] pLayout->createInfo.pBinding[i].pImmutableSamplers;
Tobin Ehliseaf28662015-04-08 10:58:37 -06001397 }
Chia-I Wuf03cbf72015-10-31 00:31:16 +08001398 delete[] pLayout->createInfo.pBinding;
Tobin Ehliseaf28662015-04-08 10:58:37 -06001399 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001400 delete pLayout;
1401 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001402 my_data->layoutMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001403}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001404
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001405// Currently clearing a set is removing all previous updates to that set
1406// TODO : Validate if this is correct clearing behavior
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001407static void clearDescriptorSet(layer_data* my_data, VkDescriptorSet set)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001408{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001409 SET_NODE* pSet = getSetNode(my_data, set);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001410 if (!pSet) {
1411 // TODO : Return error
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001412 } else {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001413 loader_platform_thread_lock_mutex(&globalLock);
1414 freeShadowUpdateTree(pSet);
1415 loader_platform_thread_unlock_mutex(&globalLock);
1416 }
1417}
1418
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06001419static void clearDescriptorPool(layer_data* my_data, const VkDevice device, const VkDescriptorPool pool, VkDescriptorPoolResetFlags flags)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001420{
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001421 DESCRIPTOR_POOL_NODE* pPool = getPoolNode(my_data, pool);
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001422 if (!pPool) {
Chia-I Wue420a332015-10-26 20:04:44 +08001423 log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_POOL, (uint64_t) pool, 0, DRAWSTATE_INVALID_POOL, "DS",
1424 "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkResetDescriptorPool() call", (uint64_t) pool);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001425 } else {
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06001426 // TODO: validate flags
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001427 // For every set off of this pool, clear it
1428 SET_NODE* pSet = pPool->pSets;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001429 while (pSet) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001430 clearDescriptorSet(my_data, pSet->set);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001431 }
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001432 // Reset available count to max count for this pool
1433 for (uint32_t i=0; i<pPool->availableDescriptorTypeCount.size(); ++i) {
1434 pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i];
1435 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001436 }
1437}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001438
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001439// For given CB object, fetch associated CB Node from map
Chia-I Wu1f851912015-10-27 18:04:07 +08001440static GLOBAL_CB_NODE* getCBNode(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001441{
1442 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinski13b66742015-11-20 14:33:48 -07001443 if (my_data->commandBufferMap.count(cb) == 0) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001444 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06001445 // TODO : How to pass cb as srcObj here?
Chia-I Wu1f851912015-10-27 18:04:07 +08001446 log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
1447 "Attempt to use CommandBuffer %#" PRIxLEAST64 " that doesn't exist!", reinterpret_cast<uint64_t>(cb));
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001448 return NULL;
1449 }
1450 loader_platform_thread_unlock_mutex(&globalLock);
Chia-I Wu1f851912015-10-27 18:04:07 +08001451 return my_data->commandBufferMap[cb];
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001452}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001453
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001454// Free all CB Nodes
1455// NOTE : Calls to this function should be wrapped in mutex
Chia-I Wu1f851912015-10-27 18:04:07 +08001456static void deleteCommandBuffers(layer_data* my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001457{
Mark Lobodzinski13b66742015-11-20 14:33:48 -07001458 if (my_data->commandBufferMap.size() <= 0) {
David Pinedof5997ab2015-04-27 16:36:17 -06001459 return;
Mark Lobodzinski13b66742015-11-20 14:33:48 -07001460 }
Chia-I Wu1f851912015-10-27 18:04:07 +08001461 for (auto ii=my_data->commandBufferMap.begin(); ii!=my_data->commandBufferMap.end(); ++ii) {
Courtney Goeltzenleuchter09098a72015-04-27 15:04:43 -06001462 vector<CMD_NODE*> cmd_node_list = (*ii).second->pCmds;
1463 while (!cmd_node_list.empty()) {
1464 CMD_NODE* cmd_node = cmd_node_list.back();
1465 delete cmd_node;
1466 cmd_node_list.pop_back();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001467 }
1468 delete (*ii).second;
1469 }
Chia-I Wu1f851912015-10-27 18:04:07 +08001470 my_data->commandBufferMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001471}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001472
Chia-I Wu1f851912015-10-27 18:04:07 +08001473static VkBool32 report_error_no_cb_begin(const layer_data* dev_data, const VkCommandBuffer cb, const char* caller_name)
Tobin Ehlise42007c2015-06-19 13:00:59 -06001474{
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06001475 // TODO : How to pass cb as srcObj here?
Chia-I Wu1f851912015-10-27 18:04:07 +08001476 return log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001477 "You must call vkBeginCommandBuffer() before this call to %s", caller_name);
Tobin Ehlise42007c2015-06-19 13:00:59 -06001478}
Michael Lentine2b9eda42015-10-28 15:55:18 -07001479
1480bool validateCmdsInCmdBuffer(const layer_data* dev_data, const GLOBAL_CB_NODE* pCB, const CMD_TYPE cmd_type) {
1481 bool skip_call = false;
1482 for (auto cmd : pCB->pCmds) {
1483 if (cmd_type == CMD_EXECUTECOMMANDS && cmd->type != CMD_EXECUTECOMMANDS) {
1484 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
1485 "vkCmdExecuteCommands() cannot be called on a cmd buffer with exsiting commands.");
1486 }
1487 if (cmd_type != CMD_EXECUTECOMMANDS && cmd->type == CMD_EXECUTECOMMANDS) {
1488 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
1489 "Commands cannot be added to a cmd buffer with exsiting secondary commands.");
1490 }
1491 }
1492 return skip_call;
1493}
1494
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001495static VkBool32 addCmd(const layer_data* my_data, GLOBAL_CB_NODE* pCB, const CMD_TYPE cmd)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001496{
Michael Lentine2b9eda42015-10-28 15:55:18 -07001497 VkBool32 skipCall = validateCmdsInCmdBuffer(my_data, pCB, cmd);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001498 CMD_NODE* pCmd = new CMD_NODE;
1499 if (pCmd) {
1500 // init cmd node and append to end of cmd LL
1501 memset(pCmd, 0, sizeof(CMD_NODE));
1502 pCmd->cmdNumber = ++pCB->numCmds;
1503 pCmd->type = cmd;
1504 pCB->pCmds.push_back(pCmd);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001505 } else {
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06001506 // TODO : How to pass cb as srcObj here?
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001507 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08001508 "Out of memory while attempting to allocate new CMD_NODE for commandBuffer %#" PRIxLEAST64, reinterpret_cast<uint64_t>(pCB->commandBuffer));
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001509 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001510 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001511}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001512
Chia-I Wu1f851912015-10-27 18:04:07 +08001513static void resetCB(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001514{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001515 GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001516 if (pCB) {
Courtney Goeltzenleuchterf03711e2015-04-27 17:16:56 -06001517 vector<CMD_NODE*> cmd_list = pCB->pCmds;
1518 while (!cmd_list.empty()) {
1519 delete cmd_list.back();
1520 cmd_list.pop_back();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001521 }
Courtney Goeltzenleuchterf03711e2015-04-27 17:16:56 -06001522 pCB->pCmds.clear();
Tobin Ehlis0cea4082015-08-18 07:10:58 -06001523 // Reset CB state (need to save createInfo)
Chia-I Wu1f851912015-10-27 18:04:07 +08001524 VkCommandBufferAllocateInfo saveCBCI = pCB->createInfo;
Chia-I Wu1f851912015-10-27 18:04:07 +08001525 pCB->commandBuffer = cb;
Tobin Ehlis0cea4082015-08-18 07:10:58 -06001526 pCB->createInfo = saveCBCI;
Michael Lentine27b0f902015-10-12 11:30:14 -05001527 memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo));
1528 pCB->fence = 0;
1529 pCB->numCmds = 0;
1530 memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t));
1531 pCB->state = CB_NEW;
1532 pCB->submitCount = 0;
1533 pCB->status = 0;
1534 pCB->pCmds.clear();
1535 pCB->lastBoundPipeline = 0;
1536 pCB->viewports.clear();
1537 pCB->scissors.clear();
1538 pCB->lineWidth = 0;
1539 pCB->depthBiasConstantFactor = 0;
1540 pCB->depthBiasClamp = 0;
1541 pCB->depthBiasSlopeFactor = 0;
1542 memset(pCB->blendConstants, 0, 4 * sizeof(float));
1543 pCB->minDepthBounds = 0;
1544 pCB->maxDepthBounds = 0;
1545 memset(&pCB->front, 0, sizeof(stencil_data));
1546 memset(&pCB->back, 0, sizeof(stencil_data));
1547 pCB->lastBoundDescriptorSet = 0;
1548 pCB->lastBoundPipelineLayout = 0;
1549 pCB->activeRenderPass = 0;
1550 pCB->activeSubpass = 0;
1551 pCB->framebuffer = 0;
Michael Lentine27b0f902015-10-12 11:30:14 -05001552 pCB->boundDescriptorSets.clear();
1553 pCB->imageLayoutMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001554 pCB->lastVtxBinding = MAX_BINDING;
1555 }
1556}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001557
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001558// Set PSO-related status bits for CB, including dynamic state set via PSO
Tobin Ehlis97866202015-06-10 12:57:07 -06001559static void set_cb_pso_status(GLOBAL_CB_NODE* pCB, const PIPELINE_NODE* pPipe)
1560{
1561 for (uint32_t i = 0; i < pPipe->cbStateCI.attachmentCount; i++) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08001562 if (0 != pPipe->pAttachments[i].colorWriteMask) {
Tobin Ehlis97866202015-06-10 12:57:07 -06001563 pCB->status |= CBSTATUS_COLOR_BLEND_WRITE_ENABLE;
1564 }
1565 }
1566 if (pPipe->dsStateCI.depthWriteEnable) {
Cody Northrop2605cb02015-08-18 15:21:16 -06001567 pCB->status |= CBSTATUS_DEPTH_WRITE_ENABLE;
1568 }
Cody Northrop2605cb02015-08-18 15:21:16 -06001569 if (pPipe->dsStateCI.stencilTestEnable) {
1570 pCB->status |= CBSTATUS_STENCIL_TEST_ENABLE;
Tobin Ehlis97866202015-06-10 12:57:07 -06001571 }
Tobin Ehlisa88e2f52015-10-02 11:00:56 -06001572 // Account for any dynamic state not set via this PSO
1573 if (!pPipe->dynStateCI.dynamicStateCount) { // All state is static
1574 pCB->status = CBSTATUS_ALL;
1575 } else {
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001576 // First consider all state on
1577 // Then unset any state that's noted as dynamic in PSO
1578 // Finally OR that into CB statemask
1579 CBStatusFlags psoDynStateMask = CBSTATUS_ALL;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001580 for (uint32_t i=0; i < pPipe->dynStateCI.dynamicStateCount; i++) {
1581 switch (pPipe->dynStateCI.pDynamicStates[i]) {
1582 case VK_DYNAMIC_STATE_VIEWPORT:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001583 psoDynStateMask &= ~CBSTATUS_VIEWPORT_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001584 break;
1585 case VK_DYNAMIC_STATE_SCISSOR:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001586 psoDynStateMask &= ~CBSTATUS_SCISSOR_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001587 break;
1588 case VK_DYNAMIC_STATE_LINE_WIDTH:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001589 psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001590 break;
1591 case VK_DYNAMIC_STATE_DEPTH_BIAS:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001592 psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001593 break;
1594 case VK_DYNAMIC_STATE_BLEND_CONSTANTS:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001595 psoDynStateMask &= ~CBSTATUS_BLEND_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001596 break;
1597 case VK_DYNAMIC_STATE_DEPTH_BOUNDS:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001598 psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001599 break;
1600 case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001601 psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001602 break;
1603 case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001604 psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001605 break;
1606 case VK_DYNAMIC_STATE_STENCIL_REFERENCE:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001607 psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001608 break;
1609 default:
1610 // TODO : Flag error here
1611 break;
1612 }
1613 }
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001614 pCB->status |= psoDynStateMask;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001615 }
Tobin Ehlis97866202015-06-10 12:57:07 -06001616}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001617
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001618// Print the last bound Gfx Pipeline
Chia-I Wu1f851912015-10-27 18:04:07 +08001619static VkBool32 printPipeline(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001620{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001621 VkBool32 skipCall = VK_FALSE;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001622 GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001623 if (pCB) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001624 PIPELINE_NODE *pPipeTrav = getPipeline(my_data, pCB->lastBoundPipeline);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001625 if (!pPipeTrav) {
1626 // nothing to print
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001627 } else {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001628 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001629 "%s", vk_print_vkgraphicspipelinecreateinfo(&pPipeTrav->graphicsPipelineCI, "{DS}").c_str());
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001630 }
1631 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001632 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001633}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001634
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001635// Print details of DS config to stdout
Chia-I Wu1f851912015-10-27 18:04:07 +08001636static VkBool32 printDSConfig(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001637{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001638 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001639 char ds_config_str[1024*256] = {0}; // TODO : Currently making this buffer HUGE w/o overrun protection. Need to be smarter, start smaller, and grow as needed.
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001640 GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb);
Tobin Ehlis7297f192015-06-09 08:39:32 -06001641 if (pCB && pCB->lastBoundDescriptorSet) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001642 SET_NODE* pSet = getSetNode(my_data, pCB->lastBoundDescriptorSet);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001643 DESCRIPTOR_POOL_NODE* pPool = getPoolNode(my_data, pSet->pool);
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001644 // Print out pool details
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001645 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001646 "Details for pool %#" PRIxLEAST64 ".", (uint64_t) pPool->pool);
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06001647 string poolStr = vk_print_vkdescriptorpoolcreateinfo(&pPool->createInfo, " ");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001648 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001649 "%s", poolStr.c_str());
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001650 // Print out set details
1651 char prefix[10];
1652 uint32_t index = 0;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001653 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001654 "Details for descriptor set %#" PRIxLEAST64 ".", (uint64_t) pSet->set);
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001655 LAYOUT_NODE* pLayout = pSet->pLayout;
1656 // Print layout details
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001657 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001658 "Layout #%u, (object %#" PRIxLEAST64 ") for DS %#" PRIxLEAST64 ".", index+1, reinterpret_cast<uint64_t>(pLayout->layout), reinterpret_cast<uint64_t>(pSet->set));
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001659 sprintf(prefix, " [L%u] ", index);
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06001660 string DSLstr = vk_print_vkdescriptorsetlayoutcreateinfo(&pLayout->createInfo, prefix).c_str();
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001661 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001662 "%s", DSLstr.c_str());
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001663 index++;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001664 GENERIC_HEADER* pUpdate = pSet->pUpdateStructs;
1665 if (pUpdate) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001666 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001667 "Update Chain [UC] for descriptor set %#" PRIxLEAST64 ":", (uint64_t) pSet->set);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001668 sprintf(prefix, " [UC] ");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001669 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001670 "%s", dynamic_display(pUpdate, prefix).c_str());
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001671 // TODO : If there is a "view" associated with this update, print CI for that view
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001672 } else {
Tobin Ehlis2bca8b02015-06-15 08:41:17 -06001673 if (0 != pSet->descriptorCount) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001674 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001675 "No Update Chain for descriptor set %#" PRIxLEAST64 " which has %u descriptors (vkUpdateDescriptors has not been called)", (uint64_t) pSet->set, pSet->descriptorCount);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001676 } else {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001677 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001678 "FYI: No descriptors in descriptor set %#" PRIxLEAST64 ".", (uint64_t) pSet->set);
Tobin Ehlis2bca8b02015-06-15 08:41:17 -06001679 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001680 }
1681 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001682 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001683}
1684
Chia-I Wu1f851912015-10-27 18:04:07 +08001685static void printCB(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001686{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001687 GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb);
David Pinedof5997ab2015-04-27 16:36:17 -06001688 if (pCB && pCB->pCmds.size() > 0) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001689 log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001690 "Cmds in CB %p", (void*)cb);
Courtney Goeltzenleuchtercf2a5362015-04-27 11:16:35 -06001691 vector<CMD_NODE*> pCmds = pCB->pCmds;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06001692 for (auto ii=pCmds.begin(); ii!=pCmds.end(); ++ii) {
1693 // TODO : Need to pass cb as srcObj here
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001694 log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001695 " CMD#%" PRIu64 ": %s", (*ii)->cmdNumber, cmdTypeToString((*ii)->type).c_str());
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001696 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001697 } else {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001698 // Nothing to print
1699 }
1700}
1701
Chia-I Wu1f851912015-10-27 18:04:07 +08001702static VkBool32 synchAndPrintDSConfig(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001703{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001704 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001705 if (!(my_data->report_data->active_flags & VK_DBG_REPORT_INFO_BIT)) {
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001706 return skipCall;
Mike Stroyanfa2f2222015-08-12 17:11:28 -06001707 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001708 skipCall |= printDSConfig(my_data, cb);
1709 skipCall |= printPipeline(my_data, cb);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001710 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001711}
1712
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001713// Flags validation error if the associated call is made inside a render pass. The apiName
1714// routine should ONLY be called outside a render pass.
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001715static VkBool32 insideRenderPass(const layer_data* my_data, GLOBAL_CB_NODE *pCB, const char *apiName)
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001716{
1717 VkBool32 inside = VK_FALSE;
1718 if (pCB->activeRenderPass) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001719 inside = log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER,
Chia-I Wu1f851912015-10-27 18:04:07 +08001720 (uint64_t)pCB->commandBuffer, 0, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS",
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001721 "%s: It is invalid to issue this call inside an active render pass (%#" PRIxLEAST64 ")",
Chia-I Wue420a332015-10-26 20:04:44 +08001722 apiName, (uint64_t) pCB->activeRenderPass);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001723 }
1724 return inside;
1725}
1726
1727// Flags validation error if the associated call is made outside a render pass. The apiName
1728// routine should ONLY be called inside a render pass.
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001729static VkBool32 outsideRenderPass(const layer_data* my_data, GLOBAL_CB_NODE *pCB, const char *apiName)
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001730{
1731 VkBool32 outside = VK_FALSE;
1732 if (!pCB->activeRenderPass) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001733 outside = log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER,
Chia-I Wu1f851912015-10-27 18:04:07 +08001734 (uint64_t)pCB->commandBuffer, 0, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS",
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001735 "%s: This call must be issued inside an active render pass.", apiName);
1736 }
1737 return outside;
1738}
1739
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001740static void init_draw_state(layer_data *my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001741{
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001742 uint32_t report_flags = 0;
1743 uint32_t debug_action = 0;
1744 FILE *log_output = NULL;
1745 const char *option_str;
Courtney Goeltzenleuchter1781b1c2015-10-05 15:58:38 -06001746 VkDbgMsgCallback callback;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001747 // initialize DrawState options
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001748 report_flags = getLayerOptionFlags("DrawStateReportFlags", 0);
1749 getLayerOptionEnum("DrawStateDebugAction", (uint32_t *) &debug_action);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001750
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001751 if (debug_action & VK_DBG_LAYER_ACTION_LOG_MSG)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001752 {
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001753 option_str = getLayerOption("DrawStateLogFilename");
Tobin Ehlisb4b6e7c2015-09-15 09:55:54 -06001754 log_output = getLayerLogOutput(option_str, "DrawState");
Courtney Goeltzenleuchter1781b1c2015-10-05 15:58:38 -06001755 layer_create_msg_callback(my_data->report_data, report_flags, log_callback, (void *) log_output, &callback);
1756 my_data->logging_callback.push_back(callback);
1757 }
1758
1759 if (debug_action & VK_DBG_LAYER_ACTION_DEBUG_OUTPUT) {
1760 layer_create_msg_callback(my_data->report_data, report_flags, win32_debug_output_msg, NULL, &callback);
1761 my_data->logging_callback.push_back(callback);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001762 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001763
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001764 if (!globalLockInitialized)
1765 {
Mike Stroyand9dd0072015-08-18 15:56:18 -06001766 // This mutex may be deleted by vkDestroyInstance of last instance.
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001767 loader_platform_thread_create_mutex(&globalLock);
1768 globalLockInitialized = 1;
1769 }
1770}
1771
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001772VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(const VkInstanceCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkInstance* pInstance)
Courtney Goeltzenleuchter3c9f6ec2015-06-01 14:29:58 -06001773{
Tobin Ehliscb085292015-12-01 09:57:09 -07001774 // TODOSC : Shouldn't need any customization here
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001775 layer_data *my_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map);
1776 VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table;
Chia-I Wu69f40122015-10-26 21:10:41 +08001777 VkResult result = pTable->CreateInstance(pCreateInfo, pAllocator, pInstance);
Courtney Goeltzenleuchter3c9f6ec2015-06-01 14:29:58 -06001778
1779 if (result == VK_SUCCESS) {
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001780 layer_data *my_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map);
1781 my_data->report_data = debug_report_create_instance(
1782 pTable,
1783 *pInstance,
Chia-I Wu763a7492015-10-26 20:48:51 +08001784 pCreateInfo->enabledExtensionNameCount,
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001785 pCreateInfo->ppEnabledExtensionNames);
Courtney Goeltzenleuchterf4a2eba2015-06-08 14:58:39 -06001786
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001787 init_draw_state(my_data);
Courtney Goeltzenleuchter3c9f6ec2015-06-01 14:29:58 -06001788 }
1789 return result;
1790}
1791
Jon Ashburne0fa2282015-05-20 09:00:28 -06001792/* hook DestroyInstance to remove tableInstanceMap entry */
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001793VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks* pAllocator)
Jon Ashburne0fa2282015-05-20 09:00:28 -06001794{
Tobin Ehliscb085292015-12-01 09:57:09 -07001795 // TODOSC : Shouldn't need any customization here
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001796 dispatch_key key = get_dispatch_key(instance);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001797 layer_data *my_data = get_my_data_ptr(key, layer_data_map);
1798 VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table;
Chia-I Wu69f40122015-10-26 21:10:41 +08001799 pTable->DestroyInstance(instance, pAllocator);
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001800
1801 // Clean up logging callback, if any
Courtney Goeltzenleuchter1781b1c2015-10-05 15:58:38 -06001802 while (my_data->logging_callback.size() > 0) {
1803 VkDbgMsgCallback callback = my_data->logging_callback.back();
1804 layer_destroy_msg_callback(my_data->report_data, callback);
1805 my_data->logging_callback.pop_back();
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001806 }
1807
Courtney Goeltzenleuchter2d034fd2015-06-28 13:01:17 -06001808 layer_debug_report_destroy_instance(my_data->report_data);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001809 delete my_data->instance_dispatch_table;
1810 layer_data_map.erase(key);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001811 // TODO : Potential race here with separate threads creating/destroying instance
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001812 if (layer_data_map.empty()) {
Mike Stroyand9dd0072015-08-18 15:56:18 -06001813 // Release mutex when destroying last instance.
1814 loader_platform_thread_delete_mutex(&globalLock);
1815 globalLockInitialized = 0;
1816 }
Jon Ashburne0fa2282015-05-20 09:00:28 -06001817}
1818
Jon Ashburnf0615e22015-05-25 14:11:37 -06001819static void createDeviceRegisterExtensions(const VkDeviceCreateInfo* pCreateInfo, VkDevice device)
1820{
Tony Barbour29b12062015-07-13 13:37:24 -06001821 uint32_t i;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001822 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
1823 dev_data->device_extensions.debug_marker_enabled = false;
Michael Lentine27b0f902015-10-12 11:30:14 -05001824 dev_data->device_extensions.wsi_enabled = false;
1825
1826
1827 VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table;
1828 PFN_vkGetDeviceProcAddr gpa = pDisp->GetDeviceProcAddr;
1829
Michael Lentine27b0f902015-10-12 11:30:14 -05001830 pDisp->CreateSwapchainKHR = (PFN_vkCreateSwapchainKHR) gpa(device, "vkCreateSwapchainKHR");
1831 pDisp->DestroySwapchainKHR = (PFN_vkDestroySwapchainKHR) gpa(device, "vkDestroySwapchainKHR");
1832 pDisp->GetSwapchainImagesKHR = (PFN_vkGetSwapchainImagesKHR) gpa(device, "vkGetSwapchainImagesKHR");
1833 pDisp->AcquireNextImageKHR = (PFN_vkAcquireNextImageKHR) gpa(device, "vkAcquireNextImageKHR");
1834 pDisp->QueuePresentKHR = (PFN_vkQueuePresentKHR) gpa(device, "vkQueuePresentKHR");
Jon Ashburnf0615e22015-05-25 14:11:37 -06001835
Chia-I Wu763a7492015-10-26 20:48:51 +08001836 for (i = 0; i < pCreateInfo->enabledExtensionNameCount; i++) {
Ian Elliottc623ba52015-11-20 14:13:17 -07001837 if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) {
Michael Lentine27b0f902015-10-12 11:30:14 -05001838 dev_data->device_extensions.wsi_enabled = true;
1839 }
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001840 if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], DEBUG_MARKER_EXTENSION_NAME) == 0) {
Jon Ashburn6f8cd632015-06-01 09:37:38 -06001841 /* Found a matching extension name, mark it enabled and init dispatch table*/
1842 initDebugMarkerTable(device);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001843 dev_data->device_extensions.debug_marker_enabled = true;
Jon Ashburnf0615e22015-05-25 14:11:37 -06001844 }
Jon Ashburnf0615e22015-05-25 14:11:37 -06001845 }
1846}
1847
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001848VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDevice* pDevice)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001849{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001850 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08001851 VkResult result = dev_data->device_dispatch_table->CreateDevice(gpu, pCreateInfo, pAllocator, pDevice);
Tobin Ehliscb085292015-12-01 09:57:09 -07001852 // TODOSC : shouldn't need any customization here
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001853 if (result == VK_SUCCESS) {
1854 layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), layer_data_map);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001855 dev_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice);
Jon Ashburn7e07faf2015-06-18 15:02:58 -06001856 createDeviceRegisterExtensions(pCreateInfo, *pDevice);
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001857 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001858 return result;
1859}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001860
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001861// prototype
1862static void deleteRenderPasses(layer_data*);
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001863VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001864{
Tobin Ehliscb085292015-12-01 09:57:09 -07001865 // TODOSC : Shouldn't need any customization here
Jeremy Hayesea1fef52015-06-19 11:37:38 -06001866 dispatch_key key = get_dispatch_key(device);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001867 layer_data* dev_data = get_my_data_ptr(key, layer_data_map);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001868 // Free all the memory
1869 loader_platform_thread_lock_mutex(&globalLock);
1870 deletePipelines(dev_data);
1871 deleteRenderPasses(dev_data);
Chia-I Wu1f851912015-10-27 18:04:07 +08001872 deleteCommandBuffers(dev_data);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001873 deletePools(dev_data);
1874 deleteLayouts(dev_data);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001875 dev_data->imageViewMap.clear();
1876 dev_data->imageMap.clear();
1877 dev_data->bufferViewMap.clear();
1878 dev_data->bufferMap.clear();
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001879 loader_platform_thread_unlock_mutex(&globalLock);
1880
Chia-I Wu69f40122015-10-26 21:10:41 +08001881 dev_data->device_dispatch_table->DestroyDevice(device, pAllocator);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001882 tableDebugMarkerMap.erase(key);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001883 delete dev_data->device_dispatch_table;
1884 layer_data_map.erase(key);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001885}
1886
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001887static const VkLayerProperties ds_global_layers[] = {
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -06001888 {
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -06001889 "DrawState",
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001890 VK_API_VERSION,
1891 VK_MAKE_VERSION(0, 1, 0),
1892 "Validation layer: DrawState",
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -06001893 }
Jon Ashburneb2728b2015-04-10 14:33:07 -06001894};
1895
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001896VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001897 const char *pLayerName,
1898 uint32_t *pCount,
1899 VkExtensionProperties* pProperties)
Jon Ashburneb2728b2015-04-10 14:33:07 -06001900{
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001901 /* DrawState does not have any global extensions */
1902 return util_GetExtensionProperties(0, NULL, pCount, pProperties);
1903}
Jon Ashburneb2728b2015-04-10 14:33:07 -06001904
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001905VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001906 uint32_t *pCount,
1907 VkLayerProperties* pProperties)
1908{
1909 return util_GetLayerProperties(ARRAY_SIZE(ds_global_layers),
1910 ds_global_layers,
1911 pCount, pProperties);
1912}
Jon Ashburneb2728b2015-04-10 14:33:07 -06001913
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001914static const VkExtensionProperties ds_device_extensions[] = {
1915 {
1916 DEBUG_MARKER_EXTENSION_NAME,
1917 VK_MAKE_VERSION(0, 1, 0),
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001918 }
1919};
1920
1921static const VkLayerProperties ds_device_layers[] = {
1922 {
1923 "DrawState",
1924 VK_API_VERSION,
1925 VK_MAKE_VERSION(0, 1, 0),
1926 "Validation layer: DrawState",
1927 }
1928};
1929
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001930VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001931 VkPhysicalDevice physicalDevice,
1932 const char* pLayerName,
1933 uint32_t* pCount,
1934 VkExtensionProperties* pProperties)
1935{
Jon Ashburnaff81ff2015-11-02 17:37:20 -07001936 if (pLayerName == NULL) {
1937 dispatch_key key = get_dispatch_key(physicalDevice);
1938 layer_data *my_data = get_my_data_ptr(key, layer_data_map);
1939 VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table;
1940 return pTable->EnumerateDeviceExtensionProperties(
1941 physicalDevice,
1942 NULL,
1943 pCount,
1944 pProperties);
1945 } else {
1946 return util_GetExtensionProperties(ARRAY_SIZE(ds_device_extensions),
1947 ds_device_extensions,
1948 pCount, pProperties);
1949 }
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001950}
1951
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001952VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001953 VkPhysicalDevice physicalDevice,
1954 uint32_t* pCount,
1955 VkLayerProperties* pProperties)
1956{
1957 /* Mem tracker's physical device layers are the same as global */
1958 return util_GetLayerProperties(ARRAY_SIZE(ds_device_layers), ds_device_layers,
1959 pCount, pProperties);
Jon Ashburneb2728b2015-04-10 14:33:07 -06001960}
1961
Michael Lentine27b0f902015-10-12 11:30:14 -05001962bool ValidateCmdBufImageLayouts(VkCommandBuffer cmdBuffer) {
1963 bool skip_call = false;
1964 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
1965 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
1966 for (auto cb_image_data : pCB->imageLayoutMap) {
1967 auto image_data = dev_data->imageLayoutMap.find(cb_image_data.first);
1968 if (image_data == dev_data->imageLayoutMap.end()) {
1969 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001970 "Cannot submit cmd buffer using deleted image %" PRIu64 ".", reinterpret_cast<uint64_t>(cb_image_data.first));
Michael Lentine27b0f902015-10-12 11:30:14 -05001971 } else {
1972 if (dev_data->imageLayoutMap[cb_image_data.first]->layout != cb_image_data.second.initialLayout) {
1973 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
1974 "Cannot submit cmd buffer using image with layout %d when first use is %d.", dev_data->imageLayoutMap[cb_image_data.first]->layout, cb_image_data.second.initialLayout);
1975 }
1976 dev_data->imageLayoutMap[cb_image_data.first]->layout = cb_image_data.second.layout;
1977 }
1978 }
1979 return skip_call;
1980}
1981
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001982VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo* pSubmits, VkFence fence)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001983{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001984 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis28be0be2015-05-22 12:38:16 -06001985 GLOBAL_CB_NODE* pCB = NULL;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001986 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map);
Courtney Goeltzenleuchter3ec31622015-10-20 18:04:07 -06001987 for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) {
Chia-I Wu483e7702015-10-26 17:20:32 +08001988 const VkSubmitInfo *submit = &pSubmits[submit_idx];
Chia-I Wu763a7492015-10-26 20:48:51 +08001989 for (uint32_t i=0; i < submit->commandBufferCount; i++) {
Mark Lobodzinski78940a42015-11-30 16:48:53 -07001990
1991#ifndef DISABLE_IMAGE_LAYOUT_VALIDATION
1992 skipCall |= ValidateCmdBufImageLayouts(submit->pCommandBuffers[i]);
1993#endif // DISABLE_IMAGE_LAYOUT_VALIDATION
1994
Courtney Goeltzenleuchter3ec31622015-10-20 18:04:07 -06001995 // Validate that cmd buffers have been updated
1996 pCB = getCBNode(dev_data, submit->pCommandBuffers[i]);
1997 loader_platform_thread_lock_mutex(&globalLock);
1998 pCB->submitCount++; // increment submit count
Chia-I Wu1f851912015-10-27 18:04:07 +08001999 if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) {
2000 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05002001 "CB %#" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT set, but has been submitted %#" PRIxLEAST64 " times.",
2002 reinterpret_cast<uint64_t>(pCB->commandBuffer), pCB->submitCount);
Courtney Goeltzenleuchter3ec31622015-10-20 18:04:07 -06002003 }
2004 if (CB_UPDATE_COMPLETE != pCB->state) {
2005 // Flag error for using CB w/o vkEndCommandBuffer() called
2006 // TODO : How to pass cb as srcObj?
Chia-I Wu1f851912015-10-27 18:04:07 +08002007 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS",
2008 "You must call vkEndCommandBuffer() on CB %#" PRIxLEAST64 " before this call to vkQueueSubmit()!", reinterpret_cast<uint64_t>(pCB->commandBuffer));
Courtney Goeltzenleuchter3ec31622015-10-20 18:04:07 -06002009 loader_platform_thread_unlock_mutex(&globalLock);
2010 return VK_ERROR_VALIDATION_FAILED;
2011 }
Tobin Ehlise90b1712015-05-27 14:30:06 -06002012 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis28be0be2015-05-22 12:38:16 -06002013 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002014 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002015 if (VK_FALSE == skipCall)
Chia-I Wu483e7702015-10-26 17:20:32 +08002016 return dev_data->device_dispatch_table->QueueSubmit(queue, submitCount, pSubmits, fence);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002017 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002018}
2019
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002020VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002021{
Chia-I Wu69f40122015-10-26 21:10:41 +08002022 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyFence(device, fence, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002023 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002024}
2025
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002026VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002027{
Chia-I Wu69f40122015-10-26 21:10:41 +08002028 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySemaphore(device, semaphore, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002029 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002030}
2031
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002032VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002033{
Chia-I Wu69f40122015-10-26 21:10:41 +08002034 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyEvent(device, event, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002035 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002036}
2037
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002038VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002039{
Chia-I Wu69f40122015-10-26 21:10:41 +08002040 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyQueryPool(device, queryPool, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002041 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002042}
2043
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002044VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyBuffer(VkDevice device, VkBuffer buffer, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002045{
Tobin Ehlisb46be812015-10-23 16:00:08 -06002046 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002047 dev_data->device_dispatch_table->DestroyBuffer(device, buffer, pAllocator);
Chia-I Wue420a332015-10-26 20:04:44 +08002048 dev_data->bufferMap.erase(buffer);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002049}
2050
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002051VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002052{
Tobin Ehlisb46be812015-10-23 16:00:08 -06002053 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002054 dev_data->device_dispatch_table->DestroyBufferView(device, bufferView, pAllocator);
Chia-I Wue420a332015-10-26 20:04:44 +08002055 dev_data->bufferViewMap.erase(bufferView);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002056}
2057
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002058VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002059{
Tobin Ehlisb46be812015-10-23 16:00:08 -06002060 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002061 dev_data->device_dispatch_table->DestroyImage(device, image, pAllocator);
Chia-I Wue420a332015-10-26 20:04:44 +08002062 dev_data->imageMap.erase(image);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002063}
2064
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002065VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002066{
Chia-I Wu69f40122015-10-26 21:10:41 +08002067 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyImageView(device, imageView, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002068 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002069}
2070
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002071VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002072{
Chia-I Wu69f40122015-10-26 21:10:41 +08002073 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyShaderModule(device, shaderModule, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002074 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002075}
2076
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002077VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002078{
Chia-I Wu69f40122015-10-26 21:10:41 +08002079 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipeline(device, pipeline, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002080 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002081}
2082
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002083VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002084{
Chia-I Wu69f40122015-10-26 21:10:41 +08002085 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipelineLayout(device, pipelineLayout, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002086 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002087}
2088
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002089VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002090{
Chia-I Wu69f40122015-10-26 21:10:41 +08002091 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySampler(device, sampler, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002092 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002093}
2094
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002095VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002096{
Chia-I Wu69f40122015-10-26 21:10:41 +08002097 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002098 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002099}
2100
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002101VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002102{
Chia-I Wu69f40122015-10-26 21:10:41 +08002103 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyDescriptorPool(device, descriptorPool, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002104 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002105}
2106
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002107VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t count, const VkCommandBuffer *pCommandBuffers)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002108{
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002109 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
2110
2111 for (auto i = 0; i < count; i++) {
2112 // Delete CB information structure, and remove from commandBufferMap
2113 auto cb = dev_data->commandBufferMap.find(pCommandBuffers[i]);
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002114 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002115 if (cb != dev_data->commandBufferMap.end()) {
2116 delete (*cb).second;
2117 dev_data->commandBufferMap.erase(cb);
2118 }
2119
2120 // Remove commandBuffer reference from commandPoolMap
2121 dev_data->commandPoolMap[commandPool].remove(pCommandBuffers[i]);
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002122 loader_platform_thread_unlock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002123 }
2124
2125 dev_data->device_dispatch_table->FreeCommandBuffers(device, commandPool, count, pCommandBuffers);
2126}
2127
2128VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkCommandPool* pCommandPool)
2129{
2130 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
2131
2132 VkResult result = dev_data->device_dispatch_table->CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
2133
2134 if (VK_SUCCESS == result) {
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002135 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002136 dev_data->commandPoolMap[*pCommandPool];
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002137 loader_platform_thread_unlock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002138 }
2139 return result;
2140}
2141
2142VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks* pAllocator)
2143{
2144 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002145 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002146
2147 // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandPoolMap
2148 if (dev_data->commandPoolMap.find(commandPool) != dev_data->commandPoolMap.end()) {
2149 for (auto poolCb = dev_data->commandPoolMap[commandPool].begin(); poolCb != dev_data->commandPoolMap[commandPool].end();) {
2150 auto del_cb = dev_data->commandBufferMap.find(*poolCb);
2151 delete (*del_cb).second; // delete CB info structure
2152 dev_data->commandBufferMap.erase(del_cb); // Remove this command buffer from cbMap
2153 poolCb = dev_data->commandPoolMap[commandPool].erase(poolCb); // Remove CB reference from commandPoolMap's list
2154 }
2155 }
2156 dev_data->commandPoolMap.erase(commandPool);
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002157
2158 loader_platform_thread_unlock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002159 dev_data->device_dispatch_table->DestroyCommandPool(device, commandPool, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002160}
2161
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002162VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002163{
Chia-I Wu69f40122015-10-26 21:10:41 +08002164 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyFramebuffer(device, framebuffer, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002165 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002166}
2167
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002168VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002169{
Chia-I Wu69f40122015-10-26 21:10:41 +08002170 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyRenderPass(device, renderPass, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002171 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002172}
2173
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002174VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBuffer(VkDevice device, const VkBufferCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkBuffer* pBuffer)
Tobin Ehlisb46be812015-10-23 16:00:08 -06002175{
2176 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002177 VkResult result = dev_data->device_dispatch_table->CreateBuffer(device, pCreateInfo, pAllocator, pBuffer);
Tobin Ehlisb46be812015-10-23 16:00:08 -06002178 if (VK_SUCCESS == result) {
2179 loader_platform_thread_lock_mutex(&globalLock);
2180 // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid
Chia-I Wue420a332015-10-26 20:04:44 +08002181 dev_data->bufferMap[*pBuffer] = unique_ptr<VkBufferCreateInfo>(new VkBufferCreateInfo(*pCreateInfo));
Tobin Ehlisb46be812015-10-23 16:00:08 -06002182 loader_platform_thread_unlock_mutex(&globalLock);
2183 }
2184 return result;
2185}
2186
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002187VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBufferView(VkDevice device, const VkBufferViewCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkBufferView* pView)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002188{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002189 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002190 VkResult result = dev_data->device_dispatch_table->CreateBufferView(device, pCreateInfo, pAllocator, pView);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002191 if (VK_SUCCESS == result) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002192 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08002193 dev_data->bufferViewMap[*pView] = unique_ptr<VkBufferViewCreateInfo>(new VkBufferViewCreateInfo(*pCreateInfo));
Tobin Ehlisb46be812015-10-23 16:00:08 -06002194 loader_platform_thread_unlock_mutex(&globalLock);
2195 }
2196 return result;
2197}
2198
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002199VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImage(VkDevice device, const VkImageCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkImage* pImage)
Tobin Ehlisb46be812015-10-23 16:00:08 -06002200{
2201 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002202 VkResult result = dev_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage);
Tobin Ehlisb46be812015-10-23 16:00:08 -06002203 if (VK_SUCCESS == result) {
Michael Lentine27b0f902015-10-12 11:30:14 -05002204 IMAGE_NODE* image_node = new IMAGE_NODE;
2205 image_node->layout = pCreateInfo->initialLayout;
Tobin Ehlisb46be812015-10-23 16:00:08 -06002206 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08002207 dev_data->imageMap[*pImage] = unique_ptr<VkImageCreateInfo>(new VkImageCreateInfo(*pCreateInfo));
Michael Lentine27b0f902015-10-12 11:30:14 -05002208 dev_data->imageLayoutMap[*pImage] = image_node;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002209 loader_platform_thread_unlock_mutex(&globalLock);
2210 }
2211 return result;
2212}
2213
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002214VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImageView(VkDevice device, const VkImageViewCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkImageView* pView)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002215{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002216 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002217 VkResult result = dev_data->device_dispatch_table->CreateImageView(device, pCreateInfo, pAllocator, pView);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002218 if (VK_SUCCESS == result) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002219 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08002220 dev_data->imageViewMap[*pView] = unique_ptr<VkImageViewCreateInfo>(new VkImageViewCreateInfo(*pCreateInfo));
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06002221 loader_platform_thread_unlock_mutex(&globalLock);
2222 }
2223 return result;
2224}
2225
Jon Ashburn0d60d272015-07-09 15:02:25 -06002226//TODO handle pipeline caches
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002227VKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineCache(
Jon Ashburn0d60d272015-07-09 15:02:25 -06002228 VkDevice device,
2229 const VkPipelineCacheCreateInfo* pCreateInfo,
Chia-I Wu1f851912015-10-27 18:04:07 +08002230 const VkAllocationCallbacks* pAllocator,
Jon Ashburn0d60d272015-07-09 15:02:25 -06002231 VkPipelineCache* pPipelineCache)
2232{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002233 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002234 VkResult result = dev_data->device_dispatch_table->CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache);
Jon Ashburn0d60d272015-07-09 15:02:25 -06002235 return result;
2236}
2237
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002238VKAPI_ATTR void VKAPI_CALL vkDestroyPipelineCache(
Jon Ashburn0d60d272015-07-09 15:02:25 -06002239 VkDevice device,
Chia-I Wu69f40122015-10-26 21:10:41 +08002240 VkPipelineCache pipelineCache,
Chia-I Wu1f851912015-10-27 18:04:07 +08002241 const VkAllocationCallbacks* pAllocator)
Jon Ashburn0d60d272015-07-09 15:02:25 -06002242{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002243 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002244 dev_data->device_dispatch_table->DestroyPipelineCache(device, pipelineCache, pAllocator);
Jon Ashburn0d60d272015-07-09 15:02:25 -06002245}
2246
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002247VKAPI_ATTR VkResult VKAPI_CALL vkGetPipelineCacheData(
Jon Ashburn0d60d272015-07-09 15:02:25 -06002248 VkDevice device,
2249 VkPipelineCache pipelineCache,
Chia-I Wu28c3c432015-10-26 19:17:06 +08002250 size_t* pDataSize,
Jon Ashburn0d60d272015-07-09 15:02:25 -06002251 void* pData)
2252{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002253 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu28c3c432015-10-26 19:17:06 +08002254 VkResult result = dev_data->device_dispatch_table->GetPipelineCacheData(device, pipelineCache, pDataSize, pData);
Jon Ashburn0d60d272015-07-09 15:02:25 -06002255 return result;
2256}
2257
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002258VKAPI_ATTR VkResult VKAPI_CALL vkMergePipelineCaches(
Jon Ashburn0d60d272015-07-09 15:02:25 -06002259 VkDevice device,
Chia-I Wu1f851912015-10-27 18:04:07 +08002260 VkPipelineCache dstCache,
Jon Ashburn0d60d272015-07-09 15:02:25 -06002261 uint32_t srcCacheCount,
2262 const VkPipelineCache* pSrcCaches)
2263{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002264 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu1f851912015-10-27 18:04:07 +08002265 VkResult result = dev_data->device_dispatch_table->MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches);
Jon Ashburn0d60d272015-07-09 15:02:25 -06002266 return result;
2267}
2268
Mark Lobodzinski2adea752015-11-10 15:25:01 -07002269VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateGraphicsPipelines(
2270 VkDevice device,
2271 VkPipelineCache pipelineCache,
2272 uint32_t count,
2273 const VkGraphicsPipelineCreateInfo *pCreateInfos,
2274 const VkAllocationCallbacks *pAllocator,
2275 VkPipeline *pPipelines)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002276{
Courtney Goeltzenleuchtera54b76a2015-09-04 13:39:59 -06002277 VkResult result = VK_SUCCESS;
Tobin Ehlise48be202015-09-16 10:33:53 -06002278 //TODO What to do with pipelineCache?
Tobin Ehlisde63c532015-06-18 15:59:33 -06002279 // The order of operations here is a little convoluted but gets the job done
2280 // 1. Pipeline create state is first shadowed into PIPELINE_NODE struct
2281 // 2. Create state is then validated (which uses flags setup during shadowing)
2282 // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap
Tobin Ehlise48be202015-09-16 10:33:53 -06002283 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis76c18852015-09-17 16:33:58 -06002284 // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic
2285 vector<PIPELINE_NODE*> pPipeNode(count);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002286 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Mark Lobodzinski2adea752015-11-10 15:25:01 -07002287
Tobin Ehlise48be202015-09-16 10:33:53 -06002288 uint32_t i=0;
Tobin Ehlisde63c532015-06-18 15:59:33 -06002289 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinski2adea752015-11-10 15:25:01 -07002290
Tobin Ehlise48be202015-09-16 10:33:53 -06002291 for (i=0; i<count; i++) {
Mark Lobodzinski2adea752015-11-10 15:25:01 -07002292 pPipeNode[i] = initGraphicsPipeline(dev_data, &pCreateInfos[i], NULL);
Tobin Ehliscb085292015-12-01 09:57:09 -07002293 // TODOSC : merge in validate_graphics_pipeline() from ShaderChecker
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002294 skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]);
Tobin Ehlise48be202015-09-16 10:33:53 -06002295 }
Mark Lobodzinski2adea752015-11-10 15:25:01 -07002296
Tobin Ehlisde63c532015-06-18 15:59:33 -06002297 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002298 if (VK_FALSE == skipCall) {
Mark Lobodzinski2adea752015-11-10 15:25:01 -07002299 result = dev_data->device_dispatch_table->CreateGraphicsPipelines(device,
2300 pipelineCache, count, pCreateInfos, pAllocator, pPipelines);
Tobin Ehlisde63c532015-06-18 15:59:33 -06002301 loader_platform_thread_lock_mutex(&globalLock);
Tobin Ehlise48be202015-09-16 10:33:53 -06002302 for (i=0; i<count; i++) {
2303 pPipeNode[i]->pipeline = pPipelines[i];
Chia-I Wue420a332015-10-26 20:04:44 +08002304 dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i];
Tobin Ehlise48be202015-09-16 10:33:53 -06002305 }
Tobin Ehlisde63c532015-06-18 15:59:33 -06002306 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002307 } else {
Tobin Ehlise48be202015-09-16 10:33:53 -06002308 for (i=0; i<count; i++) {
2309 if (pPipeNode[i]) {
2310 // If we allocated a pipeNode, need to clean it up here
2311 delete[] pPipeNode[i]->pVertexBindingDescriptions;
2312 delete[] pPipeNode[i]->pVertexAttributeDescriptions;
2313 delete[] pPipeNode[i]->pAttachments;
2314 delete pPipeNode[i];
2315 }
Tobin Ehlisde63c532015-06-18 15:59:33 -06002316 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002317 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlisde63c532015-06-18 15:59:33 -06002318 }
Courtney Goeltzenleuchter9452ac22015-04-13 16:16:04 -06002319 return result;
2320}
2321
Mark Lobodzinski2adea752015-11-10 15:25:01 -07002322VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateComputePipelines(
2323 VkDevice device,
2324 VkPipelineCache pipelineCache,
2325 uint32_t count,
2326 const VkComputePipelineCreateInfo *pCreateInfos,
2327 const VkAllocationCallbacks *pAllocator,
2328 VkPipeline *pPipelines)
2329{
2330 VkResult result = VK_SUCCESS;
2331 VkBool32 skipCall = VK_FALSE;
2332
2333 // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic
2334 vector<PIPELINE_NODE*> pPipeNode(count);
2335 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
2336
2337 uint32_t i=0;
2338 loader_platform_thread_lock_mutex(&globalLock);
2339 for (i=0; i<count; i++) {
2340 // TODO: Verify compute stage bits
2341
2342 // Create and initialize internal tracking data structure
2343 pPipeNode[i] = new PIPELINE_NODE;
2344 memset((void*)pPipeNode[i], 0, sizeof(PIPELINE_NODE));
2345 memcpy(&pPipeNode[i]->computePipelineCI, (const void*)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo));
2346
2347 // TODO: Add Compute Pipeline Verification
2348 // skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]);
2349 }
2350 loader_platform_thread_unlock_mutex(&globalLock);
2351
2352 if (VK_FALSE == skipCall) {
2353 result = dev_data->device_dispatch_table->CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, pPipelines);
2354 loader_platform_thread_lock_mutex(&globalLock);
2355 for (i=0; i<count; i++) {
2356 pPipeNode[i]->pipeline = pPipelines[i];
2357 dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i];
2358 }
2359 loader_platform_thread_unlock_mutex(&globalLock);
2360 } else {
2361 for (i=0; i<count; i++) {
2362 if (pPipeNode[i]) {
2363 // Clean up any locally allocated data structures
2364 delete pPipeNode[i];
2365 }
2366 }
2367 return VK_ERROR_VALIDATION_FAILED;
2368 }
2369 return result;
2370}
2371
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002372VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSampler(VkDevice device, const VkSamplerCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkSampler* pSampler)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002373{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002374 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002375 VkResult result = dev_data->device_dispatch_table->CreateSampler(device, pCreateInfo, pAllocator, pSampler);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002376 if (VK_SUCCESS == result) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002377 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08002378 dev_data->sampleMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo));
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002379 loader_platform_thread_unlock_mutex(&globalLock);
2380 }
2381 return result;
2382}
2383
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002384VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDescriptorSetLayout* pSetLayout)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002385{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002386 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002387 VkResult result = dev_data->device_dispatch_table->CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002388 if (VK_SUCCESS == result) {
Tobin Ehliscb085292015-12-01 09:57:09 -07002389 // TODOSC : Capture layout bindings set
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002390 LAYOUT_NODE* pNewNode = new LAYOUT_NODE;
2391 if (NULL == pNewNode) {
Chia-I Wue420a332015-10-26 20:04:44 +08002392 if (log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT, (uint64_t) *pSetLayout, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002393 "Out of memory while attempting to allocate LAYOUT_NODE in vkCreateDescriptorSetLayout()"))
2394 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002395 }
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06002396 memcpy((void*)&pNewNode->createInfo, pCreateInfo, sizeof(VkDescriptorSetLayoutCreateInfo));
Chia-I Wuf03cbf72015-10-31 00:31:16 +08002397 pNewNode->createInfo.pBinding = new VkDescriptorSetLayoutBinding[pCreateInfo->bindingCount];
2398 memcpy((void*)pNewNode->createInfo.pBinding, pCreateInfo->pBinding, sizeof(VkDescriptorSetLayoutBinding)*pCreateInfo->bindingCount);
Chia-I Wub5689ee2015-10-31 00:31:16 +08002399 // g++ does not like reserve with size 0
2400 if (pCreateInfo->bindingCount)
2401 pNewNode->bindings.reserve(pCreateInfo->bindingCount);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002402 uint32_t totalCount = 0;
Chia-I Wu763a7492015-10-26 20:48:51 +08002403 for (uint32_t i=0; i<pCreateInfo->bindingCount; i++) {
Chia-I Wub5689ee2015-10-31 00:31:16 +08002404 if (!pNewNode->bindings.insert(pCreateInfo->pBinding[i].binding).second) {
2405 if (log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT, (uint64_t) *pSetLayout, 0, DRAWSTATE_INVALID_LAYOUT, "DS",
2406 "duplicated binding number in VkDescriptorSetLayoutBinding"))
2407 return VK_ERROR_VALIDATION_FAILED;
2408 }
2409
Chia-I Wu045654f2015-11-06 06:42:02 +08002410 totalCount += pCreateInfo->pBinding[i].descriptorCount;
Chia-I Wuf03cbf72015-10-31 00:31:16 +08002411 if (pCreateInfo->pBinding[i].pImmutableSamplers) {
2412 VkSampler** ppIS = (VkSampler**)&pNewNode->createInfo.pBinding[i].pImmutableSamplers;
Chia-I Wu045654f2015-11-06 06:42:02 +08002413 *ppIS = new VkSampler[pCreateInfo->pBinding[i].descriptorCount];
2414 memcpy(*ppIS, pCreateInfo->pBinding[i].pImmutableSamplers, pCreateInfo->pBinding[i].descriptorCount*sizeof(VkSampler));
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002415 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002416 }
2417 if (totalCount > 0) {
Cody Northrop8a908322015-10-26 14:07:35 -06002418 pNewNode->descriptorTypes.resize(totalCount);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06002419 pNewNode->stageFlags.resize(totalCount);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002420 uint32_t offset = 0;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002421 uint32_t j = 0;
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002422 VkDescriptorType dType;
Chia-I Wu763a7492015-10-26 20:48:51 +08002423 for (uint32_t i=0; i<pCreateInfo->bindingCount; i++) {
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002424 dType = pCreateInfo->pBinding[i].descriptorType;
Chia-I Wu045654f2015-11-06 06:42:02 +08002425 for (j = 0; j < pCreateInfo->pBinding[i].descriptorCount; j++) {
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002426 pNewNode->descriptorTypes[offset + j] = dType;
Chia-I Wuf03cbf72015-10-31 00:31:16 +08002427 pNewNode->stageFlags[offset + j] = pCreateInfo->pBinding[i].stageFlags;
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002428 if ((dType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2429 (dType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2430 pNewNode->dynamicDescriptorCount++;
2431 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002432 }
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002433 offset += j;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002434 }
2435 }
2436 pNewNode->layout = *pSetLayout;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002437 pNewNode->startIndex = 0;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002438 pNewNode->endIndex = pNewNode->startIndex + totalCount - 1;
2439 assert(pNewNode->endIndex >= pNewNode->startIndex);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002440 // Put new node at Head of global Layer list
2441 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08002442 dev_data->layoutMap[*pSetLayout] = pNewNode;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002443 loader_platform_thread_unlock_mutex(&globalLock);
2444 }
2445 return result;
2446}
2447
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002448VKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkPipelineLayout* pPipelineLayout)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002449{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002450 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002451 VkResult result = dev_data->device_dispatch_table->CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002452 if (VK_SUCCESS == result) {
Tobin Ehliscb085292015-12-01 09:57:09 -07002453 // TODOSC : Merge capture of the setLayouts per pipeline
Tobin Ehlis982099b2015-11-05 09:52:49 -07002454 PIPELINE_LAYOUT_NODE& plNode = dev_data->pipelineLayoutMap[*pPipelineLayout];
Chia-I Wu763a7492015-10-26 20:48:51 +08002455 plNode.descriptorSetLayouts.resize(pCreateInfo->setLayoutCount);
Tobin Ehlis91423d22015-10-20 10:11:55 -06002456 uint32_t i = 0;
Chia-I Wu763a7492015-10-26 20:48:51 +08002457 for (i=0; i<pCreateInfo->setLayoutCount; ++i) {
Tobin Ehlis91423d22015-10-20 10:11:55 -06002458 plNode.descriptorSetLayouts[i] = pCreateInfo->pSetLayouts[i];
2459 }
Cody Northrop8a908322015-10-26 14:07:35 -06002460 plNode.pushConstantRanges.resize(pCreateInfo->pushConstantRangeCount);
Tobin Ehlis91423d22015-10-20 10:11:55 -06002461 for (i=0; i<pCreateInfo->pushConstantRangeCount; ++i) {
2462 plNode.pushConstantRanges[i] = pCreateInfo->pPushConstantRanges[i];
2463 }
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002464 }
2465 return result;
2466}
2467
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002468VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDescriptorPool* pDescriptorPool)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002469{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002470 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002471 VkResult result = dev_data->device_dispatch_table->CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002472 if (VK_SUCCESS == result) {
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002473 // Insert this pool into Global Pool LL at head
Chia-I Wue420a332015-10-26 20:04:44 +08002474 if (log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_DESCRIPTOR_POOL, (uint64_t) *pDescriptorPool, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
2475 "Created Descriptor Pool %#" PRIxLEAST64, (uint64_t) *pDescriptorPool))
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002476 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002477 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002478 DESCRIPTOR_POOL_NODE* pNewNode = new DESCRIPTOR_POOL_NODE(*pDescriptorPool, pCreateInfo);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002479 if (NULL == pNewNode) {
Chia-I Wue420a332015-10-26 20:04:44 +08002480 if (log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_POOL, (uint64_t) *pDescriptorPool, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002481 "Out of memory while attempting to allocate DESCRIPTOR_POOL_NODE in vkCreateDescriptorPool()"))
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002482 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002483 } else {
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002484 dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002485 }
2486 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002487 } else {
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002488 // Need to do anything if pool create fails?
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002489 }
2490 return result;
2491}
2492
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002493VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002494{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002495 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06002496 VkResult result = dev_data->device_dispatch_table->ResetDescriptorPool(device, descriptorPool, flags);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002497 if (VK_SUCCESS == result) {
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06002498 clearDescriptorPool(dev_data, device, descriptorPool, flags);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002499 }
2500 return result;
2501}
2502
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002503VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo* pAllocateInfo, VkDescriptorSet* pDescriptorSets)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002504{
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002505 VkBool32 skipCall = VK_FALSE;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002506 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002507 // Verify that requested descriptorSets are available in pool
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002508 DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002509 if (!pPoolNode) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002510 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_POOL, (uint64_t) pAllocateInfo->descriptorPool, 0, DRAWSTATE_INVALID_POOL, "DS",
2511 "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", (uint64_t) pAllocateInfo->descriptorPool);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002512 } else { // Make sure pool has all the available descriptors before calling down chain
Chia-I Wu1f851912015-10-27 18:04:07 +08002513 skipCall |= validate_descriptor_availability_in_pool(dev_data, pPoolNode, pAllocateInfo->setLayoutCount, pAllocateInfo->pSetLayouts);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002514 }
2515 if (skipCall)
2516 return VK_ERROR_VALIDATION_FAILED;
Chia-I Wu1f851912015-10-27 18:04:07 +08002517 VkResult result = dev_data->device_dispatch_table->AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets);
Cody Northropc8aa4a52015-08-03 12:47:29 -06002518 if (VK_SUCCESS == result) {
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002519 DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002520 if (pPoolNode) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002521 if (pAllocateInfo->setLayoutCount == 0) {
2522 log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, pAllocateInfo->setLayoutCount, 0, DRAWSTATE_NONE, "DS",
2523 "AllocateDescriptorSets called with 0 count");
Cody Northropc8aa4a52015-08-03 12:47:29 -06002524 }
Chia-I Wu1f851912015-10-27 18:04:07 +08002525 for (uint32_t i = 0; i < pAllocateInfo->setLayoutCount; i++) {
Chia-I Wue420a332015-10-26 20:04:44 +08002526 log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_NONE, "DS",
2527 "Created Descriptor Set %#" PRIxLEAST64, (uint64_t) pDescriptorSets[i]);
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002528 // Create new set node and add to head of pool nodes
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002529 SET_NODE* pNewNode = new SET_NODE;
2530 if (NULL == pNewNode) {
Chia-I Wue420a332015-10-26 20:04:44 +08002531 if (log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08002532 "Out of memory while attempting to allocate SET_NODE in vkAllocateDescriptorSets()"))
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002533 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002534 } else {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002535 memset(pNewNode, 0, sizeof(SET_NODE));
Tobin Ehlisf6e93e02015-10-19 12:09:13 -06002536 // TODO : Pool should store a total count of each type of Descriptor available
2537 // When descriptors are allocated, decrement the count and validate here
2538 // that the count doesn't go below 0. One reset/free need to bump count back up.
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002539 // Insert set at head of Set LL for this pool
2540 pNewNode->pNext = pPoolNode->pSets;
2541 pPoolNode->pSets = pNewNode;
Chia-I Wu1f851912015-10-27 18:04:07 +08002542 LAYOUT_NODE* pLayout = getLayoutNode(dev_data, pAllocateInfo->pSetLayouts[i]);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002543 if (NULL == pLayout) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002544 if (log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT, (uint64_t) pAllocateInfo->pSetLayouts[i], 0, DRAWSTATE_INVALID_LAYOUT, "DS",
2545 "Unable to find set layout node for layout %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", (uint64_t) pAllocateInfo->pSetLayouts[i]))
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002546 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002547 }
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002548 pNewNode->pLayout = pLayout;
Chia-I Wu1f851912015-10-27 18:04:07 +08002549 pNewNode->pool = pAllocateInfo->descriptorPool;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002550 pNewNode->set = pDescriptorSets[i];
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002551 pNewNode->descriptorCount = pLayout->endIndex + 1;
2552 if (pNewNode->descriptorCount) {
2553 size_t descriptorArraySize = sizeof(GENERIC_HEADER*)*pNewNode->descriptorCount;
2554 pNewNode->ppDescriptors = new GENERIC_HEADER*[descriptorArraySize];
2555 memset(pNewNode->ppDescriptors, 0, descriptorArraySize);
2556 }
Chia-I Wue420a332015-10-26 20:04:44 +08002557 dev_data->setMap[pDescriptorSets[i]] = pNewNode;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002558 }
2559 }
2560 }
2561 }
2562 return result;
2563}
2564
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002565VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet* pDescriptorSets)
Tony Barbourb857d312015-07-10 10:50:45 -06002566{
Tobin Ehlis3c543112015-10-08 13:13:50 -06002567 VkBool32 skipCall = VK_FALSE;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002568 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002569 DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, descriptorPool);
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06002570 if (pPoolNode && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pPoolNode->createInfo.flags)) {
2571 // Can't Free from a NON_FREE pool
2572 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DEVICE, (uint64_t)device, 0, DRAWSTATE_CANT_FREE_FROM_NON_FREE_POOL, "DS",
2573 "It is invalid to call vkFreeDescriptorSets() with a pool created without setting VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT.");
Tobin Ehlis3c543112015-10-08 13:13:50 -06002574 }
2575 if (skipCall)
2576 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002577 VkResult result = dev_data->device_dispatch_table->FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002578 if (VK_SUCCESS == result) {
2579 // For each freed descriptor add it back into the pool as available
2580 for (uint32_t i=0; i<count; ++i) {
Chia-I Wue420a332015-10-26 20:04:44 +08002581 SET_NODE* pSet = dev_data->setMap[pDescriptorSets[i]]; // getSetNode() without locking
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002582 LAYOUT_NODE* pLayout = pSet->pLayout;
Chia-I Wuc51b1212015-10-27 19:25:11 +08002583 uint32_t typeIndex = 0, poolSizeCount = 0;
Chia-I Wu763a7492015-10-26 20:48:51 +08002584 for (uint32_t j=0; j<pLayout->createInfo.bindingCount; ++j) {
Chia-I Wuf03cbf72015-10-31 00:31:16 +08002585 typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBinding[j].descriptorType);
Chia-I Wu045654f2015-11-06 06:42:02 +08002586 poolSizeCount = pLayout->createInfo.pBinding[j].descriptorCount;
Chia-I Wuc51b1212015-10-27 19:25:11 +08002587 pPoolNode->availableDescriptorTypeCount[typeIndex] += poolSizeCount;
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002588 }
2589 }
2590 }
2591 // TODO : Any other clean-up or book-keeping to do here?
Tony Barbourb857d312015-07-10 10:50:45 -06002592 return result;
2593}
2594
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002595VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet* pDescriptorWrites, uint32_t descriptorCopyCount, const VkCopyDescriptorSet* pDescriptorCopies)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002596{
Tobin Ehlis68fbd442015-10-27 12:25:35 -06002597 // dsUpdate will return VK_TRUE only if a bailout error occurs, so we want to call down tree when update returns VK_FALSE
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002598 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu483e7702015-10-26 17:20:32 +08002599 if (!dsUpdate(dev_data, device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, pDescriptorCopies)) {
2600 dev_data->device_dispatch_table->UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, pDescriptorCopies);
Jon Ashburne0fa2282015-05-20 09:00:28 -06002601 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002602}
2603
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002604VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo* pCreateInfo, VkCommandBuffer* pCommandBuffer)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002605{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002606 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu1f851912015-10-27 18:04:07 +08002607 VkResult result = dev_data->device_dispatch_table->AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002608 if (VK_SUCCESS == result) {
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002609 for (auto i = 0; i < pCreateInfo->bufferCount; i++) {
2610 // Validate command pool
2611 if (dev_data->commandPoolMap.find(pCreateInfo->commandPool) != dev_data->commandPoolMap.end()) {
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002612 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002613 // Add command buffer to its commandPool map
2614 dev_data->commandPoolMap[pCreateInfo->commandPool].push_back(pCommandBuffer[i]);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002615 GLOBAL_CB_NODE* pCB = new GLOBAL_CB_NODE;
2616 // Add command buffer to map
2617 dev_data->commandBufferMap[pCommandBuffer[i]] = pCB;
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002618 loader_platform_thread_unlock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002619 resetCB(dev_data, pCommandBuffer[i]);
2620 pCB->commandBuffer = pCommandBuffer[i];
2621 pCB->createInfo = *pCreateInfo;
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002622 updateCBTracking(pCB);
2623 }
2624 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002625 }
2626 return result;
2627}
2628
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002629VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo* pBeginInfo)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002630{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002631 VkBool32 skipCall = false;
Chia-I Wu1f851912015-10-27 18:04:07 +08002632 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002633 // Validate command buffer level
Chia-I Wu1f851912015-10-27 18:04:07 +08002634 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002635 if (pCB) {
Mark Lobodzinskia1420862015-11-19 13:22:11 -07002636 if (pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) {
Chia-I Wue420a332015-10-26 20:04:44 +08002637 if (pBeginInfo->renderPass || pBeginInfo->framebuffer) {
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002638 // These should be NULL for a Primary CB
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002639 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS",
Mark Lobodzinskifc0ec622015-11-19 12:07:21 -07002640 "vkBeginCommandBuffer(): Primary Command Buffer (%p) may not specify framebuffer or renderpass parameters", (void*)commandBuffer);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002641 }
2642 } else {
Chia-I Wue420a332015-10-26 20:04:44 +08002643 if (!pBeginInfo->renderPass || !pBeginInfo->framebuffer) {
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002644 // These should NOT be null for an Secondary CB
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002645 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS",
Mark Lobodzinskifc0ec622015-11-19 12:07:21 -07002646 "vkBeginCommandBuffer(): Secondary Command Buffers (%p) must specify framebuffer and renderpass parameters", (void*)commandBuffer);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002647 }
2648 }
Tobin Ehlis0cea4082015-08-18 07:10:58 -06002649 pCB->beginInfo = *pBeginInfo;
2650 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002651 // TODO : Need to pass commandBuffer as objType here
2652 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
2653 "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB %p!", (void*)commandBuffer);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002654 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002655 if (skipCall) {
2656 return VK_ERROR_VALIDATION_FAILED;
Courtney Goeltzenleuchter3abd86e2015-09-04 15:03:52 -06002657 }
Chia-I Wu1f851912015-10-27 18:04:07 +08002658 VkResult result = dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo);
Mark Lobodzinski2ad35592015-11-12 16:14:04 -07002659 if ((VK_SUCCESS == result) && (pCB != NULL)) {
2660 if (CB_NEW != pCB->state) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002661 resetCB(dev_data, commandBuffer);
Mark Lobodzinski2ad35592015-11-12 16:14:04 -07002662 }
Tobin Ehlis0cea4082015-08-18 07:10:58 -06002663 pCB->state = CB_UPDATE_ACTIVE;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002664 updateCBTracking(pCB);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002665 }
2666 return result;
2667}
2668
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002669VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEndCommandBuffer(VkCommandBuffer commandBuffer)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002670{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002671 VkBool32 skipCall = VK_FALSE;
Courtney Goeltzenleuchtera54b76a2015-09-04 13:39:59 -06002672 VkResult result = VK_SUCCESS;
Chia-I Wu1f851912015-10-27 18:04:07 +08002673 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2674 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchtera54b76a2015-09-04 13:39:59 -06002675 /* TODO: preference is to always call API function after reporting any validation errors */
Tobin Ehlise42007c2015-06-19 13:00:59 -06002676 if (pCB) {
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002677 if (pCB->state != CB_UPDATE_ACTIVE) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002678 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkEndCommandBuffer()");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002679 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002680 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002681 if (VK_FALSE == skipCall) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002682 result = dev_data->device_dispatch_table->EndCommandBuffer(commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002683 if (VK_SUCCESS == result) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002684 updateCBTracking(pCB);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002685 pCB->state = CB_UPDATE_COMPLETE;
2686 // Reset CB status flags
2687 pCB->status = 0;
Chia-I Wu1f851912015-10-27 18:04:07 +08002688 printCB(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002689 }
2690 } else {
2691 result = VK_ERROR_VALIDATION_FAILED;
2692 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002693 return result;
2694}
2695
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002696VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002697{
Chia-I Wu1f851912015-10-27 18:04:07 +08002698 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2699 VkResult result = dev_data->device_dispatch_table->ResetCommandBuffer(commandBuffer, flags);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002700 if (VK_SUCCESS == result) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002701 resetCB(dev_data, commandBuffer);
2702 updateCBTracking(getCBNode(dev_data, commandBuffer));
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002703 }
2704 return result;
2705}
2706
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002707VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002708{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002709 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002710 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2711 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002712 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06002713 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002714 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002715 skipCall |= addCmd(dev_data, pCB, CMD_BINDPIPELINE);
Tobin Ehlis642d5a52015-06-23 08:46:18 -06002716 if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) {
Chia-I Wue420a332015-10-26 20:04:44 +08002717 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE, (uint64_t) pipeline,
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06002718 0, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS",
2719 "Incorrectly binding compute pipeline (%#" PRIxLEAST64 ") during active RenderPass (%#" PRIxLEAST64 ")",
Chia-I Wue420a332015-10-26 20:04:44 +08002720 (uint64_t) pipeline, (uint64_t) pCB->activeRenderPass);
Tobin Ehlise4076782015-06-24 15:53:07 -06002721 } else if ((VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) && (!pCB->activeRenderPass)) {
Chia-I Wue420a332015-10-26 20:04:44 +08002722 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE, (uint64_t) pipeline,
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06002723 0, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", "Incorrectly binding graphics pipeline "
Chia-I Wue420a332015-10-26 20:04:44 +08002724 " (%#" PRIxLEAST64 ") without an active RenderPass", (uint64_t) pipeline);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002725 } else {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002726 PIPELINE_NODE* pPN = getPipeline(dev_data, pipeline);
Tobin Ehlise4076782015-06-24 15:53:07 -06002727 if (pPN) {
2728 pCB->lastBoundPipeline = pipeline;
2729 loader_platform_thread_lock_mutex(&globalLock);
2730 set_cb_pso_status(pCB, pPN);
2731 g_lastBoundPipeline = pPN;
2732 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002733 skipCall |= validatePipelineState(dev_data, pCB, pipelineBindPoint, pipeline);
Tobin Ehlise4076782015-06-24 15:53:07 -06002734 } else {
Chia-I Wue420a332015-10-26 20:04:44 +08002735 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE, (uint64_t) pipeline,
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06002736 0, DRAWSTATE_INVALID_PIPELINE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08002737 "Attempt to bind Pipeline %#" PRIxLEAST64 " that doesn't exist!", reinterpret_cast<uint64_t>(pipeline));
Tobin Ehlise4076782015-06-24 15:53:07 -06002738 }
Tobin Ehlise42007c2015-06-19 13:00:59 -06002739 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002740 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002741 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindPipeline()");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002742 }
2743 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002744 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002745 dev_data->device_dispatch_table->CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002746}
2747
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002748VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetViewport(
Chia-I Wu1f851912015-10-27 18:04:07 +08002749 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002750 uint32_t viewportCount,
2751 const VkViewport* pViewports)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002752{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002753 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002754 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2755 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlise42007c2015-06-19 13:00:59 -06002756 if (pCB) {
2757 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002758 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002759 skipCall |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE);
Tobin Ehlise42007c2015-06-19 13:00:59 -06002760 loader_platform_thread_lock_mutex(&globalLock);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002761 pCB->status |= CBSTATUS_VIEWPORT_SET;
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002762 pCB->viewports.resize(viewportCount);
Tobin Ehlis9e839e52015-10-01 11:15:13 -06002763 memcpy(pCB->viewports.data(), pViewports, viewportCount * sizeof(VkViewport));
Tobin Ehlise42007c2015-06-19 13:00:59 -06002764 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlise42007c2015-06-19 13:00:59 -06002765 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002766 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetViewport()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06002767 }
2768 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002769 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002770 dev_data->device_dispatch_table->CmdSetViewport(commandBuffer, viewportCount, pViewports);
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002771}
2772
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002773VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetScissor(
Chia-I Wu1f851912015-10-27 18:04:07 +08002774 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002775 uint32_t scissorCount,
2776 const VkRect2D* pScissors)
2777{
2778 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002779 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2780 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002781 if (pCB) {
2782 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002783 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002784 skipCall |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE);
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002785 loader_platform_thread_lock_mutex(&globalLock);
2786 pCB->status |= CBSTATUS_SCISSOR_SET;
2787 pCB->scissors.resize(scissorCount);
Tobin Ehlis9e839e52015-10-01 11:15:13 -06002788 memcpy(pCB->scissors.data(), pScissors, scissorCount * sizeof(VkRect2D));
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002789 loader_platform_thread_unlock_mutex(&globalLock);
2790 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002791 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetScissor()");
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002792 }
2793 }
2794 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002795 dev_data->device_dispatch_table->CmdSetScissor(commandBuffer, scissorCount, pScissors);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002796}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002797
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002798VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002799{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002800 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002801 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2802 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002803 if (pCB) {
2804 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002805 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002806 skipCall |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002807 /* TODO: Do we still need this lock? */
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002808 loader_platform_thread_lock_mutex(&globalLock);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002809 pCB->status |= CBSTATUS_LINE_WIDTH_SET;
2810 pCB->lineWidth = lineWidth;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002811 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002812 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002813 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDynamicLineWidthState()");
Cody Northropf5bd2252015-08-17 11:10:49 -06002814 }
2815 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002816 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002817 dev_data->device_dispatch_table->CmdSetLineWidth(commandBuffer, lineWidth);
Cody Northropf5bd2252015-08-17 11:10:49 -06002818}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002819
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002820VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetDepthBias(
Chia-I Wu1f851912015-10-27 18:04:07 +08002821 VkCommandBuffer commandBuffer,
Chia-I Wufa950c52015-10-26 19:08:09 +08002822 float depthBiasConstantFactor,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002823 float depthBiasClamp,
Chia-I Wufa950c52015-10-26 19:08:09 +08002824 float depthBiasSlopeFactor)
Cody Northropf5bd2252015-08-17 11:10:49 -06002825{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002826 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002827 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2828 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Cody Northropf5bd2252015-08-17 11:10:49 -06002829 if (pCB) {
2830 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002831 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002832 skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002833 pCB->status |= CBSTATUS_DEPTH_BIAS_SET;
Chia-I Wufa950c52015-10-26 19:08:09 +08002834 pCB->depthBiasConstantFactor = depthBiasConstantFactor;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002835 pCB->depthBiasClamp = depthBiasClamp;
Chia-I Wufa950c52015-10-26 19:08:09 +08002836 pCB->depthBiasSlopeFactor = depthBiasSlopeFactor;
Cody Northropf5bd2252015-08-17 11:10:49 -06002837 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002838 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetDepthBias()");
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002839 }
2840 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002841 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002842 dev_data->device_dispatch_table->CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, depthBiasSlopeFactor);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002843}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002844
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002845VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4])
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002846{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002847 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002848 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2849 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002850 if (pCB) {
2851 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002852 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002853 skipCall |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002854 pCB->status |= CBSTATUS_BLEND_SET;
Chia-I Wu7e470702015-10-26 17:24:52 +08002855 memcpy(pCB->blendConstants, blendConstants, 4 * sizeof(float));
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002856 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002857 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetBlendConstants()");
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002858 }
2859 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002860 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002861 dev_data->device_dispatch_table->CmdSetBlendConstants(commandBuffer, blendConstants);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002862}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002863
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002864VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetDepthBounds(
Chia-I Wu1f851912015-10-27 18:04:07 +08002865 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002866 float minDepthBounds,
2867 float maxDepthBounds)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002868{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002869 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002870 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2871 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002872 if (pCB) {
2873 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002874 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002875 skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002876 pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET;
2877 pCB->minDepthBounds = minDepthBounds;
2878 pCB->maxDepthBounds = maxDepthBounds;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002879 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002880 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetDepthBounds()");
Cody Northrop2605cb02015-08-18 15:21:16 -06002881 }
2882 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002883 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002884 dev_data->device_dispatch_table->CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds);
Cody Northrop2605cb02015-08-18 15:21:16 -06002885}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002886
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002887VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetStencilCompareMask(
Chia-I Wu1f851912015-10-27 18:04:07 +08002888 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002889 VkStencilFaceFlags faceMask,
Chia-I Wuc51b1212015-10-27 19:25:11 +08002890 uint32_t compareMask)
Cody Northrop2605cb02015-08-18 15:21:16 -06002891{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002892 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002893 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2894 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Cody Northrop2605cb02015-08-18 15:21:16 -06002895 if (pCB) {
2896 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002897 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002898 skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002899 if (faceMask & VK_STENCIL_FACE_FRONT_BIT) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002900 pCB->front.compareMask = compareMask;
Cody Northrop2605cb02015-08-18 15:21:16 -06002901 }
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002902 if (faceMask & VK_STENCIL_FACE_BACK_BIT) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002903 pCB->back.compareMask = compareMask;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002904 }
2905 /* TODO: Do we need to track front and back separately? */
2906 /* TODO: We aren't capturing the faceMask, do we need to? */
2907 pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET;
Cody Northrop2605cb02015-08-18 15:21:16 -06002908 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002909 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetStencilCompareMask()");
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002910 }
2911 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002912 if (VK_FALSE == skipCall)
Chia-I Wuc51b1212015-10-27 19:25:11 +08002913 dev_data->device_dispatch_table->CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002914}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002915
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002916VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetStencilWriteMask(
Chia-I Wu1f851912015-10-27 18:04:07 +08002917 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002918 VkStencilFaceFlags faceMask,
Chia-I Wuc51b1212015-10-27 19:25:11 +08002919 uint32_t writeMask)
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002920{
2921 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002922 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2923 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002924 if (pCB) {
2925 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002926 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002927 skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002928 if (faceMask & VK_STENCIL_FACE_FRONT_BIT) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002929 pCB->front.writeMask = writeMask;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002930 }
2931 if (faceMask & VK_STENCIL_FACE_BACK_BIT) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002932 pCB->back.writeMask = writeMask;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002933 }
2934 pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET;
2935 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002936 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetStencilWriteMask()");
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002937 }
2938 }
2939 if (VK_FALSE == skipCall)
Chia-I Wuc51b1212015-10-27 19:25:11 +08002940 dev_data->device_dispatch_table->CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002941}
2942
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002943VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetStencilReference(
Chia-I Wu1f851912015-10-27 18:04:07 +08002944 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002945 VkStencilFaceFlags faceMask,
Chia-I Wuc51b1212015-10-27 19:25:11 +08002946 uint32_t reference)
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002947{
2948 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002949 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2950 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002951 if (pCB) {
2952 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002953 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002954 skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002955 if (faceMask & VK_STENCIL_FACE_FRONT_BIT) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002956 pCB->front.reference = reference;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002957 }
2958 if (faceMask & VK_STENCIL_FACE_BACK_BIT) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002959 pCB->back.reference = reference;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002960 }
2961 pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET;
2962 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002963 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetStencilReference()");
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002964 }
2965 }
2966 if (VK_FALSE == skipCall)
Chia-I Wuc51b1212015-10-27 19:25:11 +08002967 dev_data->device_dispatch_table->CmdSetStencilReference(commandBuffer, faceMask, reference);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002968}
2969
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002970VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, uint32_t firstSet, uint32_t setCount, const VkDescriptorSet* pDescriptorSets, uint32_t dynamicOffsetCount, const uint32_t* pDynamicOffsets)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002971{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002972 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002973 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2974 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002975 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06002976 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlise4076782015-06-24 15:53:07 -06002977 if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002978 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08002979 "Incorrectly binding compute DescriptorSets during active RenderPass (%#" PRIxLEAST64 ")", (uint64_t) pCB->activeRenderPass);
Tobin Ehlise4076782015-06-24 15:53:07 -06002980 } else if ((VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) && (!pCB->activeRenderPass)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002981 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS",
Tobin Ehlise4076782015-06-24 15:53:07 -06002982 "Incorrectly binding graphics DescriptorSets without an active RenderPass");
Tobin Ehlisd28acef2015-09-09 15:12:35 -06002983 } else {
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002984 // Track total count of dynamic descriptor types to make sure we have an offset for each one
2985 uint32_t totalDynamicDescriptors = 0;
Tobin Ehlis982099b2015-11-05 09:52:49 -07002986 string errorString = "";
Tobin Ehliscb085292015-12-01 09:57:09 -07002987 uint32_t lastSetIndex = firstSet+setCount-1;
Tobin Ehlis982099b2015-11-05 09:52:49 -07002988 if (lastSetIndex >= pCB->boundDescriptorSets.size())
2989 pCB->boundDescriptorSets.resize(lastSetIndex+1);
2990 VkDescriptorSet oldFinalBoundSet = pCB->boundDescriptorSets[lastSetIndex];
Tobin Ehlise42007c2015-06-19 13:00:59 -06002991 for (uint32_t i=0; i<setCount; i++) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002992 SET_NODE* pSet = getSetNode(dev_data, pDescriptorSets[i]);
Tobin Ehlis55c1c602015-06-24 17:27:33 -06002993 if (pSet) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06002994 loader_platform_thread_lock_mutex(&globalLock);
2995 pCB->lastBoundDescriptorSet = pDescriptorSets[i];
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -06002996 pCB->lastBoundPipelineLayout = layout;
Tobin Ehlis982099b2015-11-05 09:52:49 -07002997 pCB->boundDescriptorSets[i+firstSet] = pDescriptorSets[i];
Tobin Ehlise42007c2015-06-19 13:00:59 -06002998 loader_platform_thread_unlock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08002999 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_NONE, "DS",
3000 "DS %#" PRIxLEAST64 " bound on pipeline %s", (uint64_t) pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint));
Tobin Ehlis61ebb312015-11-04 12:28:28 -07003001 if (!pSet->pUpdateStructs) {
Chia-I Wue420a332015-10-26 20:04:44 +08003002 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_WARN_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS",
3003 "DS %#" PRIxLEAST64 " bound but it was never updated. You may want to either update it or not bind it.", (uint64_t) pDescriptorSets[i]);
Tobin Ehlis61ebb312015-11-04 12:28:28 -07003004 }
Tobin Ehlis982099b2015-11-05 09:52:49 -07003005 // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout
3006 if (!verify_set_layout_compatibility(dev_data, pSet, layout, i+firstSet, errorString)) {
3007 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS",
3008 "descriptorSet #%u being bound is not compatible with overlapping layout in pipelineLayout due to: %s", i, errorString.c_str());
3009 }
Tobin Ehlis61ebb312015-11-04 12:28:28 -07003010 totalDynamicDescriptors += pSet->pLayout->dynamicDescriptorCount;
Tobin Ehlise42007c2015-06-19 13:00:59 -06003011 } else {
Chia-I Wue420a332015-10-26 20:04:44 +08003012 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_INVALID_SET, "DS",
3013 "Attempt to bind DS %#" PRIxLEAST64 " that doesn't exist!", (uint64_t) pDescriptorSets[i]);
Tobin Ehlise42007c2015-06-19 13:00:59 -06003014 }
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06003015 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003016 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003017 skipCall |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS);
Tobin Ehlis982099b2015-11-05 09:52:49 -07003018 // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update
3019 if (firstSet > 0) { // Check set #s below the first bound set
3020 for (uint32_t i=0; i<firstSet; ++i) {
Tobin Ehliscb085292015-12-01 09:57:09 -07003021 if (pCB->boundDescriptorSets[i] && !verify_set_layout_compatibility(dev_data, dev_data->setMap[pCB->boundDescriptorSets[i]], layout, i, errorString)) {
3022 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_PERF_WARN_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pCB->boundDescriptorSets[i], 0, DRAWSTATE_NONE, "DS",
Tobin Ehlis982099b2015-11-05 09:52:49 -07003023 "DescriptorSetDS %#" PRIxLEAST64 " previously bound as set #%u was disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", (uint64_t) pCB->boundDescriptorSets[i], i, (uint64_t) layout);
3024 pCB->boundDescriptorSets[i] = VK_NULL_HANDLE;
3025 }
3026 }
3027 }
3028 // Check if newly last bound set invalidates any remaining bound sets
3029 if ((pCB->boundDescriptorSets.size()-1) > (lastSetIndex)) {
Tobin Ehliscb085292015-12-01 09:57:09 -07003030 if (oldFinalBoundSet && !verify_set_layout_compatibility(dev_data, dev_data->setMap[oldFinalBoundSet], layout, lastSetIndex, errorString)) {
3031 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_PERF_WARN_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) oldFinalBoundSet, 0, DRAWSTATE_NONE, "DS",
3032 "DescriptorSetDS %#" PRIxLEAST64 " previously bound as set #%u is incompatible with set %#" PRIxLEAST64 " newly bound as set #%u so set #%u and any subsequent sets were disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", (uint64_t) oldFinalBoundSet, lastSetIndex, (uint64_t) pCB->boundDescriptorSets[lastSetIndex], lastSetIndex, lastSetIndex+1, (uint64_t) layout);
Tobin Ehlis982099b2015-11-05 09:52:49 -07003033 pCB->boundDescriptorSets.resize(lastSetIndex+1);
3034 }
3035 }
Tobin Ehlis61ebb312015-11-04 12:28:28 -07003036 // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound
3037 if (totalDynamicDescriptors != dynamicOffsetCount) {
3038 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, (uint64_t) commandBuffer, 0, DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS",
3039 "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount is %u. It should exactly match the number of dynamic descriptors.", setCount, totalDynamicDescriptors, dynamicOffsetCount);
3040 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003041 }
Tobin Ehlise42007c2015-06-19 13:00:59 -06003042 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003043 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003044 }
3045 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003046 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003047 dev_data->device_dispatch_table->CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, pDescriptorSets, dynamicOffsetCount, pDynamicOffsets);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003048}
3049
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003050VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003051{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003052 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003053 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3054 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003055 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003056 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlis8d199e52015-09-17 12:24:13 -06003057 VkDeviceSize offset_align = 0;
3058 switch (indexType) {
3059 case VK_INDEX_TYPE_UINT16:
3060 offset_align = 2;
3061 break;
3062 case VK_INDEX_TYPE_UINT32:
3063 offset_align = 4;
3064 break;
3065 default:
3066 // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0
3067 break;
3068 }
3069 if (!offset_align || (offset % offset_align)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003070 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS",
Tobin Ehlis8d199e52015-09-17 12:24:13 -06003071 "vkCmdBindIndexBuffer() offset (%#" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", offset, string_VkIndexType(indexType));
Tobin Ehlise4076782015-06-24 15:53:07 -06003072 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003073 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003074 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindIndexBuffer()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003075 }
Tobin Ehlis8d199e52015-09-17 12:24:13 -06003076 pCB->status |= CBSTATUS_INDEX_BUFFER_BOUND;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003077 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003078 skipCall |= addCmd(dev_data, pCB, CMD_BINDINDEXBUFFER);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003079 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003080 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003081 dev_data->device_dispatch_table->CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003082}
3083
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003084VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindVertexBuffers(
Chia-I Wu1f851912015-10-27 18:04:07 +08003085 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter46962942015-04-16 13:38:46 -06003086 uint32_t startBinding,
3087 uint32_t bindingCount,
3088 const VkBuffer* pBuffers,
Tony Barbour8205d902015-04-16 15:59:00 -06003089 const VkDeviceSize* pOffsets)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003090{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003091 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003092 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3093 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003094 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003095 if (pCB->state == CB_UPDATE_ACTIVE) {
3096 /* TODO: Need to track all the vertex buffers, not just last one */
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003097 pCB->lastVtxBinding = startBinding + bindingCount -1;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003098 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003099 addCmd(dev_data, pCB, CMD_BINDVERTEXBUFFER);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003100 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003101 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()");
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06003102 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003103 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003104 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003105 dev_data->device_dispatch_table->CmdBindVertexBuffers(commandBuffer, startBinding, bindingCount, pBuffers, pOffsets);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003106}
3107
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003108VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, uint32_t firstVertex, uint32_t firstInstance)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003109{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003110 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003111 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3112 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003113 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003114 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003115 pCB->drawCount[DRAW]++;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003116 skipCall |= validate_draw_state(dev_data, pCB, VK_FALSE);
Chia-I Wu1f851912015-10-27 18:04:07 +08003117 // TODO : Need to pass commandBuffer as srcObj here
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003118 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08003119 "vkCmdDraw() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW]++);
Chia-I Wu1f851912015-10-27 18:04:07 +08003120 skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003121 if (VK_FALSE == skipCall) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003122 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003123 skipCall |= addCmd(dev_data, pCB, CMD_DRAW);
Tobin Ehlise42007c2015-06-19 13:00:59 -06003124 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003125 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003126 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDraw()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003127 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003128 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDraw");
Jon Ashburne0fa2282015-05-20 09:00:28 -06003129 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003130 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003131 dev_data->device_dispatch_table->CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003132}
3133
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003134VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, uint32_t firstInstance)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003135{
Chia-I Wu1f851912015-10-27 18:04:07 +08003136 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3137 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003138 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003139 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003140 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003141 pCB->drawCount[DRAW_INDEXED]++;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003142 skipCall |= validate_draw_state(dev_data, pCB, VK_TRUE);
Chia-I Wu1f851912015-10-27 18:04:07 +08003143 // TODO : Need to pass commandBuffer as srcObj here
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003144 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08003145 "vkCmdDrawIndexed() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++);
Chia-I Wu1f851912015-10-27 18:04:07 +08003146 skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003147 if (VK_FALSE == skipCall) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003148 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003149 skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXED);
Tobin Ehlise42007c2015-06-19 13:00:59 -06003150 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003151 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003152 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDrawIndexed()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003153 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003154 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed");
Jon Ashburne0fa2282015-05-20 09:00:28 -06003155 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003156 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003157 dev_data->device_dispatch_table->CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, firstInstance);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003158}
3159
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003160VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003161{
Chia-I Wu1f851912015-10-27 18:04:07 +08003162 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3163 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003164 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003165 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003166 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003167 pCB->drawCount[DRAW_INDIRECT]++;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003168 skipCall |= validate_draw_state(dev_data, pCB, VK_FALSE);
Chia-I Wu1f851912015-10-27 18:04:07 +08003169 // TODO : Need to pass commandBuffer as srcObj here
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003170 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08003171 "vkCmdDrawIndirect() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++);
Chia-I Wu1f851912015-10-27 18:04:07 +08003172 skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003173 if (VK_FALSE == skipCall) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003174 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003175 skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDIRECT);
Tobin Ehlise42007c2015-06-19 13:00:59 -06003176 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003177 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003178 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDrawIndirect()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003179 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003180 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndirect");
Jon Ashburne0fa2282015-05-20 09:00:28 -06003181 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003182 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003183 dev_data->device_dispatch_table->CmdDrawIndirect(commandBuffer, buffer, offset, count, stride);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003184}
3185
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003186VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003187{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003188 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003189 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3190 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003191 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003192 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003193 pCB->drawCount[DRAW_INDEXED_INDIRECT]++;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003194 skipCall |= validate_draw_state(dev_data, pCB, VK_TRUE);
Chia-I Wu1f851912015-10-27 18:04:07 +08003195 // TODO : Need to pass commandBuffer as srcObj here
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003196 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08003197 "vkCmdDrawIndexedIndirect() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDEXED_INDIRECT]++);
Chia-I Wu1f851912015-10-27 18:04:07 +08003198 skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003199 if (VK_FALSE == skipCall) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003200 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003201 skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXEDINDIRECT);
Tobin Ehlise42007c2015-06-19 13:00:59 -06003202 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003203 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003204 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDrawIndexedIndirect()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003205 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003206 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexedIndirect");
Jon Ashburne0fa2282015-05-20 09:00:28 -06003207 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003208 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003209 dev_data->device_dispatch_table->CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003210}
3211
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003212VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003213{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003214 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003215 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3216 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003217 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003218 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003219 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003220 skipCall |= addCmd(dev_data, pCB, CMD_DISPATCH);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003221 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003222 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDispatch()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003223 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003224 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatch");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003225 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003226 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003227 dev_data->device_dispatch_table->CmdDispatch(commandBuffer, x, y, z);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003228}
3229
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003230VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003231{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003232 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003233 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3234 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003235 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003236 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003237 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003238 skipCall |= addCmd(dev_data, pCB, CMD_DISPATCHINDIRECT);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003239 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003240 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDispatchIndirect()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003241 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003242 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatchIndirect");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003243 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003244 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003245 dev_data->device_dispatch_table->CmdDispatchIndirect(commandBuffer, buffer, offset);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003246}
3247
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003248VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, uint32_t regionCount, const VkBufferCopy* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003249{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003250 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003251 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3252 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003253 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003254 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003255 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003256 skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFER);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003257 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003258 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyBuffer()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003259 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003260 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBuffer");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003261 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003262 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003263 dev_data->device_dispatch_table->CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003264}
3265
Michael Lentine27b0f902015-10-12 11:30:14 -05003266bool VerifySourceImageLayout(VkCommandBuffer cmdBuffer, VkImage srcImage, VkImageLayout srcImageLayout) {
3267 bool skip_call = false;
Mark Lobodzinski78940a42015-11-30 16:48:53 -07003268
3269#ifdef DISABLE_IMAGE_LAYOUT_VALIDATION
3270 // TODO: Fix -- initialLayout may have been set in a previous command buffer
3271 return skip_call;
3272#endif // DISABLE_IMAGE_LAYOUT_VALIDATION
3273
Michael Lentine27b0f902015-10-12 11:30:14 -05003274 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
3275 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
3276 auto src_image_element = pCB->imageLayoutMap.find(srcImage);
3277 if (src_image_element == pCB->imageLayoutMap.end()) {
3278 pCB->imageLayoutMap[srcImage].initialLayout = srcImageLayout;
3279 pCB->imageLayoutMap[srcImage].layout = srcImageLayout;
3280 return false;
3281 }
3282 if (src_image_element->second.layout != srcImageLayout) {
3283 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
3284 "Cannot copy from an image whose source layout is %d and doesn't match the current layout %d.", srcImageLayout, src_image_element->second.layout);
3285 }
3286 if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) {
3287 if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) {
3288 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine472af7d2015-10-16 18:08:09 -05003289 "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL.");
Michael Lentine27b0f902015-10-12 11:30:14 -05003290 } else {
3291 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine472af7d2015-10-16 18:08:09 -05003292 "Layout for input image is %d but can only be TRANSFER_SRC_OPTIMAL or GENERAL.", srcImageLayout);
Michael Lentine27b0f902015-10-12 11:30:14 -05003293 }
3294 }
3295 return skip_call;
3296}
3297
3298bool VerifyDestImageLayout(VkCommandBuffer cmdBuffer, VkImage destImage, VkImageLayout destImageLayout) {
3299 bool skip_call = false;
Mark Lobodzinski78940a42015-11-30 16:48:53 -07003300
3301#ifdef DISABLE_IMAGE_LAYOUT_VALIDATION
3302 // TODO: Fix -- initialLayout may have been set in a previous command buffer
3303 return skip_call;
3304#endif // DISABLE_IMAGE_LAYOUT_VALIDATION
3305
Michael Lentine27b0f902015-10-12 11:30:14 -05003306 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
3307 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
3308 auto dest_image_element = pCB->imageLayoutMap.find(destImage);
3309 if (dest_image_element == pCB->imageLayoutMap.end()) {
3310 pCB->imageLayoutMap[destImage].initialLayout = destImageLayout;
3311 pCB->imageLayoutMap[destImage].layout = destImageLayout;
3312 return false;
3313 }
3314 if (dest_image_element->second.layout != destImageLayout) {
3315 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
3316 "Cannot copy from an image whose dest layout is %d and doesn't match the current layout %d.", destImageLayout, dest_image_element->second.layout);
3317 }
3318 if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) {
3319 if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) {
3320 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
3321 "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL.");
3322 } else {
3323 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
3324 "Layout for output image is %d but can only be TRANSFER_DST_OPTIMAL or GENERAL.", destImageLayout);
3325 }
3326 }
3327 return skip_call;
3328}
3329
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003330VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyImage(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003331 VkImage srcImage,
3332 VkImageLayout srcImageLayout,
Chia-I Wu1f851912015-10-27 18:04:07 +08003333 VkImage dstImage,
3334 VkImageLayout dstImageLayout,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003335 uint32_t regionCount, const VkImageCopy* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003336{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003337 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003338 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3339 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003340 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003341 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003342 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003343 skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGE);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003344 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003345 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyImage()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003346 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003347 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImage");
Michael Lentine27b0f902015-10-12 11:30:14 -05003348 skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, srcImageLayout);
3349 skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, dstImageLayout);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003350 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003351 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003352 dev_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003353}
3354
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003355VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBlitImage(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003356 VkImage srcImage, VkImageLayout srcImageLayout,
Chia-I Wu1f851912015-10-27 18:04:07 +08003357 VkImage dstImage, VkImageLayout dstImageLayout,
Mark Lobodzinski20f68592015-05-22 14:43:25 -05003358 uint32_t regionCount, const VkImageBlit* pRegions,
Chia-I Wu3603b082015-10-26 16:49:32 +08003359 VkFilter filter)
Courtney Goeltzenleuchter6ff8ebc2015-04-03 14:42:51 -06003360{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003361 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003362 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3363 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchter6ff8ebc2015-04-03 14:42:51 -06003364 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003365 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003366 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003367 skipCall |= addCmd(dev_data, pCB, CMD_BLITIMAGE);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003368 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003369 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBlitImage()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003370 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003371 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBlitImage");
Courtney Goeltzenleuchter6ff8ebc2015-04-03 14:42:51 -06003372 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003373 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003374 dev_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, pRegions, filter);
Courtney Goeltzenleuchter6ff8ebc2015-04-03 14:42:51 -06003375}
3376
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003377VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003378 VkBuffer srcBuffer,
Chia-I Wu1f851912015-10-27 18:04:07 +08003379 VkImage dstImage, VkImageLayout dstImageLayout,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003380 uint32_t regionCount, const VkBufferImageCopy* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003381{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003382 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003383 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3384 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003385 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003386 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003387 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003388 skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFERTOIMAGE);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003389 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003390 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyBufferToImage()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003391 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003392 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBufferToImage");
Michael Lentine27b0f902015-10-12 11:30:14 -05003393 skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, dstImageLayout);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003394 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003395 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003396 dev_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003397}
3398
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003399VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003400 VkImage srcImage, VkImageLayout srcImageLayout,
Chia-I Wu1f851912015-10-27 18:04:07 +08003401 VkBuffer dstBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003402 uint32_t regionCount, const VkBufferImageCopy* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003403{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003404 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003405 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3406 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003407 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003408 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003409 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003410 skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGETOBUFFER);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003411 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003412 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyImageToBuffer()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003413 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003414 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImageToBuffer");
Michael Lentine27b0f902015-10-12 11:30:14 -05003415 skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, srcImageLayout);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003416 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003417 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003418 dev_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003419}
3420
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003421VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t* pData)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003422{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003423 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003424 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3425 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003426 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003427 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003428 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003429 skipCall |= addCmd(dev_data, pCB, CMD_UPDATEBUFFER);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003430 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003431 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdUpdateBuffer()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003432 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003433 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyUpdateBuffer");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003434 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003435 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003436 dev_data->device_dispatch_table->CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003437}
3438
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003439VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003440{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003441 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003442 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3443 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003444 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003445 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003446 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003447 skipCall |= addCmd(dev_data, pCB, CMD_FILLBUFFER);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003448 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003449 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdFillBuffer()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003450 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003451 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyFillBuffer");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003452 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003453 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003454 dev_data->device_dispatch_table->CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003455}
3456
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003457VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearAttachments(
Chia-I Wu1f851912015-10-27 18:04:07 +08003458 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003459 uint32_t attachmentCount,
3460 const VkClearAttachment* pAttachments,
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003461 uint32_t rectCount,
Courtney Goeltzenleuchtera12e2912015-10-15 18:22:08 -06003462 const VkClearRect* pRects)
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003463{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003464 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003465 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3466 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003467 if (pCB) {
3468 if (pCB->state == CB_UPDATE_ACTIVE) {
3469 // Warn if this is issued prior to Draw Cmd
3470 if (!hasDrawCmd(pCB)) {
Chia-I Wu1f851912015-10-27 18:04:07 +08003471 // TODO : commandBuffer should be srcObj
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003472 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_WARN_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS",
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003473 "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds."
Chia-I Wu1f851912015-10-27 18:04:07 +08003474 " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", reinterpret_cast<uint64_t>(commandBuffer));
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003475 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003476 updateCBTracking(pCB);
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003477 skipCall |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS);
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003478 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003479 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdClearAttachments()");
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003480 }
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003481 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments");
3482 }
3483
3484 // Validate that attachment is in reference list of active subpass
3485 if (pCB->activeRenderPass) {
Michael Lentine07ff1a12015-10-15 17:07:00 -05003486 const VkRenderPassCreateInfo *pRPCI = dev_data->renderPassMap[pCB->activeRenderPass]->createInfo;
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003487 const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass];
3488
3489 for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) {
3490 const VkClearAttachment *attachment = &pAttachments[attachment_idx];
3491 if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) {
3492 VkBool32 found = VK_FALSE;
Chia-I Wu763a7492015-10-26 20:48:51 +08003493 for (uint32_t i = 0; i < pSD->colorAttachmentCount; i++) {
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003494 if (attachment->colorAttachment == pSD->pColorAttachments[i].attachment) {
3495 found = VK_TRUE;
3496 break;
3497 }
3498 }
3499 if (VK_FALSE == found) {
3500 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER,
Chia-I Wu1f851912015-10-27 18:04:07 +08003501 (uint64_t)commandBuffer, 0, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS",
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003502 "vkCmdClearAttachments() attachment index %d not found in attachment reference array of active subpass %d",
3503 attachment->colorAttachment, pCB->activeSubpass);
3504 }
3505 } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) {
Mark Lobodzinski1523e3a2015-11-17 15:11:24 -07003506 if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass
Mark Lobodzinskiea1fff22015-11-18 08:58:31 -07003507 (pSD->pDepthStencilAttachment->attachment == VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass
Mark Lobodzinski1523e3a2015-11-17 15:11:24 -07003508
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003509 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER,
Mark Lobodzinski1523e3a2015-11-17 15:11:24 -07003510 (uint64_t)commandBuffer, 0, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS",
3511 "vkCmdClearAttachments() attachment index %d does not match depthStencilAttachment.attachment (%d) found in active subpass %d",
3512 attachment->colorAttachment,
3513 (pSD->pDepthStencilAttachment) ? pSD->pDepthStencilAttachment->attachment : VK_ATTACHMENT_UNUSED,
3514 pCB->activeSubpass);
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003515 }
3516 }
3517 }
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003518 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003519 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003520 dev_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects);
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003521}
3522
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003523VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearColorImage(
Chia-I Wu1f851912015-10-27 18:04:07 +08003524 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchterda4a99e2015-04-23 17:49:22 -06003525 VkImage image, VkImageLayout imageLayout,
Chris Forbese3105972015-06-24 14:34:53 +12003526 const VkClearColorValue *pColor,
Courtney Goeltzenleuchterda4a99e2015-04-23 17:49:22 -06003527 uint32_t rangeCount, const VkImageSubresourceRange* pRanges)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003528{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003529 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003530 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3531 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003532 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003533 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003534 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003535 skipCall |= addCmd(dev_data, pCB, CMD_CLEARCOLORIMAGE);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003536 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003537 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdClearColorImage()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003538 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003539 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearColorImage");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003540 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003541 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003542 dev_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003543}
3544
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003545VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearDepthStencilImage(
Chia-I Wu1f851912015-10-27 18:04:07 +08003546 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter315ad992015-09-15 18:03:22 -06003547 VkImage image, VkImageLayout imageLayout,
3548 const VkClearDepthStencilValue *pDepthStencil,
3549 uint32_t rangeCount,
3550 const VkImageSubresourceRange* pRanges)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003551{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003552 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003553 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3554 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003555 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003556 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003557 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003558 skipCall |= addCmd(dev_data, pCB, CMD_CLEARDEPTHSTENCILIMAGE);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003559 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003560 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdClearDepthStencilImage()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003561 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003562 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearDepthStencilImage");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003563 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003564 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003565 dev_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, pRanges);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003566}
3567
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003568VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdResolveImage(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003569 VkImage srcImage, VkImageLayout srcImageLayout,
Chia-I Wu1f851912015-10-27 18:04:07 +08003570 VkImage dstImage, VkImageLayout dstImageLayout,
Tony Barbour11f74372015-04-13 15:02:52 -06003571 uint32_t regionCount, const VkImageResolve* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003572{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003573 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003574 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3575 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003576 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003577 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003578 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003579 skipCall |= addCmd(dev_data, pCB, CMD_RESOLVEIMAGE);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003580 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003581 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResolveImage()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003582 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003583 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResolveImage");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003584 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003585 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003586 dev_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003587}
3588
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003589VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003590{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003591 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003592 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3593 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003594 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003595 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003596 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003597 skipCall |= addCmd(dev_data, pCB, CMD_SETEVENT);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003598 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003599 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetEvent()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003600 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003601 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003602 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003603 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003604 dev_data->device_dispatch_table->CmdSetEvent(commandBuffer, event, stageMask);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003605}
3606
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003607VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003608{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003609 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003610 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3611 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003612 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003613 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003614 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003615 skipCall |= addCmd(dev_data, pCB, CMD_RESETEVENT);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003616 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003617 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetEvent()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003618 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003619 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003620 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003621 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003622 dev_data->device_dispatch_table->CmdResetEvent(commandBuffer, event, stageMask);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003623}
3624
Michael Lentine27b0f902015-10-12 11:30:14 -05003625bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, const void* const* ppMemBarriers) {
3626 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
3627 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
3628 bool skip = false;
Mark Lobodzinski78940a42015-11-30 16:48:53 -07003629
3630#ifdef DISABLE_IMAGE_LAYOUT_VALIDATION
3631 // TODO: Fix -- pay attention to image subresource ranges -- not all subresources transition at the same time
3632 return skip;
3633#endif // DISABLE_IMAGE_LAYOUT_VALIDATION
3634
Michael Lentine27b0f902015-10-12 11:30:14 -05003635 for (uint32_t i = 0; i < memBarrierCount; ++i) {
3636 auto mem_barrier = reinterpret_cast<const VkMemoryBarrier*>(ppMemBarriers[i]);
3637 if (mem_barrier && mem_barrier->sType == VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER) {
3638 auto image_mem_barrier = reinterpret_cast<const VkImageMemoryBarrier*>(mem_barrier);
3639 auto image_data = pCB->imageLayoutMap.find(image_mem_barrier->image);
3640 if (image_data == pCB->imageLayoutMap.end()) {
3641 pCB->imageLayoutMap[image_mem_barrier->image].initialLayout = image_mem_barrier->oldLayout;
3642 pCB->imageLayoutMap[image_mem_barrier->image].layout = image_mem_barrier->newLayout;
3643 } else {
3644 if (image_data->second.layout != image_mem_barrier->oldLayout) {
3645 skip |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine8469dd62015-11-20 09:48:52 -08003646 "You cannot transition the layout from %s when current layout is %s.",
3647 string_VkImageLayout(image_mem_barrier->oldLayout), string_VkImageLayout(image_data->second.layout));
Michael Lentine27b0f902015-10-12 11:30:14 -05003648 }
3649 image_data->second.layout = image_mem_barrier->newLayout;
3650 }
3651 }
3652 }
3653 return skip;
3654}
3655
Michael Lentine8469dd62015-11-20 09:48:52 -08003656// AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set.
3657// If required_bit is zero, accessMask must have at least one of 'optional_bits' set
3658bool ValidateMaskBits(const layer_data* my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags& accessMask, const VkImageLayout& layout, VkAccessFlags required_bit, VkAccessFlags optional_bits) {
Michael Lentine472af7d2015-10-16 18:08:09 -05003659 bool skip_call = false;
Michael Lentine8469dd62015-11-20 09:48:52 -08003660 if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) {
3661 if (accessMask & !(required_bit | optional_bits)) {
Michael Lentine472af7d2015-10-16 18:08:09 -05003662 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
Michael Lentine8469dd62015-11-20 09:48:52 -08003663 "Additional bits in accessMask %d are specified when layout is %s.", accessMask, string_VkImageLayout(layout));
Michael Lentine472af7d2015-10-16 18:08:09 -05003664 }
3665 } else {
Michael Lentine8469dd62015-11-20 09:48:52 -08003666 if (!required_bit) {
3667 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
3668 "AccessMask %d must contain at least one of access bits %d when layout is %s.",
3669 accessMask, optional_bits, string_VkImageLayout(layout));
3670 } else {
3671 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
3672 "AccessMask %d must have required access bit %d and may have optional bits %d when layout is %s.",
3673 accessMask, required_bit, optional_bits,string_VkImageLayout(layout));
3674 }
Michael Lentine472af7d2015-10-16 18:08:09 -05003675 }
3676 return skip_call;
3677}
3678
Michael Lentine8469dd62015-11-20 09:48:52 -08003679bool ValidateMaskBitsFromLayouts(const layer_data* my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags& accessMask, const VkImageLayout& layout) {
Michael Lentine472af7d2015-10-16 18:08:09 -05003680 bool skip_call = false;
Michael Lentine8469dd62015-11-20 09:48:52 -08003681 switch (layout) {
3682 case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: {
3683 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, VK_ACCESS_COLOR_ATTACHMENT_READ_BIT);
3684 break;
Michael Lentine472af7d2015-10-16 18:08:09 -05003685 }
Michael Lentine8469dd62015-11-20 09:48:52 -08003686 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: {
3687 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT);
3688 break;
Michael Lentine472af7d2015-10-16 18:08:09 -05003689 }
Michael Lentine8469dd62015-11-20 09:48:52 -08003690 case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: {
3691 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0);
3692 break;
3693 }
3694 case VK_IMAGE_LAYOUT_PREINITIALIZED: {
3695 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0);
3696 break;
3697 }
3698 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: {
3699 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT);
3700 break;
3701 }
3702 case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: {
3703 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT);
3704 break;
3705 }
3706 case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: {
3707 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0);
3708 break;
3709 }
3710 case VK_IMAGE_LAYOUT_UNDEFINED: {
3711 if (accessMask != 0) {
3712 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
3713 "Additional bits in accessMask %d are specified when layout is %s.", accessMask, string_VkImageLayout(layout));
3714 }
3715 break;
3716 }
3717 case VK_IMAGE_LAYOUT_GENERAL:
3718 default: {
3719 break;
3720 }
Michael Lentine472af7d2015-10-16 18:08:09 -05003721 }
3722 return skip_call;
3723}
3724
Michael Lentine07ff1a12015-10-15 17:07:00 -05003725bool ValidateBarriers(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, const void* const* ppMemBarriers) {
3726 bool skip_call = false;
3727 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
3728 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
3729 if (pCB->activeRenderPass && memBarrierCount) {
3730 for (uint32_t i = 0; i < memBarrierCount; ++i) {
3731 auto mem_barrier = reinterpret_cast<const VkMemoryBarrier*>(ppMemBarriers[i]);
3732 if (mem_barrier && mem_barrier->sType != VK_STRUCTURE_TYPE_MEMORY_BARRIER) {
3733 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
3734 "Image or Buffers Barriers cannot be used during a render pass.");
3735 }
3736 }
3737 if (!dev_data->renderPassMap[pCB->activeRenderPass]->hasSelfDependency[pCB->activeSubpass]) {
3738 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
3739 "Barriers cannot be set during subpass %d with no self dependency specified.", pCB->activeSubpass);
3740 }
3741 }
Mark Lobodzinskib684b512015-11-20 09:27:27 -07003742
Michael Lentine472af7d2015-10-16 18:08:09 -05003743 for (uint32_t i = 0; i < memBarrierCount; ++i) {
3744 auto mem_barrier = reinterpret_cast<const VkMemoryBarrier*>(ppMemBarriers[i]);
3745 if (mem_barrier && mem_barrier->sType == VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER) {
3746 auto image_mem_barrier = reinterpret_cast<const VkImageMemoryBarrier*>(mem_barrier);
Michael Lentine8469dd62015-11-20 09:48:52 -08003747 skip_call |= ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, image_mem_barrier->srcAccessMask, image_mem_barrier->oldLayout);
3748 skip_call |= ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, image_mem_barrier->dstAccessMask, image_mem_barrier->newLayout);
Michael Lentine472af7d2015-10-16 18:08:09 -05003749 }
3750 }
Mark Lobodzinskib95fc092015-12-03 15:42:32 -07003751
Michael Lentine07ff1a12015-10-15 17:07:00 -05003752 return skip_call;
3753}
3754
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003755VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent* pEvents, VkPipelineStageFlags sourceStageMask, VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const void* const* ppMemoryBarriers)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003756{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003757 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003758 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3759 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003760 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003761 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003762 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003763 skipCall |= addCmd(dev_data, pCB, CMD_WAITEVENTS);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003764 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003765 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003766 }
Michael Lentine27b0f902015-10-12 11:30:14 -05003767 skipCall |= TransitionImageLayouts(commandBuffer, memoryBarrierCount, ppMemoryBarriers);
Michael Lentine07ff1a12015-10-15 17:07:00 -05003768 skipCall |= ValidateBarriers(commandBuffer, memoryBarrierCount, ppMemoryBarriers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003769 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003770 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003771 dev_data->device_dispatch_table->CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, memoryBarrierCount, ppMemoryBarriers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003772}
3773
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003774VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const void* const* ppMemoryBarriers)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003775{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003776 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003777 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3778 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003779 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003780 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003781 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003782 skipCall |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003783 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003784 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPipelineBarrier()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003785 }
Michael Lentine27b0f902015-10-12 11:30:14 -05003786 skipCall |= TransitionImageLayouts(commandBuffer, memoryBarrierCount, ppMemoryBarriers);
Michael Lentine07ff1a12015-10-15 17:07:00 -05003787 skipCall |= ValidateBarriers(commandBuffer, memoryBarrierCount, ppMemoryBarriers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003788 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003789 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003790 dev_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, memoryBarrierCount, ppMemoryBarriers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003791}
3792
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003793VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003794{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003795 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003796 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3797 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003798 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003799 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003800 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003801 skipCall |= addCmd(dev_data, pCB, CMD_BEGINQUERY);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003802 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003803 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBeginQuery()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003804 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003805 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003806 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003807 dev_data->device_dispatch_table->CmdBeginQuery(commandBuffer, queryPool, slot, flags);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003808}
3809
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003810VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003811{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003812 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003813 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3814 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003815 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003816 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003817 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003818 skipCall |= addCmd(dev_data, pCB, CMD_ENDQUERY);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003819 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003820 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003821 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003822 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003823 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003824 dev_data->device_dispatch_table->CmdEndQuery(commandBuffer, queryPool, slot);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003825}
3826
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003827VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t startQuery, uint32_t queryCount)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003828{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003829 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003830 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3831 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003832 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003833 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003834 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003835 skipCall |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003836 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003837 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003838 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003839 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003840 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003841 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003842 dev_data->device_dispatch_table->CmdResetQueryPool(commandBuffer, queryPool, startQuery, queryCount);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003843}
3844
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003845VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t startQuery,
Chia-I Wu1f851912015-10-27 18:04:07 +08003846 uint32_t queryCount, VkBuffer dstBuffer, VkDeviceSize dstOffset,
Chia-I Wu1f6942d2015-10-26 18:36:20 +08003847 VkDeviceSize stride, VkQueryResultFlags flags)
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003848{
3849 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003850 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3851 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003852 if (pCB) {
3853 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003854 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003855 skipCall |= addCmd(dev_data, pCB, CMD_COPYQUERYPOOLRESULTS);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003856 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003857 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()");
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003858 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003859 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyQueryPoolResults");
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003860 }
3861 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003862 dev_data->device_dispatch_table->CmdCopyQueryPoolResults(commandBuffer, queryPool,
3863 startQuery, queryCount, dstBuffer, dstOffset, stride, flags);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003864}
3865
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003866VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003867{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003868 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003869 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3870 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003871 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003872 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003873 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003874 skipCall |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003875 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003876 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003877 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003878 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003879 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003880 dev_data->device_dispatch_table->CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003881}
3882
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003883VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkFramebuffer* pFramebuffer)
Tobin Ehlis2464b882015-04-01 08:40:34 -06003884{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003885 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08003886 VkResult result = dev_data->device_dispatch_table->CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06003887 if (VK_SUCCESS == result) {
Tobin Ehlis2464b882015-04-01 08:40:34 -06003888 // Shadow create info and store in map
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003889 VkFramebufferCreateInfo* localFBCI = new VkFramebufferCreateInfo(*pCreateInfo);
Chia-I Wuc278df82015-07-07 11:50:03 +08003890 if (pCreateInfo->pAttachments) {
Courtney Goeltzenleuchter1856d6f2015-09-01 17:30:39 -06003891 localFBCI->pAttachments = new VkImageView[localFBCI->attachmentCount];
3892 memcpy((void*)localFBCI->pAttachments, pCreateInfo->pAttachments, localFBCI->attachmentCount*sizeof(VkImageView));
Tobin Ehlis2464b882015-04-01 08:40:34 -06003893 }
Chia-I Wue420a332015-10-26 20:04:44 +08003894 dev_data->frameBufferMap[*pFramebuffer] = localFBCI;
Tobin Ehlis2464b882015-04-01 08:40:34 -06003895 }
3896 return result;
3897}
3898
Michael Lentine329697b2015-10-06 14:56:18 -07003899// Store the DAG.
3900struct DAGNode {
3901 uint32_t pass;
3902 std::vector<uint32_t> prev;
3903 std::vector<uint32_t> next;
3904};
3905
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003906VkBool32 FindDependency(const int index, const int dependent, const std::vector<DAGNode>& subpass_to_node, std::unordered_set<uint32_t>& processed_nodes) {
Michael Lentine329697b2015-10-06 14:56:18 -07003907 // If we have already checked this node we have not found a dependency path so return false.
3908 if (processed_nodes.count(index))
3909 return false;
3910 processed_nodes.insert(index);
3911 const DAGNode& node = subpass_to_node[index];
3912 // Look for a dependency path. If one exists return true else recurse on the previous nodes.
3913 if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) {
3914 for (auto elem : node.prev) {
3915 if (FindDependency(elem, dependent, subpass_to_node, processed_nodes))
3916 return true;
3917 }
3918 } else {
3919 return true;
3920 }
3921 return false;
3922}
3923
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003924VkBool32 CheckDependencyExists(const layer_data* my_data, VkDevice device, const int subpass, const std::vector<uint32_t>& dependent_subpasses, const std::vector<DAGNode>& subpass_to_node, VkBool32& skip_call) {
3925 VkBool32 result = true;
Michael Lentine329697b2015-10-06 14:56:18 -07003926 // Loop through all subpasses that share the same attachment and make sure a dependency exists
3927 for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) {
3928 if (subpass == dependent_subpasses[k])
3929 continue;
3930 const DAGNode& node = subpass_to_node[subpass];
3931 // Check for a specified dependency between the two nodes. If one exists we are done.
3932 auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]);
3933 auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]);
3934 if (prev_elem == node.prev.end() && next_elem == node.next.end()) {
3935 // If no dependency exits an implicit dependency still might. If so, warn and if not throw an error.
3936 std::unordered_set<uint32_t> processed_nodes;
3937 if (FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) ||
3938 FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003939 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine329697b2015-10-06 14:56:18 -07003940 "A dependency between subpasses %d and %d must exist but only an implicit one is specified.",
3941 subpass, dependent_subpasses[k]);
3942 } else {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003943 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine329697b2015-10-06 14:56:18 -07003944 "A dependency between subpasses %d and %d must exist but one is not specified.",
3945 subpass, dependent_subpasses[k]);
3946 result = false;
3947 }
3948 }
3949 }
3950 return result;
3951}
3952
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003953VkBool32 CheckPreserved(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, const int index, const int attachment, const std::vector<DAGNode>& subpass_to_node, int depth, VkBool32& skip_call) {
Michael Lentine329697b2015-10-06 14:56:18 -07003954 const DAGNode& node = subpass_to_node[index];
3955 // If this node writes to the attachment return true as next nodes need to preserve the attachment.
3956 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[index];
Chia-I Wu763a7492015-10-26 20:48:51 +08003957 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07003958 if (attachment == subpass.pColorAttachments[j].attachment)
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003959 return VK_TRUE;
Michael Lentine329697b2015-10-06 14:56:18 -07003960 }
Chia-I Wuce532f72015-10-26 17:32:47 +08003961 if (subpass.pDepthStencilAttachment &&
3962 subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) {
3963 if (attachment == subpass.pDepthStencilAttachment->attachment)
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003964 return VK_TRUE;
Michael Lentine329697b2015-10-06 14:56:18 -07003965 }
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003966 VkBool32 result = VK_FALSE;
Michael Lentine329697b2015-10-06 14:56:18 -07003967 // Loop through previous nodes and see if any of them write to the attachment.
3968 for (auto elem : node.prev) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003969 result |= CheckPreserved(my_data, device, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07003970 }
3971 // If the attachment was written to by a previous node than this node needs to preserve it.
3972 if (result && depth > 0) {
3973 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[index];
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003974 VkBool32 has_preserved = false;
Chia-I Wu763a7492015-10-26 20:48:51 +08003975 for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07003976 if (subpass.pPreserveAttachments[j].attachment == attachment) {
3977 has_preserved = true;
3978 break;
3979 }
3980 }
3981 if (!has_preserved) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003982 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine329697b2015-10-06 14:56:18 -07003983 "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index);
3984 }
3985 }
3986 return result;
3987}
3988
Michael Lentine27b0f902015-10-12 11:30:14 -05003989VkBool32 ValidateDependencies(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, std::vector<DAGNode>& subpass_to_node) {
3990 VkBool32 skip_call = false;
Michael Lentine329697b2015-10-06 14:56:18 -07003991 std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount);
3992 std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount);
Michael Lentine27b0f902015-10-12 11:30:14 -05003993
Michael Lentine329697b2015-10-06 14:56:18 -07003994 // Create DAG
3995 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
3996 DAGNode& subpass_node = subpass_to_node[i];
3997 subpass_node.pass = i;
3998 }
3999 for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) {
4000 const VkSubpassDependency& dependency = pCreateInfo->pDependencies[i];
Chia-I Wu1f851912015-10-27 18:04:07 +08004001 if (dependency.srcSubpass > dependency.dstSubpass) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004002 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine329697b2015-10-06 14:56:18 -07004003 "Dependency graph must be specified such that an earlier pass cannot depend on a later pass.");
4004 }
Chia-I Wu1f851912015-10-27 18:04:07 +08004005 subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass);
4006 subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass);
Michael Lentine329697b2015-10-06 14:56:18 -07004007 }
Michael Lentine27b0f902015-10-12 11:30:14 -05004008
Michael Lentine329697b2015-10-06 14:56:18 -07004009 // Find for each attachment the subpasses that use them.
4010 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
4011 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i];
Chia-I Wu763a7492015-10-26 20:48:51 +08004012 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07004013 input_attachment_to_subpass[subpass.pInputAttachments[j].attachment].push_back(i);
4014 }
Chia-I Wu763a7492015-10-26 20:48:51 +08004015 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07004016 output_attachment_to_subpass[subpass.pColorAttachments[j].attachment].push_back(i);
4017 }
Chia-I Wuce532f72015-10-26 17:32:47 +08004018 if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) {
4019 output_attachment_to_subpass[subpass.pDepthStencilAttachment->attachment].push_back(i);
Michael Lentine329697b2015-10-06 14:56:18 -07004020 }
4021 }
4022 // If there is a dependency needed make sure one exists
4023 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
4024 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i];
4025 // If the attachment is an input then all subpasses that output must have a dependency relationship
Chia-I Wu763a7492015-10-26 20:48:51 +08004026 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07004027 const uint32_t& attachment = subpass.pInputAttachments[j].attachment;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004028 CheckDependencyExists(my_data, device, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07004029 }
4030 // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship
Chia-I Wu763a7492015-10-26 20:48:51 +08004031 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07004032 const uint32_t& attachment = subpass.pColorAttachments[j].attachment;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004033 CheckDependencyExists(my_data, device, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call);
4034 CheckDependencyExists(my_data, device, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07004035 }
Chia-I Wuce532f72015-10-26 17:32:47 +08004036 if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) {
4037 const uint32_t& attachment = subpass.pDepthStencilAttachment->attachment;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004038 CheckDependencyExists(my_data, device, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call);
4039 CheckDependencyExists(my_data, device, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07004040 }
4041 }
4042 // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was written.
4043 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
4044 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i];
Chia-I Wu763a7492015-10-26 20:48:51 +08004045 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004046 CheckPreserved(my_data, device, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07004047 }
4048 }
4049 return skip_call;
4050}
4051
Michael Lentine27b0f902015-10-12 11:30:14 -05004052bool ValidateLayouts(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo) {
4053 bool skip = false;
Mark Lobodzinski78940a42015-11-30 16:48:53 -07004054
4055#ifdef DISABLE_IMAGE_LAYOUT_VALIDATION
4056 return skip;
4057#endif // DISABLE_IMAGE_LAYOUT_VALIDATION
4058
Michael Lentine27b0f902015-10-12 11:30:14 -05004059 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
4060 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i];
4061 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
4062 if (subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL &&
4063 subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) {
4064 if (subpass.pInputAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) {
4065 skip |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4066 "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL.");
4067 } else {
4068 skip |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4069 "Layout for input attachment is %d but can only be READ_ONLY_OPTIMAL or GENERAL.", subpass.pInputAttachments[j].attachment);
4070 }
4071 }
4072 }
4073 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
4074 if (subpass.pColorAttachments[j].layout != VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL) {
4075 if (subpass.pColorAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) {
4076 skip |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4077 "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL.");
4078 } else {
4079 skip |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4080 "Layout for color attachment is %d but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", subpass.pColorAttachments[j].attachment);
4081 }
4082 }
4083 }
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06004084 if ((subpass.pDepthStencilAttachment != NULL) &&
4085 (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) {
Michael Lentine27b0f902015-10-12 11:30:14 -05004086 if (subpass.pDepthStencilAttachment->layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL) {
4087 if (subpass.pDepthStencilAttachment->layout == VK_IMAGE_LAYOUT_GENERAL) {
4088 skip |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4089 "Layout for depth attachment is GENERAL but should be DEPTH_STENCIL_ATTACHMENT_OPTIMAL.");
4090 } else {
4091 skip |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4092 "Layout for depth attachment is %d but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL or GENERAL.", subpass.pDepthStencilAttachment->attachment);
4093 }
4094 }
4095 }
4096 }
4097 return skip;
4098}
4099
Michael Lentine07ff1a12015-10-15 17:07:00 -05004100bool CreatePassDAG(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, std::vector<DAGNode>& subpass_to_node, std::vector<bool>& has_self_dependency) {
Michael Lentine27b0f902015-10-12 11:30:14 -05004101 bool skip_call = false;
4102 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
4103 DAGNode& subpass_node = subpass_to_node[i];
4104 subpass_node.pass = i;
4105 }
4106 for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) {
4107 const VkSubpassDependency& dependency = pCreateInfo->pDependencies[i];
4108 if (dependency.srcSubpass > dependency.dstSubpass) {
4109 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
4110 "Depedency graph must be specified such that an earlier pass cannot depend on a later pass.");
Michael Lentine07ff1a12015-10-15 17:07:00 -05004111 } else if (dependency.srcSubpass == dependency.dstSubpass) {
4112 has_self_dependency[dependency.srcSubpass] = true;
Michael Lentine27b0f902015-10-12 11:30:14 -05004113 }
4114 subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass);
4115 subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass);
4116 }
4117 return skip_call;
4118}
Tobin Ehliscb085292015-12-01 09:57:09 -07004119// TODOSC : Add intercept of vkCreateShaderModule
Michael Lentine27b0f902015-10-12 11:30:14 -05004120
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004121VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkRenderPass* pRenderPass)
Tobin Ehlis2464b882015-04-01 08:40:34 -06004122{
Michael Lentine27b0f902015-10-12 11:30:14 -05004123 bool skip_call = false;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004124 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Michael Lentine27b0f902015-10-12 11:30:14 -05004125 // Create DAG
Michael Lentine07ff1a12015-10-15 17:07:00 -05004126 std::vector<bool> has_self_dependency(pCreateInfo->subpassCount);
Michael Lentine27b0f902015-10-12 11:30:14 -05004127 std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount);
Michael Lentine07ff1a12015-10-15 17:07:00 -05004128 skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency);
Michael Lentine27b0f902015-10-12 11:30:14 -05004129 // Validate using DAG
4130 skip_call |= ValidateDependencies(dev_data, device, pCreateInfo, subpass_to_node);
4131 skip_call |= ValidateLayouts(dev_data, device, pCreateInfo);
4132 if (skip_call) {
Michael Lentine329697b2015-10-06 14:56:18 -07004133 return VK_ERROR_VALIDATION_FAILED;
4134 }
Chia-I Wu69f40122015-10-26 21:10:41 +08004135 VkResult result = dev_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004136 if (VK_SUCCESS == result) {
Tobin Ehliscb085292015-12-01 09:57:09 -07004137 // TODOSC : Merge in tracking of renderpass from ShaderChecker
Tobin Ehlis2464b882015-04-01 08:40:34 -06004138 // Shadow create info and store in map
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06004139 VkRenderPassCreateInfo* localRPCI = new VkRenderPassCreateInfo(*pCreateInfo);
Chia-I Wuc278df82015-07-07 11:50:03 +08004140 if (pCreateInfo->pAttachments) {
4141 localRPCI->pAttachments = new VkAttachmentDescription[localRPCI->attachmentCount];
4142 memcpy((void*)localRPCI->pAttachments, pCreateInfo->pAttachments, localRPCI->attachmentCount*sizeof(VkAttachmentDescription));
Tobin Ehlis2464b882015-04-01 08:40:34 -06004143 }
Chia-I Wuc278df82015-07-07 11:50:03 +08004144 if (pCreateInfo->pSubpasses) {
4145 localRPCI->pSubpasses = new VkSubpassDescription[localRPCI->subpassCount];
4146 memcpy((void*)localRPCI->pSubpasses, pCreateInfo->pSubpasses, localRPCI->subpassCount*sizeof(VkSubpassDescription));
4147
4148 for (uint32_t i = 0; i < localRPCI->subpassCount; i++) {
4149 VkSubpassDescription *subpass = (VkSubpassDescription *) &localRPCI->pSubpasses[i];
Chia-I Wu763a7492015-10-26 20:48:51 +08004150 const uint32_t attachmentCount = subpass->inputAttachmentCount +
4151 subpass->colorAttachmentCount * (1 + (subpass->pResolveAttachments?1:0)) +
Chia-I Wuce532f72015-10-26 17:32:47 +08004152 ((subpass->pDepthStencilAttachment) ? 1 : 0) + subpass->preserveAttachmentCount;
Chia-I Wuc278df82015-07-07 11:50:03 +08004153 VkAttachmentReference *attachments = new VkAttachmentReference[attachmentCount];
4154
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004155 memcpy(attachments, subpass->pInputAttachments,
Chia-I Wu763a7492015-10-26 20:48:51 +08004156 sizeof(attachments[0]) * subpass->inputAttachmentCount);
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004157 subpass->pInputAttachments = attachments;
Chia-I Wu763a7492015-10-26 20:48:51 +08004158 attachments += subpass->inputAttachmentCount;
Chia-I Wuc278df82015-07-07 11:50:03 +08004159
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004160 memcpy(attachments, subpass->pColorAttachments,
Chia-I Wu763a7492015-10-26 20:48:51 +08004161 sizeof(attachments[0]) * subpass->colorAttachmentCount);
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004162 subpass->pColorAttachments = attachments;
Chia-I Wu763a7492015-10-26 20:48:51 +08004163 attachments += subpass->colorAttachmentCount;
Chia-I Wuc278df82015-07-07 11:50:03 +08004164
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004165 if (subpass->pResolveAttachments) {
4166 memcpy(attachments, subpass->pResolveAttachments,
Chia-I Wu763a7492015-10-26 20:48:51 +08004167 sizeof(attachments[0]) * subpass->colorAttachmentCount);
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004168 subpass->pResolveAttachments = attachments;
Chia-I Wu763a7492015-10-26 20:48:51 +08004169 attachments += subpass->colorAttachmentCount;
Chia-I Wuc278df82015-07-07 11:50:03 +08004170 }
4171
Chia-I Wuce532f72015-10-26 17:32:47 +08004172 if (subpass->pDepthStencilAttachment) {
4173 memcpy(attachments, subpass->pDepthStencilAttachment,
4174 sizeof(attachments[0]) * 1);
4175 subpass->pDepthStencilAttachment = attachments;
4176 attachments += 1;
4177 }
4178
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004179 memcpy(attachments, subpass->pPreserveAttachments,
Chia-I Wu763a7492015-10-26 20:48:51 +08004180 sizeof(attachments[0]) * subpass->preserveAttachmentCount);
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004181 subpass->pPreserveAttachments = attachments;
Chia-I Wuc278df82015-07-07 11:50:03 +08004182 }
Tobin Ehlis2464b882015-04-01 08:40:34 -06004183 }
Chia-I Wuc278df82015-07-07 11:50:03 +08004184 if (pCreateInfo->pDependencies) {
4185 localRPCI->pDependencies = new VkSubpassDependency[localRPCI->dependencyCount];
4186 memcpy((void*)localRPCI->pDependencies, pCreateInfo->pDependencies, localRPCI->dependencyCount*sizeof(VkSubpassDependency));
Tobin Ehlis2464b882015-04-01 08:40:34 -06004187 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004188 dev_data->renderPassMap[*pRenderPass] = new RENDER_PASS_NODE();
4189 dev_data->renderPassMap[*pRenderPass]->hasSelfDependency = has_self_dependency;
4190 dev_data->renderPassMap[*pRenderPass]->createInfo = localRPCI;
Tobin Ehlis2464b882015-04-01 08:40:34 -06004191 }
4192 return result;
4193}
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004194// Free the renderpass shadow
4195static void deleteRenderPasses(layer_data* my_data)
4196{
4197 if (my_data->renderPassMap.size() <= 0)
4198 return;
4199 for (auto ii=my_data->renderPassMap.begin(); ii!=my_data->renderPassMap.end(); ++ii) {
Michael Lentine07ff1a12015-10-15 17:07:00 -05004200 const VkRenderPassCreateInfo* pRenderPassInfo = (*ii).second->createInfo;
4201 if (pRenderPassInfo->pAttachments) {
4202 delete[] pRenderPassInfo->pAttachments;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004203 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004204 if (pRenderPassInfo->pSubpasses) {
4205 for (uint32_t i=0; i<pRenderPassInfo->subpassCount; ++i) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004206 // Attachements are all allocated in a block, so just need to
4207 // find the first non-null one to delete
Michael Lentine07ff1a12015-10-15 17:07:00 -05004208 if (pRenderPassInfo->pSubpasses[i].pInputAttachments) {
4209 delete[] pRenderPassInfo->pSubpasses[i].pInputAttachments;
4210 } else if (pRenderPassInfo->pSubpasses[i].pColorAttachments) {
4211 delete[] pRenderPassInfo->pSubpasses[i].pColorAttachments;
4212 } else if (pRenderPassInfo->pSubpasses[i].pResolveAttachments) {
4213 delete[] pRenderPassInfo->pSubpasses[i].pResolveAttachments;
4214 } else if (pRenderPassInfo->pSubpasses[i].pPreserveAttachments) {
4215 delete[] pRenderPassInfo->pSubpasses[i].pPreserveAttachments;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004216 }
4217 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004218 delete[] pRenderPassInfo->pSubpasses;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004219 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004220 if (pRenderPassInfo->pDependencies) {
4221 delete[] pRenderPassInfo->pDependencies;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004222 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004223 delete (*ii).second;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004224 }
4225 my_data->renderPassMap.clear();
4226}
Michael Lentine27b0f902015-10-12 11:30:14 -05004227
4228bool VerifyFramebufferAndRenderPassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo* pRenderPassBegin) {
4229 bool skip_call = false;
4230 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
4231 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
Michael Lentine07ff1a12015-10-15 17:07:00 -05004232 const VkRenderPassCreateInfo* pRenderPassInfo = dev_data->renderPassMap[pRenderPassBegin->renderPass]->createInfo;
Michael Lentine27b0f902015-10-12 11:30:14 -05004233 const VkFramebufferCreateInfo* pFramebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer];
4234 if (pRenderPassInfo->attachmentCount != pFramebufferInfo->attachmentCount) {
4235 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
4236 "You cannot start a render pass using a framebuffer with a different number of attachments.");
4237 }
4238 for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) {
4239 const VkImageView& image_view = pFramebufferInfo->pAttachments[i];
4240 const VkImage& image = dev_data->imageViewMap[image_view]->image;
4241 auto image_data = pCB->imageLayoutMap.find(image);
4242 if (image_data == pCB->imageLayoutMap.end()) {
4243 pCB->imageLayoutMap[image].initialLayout = pRenderPassInfo->pAttachments[i].initialLayout;
4244 pCB->imageLayoutMap[image].layout = pRenderPassInfo->pAttachments[i].initialLayout;
4245 } else if (pRenderPassInfo->pAttachments[i].initialLayout != image_data->second.layout) {
4246 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
4247 "You cannot start a render pass using attachment %i where the intial layout differs from the starting layout.", i);
4248 }
4249 }
4250 return skip_call;
4251}
4252
4253void TransitionSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo* pRenderPassBegin, const int subpass_index) {
4254 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
4255 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
4256 auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass);
4257 if (render_pass_data == dev_data->renderPassMap.end()) {
4258 return;
4259 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004260 const VkRenderPassCreateInfo* pRenderPassInfo = render_pass_data->second->createInfo;
Michael Lentine27b0f902015-10-12 11:30:14 -05004261 auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer);
4262 if (framebuffer_data == dev_data->frameBufferMap.end()) {
4263 return;
4264 }
4265 const VkFramebufferCreateInfo* pFramebufferInfo = framebuffer_data->second;
4266 const VkSubpassDescription& subpass = pRenderPassInfo->pSubpasses[subpass_index];
4267 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
4268 const VkImageView& image_view = pFramebufferInfo->pAttachments[subpass.pInputAttachments[j].attachment];
4269 auto image_view_data = dev_data->imageViewMap.find(image_view);
4270 if (image_view_data != dev_data->imageViewMap.end()) {
4271 auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image);
4272 if (image_layout != pCB->imageLayoutMap.end()) {
4273 image_layout->second.layout = subpass.pInputAttachments[j].layout;
4274 }
4275 }
4276 }
4277 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
4278 const VkImageView& image_view = pFramebufferInfo->pAttachments[subpass.pColorAttachments[j].attachment];
4279 auto image_view_data = dev_data->imageViewMap.find(image_view);
4280 if (image_view_data != dev_data->imageViewMap.end()) {
4281 auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image);
4282 if (image_layout != pCB->imageLayoutMap.end()) {
4283 image_layout->second.layout = subpass.pColorAttachments[j].layout;
4284 }
4285 }
4286 }
Michael Lentine2b9eda42015-10-28 15:55:18 -07004287 if ((subpass.pDepthStencilAttachment != NULL) &&
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06004288 (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) {
Michael Lentine27b0f902015-10-12 11:30:14 -05004289 const VkImageView& image_view = pFramebufferInfo->pAttachments[subpass.pDepthStencilAttachment->attachment];
4290 auto image_view_data = dev_data->imageViewMap.find(image_view);
4291 if (image_view_data != dev_data->imageViewMap.end()) {
4292 auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image);
4293 if (image_layout != pCB->imageLayoutMap.end()) {
4294 image_layout->second.layout = subpass.pDepthStencilAttachment->layout;
4295 }
4296 }
4297 }
4298}
4299
Michael Lentine2b9eda42015-10-28 15:55:18 -07004300bool validatePrimaryCommandBuffer(const layer_data* my_data, const GLOBAL_CB_NODE* pCB, const std::string& cmd_name) {
4301 bool skip_call = false;
4302 if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) {
4303 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
4304 "Cannot execute command %s on a secondary command buffer.", cmd_name.c_str());
4305 }
4306 return skip_call;
4307}
4308
Michael Lentine27b0f902015-10-12 11:30:14 -05004309void TransitionFinalSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo* pRenderPassBegin) {
4310 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
4311 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
4312 auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass);
4313 if (render_pass_data == dev_data->renderPassMap.end()) {
4314 return;
4315 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004316 const VkRenderPassCreateInfo* pRenderPassInfo = render_pass_data->second->createInfo;
Michael Lentine27b0f902015-10-12 11:30:14 -05004317 auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer);
4318 if (framebuffer_data == dev_data->frameBufferMap.end()) {
4319 return;
4320 }
4321 const VkFramebufferCreateInfo* pFramebufferInfo = framebuffer_data->second;
4322 for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) {
4323 const VkImageView& image_view = pFramebufferInfo->pAttachments[i];
4324 auto image_view_data = dev_data->imageViewMap.find(image_view);
4325 if (image_view_data != dev_data->imageViewMap.end()) {
4326 auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image);
4327 if (image_layout != pCB->imageLayoutMap.end()) {
4328 image_layout->second.layout = pRenderPassInfo->pAttachments[i].finalLayout;
4329 }
4330 }
4331 }
4332}
4333
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004334VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004335{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004336 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004337 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4338 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004339 if (pCB) {
Tobin Ehlis8b6c2352015-06-23 16:13:03 -06004340 if (pRenderPassBegin && pRenderPassBegin->renderPass) {
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06004341 skipCall |= VerifyFramebufferAndRenderPassLayouts(commandBuffer, pRenderPassBegin);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004342 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBeginRenderPass");
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004343 updateCBTracking(pCB);
Michael Lentine2b9eda42015-10-28 15:55:18 -07004344 skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdBeginRenderPass");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004345 skipCall |= addCmd(dev_data, pCB, CMD_BEGINRENDERPASS);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004346 pCB->activeRenderPass = pRenderPassBegin->renderPass;
Michael Lentine27b0f902015-10-12 11:30:14 -05004347 // This is a shallow copy as that is all that is needed for now
4348 pCB->activeRenderPassBeginInfo = *pRenderPassBegin;
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004349 pCB->activeSubpass = 0;
4350 pCB->framebuffer = pRenderPassBegin->framebuffer;
4351 if (pCB->lastBoundPipeline) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004352 skipCall |= validatePipelineState(dev_data, pCB, VK_PIPELINE_BIND_POINT_GRAPHICS, pCB->lastBoundPipeline);
Tobin Ehlis8b6c2352015-06-23 16:13:03 -06004353 }
Tobin Ehlise4076782015-06-24 15:53:07 -06004354 } else {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004355 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Tobin Ehlis8b6c2352015-06-23 16:13:03 -06004356 "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()");
Tony Barbourb9f82ba2015-04-06 11:09:26 -06004357 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004358 }
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06004359 if (VK_FALSE == skipCall) {
Chia-I Wu1f851912015-10-27 18:04:07 +08004360 dev_data->device_dispatch_table->CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents);
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06004361 // This is a shallow copy as that is all that is needed for now
4362 dev_data->renderPassBeginInfo = *pRenderPassBegin;
4363 dev_data->currentSubpass = 0;
4364 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004365}
4366
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004367VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents)
Chia-I Wuc278df82015-07-07 11:50:03 +08004368{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004369 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004370 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4371 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Michael Lentine27b0f902015-10-12 11:30:14 -05004372 TransitionSubpassLayouts(commandBuffer, &dev_data->renderPassBeginInfo, ++dev_data->currentSubpass);
Chia-I Wuc278df82015-07-07 11:50:03 +08004373 if (pCB) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004374 updateCBTracking(pCB);
Michael Lentine2b9eda42015-10-28 15:55:18 -07004375 skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004376 skipCall |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004377 pCB->activeSubpass++;
Michael Lentine27b0f902015-10-12 11:30:14 -05004378 TransitionSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo, ++pCB->activeSubpass);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004379 if (pCB->lastBoundPipeline) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004380 skipCall |= validatePipelineState(dev_data, pCB, VK_PIPELINE_BIND_POINT_GRAPHICS, pCB->lastBoundPipeline);
Chia-I Wuc278df82015-07-07 11:50:03 +08004381 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004382 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass");
Chia-I Wuc278df82015-07-07 11:50:03 +08004383 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004384 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004385 dev_data->device_dispatch_table->CmdNextSubpass(commandBuffer, contents);
Chia-I Wuc278df82015-07-07 11:50:03 +08004386}
4387
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004388VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndRenderPass(VkCommandBuffer commandBuffer)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004389{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004390 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004391 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4392 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Michael Lentine27b0f902015-10-12 11:30:14 -05004393 TransitionFinalSubpassLayouts(commandBuffer, &dev_data->renderPassBeginInfo);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004394 if (pCB) {
Michael Lentine2b9eda42015-10-28 15:55:18 -07004395 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass");
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004396 updateCBTracking(pCB);
Michael Lentine2b9eda42015-10-28 15:55:18 -07004397 skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004398 skipCall |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS);
Michael Lentine27b0f902015-10-12 11:30:14 -05004399 TransitionFinalSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004400 pCB->activeRenderPass = 0;
4401 pCB->activeSubpass = 0;
Chia-I Wu88eaa3b2015-06-26 15:34:39 +08004402 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004403 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004404 dev_data->device_dispatch_table->CmdEndRenderPass(commandBuffer);
Chia-I Wu88eaa3b2015-06-26 15:34:39 +08004405}
4406
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004407VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer* pCommandBuffers)
Chia-I Wu88eaa3b2015-06-26 15:34:39 +08004408{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004409 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004410 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4411 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Chia-I Wu88eaa3b2015-06-26 15:34:39 +08004412 if (pCB) {
Tobin Ehlis5f728d32015-09-17 14:18:16 -06004413 GLOBAL_CB_NODE* pSubCB = NULL;
Chia-I Wu1f851912015-10-27 18:04:07 +08004414 for (uint32_t i=0; i<commandBuffersCount; i++) {
4415 pSubCB = getCBNode(dev_data, pCommandBuffers[i]);
Tobin Ehlis5f728d32015-09-17 14:18:16 -06004416 if (!pSubCB) {
Chia-I Wu1f851912015-10-27 18:04:07 +08004417 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS",
4418 "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p in element %u of pCommandBuffers array.", (void*)pCommandBuffers[i], i);
4419 } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) {
4420 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS",
4421 "vkCmdExecuteCommands() called w/ Primary Cmd Buffer %p in element %u of pCommandBuffers array. All cmd buffers in pCommandBuffers array must be secondary.", (void*)pCommandBuffers[i], i);
Tobin Ehlis5f728d32015-09-17 14:18:16 -06004422 }
4423 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004424 updateCBTracking(pCB);
Michael Lentine2b9eda42015-10-28 15:55:18 -07004425 skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004426 skipCall |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004427 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004428 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004429 dev_data->device_dispatch_table->CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004430}
4431
Michael Lentineee4ad4d2015-10-23 12:41:44 -07004432bool ValidateMapImageLayouts(VkDevice device, VkDeviceMemory mem) {
4433 bool skip_call = false;
4434 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
4435 auto mem_data = dev_data->memImageMap.find(mem);
4436 if (mem_data != dev_data->memImageMap.end()) {
4437 auto image_data = dev_data->imageLayoutMap.find(mem_data->second);
4438 if (image_data != dev_data->imageLayoutMap.end()) {
4439 if (image_data->second->layout != VK_IMAGE_LAYOUT_PREINITIALIZED && image_data->second->layout != VK_IMAGE_LAYOUT_GENERAL) {
4440 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4441 "Cannot map an image with layout %d. Only GENERAL or PREINITIALIZED are supported.", image_data->second->layout);
4442 }
4443 }
4444 }
4445 return skip_call;
4446}
4447
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004448VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkMapMemory(
Michael Lentineee4ad4d2015-10-23 12:41:44 -07004449 VkDevice device,
4450 VkDeviceMemory mem,
4451 VkDeviceSize offset,
4452 VkDeviceSize size,
4453 VkFlags flags,
4454 void **ppData)
4455{
4456 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Mark Lobodzinski78940a42015-11-30 16:48:53 -07004457
4458 bool skip_call = VK_FALSE;
4459#ifndef DISABLE_IMAGE_LAYOUT_VALIDATION
4460 skip_call = ValidateMapImageLayouts(device, mem);
4461#endif // DISABLE_IMAGE_LAYOUT_VALIDATION
4462
Michael Lentineee4ad4d2015-10-23 12:41:44 -07004463 if (VK_FALSE == skip_call) {
4464 return dev_data->device_dispatch_table->MapMemory(device, mem, offset, size, flags, ppData);
4465 }
4466 return VK_ERROR_VALIDATION_FAILED;
4467}
4468
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004469VKAPI_ATTR VkResult VKAPI_CALL vkBindImageMemory(
Michael Lentineee4ad4d2015-10-23 12:41:44 -07004470 VkDevice device,
4471 VkImage image,
4472 VkDeviceMemory mem,
4473 VkDeviceSize memOffset)
4474{
4475 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
4476 VkResult result = dev_data->device_dispatch_table->BindImageMemory(device, image, mem, memOffset);
4477 loader_platform_thread_lock_mutex(&globalLock);
4478 dev_data->memImageMap[mem] = image;
4479 loader_platform_thread_unlock_mutex(&globalLock);
4480 return result;
4481}
4482
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004483VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSwapchainKHR(
Michael Lentine27b0f902015-10-12 11:30:14 -05004484 VkDevice device,
4485 const VkSwapchainCreateInfoKHR *pCreateInfo,
Ian Elliottc623ba52015-11-20 14:13:17 -07004486 const VkAllocationCallbacks *pAllocator,
Michael Lentine27b0f902015-10-12 11:30:14 -05004487 VkSwapchainKHR *pSwapchain)
4488{
4489 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Ian Elliottc623ba52015-11-20 14:13:17 -07004490 VkResult result = dev_data->device_dispatch_table->CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain);
Michael Lentine27b0f902015-10-12 11:30:14 -05004491
4492 if (VK_SUCCESS == result) {
4493 SWAPCHAIN_NODE *swapchain_data = new SWAPCHAIN_NODE;
4494 loader_platform_thread_lock_mutex(&globalLock);
4495 dev_data->device_extensions.swapchainMap[*pSwapchain] = swapchain_data;
4496 loader_platform_thread_unlock_mutex(&globalLock);
4497 }
4498
4499 return result;
4500}
4501
Ian Elliottc623ba52015-11-20 14:13:17 -07004502VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroySwapchainKHR(
Michael Lentine27b0f902015-10-12 11:30:14 -05004503 VkDevice device,
Ian Elliottc623ba52015-11-20 14:13:17 -07004504 VkSwapchainKHR swapchain,
4505 const VkAllocationCallbacks *pAllocator)
Michael Lentine27b0f902015-10-12 11:30:14 -05004506{
4507 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Michael Lentine27b0f902015-10-12 11:30:14 -05004508
4509 loader_platform_thread_lock_mutex(&globalLock);
4510 auto swapchain_data = dev_data->device_extensions.swapchainMap.find(swapchain);
4511 if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) {
4512 if (swapchain_data->second->images.size() > 0) {
4513 for (auto swapchain_image : swapchain_data->second->images) {
4514 auto image_item = dev_data->imageLayoutMap.find(swapchain_image);
4515 if (image_item != dev_data->imageLayoutMap.end())
4516 dev_data->imageLayoutMap.erase(image_item);
4517 }
4518 }
4519 delete swapchain_data->second;
4520 dev_data->device_extensions.swapchainMap.erase(swapchain);
4521 }
4522 loader_platform_thread_unlock_mutex(&globalLock);
Ian Elliottc623ba52015-11-20 14:13:17 -07004523 return dev_data->device_dispatch_table->DestroySwapchainKHR(device, swapchain, pAllocator);
Michael Lentine27b0f902015-10-12 11:30:14 -05004524}
4525
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004526VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkGetSwapchainImagesKHR(
Michael Lentine27b0f902015-10-12 11:30:14 -05004527 VkDevice device,
4528 VkSwapchainKHR swapchain,
4529 uint32_t* pCount,
4530 VkImage* pSwapchainImages)
4531{
4532 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
4533 VkResult result = dev_data->device_dispatch_table->GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages);
4534
4535 if (result == VK_SUCCESS && pSwapchainImages != NULL) {
4536 // This should never happen and is checked by param checker.
4537 if (!pCount) return result;
4538 for (uint32_t i = 0; i < *pCount; ++i) {
4539 IMAGE_NODE* image_node = new IMAGE_NODE;
4540 image_node->layout = VK_IMAGE_LAYOUT_UNDEFINED;
4541 loader_platform_thread_lock_mutex(&globalLock);
4542 dev_data->device_extensions.swapchainMap[swapchain]->images.push_back(pSwapchainImages[i]);
4543 dev_data->imageLayoutMap[pSwapchainImages[i]] = image_node;
4544 loader_platform_thread_unlock_mutex(&globalLock);
4545 }
4546 }
4547 return result;
4548}
4549
Ian Elliottc623ba52015-11-20 14:13:17 -07004550VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR* pPresentInfo)
Michael Lentine27b0f902015-10-12 11:30:14 -05004551{
4552 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map);
4553 bool skip_call = false;
4554
Mark Lobodzinski78940a42015-11-30 16:48:53 -07004555#ifndef DISABLE_IMAGE_LAYOUT_VALIDATION
Michael Lentine27b0f902015-10-12 11:30:14 -05004556 if (pPresentInfo) {
4557 for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) {
Ian Elliottc623ba52015-11-20 14:13:17 -07004558 auto swapchain_data = dev_data->device_extensions.swapchainMap.find(pPresentInfo->pSwapchains[i]);
4559 if (swapchain_data != dev_data->device_extensions.swapchainMap.end() && pPresentInfo->pImageIndices[i] < swapchain_data->second->images.size()) {
4560 VkImage image = swapchain_data->second->images[pPresentInfo->pImageIndices[i]];
Michael Lentine27b0f902015-10-12 11:30:14 -05004561 auto image_data = dev_data->imageLayoutMap.find(image);
4562 if (image_data != dev_data->imageLayoutMap.end()) {
Ian Elliottc623ba52015-11-20 14:13:17 -07004563 if (image_data->second->layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) {
Michael Lentine27b0f902015-10-12 11:30:14 -05004564 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_QUEUE, (uint64_t)queue, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4565 "Images passed to present must be in layout PRESENT_SOURCE_KHR but is in %d", image_data->second->layout);
4566 }
4567 }
4568 }
4569 }
4570 }
Mark Lobodzinski78940a42015-11-30 16:48:53 -07004571#endif // DISABLE_IMAGE_LAYOUT_VALIDATION
Michael Lentine27b0f902015-10-12 11:30:14 -05004572
4573 if (VK_FALSE == skip_call)
4574 return dev_data->device_dispatch_table->QueuePresentKHR(queue, pPresentInfo);
4575 return VK_ERROR_VALIDATION_FAILED;
4576}
4577
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004578VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkDbgCreateMsgCallback(
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -06004579 VkInstance instance,
4580 VkFlags msgFlags,
4581 const PFN_vkDbgMsgCallback pfnMsgCallback,
4582 void* pUserData,
4583 VkDbgMsgCallback* pMsgCallback)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004584{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004585 layer_data* my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map);
Tobin Ehliscb085292015-12-01 09:57:09 -07004586 VkResult res = my_data->instance_dispatch_table->DbgCreateMsgCallback(instance, msgFlags, pfnMsgCallback, pUserData, pMsgCallback);
Tobin Ehlisc91330b2015-06-16 09:04:30 -06004587 if (VK_SUCCESS == res) {
Tobin Ehlisc91330b2015-06-16 09:04:30 -06004588 res = layer_create_msg_callback(my_data->report_data, msgFlags, pfnMsgCallback, pUserData, pMsgCallback);
4589 }
4590 return res;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004591}
4592
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004593VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkDbgDestroyMsgCallback(
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -06004594 VkInstance instance,
4595 VkDbgMsgCallback msgCallback)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004596{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004597 layer_data* my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map);
Tobin Ehliscb085292015-12-01 09:57:09 -07004598 VkResult res = my_data->instance_dispatch_table->DbgDestroyMsgCallback(instance, msgCallback);
Tobin Ehlisc91330b2015-06-16 09:04:30 -06004599 layer_destroy_msg_callback(my_data->report_data, msgCallback);
4600 return res;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004601}
4602
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004603VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDbgMarkerBegin(VkCommandBuffer commandBuffer, const char* pMarker)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004604{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004605 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004606 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4607 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004608 if (!dev_data->device_extensions.debug_marker_enabled) {
Chia-I Wu1f851912015-10-27 18:04:07 +08004609 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, (uint64_t)commandBuffer, 0, DRAWSTATE_INVALID_EXTENSION, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06004610 "Attempt to use CmdDbgMarkerBegin but extension disabled!");
Jon Ashburn6f8cd632015-06-01 09:37:38 -06004611 return;
Tobin Ehlisa366ca22015-06-19 15:07:05 -06004612 } else if (pCB) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004613 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004614 skipCall |= addCmd(dev_data, pCB, CMD_DBGMARKERBEGIN);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004615 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004616 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004617 debug_marker_dispatch_table(commandBuffer)->CmdDbgMarkerBegin(commandBuffer, pMarker);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004618}
4619
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004620VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDbgMarkerEnd(VkCommandBuffer commandBuffer)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004621{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004622 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004623 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4624 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004625 if (!dev_data->device_extensions.debug_marker_enabled) {
Chia-I Wu1f851912015-10-27 18:04:07 +08004626 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, (uint64_t)commandBuffer, 0, DRAWSTATE_INVALID_EXTENSION, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06004627 "Attempt to use CmdDbgMarkerEnd but extension disabled!");
Jon Ashburn6f8cd632015-06-01 09:37:38 -06004628 return;
Tobin Ehlisa366ca22015-06-19 15:07:05 -06004629 } else if (pCB) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004630 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004631 skipCall |= addCmd(dev_data, pCB, CMD_DBGMARKEREND);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004632 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004633 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004634 debug_marker_dispatch_table(commandBuffer)->CmdDbgMarkerEnd(commandBuffer);
Jon Ashburn6f8cd632015-06-01 09:37:38 -06004635}
4636
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004637VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char* funcName)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004638{
Jon Ashburn1245cec2015-05-18 13:20:15 -06004639 if (dev == NULL)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004640 return NULL;
Jon Ashburne0fa2282015-05-20 09:00:28 -06004641
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004642 layer_data *dev_data;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004643 /* loader uses this to force layer initialization; device object is wrapped */
4644 if (!strcmp(funcName, "vkGetDeviceProcAddr")) {
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004645 VkBaseLayerObject* wrapped_dev = (VkBaseLayerObject*) dev;
4646 dev_data = get_my_data_ptr(get_dispatch_key(wrapped_dev->baseObject), layer_data_map);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004647 dev_data->device_dispatch_table = new VkLayerDispatchTable;
4648 layer_initialize_dispatch_table(dev_data->device_dispatch_table, wrapped_dev);
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004649 return (PFN_vkVoidFunction) vkGetDeviceProcAddr;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004650 }
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004651 dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map);
Courtney Goeltzenleuchterbe637992015-06-25 18:01:43 -06004652 if (!strcmp(funcName, "vkCreateDevice"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004653 return (PFN_vkVoidFunction) vkCreateDevice;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004654 if (!strcmp(funcName, "vkDestroyDevice"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004655 return (PFN_vkVoidFunction) vkDestroyDevice;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004656 if (!strcmp(funcName, "vkQueueSubmit"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004657 return (PFN_vkVoidFunction) vkQueueSubmit;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004658 if (!strcmp(funcName, "vkDestroyInstance"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004659 return (PFN_vkVoidFunction) vkDestroyInstance;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004660 if (!strcmp(funcName, "vkDestroyDevice"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004661 return (PFN_vkVoidFunction) vkDestroyDevice;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004662 if (!strcmp(funcName, "vkDestroyFence"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004663 return (PFN_vkVoidFunction) vkDestroyFence;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004664 if (!strcmp(funcName, "vkDestroySemaphore"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004665 return (PFN_vkVoidFunction) vkDestroySemaphore;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004666 if (!strcmp(funcName, "vkDestroyEvent"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004667 return (PFN_vkVoidFunction) vkDestroyEvent;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004668 if (!strcmp(funcName, "vkDestroyQueryPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004669 return (PFN_vkVoidFunction) vkDestroyQueryPool;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004670 if (!strcmp(funcName, "vkDestroyBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004671 return (PFN_vkVoidFunction) vkDestroyBuffer;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004672 if (!strcmp(funcName, "vkDestroyBufferView"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004673 return (PFN_vkVoidFunction) vkDestroyBufferView;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004674 if (!strcmp(funcName, "vkDestroyImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004675 return (PFN_vkVoidFunction) vkDestroyImage;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004676 if (!strcmp(funcName, "vkDestroyImageView"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004677 return (PFN_vkVoidFunction) vkDestroyImageView;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004678 if (!strcmp(funcName, "vkDestroyShaderModule"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004679 return (PFN_vkVoidFunction) vkDestroyShaderModule;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004680 if (!strcmp(funcName, "vkDestroyPipeline"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004681 return (PFN_vkVoidFunction) vkDestroyPipeline;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004682 if (!strcmp(funcName, "vkDestroyPipelineLayout"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004683 return (PFN_vkVoidFunction) vkDestroyPipelineLayout;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004684 if (!strcmp(funcName, "vkDestroySampler"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004685 return (PFN_vkVoidFunction) vkDestroySampler;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004686 if (!strcmp(funcName, "vkDestroyDescriptorSetLayout"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004687 return (PFN_vkVoidFunction) vkDestroyDescriptorSetLayout;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004688 if (!strcmp(funcName, "vkDestroyDescriptorPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004689 return (PFN_vkVoidFunction) vkDestroyDescriptorPool;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004690 if (!strcmp(funcName, "vkDestroyFramebuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004691 return (PFN_vkVoidFunction) vkDestroyFramebuffer;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004692 if (!strcmp(funcName, "vkDestroyRenderPass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004693 return (PFN_vkVoidFunction) vkDestroyRenderPass;
Tobin Ehlisb46be812015-10-23 16:00:08 -06004694 if (!strcmp(funcName, "vkCreateBuffer"))
4695 return (PFN_vkVoidFunction) vkCreateBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004696 if (!strcmp(funcName, "vkCreateBufferView"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004697 return (PFN_vkVoidFunction) vkCreateBufferView;
Tobin Ehlisb46be812015-10-23 16:00:08 -06004698 if (!strcmp(funcName, "vkCreateImage"))
4699 return (PFN_vkVoidFunction) vkCreateImage;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004700 if (!strcmp(funcName, "vkCreateImageView"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004701 return (PFN_vkVoidFunction) vkCreateImageView;
Jon Ashburn0d60d272015-07-09 15:02:25 -06004702 if (!strcmp(funcName, "CreatePipelineCache"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004703 return (PFN_vkVoidFunction) vkCreatePipelineCache;
Jon Ashburn0d60d272015-07-09 15:02:25 -06004704 if (!strcmp(funcName, "DestroyPipelineCache"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004705 return (PFN_vkVoidFunction) vkDestroyPipelineCache;
Jon Ashburn0d60d272015-07-09 15:02:25 -06004706 if (!strcmp(funcName, "GetPipelineCacheData"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004707 return (PFN_vkVoidFunction) vkGetPipelineCacheData;
Jon Ashburn0d60d272015-07-09 15:02:25 -06004708 if (!strcmp(funcName, "MergePipelineCaches"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004709 return (PFN_vkVoidFunction) vkMergePipelineCaches;
Jon Ashburn0d60d272015-07-09 15:02:25 -06004710 if (!strcmp(funcName, "vkCreateGraphicsPipelines"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004711 return (PFN_vkVoidFunction) vkCreateGraphicsPipelines;
Mark Lobodzinski2adea752015-11-10 15:25:01 -07004712 if (!strcmp(funcName, "vkCreateComputePipelines"))
4713 return (PFN_vkVoidFunction) vkCreateComputePipelines;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004714 if (!strcmp(funcName, "vkCreateSampler"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004715 return (PFN_vkVoidFunction) vkCreateSampler;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004716 if (!strcmp(funcName, "vkCreateDescriptorSetLayout"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004717 return (PFN_vkVoidFunction) vkCreateDescriptorSetLayout;
Mark Lobodzinski556f7212015-04-17 14:11:39 -05004718 if (!strcmp(funcName, "vkCreatePipelineLayout"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004719 return (PFN_vkVoidFunction) vkCreatePipelineLayout;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004720 if (!strcmp(funcName, "vkCreateDescriptorPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004721 return (PFN_vkVoidFunction) vkCreateDescriptorPool;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004722 if (!strcmp(funcName, "vkResetDescriptorPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004723 return (PFN_vkVoidFunction) vkResetDescriptorPool;
Chia-I Wu1f851912015-10-27 18:04:07 +08004724 if (!strcmp(funcName, "vkAllocateDescriptorSets"))
4725 return (PFN_vkVoidFunction) vkAllocateDescriptorSets;
Tobin Ehlis3c543112015-10-08 13:13:50 -06004726 if (!strcmp(funcName, "vkFreeDescriptorSets"))
4727 return (PFN_vkVoidFunction) vkFreeDescriptorSets;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08004728 if (!strcmp(funcName, "vkUpdateDescriptorSets"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004729 return (PFN_vkVoidFunction) vkUpdateDescriptorSets;
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07004730 if (!strcmp(funcName, "vkCreateCommandPool"))
4731 return (PFN_vkVoidFunction) vkCreateCommandPool;
4732 if (!strcmp(funcName, "vkDestroyCommandPool"))
4733 return (PFN_vkVoidFunction) vkDestroyCommandPool;
Chia-I Wu1f851912015-10-27 18:04:07 +08004734 if (!strcmp(funcName, "vkAllocateCommandBuffers"))
4735 return (PFN_vkVoidFunction) vkAllocateCommandBuffers;
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07004736 if (!strcmp(funcName, "vkFreeCommandBuffers"))
4737 return (PFN_vkVoidFunction) vkFreeCommandBuffers;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004738 if (!strcmp(funcName, "vkBeginCommandBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004739 return (PFN_vkVoidFunction) vkBeginCommandBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004740 if (!strcmp(funcName, "vkEndCommandBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004741 return (PFN_vkVoidFunction) vkEndCommandBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004742 if (!strcmp(funcName, "vkResetCommandBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004743 return (PFN_vkVoidFunction) vkResetCommandBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004744 if (!strcmp(funcName, "vkCmdBindPipeline"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004745 return (PFN_vkVoidFunction) vkCmdBindPipeline;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06004746 if (!strcmp(funcName, "vkCmdSetViewport"))
4747 return (PFN_vkVoidFunction) vkCmdSetViewport;
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06004748 if (!strcmp(funcName, "vkCmdSetScissor"))
4749 return (PFN_vkVoidFunction) vkCmdSetScissor;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06004750 if (!strcmp(funcName, "vkCmdSetLineWidth"))
4751 return (PFN_vkVoidFunction) vkCmdSetLineWidth;
4752 if (!strcmp(funcName, "vkCmdSetDepthBias"))
4753 return (PFN_vkVoidFunction) vkCmdSetDepthBias;
4754 if (!strcmp(funcName, "vkCmdSetBlendConstants"))
4755 return (PFN_vkVoidFunction) vkCmdSetBlendConstants;
4756 if (!strcmp(funcName, "vkCmdSetDepthBounds"))
4757 return (PFN_vkVoidFunction) vkCmdSetDepthBounds;
4758 if (!strcmp(funcName, "vkCmdSetStencilCompareMask"))
4759 return (PFN_vkVoidFunction) vkCmdSetStencilCompareMask;
4760 if (!strcmp(funcName, "vkCmdSetStencilWriteMask"))
4761 return (PFN_vkVoidFunction) vkCmdSetStencilWriteMask;
4762 if (!strcmp(funcName, "vkCmdSetStencilReference"))
4763 return (PFN_vkVoidFunction) vkCmdSetStencilReference;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004764 if (!strcmp(funcName, "vkCmdBindDescriptorSets"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004765 return (PFN_vkVoidFunction) vkCmdBindDescriptorSets;
Courtney Goeltzenleuchter46962942015-04-16 13:38:46 -06004766 if (!strcmp(funcName, "vkCmdBindVertexBuffers"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004767 return (PFN_vkVoidFunction) vkCmdBindVertexBuffers;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004768 if (!strcmp(funcName, "vkCmdBindIndexBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004769 return (PFN_vkVoidFunction) vkCmdBindIndexBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004770 if (!strcmp(funcName, "vkCmdDraw"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004771 return (PFN_vkVoidFunction) vkCmdDraw;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004772 if (!strcmp(funcName, "vkCmdDrawIndexed"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004773 return (PFN_vkVoidFunction) vkCmdDrawIndexed;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004774 if (!strcmp(funcName, "vkCmdDrawIndirect"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004775 return (PFN_vkVoidFunction) vkCmdDrawIndirect;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004776 if (!strcmp(funcName, "vkCmdDrawIndexedIndirect"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004777 return (PFN_vkVoidFunction) vkCmdDrawIndexedIndirect;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004778 if (!strcmp(funcName, "vkCmdDispatch"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004779 return (PFN_vkVoidFunction) vkCmdDispatch;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004780 if (!strcmp(funcName, "vkCmdDispatchIndirect"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004781 return (PFN_vkVoidFunction) vkCmdDispatchIndirect;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004782 if (!strcmp(funcName, "vkCmdCopyBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004783 return (PFN_vkVoidFunction) vkCmdCopyBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004784 if (!strcmp(funcName, "vkCmdCopyImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004785 return (PFN_vkVoidFunction) vkCmdCopyImage;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004786 if (!strcmp(funcName, "vkCmdCopyBufferToImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004787 return (PFN_vkVoidFunction) vkCmdCopyBufferToImage;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004788 if (!strcmp(funcName, "vkCmdCopyImageToBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004789 return (PFN_vkVoidFunction) vkCmdCopyImageToBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004790 if (!strcmp(funcName, "vkCmdUpdateBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004791 return (PFN_vkVoidFunction) vkCmdUpdateBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004792 if (!strcmp(funcName, "vkCmdFillBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004793 return (PFN_vkVoidFunction) vkCmdFillBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004794 if (!strcmp(funcName, "vkCmdClearColorImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004795 return (PFN_vkVoidFunction) vkCmdClearColorImage;
Chris Forbes2951d7d2015-06-22 17:21:59 +12004796 if (!strcmp(funcName, "vkCmdClearDepthStencilImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004797 return (PFN_vkVoidFunction) vkCmdClearDepthStencilImage;
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06004798 if (!strcmp(funcName, "vkCmdClearAttachments"))
4799 return (PFN_vkVoidFunction) vkCmdClearAttachments;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004800 if (!strcmp(funcName, "vkCmdResolveImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004801 return (PFN_vkVoidFunction) vkCmdResolveImage;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004802 if (!strcmp(funcName, "vkCmdSetEvent"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004803 return (PFN_vkVoidFunction) vkCmdSetEvent;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004804 if (!strcmp(funcName, "vkCmdResetEvent"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004805 return (PFN_vkVoidFunction) vkCmdResetEvent;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004806 if (!strcmp(funcName, "vkCmdWaitEvents"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004807 return (PFN_vkVoidFunction) vkCmdWaitEvents;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004808 if (!strcmp(funcName, "vkCmdPipelineBarrier"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004809 return (PFN_vkVoidFunction) vkCmdPipelineBarrier;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004810 if (!strcmp(funcName, "vkCmdBeginQuery"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004811 return (PFN_vkVoidFunction) vkCmdBeginQuery;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004812 if (!strcmp(funcName, "vkCmdEndQuery"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004813 return (PFN_vkVoidFunction) vkCmdEndQuery;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004814 if (!strcmp(funcName, "vkCmdResetQueryPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004815 return (PFN_vkVoidFunction) vkCmdResetQueryPool;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004816 if (!strcmp(funcName, "vkCmdWriteTimestamp"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004817 return (PFN_vkVoidFunction) vkCmdWriteTimestamp;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004818 if (!strcmp(funcName, "vkCreateFramebuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004819 return (PFN_vkVoidFunction) vkCreateFramebuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004820 if (!strcmp(funcName, "vkCreateRenderPass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004821 return (PFN_vkVoidFunction) vkCreateRenderPass;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004822 if (!strcmp(funcName, "vkCmdBeginRenderPass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004823 return (PFN_vkVoidFunction) vkCmdBeginRenderPass;
Chia-I Wuc278df82015-07-07 11:50:03 +08004824 if (!strcmp(funcName, "vkCmdNextSubpass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004825 return (PFN_vkVoidFunction) vkCmdNextSubpass;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004826 if (!strcmp(funcName, "vkCmdEndRenderPass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004827 return (PFN_vkVoidFunction) vkCmdEndRenderPass;
Tobin Ehlis5f728d32015-09-17 14:18:16 -06004828 if (!strcmp(funcName, "vkCmdExecuteCommands"))
4829 return (PFN_vkVoidFunction) vkCmdExecuteCommands;
Michael Lentineee4ad4d2015-10-23 12:41:44 -07004830 if (!strcmp(funcName, "vkMapMemory"))
4831 return (PFN_vkVoidFunction) vkMapMemory;
Jon Ashburn6f8cd632015-06-01 09:37:38 -06004832
Michael Lentine27b0f902015-10-12 11:30:14 -05004833 if (dev_data->device_extensions.wsi_enabled)
4834 {
4835 if (!strcmp(funcName, "vkCreateSwapchainKHR"))
4836 return (PFN_vkVoidFunction) vkCreateSwapchainKHR;
4837 if (!strcmp(funcName, "vkDestroySwapchainKHR"))
4838 return (PFN_vkVoidFunction) vkDestroySwapchainKHR;
4839 if (!strcmp(funcName, "vkGetSwapchainImagesKHR"))
4840 return (PFN_vkVoidFunction) vkGetSwapchainImagesKHR;
4841 if (!strcmp(funcName, "vkQueuePresentKHR"))
4842 return (PFN_vkVoidFunction) vkQueuePresentKHR;
4843 }
4844
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004845 VkLayerDispatchTable* pTable = dev_data->device_dispatch_table;
4846 if (dev_data->device_extensions.debug_marker_enabled)
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004847 {
Jon Ashburn7e07faf2015-06-18 15:02:58 -06004848 if (!strcmp(funcName, "vkCmdDbgMarkerBegin"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004849 return (PFN_vkVoidFunction) vkCmdDbgMarkerBegin;
Jon Ashburn7e07faf2015-06-18 15:02:58 -06004850 if (!strcmp(funcName, "vkCmdDbgMarkerEnd"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004851 return (PFN_vkVoidFunction) vkCmdDbgMarkerEnd;
Jon Ashburn6f8cd632015-06-01 09:37:38 -06004852 }
4853 {
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004854 if (pTable->GetDeviceProcAddr == NULL)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004855 return NULL;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004856 return pTable->GetDeviceProcAddr(dev, funcName);
Jon Ashburn79b78ac2015-05-05 14:22:52 -06004857 }
4858}
4859
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004860VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char* funcName)
Jon Ashburn79b78ac2015-05-05 14:22:52 -06004861{
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004862 PFN_vkVoidFunction fptr;
Jon Ashburn79b78ac2015-05-05 14:22:52 -06004863 if (instance == NULL)
4864 return NULL;
4865
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004866 layer_data* my_data;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004867 /* loader uses this to force layer initialization; instance object is wrapped */
4868 if (!strcmp(funcName, "vkGetInstanceProcAddr")) {
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004869 VkBaseLayerObject* wrapped_inst = (VkBaseLayerObject*) instance;
4870 my_data = get_my_data_ptr(get_dispatch_key(wrapped_inst->baseObject), layer_data_map);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004871 my_data->instance_dispatch_table = new VkLayerInstanceDispatchTable;
4872 layer_init_instance_dispatch_table(my_data->instance_dispatch_table, wrapped_inst);
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004873 return (PFN_vkVoidFunction) vkGetInstanceProcAddr;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004874 }
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004875 my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map);
Courtney Goeltzenleuchter3c9f6ec2015-06-01 14:29:58 -06004876 if (!strcmp(funcName, "vkCreateInstance"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004877 return (PFN_vkVoidFunction) vkCreateInstance;
Jon Ashburne0fa2282015-05-20 09:00:28 -06004878 if (!strcmp(funcName, "vkDestroyInstance"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004879 return (PFN_vkVoidFunction) vkDestroyInstance;
Courtney Goeltzenleuchter74c4ce92015-09-14 17:22:16 -06004880 if (!strcmp(funcName, "vkEnumerateInstanceLayerProperties"))
4881 return (PFN_vkVoidFunction) vkEnumerateInstanceLayerProperties;
4882 if (!strcmp(funcName, "vkEnumerateInstanceExtensionProperties"))
4883 return (PFN_vkVoidFunction) vkEnumerateInstanceExtensionProperties;
4884 if (!strcmp(funcName, "vkEnumerateDeviceLayerProperties"))
4885 return (PFN_vkVoidFunction) vkEnumerateDeviceLayerProperties;
4886 if (!strcmp(funcName, "vkEnumerateDeviceExtensionProperties"))
4887 return (PFN_vkVoidFunction) vkEnumerateDeviceExtensionProperties;
Courtney Goeltzenleuchtercc899fe2015-06-01 14:33:14 -06004888
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06004889 fptr = debug_report_get_instance_proc_addr(my_data->report_data, funcName);
Courtney Goeltzenleuchtercc899fe2015-06-01 14:33:14 -06004890 if (fptr)
4891 return fptr;
4892
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004893 {
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004894 VkLayerInstanceDispatchTable* pTable = my_data->instance_dispatch_table;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004895 if (pTable->GetInstanceProcAddr == NULL)
Jon Ashburn79b78ac2015-05-05 14:22:52 -06004896 return NULL;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004897 return pTable->GetInstanceProcAddr(instance, funcName);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004898 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004899}