Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1 | /* |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2 | * |
Courtney Goeltzenleuchter | 8a17da5 | 2015-10-29 13:50:34 -0600 | [diff] [blame] | 3 | * Copyright (C) 2015 Valve Corporation |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4 | * Copyright (C) 2015 Google, Inc. |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5 | * |
| 6 | * Permission is hereby granted, free of charge, to any person obtaining a |
| 7 | * copy of this software and associated documentation files (the "Software"), |
| 8 | * to deal in the Software without restriction, including without limitation |
| 9 | * the rights to use, copy, modify, merge, publish, distribute, sublicense, |
| 10 | * and/or sell copies of the Software, and to permit persons to whom the |
| 11 | * Software is furnished to do so, subject to the following conditions: |
| 12 | * |
| 13 | * The above copyright notice and this permission notice shall be included |
| 14 | * in all copies or substantial portions of the Software. |
| 15 | * |
| 16 | * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR |
| 17 | * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, |
| 18 | * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL |
| 19 | * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER |
| 20 | * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING |
| 21 | * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER |
| 22 | * DEALINGS IN THE SOFTWARE. |
Courtney Goeltzenleuchter | 96cd795 | 2015-10-30 11:14:30 -0600 | [diff] [blame] | 23 | * |
Tobin Ehlis | d17c28c | 2015-12-03 09:40:56 -0700 | [diff] [blame] | 24 | * Author: Cody Northrop <cnorthrop@google.com> |
Courtney Goeltzenleuchter | 96cd795 | 2015-10-30 11:14:30 -0600 | [diff] [blame] | 25 | * Author: Michael Lentine <mlentine@google.com> |
Tobin Ehlis | d17c28c | 2015-12-03 09:40:56 -0700 | [diff] [blame] | 26 | * Author: Tobin Ehlis <tobine@google.com> |
| 27 | * Author: Chia-I Wu <olv@google.com> |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 28 | * Author: Chris Forbes <chrisf@ijw.co.nz> |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 29 | */ |
| 30 | |
| 31 | #include <stdio.h> |
| 32 | #include <stdlib.h> |
| 33 | #include <string.h> |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 34 | #include <assert.h> |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 35 | #include <unordered_map> |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 36 | #include <unordered_set> |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 37 | #include <map> |
| 38 | #include <string> |
| 39 | #include <iostream> |
| 40 | #include <algorithm> |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 41 | #include <list> |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 42 | #include <spirv.hpp> |
Tobin Ehlis | d17c28c | 2015-12-03 09:40:56 -0700 | [diff] [blame] | 43 | #include <set> |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 44 | |
Tobin Ehlis | 7a51d90 | 2015-07-03 10:34:49 -0600 | [diff] [blame] | 45 | #include "vk_loader_platform.h" |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 46 | #include "vk_dispatch_table_helper.h" |
| 47 | #include "vk_struct_string_helper_cpp.h" |
Tony Barbour | a938abb | 2015-04-22 11:36:22 -0600 | [diff] [blame] | 48 | #if defined(__GNUC__) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 49 | #pragma GCC diagnostic ignored "-Wwrite-strings" |
Tony Barbour | a938abb | 2015-04-22 11:36:22 -0600 | [diff] [blame] | 50 | #endif |
Tony Barbour | a938abb | 2015-04-22 11:36:22 -0600 | [diff] [blame] | 51 | #if defined(__GNUC__) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 52 | #pragma GCC diagnostic warning "-Wwrite-strings" |
Tony Barbour | a938abb | 2015-04-22 11:36:22 -0600 | [diff] [blame] | 53 | #endif |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 54 | #include "vk_struct_size_helper.h" |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 55 | #include "draw_state.h" |
Tobin Ehlis | 56d204a | 2015-07-03 10:15:26 -0600 | [diff] [blame] | 56 | #include "vk_layer_config.h" |
Michael Lentine | 8469dd6 | 2015-11-20 09:48:52 -0800 | [diff] [blame] | 57 | #include "vulkan/vk_debug_marker_layer.h" |
Tobin Ehlis | 56d204a | 2015-07-03 10:15:26 -0600 | [diff] [blame] | 58 | #include "vk_layer_table.h" |
| 59 | #include "vk_layer_debug_marker_table.h" |
| 60 | #include "vk_layer_data.h" |
| 61 | #include "vk_layer_logging.h" |
Courtney Goeltzenleuchter | 73e8bd4 | 2015-07-06 22:31:52 -0600 | [diff] [blame] | 62 | #include "vk_layer_extension_utils.h" |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 63 | #include "vk_layer_utils.h" |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 64 | |
Mark Lobodzinski | 78940a4 | 2015-11-30 16:48:53 -0700 | [diff] [blame] | 65 | // This definition controls whether image layout transitions are enabled/disabled. |
| 66 | // disable until corner cases are fixed |
| 67 | #define DISABLE_IMAGE_LAYOUT_VALIDATION |
| 68 | |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 69 | using std::unordered_map; |
| 70 | using std::unordered_set; |
| 71 | |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 72 | // Track command pools and their command buffers |
| 73 | struct CMD_POOL_INFO { |
| 74 | VkCommandPoolCreateFlags createFlags; |
| 75 | list<VkCommandBuffer> commandBuffers; // list container of cmd buffers allocated from this pool |
| 76 | }; |
| 77 | |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 78 | struct devExts { |
Courtney Goeltzenleuchter | f2bca90 | 2015-11-03 15:41:43 -0700 | [diff] [blame] | 79 | VkBool32 debug_marker_enabled; |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 80 | VkBool32 wsi_enabled; |
| 81 | unordered_map<VkSwapchainKHR, SWAPCHAIN_NODE*> swapchainMap; |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 82 | }; |
| 83 | |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 84 | // fwd decls |
| 85 | struct shader_module; |
| 86 | struct render_pass; |
| 87 | |
Cody Northrop | 73bb657 | 2015-09-28 15:09:32 -0600 | [diff] [blame] | 88 | struct layer_data { |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 89 | debug_report_data* report_data; |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 90 | std::vector<VkDebugReportCallbackEXT> logging_callback; |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 91 | VkLayerDispatchTable* device_dispatch_table; |
| 92 | VkLayerInstanceDispatchTable* instance_dispatch_table; |
| 93 | devExts device_extensions; |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 94 | // Layer specific data |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 95 | unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> sampleMap; |
| 96 | unordered_map<VkImageView, unique_ptr<VkImageViewCreateInfo>> imageViewMap; |
| 97 | unordered_map<VkImage, unique_ptr<VkImageCreateInfo>> imageMap; |
| 98 | unordered_map<VkBufferView, unique_ptr<VkBufferViewCreateInfo>> bufferViewMap; |
| 99 | unordered_map<VkBuffer, unique_ptr<VkBufferCreateInfo>> bufferMap; |
| 100 | unordered_map<VkPipeline, PIPELINE_NODE*> pipelineMap; |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 101 | unordered_map<VkCommandPool, CMD_POOL_INFO> commandPoolMap; |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 102 | unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE*> descriptorPoolMap; |
| 103 | unordered_map<VkDescriptorSet, SET_NODE*> setMap; |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 104 | unordered_map<VkDescriptorSetLayout, LAYOUT_NODE*> descriptorSetLayoutMap; |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 105 | unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; |
| 106 | unordered_map<VkDeviceMemory, VkImage> memImageMap; |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 107 | // Map for layout chains |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 108 | unordered_map<void*, GLOBAL_CB_NODE*> commandBufferMap; |
| 109 | unordered_map<VkFramebuffer, VkFramebufferCreateInfo*> frameBufferMap; |
| 110 | unordered_map<VkImage, IMAGE_NODE*> imageLayoutMap; |
| 111 | unordered_map<VkRenderPass, RENDER_PASS_NODE*> renderPassMap; |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 112 | unordered_map<VkShaderModule, shader_module*> shaderModuleMap; |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 113 | // Current render pass |
| 114 | VkRenderPassBeginInfo renderPassBeginInfo; |
| 115 | uint32_t currentSubpass; |
Cody Northrop | 73bb657 | 2015-09-28 15:09:32 -0600 | [diff] [blame] | 116 | |
| 117 | layer_data() : |
| 118 | report_data(nullptr), |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 119 | device_dispatch_table(nullptr), |
| 120 | instance_dispatch_table(nullptr), |
| 121 | device_extensions() |
Cody Northrop | 73bb657 | 2015-09-28 15:09:32 -0600 | [diff] [blame] | 122 | {}; |
| 123 | }; |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 124 | // Code imported from ShaderChecker |
| 125 | static void |
| 126 | build_type_def_index(std::vector<unsigned> const &words, std::unordered_map<unsigned, unsigned> &type_def_index); |
| 127 | |
| 128 | struct shader_module { |
| 129 | /* the spirv image itself */ |
| 130 | vector<uint32_t> words; |
| 131 | /* a mapping of <id> to the first word of its def. this is useful because walking type |
| 132 | * trees requires jumping all over the instruction stream. |
| 133 | */ |
| 134 | unordered_map<unsigned, unsigned> type_def_index; |
| 135 | |
| 136 | shader_module(VkShaderModuleCreateInfo const *pCreateInfo) : |
| 137 | words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)), |
| 138 | type_def_index() { |
| 139 | |
| 140 | build_type_def_index(words, type_def_index); |
| 141 | } |
| 142 | }; |
| 143 | |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 144 | // TODO : Do we need to guard access to layer_data_map w/ lock? |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 145 | static unordered_map<void*, layer_data*> layer_data_map; |
Courtney Goeltzenleuchter | c280adc | 2015-06-13 21:23:09 -0600 | [diff] [blame] | 146 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 147 | static LOADER_PLATFORM_THREAD_ONCE_DECLARATION(g_initOnce); |
| 148 | // TODO : This can be much smarter, using separate locks for separate global data |
| 149 | static int globalLockInitialized = 0; |
| 150 | static loader_platform_thread_mutex globalLock; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 151 | #define MAX_TID 513 |
| 152 | static loader_platform_thread_id g_tidMapping[MAX_TID] = {0}; |
| 153 | static uint32_t g_maxTID = 0; |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 154 | |
| 155 | template layer_data *get_my_data_ptr<layer_data>( |
| 156 | void *data_key, |
| 157 | std::unordered_map<void *, layer_data *> &data_map); |
| 158 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 159 | // Map actual TID to an index value and return that index |
| 160 | // This keeps TIDs in range from 0-MAX_TID and simplifies compares between runs |
| 161 | static uint32_t getTIDIndex() { |
| 162 | loader_platform_thread_id tid = loader_platform_get_thread_id(); |
| 163 | for (uint32_t i = 0; i < g_maxTID; i++) { |
| 164 | if (tid == g_tidMapping[i]) |
| 165 | return i; |
| 166 | } |
| 167 | // Don't yet have mapping, set it and return newly set index |
| 168 | uint32_t retVal = (uint32_t) g_maxTID; |
| 169 | g_tidMapping[g_maxTID++] = tid; |
| 170 | assert(g_maxTID < MAX_TID); |
| 171 | return retVal; |
| 172 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 173 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 174 | // Return a string representation of CMD_TYPE enum |
| 175 | static string cmdTypeToString(CMD_TYPE cmd) |
| 176 | { |
| 177 | switch (cmd) |
| 178 | { |
| 179 | case CMD_BINDPIPELINE: |
| 180 | return "CMD_BINDPIPELINE"; |
| 181 | case CMD_BINDPIPELINEDELTA: |
| 182 | return "CMD_BINDPIPELINEDELTA"; |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 183 | case CMD_SETVIEWPORTSTATE: |
| 184 | return "CMD_SETVIEWPORTSTATE"; |
| 185 | case CMD_SETLINEWIDTHSTATE: |
| 186 | return "CMD_SETLINEWIDTHSTATE"; |
| 187 | case CMD_SETDEPTHBIASSTATE: |
| 188 | return "CMD_SETDEPTHBIASSTATE"; |
| 189 | case CMD_SETBLENDSTATE: |
| 190 | return "CMD_SETBLENDSTATE"; |
| 191 | case CMD_SETDEPTHBOUNDSSTATE: |
| 192 | return "CMD_SETDEPTHBOUNDSSTATE"; |
| 193 | case CMD_SETSTENCILREADMASKSTATE: |
| 194 | return "CMD_SETSTENCILREADMASKSTATE"; |
| 195 | case CMD_SETSTENCILWRITEMASKSTATE: |
| 196 | return "CMD_SETSTENCILWRITEMASKSTATE"; |
| 197 | case CMD_SETSTENCILREFERENCESTATE: |
| 198 | return "CMD_SETSTENCILREFERENCESTATE"; |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 199 | case CMD_BINDDESCRIPTORSETS: |
| 200 | return "CMD_BINDDESCRIPTORSETS"; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 201 | case CMD_BINDINDEXBUFFER: |
| 202 | return "CMD_BINDINDEXBUFFER"; |
| 203 | case CMD_BINDVERTEXBUFFER: |
| 204 | return "CMD_BINDVERTEXBUFFER"; |
| 205 | case CMD_DRAW: |
| 206 | return "CMD_DRAW"; |
| 207 | case CMD_DRAWINDEXED: |
| 208 | return "CMD_DRAWINDEXED"; |
| 209 | case CMD_DRAWINDIRECT: |
| 210 | return "CMD_DRAWINDIRECT"; |
| 211 | case CMD_DRAWINDEXEDINDIRECT: |
| 212 | return "CMD_DRAWINDEXEDINDIRECT"; |
| 213 | case CMD_DISPATCH: |
| 214 | return "CMD_DISPATCH"; |
| 215 | case CMD_DISPATCHINDIRECT: |
| 216 | return "CMD_DISPATCHINDIRECT"; |
| 217 | case CMD_COPYBUFFER: |
| 218 | return "CMD_COPYBUFFER"; |
| 219 | case CMD_COPYIMAGE: |
| 220 | return "CMD_COPYIMAGE"; |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 221 | case CMD_BLITIMAGE: |
| 222 | return "CMD_BLITIMAGE"; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 223 | case CMD_COPYBUFFERTOIMAGE: |
| 224 | return "CMD_COPYBUFFERTOIMAGE"; |
| 225 | case CMD_COPYIMAGETOBUFFER: |
| 226 | return "CMD_COPYIMAGETOBUFFER"; |
| 227 | case CMD_CLONEIMAGEDATA: |
| 228 | return "CMD_CLONEIMAGEDATA"; |
| 229 | case CMD_UPDATEBUFFER: |
| 230 | return "CMD_UPDATEBUFFER"; |
| 231 | case CMD_FILLBUFFER: |
| 232 | return "CMD_FILLBUFFER"; |
| 233 | case CMD_CLEARCOLORIMAGE: |
| 234 | return "CMD_CLEARCOLORIMAGE"; |
Courtney Goeltzenleuchter | 9feb073 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 235 | case CMD_CLEARATTACHMENTS: |
Tobin Ehlis | 8cd650e | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 236 | return "CMD_CLEARCOLORATTACHMENT"; |
| 237 | case CMD_CLEARDEPTHSTENCILIMAGE: |
| 238 | return "CMD_CLEARDEPTHSTENCILIMAGE"; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 239 | case CMD_RESOLVEIMAGE: |
| 240 | return "CMD_RESOLVEIMAGE"; |
| 241 | case CMD_SETEVENT: |
| 242 | return "CMD_SETEVENT"; |
| 243 | case CMD_RESETEVENT: |
| 244 | return "CMD_RESETEVENT"; |
| 245 | case CMD_WAITEVENTS: |
| 246 | return "CMD_WAITEVENTS"; |
| 247 | case CMD_PIPELINEBARRIER: |
| 248 | return "CMD_PIPELINEBARRIER"; |
| 249 | case CMD_BEGINQUERY: |
| 250 | return "CMD_BEGINQUERY"; |
| 251 | case CMD_ENDQUERY: |
| 252 | return "CMD_ENDQUERY"; |
| 253 | case CMD_RESETQUERYPOOL: |
| 254 | return "CMD_RESETQUERYPOOL"; |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 255 | case CMD_COPYQUERYPOOLRESULTS: |
| 256 | return "CMD_COPYQUERYPOOLRESULTS"; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 257 | case CMD_WRITETIMESTAMP: |
| 258 | return "CMD_WRITETIMESTAMP"; |
| 259 | case CMD_INITATOMICCOUNTERS: |
| 260 | return "CMD_INITATOMICCOUNTERS"; |
| 261 | case CMD_LOADATOMICCOUNTERS: |
| 262 | return "CMD_LOADATOMICCOUNTERS"; |
| 263 | case CMD_SAVEATOMICCOUNTERS: |
| 264 | return "CMD_SAVEATOMICCOUNTERS"; |
| 265 | case CMD_BEGINRENDERPASS: |
| 266 | return "CMD_BEGINRENDERPASS"; |
| 267 | case CMD_ENDRENDERPASS: |
| 268 | return "CMD_ENDRENDERPASS"; |
| 269 | case CMD_DBGMARKERBEGIN: |
| 270 | return "CMD_DBGMARKERBEGIN"; |
| 271 | case CMD_DBGMARKEREND: |
| 272 | return "CMD_DBGMARKEREND"; |
| 273 | default: |
| 274 | return "UNKNOWN"; |
| 275 | } |
| 276 | } |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 277 | |
| 278 | // SPIRV utility functions |
| 279 | static void |
| 280 | build_type_def_index(std::vector<unsigned> const &words, std::unordered_map<unsigned, unsigned> &type_def_index) |
| 281 | { |
| 282 | unsigned int const *code = (unsigned int const *)&words[0]; |
| 283 | size_t size = words.size(); |
| 284 | |
| 285 | unsigned word = 5; |
| 286 | while (word < size) { |
| 287 | unsigned opcode = code[word] & 0x0ffffu; |
| 288 | unsigned oplen = (code[word] & 0xffff0000u) >> 16; |
| 289 | |
| 290 | switch (opcode) { |
| 291 | case spv::OpTypeVoid: |
| 292 | case spv::OpTypeBool: |
| 293 | case spv::OpTypeInt: |
| 294 | case spv::OpTypeFloat: |
| 295 | case spv::OpTypeVector: |
| 296 | case spv::OpTypeMatrix: |
| 297 | case spv::OpTypeImage: |
| 298 | case spv::OpTypeSampler: |
| 299 | case spv::OpTypeSampledImage: |
| 300 | case spv::OpTypeArray: |
| 301 | case spv::OpTypeRuntimeArray: |
| 302 | case spv::OpTypeStruct: |
| 303 | case spv::OpTypeOpaque: |
| 304 | case spv::OpTypePointer: |
| 305 | case spv::OpTypeFunction: |
| 306 | case spv::OpTypeEvent: |
| 307 | case spv::OpTypeDeviceEvent: |
| 308 | case spv::OpTypeReserveId: |
| 309 | case spv::OpTypeQueue: |
| 310 | case spv::OpTypePipe: |
| 311 | type_def_index[code[word+1]] = word; |
| 312 | break; |
| 313 | |
| 314 | default: |
| 315 | /* We only care about type definitions */ |
| 316 | break; |
| 317 | } |
| 318 | |
| 319 | word += oplen; |
| 320 | } |
| 321 | } |
| 322 | |
| 323 | bool |
| 324 | shader_is_spirv(VkShaderModuleCreateInfo const *pCreateInfo) |
| 325 | { |
| 326 | uint32_t *words = (uint32_t *)pCreateInfo->pCode; |
| 327 | size_t sizeInWords = pCreateInfo->codeSize / sizeof(uint32_t); |
| 328 | |
| 329 | /* Just validate that the header makes sense. */ |
| 330 | return sizeInWords >= 5 && words[0] == spv::MagicNumber && words[1] == spv::Version; |
| 331 | } |
| 332 | |
| 333 | static char const * |
| 334 | storage_class_name(unsigned sc) |
| 335 | { |
| 336 | switch (sc) { |
| 337 | case spv::StorageClassInput: return "input"; |
| 338 | case spv::StorageClassOutput: return "output"; |
| 339 | case spv::StorageClassUniformConstant: return "const uniform"; |
| 340 | case spv::StorageClassUniform: return "uniform"; |
| 341 | case spv::StorageClassWorkgroup: return "workgroup local"; |
| 342 | case spv::StorageClassCrossWorkgroup: return "workgroup global"; |
| 343 | case spv::StorageClassPrivate: return "private global"; |
| 344 | case spv::StorageClassFunction: return "function"; |
| 345 | case spv::StorageClassGeneric: return "generic"; |
| 346 | case spv::StorageClassAtomicCounter: return "atomic counter"; |
| 347 | case spv::StorageClassImage: return "image"; |
| 348 | default: return "unknown"; |
| 349 | } |
| 350 | } |
| 351 | |
| 352 | /* returns ptr to null terminator */ |
| 353 | static char * |
| 354 | describe_type(char *dst, shader_module const *src, unsigned type) |
| 355 | { |
| 356 | auto type_def_it = src->type_def_index.find(type); |
| 357 | |
| 358 | if (type_def_it == src->type_def_index.end()) { |
| 359 | return dst + sprintf(dst, "undef"); |
| 360 | } |
| 361 | |
| 362 | unsigned int const *code = (unsigned int const *)&src->words[type_def_it->second]; |
| 363 | unsigned opcode = code[0] & 0x0ffffu; |
| 364 | switch (opcode) { |
| 365 | case spv::OpTypeBool: |
| 366 | return dst + sprintf(dst, "bool"); |
| 367 | case spv::OpTypeInt: |
| 368 | return dst + sprintf(dst, "%cint%d", code[3] ? 's' : 'u', code[2]); |
| 369 | case spv::OpTypeFloat: |
| 370 | return dst + sprintf(dst, "float%d", code[2]); |
| 371 | case spv::OpTypeVector: |
| 372 | dst += sprintf(dst, "vec%d of ", code[3]); |
| 373 | return describe_type(dst, src, code[2]); |
| 374 | case spv::OpTypeMatrix: |
| 375 | dst += sprintf(dst, "mat%d of ", code[3]); |
| 376 | return describe_type(dst, src, code[2]); |
| 377 | case spv::OpTypeArray: |
| 378 | dst += sprintf(dst, "arr[%d] of ", code[3]); |
| 379 | return describe_type(dst, src, code[2]); |
| 380 | case spv::OpTypePointer: |
| 381 | dst += sprintf(dst, "ptr to %s ", storage_class_name(code[2])); |
| 382 | return describe_type(dst, src, code[3]); |
| 383 | case spv::OpTypeStruct: |
| 384 | { |
| 385 | unsigned oplen = code[0] >> 16; |
| 386 | dst += sprintf(dst, "struct of ("); |
| 387 | for (unsigned i = 2; i < oplen; i++) { |
| 388 | dst = describe_type(dst, src, code[i]); |
| 389 | dst += sprintf(dst, i == oplen-1 ? ")" : ", "); |
| 390 | } |
| 391 | return dst; |
| 392 | } |
| 393 | case spv::OpTypeSampler: |
| 394 | return dst + sprintf(dst, "sampler"); |
| 395 | default: |
| 396 | return dst + sprintf(dst, "oddtype"); |
| 397 | } |
| 398 | } |
| 399 | |
| 400 | static bool |
| 401 | types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool b_arrayed) |
| 402 | { |
| 403 | auto a_type_def_it = a->type_def_index.find(a_type); |
| 404 | auto b_type_def_it = b->type_def_index.find(b_type); |
| 405 | |
| 406 | if (a_type_def_it == a->type_def_index.end()) { |
| 407 | return false; |
| 408 | } |
| 409 | |
| 410 | if (b_type_def_it == b->type_def_index.end()) { |
| 411 | return false; |
| 412 | } |
| 413 | |
| 414 | /* walk two type trees together, and complain about differences */ |
| 415 | unsigned int const *a_code = (unsigned int const *)&a->words[a_type_def_it->second]; |
| 416 | unsigned int const *b_code = (unsigned int const *)&b->words[b_type_def_it->second]; |
| 417 | |
| 418 | unsigned a_opcode = a_code[0] & 0x0ffffu; |
| 419 | unsigned b_opcode = b_code[0] & 0x0ffffu; |
| 420 | |
| 421 | if (b_arrayed && b_opcode == spv::OpTypeArray) { |
| 422 | /* we probably just found the extra level of arrayness in b_type: compare the type inside it to a_type */ |
| 423 | return types_match(a, b, a_type, b_code[2], false); |
| 424 | } |
| 425 | |
| 426 | if (a_opcode != b_opcode) { |
| 427 | return false; |
| 428 | } |
| 429 | |
| 430 | switch (a_opcode) { |
| 431 | /* if b_arrayed and we hit a leaf type, then we can't match -- there's nowhere for the extra OpTypeArray to be! */ |
| 432 | case spv::OpTypeBool: |
| 433 | return true && !b_arrayed; |
| 434 | case spv::OpTypeInt: |
| 435 | /* match on width, signedness */ |
| 436 | return a_code[2] == b_code[2] && a_code[3] == b_code[3] && !b_arrayed; |
| 437 | case spv::OpTypeFloat: |
| 438 | /* match on width */ |
| 439 | return a_code[2] == b_code[2] && !b_arrayed; |
| 440 | case spv::OpTypeVector: |
| 441 | case spv::OpTypeMatrix: |
| 442 | case spv::OpTypeArray: |
| 443 | /* match on element type, count. these all have the same layout. we don't get here if |
| 444 | * b_arrayed -- that is handled above. */ |
| 445 | return !b_arrayed && types_match(a, b, a_code[2], b_code[2], b_arrayed) && a_code[3] == b_code[3]; |
| 446 | case spv::OpTypeStruct: |
| 447 | /* match on all element types */ |
| 448 | { |
| 449 | if (b_arrayed) { |
| 450 | /* for the purposes of matching different levels of arrayness, structs are leaves. */ |
| 451 | return false; |
| 452 | } |
| 453 | |
| 454 | unsigned a_len = a_code[0] >> 16; |
| 455 | unsigned b_len = b_code[0] >> 16; |
| 456 | |
| 457 | if (a_len != b_len) { |
| 458 | return false; /* structs cannot match if member counts differ */ |
| 459 | } |
| 460 | |
| 461 | for (unsigned i = 2; i < a_len; i++) { |
| 462 | if (!types_match(a, b, a_code[i], b_code[i], b_arrayed)) { |
| 463 | return false; |
| 464 | } |
| 465 | } |
| 466 | |
| 467 | return true; |
| 468 | } |
| 469 | case spv::OpTypePointer: |
| 470 | /* match on pointee type. storage class is expected to differ */ |
| 471 | return types_match(a, b, a_code[3], b_code[3], b_arrayed); |
| 472 | |
| 473 | default: |
| 474 | /* remaining types are CLisms, or may not appear in the interfaces we |
| 475 | * are interested in. Just claim no match. |
| 476 | */ |
| 477 | return false; |
| 478 | |
| 479 | } |
| 480 | } |
| 481 | |
| 482 | static int |
| 483 | value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def) |
| 484 | { |
| 485 | auto it = map.find(id); |
| 486 | if (it == map.end()) |
| 487 | return def; |
| 488 | else |
| 489 | return it->second; |
| 490 | } |
| 491 | |
| 492 | |
| 493 | static unsigned |
| 494 | get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level) |
| 495 | { |
| 496 | auto type_def_it = src->type_def_index.find(type); |
| 497 | |
| 498 | if (type_def_it == src->type_def_index.end()) { |
| 499 | return 1; /* This is actually broken SPIR-V... */ |
| 500 | } |
| 501 | |
| 502 | unsigned int const *code = (unsigned int const *)&src->words[type_def_it->second]; |
| 503 | unsigned opcode = code[0] & 0x0ffffu; |
| 504 | |
| 505 | switch (opcode) { |
| 506 | case spv::OpTypePointer: |
| 507 | /* see through the ptr -- this is only ever at the toplevel for graphics shaders; |
| 508 | * we're never actually passing pointers around. */ |
| 509 | return get_locations_consumed_by_type(src, code[3], strip_array_level); |
| 510 | case spv::OpTypeArray: |
| 511 | if (strip_array_level) { |
| 512 | return get_locations_consumed_by_type(src, code[2], false); |
| 513 | } |
| 514 | else { |
| 515 | return code[3] * get_locations_consumed_by_type(src, code[2], false); |
| 516 | } |
| 517 | case spv::OpTypeMatrix: |
| 518 | /* num locations is the dimension * element size */ |
| 519 | return code[3] * get_locations_consumed_by_type(src, code[2], false); |
| 520 | default: |
| 521 | /* everything else is just 1. */ |
| 522 | return 1; |
| 523 | |
| 524 | /* TODO: extend to handle 64bit scalar types, whose vectors may need |
| 525 | * multiple locations. */ |
| 526 | } |
| 527 | } |
| 528 | |
| 529 | |
| 530 | struct interface_var { |
| 531 | uint32_t id; |
| 532 | uint32_t type_id; |
| 533 | uint32_t offset; |
| 534 | /* TODO: collect the name, too? Isn't required to be present. */ |
| 535 | }; |
| 536 | |
| 537 | static void |
| 538 | collect_interface_by_location(layer_data *my_data, VkDevice dev, |
| 539 | shader_module const *src, spv::StorageClass sinterface, |
| 540 | std::map<uint32_t, interface_var> &out, |
| 541 | std::map<uint32_t, interface_var> &builtins_out, |
| 542 | bool is_array_of_verts) |
| 543 | { |
| 544 | unsigned int const *code = (unsigned int const *)&src->words[0]; |
| 545 | size_t size = src->words.size(); |
| 546 | |
| 547 | std::unordered_map<unsigned, unsigned> var_locations; |
| 548 | std::unordered_map<unsigned, unsigned> var_builtins; |
| 549 | |
| 550 | unsigned word = 5; |
| 551 | while (word < size) { |
| 552 | |
| 553 | unsigned opcode = code[word] & 0x0ffffu; |
| 554 | unsigned oplen = (code[word] & 0xffff0000u) >> 16; |
| 555 | |
| 556 | /* We consider two interface models: SSO rendezvous-by-location, and |
| 557 | * builtins. Complain about anything that fits neither model. |
| 558 | */ |
| 559 | if (opcode == spv::OpDecorate) { |
| 560 | if (code[word+2] == spv::DecorationLocation) { |
| 561 | var_locations[code[word+1]] = code[word+3]; |
| 562 | } |
| 563 | |
| 564 | if (code[word+2] == spv::DecorationBuiltIn) { |
| 565 | var_builtins[code[word+1]] = code[word+3]; |
| 566 | } |
| 567 | } |
| 568 | |
| 569 | /* TODO: handle grouped decorations */ |
| 570 | /* TODO: handle index=1 dual source outputs from FS -- two vars will |
| 571 | * have the same location, and we DONT want to clobber. */ |
| 572 | |
| 573 | if (opcode == spv::OpVariable && code[word+3] == sinterface) { |
| 574 | unsigned id = code[word+2]; |
| 575 | unsigned type = code[word+1]; |
| 576 | |
| 577 | int location = value_or_default(var_locations, code[word+2], -1); |
| 578 | int builtin = value_or_default(var_builtins, code[word+2], -1); |
| 579 | |
| 580 | if (location == -1 && builtin == -1) { |
| 581 | /* No location defined, and not bound to an API builtin. |
| 582 | * The spec says nothing about how this case works (or doesn't) |
| 583 | * for interface matching. |
| 584 | */ |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 585 | log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 586 | "var %d (type %d) in %s interface has no Location or Builtin decoration", |
| 587 | code[word+2], code[word+1], storage_class_name(sinterface)); |
| 588 | } |
| 589 | else if (location != -1) { |
| 590 | /* A user-defined interface variable, with a location. Where a variable |
| 591 | * occupied multiple locations, emit one result for each. */ |
| 592 | unsigned num_locations = get_locations_consumed_by_type(src, type, |
| 593 | is_array_of_verts); |
| 594 | for (int offset = 0; offset < num_locations; offset++) { |
| 595 | interface_var v; |
| 596 | v.id = id; |
| 597 | v.type_id = type; |
| 598 | v.offset = offset; |
| 599 | out[location + offset] = v; |
| 600 | } |
| 601 | } |
| 602 | else { |
| 603 | /* A builtin interface variable */ |
| 604 | /* Note that since builtin interface variables do not consume numbered |
| 605 | * locations, there is no larger-than-vec4 consideration as above |
| 606 | */ |
| 607 | interface_var v; |
| 608 | v.id = id; |
| 609 | v.type_id = type; |
| 610 | v.offset = 0; |
| 611 | builtins_out[builtin] = v; |
| 612 | } |
| 613 | } |
| 614 | |
| 615 | word += oplen; |
| 616 | } |
| 617 | } |
| 618 | |
| 619 | static void |
| 620 | collect_interface_by_descriptor_slot(layer_data *my_data, VkDevice dev, |
| 621 | shader_module const *src, spv::StorageClass sinterface, |
| 622 | std::map<std::pair<unsigned, unsigned>, interface_var> &out) |
| 623 | { |
| 624 | unsigned int const *code = (unsigned int const *)&src->words[0]; |
| 625 | size_t size = src->words.size(); |
| 626 | |
| 627 | std::unordered_map<unsigned, unsigned> var_sets; |
| 628 | std::unordered_map<unsigned, unsigned> var_bindings; |
| 629 | |
| 630 | unsigned word = 5; |
| 631 | while (word < size) { |
| 632 | |
| 633 | unsigned opcode = code[word] & 0x0ffffu; |
| 634 | unsigned oplen = (code[word] & 0xffff0000u) >> 16; |
| 635 | |
| 636 | /* All variables in the Uniform or UniformConstant storage classes are required to be decorated with both |
| 637 | * DecorationDescriptorSet and DecorationBinding. |
| 638 | */ |
| 639 | if (opcode == spv::OpDecorate) { |
| 640 | if (code[word+2] == spv::DecorationDescriptorSet) { |
| 641 | var_sets[code[word+1]] = code[word+3]; |
| 642 | } |
| 643 | |
| 644 | if (code[word+2] == spv::DecorationBinding) { |
| 645 | var_bindings[code[word+1]] = code[word+3]; |
| 646 | } |
| 647 | } |
| 648 | |
| 649 | if (opcode == spv::OpVariable && (code[word+3] == spv::StorageClassUniform || |
| 650 | code[word+3] == spv::StorageClassUniformConstant)) { |
| 651 | unsigned set = value_or_default(var_sets, code[word+2], 0); |
| 652 | unsigned binding = value_or_default(var_bindings, code[word+2], 0); |
| 653 | |
| 654 | auto existing_it = out.find(std::make_pair(set, binding)); |
| 655 | if (existing_it != out.end()) { |
| 656 | /* conflict within spv image */ |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 657 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 658 | SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", |
| 659 | "var %d (type %d) in %s interface in descriptor slot (%u,%u) conflicts with existing definition", |
| 660 | code[word+2], code[word+1], storage_class_name(sinterface), |
| 661 | existing_it->first.first, existing_it->first.second); |
| 662 | } |
| 663 | |
| 664 | interface_var v; |
| 665 | v.id = code[word+2]; |
| 666 | v.type_id = code[word+1]; |
| 667 | out[std::make_pair(set, binding)] = v; |
| 668 | } |
| 669 | |
| 670 | word += oplen; |
| 671 | } |
| 672 | } |
| 673 | |
| 674 | static bool |
| 675 | validate_interface_between_stages(layer_data *my_data, VkDevice dev, |
| 676 | shader_module const *producer, char const *producer_name, |
| 677 | shader_module const *consumer, char const *consumer_name, |
| 678 | bool consumer_arrayed_input) |
| 679 | { |
| 680 | std::map<uint32_t, interface_var> outputs; |
| 681 | std::map<uint32_t, interface_var> inputs; |
| 682 | |
| 683 | std::map<uint32_t, interface_var> builtin_outputs; |
| 684 | std::map<uint32_t, interface_var> builtin_inputs; |
| 685 | |
| 686 | bool pass = true; |
| 687 | |
| 688 | collect_interface_by_location(my_data, dev, producer, spv::StorageClassOutput, outputs, builtin_outputs, false); |
| 689 | collect_interface_by_location(my_data, dev, consumer, spv::StorageClassInput, inputs, builtin_inputs, |
| 690 | consumer_arrayed_input); |
| 691 | |
| 692 | auto a_it = outputs.begin(); |
| 693 | auto b_it = inputs.begin(); |
| 694 | |
| 695 | /* maps sorted by key (location); walk them together to find mismatches */ |
| 696 | while ((outputs.size() > 0 && a_it != outputs.end()) || ( inputs.size() && b_it != inputs.end())) { |
| 697 | bool a_at_end = outputs.size() == 0 || a_it == outputs.end(); |
| 698 | bool b_at_end = inputs.size() == 0 || b_it == inputs.end(); |
| 699 | auto a_first = a_at_end ? 0 : a_it->first; |
| 700 | auto b_first = b_at_end ? 0 : b_it->first; |
| 701 | |
| 702 | if (b_at_end || ((!a_at_end) && (a_first < b_first))) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 703 | if (log_msg(my_data->report_data, VK_DEBUG_REPORT_PERF_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 704 | "%s writes to output location %d which is not consumed by %s", producer_name, a_first, consumer_name)) { |
| 705 | pass = false; |
| 706 | } |
| 707 | a_it++; |
| 708 | } |
| 709 | else if (a_at_end || a_first > b_first) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 710 | if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 711 | "%s consumes input location %d which is not written by %s", consumer_name, b_first, producer_name)) { |
| 712 | pass = false; |
| 713 | } |
| 714 | b_it++; |
| 715 | } |
| 716 | else { |
| 717 | if (types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, consumer_arrayed_input)) { |
| 718 | /* OK! */ |
| 719 | } |
| 720 | else { |
| 721 | char producer_type[1024]; |
| 722 | char consumer_type[1024]; |
| 723 | describe_type(producer_type, producer, a_it->second.type_id); |
| 724 | describe_type(consumer_type, consumer, b_it->second.type_id); |
| 725 | |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 726 | if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 727 | "Type mismatch on location %d: '%s' vs '%s'", a_it->first, producer_type, consumer_type)) { |
| 728 | pass = false; |
| 729 | } |
| 730 | } |
| 731 | a_it++; |
| 732 | b_it++; |
| 733 | } |
| 734 | } |
| 735 | |
| 736 | return pass; |
| 737 | } |
| 738 | |
| 739 | enum FORMAT_TYPE { |
| 740 | FORMAT_TYPE_UNDEFINED, |
| 741 | FORMAT_TYPE_FLOAT, /* UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader */ |
| 742 | FORMAT_TYPE_SINT, |
| 743 | FORMAT_TYPE_UINT, |
| 744 | }; |
| 745 | |
| 746 | static unsigned |
| 747 | get_format_type(VkFormat fmt) { |
| 748 | switch (fmt) { |
| 749 | case VK_FORMAT_UNDEFINED: |
| 750 | return FORMAT_TYPE_UNDEFINED; |
| 751 | case VK_FORMAT_R8_SINT: |
| 752 | case VK_FORMAT_R8G8_SINT: |
| 753 | case VK_FORMAT_R8G8B8_SINT: |
| 754 | case VK_FORMAT_R8G8B8A8_SINT: |
| 755 | case VK_FORMAT_R16_SINT: |
| 756 | case VK_FORMAT_R16G16_SINT: |
| 757 | case VK_FORMAT_R16G16B16_SINT: |
| 758 | case VK_FORMAT_R16G16B16A16_SINT: |
| 759 | case VK_FORMAT_R32_SINT: |
| 760 | case VK_FORMAT_R32G32_SINT: |
| 761 | case VK_FORMAT_R32G32B32_SINT: |
| 762 | case VK_FORMAT_R32G32B32A32_SINT: |
| 763 | case VK_FORMAT_B8G8R8_SINT: |
| 764 | case VK_FORMAT_B8G8R8A8_SINT: |
| 765 | case VK_FORMAT_A2B10G10R10_SINT_PACK32: |
| 766 | case VK_FORMAT_A2R10G10B10_SINT_PACK32: |
| 767 | return FORMAT_TYPE_SINT; |
| 768 | case VK_FORMAT_R8_UINT: |
| 769 | case VK_FORMAT_R8G8_UINT: |
| 770 | case VK_FORMAT_R8G8B8_UINT: |
| 771 | case VK_FORMAT_R8G8B8A8_UINT: |
| 772 | case VK_FORMAT_R16_UINT: |
| 773 | case VK_FORMAT_R16G16_UINT: |
| 774 | case VK_FORMAT_R16G16B16_UINT: |
| 775 | case VK_FORMAT_R16G16B16A16_UINT: |
| 776 | case VK_FORMAT_R32_UINT: |
| 777 | case VK_FORMAT_R32G32_UINT: |
| 778 | case VK_FORMAT_R32G32B32_UINT: |
| 779 | case VK_FORMAT_R32G32B32A32_UINT: |
| 780 | case VK_FORMAT_B8G8R8_UINT: |
| 781 | case VK_FORMAT_B8G8R8A8_UINT: |
| 782 | case VK_FORMAT_A2B10G10R10_UINT_PACK32: |
| 783 | case VK_FORMAT_A2R10G10B10_UINT_PACK32: |
| 784 | return FORMAT_TYPE_UINT; |
| 785 | default: |
| 786 | return FORMAT_TYPE_FLOAT; |
| 787 | } |
| 788 | } |
| 789 | |
| 790 | /* characterizes a SPIR-V type appearing in an interface to a FF stage, |
| 791 | * for comparison to a VkFormat's characterization above. */ |
| 792 | static unsigned |
| 793 | get_fundamental_type(shader_module const *src, unsigned type) |
| 794 | { |
| 795 | auto type_def_it = src->type_def_index.find(type); |
| 796 | |
| 797 | if (type_def_it == src->type_def_index.end()) { |
| 798 | return FORMAT_TYPE_UNDEFINED; |
| 799 | } |
| 800 | |
| 801 | unsigned int const *code = (unsigned int const *)&src->words[type_def_it->second]; |
| 802 | unsigned opcode = code[0] & 0x0ffffu; |
| 803 | switch (opcode) { |
| 804 | case spv::OpTypeInt: |
| 805 | return code[3] ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT; |
| 806 | case spv::OpTypeFloat: |
| 807 | return FORMAT_TYPE_FLOAT; |
| 808 | case spv::OpTypeVector: |
| 809 | return get_fundamental_type(src, code[2]); |
| 810 | case spv::OpTypeMatrix: |
| 811 | return get_fundamental_type(src, code[2]); |
| 812 | case spv::OpTypeArray: |
| 813 | return get_fundamental_type(src, code[2]); |
| 814 | case spv::OpTypePointer: |
| 815 | return get_fundamental_type(src, code[3]); |
| 816 | default: |
| 817 | return FORMAT_TYPE_UNDEFINED; |
| 818 | } |
| 819 | } |
| 820 | |
| 821 | static bool |
| 822 | validate_vi_consistency(layer_data *my_data, VkDevice dev, VkPipelineVertexInputStateCreateInfo const *vi) |
| 823 | { |
| 824 | /* walk the binding descriptions, which describe the step rate and stride of each vertex buffer. |
| 825 | * each binding should be specified only once. |
| 826 | */ |
| 827 | std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings; |
| 828 | bool pass = true; |
| 829 | |
| 830 | for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) { |
| 831 | auto desc = &vi->pVertexBindingDescriptions[i]; |
| 832 | auto & binding = bindings[desc->binding]; |
| 833 | if (binding) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 834 | if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_INCONSISTENT_VI, "SC", |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 835 | "Duplicate vertex input binding descriptions for binding %d", desc->binding)) { |
| 836 | pass = false; |
| 837 | } |
| 838 | } |
| 839 | else { |
| 840 | binding = desc; |
| 841 | } |
| 842 | } |
| 843 | |
| 844 | return pass; |
| 845 | } |
| 846 | |
| 847 | static bool |
| 848 | validate_vi_against_vs_inputs(layer_data *my_data, VkDevice dev, VkPipelineVertexInputStateCreateInfo const *vi, shader_module const *vs) |
| 849 | { |
| 850 | std::map<uint32_t, interface_var> inputs; |
| 851 | /* we collect builtin inputs, but they will never appear in the VI state -- |
| 852 | * the vs builtin inputs are generated in the pipeline, not sourced from buffers (VertexID, etc) |
| 853 | */ |
| 854 | std::map<uint32_t, interface_var> builtin_inputs; |
| 855 | bool pass = true; |
| 856 | |
| 857 | collect_interface_by_location(my_data, dev, vs, spv::StorageClassInput, inputs, builtin_inputs, false); |
| 858 | |
| 859 | /* Build index by location */ |
| 860 | std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs; |
| 861 | if (vi) { |
| 862 | for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++) |
| 863 | attribs[vi->pVertexAttributeDescriptions[i].location] = &vi->pVertexAttributeDescriptions[i]; |
| 864 | } |
| 865 | |
| 866 | auto it_a = attribs.begin(); |
| 867 | auto it_b = inputs.begin(); |
| 868 | |
| 869 | while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) { |
| 870 | bool a_at_end = attribs.size() == 0 || it_a == attribs.end(); |
| 871 | bool b_at_end = inputs.size() == 0 || it_b == inputs.end(); |
| 872 | auto a_first = a_at_end ? 0 : it_a->first; |
| 873 | auto b_first = b_at_end ? 0 : it_b->first; |
| 874 | if (b_at_end || a_first < b_first) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 875 | if (log_msg(my_data->report_data, VK_DEBUG_REPORT_PERF_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 876 | "Vertex attribute at location %d not consumed by VS", a_first)) { |
| 877 | pass = false; |
| 878 | } |
| 879 | it_a++; |
| 880 | } |
| 881 | else if (a_at_end || b_first < a_first) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 882 | if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 883 | "VS consumes input at location %d but not provided", b_first)) { |
| 884 | pass = false; |
| 885 | } |
| 886 | it_b++; |
| 887 | } |
| 888 | else { |
| 889 | unsigned attrib_type = get_format_type(it_a->second->format); |
| 890 | unsigned input_type = get_fundamental_type(vs, it_b->second.type_id); |
| 891 | |
| 892 | /* type checking */ |
| 893 | if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) { |
| 894 | char vs_type[1024]; |
| 895 | describe_type(vs_type, vs, it_b->second.type_id); |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 896 | if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 897 | "Attribute type of `%s` at location %d does not match VS input type of `%s`", |
| 898 | string_VkFormat(it_a->second->format), a_first, vs_type)) { |
| 899 | pass = false; |
| 900 | } |
| 901 | } |
| 902 | |
| 903 | /* OK! */ |
| 904 | it_a++; |
| 905 | it_b++; |
| 906 | } |
| 907 | } |
| 908 | |
| 909 | return pass; |
| 910 | } |
| 911 | |
| 912 | static bool |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 913 | validate_fs_outputs_against_render_pass(layer_data *my_data, VkDevice dev, shader_module const *fs, RENDER_PASS_NODE const *rp, uint32_t subpass) |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 914 | { |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 915 | const std::vector<VkFormat> &color_formats = rp->subpassColorFormats[subpass]; |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 916 | std::map<uint32_t, interface_var> outputs; |
| 917 | std::map<uint32_t, interface_var> builtin_outputs; |
| 918 | bool pass = true; |
| 919 | |
| 920 | /* TODO: dual source blend index (spv::DecIndex, zero if not provided) */ |
| 921 | |
| 922 | collect_interface_by_location(my_data, dev, fs, spv::StorageClassOutput, outputs, builtin_outputs, false); |
| 923 | |
| 924 | auto it = outputs.begin(); |
| 925 | uint32_t attachment = 0; |
| 926 | |
| 927 | /* Walk attachment list and outputs together -- this is a little overpowered since attachments |
| 928 | * are currently dense, but the parallel with matching between shader stages is nice. |
| 929 | */ |
| 930 | |
| 931 | /* TODO: Figure out compile error with cb->attachmentCount */ |
| 932 | while ((outputs.size() > 0 && it != outputs.end()) || attachment < color_formats.size()) { |
| 933 | if (attachment == color_formats.size() || ( it != outputs.end() && it->first < attachment)) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 934 | if (log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 935 | "FS writes to output location %d with no matching attachment", it->first)) { |
| 936 | pass = false; |
| 937 | } |
| 938 | it++; |
| 939 | } |
| 940 | else if (it == outputs.end() || it->first > attachment) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 941 | if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 942 | "Attachment %d not written by FS", attachment)) { |
| 943 | pass = false; |
| 944 | } |
| 945 | attachment++; |
| 946 | } |
| 947 | else { |
| 948 | unsigned output_type = get_fundamental_type(fs, it->second.type_id); |
| 949 | unsigned att_type = get_format_type(color_formats[attachment]); |
| 950 | |
| 951 | /* type checking */ |
| 952 | if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) { |
| 953 | char fs_type[1024]; |
| 954 | describe_type(fs_type, fs, it->second.type_id); |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 955 | if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 956 | "Attachment %d of type `%s` does not match FS output type of `%s`", |
| 957 | attachment, string_VkFormat(color_formats[attachment]), fs_type)) { |
| 958 | pass = false; |
| 959 | } |
| 960 | } |
| 961 | |
| 962 | /* OK! */ |
| 963 | it++; |
| 964 | attachment++; |
| 965 | } |
| 966 | } |
| 967 | |
| 968 | return pass; |
| 969 | } |
| 970 | |
| 971 | |
| 972 | struct shader_stage_attributes { |
| 973 | char const * const name; |
| 974 | bool arrayed_input; |
| 975 | }; |
| 976 | |
| 977 | |
| 978 | static shader_stage_attributes |
| 979 | shader_stage_attribs[] = { |
| 980 | { "vertex shader", false }, |
| 981 | { "tessellation control shader", true }, |
| 982 | { "tessellation evaluation shader", false }, |
| 983 | { "geometry shader", true }, |
| 984 | { "fragment shader", false }, |
| 985 | }; |
| 986 | |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 987 | // For given pipelineLayout verify that the setLayout at slot.first |
| 988 | // has the requested binding at slot.second |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 989 | static bool |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 990 | has_descriptor_binding(layer_data* my_data, |
| 991 | vector<VkDescriptorSetLayout>* pipelineLayout, |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 992 | std::pair<unsigned, unsigned> slot) |
| 993 | { |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 994 | if (!pipelineLayout) |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 995 | return false; |
| 996 | |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 997 | if (slot.first >= pipelineLayout->size()) |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 998 | return false; |
| 999 | |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 1000 | auto set = my_data->descriptorSetLayoutMap[(*pipelineLayout)[slot.first]]->bindings; |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 1001 | |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 1002 | return (set.find(slot.second) != set.end()); |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 1003 | } |
| 1004 | |
| 1005 | static uint32_t get_shader_stage_id(VkShaderStageFlagBits stage) |
| 1006 | { |
| 1007 | uint32_t bit_pos = u_ffs(stage); |
| 1008 | return bit_pos-1; |
| 1009 | } |
| 1010 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1011 | // Block of code at start here for managing/tracking Pipeline state that this layer cares about |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1012 | |
| 1013 | static uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0}; |
| 1014 | |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 1015 | // TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1016 | // Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates |
| 1017 | // to that same cmd buffer by separate thread are not changing state from underneath us |
| 1018 | // Track the last cmd buffer touched by this thread |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 1019 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1020 | // Track the last global DrawState of interest touched by any thread |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 1021 | static PIPELINE_NODE* g_lastBoundPipeline = NULL; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1022 | #define MAX_BINDING 0xFFFFFFFF // Default vtxBinding value in CB Node to identify if no vtxBinding set |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 1023 | // prototype |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 1024 | static GLOBAL_CB_NODE* getCBNode(layer_data*, const VkCommandBuffer); |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1025 | |
Courtney Goeltzenleuchter | 1f41f54 | 2015-07-09 11:44:38 -0600 | [diff] [blame] | 1026 | static VkBool32 hasDrawCmd(GLOBAL_CB_NODE* pCB) |
Tobin Ehlis | 8cd650e | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 1027 | { |
| 1028 | for (uint32_t i=0; i<NUM_DRAW_TYPES; i++) { |
| 1029 | if (pCB->drawCount[i]) |
| 1030 | return VK_TRUE; |
| 1031 | } |
| 1032 | return VK_FALSE; |
| 1033 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1034 | |
Tobin Ehlis | 9786620 | 2015-06-10 12:57:07 -0600 | [diff] [blame] | 1035 | // Check object status for selected flag state |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 1036 | static VkBool32 validate_status(layer_data* my_data, GLOBAL_CB_NODE* pNode, CBStatusFlags enable_mask, CBStatusFlags status_mask, CBStatusFlags status_flag, VkFlags msg_flags, DRAW_STATE_ERROR error_code, const char* fail_msg) |
Courtney Goeltzenleuchter | 1c7c65d | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1037 | { |
Tobin Ehlis | c6c3d6d | 2015-06-22 17:20:50 -0600 | [diff] [blame] | 1038 | // If non-zero enable mask is present, check it against status but if enable_mask |
| 1039 | // is 0 then no enable required so we should always just check status |
| 1040 | if ((!enable_mask) || (enable_mask & pNode->status)) { |
| 1041 | if ((pNode->status & status_mask) != status_flag) { |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 1042 | // TODO : How to pass dispatchable objects as srcObject? Here src obj should be cmd buffer |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1043 | return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, error_code, "DS", |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 1044 | "CB object %#" PRIxLEAST64 ": %s", reinterpret_cast<uint64_t>(pNode->commandBuffer), fail_msg); |
Tobin Ehlis | 9786620 | 2015-06-10 12:57:07 -0600 | [diff] [blame] | 1045 | } |
Tobin Ehlis | 9786620 | 2015-06-10 12:57:07 -0600 | [diff] [blame] | 1046 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1047 | return VK_FALSE; |
Tobin Ehlis | 9786620 | 2015-06-10 12:57:07 -0600 | [diff] [blame] | 1048 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1049 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1050 | // Retrieve pipeline node ptr for given pipeline object |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 1051 | static PIPELINE_NODE* getPipeline(layer_data* my_data, const VkPipeline pipeline) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1052 | { |
| 1053 | loader_platform_thread_lock_mutex(&globalLock); |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1054 | if (my_data->pipelineMap.find(pipeline) == my_data->pipelineMap.end()) { |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1055 | loader_platform_thread_unlock_mutex(&globalLock); |
| 1056 | return NULL; |
| 1057 | } |
| 1058 | loader_platform_thread_unlock_mutex(&globalLock); |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1059 | return my_data->pipelineMap[pipeline]; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1060 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1061 | |
Tobin Ehlis | a88e2f5 | 2015-10-02 11:00:56 -0600 | [diff] [blame] | 1062 | // Return VK_TRUE if for a given PSO, the given state enum is dynamic, else return VK_FALSE |
| 1063 | static VkBool32 isDynamic(const PIPELINE_NODE* pPipeline, const VkDynamicState state) |
| 1064 | { |
| 1065 | if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { |
| 1066 | for (uint32_t i=0; i<pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { |
| 1067 | if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) |
| 1068 | return VK_TRUE; |
| 1069 | } |
| 1070 | } |
| 1071 | return VK_FALSE; |
| 1072 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1073 | |
Tobin Ehlis | c6c3d6d | 2015-06-22 17:20:50 -0600 | [diff] [blame] | 1074 | // Validate state stored as flags at time of draw call |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 1075 | static VkBool32 validate_draw_state_flags(layer_data* my_data, GLOBAL_CB_NODE* pCB, VkBool32 indexedDraw) { |
Courtney Goeltzenleuchter | 1f41f54 | 2015-07-09 11:44:38 -0600 | [diff] [blame] | 1076 | VkBool32 result; |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1077 | result = validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_VIEWPORT_SET, CBSTATUS_VIEWPORT_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_VIEWPORT_NOT_BOUND, "Dynamic viewport state not set for this command buffer"); |
| 1078 | result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_SCISSOR_SET, CBSTATUS_SCISSOR_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_SCISSOR_NOT_BOUND, "Dynamic scissor state not set for this command buffer"); |
| 1079 | result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_LINE_WIDTH_SET, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer"); |
| 1080 | result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_DEPTH_BIAS_SET, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer"); |
| 1081 | result |= validate_status(my_data, pCB, CBSTATUS_COLOR_BLEND_WRITE_ENABLE, CBSTATUS_BLEND_SET, CBSTATUS_BLEND_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend object state not set for this command buffer"); |
| 1082 | result |= validate_status(my_data, pCB, CBSTATUS_DEPTH_WRITE_ENABLE, CBSTATUS_DEPTH_BOUNDS_SET, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer"); |
| 1083 | result |= validate_status(my_data, pCB, CBSTATUS_STENCIL_TEST_ENABLE, CBSTATUS_STENCIL_READ_MASK_SET, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer"); |
| 1084 | result |= validate_status(my_data, pCB, CBSTATUS_STENCIL_TEST_ENABLE, CBSTATUS_STENCIL_WRITE_MASK_SET, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer"); |
| 1085 | result |= validate_status(my_data, pCB, CBSTATUS_STENCIL_TEST_ENABLE, CBSTATUS_STENCIL_REFERENCE_SET, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer"); |
Tobin Ehlis | c6c3d6d | 2015-06-22 17:20:50 -0600 | [diff] [blame] | 1086 | if (indexedDraw) |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1087 | result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_INDEX_BUFFER_BOUND, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_INDEX_BUFFER_NOT_BOUND, "Index buffer object not bound to this command buffer when Indexed Draw attempted"); |
Tobin Ehlis | c6c3d6d | 2015-06-22 17:20:50 -0600 | [diff] [blame] | 1088 | return result; |
| 1089 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1090 | |
| 1091 | // For give SET_NODE, verify that its Set is compatible w/ the setLayout corresponding to pipelineLayout[layoutIndex] |
| 1092 | static bool verify_set_layout_compatibility(layer_data* my_data, const SET_NODE* pSet, const VkPipelineLayout layout, const uint32_t layoutIndex, string& errorMsg) |
| 1093 | { |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 1094 | stringstream errorStr; |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1095 | if (my_data->pipelineLayoutMap.find(layout) == my_data->pipelineLayoutMap.end()) { |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 1096 | errorStr << "invalid VkPipelineLayout (" << layout << ")"; |
| 1097 | errorMsg = errorStr.str(); |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1098 | return false; |
| 1099 | } |
| 1100 | PIPELINE_LAYOUT_NODE pl = my_data->pipelineLayoutMap[layout]; |
| 1101 | if (layoutIndex >= pl.descriptorSetLayouts.size()) { |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 1102 | errorStr << "VkPipelineLayout (" << layout << ") only contains " << pl.descriptorSetLayouts.size() << " setLayouts corresponding to sets 0-" << pl.descriptorSetLayouts.size()-1 << ", but you're attempting to bind set to index " << layoutIndex; |
| 1103 | errorMsg = errorStr.str(); |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1104 | return false; |
| 1105 | } |
| 1106 | // Get the specific setLayout from PipelineLayout that overlaps this set |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 1107 | LAYOUT_NODE* pLayoutNode = my_data->descriptorSetLayoutMap[pl.descriptorSetLayouts[layoutIndex]]; |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1108 | if (pLayoutNode->layout == pSet->pLayout->layout) { // trivial pass case |
| 1109 | return true; |
| 1110 | } |
| 1111 | uint32_t descriptorCount = pLayoutNode->descriptorTypes.size(); |
| 1112 | if (descriptorCount != pSet->pLayout->descriptorTypes.size()) { |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 1113 | errorStr << "setLayout " << layoutIndex << " from pipelineLayout " << layout << " has " << descriptorCount << " descriptors, but corresponding set being bound has " << pSet->pLayout->descriptorTypes.size() << " descriptors."; |
| 1114 | errorMsg = errorStr.str(); |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1115 | return false; // trivial fail case |
| 1116 | } |
| 1117 | // Now need to check set against corresponding pipelineLayout to verify compatibility |
| 1118 | for (uint32_t i=0; i<descriptorCount; ++i) { |
| 1119 | // Need to verify that layouts are identically defined |
| 1120 | // TODO : Is below sufficient? Making sure that types & stageFlags match per descriptor |
| 1121 | // do we also need to check immutable samplers? |
| 1122 | if (pLayoutNode->descriptorTypes[i] != pSet->pLayout->descriptorTypes[i]) { |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 1123 | errorStr << "descriptor " << i << " for descriptorSet being bound is type '" << string_VkDescriptorType(pSet->pLayout->descriptorTypes[i]) << "' but corresponding descriptor from pipelineLayout is type '" << string_VkDescriptorType(pLayoutNode->descriptorTypes[i]) << "'"; |
| 1124 | errorMsg = errorStr.str(); |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1125 | return false; |
| 1126 | } |
| 1127 | if (pLayoutNode->stageFlags[i] != pSet->pLayout->stageFlags[i]) { |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 1128 | errorStr << "stageFlags " << i << " for descriptorSet being bound is " << pSet->pLayout->stageFlags[i] << "' but corresponding descriptor from pipelineLayout has stageFlags " << pLayoutNode->stageFlags[i]; |
| 1129 | errorMsg = errorStr.str(); |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1130 | return false; |
| 1131 | } |
| 1132 | } |
| 1133 | return true; |
| 1134 | } |
| 1135 | |
Tobin Ehlis | d17c28c | 2015-12-03 09:40:56 -0700 | [diff] [blame] | 1136 | // Validate that the shaders used by the given pipeline |
| 1137 | // As a side effect this function also records the sets that are actually used by the pipeline |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 1138 | static bool |
Tobin Ehlis | d17c28c | 2015-12-03 09:40:56 -0700 | [diff] [blame] | 1139 | validate_pipeline_shaders(layer_data *my_data, VkDevice dev, PIPELINE_NODE* pPipeline) |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 1140 | { |
Tobin Ehlis | d17c28c | 2015-12-03 09:40:56 -0700 | [diff] [blame] | 1141 | VkGraphicsPipelineCreateInfo const *pCreateInfo = &pPipeline->graphicsPipelineCI; |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 1142 | /* We seem to allow pipeline stages to be specified out of order, so collect and identify them |
| 1143 | * before trying to do anything more: */ |
| 1144 | int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); |
| 1145 | int geometry_stage = get_shader_stage_id(VK_SHADER_STAGE_GEOMETRY_BIT); |
| 1146 | int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT); |
| 1147 | |
| 1148 | shader_module **shaders = new shader_module*[fragment_stage + 1]; /* exclude CS */ |
| 1149 | memset(shaders, 0, sizeof(shader_module *) * (fragment_stage +1)); |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 1150 | RENDER_PASS_NODE const *rp = 0; |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 1151 | VkPipelineVertexInputStateCreateInfo const *vi = 0; |
| 1152 | bool pass = true; |
| 1153 | |
| 1154 | for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { |
| 1155 | VkPipelineShaderStageCreateInfo const *pStage = &pCreateInfo->pStages[i]; |
| 1156 | if (pStage->sType == VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO) { |
| 1157 | |
| 1158 | if ((pStage->stage & (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_GEOMETRY_BIT | VK_SHADER_STAGE_FRAGMENT_BIT |
| 1159 | | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT)) == 0) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1160 | if (log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_UNKNOWN_STAGE, "SC", |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 1161 | "Unknown shader stage %d", pStage->stage)) { |
| 1162 | pass = false; |
| 1163 | } |
| 1164 | } |
| 1165 | else { |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 1166 | shader_module *module = my_data->shaderModuleMap[pStage->module]; |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 1167 | shaders[get_shader_stage_id(pStage->stage)] = module; |
| 1168 | |
| 1169 | /* validate descriptor set layout against what the spirv module actually uses */ |
| 1170 | std::map<std::pair<unsigned, unsigned>, interface_var> descriptor_uses; |
| 1171 | collect_interface_by_descriptor_slot(my_data, dev, module, spv::StorageClassUniform, |
| 1172 | descriptor_uses); |
| 1173 | |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 1174 | auto layouts = pCreateInfo->layout != VK_NULL_HANDLE ? |
| 1175 | &(my_data->pipelineLayoutMap[pCreateInfo->layout].descriptorSetLayouts) : nullptr; |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 1176 | |
| 1177 | for (auto it = descriptor_uses.begin(); it != descriptor_uses.end(); it++) { |
Tobin Ehlis | d17c28c | 2015-12-03 09:40:56 -0700 | [diff] [blame] | 1178 | // As a side-effect of this function, capture which sets are used by the pipeline |
| 1179 | pPipeline->active_sets.insert(it->first.first); |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 1180 | |
| 1181 | /* find the matching binding */ |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 1182 | auto found = has_descriptor_binding(my_data, layouts, it->first); |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 1183 | |
| 1184 | if (!found) { |
| 1185 | char type_name[1024]; |
| 1186 | describe_type(type_name, module, it->second.type_id); |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1187 | if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 1188 | SHADER_CHECKER_MISSING_DESCRIPTOR, "SC", |
| 1189 | "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout", |
| 1190 | it->first.first, it->first.second, type_name)) { |
| 1191 | pass = false; |
| 1192 | } |
| 1193 | } |
| 1194 | } |
| 1195 | } |
| 1196 | } |
| 1197 | } |
| 1198 | |
| 1199 | if (pCreateInfo->renderPass != VK_NULL_HANDLE) |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 1200 | rp = my_data->renderPassMap[pCreateInfo->renderPass]; |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 1201 | |
| 1202 | vi = pCreateInfo->pVertexInputState; |
| 1203 | |
| 1204 | if (vi) { |
| 1205 | pass = validate_vi_consistency(my_data, dev, vi) && pass; |
| 1206 | } |
| 1207 | |
| 1208 | if (shaders[vertex_stage]) { |
| 1209 | pass = validate_vi_against_vs_inputs(my_data, dev, vi, shaders[vertex_stage]) && pass; |
| 1210 | } |
| 1211 | |
| 1212 | /* TODO: enforce rules about present combinations of shaders */ |
| 1213 | int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); |
| 1214 | int consumer = get_shader_stage_id(VK_SHADER_STAGE_GEOMETRY_BIT); |
| 1215 | |
| 1216 | while (!shaders[producer] && producer != fragment_stage) { |
| 1217 | producer++; |
| 1218 | consumer++; |
| 1219 | } |
| 1220 | |
| 1221 | for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) { |
| 1222 | assert(shaders[producer]); |
| 1223 | if (shaders[consumer]) { |
| 1224 | pass = validate_interface_between_stages(my_data, dev, |
| 1225 | shaders[producer], shader_stage_attribs[producer].name, |
| 1226 | shaders[consumer], shader_stage_attribs[consumer].name, |
| 1227 | shader_stage_attribs[consumer].arrayed_input) && pass; |
| 1228 | |
| 1229 | producer = consumer; |
| 1230 | } |
| 1231 | } |
| 1232 | |
| 1233 | if (shaders[fragment_stage] && rp) { |
| 1234 | pass = validate_fs_outputs_against_render_pass(my_data, dev, shaders[fragment_stage], rp, pCreateInfo->subpass) && pass; |
| 1235 | } |
| 1236 | |
| 1237 | delete shaders; |
| 1238 | |
| 1239 | return pass; |
| 1240 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1241 | |
Tobin Ehlis | c6c3d6d | 2015-06-22 17:20:50 -0600 | [diff] [blame] | 1242 | // Validate overall state at the time of a draw call |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 1243 | static VkBool32 validate_draw_state(layer_data* my_data, GLOBAL_CB_NODE* pCB, VkBool32 indexedDraw) { |
Tobin Ehlis | c6c3d6d | 2015-06-22 17:20:50 -0600 | [diff] [blame] | 1244 | // First check flag states |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 1245 | VkBool32 result = validate_draw_state_flags(my_data, pCB, indexedDraw); |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 1246 | PIPELINE_NODE* pPipe = getPipeline(my_data, pCB->lastBoundPipeline); |
Tobin Ehlis | c6c3d6d | 2015-06-22 17:20:50 -0600 | [diff] [blame] | 1247 | // Now complete other state checks |
Tobin Ehlis | 12ab7dc | 2015-09-09 13:31:01 -0600 | [diff] [blame] | 1248 | // TODO : Currently only performing next check if *something* was bound (non-zero last bound) |
| 1249 | // There is probably a better way to gate when this check happens, and to know if something *should* have been bound |
| 1250 | // We should have that check separately and then gate this check based on that check |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1251 | if (pPipe && (pCB->lastBoundPipelineLayout)) { |
Tobin Ehlis | d17c28c | 2015-12-03 09:40:56 -0700 | [diff] [blame] | 1252 | string errorString; |
| 1253 | for (auto setIndex : pPipe->active_sets) { |
| 1254 | // If valid set is not bound throw an error |
| 1255 | if ((pCB->boundDescriptorSets.size() <= setIndex) || (!pCB->boundDescriptorSets[setIndex])) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1256 | result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", |
| 1257 | "VkPipeline %#" PRIxLEAST64 " uses set #%u but that set is not bound.", (uint64_t)pPipe->pipeline, setIndex); |
Tobin Ehlis | d17c28c | 2015-12-03 09:40:56 -0700 | [diff] [blame] | 1258 | } else if (!verify_set_layout_compatibility(my_data, my_data->setMap[pCB->boundDescriptorSets[setIndex]], pPipe->graphicsPipelineCI.layout, setIndex, errorString)) { |
| 1259 | // Set is bound but not compatible w/ overlapping pipelineLayout from PSO |
| 1260 | VkDescriptorSet setHandle = my_data->setMap[pCB->boundDescriptorSets[setIndex]]->set; |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1261 | result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)setHandle, 0, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", |
Mark Lobodzinski | 74e8469 | 2015-12-14 15:14:10 -0700 | [diff] [blame] | 1262 | "VkDescriptorSet (%#" PRIxLEAST64 ") bound as set #%u is not compatible with overlapping VkPipelineLayout %#" PRIxLEAST64 " due to: %s", |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1263 | (uint64_t)setHandle, setIndex, (uint64_t)pPipe->graphicsPipelineCI.layout, errorString.c_str()); |
Tobin Ehlis | d17c28c | 2015-12-03 09:40:56 -0700 | [diff] [blame] | 1264 | } |
| 1265 | } |
Tobin Ehlis | c6c3d6d | 2015-06-22 17:20:50 -0600 | [diff] [blame] | 1266 | } |
Mark Lobodzinski | 74e8469 | 2015-12-14 15:14:10 -0700 | [diff] [blame] | 1267 | |
Tobin Ehlis | d28acef | 2015-09-09 15:12:35 -0600 | [diff] [blame] | 1268 | // Verify Vtx binding |
Mark Lobodzinski | 74e8469 | 2015-12-14 15:14:10 -0700 | [diff] [blame] | 1269 | if (pPipe->vtxBindingCount > 0) { |
| 1270 | VkPipelineVertexInputStateCreateInfo *vtxInCI = &pPipe->vertexInputCI; |
| 1271 | for (auto i = 0; i < vtxInCI->vertexBindingDescriptionCount; i++) { |
| 1272 | if ((pCB->boundVtxBuffers.size() < (i+1)) || (pCB->boundVtxBuffers[i] == VK_NULL_HANDLE)) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1273 | result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", |
Mark Lobodzinski | 74e8469 | 2015-12-14 15:14:10 -0700 | [diff] [blame] | 1274 | "The Pipeline State Object (%#" PRIxLEAST64 ") expects that this Command Buffer's vertex binding Index %d should be set via vkCmdBindVertexBuffers.", |
| 1275 | (uint64_t)pCB->lastBoundPipeline, i); |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1276 | |
Tobin Ehlis | d28acef | 2015-09-09 15:12:35 -0600 | [diff] [blame] | 1277 | } |
| 1278 | } |
Mark Lobodzinski | 74e8469 | 2015-12-14 15:14:10 -0700 | [diff] [blame] | 1279 | } else { |
| 1280 | if (!pCB->boundVtxBuffers.empty()) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1281 | result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERF_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, |
Mark Lobodzinski | 74e8469 | 2015-12-14 15:14:10 -0700 | [diff] [blame] | 1282 | "DS", "Vertex buffers are bound to command buffer (%#" PRIxLEAST64 ") but no vertex buffers are attached to this Pipeline State Object (%#" PRIxLEAST64 ").", |
| 1283 | (uint64_t)pCB->commandBuffer, (uint64_t)pCB->lastBoundPipeline); |
| 1284 | } |
Tobin Ehlis | d28acef | 2015-09-09 15:12:35 -0600 | [diff] [blame] | 1285 | } |
Mark Lobodzinski | 74e8469 | 2015-12-14 15:14:10 -0700 | [diff] [blame] | 1286 | |
Tobin Ehlis | a88e2f5 | 2015-10-02 11:00:56 -0600 | [diff] [blame] | 1287 | // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count |
| 1288 | VkBool32 dynViewport = isDynamic(pPipe, VK_DYNAMIC_STATE_VIEWPORT); |
| 1289 | VkBool32 dynScissor = isDynamic(pPipe, VK_DYNAMIC_STATE_SCISSOR); |
| 1290 | if (dynViewport) { |
| 1291 | if (pCB->viewports.size() != pPipe->graphicsPipelineCI.pViewportState->viewportCount) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1292 | result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", |
Courtney Goeltzenleuchter | 95e6dba | 2015-11-25 11:38:54 -0700 | [diff] [blame] | 1293 | "Dynamic viewportCount from vkCmdSetViewport() is " PRINTF_SIZE_T_SPECIFIER ", but PSO viewportCount is %u. These counts must match.", pCB->viewports.size(), pPipe->graphicsPipelineCI.pViewportState->viewportCount); |
Tobin Ehlis | a88e2f5 | 2015-10-02 11:00:56 -0600 | [diff] [blame] | 1294 | } |
| 1295 | } |
| 1296 | if (dynScissor) { |
| 1297 | if (pCB->scissors.size() != pPipe->graphicsPipelineCI.pViewportState->scissorCount) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1298 | result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", |
Courtney Goeltzenleuchter | 95e6dba | 2015-11-25 11:38:54 -0700 | [diff] [blame] | 1299 | "Dynamic scissorCount from vkCmdSetScissor() is " PRINTF_SIZE_T_SPECIFIER ", but PSO scissorCount is %u. These counts must match.", pCB->scissors.size(), pPipe->graphicsPipelineCI.pViewportState->scissorCount); |
Tobin Ehlis | a88e2f5 | 2015-10-02 11:00:56 -0600 | [diff] [blame] | 1300 | } |
| 1301 | } |
Tobin Ehlis | c6c3d6d | 2015-06-22 17:20:50 -0600 | [diff] [blame] | 1302 | return result; |
| 1303 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1304 | |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 1305 | // Verify that create state for a pipeline is valid |
Tobin Ehlis | d17c28c | 2015-12-03 09:40:56 -0700 | [diff] [blame] | 1306 | static VkBool32 verifyPipelineCreateState(layer_data* my_data, const VkDevice device, PIPELINE_NODE* pPipeline) |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 1307 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1308 | VkBool32 skipCall = VK_FALSE; |
Mark Lobodzinski | 312274f | 2015-12-16 14:25:22 -0700 | [diff] [blame] | 1309 | |
Tobin Ehlis | d17c28c | 2015-12-03 09:40:56 -0700 | [diff] [blame] | 1310 | if (!validate_pipeline_shaders(my_data, device, pPipeline)) { |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 1311 | skipCall = VK_TRUE; |
| 1312 | } |
Mark Lobodzinski | 312274f | 2015-12-16 14:25:22 -0700 | [diff] [blame] | 1313 | |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 1314 | // VS is required |
| 1315 | if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1316 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 1317 | "Invalid Pipeline CreateInfo State: Vtx Shader required"); |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 1318 | } |
| 1319 | // Either both or neither TC/TE shaders should be defined |
Courtney Goeltzenleuchter | c6fd226 | 2015-10-15 17:35:38 -0600 | [diff] [blame] | 1320 | if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) != |
| 1321 | ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0) ) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1322 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 1323 | "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair"); |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 1324 | } |
| 1325 | // Compute shaders should be specified independent of Gfx shaders |
| 1326 | if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) && |
Courtney Goeltzenleuchter | c6fd226 | 2015-10-15 17:35:38 -0600 | [diff] [blame] | 1327 | (pPipeline->active_shaders & (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | |
| 1328 | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | VK_SHADER_STAGE_GEOMETRY_BIT | |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 1329 | VK_SHADER_STAGE_FRAGMENT_BIT))) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1330 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 1331 | "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline"); |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 1332 | } |
Chia-I Wu | 99ba2bb | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1333 | // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 1334 | // Mismatching primitive topology and tessellation fails graphics pipeline creation. |
Courtney Goeltzenleuchter | c6fd226 | 2015-10-15 17:35:38 -0600 | [diff] [blame] | 1335 | if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && |
Chia-I Wu | 99ba2bb | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1336 | (pPipeline->iaStateCI.topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1337 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", |
Chia-I Wu | 99ba2bb | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1338 | "Invalid Pipeline CreateInfo State: VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA topology for tessellation pipelines"); |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 1339 | } |
Chia-I Wu | 99ba2bb | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1340 | if (pPipeline->iaStateCI.topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { |
Courtney Goeltzenleuchter | c6fd226 | 2015-10-15 17:35:38 -0600 | [diff] [blame] | 1341 | if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1342 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", |
Chia-I Wu | 99ba2bb | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1343 | "Invalid Pipeline CreateInfo State: VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines"); |
Tobin Ehlis | 2069317 | 2015-09-17 08:46:18 -0600 | [diff] [blame] | 1344 | } |
| 1345 | if (!pPipeline->tessStateCI.patchControlPoints || (pPipeline->tessStateCI.patchControlPoints > 32)) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1346 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", |
Chia-I Wu | 99ba2bb | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1347 | "Invalid Pipeline CreateInfo State: VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology used with patchControlPoints value %u." |
Tobin Ehlis | 2069317 | 2015-09-17 08:46:18 -0600 | [diff] [blame] | 1348 | " patchControlPoints should be >0 and <=32.", pPipeline->tessStateCI.patchControlPoints); |
| 1349 | } |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 1350 | } |
Tobin Ehlis | a88e2f5 | 2015-10-02 11:00:56 -0600 | [diff] [blame] | 1351 | // Viewport state must be included and viewport and scissor counts should always match |
Tobin Ehlis | 9e839e5 | 2015-10-01 11:15:13 -0600 | [diff] [blame] | 1352 | // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler |
Tobin Ehlis | a88e2f5 | 2015-10-02 11:00:56 -0600 | [diff] [blame] | 1353 | if (!pPipeline->graphicsPipelineCI.pViewportState) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1354 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", |
Tobin Ehlis | a88e2f5 | 2015-10-02 11:00:56 -0600 | [diff] [blame] | 1355 | "Gfx Pipeline pViewportState is null. Even if viewport and scissors are dynamic PSO must include viewportCount and scissorCount in pViewportState."); |
| 1356 | } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1357 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", |
Tobin Ehlis | 9e839e5 | 2015-10-01 11:15:13 -0600 | [diff] [blame] | 1358 | "Gfx Pipeline viewport count (%u) must match scissor count (%u).", pPipeline->vpStateCI.viewportCount, pPipeline->vpStateCI.scissorCount); |
Tobin Ehlis | a88e2f5 | 2015-10-02 11:00:56 -0600 | [diff] [blame] | 1359 | } else { |
| 1360 | // If viewport or scissor are not dynamic, then verify that data is appropriate for count |
| 1361 | VkBool32 dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); |
| 1362 | VkBool32 dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); |
| 1363 | if (!dynViewport) { |
| 1364 | if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && !pPipeline->graphicsPipelineCI.pViewportState->pViewports) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1365 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", |
Courtney Goeltzenleuchter | 95e6dba | 2015-11-25 11:38:54 -0700 | [diff] [blame] | 1366 | "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you must either include pViewports data, or include viewport in pDynamicState and set it with vkCmdSetViewport().", pPipeline->graphicsPipelineCI.pViewportState->viewportCount); |
Tobin Ehlis | 9e839e5 | 2015-10-01 11:15:13 -0600 | [diff] [blame] | 1367 | } |
| 1368 | } |
Tobin Ehlis | a88e2f5 | 2015-10-02 11:00:56 -0600 | [diff] [blame] | 1369 | if (!dynScissor) { |
| 1370 | if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && !pPipeline->graphicsPipelineCI.pViewportState->pScissors) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1371 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", |
Courtney Goeltzenleuchter | 95e6dba | 2015-11-25 11:38:54 -0700 | [diff] [blame] | 1372 | "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you must either include pScissors data, or include scissor in pDynamicState and set it with vkCmdSetScissor().", pPipeline->graphicsPipelineCI.pViewportState->scissorCount); |
Tobin Ehlis | a88e2f5 | 2015-10-02 11:00:56 -0600 | [diff] [blame] | 1373 | } |
Tobin Ehlis | 9e839e5 | 2015-10-01 11:15:13 -0600 | [diff] [blame] | 1374 | } |
| 1375 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1376 | return skipCall; |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 1377 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1378 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1379 | // Init the pipeline mapping info based on pipeline create info LL tree |
| 1380 | // Threading note : Calls to this function should wrapped in mutex |
Tobin Ehlis | d17c28c | 2015-12-03 09:40:56 -0700 | [diff] [blame] | 1381 | // TODO : this should really just be in the constructor for PIPELINE_NODE |
Mark Lobodzinski | 2adea75 | 2015-11-10 15:25:01 -0700 | [diff] [blame] | 1382 | static PIPELINE_NODE* initGraphicsPipeline(layer_data* dev_data, const VkGraphicsPipelineCreateInfo* pCreateInfo, PIPELINE_NODE* pBasePipeline) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1383 | { |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 1384 | PIPELINE_NODE* pPipeline = new PIPELINE_NODE; |
Mark Lobodzinski | e443d2b | 2015-12-11 11:56:07 -0700 | [diff] [blame] | 1385 | |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 1386 | if (pBasePipeline) { |
Mark Lobodzinski | e443d2b | 2015-12-11 11:56:07 -0700 | [diff] [blame] | 1387 | *pPipeline = *pBasePipeline; |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 1388 | } |
Mark Lobodzinski | e443d2b | 2015-12-11 11:56:07 -0700 | [diff] [blame] | 1389 | |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1390 | // First init create info |
Courtney Goeltzenleuchter | 382489d | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 1391 | memcpy(&pPipeline->graphicsPipelineCI, pCreateInfo, sizeof(VkGraphicsPipelineCreateInfo)); |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1392 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1393 | size_t bufferSize = 0; |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1394 | const VkPipelineVertexInputStateCreateInfo* pVICI = NULL; |
Tobin Ehlis | 59db571 | 2015-07-13 13:14:24 -0600 | [diff] [blame] | 1395 | const VkPipelineColorBlendStateCreateInfo* pCBCI = NULL; |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1396 | |
| 1397 | for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { |
| 1398 | const VkPipelineShaderStageCreateInfo *pPSSCI = &pCreateInfo->pStages[i]; |
| 1399 | |
Chia-I Wu | 062ad15 | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1400 | switch (pPSSCI->stage) { |
Courtney Goeltzenleuchter | 8e2f097 | 2015-10-21 17:08:06 -0600 | [diff] [blame] | 1401 | case VK_SHADER_STAGE_VERTEX_BIT: |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1402 | memcpy(&pPipeline->vsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo)); |
| 1403 | pPipeline->active_shaders |= VK_SHADER_STAGE_VERTEX_BIT; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1404 | break; |
Courtney Goeltzenleuchter | 8e2f097 | 2015-10-21 17:08:06 -0600 | [diff] [blame] | 1405 | case VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT: |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1406 | memcpy(&pPipeline->tcsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo)); |
Courtney Goeltzenleuchter | c6fd226 | 2015-10-15 17:35:38 -0600 | [diff] [blame] | 1407 | pPipeline->active_shaders |= VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1408 | break; |
Courtney Goeltzenleuchter | 8e2f097 | 2015-10-21 17:08:06 -0600 | [diff] [blame] | 1409 | case VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT: |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1410 | memcpy(&pPipeline->tesCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo)); |
Courtney Goeltzenleuchter | c6fd226 | 2015-10-15 17:35:38 -0600 | [diff] [blame] | 1411 | pPipeline->active_shaders |= VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1412 | break; |
Courtney Goeltzenleuchter | 8e2f097 | 2015-10-21 17:08:06 -0600 | [diff] [blame] | 1413 | case VK_SHADER_STAGE_GEOMETRY_BIT: |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1414 | memcpy(&pPipeline->gsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo)); |
| 1415 | pPipeline->active_shaders |= VK_SHADER_STAGE_GEOMETRY_BIT; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1416 | break; |
Courtney Goeltzenleuchter | 8e2f097 | 2015-10-21 17:08:06 -0600 | [diff] [blame] | 1417 | case VK_SHADER_STAGE_FRAGMENT_BIT: |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1418 | memcpy(&pPipeline->fsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo)); |
| 1419 | pPipeline->active_shaders |= VK_SHADER_STAGE_FRAGMENT_BIT; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1420 | break; |
Courtney Goeltzenleuchter | 8e2f097 | 2015-10-21 17:08:06 -0600 | [diff] [blame] | 1421 | case VK_SHADER_STAGE_COMPUTE_BIT: |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1422 | // TODO : Flag error, CS is specified through VkComputePipelineCreateInfo |
| 1423 | pPipeline->active_shaders |= VK_SHADER_STAGE_COMPUTE_BIT; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1424 | break; |
| 1425 | default: |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1426 | // TODO : Flag error |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1427 | break; |
| 1428 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1429 | } |
Tobin Ehlis | f6cb467 | 2015-09-29 08:18:34 -0600 | [diff] [blame] | 1430 | // Copy over GraphicsPipelineCreateInfo structure embedded pointers |
| 1431 | if (pCreateInfo->stageCount != 0) { |
| 1432 | pPipeline->graphicsPipelineCI.pStages = new VkPipelineShaderStageCreateInfo[pCreateInfo->stageCount]; |
| 1433 | bufferSize = pCreateInfo->stageCount * sizeof(VkPipelineShaderStageCreateInfo); |
| 1434 | memcpy((void*)pPipeline->graphicsPipelineCI.pStages, pCreateInfo->pStages, bufferSize); |
| 1435 | } |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1436 | if (pCreateInfo->pVertexInputState != NULL) { |
| 1437 | memcpy((void*)&pPipeline->vertexInputCI, pCreateInfo->pVertexInputState , sizeof(VkPipelineVertexInputStateCreateInfo)); |
| 1438 | // Copy embedded ptrs |
| 1439 | pVICI = pCreateInfo->pVertexInputState; |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 1440 | pPipeline->vtxBindingCount = pVICI->vertexBindingDescriptionCount; |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1441 | if (pPipeline->vtxBindingCount) { |
| 1442 | pPipeline->pVertexBindingDescriptions = new VkVertexInputBindingDescription[pPipeline->vtxBindingCount]; |
| 1443 | bufferSize = pPipeline->vtxBindingCount * sizeof(VkVertexInputBindingDescription); |
| 1444 | memcpy((void*)pPipeline->pVertexBindingDescriptions, pVICI->pVertexBindingDescriptions, bufferSize); |
| 1445 | } |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 1446 | pPipeline->vtxAttributeCount = pVICI->vertexAttributeDescriptionCount; |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1447 | if (pPipeline->vtxAttributeCount) { |
| 1448 | pPipeline->pVertexAttributeDescriptions = new VkVertexInputAttributeDescription[pPipeline->vtxAttributeCount]; |
| 1449 | bufferSize = pPipeline->vtxAttributeCount * sizeof(VkVertexInputAttributeDescription); |
| 1450 | memcpy((void*)pPipeline->pVertexAttributeDescriptions, pVICI->pVertexAttributeDescriptions, bufferSize); |
| 1451 | } |
| 1452 | pPipeline->graphicsPipelineCI.pVertexInputState = &pPipeline->vertexInputCI; |
| 1453 | } |
Tony Barbour | e307f58 | 2015-07-10 15:29:03 -0600 | [diff] [blame] | 1454 | if (pCreateInfo->pInputAssemblyState != NULL) { |
| 1455 | memcpy((void*)&pPipeline->iaStateCI, pCreateInfo->pInputAssemblyState, sizeof(VkPipelineInputAssemblyStateCreateInfo)); |
| 1456 | pPipeline->graphicsPipelineCI.pInputAssemblyState = &pPipeline->iaStateCI; |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1457 | } |
Tony Barbour | e307f58 | 2015-07-10 15:29:03 -0600 | [diff] [blame] | 1458 | if (pCreateInfo->pTessellationState != NULL) { |
| 1459 | memcpy((void*)&pPipeline->tessStateCI, pCreateInfo->pTessellationState, sizeof(VkPipelineTessellationStateCreateInfo)); |
| 1460 | pPipeline->graphicsPipelineCI.pTessellationState = &pPipeline->tessStateCI; |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1461 | } |
Tony Barbour | e307f58 | 2015-07-10 15:29:03 -0600 | [diff] [blame] | 1462 | if (pCreateInfo->pViewportState != NULL) { |
| 1463 | memcpy((void*)&pPipeline->vpStateCI, pCreateInfo->pViewportState, sizeof(VkPipelineViewportStateCreateInfo)); |
| 1464 | pPipeline->graphicsPipelineCI.pViewportState = &pPipeline->vpStateCI; |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1465 | } |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 1466 | if (pCreateInfo->pRasterizationState != NULL) { |
| 1467 | memcpy((void*)&pPipeline->rsStateCI, pCreateInfo->pRasterizationState, sizeof(VkPipelineRasterizationStateCreateInfo)); |
| 1468 | pPipeline->graphicsPipelineCI.pRasterizationState = &pPipeline->rsStateCI; |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1469 | } |
Tony Barbour | e307f58 | 2015-07-10 15:29:03 -0600 | [diff] [blame] | 1470 | if (pCreateInfo->pMultisampleState != NULL) { |
| 1471 | memcpy((void*)&pPipeline->msStateCI, pCreateInfo->pMultisampleState, sizeof(VkPipelineMultisampleStateCreateInfo)); |
| 1472 | pPipeline->graphicsPipelineCI.pMultisampleState = &pPipeline->msStateCI; |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1473 | } |
Tobin Ehlis | f6cb467 | 2015-09-29 08:18:34 -0600 | [diff] [blame] | 1474 | if (pCreateInfo->pDepthStencilState != NULL) { |
| 1475 | memcpy((void*)&pPipeline->dsStateCI, pCreateInfo->pDepthStencilState, sizeof(VkPipelineDepthStencilStateCreateInfo)); |
| 1476 | pPipeline->graphicsPipelineCI.pDepthStencilState = &pPipeline->dsStateCI; |
| 1477 | } |
Tony Barbour | e307f58 | 2015-07-10 15:29:03 -0600 | [diff] [blame] | 1478 | if (pCreateInfo->pColorBlendState != NULL) { |
| 1479 | memcpy((void*)&pPipeline->cbStateCI, pCreateInfo->pColorBlendState, sizeof(VkPipelineColorBlendStateCreateInfo)); |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1480 | // Copy embedded ptrs |
Tony Barbour | e307f58 | 2015-07-10 15:29:03 -0600 | [diff] [blame] | 1481 | pCBCI = pCreateInfo->pColorBlendState; |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1482 | pPipeline->attachmentCount = pCBCI->attachmentCount; |
| 1483 | if (pPipeline->attachmentCount) { |
Tony Barbour | e307f58 | 2015-07-10 15:29:03 -0600 | [diff] [blame] | 1484 | pPipeline->pAttachments = new VkPipelineColorBlendAttachmentState[pPipeline->attachmentCount]; |
| 1485 | bufferSize = pPipeline->attachmentCount * sizeof(VkPipelineColorBlendAttachmentState); |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1486 | memcpy((void*)pPipeline->pAttachments, pCBCI->pAttachments, bufferSize); |
| 1487 | } |
Tony Barbour | e307f58 | 2015-07-10 15:29:03 -0600 | [diff] [blame] | 1488 | pPipeline->graphicsPipelineCI.pColorBlendState = &pPipeline->cbStateCI; |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1489 | } |
Tobin Ehlis | f6cb467 | 2015-09-29 08:18:34 -0600 | [diff] [blame] | 1490 | if (pCreateInfo->pDynamicState != NULL) { |
| 1491 | memcpy((void*)&pPipeline->dynStateCI, pCreateInfo->pDynamicState, sizeof(VkPipelineDynamicStateCreateInfo)); |
| 1492 | if (pPipeline->dynStateCI.dynamicStateCount) { |
| 1493 | pPipeline->dynStateCI.pDynamicStates = new VkDynamicState[pPipeline->dynStateCI.dynamicStateCount]; |
| 1494 | bufferSize = pPipeline->dynStateCI.dynamicStateCount * sizeof(VkDynamicState); |
| 1495 | memcpy((void*)pPipeline->dynStateCI.pDynamicStates, pCreateInfo->pDynamicState->pDynamicStates, bufferSize); |
| 1496 | } |
| 1497 | pPipeline->graphicsPipelineCI.pDynamicState = &pPipeline->dynStateCI; |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1498 | } |
Tobin Ehlis | d17c28c | 2015-12-03 09:40:56 -0700 | [diff] [blame] | 1499 | pPipeline->active_sets.clear(); |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 1500 | return pPipeline; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1501 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1502 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1503 | // Free the Pipeline nodes |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 1504 | static void deletePipelines(layer_data* my_data) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1505 | { |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 1506 | if (my_data->pipelineMap.size() <= 0) |
David Pinedo | f5997ab | 2015-04-27 16:36:17 -0600 | [diff] [blame] | 1507 | return; |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 1508 | for (auto ii=my_data->pipelineMap.begin(); ii!=my_data->pipelineMap.end(); ++ii) { |
Mark Lobodzinski | 0e0fb5c | 2015-06-23 15:11:57 -0600 | [diff] [blame] | 1509 | if ((*ii).second->graphicsPipelineCI.stageCount != 0) { |
| 1510 | delete[] (*ii).second->graphicsPipelineCI.pStages; |
| 1511 | } |
Tobin Ehlis | cd3109e | 2015-04-01 11:59:08 -0600 | [diff] [blame] | 1512 | if ((*ii).second->pVertexBindingDescriptions) { |
| 1513 | delete[] (*ii).second->pVertexBindingDescriptions; |
| 1514 | } |
| 1515 | if ((*ii).second->pVertexAttributeDescriptions) { |
| 1516 | delete[] (*ii).second->pVertexAttributeDescriptions; |
| 1517 | } |
| 1518 | if ((*ii).second->pAttachments) { |
| 1519 | delete[] (*ii).second->pAttachments; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1520 | } |
Tobin Ehlis | f6cb467 | 2015-09-29 08:18:34 -0600 | [diff] [blame] | 1521 | if ((*ii).second->dynStateCI.dynamicStateCount != 0) { |
| 1522 | delete[] (*ii).second->dynStateCI.pDynamicStates; |
| 1523 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1524 | delete (*ii).second; |
| 1525 | } |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 1526 | my_data->pipelineMap.clear(); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1527 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1528 | |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 1529 | // For given pipeline, return number of MSAA samples, or one if MSAA disabled |
Chia-I Wu | 3138d6a | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1530 | static VkSampleCountFlagBits getNumSamples(layer_data* my_data, const VkPipeline pipeline) |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 1531 | { |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1532 | PIPELINE_NODE* pPipe = my_data->pipelineMap[pipeline]; |
Tobin Ehlis | b3a506f | 2015-07-13 14:51:15 -0600 | [diff] [blame] | 1533 | if (VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pPipe->msStateCI.sType) { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 1534 | return pPipe->msStateCI.rasterizationSamples; |
Tobin Ehlis | b3a506f | 2015-07-13 14:51:15 -0600 | [diff] [blame] | 1535 | } |
Chia-I Wu | 3138d6a | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1536 | return VK_SAMPLE_COUNT_1_BIT; |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 1537 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1538 | |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 1539 | // Validate state related to the PSO |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 1540 | static VkBool32 validatePipelineState(layer_data* my_data, const GLOBAL_CB_NODE* pCB, const VkPipelineBindPoint pipelineBindPoint, const VkPipeline pipeline) |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 1541 | { |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 1542 | if (VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) { |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 1543 | // Verify that any MSAA request in PSO matches sample# in bound FB |
Chia-I Wu | 3138d6a | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1544 | VkSampleCountFlagBits psoNumSamples = getNumSamples(my_data, pipeline); |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 1545 | if (pCB->activeRenderPass) { |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 1546 | const VkRenderPassCreateInfo* pRPCI = my_data->renderPassMap[pCB->activeRenderPass]->pCreateInfo; |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 1547 | const VkSubpassDescription* pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; |
Chia-I Wu | 3138d6a | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1548 | VkSampleCountFlagBits subpassNumSamples = (VkSampleCountFlagBits) 0; |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 1549 | uint32_t i; |
| 1550 | |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 1551 | for (i = 0; i < pSD->colorAttachmentCount; i++) { |
Chia-I Wu | 3138d6a | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1552 | VkSampleCountFlagBits samples; |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 1553 | |
Cody Northrop | 6de6b0b | 2015-08-04 11:16:41 -0600 | [diff] [blame] | 1554 | if (pSD->pColorAttachments[i].attachment == VK_ATTACHMENT_UNUSED) |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 1555 | continue; |
| 1556 | |
Cody Northrop | 6de6b0b | 2015-08-04 11:16:41 -0600 | [diff] [blame] | 1557 | samples = pRPCI->pAttachments[pSD->pColorAttachments[i].attachment].samples; |
Chia-I Wu | 3138d6a | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1558 | if (subpassNumSamples == (VkSampleCountFlagBits) 0) { |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 1559 | subpassNumSamples = samples; |
| 1560 | } else if (subpassNumSamples != samples) { |
Chia-I Wu | 3138d6a | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1561 | subpassNumSamples = (VkSampleCountFlagBits) -1; |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 1562 | break; |
| 1563 | } |
| 1564 | } |
Chia-I Wu | ce532f7 | 2015-10-26 17:32:47 +0800 | [diff] [blame] | 1565 | if (pSD->pDepthStencilAttachment && pSD->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
Chia-I Wu | 3138d6a | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1566 | const VkSampleCountFlagBits samples = pRPCI->pAttachments[pSD->pDepthStencilAttachment->attachment].samples; |
| 1567 | if (subpassNumSamples == (VkSampleCountFlagBits) 0) |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 1568 | subpassNumSamples = samples; |
| 1569 | else if (subpassNumSamples != samples) |
Chia-I Wu | 3138d6a | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1570 | subpassNumSamples = (VkSampleCountFlagBits) -1; |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 1571 | } |
| 1572 | |
| 1573 | if (psoNumSamples != subpassNumSamples) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1574 | return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, (uint64_t) pipeline, 0, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 1575 | "Num samples mismatch! Binding PSO (%#" PRIxLEAST64 ") with %u samples while current RenderPass (%#" PRIxLEAST64 ") w/ %u samples!", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1576 | (uint64_t) pipeline, psoNumSamples, (uint64_t) pCB->activeRenderPass, subpassNumSamples); |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 1577 | } |
| 1578 | } else { |
| 1579 | // TODO : I believe it's an error if we reach this point and don't have an activeRenderPass |
| 1580 | // Verify and flag error as appropriate |
| 1581 | } |
| 1582 | // TODO : Add more checks here |
| 1583 | } else { |
| 1584 | // TODO : Validate non-gfx pipeline updates |
| 1585 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1586 | return VK_FALSE; |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 1587 | } |
| 1588 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1589 | // Block of code at start here specifically for managing/tracking DSs |
| 1590 | |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 1591 | // Return Pool node ptr for specified pool or else NULL |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 1592 | static DESCRIPTOR_POOL_NODE* getPoolNode(layer_data* my_data, const VkDescriptorPool pool) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1593 | { |
| 1594 | loader_platform_thread_lock_mutex(&globalLock); |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 1595 | if (my_data->descriptorPoolMap.find(pool) == my_data->descriptorPoolMap.end()) { |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1596 | loader_platform_thread_unlock_mutex(&globalLock); |
| 1597 | return NULL; |
| 1598 | } |
| 1599 | loader_platform_thread_unlock_mutex(&globalLock); |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 1600 | return my_data->descriptorPoolMap[pool]; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1601 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1602 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1603 | // Return Set node ptr for specified set or else NULL |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 1604 | static SET_NODE* getSetNode(layer_data* my_data, const VkDescriptorSet set) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1605 | { |
| 1606 | loader_platform_thread_lock_mutex(&globalLock); |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1607 | if (my_data->setMap.find(set) == my_data->setMap.end()) { |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1608 | loader_platform_thread_unlock_mutex(&globalLock); |
| 1609 | return NULL; |
| 1610 | } |
| 1611 | loader_platform_thread_unlock_mutex(&globalLock); |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1612 | return my_data->setMap[set]; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1613 | } |
| 1614 | |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 1615 | static LAYOUT_NODE* getLayoutNode(layer_data* my_data, const VkDescriptorSetLayout layout) { |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1616 | loader_platform_thread_lock_mutex(&globalLock); |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 1617 | if (my_data->descriptorSetLayoutMap.find(layout) == my_data->descriptorSetLayoutMap.end()) { |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1618 | loader_platform_thread_unlock_mutex(&globalLock); |
| 1619 | return NULL; |
| 1620 | } |
| 1621 | loader_platform_thread_unlock_mutex(&globalLock); |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 1622 | return my_data->descriptorSetLayoutMap[layout]; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1623 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1624 | |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1625 | // Return VK_FALSE if update struct is of valid type, otherwise flag error and return code from callback |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 1626 | static VkBool32 validUpdateStruct(layer_data* my_data, const VkDevice device, const GENERIC_HEADER* pUpdateStruct) |
Tobin Ehlis | 0b551cd | 2015-05-28 12:10:17 -0600 | [diff] [blame] | 1627 | { |
Tobin Ehlis | 0b551cd | 2015-05-28 12:10:17 -0600 | [diff] [blame] | 1628 | switch (pUpdateStruct->sType) |
| 1629 | { |
Chia-I Wu | 8cd8ecd | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1630 | case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: |
| 1631 | case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1632 | return VK_FALSE; |
Tobin Ehlis | 0b551cd | 2015-05-28 12:10:17 -0600 | [diff] [blame] | 1633 | default: |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1634 | return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 1635 | "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); |
Tobin Ehlis | 0b551cd | 2015-05-28 12:10:17 -0600 | [diff] [blame] | 1636 | } |
| 1637 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1638 | |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1639 | // Set count for given update struct in the last parameter |
| 1640 | // Return value of skipCall, which is only VK_TRUE is error occurs and callback signals execution to cease |
Tobin Ehlis | e66ec96 | 2015-10-27 12:54:50 -0600 | [diff] [blame] | 1641 | static uint32_t getUpdateCount(layer_data* my_data, const VkDevice device, const GENERIC_HEADER* pUpdateStruct) |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 1642 | { |
| 1643 | switch (pUpdateStruct->sType) |
| 1644 | { |
Chia-I Wu | 8cd8ecd | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1645 | case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 1646 | return ((VkWriteDescriptorSet*)pUpdateStruct)->descriptorCount; |
Chia-I Wu | 8cd8ecd | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1647 | case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 1648 | // TODO : Need to understand this case better and make sure code is correct |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 1649 | return ((VkCopyDescriptorSet*)pUpdateStruct)->descriptorCount; |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 1650 | } |
| 1651 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1652 | |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 1653 | // For given Layout Node and binding, return index where that binding begins |
| 1654 | static uint32_t getBindingStartIndex(const LAYOUT_NODE* pLayout, const uint32_t binding) |
| 1655 | { |
| 1656 | uint32_t offsetIndex = 0; |
Chia-I Wu | b5689ee | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1657 | for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) { |
| 1658 | if (pLayout->createInfo.pBinding[i].binding == binding) |
| 1659 | break; |
Chia-I Wu | 045654f | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 1660 | offsetIndex += pLayout->createInfo.pBinding[i].descriptorCount; |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 1661 | } |
| 1662 | return offsetIndex; |
| 1663 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1664 | |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 1665 | // For given layout node and binding, return last index that is updated |
| 1666 | static uint32_t getBindingEndIndex(const LAYOUT_NODE* pLayout, const uint32_t binding) |
| 1667 | { |
| 1668 | uint32_t offsetIndex = 0; |
Chia-I Wu | b5689ee | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1669 | for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) { |
Chia-I Wu | 045654f | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 1670 | offsetIndex += pLayout->createInfo.pBinding[i].descriptorCount; |
Chia-I Wu | b5689ee | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1671 | if (pLayout->createInfo.pBinding[i].binding == binding) |
| 1672 | break; |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 1673 | } |
| 1674 | return offsetIndex-1; |
| 1675 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1676 | |
Tobin Ehlis | e66ec96 | 2015-10-27 12:54:50 -0600 | [diff] [blame] | 1677 | // For given layout and update, return the first overall index of the layout that is updated |
Tobin Ehlis | d2e246e | 2015-10-27 15:43:38 -0600 | [diff] [blame] | 1678 | static uint32_t getUpdateStartIndex(layer_data* my_data, const VkDevice device, const LAYOUT_NODE* pLayout, const uint32_t binding, const uint32_t arrayIndex, const GENERIC_HEADER* pUpdateStruct) |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 1679 | { |
Tobin Ehlis | e66ec96 | 2015-10-27 12:54:50 -0600 | [diff] [blame] | 1680 | return getBindingStartIndex(pLayout, binding)+arrayIndex; |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 1681 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1682 | |
Tobin Ehlis | d2e246e | 2015-10-27 15:43:38 -0600 | [diff] [blame] | 1683 | // For given layout and update, return the last overall index of the layout that is updated |
| 1684 | static uint32_t getUpdateEndIndex(layer_data* my_data, const VkDevice device, const LAYOUT_NODE* pLayout, const uint32_t binding, const uint32_t arrayIndex, const GENERIC_HEADER* pUpdateStruct) |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 1685 | { |
Tobin Ehlis | d2e246e | 2015-10-27 15:43:38 -0600 | [diff] [blame] | 1686 | uint32_t count = getUpdateCount(my_data, device, pUpdateStruct); |
Tobin Ehlis | e66ec96 | 2015-10-27 12:54:50 -0600 | [diff] [blame] | 1687 | return getBindingStartIndex(pLayout, binding)+arrayIndex+count-1; |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 1688 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1689 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1690 | // Verify that the descriptor type in the update struct matches what's expected by the layout |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1691 | static VkBool32 validateUpdateConsistency(layer_data* my_data, const VkDevice device, const LAYOUT_NODE* pLayout, const GENERIC_HEADER* pUpdateStruct, uint32_t startIndex, uint32_t endIndex) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1692 | { |
| 1693 | // First get actual type of update |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1694 | VkBool32 skipCall = VK_FALSE; |
Courtney Goeltzenleuchter | 382489d | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 1695 | VkDescriptorType actualType; |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1696 | uint32_t i = 0; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1697 | switch (pUpdateStruct->sType) |
| 1698 | { |
Chia-I Wu | 8cd8ecd | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1699 | case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: |
| 1700 | actualType = ((VkWriteDescriptorSet*)pUpdateStruct)->descriptorType; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1701 | break; |
Chia-I Wu | 8cd8ecd | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1702 | case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: |
| 1703 | /* no need to validate */ |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1704 | return VK_FALSE; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1705 | break; |
| 1706 | default: |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1707 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 1708 | "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1709 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1710 | if (VK_FALSE == skipCall) { |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1711 | // Set first stageFlags as reference and verify that all other updates match it |
| 1712 | VkShaderStageFlags refStageFlags = pLayout->stageFlags[startIndex]; |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1713 | for (i = startIndex; i <= endIndex; i++) { |
Tobin Ehlis | 91423d2 | 2015-10-20 10:11:55 -0600 | [diff] [blame] | 1714 | if (pLayout->descriptorTypes[i] != actualType) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1715 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1716 | "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!", |
| 1717 | string_VkDescriptorType(actualType), string_VkDescriptorType(pLayout->descriptorTypes[i])); |
| 1718 | } |
| 1719 | if (pLayout->stageFlags[i] != refStageFlags) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1720 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_DESCRIPTOR_STAGEFLAGS_MISMATCH, "DS", |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1721 | "Write descriptor update has stageFlags %x that do not match overlapping binding descriptor stageFlags of %x!", |
| 1722 | refStageFlags, pLayout->stageFlags[i]); |
Tobin Ehlis | 3b34109 | 2015-09-30 08:30:20 -0600 | [diff] [blame] | 1723 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1724 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1725 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1726 | return skipCall; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1727 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1728 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1729 | // Determine the update type, allocate a new struct of that type, shadow the given pUpdate |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1730 | // struct into the pNewNode param. Return VK_TRUE if error condition encountered and callback signals early exit. |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1731 | // NOTE : Calls to this function should be wrapped in mutex |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 1732 | static VkBool32 shadowUpdateNode(layer_data* my_data, const VkDevice device, GENERIC_HEADER* pUpdate, GENERIC_HEADER** pNewNode) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1733 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1734 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 8cd8ecd | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1735 | VkWriteDescriptorSet* pWDS = NULL; |
| 1736 | VkCopyDescriptorSet* pCDS = NULL; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1737 | size_t array_size = 0; |
| 1738 | size_t base_array_size = 0; |
| 1739 | size_t total_array_size = 0; |
| 1740 | size_t baseBuffAddr = 0; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1741 | switch (pUpdate->sType) |
| 1742 | { |
Chia-I Wu | 8cd8ecd | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1743 | case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: |
| 1744 | pWDS = new VkWriteDescriptorSet; |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1745 | *pNewNode = (GENERIC_HEADER*)pWDS; |
Chia-I Wu | 8cd8ecd | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1746 | memcpy(pWDS, pUpdate, sizeof(VkWriteDescriptorSet)); |
Courtney Goeltzenleuchter | 34aa5c8 | 2015-10-23 13:38:14 -0600 | [diff] [blame] | 1747 | |
| 1748 | switch (pWDS->descriptorType) { |
| 1749 | case VK_DESCRIPTOR_TYPE_SAMPLER: |
| 1750 | case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: |
| 1751 | case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: |
| 1752 | case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: |
| 1753 | { |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 1754 | VkDescriptorImageInfo *info = new VkDescriptorImageInfo[pWDS->descriptorCount]; |
| 1755 | memcpy(info, pWDS->pImageInfo, pWDS->descriptorCount * sizeof(VkDescriptorImageInfo)); |
Courtney Goeltzenleuchter | 34aa5c8 | 2015-10-23 13:38:14 -0600 | [diff] [blame] | 1756 | pWDS->pImageInfo = info; |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 1757 | } |
Courtney Goeltzenleuchter | 34aa5c8 | 2015-10-23 13:38:14 -0600 | [diff] [blame] | 1758 | break; |
| 1759 | case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: |
| 1760 | case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: |
| 1761 | { |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 1762 | VkBufferView *info = new VkBufferView[pWDS->descriptorCount]; |
| 1763 | memcpy(info, pWDS->pTexelBufferView, pWDS->descriptorCount * sizeof(VkBufferView)); |
Courtney Goeltzenleuchter | 34aa5c8 | 2015-10-23 13:38:14 -0600 | [diff] [blame] | 1764 | pWDS->pTexelBufferView = info; |
| 1765 | } |
| 1766 | break; |
| 1767 | case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: |
| 1768 | case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: |
| 1769 | case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: |
| 1770 | case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: |
| 1771 | { |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 1772 | VkDescriptorBufferInfo *info = new VkDescriptorBufferInfo[pWDS->descriptorCount]; |
| 1773 | memcpy(info, pWDS->pBufferInfo, pWDS->descriptorCount * sizeof(VkDescriptorBufferInfo)); |
Courtney Goeltzenleuchter | 34aa5c8 | 2015-10-23 13:38:14 -0600 | [diff] [blame] | 1774 | pWDS->pBufferInfo = info; |
| 1775 | } |
| 1776 | break; |
| 1777 | default: |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 1778 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Courtney Goeltzenleuchter | 34aa5c8 | 2015-10-23 13:38:14 -0600 | [diff] [blame] | 1779 | break; |
| 1780 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1781 | break; |
Chia-I Wu | 8cd8ecd | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1782 | case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: |
| 1783 | pCDS = new VkCopyDescriptorSet; |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1784 | *pNewNode = (GENERIC_HEADER*)pCDS; |
Chia-I Wu | 8cd8ecd | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1785 | memcpy(pCDS, pUpdate, sizeof(VkCopyDescriptorSet)); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1786 | break; |
| 1787 | default: |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1788 | if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1789 | "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", string_VkStructureType(pUpdate->sType), pUpdate->sType)) |
| 1790 | return VK_TRUE; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1791 | } |
| 1792 | // Make sure that pNext for the end of shadow copy is NULL |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1793 | (*pNewNode)->pNext = NULL; |
| 1794 | return skipCall; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1795 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1796 | |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1797 | // Verify that given sampler is valid |
| 1798 | static VkBool32 validateSampler(const layer_data* my_data, const VkSampler* pSampler, const VkBool32 immutable) |
| 1799 | { |
| 1800 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1801 | auto sampIt = my_data->sampleMap.find(*pSampler); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1802 | if (sampIt == my_data->sampleMap.end()) { |
| 1803 | if (!immutable) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1804 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, (uint64_t) *pSampler, 0, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1805 | "vkUpdateDescriptorSets: Attempt to update descriptor with invalid sampler %#" PRIxLEAST64, (uint64_t) *pSampler); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1806 | } else { // immutable |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1807 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, (uint64_t) *pSampler, 0, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1808 | "vkUpdateDescriptorSets: Attempt to update descriptor whose binding has an invalid immutable sampler %#" PRIxLEAST64, (uint64_t) *pSampler); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1809 | } |
| 1810 | } else { |
| 1811 | // TODO : Any further checks we want to do on the sampler? |
| 1812 | } |
| 1813 | return skipCall; |
| 1814 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1815 | |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1816 | // Verify that given imageView is valid |
| 1817 | static VkBool32 validateImageView(const layer_data* my_data, const VkImageView* pImageView, const VkImageLayout imageLayout) |
| 1818 | { |
| 1819 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1820 | auto ivIt = my_data->imageViewMap.find(*pImageView); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1821 | if (ivIt == my_data->imageViewMap.end()) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1822 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, (uint64_t) *pImageView, 0, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1823 | "vkUpdateDescriptorSets: Attempt to update descriptor with invalid imageView %#" PRIxLEAST64, (uint64_t) *pImageView); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1824 | } else { |
| 1825 | // Validate that imageLayout is compatible with aspectMask and image format |
| 1826 | VkImageAspectFlags aspectMask = ivIt->second->subresourceRange.aspectMask; |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1827 | VkImage image = ivIt->second->image; |
Michael Lentine | ee4ad4d | 2015-10-23 12:41:44 -0700 | [diff] [blame] | 1828 | // TODO : Check here in case we have a bad image |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1829 | auto imgIt = my_data->imageMap.find(image); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1830 | if (imgIt == my_data->imageMap.end()) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1831 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, (uint64_t) image, 0, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", |
Michael Lentine | ee4ad4d | 2015-10-23 12:41:44 -0700 | [diff] [blame] | 1832 | "vkUpdateDescriptorSets: Attempt to update descriptor with invalid image %#" PRIxLEAST64 " in imageView %#" PRIxLEAST64, (uint64_t) image, (uint64_t) *pImageView); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1833 | } else { |
| 1834 | VkFormat format = (*imgIt).second->format; |
Courtney Goeltzenleuchter | f2bca90 | 2015-11-03 15:41:43 -0700 | [diff] [blame] | 1835 | VkBool32 ds = vk_format_is_depth_or_stencil(format); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1836 | switch (imageLayout) { |
| 1837 | case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: |
| 1838 | // Only Color bit must be set |
| 1839 | if ((aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) != VK_IMAGE_ASPECT_COLOR_BIT) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1840 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, (uint64_t) *pImageView, 0, |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1841 | DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL and imageView %#" PRIxLEAST64 "" |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1842 | " that does not have VK_IMAGE_ASPECT_COLOR_BIT set.", (uint64_t) *pImageView); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1843 | } |
| 1844 | // format must NOT be DS |
| 1845 | if (ds) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1846 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, (uint64_t) *pImageView, 0, |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1847 | DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL and imageView %#" PRIxLEAST64 "" |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1848 | " but the image format is %s which is not a color format.", (uint64_t) *pImageView, string_VkFormat(format)); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1849 | } |
| 1850 | break; |
| 1851 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: |
| 1852 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: |
| 1853 | // Depth or stencil bit must be set, but both must NOT be set |
| 1854 | if (aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) { |
| 1855 | if (aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT) { |
| 1856 | // both must NOT be set |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1857 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, (uint64_t) *pImageView, 0, |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1858 | DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", "vkUpdateDescriptorSets: Updating descriptor with imageView %#" PRIxLEAST64 "" |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1859 | " that has both STENCIL and DEPTH aspects set", (uint64_t) *pImageView); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1860 | } |
| 1861 | } else if (!(aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT)) { |
| 1862 | // Neither were set |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1863 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, (uint64_t) *pImageView, 0, |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1864 | DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 "" |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1865 | " that does not have STENCIL or DEPTH aspect set.", string_VkImageLayout(imageLayout), (uint64_t) *pImageView); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1866 | } |
| 1867 | // format must be DS |
| 1868 | if (!ds) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1869 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, (uint64_t) *pImageView, 0, |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1870 | DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 "" |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1871 | " but the image format is %s which is not a depth/stencil format.", string_VkImageLayout(imageLayout), (uint64_t) *pImageView, string_VkFormat(format)); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1872 | } |
| 1873 | break; |
| 1874 | default: |
| 1875 | // anything to check for other layouts? |
| 1876 | break; |
| 1877 | } |
| 1878 | } |
| 1879 | } |
| 1880 | return skipCall; |
| 1881 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1882 | |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1883 | // Verify that given bufferView is valid |
| 1884 | static VkBool32 validateBufferView(const layer_data* my_data, const VkBufferView* pBufferView) |
| 1885 | { |
| 1886 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1887 | auto sampIt = my_data->bufferViewMap.find(*pBufferView); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1888 | if (sampIt == my_data->bufferViewMap.end()) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1889 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT, (uint64_t) *pBufferView, 0, DRAWSTATE_BUFFERVIEW_DESCRIPTOR_ERROR, "DS", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1890 | "vkUpdateDescriptorSets: Attempt to update descriptor with invalid bufferView %#" PRIxLEAST64, (uint64_t) *pBufferView); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1891 | } else { |
| 1892 | // TODO : Any further checks we want to do on the bufferView? |
| 1893 | } |
| 1894 | return skipCall; |
| 1895 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1896 | |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1897 | // Verify that given bufferInfo is valid |
| 1898 | static VkBool32 validateBufferInfo(const layer_data* my_data, const VkDescriptorBufferInfo* pBufferInfo) |
| 1899 | { |
| 1900 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1901 | auto sampIt = my_data->bufferMap.find(pBufferInfo->buffer); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1902 | if (sampIt == my_data->bufferMap.end()) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1903 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, (uint64_t) pBufferInfo->buffer, 0, DRAWSTATE_BUFFERINFO_DESCRIPTOR_ERROR, "DS", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1904 | "vkUpdateDescriptorSets: Attempt to update descriptor where bufferInfo has invalid buffer %#" PRIxLEAST64, (uint64_t) pBufferInfo->buffer); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1905 | } else { |
| 1906 | // TODO : Any further checks we want to do on the bufferView? |
| 1907 | } |
| 1908 | return skipCall; |
| 1909 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1910 | |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1911 | static VkBool32 validateUpdateContents(const layer_data* my_data, const VkWriteDescriptorSet *pWDS, const VkDescriptorSetLayoutBinding* pLayoutBinding) |
| 1912 | { |
| 1913 | VkBool32 skipCall = VK_FALSE; |
| 1914 | // First verify that for the given Descriptor type, the correct DescriptorInfo data is supplied |
| 1915 | VkBufferView* pBufferView = NULL; |
| 1916 | const VkSampler* pSampler = NULL; |
| 1917 | VkImageView* pImageView = NULL; |
| 1918 | VkImageLayout* pImageLayout = NULL; |
| 1919 | VkDescriptorBufferInfo* pBufferInfo = NULL; |
| 1920 | VkBool32 immutable = VK_FALSE; |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1921 | uint32_t i = 0; |
| 1922 | // For given update type, verify that update contents are correct |
| 1923 | switch (pWDS->descriptorType) { |
| 1924 | case VK_DESCRIPTOR_TYPE_SAMPLER: |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 1925 | for (i=0; i<pWDS->descriptorCount; ++i) { |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1926 | skipCall |= validateSampler(my_data, &(pWDS->pImageInfo[i].sampler), immutable); |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1927 | } |
| 1928 | break; |
| 1929 | case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 1930 | for (i=0; i<pWDS->descriptorCount; ++i) { |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1931 | if (NULL == pLayoutBinding->pImmutableSamplers) { |
| 1932 | pSampler = &(pWDS->pImageInfo[i].sampler); |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1933 | if (immutable) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1934 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, (uint64_t) *pSampler, 0, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS", |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1935 | "vkUpdateDescriptorSets: Update #%u is not an immutable sampler %#" PRIxLEAST64 ", but previous update(s) from this " |
| 1936 | "VkWriteDescriptorSet struct used an immutable sampler. All updates from a single struct must either " |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1937 | "use immutable or non-immutable samplers.", i, (uint64_t) *pSampler); |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1938 | } |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1939 | } else { |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1940 | if (i>0 && !immutable) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1941 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, (uint64_t) *pSampler, 0, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS", |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1942 | "vkUpdateDescriptorSets: Update #%u is an immutable sampler, but previous update(s) from this " |
| 1943 | "VkWriteDescriptorSet struct used a non-immutable sampler. All updates from a single struct must either " |
| 1944 | "use immutable or non-immutable samplers.", i); |
| 1945 | } |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1946 | immutable = VK_TRUE; |
| 1947 | pSampler = &(pLayoutBinding->pImmutableSamplers[i]); |
| 1948 | } |
| 1949 | skipCall |= validateSampler(my_data, pSampler, immutable); |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1950 | } |
| 1951 | // Intentionally fall through here to also validate image stuff |
| 1952 | case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: |
| 1953 | case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: |
| 1954 | case VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT: |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 1955 | for (i=0; i<pWDS->descriptorCount; ++i) { |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1956 | skipCall |= validateImageView(my_data, &(pWDS->pImageInfo[i].imageView), pWDS->pImageInfo[i].imageLayout); |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1957 | } |
| 1958 | break; |
| 1959 | case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: |
| 1960 | case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 1961 | for (i=0; i<pWDS->descriptorCount; ++i) { |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1962 | skipCall |= validateBufferView(my_data, &(pWDS->pTexelBufferView[i])); |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1963 | } |
| 1964 | break; |
| 1965 | case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: |
| 1966 | case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: |
| 1967 | case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: |
| 1968 | case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 1969 | for (i=0; i<pWDS->descriptorCount; ++i) { |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1970 | skipCall |= validateBufferInfo(my_data, &(pWDS->pBufferInfo[i])); |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1971 | } |
| 1972 | break; |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1973 | } |
| 1974 | return skipCall; |
| 1975 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 1976 | |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1977 | // update DS mappings based on write and copy update arrays |
Chia-I Wu | 483e770 | 2015-10-26 17:20:32 +0800 | [diff] [blame] | 1978 | static VkBool32 dsUpdate(layer_data* my_data, VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet* pWDS, uint32_t descriptorCopyCount, const VkCopyDescriptorSet* pCDS) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1979 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1980 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 8cd8ecd | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1981 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1982 | loader_platform_thread_lock_mutex(&globalLock); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 1983 | LAYOUT_NODE* pLayout = NULL; |
Courtney Goeltzenleuchter | 382489d | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 1984 | VkDescriptorSetLayoutCreateInfo* pLayoutCI = NULL; |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1985 | // Validate Write updates |
Tobin Ehlis | d2e246e | 2015-10-27 15:43:38 -0600 | [diff] [blame] | 1986 | uint32_t i = 0; |
Chia-I Wu | 483e770 | 2015-10-26 17:20:32 +0800 | [diff] [blame] | 1987 | for (i=0; i < descriptorWriteCount; i++) { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 1988 | VkDescriptorSet ds = pWDS[i].dstSet; |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 1989 | SET_NODE* pSet = my_data->setMap[ds]; |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 1990 | GENERIC_HEADER* pUpdate = (GENERIC_HEADER*) &pWDS[i]; |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 1991 | pLayout = pSet->pLayout; |
Tobin Ehlis | 0b551cd | 2015-05-28 12:10:17 -0600 | [diff] [blame] | 1992 | // First verify valid update struct |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 1993 | if ((skipCall = validUpdateStruct(my_data, device, pUpdate)) == VK_TRUE) { |
Tobin Ehlis | 0b551cd | 2015-05-28 12:10:17 -0600 | [diff] [blame] | 1994 | break; |
| 1995 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 1996 | uint32_t binding = 0, endIndex = 0; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 1997 | binding = pWDS[i].dstBinding; |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 1998 | // Make sure that layout being updated has the binding being updated |
Chia-I Wu | b5689ee | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 1999 | if (pLayout->bindings.find(binding) == pLayout->bindings.end()) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2000 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) ds, 0, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", |
Michael Lentine | cbc4a5e | 2015-11-03 16:19:46 -0800 | [diff] [blame] | 2001 | "Descriptor Set %" PRIu64 " does not have binding to match update binding %u for update type %s!", reinterpret_cast<uint64_t>(ds), binding, string_VkStructureType(pUpdate->sType)); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 2002 | } else { |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 2003 | // Next verify that update falls within size of given binding |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2004 | endIndex = getUpdateEndIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate); |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 2005 | if (getBindingEndIndex(pLayout, binding) < endIndex) { |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 2006 | pLayoutCI = &pLayout->createInfo; |
Courtney Goeltzenleuchter | 382489d | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 2007 | string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} "); |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2008 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) ds, 0, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS", |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 2009 | "Descriptor update type of %s is out of bounds for matching binding %u in Layout w/ CI:\n%s!", string_VkStructureType(pUpdate->sType), binding, DSstr.c_str()); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 2010 | } else { // TODO : should we skip update on a type mismatch or force it? |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 2011 | uint32_t startIndex; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2012 | startIndex = getUpdateStartIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate); |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 2013 | // Layout bindings match w/ update, now verify that update type & stageFlags are the same for entire update |
| 2014 | if ((skipCall = validateUpdateConsistency(my_data, device, pLayout, pUpdate, startIndex, endIndex)) == VK_FALSE) { |
| 2015 | // The update is within bounds and consistent, but need to make sure contents make sense as well |
Chia-I Wu | f03cbf7 | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 2016 | if ((skipCall = validateUpdateContents(my_data, &pWDS[i], &pLayout->createInfo.pBinding[binding])) == VK_FALSE) { |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 2017 | // Update is good. Save the update info |
| 2018 | // Create new update struct for this set's shadow copy |
| 2019 | GENERIC_HEADER* pNewNode = NULL; |
| 2020 | skipCall |= shadowUpdateNode(my_data, device, pUpdate, &pNewNode); |
| 2021 | if (NULL == pNewNode) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2022 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) ds, 0, DRAWSTATE_OUT_OF_MEMORY, "DS", |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 2023 | "Out of memory while attempting to allocate UPDATE struct in vkUpdateDescriptors()"); |
| 2024 | } else { |
| 2025 | // Insert shadow node into LL of updates for this set |
| 2026 | pNewNode->pNext = pSet->pUpdateStructs; |
| 2027 | pSet->pUpdateStructs = pNewNode; |
| 2028 | // Now update appropriate descriptor(s) to point to new Update node |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 2029 | for (uint32_t j = startIndex; j <= endIndex; j++) { |
| 2030 | assert(j<pSet->descriptorCount); |
| 2031 | pSet->ppDescriptors[j] = pNewNode; |
| 2032 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2033 | } |
| 2034 | } |
| 2035 | } |
| 2036 | } |
| 2037 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2038 | } |
Tobin Ehlis | d2e246e | 2015-10-27 15:43:38 -0600 | [diff] [blame] | 2039 | // Now validate copy updates |
Chia-I Wu | 483e770 | 2015-10-26 17:20:32 +0800 | [diff] [blame] | 2040 | for (i=0; i < descriptorCopyCount; ++i) { |
Tobin Ehlis | d2e246e | 2015-10-27 15:43:38 -0600 | [diff] [blame] | 2041 | SET_NODE *pSrcSet = NULL, *pDstSet = NULL; |
| 2042 | LAYOUT_NODE *pSrcLayout = NULL, *pDstLayout = NULL; |
| 2043 | uint32_t srcStartIndex = 0, srcEndIndex = 0, dstStartIndex = 0, dstEndIndex = 0; |
| 2044 | // For each copy make sure that update falls within given layout and that types match |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 2045 | pSrcSet = my_data->setMap[pCDS[i].srcSet]; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2046 | pDstSet = my_data->setMap[pCDS[i].dstSet]; |
Tobin Ehlis | d2e246e | 2015-10-27 15:43:38 -0600 | [diff] [blame] | 2047 | pSrcLayout = pSrcSet->pLayout; |
| 2048 | pDstLayout = pDstSet->pLayout; |
| 2049 | // Validate that src binding is valid for src set layout |
Chia-I Wu | b5689ee | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 2050 | if (pSrcLayout->bindings.find(pCDS[i].srcBinding) == pSrcLayout->bindings.end()) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2051 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pSrcSet->set, 0, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", |
Tobin Ehlis | d2e246e | 2015-10-27 15:43:38 -0600 | [diff] [blame] | 2052 | "Copy descriptor update %u has srcBinding %u which is out of bounds for underlying SetLayout %#" PRIxLEAST64 " which only has bindings 0-%u.", |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 2053 | i, pCDS[i].srcBinding, (uint64_t) pSrcLayout->layout, pSrcLayout->createInfo.bindingCount-1); |
Chia-I Wu | b5689ee | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 2054 | } else if (pDstLayout->bindings.find(pCDS[i].dstBinding) == pDstLayout->bindings.end()) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2055 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pDstSet->set, 0, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2056 | "Copy descriptor update %u has dstBinding %u which is out of bounds for underlying SetLayout %#" PRIxLEAST64 " which only has bindings 0-%u.", |
| 2057 | i, pCDS[i].dstBinding, (uint64_t) pDstLayout->layout, pDstLayout->createInfo.bindingCount-1); |
Tobin Ehlis | d2e246e | 2015-10-27 15:43:38 -0600 | [diff] [blame] | 2058 | } else { |
| 2059 | // Proceed with validation. Bindings are ok, but make sure update is within bounds of given layout |
| 2060 | srcEndIndex = getUpdateEndIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, (const GENERIC_HEADER*)&(pCDS[i])); |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2061 | dstEndIndex = getUpdateEndIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, (const GENERIC_HEADER*)&(pCDS[i])); |
Tobin Ehlis | d2e246e | 2015-10-27 15:43:38 -0600 | [diff] [blame] | 2062 | if (getBindingEndIndex(pSrcLayout, pCDS[i].srcBinding) < srcEndIndex) { |
| 2063 | pLayoutCI = &pSrcLayout->createInfo; |
| 2064 | string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} "); |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2065 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pSrcSet->set, 0, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS", |
Tobin Ehlis | d2e246e | 2015-10-27 15:43:38 -0600 | [diff] [blame] | 2066 | "Copy descriptor src update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", pCDS[i].srcBinding, DSstr.c_str()); |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2067 | } else if (getBindingEndIndex(pDstLayout, pCDS[i].dstBinding) < dstEndIndex) { |
Tobin Ehlis | d2e246e | 2015-10-27 15:43:38 -0600 | [diff] [blame] | 2068 | pLayoutCI = &pDstLayout->createInfo; |
| 2069 | string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} "); |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2070 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pDstSet->set, 0, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS", |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2071 | "Copy descriptor dest update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", pCDS[i].dstBinding, DSstr.c_str()); |
Tobin Ehlis | d2e246e | 2015-10-27 15:43:38 -0600 | [diff] [blame] | 2072 | } else { |
| 2073 | srcStartIndex = getUpdateStartIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, (const GENERIC_HEADER*)&(pCDS[i])); |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2074 | dstStartIndex = getUpdateStartIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, (const GENERIC_HEADER*)&(pCDS[i])); |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 2075 | for (uint32_t j=0; j<pCDS[i].descriptorCount; ++j) { |
Tobin Ehlis | d2e246e | 2015-10-27 15:43:38 -0600 | [diff] [blame] | 2076 | // For copy just make sure that the types match and then perform the update |
| 2077 | if (pSrcLayout->descriptorTypes[srcStartIndex+j] != pDstLayout->descriptorTypes[dstStartIndex+j]) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2078 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", |
Tobin Ehlis | d2e246e | 2015-10-27 15:43:38 -0600 | [diff] [blame] | 2079 | "Copy descriptor update index %u, update count #%u, has src update descriptor type %s that does not match overlapping dest descriptor type of %s!", |
| 2080 | i, j+1, string_VkDescriptorType(pSrcLayout->descriptorTypes[srcStartIndex+j]), string_VkDescriptorType(pDstLayout->descriptorTypes[dstStartIndex+j])); |
| 2081 | } else { |
| 2082 | // point dst descriptor at corresponding src descriptor |
| 2083 | pDstSet->ppDescriptors[j+dstStartIndex] = pSrcSet->ppDescriptors[j+srcStartIndex]; |
| 2084 | } |
| 2085 | } |
| 2086 | } |
| 2087 | } |
| 2088 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2089 | loader_platform_thread_unlock_mutex(&globalLock); |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 2090 | return skipCall; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2091 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 2092 | |
Tobin Ehlis | c6457d2 | 2015-10-20 16:16:04 -0600 | [diff] [blame] | 2093 | // Verify that given pool has descriptors that are being requested for allocation |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 2094 | static VkBool32 validate_descriptor_availability_in_pool(layer_data* dev_data, DESCRIPTOR_POOL_NODE* pPoolNode, uint32_t count, const VkDescriptorSetLayout* pSetLayouts) |
Tobin Ehlis | c6457d2 | 2015-10-20 16:16:04 -0600 | [diff] [blame] | 2095 | { |
| 2096 | VkBool32 skipCall = VK_FALSE; |
| 2097 | uint32_t i = 0, j = 0; |
| 2098 | for (i=0; i<count; ++i) { |
| 2099 | LAYOUT_NODE* pLayout = getLayoutNode(dev_data, pSetLayouts[i]); |
| 2100 | if (NULL == pLayout) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2101 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t) pSetLayouts[i], 0, DRAWSTATE_INVALID_LAYOUT, "DS", |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2102 | "Unable to find set layout node for layout %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", (uint64_t) pSetLayouts[i]); |
Tobin Ehlis | c6457d2 | 2015-10-20 16:16:04 -0600 | [diff] [blame] | 2103 | } else { |
Chia-I Wu | c51b121 | 2015-10-27 19:25:11 +0800 | [diff] [blame] | 2104 | uint32_t typeIndex = 0, poolSizeCount = 0; |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 2105 | for (j=0; j<pLayout->createInfo.bindingCount; ++j) { |
Chia-I Wu | f03cbf7 | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 2106 | typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBinding[j].descriptorType); |
Chia-I Wu | 045654f | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2107 | poolSizeCount = pLayout->createInfo.pBinding[j].descriptorCount; |
Chia-I Wu | c51b121 | 2015-10-27 19:25:11 +0800 | [diff] [blame] | 2108 | if (poolSizeCount > pPoolNode->availableDescriptorTypeCount[typeIndex]) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2109 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t) pLayout->layout, 0, DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS", |
Tobin Ehlis | c6457d2 | 2015-10-20 16:16:04 -0600 | [diff] [blame] | 2110 | "Unable to allocate %u descriptors of type %s from pool %#" PRIxLEAST64 ". This pool only has %u descriptors of this type remaining.", |
Chia-I Wu | f03cbf7 | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 2111 | poolSizeCount, string_VkDescriptorType(pLayout->createInfo.pBinding[j].descriptorType), (uint64_t) pPoolNode->pool, pPoolNode->availableDescriptorTypeCount[typeIndex]); |
Tobin Ehlis | c6457d2 | 2015-10-20 16:16:04 -0600 | [diff] [blame] | 2112 | } else { // Decrement available descriptors of this type |
Chia-I Wu | c51b121 | 2015-10-27 19:25:11 +0800 | [diff] [blame] | 2113 | pPoolNode->availableDescriptorTypeCount[typeIndex] -= poolSizeCount; |
Tobin Ehlis | c6457d2 | 2015-10-20 16:16:04 -0600 | [diff] [blame] | 2114 | } |
| 2115 | } |
| 2116 | } |
| 2117 | } |
| 2118 | return skipCall; |
| 2119 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 2120 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2121 | // Free the shadowed update node for this Set |
| 2122 | // NOTE : Calls to this function should be wrapped in mutex |
| 2123 | static void freeShadowUpdateTree(SET_NODE* pSet) |
| 2124 | { |
| 2125 | GENERIC_HEADER* pShadowUpdate = pSet->pUpdateStructs; |
| 2126 | pSet->pUpdateStructs = NULL; |
| 2127 | GENERIC_HEADER* pFreeUpdate = pShadowUpdate; |
| 2128 | // Clear the descriptor mappings as they will now be invalid |
| 2129 | memset(pSet->ppDescriptors, 0, pSet->descriptorCount*sizeof(GENERIC_HEADER*)); |
| 2130 | while(pShadowUpdate) { |
| 2131 | pFreeUpdate = pShadowUpdate; |
| 2132 | pShadowUpdate = (GENERIC_HEADER*)pShadowUpdate->pNext; |
| 2133 | uint32_t index = 0; |
Chia-I Wu | 8cd8ecd | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 2134 | VkWriteDescriptorSet * pWDS = NULL; |
| 2135 | VkCopyDescriptorSet * pCDS = NULL; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2136 | void** ppToFree = NULL; |
| 2137 | switch (pFreeUpdate->sType) |
| 2138 | { |
Chia-I Wu | 8cd8ecd | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 2139 | case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: |
| 2140 | pWDS = (VkWriteDescriptorSet*)pFreeUpdate; |
Tony Barbour | f740f90 | 2015-11-02 11:46:29 -0700 | [diff] [blame] | 2141 | switch (pWDS->descriptorType) { |
| 2142 | case VK_DESCRIPTOR_TYPE_SAMPLER: |
| 2143 | case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: |
| 2144 | case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: |
| 2145 | case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: |
| 2146 | { |
| 2147 | delete[] pWDS->pImageInfo; |
| 2148 | } |
| 2149 | break; |
| 2150 | case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: |
| 2151 | case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: |
| 2152 | { |
| 2153 | delete[] pWDS->pTexelBufferView; |
| 2154 | } |
| 2155 | break; |
| 2156 | case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: |
| 2157 | case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: |
| 2158 | case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: |
| 2159 | case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: |
| 2160 | { |
| 2161 | delete[] pWDS->pBufferInfo; |
| 2162 | } |
| 2163 | break; |
| 2164 | default: |
| 2165 | break; |
Courtney Goeltzenleuchter | e409974 | 2015-10-22 15:31:56 -0600 | [diff] [blame] | 2166 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2167 | break; |
Chia-I Wu | 8cd8ecd | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 2168 | case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2169 | break; |
| 2170 | default: |
| 2171 | assert(0); |
| 2172 | break; |
| 2173 | } |
Tobin Ehlis | eaf2866 | 2015-04-08 10:58:37 -0600 | [diff] [blame] | 2174 | delete pFreeUpdate; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2175 | } |
| 2176 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 2177 | |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 2178 | // Free all DS Pools including their Sets & related sub-structs |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2179 | // NOTE : Calls to this function should be wrapped in mutex |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 2180 | static void deletePools(layer_data* my_data) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2181 | { |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 2182 | if (my_data->descriptorPoolMap.size() <= 0) |
David Pinedo | f5997ab | 2015-04-27 16:36:17 -0600 | [diff] [blame] | 2183 | return; |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 2184 | for (auto ii=my_data->descriptorPoolMap.begin(); ii!=my_data->descriptorPoolMap.end(); ++ii) { |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2185 | SET_NODE* pSet = (*ii).second->pSets; |
| 2186 | SET_NODE* pFreeSet = pSet; |
| 2187 | while (pSet) { |
| 2188 | pFreeSet = pSet; |
| 2189 | pSet = pSet->pNext; |
Tobin Ehlis | eaf2866 | 2015-04-08 10:58:37 -0600 | [diff] [blame] | 2190 | // Freeing layouts handled in deleteLayouts() function |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2191 | // Free Update shadow struct tree |
| 2192 | freeShadowUpdateTree(pFreeSet); |
| 2193 | if (pFreeSet->ppDescriptors) { |
Chris Forbes | 4506d3f | 2015-06-04 10:49:27 +1200 | [diff] [blame] | 2194 | delete[] pFreeSet->ppDescriptors; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2195 | } |
| 2196 | delete pFreeSet; |
| 2197 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2198 | delete (*ii).second; |
| 2199 | } |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 2200 | my_data->descriptorPoolMap.clear(); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2201 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 2202 | |
Tobin Ehlis | eaf2866 | 2015-04-08 10:58:37 -0600 | [diff] [blame] | 2203 | // WARN : Once deleteLayouts() called, any layout ptrs in Pool/Set data structure will be invalid |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2204 | // NOTE : Calls to this function should be wrapped in mutex |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 2205 | static void deleteLayouts(layer_data* my_data) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2206 | { |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 2207 | if (my_data->descriptorSetLayoutMap.size() <= 0) |
David Pinedo | f5997ab | 2015-04-27 16:36:17 -0600 | [diff] [blame] | 2208 | return; |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 2209 | for (auto ii=my_data->descriptorSetLayoutMap.begin(); ii!=my_data->descriptorSetLayoutMap.end(); ++ii) { |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2210 | LAYOUT_NODE* pLayout = (*ii).second; |
Chia-I Wu | f03cbf7 | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 2211 | if (pLayout->createInfo.pBinding) { |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 2212 | for (uint32_t i=0; i<pLayout->createInfo.bindingCount; i++) { |
Chia-I Wu | f03cbf7 | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 2213 | if (pLayout->createInfo.pBinding[i].pImmutableSamplers) |
| 2214 | delete[] pLayout->createInfo.pBinding[i].pImmutableSamplers; |
Tobin Ehlis | eaf2866 | 2015-04-08 10:58:37 -0600 | [diff] [blame] | 2215 | } |
Chia-I Wu | f03cbf7 | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 2216 | delete[] pLayout->createInfo.pBinding; |
Tobin Ehlis | eaf2866 | 2015-04-08 10:58:37 -0600 | [diff] [blame] | 2217 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2218 | delete pLayout; |
| 2219 | } |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 2220 | my_data->descriptorSetLayoutMap.clear(); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2221 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 2222 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2223 | // Currently clearing a set is removing all previous updates to that set |
| 2224 | // TODO : Validate if this is correct clearing behavior |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 2225 | static void clearDescriptorSet(layer_data* my_data, VkDescriptorSet set) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2226 | { |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 2227 | SET_NODE* pSet = getSetNode(my_data, set); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2228 | if (!pSet) { |
| 2229 | // TODO : Return error |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 2230 | } else { |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2231 | loader_platform_thread_lock_mutex(&globalLock); |
| 2232 | freeShadowUpdateTree(pSet); |
| 2233 | loader_platform_thread_unlock_mutex(&globalLock); |
| 2234 | } |
| 2235 | } |
| 2236 | |
Courtney Goeltzenleuchter | 831c183 | 2015-10-23 14:21:05 -0600 | [diff] [blame] | 2237 | static void clearDescriptorPool(layer_data* my_data, const VkDevice device, const VkDescriptorPool pool, VkDescriptorPoolResetFlags flags) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2238 | { |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 2239 | DESCRIPTOR_POOL_NODE* pPool = getPoolNode(my_data, pool); |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 2240 | if (!pPool) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2241 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, (uint64_t) pool, 0, DRAWSTATE_INVALID_POOL, "DS", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 2242 | "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkResetDescriptorPool() call", (uint64_t) pool); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 2243 | } else { |
Courtney Goeltzenleuchter | 831c183 | 2015-10-23 14:21:05 -0600 | [diff] [blame] | 2244 | // TODO: validate flags |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 2245 | // For every set off of this pool, clear it |
| 2246 | SET_NODE* pSet = pPool->pSets; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2247 | while (pSet) { |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 2248 | clearDescriptorSet(my_data, pSet->set); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2249 | } |
Tobin Ehlis | c6457d2 | 2015-10-20 16:16:04 -0600 | [diff] [blame] | 2250 | // Reset available count to max count for this pool |
| 2251 | for (uint32_t i=0; i<pPool->availableDescriptorTypeCount.size(); ++i) { |
| 2252 | pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; |
| 2253 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2254 | } |
| 2255 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 2256 | |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 2257 | // For given CB object, fetch associated CB Node from map |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2258 | static GLOBAL_CB_NODE* getCBNode(layer_data* my_data, const VkCommandBuffer cb) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2259 | { |
| 2260 | loader_platform_thread_lock_mutex(&globalLock); |
Mark Lobodzinski | 13b6674 | 2015-11-20 14:33:48 -0700 | [diff] [blame] | 2261 | if (my_data->commandBufferMap.count(cb) == 0) { |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2262 | loader_platform_thread_unlock_mutex(&globalLock); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2263 | // TODO : How to pass cb as srcObj here? |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2264 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2265 | "Attempt to use CommandBuffer %#" PRIxLEAST64 " that doesn't exist!", reinterpret_cast<uint64_t>(cb)); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2266 | return NULL; |
| 2267 | } |
| 2268 | loader_platform_thread_unlock_mutex(&globalLock); |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2269 | return my_data->commandBufferMap[cb]; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2270 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 2271 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2272 | // Free all CB Nodes |
| 2273 | // NOTE : Calls to this function should be wrapped in mutex |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2274 | static void deleteCommandBuffers(layer_data* my_data) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2275 | { |
Mark Lobodzinski | 13b6674 | 2015-11-20 14:33:48 -0700 | [diff] [blame] | 2276 | if (my_data->commandBufferMap.size() <= 0) { |
David Pinedo | f5997ab | 2015-04-27 16:36:17 -0600 | [diff] [blame] | 2277 | return; |
Mark Lobodzinski | 13b6674 | 2015-11-20 14:33:48 -0700 | [diff] [blame] | 2278 | } |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2279 | for (auto ii=my_data->commandBufferMap.begin(); ii!=my_data->commandBufferMap.end(); ++ii) { |
Courtney Goeltzenleuchter | 09098a7 | 2015-04-27 15:04:43 -0600 | [diff] [blame] | 2280 | vector<CMD_NODE*> cmd_node_list = (*ii).second->pCmds; |
| 2281 | while (!cmd_node_list.empty()) { |
| 2282 | CMD_NODE* cmd_node = cmd_node_list.back(); |
| 2283 | delete cmd_node; |
| 2284 | cmd_node_list.pop_back(); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2285 | } |
| 2286 | delete (*ii).second; |
| 2287 | } |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2288 | my_data->commandBufferMap.clear(); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2289 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 2290 | |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2291 | static VkBool32 report_error_no_cb_begin(const layer_data* dev_data, const VkCommandBuffer cb, const char* caller_name) |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 2292 | { |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2293 | // TODO : How to pass cb as srcObj here? |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2294 | return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS", |
Michael Lentine | cbc4a5e | 2015-11-03 16:19:46 -0800 | [diff] [blame] | 2295 | "You must call vkBeginCommandBuffer() before this call to %s", caller_name); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 2296 | } |
Michael Lentine | 2b9eda4 | 2015-10-28 15:55:18 -0700 | [diff] [blame] | 2297 | |
| 2298 | bool validateCmdsInCmdBuffer(const layer_data* dev_data, const GLOBAL_CB_NODE* pCB, const CMD_TYPE cmd_type) { |
| 2299 | bool skip_call = false; |
| 2300 | for (auto cmd : pCB->pCmds) { |
| 2301 | if (cmd_type == CMD_EXECUTECOMMANDS && cmd->type != CMD_EXECUTECOMMANDS) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2302 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
Michael Lentine | 2b9eda4 | 2015-10-28 15:55:18 -0700 | [diff] [blame] | 2303 | "vkCmdExecuteCommands() cannot be called on a cmd buffer with exsiting commands."); |
| 2304 | } |
| 2305 | if (cmd_type != CMD_EXECUTECOMMANDS && cmd->type == CMD_EXECUTECOMMANDS) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2306 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
Michael Lentine | 2b9eda4 | 2015-10-28 15:55:18 -0700 | [diff] [blame] | 2307 | "Commands cannot be added to a cmd buffer with exsiting secondary commands."); |
| 2308 | } |
| 2309 | } |
| 2310 | return skip_call; |
| 2311 | } |
| 2312 | |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 2313 | static VkBool32 addCmd(const layer_data* my_data, GLOBAL_CB_NODE* pCB, const CMD_TYPE cmd) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2314 | { |
Michael Lentine | 2b9eda4 | 2015-10-28 15:55:18 -0700 | [diff] [blame] | 2315 | VkBool32 skipCall = validateCmdsInCmdBuffer(my_data, pCB, cmd); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2316 | CMD_NODE* pCmd = new CMD_NODE; |
| 2317 | if (pCmd) { |
| 2318 | // init cmd node and append to end of cmd LL |
| 2319 | memset(pCmd, 0, sizeof(CMD_NODE)); |
| 2320 | pCmd->cmdNumber = ++pCB->numCmds; |
| 2321 | pCmd->type = cmd; |
| 2322 | pCB->pCmds.push_back(pCmd); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 2323 | } else { |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2324 | // TODO : How to pass cb as srcObj here? |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2325 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_OUT_OF_MEMORY, "DS", |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2326 | "Out of memory while attempting to allocate new CMD_NODE for commandBuffer %#" PRIxLEAST64, reinterpret_cast<uint64_t>(pCB->commandBuffer)); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2327 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 2328 | return skipCall; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2329 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 2330 | |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2331 | static void resetCB(layer_data* my_data, const VkCommandBuffer cb) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2332 | { |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 2333 | GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2334 | if (pCB) { |
Courtney Goeltzenleuchter | f03711e | 2015-04-27 17:16:56 -0600 | [diff] [blame] | 2335 | vector<CMD_NODE*> cmd_list = pCB->pCmds; |
| 2336 | while (!cmd_list.empty()) { |
| 2337 | delete cmd_list.back(); |
| 2338 | cmd_list.pop_back(); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2339 | } |
Courtney Goeltzenleuchter | f03711e | 2015-04-27 17:16:56 -0600 | [diff] [blame] | 2340 | pCB->pCmds.clear(); |
Tobin Ehlis | 0cea408 | 2015-08-18 07:10:58 -0600 | [diff] [blame] | 2341 | // Reset CB state (need to save createInfo) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2342 | VkCommandBufferAllocateInfo saveCBCI = pCB->createInfo; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2343 | pCB->commandBuffer = cb; |
Tobin Ehlis | 0cea408 | 2015-08-18 07:10:58 -0600 | [diff] [blame] | 2344 | pCB->createInfo = saveCBCI; |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 2345 | memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); |
| 2346 | pCB->fence = 0; |
| 2347 | pCB->numCmds = 0; |
| 2348 | memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t)); |
| 2349 | pCB->state = CB_NEW; |
| 2350 | pCB->submitCount = 0; |
| 2351 | pCB->status = 0; |
| 2352 | pCB->pCmds.clear(); |
| 2353 | pCB->lastBoundPipeline = 0; |
| 2354 | pCB->viewports.clear(); |
| 2355 | pCB->scissors.clear(); |
| 2356 | pCB->lineWidth = 0; |
| 2357 | pCB->depthBiasConstantFactor = 0; |
| 2358 | pCB->depthBiasClamp = 0; |
| 2359 | pCB->depthBiasSlopeFactor = 0; |
| 2360 | memset(pCB->blendConstants, 0, 4 * sizeof(float)); |
| 2361 | pCB->minDepthBounds = 0; |
| 2362 | pCB->maxDepthBounds = 0; |
| 2363 | memset(&pCB->front, 0, sizeof(stencil_data)); |
| 2364 | memset(&pCB->back, 0, sizeof(stencil_data)); |
| 2365 | pCB->lastBoundDescriptorSet = 0; |
| 2366 | pCB->lastBoundPipelineLayout = 0; |
| 2367 | pCB->activeRenderPass = 0; |
| 2368 | pCB->activeSubpass = 0; |
| 2369 | pCB->framebuffer = 0; |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 2370 | pCB->boundDescriptorSets.clear(); |
| 2371 | pCB->imageLayoutMap.clear(); |
Mark Lobodzinski | 74e8469 | 2015-12-14 15:14:10 -0700 | [diff] [blame] | 2372 | pCB->boundVtxBuffers.clear(); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2373 | } |
| 2374 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 2375 | |
Tobin Ehlis | f6cb467 | 2015-09-29 08:18:34 -0600 | [diff] [blame] | 2376 | // Set PSO-related status bits for CB, including dynamic state set via PSO |
Tobin Ehlis | 9786620 | 2015-06-10 12:57:07 -0600 | [diff] [blame] | 2377 | static void set_cb_pso_status(GLOBAL_CB_NODE* pCB, const PIPELINE_NODE* pPipe) |
| 2378 | { |
| 2379 | for (uint32_t i = 0; i < pPipe->cbStateCI.attachmentCount; i++) { |
Chia-I Wu | c51b121 | 2015-10-27 19:25:11 +0800 | [diff] [blame] | 2380 | if (0 != pPipe->pAttachments[i].colorWriteMask) { |
Tobin Ehlis | 9786620 | 2015-06-10 12:57:07 -0600 | [diff] [blame] | 2381 | pCB->status |= CBSTATUS_COLOR_BLEND_WRITE_ENABLE; |
| 2382 | } |
| 2383 | } |
| 2384 | if (pPipe->dsStateCI.depthWriteEnable) { |
Cody Northrop | 2605cb0 | 2015-08-18 15:21:16 -0600 | [diff] [blame] | 2385 | pCB->status |= CBSTATUS_DEPTH_WRITE_ENABLE; |
| 2386 | } |
Cody Northrop | 2605cb0 | 2015-08-18 15:21:16 -0600 | [diff] [blame] | 2387 | if (pPipe->dsStateCI.stencilTestEnable) { |
| 2388 | pCB->status |= CBSTATUS_STENCIL_TEST_ENABLE; |
Tobin Ehlis | 9786620 | 2015-06-10 12:57:07 -0600 | [diff] [blame] | 2389 | } |
Tobin Ehlis | a88e2f5 | 2015-10-02 11:00:56 -0600 | [diff] [blame] | 2390 | // Account for any dynamic state not set via this PSO |
| 2391 | if (!pPipe->dynStateCI.dynamicStateCount) { // All state is static |
| 2392 | pCB->status = CBSTATUS_ALL; |
| 2393 | } else { |
Tobin Ehlis | 3dec46c | 2015-10-01 09:24:40 -0600 | [diff] [blame] | 2394 | // First consider all state on |
| 2395 | // Then unset any state that's noted as dynamic in PSO |
| 2396 | // Finally OR that into CB statemask |
| 2397 | CBStatusFlags psoDynStateMask = CBSTATUS_ALL; |
Tobin Ehlis | f6cb467 | 2015-09-29 08:18:34 -0600 | [diff] [blame] | 2398 | for (uint32_t i=0; i < pPipe->dynStateCI.dynamicStateCount; i++) { |
| 2399 | switch (pPipe->dynStateCI.pDynamicStates[i]) { |
| 2400 | case VK_DYNAMIC_STATE_VIEWPORT: |
Tobin Ehlis | 3dec46c | 2015-10-01 09:24:40 -0600 | [diff] [blame] | 2401 | psoDynStateMask &= ~CBSTATUS_VIEWPORT_SET; |
Tobin Ehlis | f6cb467 | 2015-09-29 08:18:34 -0600 | [diff] [blame] | 2402 | break; |
| 2403 | case VK_DYNAMIC_STATE_SCISSOR: |
Tobin Ehlis | 3dec46c | 2015-10-01 09:24:40 -0600 | [diff] [blame] | 2404 | psoDynStateMask &= ~CBSTATUS_SCISSOR_SET; |
Tobin Ehlis | f6cb467 | 2015-09-29 08:18:34 -0600 | [diff] [blame] | 2405 | break; |
| 2406 | case VK_DYNAMIC_STATE_LINE_WIDTH: |
Tobin Ehlis | 3dec46c | 2015-10-01 09:24:40 -0600 | [diff] [blame] | 2407 | psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET; |
Tobin Ehlis | f6cb467 | 2015-09-29 08:18:34 -0600 | [diff] [blame] | 2408 | break; |
| 2409 | case VK_DYNAMIC_STATE_DEPTH_BIAS: |
Tobin Ehlis | 3dec46c | 2015-10-01 09:24:40 -0600 | [diff] [blame] | 2410 | psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET; |
Tobin Ehlis | f6cb467 | 2015-09-29 08:18:34 -0600 | [diff] [blame] | 2411 | break; |
| 2412 | case VK_DYNAMIC_STATE_BLEND_CONSTANTS: |
Tobin Ehlis | 3dec46c | 2015-10-01 09:24:40 -0600 | [diff] [blame] | 2413 | psoDynStateMask &= ~CBSTATUS_BLEND_SET; |
Tobin Ehlis | f6cb467 | 2015-09-29 08:18:34 -0600 | [diff] [blame] | 2414 | break; |
| 2415 | case VK_DYNAMIC_STATE_DEPTH_BOUNDS: |
Tobin Ehlis | 3dec46c | 2015-10-01 09:24:40 -0600 | [diff] [blame] | 2416 | psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET; |
Tobin Ehlis | f6cb467 | 2015-09-29 08:18:34 -0600 | [diff] [blame] | 2417 | break; |
| 2418 | case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: |
Tobin Ehlis | 3dec46c | 2015-10-01 09:24:40 -0600 | [diff] [blame] | 2419 | psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET; |
Tobin Ehlis | f6cb467 | 2015-09-29 08:18:34 -0600 | [diff] [blame] | 2420 | break; |
| 2421 | case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: |
Tobin Ehlis | 3dec46c | 2015-10-01 09:24:40 -0600 | [diff] [blame] | 2422 | psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; |
Tobin Ehlis | f6cb467 | 2015-09-29 08:18:34 -0600 | [diff] [blame] | 2423 | break; |
| 2424 | case VK_DYNAMIC_STATE_STENCIL_REFERENCE: |
Tobin Ehlis | 3dec46c | 2015-10-01 09:24:40 -0600 | [diff] [blame] | 2425 | psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET; |
Tobin Ehlis | f6cb467 | 2015-09-29 08:18:34 -0600 | [diff] [blame] | 2426 | break; |
| 2427 | default: |
| 2428 | // TODO : Flag error here |
| 2429 | break; |
| 2430 | } |
| 2431 | } |
Tobin Ehlis | 3dec46c | 2015-10-01 09:24:40 -0600 | [diff] [blame] | 2432 | pCB->status |= psoDynStateMask; |
Tobin Ehlis | f6cb467 | 2015-09-29 08:18:34 -0600 | [diff] [blame] | 2433 | } |
Tobin Ehlis | 9786620 | 2015-06-10 12:57:07 -0600 | [diff] [blame] | 2434 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 2435 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2436 | // Print the last bound Gfx Pipeline |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2437 | static VkBool32 printPipeline(layer_data* my_data, const VkCommandBuffer cb) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2438 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 2439 | VkBool32 skipCall = VK_FALSE; |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 2440 | GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2441 | if (pCB) { |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 2442 | PIPELINE_NODE *pPipeTrav = getPipeline(my_data, pCB->lastBoundPipeline); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2443 | if (!pPipeTrav) { |
| 2444 | // nothing to print |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 2445 | } else { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2446 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS", |
Michael Lentine | cbc4a5e | 2015-11-03 16:19:46 -0800 | [diff] [blame] | 2447 | "%s", vk_print_vkgraphicspipelinecreateinfo(&pPipeTrav->graphicsPipelineCI, "{DS}").c_str()); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2448 | } |
| 2449 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 2450 | return skipCall; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2451 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 2452 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2453 | // Print details of DS config to stdout |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2454 | static VkBool32 printDSConfig(layer_data* my_data, const VkCommandBuffer cb) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2455 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 2456 | VkBool32 skipCall = VK_FALSE; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2457 | char ds_config_str[1024*256] = {0}; // TODO : Currently making this buffer HUGE w/o overrun protection. Need to be smarter, start smaller, and grow as needed. |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 2458 | GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb); |
Tobin Ehlis | 7297f19 | 2015-06-09 08:39:32 -0600 | [diff] [blame] | 2459 | if (pCB && pCB->lastBoundDescriptorSet) { |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 2460 | SET_NODE* pSet = getSetNode(my_data, pCB->lastBoundDescriptorSet); |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 2461 | DESCRIPTOR_POOL_NODE* pPool = getPoolNode(my_data, pSet->pool); |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 2462 | // Print out pool details |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2463 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 2464 | "Details for pool %#" PRIxLEAST64 ".", (uint64_t) pPool->pool); |
Courtney Goeltzenleuchter | 382489d | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 2465 | string poolStr = vk_print_vkdescriptorpoolcreateinfo(&pPool->createInfo, " "); |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2466 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS", |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 2467 | "%s", poolStr.c_str()); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2468 | // Print out set details |
| 2469 | char prefix[10]; |
| 2470 | uint32_t index = 0; |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2471 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 2472 | "Details for descriptor set %#" PRIxLEAST64 ".", (uint64_t) pSet->set); |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 2473 | LAYOUT_NODE* pLayout = pSet->pLayout; |
| 2474 | // Print layout details |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2475 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS", |
Michael Lentine | cbc4a5e | 2015-11-03 16:19:46 -0800 | [diff] [blame] | 2476 | "Layout #%u, (object %#" PRIxLEAST64 ") for DS %#" PRIxLEAST64 ".", index+1, reinterpret_cast<uint64_t>(pLayout->layout), reinterpret_cast<uint64_t>(pSet->set)); |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 2477 | sprintf(prefix, " [L%u] ", index); |
Courtney Goeltzenleuchter | 382489d | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 2478 | string DSLstr = vk_print_vkdescriptorsetlayoutcreateinfo(&pLayout->createInfo, prefix).c_str(); |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2479 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS", |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 2480 | "%s", DSLstr.c_str()); |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 2481 | index++; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2482 | GENERIC_HEADER* pUpdate = pSet->pUpdateStructs; |
| 2483 | if (pUpdate) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2484 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 2485 | "Update Chain [UC] for descriptor set %#" PRIxLEAST64 ":", (uint64_t) pSet->set); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2486 | sprintf(prefix, " [UC] "); |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2487 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS", |
Michael Lentine | cbc4a5e | 2015-11-03 16:19:46 -0800 | [diff] [blame] | 2488 | "%s", dynamic_display(pUpdate, prefix).c_str()); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2489 | // TODO : If there is a "view" associated with this update, print CI for that view |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 2490 | } else { |
Tobin Ehlis | 2bca8b0 | 2015-06-15 08:41:17 -0600 | [diff] [blame] | 2491 | if (0 != pSet->descriptorCount) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2492 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 2493 | "No Update Chain for descriptor set %#" PRIxLEAST64 " which has %u descriptors (vkUpdateDescriptors has not been called)", (uint64_t) pSet->set, pSet->descriptorCount); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 2494 | } else { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2495 | skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 2496 | "FYI: No descriptors in descriptor set %#" PRIxLEAST64 ".", (uint64_t) pSet->set); |
Tobin Ehlis | 2bca8b0 | 2015-06-15 08:41:17 -0600 | [diff] [blame] | 2497 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2498 | } |
| 2499 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 2500 | return skipCall; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2501 | } |
| 2502 | |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2503 | static void printCB(layer_data* my_data, const VkCommandBuffer cb) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2504 | { |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 2505 | GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb); |
David Pinedo | f5997ab | 2015-04-27 16:36:17 -0600 | [diff] [blame] | 2506 | if (pCB && pCB->pCmds.size() > 0) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2507 | log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS", |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 2508 | "Cmds in CB %p", (void*)cb); |
Courtney Goeltzenleuchter | cf2a536 | 2015-04-27 11:16:35 -0600 | [diff] [blame] | 2509 | vector<CMD_NODE*> pCmds = pCB->pCmds; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2510 | for (auto ii=pCmds.begin(); ii!=pCmds.end(); ++ii) { |
| 2511 | // TODO : Need to pass cb as srcObj here |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2512 | log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_NONE, "DS", |
Michael Lentine | cbc4a5e | 2015-11-03 16:19:46 -0800 | [diff] [blame] | 2513 | " CMD#%" PRIu64 ": %s", (*ii)->cmdNumber, cmdTypeToString((*ii)->type).c_str()); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2514 | } |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 2515 | } else { |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2516 | // Nothing to print |
| 2517 | } |
| 2518 | } |
| 2519 | |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2520 | static VkBool32 synchAndPrintDSConfig(layer_data* my_data, const VkCommandBuffer cb) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2521 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 2522 | VkBool32 skipCall = VK_FALSE; |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2523 | if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFO_BIT_EXT)) { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 2524 | return skipCall; |
Mike Stroyan | fa2f222 | 2015-08-12 17:11:28 -0600 | [diff] [blame] | 2525 | } |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 2526 | skipCall |= printDSConfig(my_data, cb); |
| 2527 | skipCall |= printPipeline(my_data, cb); |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 2528 | return skipCall; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2529 | } |
| 2530 | |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 2531 | // Flags validation error if the associated call is made inside a render pass. The apiName |
| 2532 | // routine should ONLY be called outside a render pass. |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 2533 | static VkBool32 insideRenderPass(const layer_data* my_data, GLOBAL_CB_NODE *pCB, const char *apiName) |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 2534 | { |
| 2535 | VkBool32 inside = VK_FALSE; |
| 2536 | if (pCB->activeRenderPass) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2537 | inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2538 | (uint64_t)pCB->commandBuffer, 0, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 2539 | "%s: It is invalid to issue this call inside an active render pass (%#" PRIxLEAST64 ")", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 2540 | apiName, (uint64_t) pCB->activeRenderPass); |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 2541 | } |
| 2542 | return inside; |
| 2543 | } |
| 2544 | |
| 2545 | // Flags validation error if the associated call is made outside a render pass. The apiName |
| 2546 | // routine should ONLY be called inside a render pass. |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 2547 | static VkBool32 outsideRenderPass(const layer_data* my_data, GLOBAL_CB_NODE *pCB, const char *apiName) |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 2548 | { |
| 2549 | VkBool32 outside = VK_FALSE; |
| 2550 | if (!pCB->activeRenderPass) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2551 | outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2552 | (uint64_t)pCB->commandBuffer, 0, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 2553 | "%s: This call must be issued inside an active render pass.", apiName); |
| 2554 | } |
| 2555 | return outside; |
| 2556 | } |
| 2557 | |
Courtney Goeltzenleuchter | b03a0bf | 2015-11-25 14:31:49 -0700 | [diff] [blame] | 2558 | static void init_draw_state(layer_data *my_data, const VkAllocationCallbacks *pAllocator) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2559 | { |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 2560 | uint32_t report_flags = 0; |
| 2561 | uint32_t debug_action = 0; |
| 2562 | FILE *log_output = NULL; |
| 2563 | const char *option_str; |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2564 | VkDebugReportCallbackEXT callback; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2565 | // initialize DrawState options |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 2566 | report_flags = getLayerOptionFlags("DrawStateReportFlags", 0); |
| 2567 | getLayerOptionEnum("DrawStateDebugAction", (uint32_t *) &debug_action); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2568 | |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 2569 | if (debug_action & VK_DBG_LAYER_ACTION_LOG_MSG) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2570 | { |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 2571 | option_str = getLayerOption("DrawStateLogFilename"); |
Tobin Ehlis | b4b6e7c | 2015-09-15 09:55:54 -0600 | [diff] [blame] | 2572 | log_output = getLayerLogOutput(option_str, "DrawState"); |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2573 | VkDebugReportCallbackCreateInfoEXT dbgInfo; |
Courtney Goeltzenleuchter | f6a6e22 | 2015-11-30 12:13:14 -0700 | [diff] [blame] | 2574 | memset(&dbgInfo, 0, sizeof(dbgInfo)); |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2575 | dbgInfo.sType = VK_STRUCTURE_TYPE_DEBUG_REPORT_CREATE_INFO_EXT; |
Courtney Goeltzenleuchter | f6a6e22 | 2015-11-30 12:13:14 -0700 | [diff] [blame] | 2576 | dbgInfo.pfnCallback = log_callback; |
| 2577 | dbgInfo.pUserData = log_output; |
| 2578 | dbgInfo.flags = report_flags; |
| 2579 | layer_create_msg_callback(my_data->report_data, &dbgInfo, pAllocator, &callback); |
Courtney Goeltzenleuchter | 1781b1c | 2015-10-05 15:58:38 -0600 | [diff] [blame] | 2580 | my_data->logging_callback.push_back(callback); |
| 2581 | } |
| 2582 | |
| 2583 | if (debug_action & VK_DBG_LAYER_ACTION_DEBUG_OUTPUT) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2584 | VkDebugReportCallbackCreateInfoEXT dbgInfo; |
Courtney Goeltzenleuchter | f6a6e22 | 2015-11-30 12:13:14 -0700 | [diff] [blame] | 2585 | memset(&dbgInfo, 0, sizeof(dbgInfo)); |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2586 | dbgInfo.sType = VK_STRUCTURE_TYPE_DEBUG_REPORT_CREATE_INFO_EXT; |
Courtney Goeltzenleuchter | f6a6e22 | 2015-11-30 12:13:14 -0700 | [diff] [blame] | 2587 | dbgInfo.pfnCallback = win32_debug_output_msg; |
| 2588 | dbgInfo.pUserData = log_output; |
| 2589 | dbgInfo.flags = report_flags; |
| 2590 | layer_create_msg_callback(my_data->report_data, &dbgInfo, pAllocator, &callback); |
Courtney Goeltzenleuchter | 1781b1c | 2015-10-05 15:58:38 -0600 | [diff] [blame] | 2591 | my_data->logging_callback.push_back(callback); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2592 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2593 | |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2594 | if (!globalLockInitialized) |
| 2595 | { |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2596 | loader_platform_thread_create_mutex(&globalLock); |
| 2597 | globalLockInitialized = 1; |
| 2598 | } |
| 2599 | } |
| 2600 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2601 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(const VkInstanceCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkInstance* pInstance) |
Courtney Goeltzenleuchter | 3c9f6ec | 2015-06-01 14:29:58 -0600 | [diff] [blame] | 2602 | { |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 2603 | // TODOSC : Shouldn't need any customization here |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 2604 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map); |
| 2605 | VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 2606 | VkResult result = pTable->CreateInstance(pCreateInfo, pAllocator, pInstance); |
Courtney Goeltzenleuchter | 3c9f6ec | 2015-06-01 14:29:58 -0600 | [diff] [blame] | 2607 | |
| 2608 | if (result == VK_SUCCESS) { |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 2609 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map); |
| 2610 | my_data->report_data = debug_report_create_instance( |
| 2611 | pTable, |
| 2612 | *pInstance, |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 2613 | pCreateInfo->enabledExtensionNameCount, |
Courtney Goeltzenleuchter | 73e8bd4 | 2015-07-06 22:31:52 -0600 | [diff] [blame] | 2614 | pCreateInfo->ppEnabledExtensionNames); |
Courtney Goeltzenleuchter | f4a2eba | 2015-06-08 14:58:39 -0600 | [diff] [blame] | 2615 | |
Courtney Goeltzenleuchter | b03a0bf | 2015-11-25 14:31:49 -0700 | [diff] [blame] | 2616 | init_draw_state(my_data, pAllocator); |
Courtney Goeltzenleuchter | 3c9f6ec | 2015-06-01 14:29:58 -0600 | [diff] [blame] | 2617 | } |
| 2618 | return result; |
| 2619 | } |
| 2620 | |
Jon Ashburn | e0fa228 | 2015-05-20 09:00:28 -0600 | [diff] [blame] | 2621 | /* hook DestroyInstance to remove tableInstanceMap entry */ |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2622 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks* pAllocator) |
Jon Ashburn | e0fa228 | 2015-05-20 09:00:28 -0600 | [diff] [blame] | 2623 | { |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 2624 | // TODOSC : Shouldn't need any customization here |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 2625 | dispatch_key key = get_dispatch_key(instance); |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 2626 | layer_data *my_data = get_my_data_ptr(key, layer_data_map); |
| 2627 | VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 2628 | pTable->DestroyInstance(instance, pAllocator); |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 2629 | |
| 2630 | // Clean up logging callback, if any |
Courtney Goeltzenleuchter | 1781b1c | 2015-10-05 15:58:38 -0600 | [diff] [blame] | 2631 | while (my_data->logging_callback.size() > 0) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2632 | VkDebugReportCallbackEXT callback = my_data->logging_callback.back(); |
Courtney Goeltzenleuchter | f6a6e22 | 2015-11-30 12:13:14 -0700 | [diff] [blame] | 2633 | layer_destroy_msg_callback(my_data->report_data, callback, pAllocator); |
Courtney Goeltzenleuchter | 1781b1c | 2015-10-05 15:58:38 -0600 | [diff] [blame] | 2634 | my_data->logging_callback.pop_back(); |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 2635 | } |
| 2636 | |
Courtney Goeltzenleuchter | 2d034fd | 2015-06-28 13:01:17 -0600 | [diff] [blame] | 2637 | layer_debug_report_destroy_instance(my_data->report_data); |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 2638 | delete my_data->instance_dispatch_table; |
| 2639 | layer_data_map.erase(key); |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 2640 | // TODO : Potential race here with separate threads creating/destroying instance |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 2641 | if (layer_data_map.empty()) { |
Mike Stroyan | d9dd007 | 2015-08-18 15:56:18 -0600 | [diff] [blame] | 2642 | // Release mutex when destroying last instance. |
| 2643 | loader_platform_thread_delete_mutex(&globalLock); |
| 2644 | globalLockInitialized = 0; |
| 2645 | } |
Jon Ashburn | e0fa228 | 2015-05-20 09:00:28 -0600 | [diff] [blame] | 2646 | } |
| 2647 | |
Jon Ashburn | f0615e2 | 2015-05-25 14:11:37 -0600 | [diff] [blame] | 2648 | static void createDeviceRegisterExtensions(const VkDeviceCreateInfo* pCreateInfo, VkDevice device) |
| 2649 | { |
Tony Barbour | 29b1206 | 2015-07-13 13:37:24 -0600 | [diff] [blame] | 2650 | uint32_t i; |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 2651 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 2652 | dev_data->device_extensions.debug_marker_enabled = false; |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 2653 | dev_data->device_extensions.wsi_enabled = false; |
| 2654 | |
| 2655 | |
| 2656 | VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; |
| 2657 | PFN_vkGetDeviceProcAddr gpa = pDisp->GetDeviceProcAddr; |
| 2658 | |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 2659 | pDisp->CreateSwapchainKHR = (PFN_vkCreateSwapchainKHR) gpa(device, "vkCreateSwapchainKHR"); |
| 2660 | pDisp->DestroySwapchainKHR = (PFN_vkDestroySwapchainKHR) gpa(device, "vkDestroySwapchainKHR"); |
| 2661 | pDisp->GetSwapchainImagesKHR = (PFN_vkGetSwapchainImagesKHR) gpa(device, "vkGetSwapchainImagesKHR"); |
| 2662 | pDisp->AcquireNextImageKHR = (PFN_vkAcquireNextImageKHR) gpa(device, "vkAcquireNextImageKHR"); |
| 2663 | pDisp->QueuePresentKHR = (PFN_vkQueuePresentKHR) gpa(device, "vkQueuePresentKHR"); |
Jon Ashburn | f0615e2 | 2015-05-25 14:11:37 -0600 | [diff] [blame] | 2664 | |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 2665 | for (i = 0; i < pCreateInfo->enabledExtensionNameCount; i++) { |
Ian Elliott | c623ba5 | 2015-11-20 14:13:17 -0700 | [diff] [blame] | 2666 | if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) { |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 2667 | dev_data->device_extensions.wsi_enabled = true; |
| 2668 | } |
Courtney Goeltzenleuchter | 73e8bd4 | 2015-07-06 22:31:52 -0600 | [diff] [blame] | 2669 | if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], DEBUG_MARKER_EXTENSION_NAME) == 0) { |
Jon Ashburn | 6f8cd63 | 2015-06-01 09:37:38 -0600 | [diff] [blame] | 2670 | /* Found a matching extension name, mark it enabled and init dispatch table*/ |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 2671 | dev_data->device_extensions.debug_marker_enabled = true; |
Jon Ashburn | c1d059f | 2015-12-10 19:12:21 -0700 | [diff] [blame] | 2672 | initDebugMarkerTable(device); |
| 2673 | |
Jon Ashburn | f0615e2 | 2015-05-25 14:11:37 -0600 | [diff] [blame] | 2674 | } |
Jon Ashburn | f0615e2 | 2015-05-25 14:11:37 -0600 | [diff] [blame] | 2675 | } |
| 2676 | } |
| 2677 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2678 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDevice* pDevice) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2679 | { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 2680 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 2681 | VkResult result = dev_data->device_dispatch_table->CreateDevice(gpu, pCreateInfo, pAllocator, pDevice); |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 2682 | // TODOSC : shouldn't need any customization here |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 2683 | if (result == VK_SUCCESS) { |
| 2684 | layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), layer_data_map); |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 2685 | dev_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); |
Jon Ashburn | 7e07faf | 2015-06-18 15:02:58 -0600 | [diff] [blame] | 2686 | createDeviceRegisterExtensions(pCreateInfo, *pDevice); |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 2687 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2688 | return result; |
| 2689 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 2690 | |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 2691 | // prototype |
| 2692 | static void deleteRenderPasses(layer_data*); |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2693 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks* pAllocator) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2694 | { |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 2695 | // TODOSC : Shouldn't need any customization here |
Jeremy Hayes | ea1fef5 | 2015-06-19 11:37:38 -0600 | [diff] [blame] | 2696 | dispatch_key key = get_dispatch_key(device); |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 2697 | layer_data* dev_data = get_my_data_ptr(key, layer_data_map); |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 2698 | // Free all the memory |
| 2699 | loader_platform_thread_lock_mutex(&globalLock); |
| 2700 | deletePipelines(dev_data); |
| 2701 | deleteRenderPasses(dev_data); |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2702 | deleteCommandBuffers(dev_data); |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 2703 | deletePools(dev_data); |
| 2704 | deleteLayouts(dev_data); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 2705 | dev_data->imageViewMap.clear(); |
| 2706 | dev_data->imageMap.clear(); |
| 2707 | dev_data->bufferViewMap.clear(); |
| 2708 | dev_data->bufferMap.clear(); |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 2709 | loader_platform_thread_unlock_mutex(&globalLock); |
| 2710 | |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 2711 | dev_data->device_dispatch_table->DestroyDevice(device, pAllocator); |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 2712 | tableDebugMarkerMap.erase(key); |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 2713 | delete dev_data->device_dispatch_table; |
| 2714 | layer_data_map.erase(key); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2715 | } |
| 2716 | |
Courtney Goeltzenleuchter | d89520d | 2015-12-01 14:08:28 -0700 | [diff] [blame] | 2717 | static const VkExtensionProperties instance_extensions[] = { |
Courtney Goeltzenleuchter | 1c7c65d | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2718 | { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2719 | VK_EXT_DEBUG_REPORT_EXTENSION_NAME, |
| 2720 | VK_EXT_DEBUG_REPORT_REVISION |
Courtney Goeltzenleuchter | 1c7c65d | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2721 | } |
Jon Ashburn | eb2728b | 2015-04-10 14:33:07 -0600 | [diff] [blame] | 2722 | }; |
| 2723 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2724 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties( |
Courtney Goeltzenleuchter | 73e8bd4 | 2015-07-06 22:31:52 -0600 | [diff] [blame] | 2725 | const char *pLayerName, |
| 2726 | uint32_t *pCount, |
| 2727 | VkExtensionProperties* pProperties) |
Jon Ashburn | eb2728b | 2015-04-10 14:33:07 -0600 | [diff] [blame] | 2728 | { |
Courtney Goeltzenleuchter | d89520d | 2015-12-01 14:08:28 -0700 | [diff] [blame] | 2729 | return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); |
Courtney Goeltzenleuchter | 73e8bd4 | 2015-07-06 22:31:52 -0600 | [diff] [blame] | 2730 | } |
Jon Ashburn | eb2728b | 2015-04-10 14:33:07 -0600 | [diff] [blame] | 2731 | |
Courtney Goeltzenleuchter | d89520d | 2015-12-01 14:08:28 -0700 | [diff] [blame] | 2732 | static const VkLayerProperties ds_global_layers[] = { |
| 2733 | { |
| 2734 | "DrawState", |
| 2735 | VK_API_VERSION, |
| 2736 | VK_MAKE_VERSION(0, 1, 0), |
| 2737 | "Validation layer: DrawState", |
| 2738 | } |
| 2739 | }; |
| 2740 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2741 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties( |
Courtney Goeltzenleuchter | 73e8bd4 | 2015-07-06 22:31:52 -0600 | [diff] [blame] | 2742 | uint32_t *pCount, |
| 2743 | VkLayerProperties* pProperties) |
| 2744 | { |
| 2745 | return util_GetLayerProperties(ARRAY_SIZE(ds_global_layers), |
| 2746 | ds_global_layers, |
| 2747 | pCount, pProperties); |
| 2748 | } |
Jon Ashburn | eb2728b | 2015-04-10 14:33:07 -0600 | [diff] [blame] | 2749 | |
Courtney Goeltzenleuchter | 73e8bd4 | 2015-07-06 22:31:52 -0600 | [diff] [blame] | 2750 | static const VkExtensionProperties ds_device_extensions[] = { |
| 2751 | { |
| 2752 | DEBUG_MARKER_EXTENSION_NAME, |
| 2753 | VK_MAKE_VERSION(0, 1, 0), |
Courtney Goeltzenleuchter | 73e8bd4 | 2015-07-06 22:31:52 -0600 | [diff] [blame] | 2754 | } |
| 2755 | }; |
| 2756 | |
| 2757 | static const VkLayerProperties ds_device_layers[] = { |
| 2758 | { |
| 2759 | "DrawState", |
| 2760 | VK_API_VERSION, |
| 2761 | VK_MAKE_VERSION(0, 1, 0), |
| 2762 | "Validation layer: DrawState", |
| 2763 | } |
| 2764 | }; |
| 2765 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2766 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties( |
Courtney Goeltzenleuchter | 73e8bd4 | 2015-07-06 22:31:52 -0600 | [diff] [blame] | 2767 | VkPhysicalDevice physicalDevice, |
| 2768 | const char* pLayerName, |
| 2769 | uint32_t* pCount, |
| 2770 | VkExtensionProperties* pProperties) |
| 2771 | { |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 2772 | // DrawState does not have any physical device extensions |
Jon Ashburn | aff81ff | 2015-11-02 17:37:20 -0700 | [diff] [blame] | 2773 | if (pLayerName == NULL) { |
| 2774 | dispatch_key key = get_dispatch_key(physicalDevice); |
| 2775 | layer_data *my_data = get_my_data_ptr(key, layer_data_map); |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 2776 | return my_data->instance_dispatch_table->EnumerateDeviceExtensionProperties( |
Jon Ashburn | aff81ff | 2015-11-02 17:37:20 -0700 | [diff] [blame] | 2777 | physicalDevice, |
| 2778 | NULL, |
| 2779 | pCount, |
| 2780 | pProperties); |
| 2781 | } else { |
| 2782 | return util_GetExtensionProperties(ARRAY_SIZE(ds_device_extensions), |
| 2783 | ds_device_extensions, |
| 2784 | pCount, pProperties); |
| 2785 | } |
Courtney Goeltzenleuchter | 73e8bd4 | 2015-07-06 22:31:52 -0600 | [diff] [blame] | 2786 | } |
| 2787 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2788 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties( |
Courtney Goeltzenleuchter | 73e8bd4 | 2015-07-06 22:31:52 -0600 | [diff] [blame] | 2789 | VkPhysicalDevice physicalDevice, |
| 2790 | uint32_t* pCount, |
| 2791 | VkLayerProperties* pProperties) |
| 2792 | { |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 2793 | /* DrawState physical device layers are the same as global */ |
Courtney Goeltzenleuchter | 73e8bd4 | 2015-07-06 22:31:52 -0600 | [diff] [blame] | 2794 | return util_GetLayerProperties(ARRAY_SIZE(ds_device_layers), ds_device_layers, |
| 2795 | pCount, pProperties); |
Jon Ashburn | eb2728b | 2015-04-10 14:33:07 -0600 | [diff] [blame] | 2796 | } |
| 2797 | |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 2798 | bool ValidateCmdBufImageLayouts(VkCommandBuffer cmdBuffer) { |
| 2799 | bool skip_call = false; |
| 2800 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); |
| 2801 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer); |
| 2802 | for (auto cb_image_data : pCB->imageLayoutMap) { |
| 2803 | auto image_data = dev_data->imageLayoutMap.find(cb_image_data.first); |
| 2804 | if (image_data == dev_data->imageLayoutMap.end()) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2805 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Michael Lentine | cbc4a5e | 2015-11-03 16:19:46 -0800 | [diff] [blame] | 2806 | "Cannot submit cmd buffer using deleted image %" PRIu64 ".", reinterpret_cast<uint64_t>(cb_image_data.first)); |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 2807 | } else { |
| 2808 | if (dev_data->imageLayoutMap[cb_image_data.first]->layout != cb_image_data.second.initialLayout) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2809 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 2810 | "Cannot submit cmd buffer using image with layout %d when first use is %d.", dev_data->imageLayoutMap[cb_image_data.first]->layout, cb_image_data.second.initialLayout); |
| 2811 | } |
| 2812 | dev_data->imageLayoutMap[cb_image_data.first]->layout = cb_image_data.second.layout; |
| 2813 | } |
| 2814 | } |
| 2815 | return skip_call; |
| 2816 | } |
| 2817 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2818 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo* pSubmits, VkFence fence) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2819 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 2820 | VkBool32 skipCall = VK_FALSE; |
Tobin Ehlis | 28be0be | 2015-05-22 12:38:16 -0600 | [diff] [blame] | 2821 | GLOBAL_CB_NODE* pCB = NULL; |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 2822 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); |
Courtney Goeltzenleuchter | 3ec3162 | 2015-10-20 18:04:07 -0600 | [diff] [blame] | 2823 | for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { |
Chia-I Wu | 483e770 | 2015-10-26 17:20:32 +0800 | [diff] [blame] | 2824 | const VkSubmitInfo *submit = &pSubmits[submit_idx]; |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 2825 | for (uint32_t i=0; i < submit->commandBufferCount; i++) { |
Mark Lobodzinski | 78940a4 | 2015-11-30 16:48:53 -0700 | [diff] [blame] | 2826 | |
| 2827 | #ifndef DISABLE_IMAGE_LAYOUT_VALIDATION |
| 2828 | skipCall |= ValidateCmdBufImageLayouts(submit->pCommandBuffers[i]); |
| 2829 | #endif // DISABLE_IMAGE_LAYOUT_VALIDATION |
| 2830 | |
Courtney Goeltzenleuchter | 3ec3162 | 2015-10-20 18:04:07 -0600 | [diff] [blame] | 2831 | // Validate that cmd buffers have been updated |
| 2832 | pCB = getCBNode(dev_data, submit->pCommandBuffers[i]); |
| 2833 | loader_platform_thread_lock_mutex(&globalLock); |
| 2834 | pCB->submitCount++; // increment submit count |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2835 | if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2836 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 2837 | "CB %#" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT set, but has been submitted %#" PRIxLEAST64 " times.", |
| 2838 | reinterpret_cast<uint64_t>(pCB->commandBuffer), pCB->submitCount); |
Courtney Goeltzenleuchter | 3ec3162 | 2015-10-20 18:04:07 -0600 | [diff] [blame] | 2839 | } |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 2840 | if (CB_RECORDED != pCB->state) { |
Courtney Goeltzenleuchter | 3ec3162 | 2015-10-20 18:04:07 -0600 | [diff] [blame] | 2841 | // Flag error for using CB w/o vkEndCommandBuffer() called |
| 2842 | // TODO : How to pass cb as srcObj? |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 2843 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 2844 | "You must call vkEndCommandBuffer() on CB %#" PRIxLEAST64 " before this call to vkQueueSubmit()!", reinterpret_cast<uint64_t>(pCB->commandBuffer)); |
Courtney Goeltzenleuchter | 3ec3162 | 2015-10-20 18:04:07 -0600 | [diff] [blame] | 2845 | loader_platform_thread_unlock_mutex(&globalLock); |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 2846 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Courtney Goeltzenleuchter | 3ec3162 | 2015-10-20 18:04:07 -0600 | [diff] [blame] | 2847 | } |
Tobin Ehlis | e90b171 | 2015-05-27 14:30:06 -0600 | [diff] [blame] | 2848 | loader_platform_thread_unlock_mutex(&globalLock); |
Tobin Ehlis | 28be0be | 2015-05-22 12:38:16 -0600 | [diff] [blame] | 2849 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2850 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 2851 | if (VK_FALSE == skipCall) |
Chia-I Wu | 483e770 | 2015-10-26 17:20:32 +0800 | [diff] [blame] | 2852 | return dev_data->device_dispatch_table->QueueSubmit(queue, submitCount, pSubmits, fence); |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 2853 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2854 | } |
| 2855 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2856 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks* pAllocator) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 2857 | { |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 2858 | get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyFence(device, fence, pAllocator); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2859 | // TODO : Clean up any internal data structures using this obj. |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2860 | } |
| 2861 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2862 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks* pAllocator) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2863 | { |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 2864 | get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySemaphore(device, semaphore, pAllocator); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2865 | // TODO : Clean up any internal data structures using this obj. |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2866 | } |
| 2867 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2868 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks* pAllocator) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2869 | { |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 2870 | get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyEvent(device, event, pAllocator); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2871 | // TODO : Clean up any internal data structures using this obj. |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2872 | } |
| 2873 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2874 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks* pAllocator) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2875 | { |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 2876 | get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyQueryPool(device, queryPool, pAllocator); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2877 | // TODO : Clean up any internal data structures using this obj. |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2878 | } |
| 2879 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2880 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyBuffer(VkDevice device, VkBuffer buffer, const VkAllocationCallbacks* pAllocator) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2881 | { |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 2882 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 2883 | dev_data->device_dispatch_table->DestroyBuffer(device, buffer, pAllocator); |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 2884 | dev_data->bufferMap.erase(buffer); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2885 | } |
| 2886 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2887 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks* pAllocator) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2888 | { |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 2889 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 2890 | dev_data->device_dispatch_table->DestroyBufferView(device, bufferView, pAllocator); |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 2891 | dev_data->bufferViewMap.erase(bufferView); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2892 | } |
| 2893 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2894 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks* pAllocator) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2895 | { |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 2896 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 2897 | dev_data->device_dispatch_table->DestroyImage(device, image, pAllocator); |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 2898 | dev_data->imageMap.erase(image); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2899 | } |
| 2900 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2901 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks* pAllocator) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2902 | { |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 2903 | get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyImageView(device, imageView, pAllocator); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2904 | // TODO : Clean up any internal data structures using this obj. |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2905 | } |
| 2906 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2907 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks* pAllocator) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2908 | { |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 2909 | get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyShaderModule(device, shaderModule, pAllocator); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2910 | // TODO : Clean up any internal data structures using this obj. |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2911 | } |
| 2912 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2913 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks* pAllocator) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2914 | { |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 2915 | get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipeline(device, pipeline, pAllocator); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2916 | // TODO : Clean up any internal data structures using this obj. |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2917 | } |
| 2918 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2919 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks* pAllocator) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2920 | { |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 2921 | get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipelineLayout(device, pipelineLayout, pAllocator); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2922 | // TODO : Clean up any internal data structures using this obj. |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2923 | } |
| 2924 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2925 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks* pAllocator) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2926 | { |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 2927 | get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySampler(device, sampler, pAllocator); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2928 | // TODO : Clean up any internal data structures using this obj. |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2929 | } |
| 2930 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2931 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks* pAllocator) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2932 | { |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 2933 | get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2934 | // TODO : Clean up any internal data structures using this obj. |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2935 | } |
| 2936 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2937 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks* pAllocator) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2938 | { |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 2939 | get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyDescriptorPool(device, descriptorPool, pAllocator); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2940 | // TODO : Clean up any internal data structures using this obj. |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2941 | } |
| 2942 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 2943 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t count, const VkCommandBuffer *pCommandBuffers) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2944 | { |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 2945 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 2946 | |
| 2947 | for (auto i = 0; i < count; i++) { |
| 2948 | // Delete CB information structure, and remove from commandBufferMap |
| 2949 | auto cb = dev_data->commandBufferMap.find(pCommandBuffers[i]); |
Mark Lobodzinski | 13b6674 | 2015-11-20 14:33:48 -0700 | [diff] [blame] | 2950 | loader_platform_thread_lock_mutex(&globalLock); |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 2951 | if (cb != dev_data->commandBufferMap.end()) { |
| 2952 | delete (*cb).second; |
| 2953 | dev_data->commandBufferMap.erase(cb); |
| 2954 | } |
| 2955 | |
| 2956 | // Remove commandBuffer reference from commandPoolMap |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 2957 | dev_data->commandPoolMap[commandPool].commandBuffers.remove(pCommandBuffers[i]); |
Mark Lobodzinski | 13b6674 | 2015-11-20 14:33:48 -0700 | [diff] [blame] | 2958 | loader_platform_thread_unlock_mutex(&globalLock); |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 2959 | } |
| 2960 | |
| 2961 | dev_data->device_dispatch_table->FreeCommandBuffers(device, commandPool, count, pCommandBuffers); |
| 2962 | } |
| 2963 | |
| 2964 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkCommandPool* pCommandPool) |
| 2965 | { |
| 2966 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 2967 | |
| 2968 | VkResult result = dev_data->device_dispatch_table->CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); |
| 2969 | |
| 2970 | if (VK_SUCCESS == result) { |
Mark Lobodzinski | 13b6674 | 2015-11-20 14:33:48 -0700 | [diff] [blame] | 2971 | loader_platform_thread_lock_mutex(&globalLock); |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 2972 | dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; |
Mark Lobodzinski | 13b6674 | 2015-11-20 14:33:48 -0700 | [diff] [blame] | 2973 | loader_platform_thread_unlock_mutex(&globalLock); |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 2974 | } |
| 2975 | return result; |
| 2976 | } |
| 2977 | |
| 2978 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks* pAllocator) |
| 2979 | { |
| 2980 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Mark Lobodzinski | 13b6674 | 2015-11-20 14:33:48 -0700 | [diff] [blame] | 2981 | loader_platform_thread_lock_mutex(&globalLock); |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 2982 | |
| 2983 | // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandPoolMap |
| 2984 | if (dev_data->commandPoolMap.find(commandPool) != dev_data->commandPoolMap.end()) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 2985 | for (auto poolCb = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); poolCb != dev_data->commandPoolMap[commandPool].commandBuffers.end();) { |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 2986 | auto del_cb = dev_data->commandBufferMap.find(*poolCb); |
| 2987 | delete (*del_cb).second; // delete CB info structure |
| 2988 | dev_data->commandBufferMap.erase(del_cb); // Remove this command buffer from cbMap |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 2989 | poolCb = dev_data->commandPoolMap[commandPool].commandBuffers.erase(poolCb); // Remove CB reference from commandPoolMap's list |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 2990 | } |
| 2991 | } |
| 2992 | dev_data->commandPoolMap.erase(commandPool); |
Mark Lobodzinski | 13b6674 | 2015-11-20 14:33:48 -0700 | [diff] [blame] | 2993 | |
| 2994 | loader_platform_thread_unlock_mutex(&globalLock); |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 2995 | dev_data->device_dispatch_table->DestroyCommandPool(device, commandPool, pAllocator); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 2996 | } |
| 2997 | |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 2998 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkResetCommandPool( |
| 2999 | VkDevice device, |
| 3000 | VkCommandPool commandPool, |
| 3001 | VkCommandPoolResetFlags flags) |
| 3002 | { |
| 3003 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 3004 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3005 | |
| 3006 | result = dev_data->device_dispatch_table->ResetCommandPool(device, commandPool, flags); |
| 3007 | // Reset all of the CBs allocated from this pool |
| 3008 | if (VK_SUCCESS == result) { |
| 3009 | auto it = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); |
| 3010 | while (it != dev_data->commandPoolMap[commandPool].commandBuffers.end()) { |
| 3011 | resetCB(dev_data, (*it)); |
| 3012 | ++it; |
| 3013 | } |
| 3014 | } |
| 3015 | return result; |
| 3016 | } |
| 3017 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3018 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks* pAllocator) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3019 | { |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 3020 | get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyFramebuffer(device, framebuffer, pAllocator); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3021 | // TODO : Clean up any internal data structures using this obj. |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3022 | } |
| 3023 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3024 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks* pAllocator) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3025 | { |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 3026 | get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyRenderPass(device, renderPass, pAllocator); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3027 | // TODO : Clean up any internal data structures using this obj. |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3028 | } |
| 3029 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3030 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBuffer(VkDevice device, const VkBufferCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkBuffer* pBuffer) |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 3031 | { |
| 3032 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 3033 | VkResult result = dev_data->device_dispatch_table->CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 3034 | if (VK_SUCCESS == result) { |
| 3035 | loader_platform_thread_lock_mutex(&globalLock); |
| 3036 | // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 3037 | dev_data->bufferMap[*pBuffer] = unique_ptr<VkBufferCreateInfo>(new VkBufferCreateInfo(*pCreateInfo)); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 3038 | loader_platform_thread_unlock_mutex(&globalLock); |
| 3039 | } |
| 3040 | return result; |
| 3041 | } |
| 3042 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3043 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBufferView(VkDevice device, const VkBufferViewCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkBufferView* pView) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3044 | { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 3045 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 3046 | VkResult result = dev_data->device_dispatch_table->CreateBufferView(device, pCreateInfo, pAllocator, pView); |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 3047 | if (VK_SUCCESS == result) { |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3048 | loader_platform_thread_lock_mutex(&globalLock); |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 3049 | dev_data->bufferViewMap[*pView] = unique_ptr<VkBufferViewCreateInfo>(new VkBufferViewCreateInfo(*pCreateInfo)); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 3050 | loader_platform_thread_unlock_mutex(&globalLock); |
| 3051 | } |
| 3052 | return result; |
| 3053 | } |
| 3054 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3055 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImage(VkDevice device, const VkImageCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkImage* pImage) |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 3056 | { |
| 3057 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 3058 | VkResult result = dev_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage); |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 3059 | if (VK_SUCCESS == result) { |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 3060 | IMAGE_NODE* image_node = new IMAGE_NODE; |
| 3061 | image_node->layout = pCreateInfo->initialLayout; |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 3062 | loader_platform_thread_lock_mutex(&globalLock); |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 3063 | dev_data->imageMap[*pImage] = unique_ptr<VkImageCreateInfo>(new VkImageCreateInfo(*pCreateInfo)); |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 3064 | dev_data->imageLayoutMap[*pImage] = image_node; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3065 | loader_platform_thread_unlock_mutex(&globalLock); |
| 3066 | } |
| 3067 | return result; |
| 3068 | } |
| 3069 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3070 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImageView(VkDevice device, const VkImageViewCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkImageView* pView) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3071 | { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 3072 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 3073 | VkResult result = dev_data->device_dispatch_table->CreateImageView(device, pCreateInfo, pAllocator, pView); |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 3074 | if (VK_SUCCESS == result) { |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3075 | loader_platform_thread_lock_mutex(&globalLock); |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 3076 | dev_data->imageViewMap[*pView] = unique_ptr<VkImageViewCreateInfo>(new VkImageViewCreateInfo(*pCreateInfo)); |
Tobin Ehlis | 8cd650e | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 3077 | loader_platform_thread_unlock_mutex(&globalLock); |
| 3078 | } |
| 3079 | return result; |
| 3080 | } |
| 3081 | |
Jon Ashburn | 0d60d27 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 3082 | //TODO handle pipeline caches |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3083 | VKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineCache( |
Jon Ashburn | 0d60d27 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 3084 | VkDevice device, |
| 3085 | const VkPipelineCacheCreateInfo* pCreateInfo, |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3086 | const VkAllocationCallbacks* pAllocator, |
Jon Ashburn | 0d60d27 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 3087 | VkPipelineCache* pPipelineCache) |
| 3088 | { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 3089 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 3090 | VkResult result = dev_data->device_dispatch_table->CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); |
Jon Ashburn | 0d60d27 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 3091 | return result; |
| 3092 | } |
| 3093 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3094 | VKAPI_ATTR void VKAPI_CALL vkDestroyPipelineCache( |
Jon Ashburn | 0d60d27 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 3095 | VkDevice device, |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 3096 | VkPipelineCache pipelineCache, |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3097 | const VkAllocationCallbacks* pAllocator) |
Jon Ashburn | 0d60d27 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 3098 | { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 3099 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 3100 | dev_data->device_dispatch_table->DestroyPipelineCache(device, pipelineCache, pAllocator); |
Jon Ashburn | 0d60d27 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 3101 | } |
| 3102 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3103 | VKAPI_ATTR VkResult VKAPI_CALL vkGetPipelineCacheData( |
Jon Ashburn | 0d60d27 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 3104 | VkDevice device, |
| 3105 | VkPipelineCache pipelineCache, |
Chia-I Wu | 28c3c43 | 2015-10-26 19:17:06 +0800 | [diff] [blame] | 3106 | size_t* pDataSize, |
Jon Ashburn | 0d60d27 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 3107 | void* pData) |
| 3108 | { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 3109 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chia-I Wu | 28c3c43 | 2015-10-26 19:17:06 +0800 | [diff] [blame] | 3110 | VkResult result = dev_data->device_dispatch_table->GetPipelineCacheData(device, pipelineCache, pDataSize, pData); |
Jon Ashburn | 0d60d27 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 3111 | return result; |
| 3112 | } |
| 3113 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3114 | VKAPI_ATTR VkResult VKAPI_CALL vkMergePipelineCaches( |
Jon Ashburn | 0d60d27 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 3115 | VkDevice device, |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3116 | VkPipelineCache dstCache, |
Jon Ashburn | 0d60d27 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 3117 | uint32_t srcCacheCount, |
| 3118 | const VkPipelineCache* pSrcCaches) |
| 3119 | { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 3120 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3121 | VkResult result = dev_data->device_dispatch_table->MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); |
Jon Ashburn | 0d60d27 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 3122 | return result; |
| 3123 | } |
| 3124 | |
Mark Lobodzinski | 2adea75 | 2015-11-10 15:25:01 -0700 | [diff] [blame] | 3125 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateGraphicsPipelines( |
| 3126 | VkDevice device, |
| 3127 | VkPipelineCache pipelineCache, |
| 3128 | uint32_t count, |
| 3129 | const VkGraphicsPipelineCreateInfo *pCreateInfos, |
| 3130 | const VkAllocationCallbacks *pAllocator, |
| 3131 | VkPipeline *pPipelines) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3132 | { |
Courtney Goeltzenleuchter | a54b76a | 2015-09-04 13:39:59 -0600 | [diff] [blame] | 3133 | VkResult result = VK_SUCCESS; |
Tobin Ehlis | e48be20 | 2015-09-16 10:33:53 -0600 | [diff] [blame] | 3134 | //TODO What to do with pipelineCache? |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 3135 | // The order of operations here is a little convoluted but gets the job done |
| 3136 | // 1. Pipeline create state is first shadowed into PIPELINE_NODE struct |
| 3137 | // 2. Create state is then validated (which uses flags setup during shadowing) |
| 3138 | // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap |
Tobin Ehlis | e48be20 | 2015-09-16 10:33:53 -0600 | [diff] [blame] | 3139 | VkBool32 skipCall = VK_FALSE; |
Tobin Ehlis | 76c1885 | 2015-09-17 16:33:58 -0600 | [diff] [blame] | 3140 | // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic |
| 3141 | vector<PIPELINE_NODE*> pPipeNode(count); |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 3142 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Mark Lobodzinski | 2adea75 | 2015-11-10 15:25:01 -0700 | [diff] [blame] | 3143 | |
Tobin Ehlis | e48be20 | 2015-09-16 10:33:53 -0600 | [diff] [blame] | 3144 | uint32_t i=0; |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 3145 | loader_platform_thread_lock_mutex(&globalLock); |
Mark Lobodzinski | 2adea75 | 2015-11-10 15:25:01 -0700 | [diff] [blame] | 3146 | |
Tobin Ehlis | e48be20 | 2015-09-16 10:33:53 -0600 | [diff] [blame] | 3147 | for (i=0; i<count; i++) { |
Mark Lobodzinski | 2adea75 | 2015-11-10 15:25:01 -0700 | [diff] [blame] | 3148 | pPipeNode[i] = initGraphicsPipeline(dev_data, &pCreateInfos[i], NULL); |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 3149 | skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]); |
Tobin Ehlis | e48be20 | 2015-09-16 10:33:53 -0600 | [diff] [blame] | 3150 | } |
Mark Lobodzinski | 2adea75 | 2015-11-10 15:25:01 -0700 | [diff] [blame] | 3151 | |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 3152 | loader_platform_thread_unlock_mutex(&globalLock); |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 3153 | |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 3154 | if (VK_FALSE == skipCall) { |
Mark Lobodzinski | 2adea75 | 2015-11-10 15:25:01 -0700 | [diff] [blame] | 3155 | result = dev_data->device_dispatch_table->CreateGraphicsPipelines(device, |
| 3156 | pipelineCache, count, pCreateInfos, pAllocator, pPipelines); |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 3157 | loader_platform_thread_lock_mutex(&globalLock); |
Tobin Ehlis | e48be20 | 2015-09-16 10:33:53 -0600 | [diff] [blame] | 3158 | for (i=0; i<count; i++) { |
| 3159 | pPipeNode[i]->pipeline = pPipelines[i]; |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 3160 | dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; |
Tobin Ehlis | e48be20 | 2015-09-16 10:33:53 -0600 | [diff] [blame] | 3161 | } |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 3162 | loader_platform_thread_unlock_mutex(&globalLock); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 3163 | } else { |
Tobin Ehlis | e48be20 | 2015-09-16 10:33:53 -0600 | [diff] [blame] | 3164 | for (i=0; i<count; i++) { |
| 3165 | if (pPipeNode[i]) { |
| 3166 | // If we allocated a pipeNode, need to clean it up here |
| 3167 | delete[] pPipeNode[i]->pVertexBindingDescriptions; |
| 3168 | delete[] pPipeNode[i]->pVertexAttributeDescriptions; |
| 3169 | delete[] pPipeNode[i]->pAttachments; |
| 3170 | delete pPipeNode[i]; |
| 3171 | } |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 3172 | } |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 3173 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | de63c53 | 2015-06-18 15:59:33 -0600 | [diff] [blame] | 3174 | } |
Courtney Goeltzenleuchter | 9452ac2 | 2015-04-13 16:16:04 -0600 | [diff] [blame] | 3175 | return result; |
| 3176 | } |
| 3177 | |
Mark Lobodzinski | 2adea75 | 2015-11-10 15:25:01 -0700 | [diff] [blame] | 3178 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateComputePipelines( |
| 3179 | VkDevice device, |
| 3180 | VkPipelineCache pipelineCache, |
| 3181 | uint32_t count, |
| 3182 | const VkComputePipelineCreateInfo *pCreateInfos, |
| 3183 | const VkAllocationCallbacks *pAllocator, |
| 3184 | VkPipeline *pPipelines) |
| 3185 | { |
| 3186 | VkResult result = VK_SUCCESS; |
| 3187 | VkBool32 skipCall = VK_FALSE; |
| 3188 | |
| 3189 | // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic |
| 3190 | vector<PIPELINE_NODE*> pPipeNode(count); |
| 3191 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 3192 | |
| 3193 | uint32_t i=0; |
| 3194 | loader_platform_thread_lock_mutex(&globalLock); |
| 3195 | for (i=0; i<count; i++) { |
| 3196 | // TODO: Verify compute stage bits |
| 3197 | |
| 3198 | // Create and initialize internal tracking data structure |
| 3199 | pPipeNode[i] = new PIPELINE_NODE; |
| 3200 | memset((void*)pPipeNode[i], 0, sizeof(PIPELINE_NODE)); |
| 3201 | memcpy(&pPipeNode[i]->computePipelineCI, (const void*)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo)); |
| 3202 | |
| 3203 | // TODO: Add Compute Pipeline Verification |
| 3204 | // skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]); |
| 3205 | } |
| 3206 | loader_platform_thread_unlock_mutex(&globalLock); |
| 3207 | |
| 3208 | if (VK_FALSE == skipCall) { |
| 3209 | result = dev_data->device_dispatch_table->CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, pPipelines); |
| 3210 | loader_platform_thread_lock_mutex(&globalLock); |
| 3211 | for (i=0; i<count; i++) { |
| 3212 | pPipeNode[i]->pipeline = pPipelines[i]; |
| 3213 | dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; |
| 3214 | } |
| 3215 | loader_platform_thread_unlock_mutex(&globalLock); |
| 3216 | } else { |
| 3217 | for (i=0; i<count; i++) { |
| 3218 | if (pPipeNode[i]) { |
| 3219 | // Clean up any locally allocated data structures |
| 3220 | delete pPipeNode[i]; |
| 3221 | } |
| 3222 | } |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 3223 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Mark Lobodzinski | 2adea75 | 2015-11-10 15:25:01 -0700 | [diff] [blame] | 3224 | } |
| 3225 | return result; |
| 3226 | } |
| 3227 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3228 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSampler(VkDevice device, const VkSamplerCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkSampler* pSampler) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3229 | { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 3230 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 3231 | VkResult result = dev_data->device_dispatch_table->CreateSampler(device, pCreateInfo, pAllocator, pSampler); |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 3232 | if (VK_SUCCESS == result) { |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3233 | loader_platform_thread_lock_mutex(&globalLock); |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 3234 | dev_data->sampleMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo)); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3235 | loader_platform_thread_unlock_mutex(&globalLock); |
| 3236 | } |
| 3237 | return result; |
| 3238 | } |
| 3239 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3240 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDescriptorSetLayout* pSetLayout) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3241 | { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 3242 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 3243 | VkResult result = dev_data->device_dispatch_table->CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 3244 | if (VK_SUCCESS == result) { |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 3245 | // TODOSC : Capture layout bindings set |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3246 | LAYOUT_NODE* pNewNode = new LAYOUT_NODE; |
| 3247 | if (NULL == pNewNode) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3248 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t) *pSetLayout, 0, DRAWSTATE_OUT_OF_MEMORY, "DS", |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3249 | "Out of memory while attempting to allocate LAYOUT_NODE in vkCreateDescriptorSetLayout()")) |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 3250 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3251 | } |
Courtney Goeltzenleuchter | 382489d | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 3252 | memcpy((void*)&pNewNode->createInfo, pCreateInfo, sizeof(VkDescriptorSetLayoutCreateInfo)); |
Chia-I Wu | f03cbf7 | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 3253 | pNewNode->createInfo.pBinding = new VkDescriptorSetLayoutBinding[pCreateInfo->bindingCount]; |
| 3254 | memcpy((void*)pNewNode->createInfo.pBinding, pCreateInfo->pBinding, sizeof(VkDescriptorSetLayoutBinding)*pCreateInfo->bindingCount); |
Chia-I Wu | b5689ee | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 3255 | // g++ does not like reserve with size 0 |
| 3256 | if (pCreateInfo->bindingCount) |
| 3257 | pNewNode->bindings.reserve(pCreateInfo->bindingCount); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3258 | uint32_t totalCount = 0; |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 3259 | for (uint32_t i=0; i<pCreateInfo->bindingCount; i++) { |
Chia-I Wu | b5689ee | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 3260 | if (!pNewNode->bindings.insert(pCreateInfo->pBinding[i].binding).second) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3261 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t) *pSetLayout, 0, DRAWSTATE_INVALID_LAYOUT, "DS", |
Chia-I Wu | b5689ee | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 3262 | "duplicated binding number in VkDescriptorSetLayoutBinding")) |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 3263 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Chia-I Wu | b5689ee | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 3264 | } |
| 3265 | |
Chia-I Wu | 045654f | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3266 | totalCount += pCreateInfo->pBinding[i].descriptorCount; |
Chia-I Wu | f03cbf7 | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 3267 | if (pCreateInfo->pBinding[i].pImmutableSamplers) { |
| 3268 | VkSampler** ppIS = (VkSampler**)&pNewNode->createInfo.pBinding[i].pImmutableSamplers; |
Chia-I Wu | 045654f | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3269 | *ppIS = new VkSampler[pCreateInfo->pBinding[i].descriptorCount]; |
| 3270 | memcpy(*ppIS, pCreateInfo->pBinding[i].pImmutableSamplers, pCreateInfo->pBinding[i].descriptorCount*sizeof(VkSampler)); |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 3271 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3272 | } |
| 3273 | if (totalCount > 0) { |
Cody Northrop | 8a90832 | 2015-10-26 14:07:35 -0600 | [diff] [blame] | 3274 | pNewNode->descriptorTypes.resize(totalCount); |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 3275 | pNewNode->stageFlags.resize(totalCount); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3276 | uint32_t offset = 0; |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 3277 | uint32_t j = 0; |
Tobin Ehlis | 61ebb31 | 2015-11-04 12:28:28 -0700 | [diff] [blame] | 3278 | VkDescriptorType dType; |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 3279 | for (uint32_t i=0; i<pCreateInfo->bindingCount; i++) { |
Tobin Ehlis | 61ebb31 | 2015-11-04 12:28:28 -0700 | [diff] [blame] | 3280 | dType = pCreateInfo->pBinding[i].descriptorType; |
Chia-I Wu | 045654f | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3281 | for (j = 0; j < pCreateInfo->pBinding[i].descriptorCount; j++) { |
Tobin Ehlis | 61ebb31 | 2015-11-04 12:28:28 -0700 | [diff] [blame] | 3282 | pNewNode->descriptorTypes[offset + j] = dType; |
Chia-I Wu | f03cbf7 | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 3283 | pNewNode->stageFlags[offset + j] = pCreateInfo->pBinding[i].stageFlags; |
Tobin Ehlis | 61ebb31 | 2015-11-04 12:28:28 -0700 | [diff] [blame] | 3284 | if ((dType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) || |
| 3285 | (dType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) { |
| 3286 | pNewNode->dynamicDescriptorCount++; |
| 3287 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3288 | } |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 3289 | offset += j; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3290 | } |
| 3291 | } |
| 3292 | pNewNode->layout = *pSetLayout; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3293 | pNewNode->startIndex = 0; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3294 | pNewNode->endIndex = pNewNode->startIndex + totalCount - 1; |
| 3295 | assert(pNewNode->endIndex >= pNewNode->startIndex); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3296 | // Put new node at Head of global Layer list |
| 3297 | loader_platform_thread_lock_mutex(&globalLock); |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 3298 | dev_data->descriptorSetLayoutMap[*pSetLayout] = pNewNode; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3299 | loader_platform_thread_unlock_mutex(&globalLock); |
| 3300 | } |
| 3301 | return result; |
| 3302 | } |
| 3303 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3304 | VKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkPipelineLayout* pPipelineLayout) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3305 | { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 3306 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 3307 | VkResult result = dev_data->device_dispatch_table->CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 3308 | if (VK_SUCCESS == result) { |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 3309 | // TODOSC : Merge capture of the setLayouts per pipeline |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 3310 | PIPELINE_LAYOUT_NODE& plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 3311 | plNode.descriptorSetLayouts.resize(pCreateInfo->setLayoutCount); |
Tobin Ehlis | 91423d2 | 2015-10-20 10:11:55 -0600 | [diff] [blame] | 3312 | uint32_t i = 0; |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 3313 | for (i=0; i<pCreateInfo->setLayoutCount; ++i) { |
Tobin Ehlis | 91423d2 | 2015-10-20 10:11:55 -0600 | [diff] [blame] | 3314 | plNode.descriptorSetLayouts[i] = pCreateInfo->pSetLayouts[i]; |
| 3315 | } |
Cody Northrop | 8a90832 | 2015-10-26 14:07:35 -0600 | [diff] [blame] | 3316 | plNode.pushConstantRanges.resize(pCreateInfo->pushConstantRangeCount); |
Tobin Ehlis | 91423d2 | 2015-10-20 10:11:55 -0600 | [diff] [blame] | 3317 | for (i=0; i<pCreateInfo->pushConstantRangeCount; ++i) { |
| 3318 | plNode.pushConstantRanges[i] = pCreateInfo->pPushConstantRanges[i]; |
| 3319 | } |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 3320 | } |
| 3321 | return result; |
| 3322 | } |
| 3323 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3324 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDescriptorPool* pDescriptorPool) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3325 | { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 3326 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 3327 | VkResult result = dev_data->device_dispatch_table->CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 3328 | if (VK_SUCCESS == result) { |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 3329 | // Insert this pool into Global Pool LL at head |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3330 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, (uint64_t) *pDescriptorPool, 0, DRAWSTATE_OUT_OF_MEMORY, "DS", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 3331 | "Created Descriptor Pool %#" PRIxLEAST64, (uint64_t) *pDescriptorPool)) |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 3332 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3333 | loader_platform_thread_lock_mutex(&globalLock); |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 3334 | DESCRIPTOR_POOL_NODE* pNewNode = new DESCRIPTOR_POOL_NODE(*pDescriptorPool, pCreateInfo); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3335 | if (NULL == pNewNode) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3336 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, (uint64_t) *pDescriptorPool, 0, DRAWSTATE_OUT_OF_MEMORY, "DS", |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 3337 | "Out of memory while attempting to allocate DESCRIPTOR_POOL_NODE in vkCreateDescriptorPool()")) |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 3338 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 3339 | } else { |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 3340 | dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3341 | } |
| 3342 | loader_platform_thread_unlock_mutex(&globalLock); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 3343 | } else { |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 3344 | // Need to do anything if pool create fails? |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3345 | } |
| 3346 | return result; |
| 3347 | } |
| 3348 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3349 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3350 | { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 3351 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Courtney Goeltzenleuchter | 831c183 | 2015-10-23 14:21:05 -0600 | [diff] [blame] | 3352 | VkResult result = dev_data->device_dispatch_table->ResetDescriptorPool(device, descriptorPool, flags); |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 3353 | if (VK_SUCCESS == result) { |
Courtney Goeltzenleuchter | 831c183 | 2015-10-23 14:21:05 -0600 | [diff] [blame] | 3354 | clearDescriptorPool(dev_data, device, descriptorPool, flags); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3355 | } |
| 3356 | return result; |
| 3357 | } |
| 3358 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3359 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo* pAllocateInfo, VkDescriptorSet* pDescriptorSets) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3360 | { |
Tobin Ehlis | c6457d2 | 2015-10-20 16:16:04 -0600 | [diff] [blame] | 3361 | VkBool32 skipCall = VK_FALSE; |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 3362 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | c6457d2 | 2015-10-20 16:16:04 -0600 | [diff] [blame] | 3363 | // Verify that requested descriptorSets are available in pool |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 3364 | DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool); |
Tobin Ehlis | c6457d2 | 2015-10-20 16:16:04 -0600 | [diff] [blame] | 3365 | if (!pPoolNode) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3366 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, (uint64_t) pAllocateInfo->descriptorPool, 0, DRAWSTATE_INVALID_POOL, "DS", |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3367 | "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", (uint64_t) pAllocateInfo->descriptorPool); |
Tobin Ehlis | c6457d2 | 2015-10-20 16:16:04 -0600 | [diff] [blame] | 3368 | } else { // Make sure pool has all the available descriptors before calling down chain |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3369 | skipCall |= validate_descriptor_availability_in_pool(dev_data, pPoolNode, pAllocateInfo->setLayoutCount, pAllocateInfo->pSetLayouts); |
Tobin Ehlis | c6457d2 | 2015-10-20 16:16:04 -0600 | [diff] [blame] | 3370 | } |
| 3371 | if (skipCall) |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 3372 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3373 | VkResult result = dev_data->device_dispatch_table->AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); |
Cody Northrop | c8aa4a5 | 2015-08-03 12:47:29 -0600 | [diff] [blame] | 3374 | if (VK_SUCCESS == result) { |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 3375 | DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool); |
Tobin Ehlis | c6457d2 | 2015-10-20 16:16:04 -0600 | [diff] [blame] | 3376 | if (pPoolNode) { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3377 | if (pAllocateInfo->setLayoutCount == 0) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3378 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, pAllocateInfo->setLayoutCount, 0, DRAWSTATE_NONE, "DS", |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3379 | "AllocateDescriptorSets called with 0 count"); |
Cody Northrop | c8aa4a5 | 2015-08-03 12:47:29 -0600 | [diff] [blame] | 3380 | } |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3381 | for (uint32_t i = 0; i < pAllocateInfo->setLayoutCount; i++) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3382 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_NONE, "DS", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 3383 | "Created Descriptor Set %#" PRIxLEAST64, (uint64_t) pDescriptorSets[i]); |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 3384 | // Create new set node and add to head of pool nodes |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3385 | SET_NODE* pNewNode = new SET_NODE; |
| 3386 | if (NULL == pNewNode) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3387 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_OUT_OF_MEMORY, "DS", |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3388 | "Out of memory while attempting to allocate SET_NODE in vkAllocateDescriptorSets()")) |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 3389 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 3390 | } else { |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3391 | memset(pNewNode, 0, sizeof(SET_NODE)); |
Tobin Ehlis | f6e93e0 | 2015-10-19 12:09:13 -0600 | [diff] [blame] | 3392 | // TODO : Pool should store a total count of each type of Descriptor available |
| 3393 | // When descriptors are allocated, decrement the count and validate here |
| 3394 | // that the count doesn't go below 0. One reset/free need to bump count back up. |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 3395 | // Insert set at head of Set LL for this pool |
| 3396 | pNewNode->pNext = pPoolNode->pSets; |
| 3397 | pPoolNode->pSets = pNewNode; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3398 | LAYOUT_NODE* pLayout = getLayoutNode(dev_data, pAllocateInfo->pSetLayouts[i]); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3399 | if (NULL == pLayout) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3400 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t) pAllocateInfo->pSetLayouts[i], 0, DRAWSTATE_INVALID_LAYOUT, "DS", |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3401 | "Unable to find set layout node for layout %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", (uint64_t) pAllocateInfo->pSetLayouts[i])) |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 3402 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3403 | } |
Tobin Ehlis | dd82f6b | 2015-04-03 12:01:11 -0600 | [diff] [blame] | 3404 | pNewNode->pLayout = pLayout; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3405 | pNewNode->pool = pAllocateInfo->descriptorPool; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3406 | pNewNode->set = pDescriptorSets[i]; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3407 | pNewNode->descriptorCount = pLayout->endIndex + 1; |
| 3408 | if (pNewNode->descriptorCount) { |
| 3409 | size_t descriptorArraySize = sizeof(GENERIC_HEADER*)*pNewNode->descriptorCount; |
| 3410 | pNewNode->ppDescriptors = new GENERIC_HEADER*[descriptorArraySize]; |
| 3411 | memset(pNewNode->ppDescriptors, 0, descriptorArraySize); |
| 3412 | } |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 3413 | dev_data->setMap[pDescriptorSets[i]] = pNewNode; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3414 | } |
| 3415 | } |
| 3416 | } |
| 3417 | } |
| 3418 | return result; |
| 3419 | } |
| 3420 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3421 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet* pDescriptorSets) |
Tony Barbour | b857d31 | 2015-07-10 10:50:45 -0600 | [diff] [blame] | 3422 | { |
Tobin Ehlis | 3c54311 | 2015-10-08 13:13:50 -0600 | [diff] [blame] | 3423 | VkBool32 skipCall = VK_FALSE; |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 3424 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 3425 | DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, descriptorPool); |
Courtney Goeltzenleuchter | 831c183 | 2015-10-23 14:21:05 -0600 | [diff] [blame] | 3426 | if (pPoolNode && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pPoolNode->createInfo.flags)) { |
| 3427 | // Can't Free from a NON_FREE pool |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3428 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, (uint64_t)device, 0, DRAWSTATE_CANT_FREE_FROM_NON_FREE_POOL, "DS", |
Courtney Goeltzenleuchter | 831c183 | 2015-10-23 14:21:05 -0600 | [diff] [blame] | 3429 | "It is invalid to call vkFreeDescriptorSets() with a pool created without setting VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT."); |
Tobin Ehlis | 3c54311 | 2015-10-08 13:13:50 -0600 | [diff] [blame] | 3430 | } |
| 3431 | if (skipCall) |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 3432 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 3433 | VkResult result = dev_data->device_dispatch_table->FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); |
Tobin Ehlis | c6457d2 | 2015-10-20 16:16:04 -0600 | [diff] [blame] | 3434 | if (VK_SUCCESS == result) { |
| 3435 | // For each freed descriptor add it back into the pool as available |
| 3436 | for (uint32_t i=0; i<count; ++i) { |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 3437 | SET_NODE* pSet = dev_data->setMap[pDescriptorSets[i]]; // getSetNode() without locking |
Tobin Ehlis | c6457d2 | 2015-10-20 16:16:04 -0600 | [diff] [blame] | 3438 | LAYOUT_NODE* pLayout = pSet->pLayout; |
Chia-I Wu | c51b121 | 2015-10-27 19:25:11 +0800 | [diff] [blame] | 3439 | uint32_t typeIndex = 0, poolSizeCount = 0; |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 3440 | for (uint32_t j=0; j<pLayout->createInfo.bindingCount; ++j) { |
Chia-I Wu | f03cbf7 | 2015-10-31 00:31:16 +0800 | [diff] [blame] | 3441 | typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBinding[j].descriptorType); |
Chia-I Wu | 045654f | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3442 | poolSizeCount = pLayout->createInfo.pBinding[j].descriptorCount; |
Chia-I Wu | c51b121 | 2015-10-27 19:25:11 +0800 | [diff] [blame] | 3443 | pPoolNode->availableDescriptorTypeCount[typeIndex] += poolSizeCount; |
Tobin Ehlis | c6457d2 | 2015-10-20 16:16:04 -0600 | [diff] [blame] | 3444 | } |
| 3445 | } |
| 3446 | } |
| 3447 | // TODO : Any other clean-up or book-keeping to do here? |
Tony Barbour | b857d31 | 2015-07-10 10:50:45 -0600 | [diff] [blame] | 3448 | return result; |
| 3449 | } |
| 3450 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3451 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet* pDescriptorWrites, uint32_t descriptorCopyCount, const VkCopyDescriptorSet* pDescriptorCopies) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3452 | { |
Tobin Ehlis | 68fbd44 | 2015-10-27 12:25:35 -0600 | [diff] [blame] | 3453 | // dsUpdate will return VK_TRUE only if a bailout error occurs, so we want to call down tree when update returns VK_FALSE |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 3454 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chia-I Wu | 483e770 | 2015-10-26 17:20:32 +0800 | [diff] [blame] | 3455 | if (!dsUpdate(dev_data, device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, pDescriptorCopies)) { |
| 3456 | dev_data->device_dispatch_table->UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, pDescriptorCopies); |
Jon Ashburn | e0fa228 | 2015-05-20 09:00:28 -0600 | [diff] [blame] | 3457 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3458 | } |
| 3459 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3460 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo* pCreateInfo, VkCommandBuffer* pCommandBuffer) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3461 | { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 3462 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3463 | VkResult result = dev_data->device_dispatch_table->AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 3464 | if (VK_SUCCESS == result) { |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 3465 | for (auto i = 0; i < pCreateInfo->bufferCount; i++) { |
| 3466 | // Validate command pool |
| 3467 | if (dev_data->commandPoolMap.find(pCreateInfo->commandPool) != dev_data->commandPoolMap.end()) { |
Mark Lobodzinski | 13b6674 | 2015-11-20 14:33:48 -0700 | [diff] [blame] | 3468 | loader_platform_thread_lock_mutex(&globalLock); |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 3469 | // Add command buffer to its commandPool map |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3470 | dev_data->commandPoolMap[pCreateInfo->commandPool].commandBuffers.push_back(pCommandBuffer[i]); |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 3471 | GLOBAL_CB_NODE* pCB = new GLOBAL_CB_NODE; |
| 3472 | // Add command buffer to map |
| 3473 | dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; |
Mark Lobodzinski | 13b6674 | 2015-11-20 14:33:48 -0700 | [diff] [blame] | 3474 | loader_platform_thread_unlock_mutex(&globalLock); |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 3475 | resetCB(dev_data, pCommandBuffer[i]); |
| 3476 | pCB->commandBuffer = pCommandBuffer[i]; |
| 3477 | pCB->createInfo = *pCreateInfo; |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 3478 | } |
| 3479 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3480 | } |
| 3481 | return result; |
| 3482 | } |
| 3483 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3484 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo* pBeginInfo) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3485 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3486 | VkBool32 skipCall = false; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3487 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | 90bf5b0 | 2015-08-04 16:24:20 -0600 | [diff] [blame] | 3488 | // Validate command buffer level |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3489 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Mark Lobodzinski | 90bf5b0 | 2015-08-04 16:24:20 -0600 | [diff] [blame] | 3490 | if (pCB) { |
Mark Lobodzinski | a142086 | 2015-11-19 13:22:11 -0700 | [diff] [blame] | 3491 | if (pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) { |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 3492 | if (pBeginInfo->renderPass || pBeginInfo->framebuffer) { |
Mark Lobodzinski | 90bf5b0 | 2015-08-04 16:24:20 -0600 | [diff] [blame] | 3493 | // These should be NULL for a Primary CB |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3494 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, 0, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3495 | "vkBeginCommandBuffer(): Primary Command Buffer (%p) may not specify framebuffer or renderpass parameters", (void*)commandBuffer); |
Mark Lobodzinski | 90bf5b0 | 2015-08-04 16:24:20 -0600 | [diff] [blame] | 3496 | } |
| 3497 | } else { |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 3498 | if (!pBeginInfo->renderPass || !pBeginInfo->framebuffer) { |
Mark Lobodzinski | 90bf5b0 | 2015-08-04 16:24:20 -0600 | [diff] [blame] | 3499 | // These should NOT be null for an Secondary CB |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3500 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, 0, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3501 | "vkBeginCommandBuffer(): Secondary Command Buffers (%p) must specify framebuffer and renderpass parameters", (void*)commandBuffer); |
Mark Lobodzinski | 90bf5b0 | 2015-08-04 16:24:20 -0600 | [diff] [blame] | 3502 | } |
| 3503 | } |
Tobin Ehlis | 0cea408 | 2015-08-18 07:10:58 -0600 | [diff] [blame] | 3504 | pCB->beginInfo = *pBeginInfo; |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3505 | if (CB_RECORDING == pCB->state) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3506 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, 0, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3507 | "vkBeginCommandBuffer(): Cannot call Begin on CB (%#" PRIxLEAST64 ") in the RECORDING state. Must first call vkEndCommandBuffer().", (uint64_t)commandBuffer); |
| 3508 | } else if (CB_RECORDED == pCB->state) { |
| 3509 | VkCommandPool cmdPool = pCB->createInfo.commandPool; |
| 3510 | if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3511 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3512 | 0, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", |
| 3513 | "Call to vkBeginCommandBuffer() on command buffer (%#" PRIxLEAST64 ") attempts to implicitly reset cmdBuffer created from command pool (%#" PRIxLEAST64 ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", |
| 3514 | (uint64_t) commandBuffer, (uint64_t) cmdPool); |
| 3515 | } |
| 3516 | } |
Tobin Ehlis | 0cea408 | 2015-08-18 07:10:58 -0600 | [diff] [blame] | 3517 | } else { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3518 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3519 | "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB %p!", (void*)commandBuffer); |
Mark Lobodzinski | 90bf5b0 | 2015-08-04 16:24:20 -0600 | [diff] [blame] | 3520 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3521 | if (skipCall) { |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 3522 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Courtney Goeltzenleuchter | 3abd86e | 2015-09-04 15:03:52 -0600 | [diff] [blame] | 3523 | } |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3524 | VkResult result = dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo); |
Mark Lobodzinski | 2ad3559 | 2015-11-12 16:14:04 -0700 | [diff] [blame] | 3525 | if ((VK_SUCCESS == result) && (pCB != NULL)) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3526 | if (CB_RECORDED == pCB->state) { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3527 | resetCB(dev_data, commandBuffer); |
Mark Lobodzinski | 2ad3559 | 2015-11-12 16:14:04 -0700 | [diff] [blame] | 3528 | } |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3529 | pCB->state = CB_RECORDING; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3530 | } |
| 3531 | return result; |
| 3532 | } |
| 3533 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3534 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEndCommandBuffer(VkCommandBuffer commandBuffer) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3535 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3536 | VkBool32 skipCall = VK_FALSE; |
Courtney Goeltzenleuchter | a54b76a | 2015-09-04 13:39:59 -0600 | [diff] [blame] | 3537 | VkResult result = VK_SUCCESS; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3538 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 3539 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 3540 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3541 | if (pCB->state != CB_RECORDING) { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3542 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkEndCommandBuffer()"); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3543 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3544 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3545 | if (VK_FALSE == skipCall) { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3546 | result = dev_data->device_dispatch_table->EndCommandBuffer(commandBuffer); |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3547 | if (VK_SUCCESS == result) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3548 | pCB->state = CB_RECORDED; |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3549 | // Reset CB status flags |
| 3550 | pCB->status = 0; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3551 | printCB(dev_data, commandBuffer); |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3552 | } |
| 3553 | } else { |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 3554 | result = VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3555 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3556 | return result; |
| 3557 | } |
| 3558 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3559 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3560 | { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3561 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3562 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3563 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
| 3564 | VkCommandPool cmdPool = pCB->createInfo.commandPool; |
| 3565 | if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3566 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t) commandBuffer, |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3567 | 0, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", |
| 3568 | "Attempt to reset command buffer (%#" PRIxLEAST64 ") created from command pool (%#" PRIxLEAST64 ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", |
| 3569 | (uint64_t) commandBuffer, (uint64_t) cmdPool); |
| 3570 | } |
| 3571 | if (skipCall) |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 3572 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3573 | VkResult result = dev_data->device_dispatch_table->ResetCommandBuffer(commandBuffer, flags); |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 3574 | if (VK_SUCCESS == result) { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3575 | resetCB(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3576 | } |
| 3577 | return result; |
| 3578 | } |
| 3579 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3580 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3581 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3582 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3583 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 3584 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3585 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3586 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 3587 | skipCall |= addCmd(dev_data, pCB, CMD_BINDPIPELINE); |
Mark Lobodzinski | 7bc3a9e | 2015-12-17 09:24:14 -0700 | [diff] [blame] | 3588 | PIPELINE_NODE* pPN = getPipeline(dev_data, pipeline); |
| 3589 | if (pPN) { |
| 3590 | pCB->lastBoundPipeline = pipeline; |
| 3591 | loader_platform_thread_lock_mutex(&globalLock); |
| 3592 | set_cb_pso_status(pCB, pPN); |
| 3593 | g_lastBoundPipeline = pPN; |
| 3594 | loader_platform_thread_unlock_mutex(&globalLock); |
| 3595 | skipCall |= validatePipelineState(dev_data, pCB, pipelineBindPoint, pipeline); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 3596 | } else { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3597 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, (uint64_t) pipeline, |
Mark Lobodzinski | 7bc3a9e | 2015-12-17 09:24:14 -0700 | [diff] [blame] | 3598 | 0, DRAWSTATE_INVALID_PIPELINE, "DS", |
| 3599 | "Attempt to bind Pipeline %#" PRIxLEAST64 " that doesn't exist!", reinterpret_cast<uint64_t>(pipeline)); |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3600 | |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 3601 | } |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 3602 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3603 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindPipeline()"); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3604 | } |
| 3605 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3606 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3607 | dev_data->device_dispatch_table->CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3608 | } |
| 3609 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3610 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetViewport( |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3611 | VkCommandBuffer commandBuffer, |
Courtney Goeltzenleuchter | 932cdb5 | 2015-09-21 11:44:06 -0600 | [diff] [blame] | 3612 | uint32_t viewportCount, |
| 3613 | const VkViewport* pViewports) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3614 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3615 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3616 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 3617 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 3618 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3619 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 3620 | skipCall |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 3621 | loader_platform_thread_lock_mutex(&globalLock); |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3622 | pCB->status |= CBSTATUS_VIEWPORT_SET; |
Courtney Goeltzenleuchter | 932cdb5 | 2015-09-21 11:44:06 -0600 | [diff] [blame] | 3623 | pCB->viewports.resize(viewportCount); |
Tobin Ehlis | 9e839e5 | 2015-10-01 11:15:13 -0600 | [diff] [blame] | 3624 | memcpy(pCB->viewports.data(), pViewports, viewportCount * sizeof(VkViewport)); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 3625 | loader_platform_thread_unlock_mutex(&globalLock); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 3626 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3627 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetViewport()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 3628 | } |
| 3629 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3630 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3631 | dev_data->device_dispatch_table->CmdSetViewport(commandBuffer, viewportCount, pViewports); |
Courtney Goeltzenleuchter | 932cdb5 | 2015-09-21 11:44:06 -0600 | [diff] [blame] | 3632 | } |
| 3633 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3634 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetScissor( |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3635 | VkCommandBuffer commandBuffer, |
Courtney Goeltzenleuchter | 932cdb5 | 2015-09-21 11:44:06 -0600 | [diff] [blame] | 3636 | uint32_t scissorCount, |
| 3637 | const VkRect2D* pScissors) |
| 3638 | { |
| 3639 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3640 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 3641 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Courtney Goeltzenleuchter | 932cdb5 | 2015-09-21 11:44:06 -0600 | [diff] [blame] | 3642 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3643 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 3644 | skipCall |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE); |
Courtney Goeltzenleuchter | 932cdb5 | 2015-09-21 11:44:06 -0600 | [diff] [blame] | 3645 | loader_platform_thread_lock_mutex(&globalLock); |
| 3646 | pCB->status |= CBSTATUS_SCISSOR_SET; |
| 3647 | pCB->scissors.resize(scissorCount); |
Tobin Ehlis | 9e839e5 | 2015-10-01 11:15:13 -0600 | [diff] [blame] | 3648 | memcpy(pCB->scissors.data(), pScissors, scissorCount * sizeof(VkRect2D)); |
Courtney Goeltzenleuchter | 932cdb5 | 2015-09-21 11:44:06 -0600 | [diff] [blame] | 3649 | loader_platform_thread_unlock_mutex(&globalLock); |
| 3650 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3651 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetScissor()"); |
Courtney Goeltzenleuchter | 932cdb5 | 2015-09-21 11:44:06 -0600 | [diff] [blame] | 3652 | } |
| 3653 | } |
| 3654 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3655 | dev_data->device_dispatch_table->CmdSetScissor(commandBuffer, scissorCount, pScissors); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3656 | } |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3657 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3658 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3659 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3660 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3661 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 3662 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3663 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3664 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 3665 | skipCall |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE); |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3666 | /* TODO: Do we still need this lock? */ |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3667 | loader_platform_thread_lock_mutex(&globalLock); |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3668 | pCB->status |= CBSTATUS_LINE_WIDTH_SET; |
| 3669 | pCB->lineWidth = lineWidth; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3670 | loader_platform_thread_unlock_mutex(&globalLock); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3671 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3672 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDynamicLineWidthState()"); |
Cody Northrop | f5bd225 | 2015-08-17 11:10:49 -0600 | [diff] [blame] | 3673 | } |
| 3674 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3675 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3676 | dev_data->device_dispatch_table->CmdSetLineWidth(commandBuffer, lineWidth); |
Cody Northrop | f5bd225 | 2015-08-17 11:10:49 -0600 | [diff] [blame] | 3677 | } |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3678 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3679 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetDepthBias( |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3680 | VkCommandBuffer commandBuffer, |
Chia-I Wu | fa950c5 | 2015-10-26 19:08:09 +0800 | [diff] [blame] | 3681 | float depthBiasConstantFactor, |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3682 | float depthBiasClamp, |
Chia-I Wu | fa950c5 | 2015-10-26 19:08:09 +0800 | [diff] [blame] | 3683 | float depthBiasSlopeFactor) |
Cody Northrop | f5bd225 | 2015-08-17 11:10:49 -0600 | [diff] [blame] | 3684 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3685 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3686 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 3687 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Cody Northrop | f5bd225 | 2015-08-17 11:10:49 -0600 | [diff] [blame] | 3688 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3689 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 3690 | skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE); |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3691 | pCB->status |= CBSTATUS_DEPTH_BIAS_SET; |
Chia-I Wu | fa950c5 | 2015-10-26 19:08:09 +0800 | [diff] [blame] | 3692 | pCB->depthBiasConstantFactor = depthBiasConstantFactor; |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3693 | pCB->depthBiasClamp = depthBiasClamp; |
Chia-I Wu | fa950c5 | 2015-10-26 19:08:09 +0800 | [diff] [blame] | 3694 | pCB->depthBiasSlopeFactor = depthBiasSlopeFactor; |
Cody Northrop | f5bd225 | 2015-08-17 11:10:49 -0600 | [diff] [blame] | 3695 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3696 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetDepthBias()"); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3697 | } |
| 3698 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3699 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3700 | dev_data->device_dispatch_table->CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, depthBiasSlopeFactor); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3701 | } |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3702 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3703 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3704 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3705 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3706 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 3707 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3708 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3709 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 3710 | skipCall |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE); |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3711 | pCB->status |= CBSTATUS_BLEND_SET; |
Chia-I Wu | 7e47070 | 2015-10-26 17:24:52 +0800 | [diff] [blame] | 3712 | memcpy(pCB->blendConstants, blendConstants, 4 * sizeof(float)); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3713 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3714 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetBlendConstants()"); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3715 | } |
| 3716 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3717 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3718 | dev_data->device_dispatch_table->CmdSetBlendConstants(commandBuffer, blendConstants); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3719 | } |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3720 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3721 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetDepthBounds( |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3722 | VkCommandBuffer commandBuffer, |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3723 | float minDepthBounds, |
| 3724 | float maxDepthBounds) |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3725 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3726 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3727 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 3728 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3729 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3730 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 3731 | skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE); |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3732 | pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; |
| 3733 | pCB->minDepthBounds = minDepthBounds; |
| 3734 | pCB->maxDepthBounds = maxDepthBounds; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3735 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3736 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetDepthBounds()"); |
Cody Northrop | 2605cb0 | 2015-08-18 15:21:16 -0600 | [diff] [blame] | 3737 | } |
| 3738 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3739 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3740 | dev_data->device_dispatch_table->CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); |
Cody Northrop | 2605cb0 | 2015-08-18 15:21:16 -0600 | [diff] [blame] | 3741 | } |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3742 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3743 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetStencilCompareMask( |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3744 | VkCommandBuffer commandBuffer, |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3745 | VkStencilFaceFlags faceMask, |
Chia-I Wu | c51b121 | 2015-10-27 19:25:11 +0800 | [diff] [blame] | 3746 | uint32_t compareMask) |
Cody Northrop | 2605cb0 | 2015-08-18 15:21:16 -0600 | [diff] [blame] | 3747 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3748 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3749 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 3750 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Cody Northrop | 2605cb0 | 2015-08-18 15:21:16 -0600 | [diff] [blame] | 3751 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3752 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 3753 | skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE); |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3754 | if (faceMask & VK_STENCIL_FACE_FRONT_BIT) { |
Chia-I Wu | c51b121 | 2015-10-27 19:25:11 +0800 | [diff] [blame] | 3755 | pCB->front.compareMask = compareMask; |
Cody Northrop | 2605cb0 | 2015-08-18 15:21:16 -0600 | [diff] [blame] | 3756 | } |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3757 | if (faceMask & VK_STENCIL_FACE_BACK_BIT) { |
Chia-I Wu | c51b121 | 2015-10-27 19:25:11 +0800 | [diff] [blame] | 3758 | pCB->back.compareMask = compareMask; |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3759 | } |
| 3760 | /* TODO: Do we need to track front and back separately? */ |
| 3761 | /* TODO: We aren't capturing the faceMask, do we need to? */ |
| 3762 | pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; |
Cody Northrop | 2605cb0 | 2015-08-18 15:21:16 -0600 | [diff] [blame] | 3763 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3764 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetStencilCompareMask()"); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3765 | } |
| 3766 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3767 | if (VK_FALSE == skipCall) |
Chia-I Wu | c51b121 | 2015-10-27 19:25:11 +0800 | [diff] [blame] | 3768 | dev_data->device_dispatch_table->CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 3769 | } |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3770 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3771 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetStencilWriteMask( |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3772 | VkCommandBuffer commandBuffer, |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3773 | VkStencilFaceFlags faceMask, |
Chia-I Wu | c51b121 | 2015-10-27 19:25:11 +0800 | [diff] [blame] | 3774 | uint32_t writeMask) |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3775 | { |
| 3776 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3777 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 3778 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3779 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3780 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 3781 | skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE); |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3782 | if (faceMask & VK_STENCIL_FACE_FRONT_BIT) { |
Chia-I Wu | c51b121 | 2015-10-27 19:25:11 +0800 | [diff] [blame] | 3783 | pCB->front.writeMask = writeMask; |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3784 | } |
| 3785 | if (faceMask & VK_STENCIL_FACE_BACK_BIT) { |
Chia-I Wu | c51b121 | 2015-10-27 19:25:11 +0800 | [diff] [blame] | 3786 | pCB->back.writeMask = writeMask; |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3787 | } |
| 3788 | pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; |
| 3789 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3790 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetStencilWriteMask()"); |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3791 | } |
| 3792 | } |
| 3793 | if (VK_FALSE == skipCall) |
Chia-I Wu | c51b121 | 2015-10-27 19:25:11 +0800 | [diff] [blame] | 3794 | dev_data->device_dispatch_table->CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3795 | } |
| 3796 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3797 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetStencilReference( |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3798 | VkCommandBuffer commandBuffer, |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3799 | VkStencilFaceFlags faceMask, |
Chia-I Wu | c51b121 | 2015-10-27 19:25:11 +0800 | [diff] [blame] | 3800 | uint32_t reference) |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3801 | { |
| 3802 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3803 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 3804 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3805 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3806 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 3807 | skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE); |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3808 | if (faceMask & VK_STENCIL_FACE_FRONT_BIT) { |
Chia-I Wu | c51b121 | 2015-10-27 19:25:11 +0800 | [diff] [blame] | 3809 | pCB->front.reference = reference; |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3810 | } |
| 3811 | if (faceMask & VK_STENCIL_FACE_BACK_BIT) { |
Chia-I Wu | c51b121 | 2015-10-27 19:25:11 +0800 | [diff] [blame] | 3812 | pCB->back.reference = reference; |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3813 | } |
| 3814 | pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; |
| 3815 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3816 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetStencilReference()"); |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3817 | } |
| 3818 | } |
| 3819 | if (VK_FALSE == skipCall) |
Chia-I Wu | c51b121 | 2015-10-27 19:25:11 +0800 | [diff] [blame] | 3820 | dev_data->device_dispatch_table->CmdSetStencilReference(commandBuffer, faceMask, reference); |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 3821 | } |
| 3822 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3823 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, uint32_t firstSet, uint32_t setCount, const VkDescriptorSet* pDescriptorSets, uint32_t dynamicOffsetCount, const uint32_t* pDynamicOffsets) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3824 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3825 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3826 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 3827 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3828 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3829 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | e407678 | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 3830 | if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3831 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 3832 | "Incorrectly binding compute DescriptorSets during active RenderPass (%#" PRIxLEAST64 ")", (uint64_t) pCB->activeRenderPass); |
Tobin Ehlis | e407678 | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 3833 | } else if ((VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) && (!pCB->activeRenderPass)) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3834 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", |
Tobin Ehlis | e407678 | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 3835 | "Incorrectly binding graphics DescriptorSets without an active RenderPass"); |
Tobin Ehlis | d28acef | 2015-09-09 15:12:35 -0600 | [diff] [blame] | 3836 | } else { |
Tobin Ehlis | 61ebb31 | 2015-11-04 12:28:28 -0700 | [diff] [blame] | 3837 | // Track total count of dynamic descriptor types to make sure we have an offset for each one |
| 3838 | uint32_t totalDynamicDescriptors = 0; |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 3839 | string errorString = ""; |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 3840 | uint32_t lastSetIndex = firstSet+setCount-1; |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 3841 | if (lastSetIndex >= pCB->boundDescriptorSets.size()) |
| 3842 | pCB->boundDescriptorSets.resize(lastSetIndex+1); |
| 3843 | VkDescriptorSet oldFinalBoundSet = pCB->boundDescriptorSets[lastSetIndex]; |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 3844 | for (uint32_t i=0; i<setCount; i++) { |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 3845 | SET_NODE* pSet = getSetNode(dev_data, pDescriptorSets[i]); |
Tobin Ehlis | 55c1c60 | 2015-06-24 17:27:33 -0600 | [diff] [blame] | 3846 | if (pSet) { |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 3847 | loader_platform_thread_lock_mutex(&globalLock); |
| 3848 | pCB->lastBoundDescriptorSet = pDescriptorSets[i]; |
Tobin Ehlis | c6c3d6d | 2015-06-22 17:20:50 -0600 | [diff] [blame] | 3849 | pCB->lastBoundPipelineLayout = layout; |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 3850 | pCB->boundDescriptorSets[i+firstSet] = pDescriptorSets[i]; |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 3851 | loader_platform_thread_unlock_mutex(&globalLock); |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3852 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_NONE, "DS", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 3853 | "DS %#" PRIxLEAST64 " bound on pipeline %s", (uint64_t) pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint)); |
Tobin Ehlis | 61ebb31 | 2015-11-04 12:28:28 -0700 | [diff] [blame] | 3854 | if (!pSet->pUpdateStructs) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3855 | // TODO: Verify against Valid Usage |
| 3856 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 3857 | "DS %#" PRIxLEAST64 " bound but it was never updated. You may want to either update it or not bind it.", (uint64_t) pDescriptorSets[i]); |
Tobin Ehlis | 61ebb31 | 2015-11-04 12:28:28 -0700 | [diff] [blame] | 3858 | } |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 3859 | // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout |
| 3860 | if (!verify_set_layout_compatibility(dev_data, pSet, layout, i+firstSet, errorString)) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3861 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 3862 | "descriptorSet #%u being bound is not compatible with overlapping layout in pipelineLayout due to: %s", i, errorString.c_str()); |
| 3863 | } |
Tobin Ehlis | 61ebb31 | 2015-11-04 12:28:28 -0700 | [diff] [blame] | 3864 | totalDynamicDescriptors += pSet->pLayout->dynamicDescriptorCount; |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 3865 | } else { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3866 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_INVALID_SET, "DS", |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 3867 | "Attempt to bind DS %#" PRIxLEAST64 " that doesn't exist!", (uint64_t) pDescriptorSets[i]); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 3868 | } |
Tobin Ehlis | 0b551cd | 2015-05-28 12:10:17 -0600 | [diff] [blame] | 3869 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 3870 | skipCall |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS); |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 3871 | // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update |
| 3872 | if (firstSet > 0) { // Check set #s below the first bound set |
| 3873 | for (uint32_t i=0; i<firstSet; ++i) { |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 3874 | if (pCB->boundDescriptorSets[i] && !verify_set_layout_compatibility(dev_data, dev_data->setMap[pCB->boundDescriptorSets[i]], layout, i, errorString)) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3875 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERF_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pCB->boundDescriptorSets[i], 0, DRAWSTATE_NONE, "DS", |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 3876 | "DescriptorSetDS %#" PRIxLEAST64 " previously bound as set #%u was disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", (uint64_t) pCB->boundDescriptorSets[i], i, (uint64_t) layout); |
| 3877 | pCB->boundDescriptorSets[i] = VK_NULL_HANDLE; |
| 3878 | } |
| 3879 | } |
| 3880 | } |
| 3881 | // Check if newly last bound set invalidates any remaining bound sets |
| 3882 | if ((pCB->boundDescriptorSets.size()-1) > (lastSetIndex)) { |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 3883 | if (oldFinalBoundSet && !verify_set_layout_compatibility(dev_data, dev_data->setMap[oldFinalBoundSet], layout, lastSetIndex, errorString)) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3884 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERF_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) oldFinalBoundSet, 0, DRAWSTATE_NONE, "DS", |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 3885 | "DescriptorSetDS %#" PRIxLEAST64 " previously bound as set #%u is incompatible with set %#" PRIxLEAST64 " newly bound as set #%u so set #%u and any subsequent sets were disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", (uint64_t) oldFinalBoundSet, lastSetIndex, (uint64_t) pCB->boundDescriptorSets[lastSetIndex], lastSetIndex, lastSetIndex+1, (uint64_t) layout); |
Tobin Ehlis | 982099b | 2015-11-05 09:52:49 -0700 | [diff] [blame] | 3886 | pCB->boundDescriptorSets.resize(lastSetIndex+1); |
| 3887 | } |
| 3888 | } |
Tobin Ehlis | 61ebb31 | 2015-11-04 12:28:28 -0700 | [diff] [blame] | 3889 | // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound |
| 3890 | if (totalDynamicDescriptors != dynamicOffsetCount) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3891 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t) commandBuffer, 0, DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", |
Tobin Ehlis | 61ebb31 | 2015-11-04 12:28:28 -0700 | [diff] [blame] | 3892 | "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount is %u. It should exactly match the number of dynamic descriptors.", setCount, totalDynamicDescriptors, dynamicOffsetCount); |
| 3893 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3894 | } |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 3895 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3896 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()"); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3897 | } |
| 3898 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3899 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3900 | dev_data->device_dispatch_table->CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3901 | } |
| 3902 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3903 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3904 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3905 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3906 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 3907 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3908 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3909 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 8d199e5 | 2015-09-17 12:24:13 -0600 | [diff] [blame] | 3910 | VkDeviceSize offset_align = 0; |
| 3911 | switch (indexType) { |
| 3912 | case VK_INDEX_TYPE_UINT16: |
| 3913 | offset_align = 2; |
| 3914 | break; |
| 3915 | case VK_INDEX_TYPE_UINT32: |
| 3916 | offset_align = 4; |
| 3917 | break; |
| 3918 | default: |
| 3919 | // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0 |
| 3920 | break; |
| 3921 | } |
| 3922 | if (!offset_align || (offset % offset_align)) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3923 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS", |
Tobin Ehlis | 8d199e5 | 2015-09-17 12:24:13 -0600 | [diff] [blame] | 3924 | "vkCmdBindIndexBuffer() offset (%#" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", offset, string_VkIndexType(indexType)); |
Tobin Ehlis | e407678 | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 3925 | } |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 3926 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3927 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindIndexBuffer()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 3928 | } |
Tobin Ehlis | 8d199e5 | 2015-09-17 12:24:13 -0600 | [diff] [blame] | 3929 | pCB->status |= CBSTATUS_INDEX_BUFFER_BOUND; |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 3930 | skipCall |= addCmd(dev_data, pCB, CMD_BINDINDEXBUFFER); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3931 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3932 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3933 | dev_data->device_dispatch_table->CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3934 | } |
| 3935 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3936 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindVertexBuffers( |
Mark Lobodzinski | 74e8469 | 2015-12-14 15:14:10 -0700 | [diff] [blame] | 3937 | VkCommandBuffer commandBuffer, |
Courtney Goeltzenleuchter | 4696294 | 2015-04-16 13:38:46 -0600 | [diff] [blame] | 3938 | uint32_t startBinding, |
| 3939 | uint32_t bindingCount, |
Mark Lobodzinski | 74e8469 | 2015-12-14 15:14:10 -0700 | [diff] [blame] | 3940 | const VkBuffer *pBuffers, |
| 3941 | const VkDeviceSize *pOffsets) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3942 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3943 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3944 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 3945 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3946 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3947 | if (pCB->state == CB_RECORDING) { |
Mark Lobodzinski | 74e8469 | 2015-12-14 15:14:10 -0700 | [diff] [blame] | 3948 | if ((startBinding + bindingCount) > pCB->boundVtxBuffers.size()) { |
| 3949 | pCB->boundVtxBuffers.resize(startBinding+bindingCount, VK_NULL_HANDLE); |
| 3950 | } |
| 3951 | for (auto i = 0; i < bindingCount; i++) { |
| 3952 | pCB->boundVtxBuffers[i+startBinding] = pBuffers[i]; |
| 3953 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 3954 | addCmd(dev_data, pCB, CMD_BINDVERTEXBUFFER); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 3955 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3956 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()"); |
Tobin Ehlis | 0b551cd | 2015-05-28 12:10:17 -0600 | [diff] [blame] | 3957 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3958 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3959 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3960 | dev_data->device_dispatch_table->CmdBindVertexBuffers(commandBuffer, startBinding, bindingCount, pBuffers, pOffsets); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3961 | } |
| 3962 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3963 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, uint32_t firstVertex, uint32_t firstInstance) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3964 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3965 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3966 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 3967 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3968 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3969 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 3970 | pCB->drawCount[DRAW]++; |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 3971 | skipCall |= validate_draw_state(dev_data, pCB, VK_FALSE); |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3972 | // TODO : Need to pass commandBuffer as srcObj here |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3973 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_NONE, "DS", |
Michael Lentine | cbc4a5e | 2015-11-03 16:19:46 -0800 | [diff] [blame] | 3974 | "vkCmdDraw() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW]++); |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3975 | skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3976 | if (VK_FALSE == skipCall) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 3977 | skipCall |= addCmd(dev_data, pCB, CMD_DRAW); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 3978 | } |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 3979 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3980 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDraw()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 3981 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 3982 | skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDraw"); |
Jon Ashburn | e0fa228 | 2015-05-20 09:00:28 -0600 | [diff] [blame] | 3983 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3984 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3985 | dev_data->device_dispatch_table->CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3986 | } |
| 3987 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 3988 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, uint32_t firstInstance) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3989 | { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3990 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 3991 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 3992 | VkBool32 skipCall = VK_FALSE; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 3993 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 3994 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 3995 | pCB->drawCount[DRAW_INDEXED]++; |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 3996 | skipCall |= validate_draw_state(dev_data, pCB, VK_TRUE); |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 3997 | // TODO : Need to pass commandBuffer as srcObj here |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 3998 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_NONE, "DS", |
Michael Lentine | cbc4a5e | 2015-11-03 16:19:46 -0800 | [diff] [blame] | 3999 | "vkCmdDrawIndexed() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++); |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4000 | skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4001 | if (VK_FALSE == skipCall) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4002 | skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXED); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4003 | } |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4004 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4005 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDrawIndexed()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4006 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4007 | skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed"); |
Jon Ashburn | e0fa228 | 2015-05-20 09:00:28 -0600 | [diff] [blame] | 4008 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4009 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4010 | dev_data->device_dispatch_table->CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, firstInstance); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4011 | } |
| 4012 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4013 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4014 | { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4015 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4016 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4017 | VkBool32 skipCall = VK_FALSE; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4018 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4019 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4020 | pCB->drawCount[DRAW_INDIRECT]++; |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 4021 | skipCall |= validate_draw_state(dev_data, pCB, VK_FALSE); |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4022 | // TODO : Need to pass commandBuffer as srcObj here |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4023 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_NONE, "DS", |
Michael Lentine | cbc4a5e | 2015-11-03 16:19:46 -0800 | [diff] [blame] | 4024 | "vkCmdDrawIndirect() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++); |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4025 | skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4026 | if (VK_FALSE == skipCall) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4027 | skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDIRECT); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4028 | } |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4029 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4030 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDrawIndirect()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4031 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4032 | skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndirect"); |
Jon Ashburn | e0fa228 | 2015-05-20 09:00:28 -0600 | [diff] [blame] | 4033 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4034 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4035 | dev_data->device_dispatch_table->CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4036 | } |
| 4037 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4038 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4039 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4040 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4041 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4042 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4043 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4044 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4045 | pCB->drawCount[DRAW_INDEXED_INDIRECT]++; |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 4046 | skipCall |= validate_draw_state(dev_data, pCB, VK_TRUE); |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4047 | // TODO : Need to pass commandBuffer as srcObj here |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4048 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_NONE, "DS", |
Michael Lentine | cbc4a5e | 2015-11-03 16:19:46 -0800 | [diff] [blame] | 4049 | "vkCmdDrawIndexedIndirect() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDEXED_INDIRECT]++); |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4050 | skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4051 | if (VK_FALSE == skipCall) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4052 | skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXEDINDIRECT); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4053 | } |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4054 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4055 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDrawIndexedIndirect()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4056 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4057 | skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexedIndirect"); |
Jon Ashburn | e0fa228 | 2015-05-20 09:00:28 -0600 | [diff] [blame] | 4058 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4059 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4060 | dev_data->device_dispatch_table->CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4061 | } |
| 4062 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4063 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4064 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4065 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4066 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4067 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4068 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4069 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4070 | skipCall |= addCmd(dev_data, pCB, CMD_DISPATCH); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4071 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4072 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDispatch()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4073 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4074 | skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatch"); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4075 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4076 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4077 | dev_data->device_dispatch_table->CmdDispatch(commandBuffer, x, y, z); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4078 | } |
| 4079 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4080 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4081 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4082 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4083 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4084 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4085 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4086 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4087 | skipCall |= addCmd(dev_data, pCB, CMD_DISPATCHINDIRECT); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4088 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4089 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDispatchIndirect()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4090 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4091 | skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatchIndirect"); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4092 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4093 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4094 | dev_data->device_dispatch_table->CmdDispatchIndirect(commandBuffer, buffer, offset); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4095 | } |
| 4096 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4097 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, uint32_t regionCount, const VkBufferCopy* pRegions) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4098 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4099 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4100 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4101 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4102 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4103 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4104 | skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFER); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4105 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4106 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyBuffer()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4107 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4108 | skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBuffer"); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4109 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4110 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4111 | dev_data->device_dispatch_table->CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4112 | } |
| 4113 | |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4114 | bool VerifySourceImageLayout(VkCommandBuffer cmdBuffer, VkImage srcImage, VkImageLayout srcImageLayout) { |
| 4115 | bool skip_call = false; |
Mark Lobodzinski | 78940a4 | 2015-11-30 16:48:53 -0700 | [diff] [blame] | 4116 | |
| 4117 | #ifdef DISABLE_IMAGE_LAYOUT_VALIDATION |
| 4118 | // TODO: Fix -- initialLayout may have been set in a previous command buffer |
| 4119 | return skip_call; |
| 4120 | #endif // DISABLE_IMAGE_LAYOUT_VALIDATION |
| 4121 | |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4122 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); |
| 4123 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer); |
| 4124 | auto src_image_element = pCB->imageLayoutMap.find(srcImage); |
| 4125 | if (src_image_element == pCB->imageLayoutMap.end()) { |
| 4126 | pCB->imageLayoutMap[srcImage].initialLayout = srcImageLayout; |
| 4127 | pCB->imageLayoutMap[srcImage].layout = srcImageLayout; |
| 4128 | return false; |
| 4129 | } |
| 4130 | if (src_image_element->second.layout != srcImageLayout) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4131 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4132 | "Cannot copy from an image whose source layout is %d and doesn't match the current layout %d.", srcImageLayout, src_image_element->second.layout); |
| 4133 | } |
| 4134 | if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) { |
| 4135 | if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4136 | // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. |
| 4137 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERF_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Michael Lentine | 472af7d | 2015-10-16 18:08:09 -0500 | [diff] [blame] | 4138 | "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL."); |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4139 | } else { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4140 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Michael Lentine | 472af7d | 2015-10-16 18:08:09 -0500 | [diff] [blame] | 4141 | "Layout for input image is %d but can only be TRANSFER_SRC_OPTIMAL or GENERAL.", srcImageLayout); |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4142 | } |
| 4143 | } |
| 4144 | return skip_call; |
| 4145 | } |
| 4146 | |
| 4147 | bool VerifyDestImageLayout(VkCommandBuffer cmdBuffer, VkImage destImage, VkImageLayout destImageLayout) { |
| 4148 | bool skip_call = false; |
Mark Lobodzinski | 78940a4 | 2015-11-30 16:48:53 -0700 | [diff] [blame] | 4149 | |
| 4150 | #ifdef DISABLE_IMAGE_LAYOUT_VALIDATION |
| 4151 | // TODO: Fix -- initialLayout may have been set in a previous command buffer |
| 4152 | return skip_call; |
| 4153 | #endif // DISABLE_IMAGE_LAYOUT_VALIDATION |
| 4154 | |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4155 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); |
| 4156 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer); |
| 4157 | auto dest_image_element = pCB->imageLayoutMap.find(destImage); |
| 4158 | if (dest_image_element == pCB->imageLayoutMap.end()) { |
| 4159 | pCB->imageLayoutMap[destImage].initialLayout = destImageLayout; |
| 4160 | pCB->imageLayoutMap[destImage].layout = destImageLayout; |
| 4161 | return false; |
| 4162 | } |
| 4163 | if (dest_image_element->second.layout != destImageLayout) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4164 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4165 | "Cannot copy from an image whose dest layout is %d and doesn't match the current layout %d.", destImageLayout, dest_image_element->second.layout); |
| 4166 | } |
| 4167 | if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { |
| 4168 | if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4169 | // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. |
| 4170 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERF_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4171 | "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL."); |
| 4172 | } else { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4173 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4174 | "Layout for output image is %d but can only be TRANSFER_DST_OPTIMAL or GENERAL.", destImageLayout); |
| 4175 | } |
| 4176 | } |
| 4177 | return skip_call; |
| 4178 | } |
| 4179 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4180 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyImage(VkCommandBuffer commandBuffer, |
Courtney Goeltzenleuchter | 382489d | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 4181 | VkImage srcImage, |
| 4182 | VkImageLayout srcImageLayout, |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4183 | VkImage dstImage, |
| 4184 | VkImageLayout dstImageLayout, |
Courtney Goeltzenleuchter | 382489d | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 4185 | uint32_t regionCount, const VkImageCopy* pRegions) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4186 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4187 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4188 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4189 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4190 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4191 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4192 | skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGE); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4193 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4194 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyImage()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4195 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4196 | skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImage"); |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4197 | skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, srcImageLayout); |
| 4198 | skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, dstImageLayout); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4199 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4200 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4201 | dev_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, pRegions); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4202 | } |
| 4203 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4204 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBlitImage(VkCommandBuffer commandBuffer, |
Courtney Goeltzenleuchter | 382489d | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 4205 | VkImage srcImage, VkImageLayout srcImageLayout, |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4206 | VkImage dstImage, VkImageLayout dstImageLayout, |
Mark Lobodzinski | 20f6859 | 2015-05-22 14:43:25 -0500 | [diff] [blame] | 4207 | uint32_t regionCount, const VkImageBlit* pRegions, |
Chia-I Wu | 3603b08 | 2015-10-26 16:49:32 +0800 | [diff] [blame] | 4208 | VkFilter filter) |
Courtney Goeltzenleuchter | 6ff8ebc | 2015-04-03 14:42:51 -0600 | [diff] [blame] | 4209 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4210 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4211 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4212 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Courtney Goeltzenleuchter | 6ff8ebc | 2015-04-03 14:42:51 -0600 | [diff] [blame] | 4213 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4214 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4215 | skipCall |= addCmd(dev_data, pCB, CMD_BLITIMAGE); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4216 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4217 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBlitImage()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4218 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4219 | skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBlitImage"); |
Courtney Goeltzenleuchter | 6ff8ebc | 2015-04-03 14:42:51 -0600 | [diff] [blame] | 4220 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4221 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4222 | dev_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, pRegions, filter); |
Courtney Goeltzenleuchter | 6ff8ebc | 2015-04-03 14:42:51 -0600 | [diff] [blame] | 4223 | } |
| 4224 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4225 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer, |
Courtney Goeltzenleuchter | 382489d | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 4226 | VkBuffer srcBuffer, |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4227 | VkImage dstImage, VkImageLayout dstImageLayout, |
Courtney Goeltzenleuchter | 382489d | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 4228 | uint32_t regionCount, const VkBufferImageCopy* pRegions) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4229 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4230 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4231 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4232 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4233 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4234 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4235 | skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFERTOIMAGE); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4236 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4237 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyBufferToImage()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4238 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4239 | skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBufferToImage"); |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4240 | skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, dstImageLayout); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4241 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4242 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4243 | dev_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, pRegions); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4244 | } |
| 4245 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4246 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, |
Courtney Goeltzenleuchter | 382489d | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 4247 | VkImage srcImage, VkImageLayout srcImageLayout, |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4248 | VkBuffer dstBuffer, |
Courtney Goeltzenleuchter | 382489d | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 4249 | uint32_t regionCount, const VkBufferImageCopy* pRegions) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4250 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4251 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4252 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4253 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4254 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4255 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4256 | skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGETOBUFFER); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4257 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4258 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyImageToBuffer()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4259 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4260 | skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImageToBuffer"); |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4261 | skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, srcImageLayout); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4262 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4263 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4264 | dev_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, pRegions); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4265 | } |
| 4266 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4267 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t* pData) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4268 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4269 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4270 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4271 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4272 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4273 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4274 | skipCall |= addCmd(dev_data, pCB, CMD_UPDATEBUFFER); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4275 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4276 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdUpdateBuffer()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4277 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4278 | skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyUpdateBuffer"); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4279 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4280 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4281 | dev_data->device_dispatch_table->CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4282 | } |
| 4283 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4284 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4285 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4286 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4287 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4288 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4289 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4290 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4291 | skipCall |= addCmd(dev_data, pCB, CMD_FILLBUFFER); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4292 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4293 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdFillBuffer()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4294 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4295 | skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyFillBuffer"); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4296 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4297 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4298 | dev_data->device_dispatch_table->CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4299 | } |
| 4300 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4301 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearAttachments( |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4302 | VkCommandBuffer commandBuffer, |
Courtney Goeltzenleuchter | 9feb073 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 4303 | uint32_t attachmentCount, |
| 4304 | const VkClearAttachment* pAttachments, |
Tobin Ehlis | 8cd650e | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 4305 | uint32_t rectCount, |
Courtney Goeltzenleuchter | a12e291 | 2015-10-15 18:22:08 -0600 | [diff] [blame] | 4306 | const VkClearRect* pRects) |
Tobin Ehlis | 8cd650e | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 4307 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4308 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4309 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4310 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 8cd650e | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 4311 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4312 | if (pCB->state == CB_RECORDING) { |
Mark Lobodzinski | 92c712c | 2015-12-08 13:47:14 -0700 | [diff] [blame] | 4313 | // Warn if this is issued prior to Draw Cmd and clearing the entire attachment |
| 4314 | if (!hasDrawCmd(pCB) && |
| 4315 | (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && |
| 4316 | (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4317 | // TODO : commandBuffer should be srcObj |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4318 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", |
Courtney Goeltzenleuchter | 9feb073 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 4319 | "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds." |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4320 | " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", reinterpret_cast<uint64_t>(commandBuffer)); |
Tobin Ehlis | 8cd650e | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 4321 | } |
Courtney Goeltzenleuchter | 9feb073 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 4322 | skipCall |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS); |
Tobin Ehlis | 8cd650e | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 4323 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4324 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdClearAttachments()"); |
Tobin Ehlis | 8cd650e | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 4325 | } |
Courtney Goeltzenleuchter | 9feb073 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 4326 | skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments"); |
| 4327 | } |
| 4328 | |
| 4329 | // Validate that attachment is in reference list of active subpass |
| 4330 | if (pCB->activeRenderPass) { |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 4331 | const VkRenderPassCreateInfo *pRPCI = dev_data->renderPassMap[pCB->activeRenderPass]->pCreateInfo; |
Courtney Goeltzenleuchter | 9feb073 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 4332 | const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; |
| 4333 | |
| 4334 | for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) { |
| 4335 | const VkClearAttachment *attachment = &pAttachments[attachment_idx]; |
| 4336 | if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { |
| 4337 | VkBool32 found = VK_FALSE; |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 4338 | for (uint32_t i = 0; i < pSD->colorAttachmentCount; i++) { |
Courtney Goeltzenleuchter | 9feb073 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 4339 | if (attachment->colorAttachment == pSD->pColorAttachments[i].attachment) { |
| 4340 | found = VK_TRUE; |
| 4341 | break; |
| 4342 | } |
| 4343 | } |
| 4344 | if (VK_FALSE == found) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4345 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4346 | (uint64_t)commandBuffer, 0, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", |
Courtney Goeltzenleuchter | 9feb073 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 4347 | "vkCmdClearAttachments() attachment index %d not found in attachment reference array of active subpass %d", |
| 4348 | attachment->colorAttachment, pCB->activeSubpass); |
| 4349 | } |
| 4350 | } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { |
Mark Lobodzinski | 1523e3a | 2015-11-17 15:11:24 -0700 | [diff] [blame] | 4351 | if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass |
Mark Lobodzinski | ea1fff2 | 2015-11-18 08:58:31 -0700 | [diff] [blame] | 4352 | (pSD->pDepthStencilAttachment->attachment == VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass |
Mark Lobodzinski | 1523e3a | 2015-11-17 15:11:24 -0700 | [diff] [blame] | 4353 | |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4354 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mark Lobodzinski | 1523e3a | 2015-11-17 15:11:24 -0700 | [diff] [blame] | 4355 | (uint64_t)commandBuffer, 0, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", |
| 4356 | "vkCmdClearAttachments() attachment index %d does not match depthStencilAttachment.attachment (%d) found in active subpass %d", |
| 4357 | attachment->colorAttachment, |
| 4358 | (pSD->pDepthStencilAttachment) ? pSD->pDepthStencilAttachment->attachment : VK_ATTACHMENT_UNUSED, |
| 4359 | pCB->activeSubpass); |
Courtney Goeltzenleuchter | 9feb073 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 4360 | } |
| 4361 | } |
| 4362 | } |
Tobin Ehlis | 8cd650e | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 4363 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4364 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4365 | dev_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); |
Tobin Ehlis | 8cd650e | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 4366 | } |
| 4367 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4368 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearColorImage( |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4369 | VkCommandBuffer commandBuffer, |
Courtney Goeltzenleuchter | da4a99e | 2015-04-23 17:49:22 -0600 | [diff] [blame] | 4370 | VkImage image, VkImageLayout imageLayout, |
Chris Forbes | e310597 | 2015-06-24 14:34:53 +1200 | [diff] [blame] | 4371 | const VkClearColorValue *pColor, |
Courtney Goeltzenleuchter | da4a99e | 2015-04-23 17:49:22 -0600 | [diff] [blame] | 4372 | uint32_t rangeCount, const VkImageSubresourceRange* pRanges) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4373 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4374 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4375 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4376 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4377 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4378 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4379 | skipCall |= addCmd(dev_data, pCB, CMD_CLEARCOLORIMAGE); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4380 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4381 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdClearColorImage()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4382 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4383 | skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearColorImage"); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4384 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4385 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4386 | dev_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4387 | } |
| 4388 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4389 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearDepthStencilImage( |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4390 | VkCommandBuffer commandBuffer, |
Courtney Goeltzenleuchter | 315ad99 | 2015-09-15 18:03:22 -0600 | [diff] [blame] | 4391 | VkImage image, VkImageLayout imageLayout, |
| 4392 | const VkClearDepthStencilValue *pDepthStencil, |
| 4393 | uint32_t rangeCount, |
| 4394 | const VkImageSubresourceRange* pRanges) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4395 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4396 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4397 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4398 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4399 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4400 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4401 | skipCall |= addCmd(dev_data, pCB, CMD_CLEARDEPTHSTENCILIMAGE); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4402 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4403 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdClearDepthStencilImage()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4404 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4405 | skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearDepthStencilImage"); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4406 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4407 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4408 | dev_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, pRanges); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4409 | } |
| 4410 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4411 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdResolveImage(VkCommandBuffer commandBuffer, |
Courtney Goeltzenleuchter | 382489d | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 4412 | VkImage srcImage, VkImageLayout srcImageLayout, |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4413 | VkImage dstImage, VkImageLayout dstImageLayout, |
Tony Barbour | 11f7437 | 2015-04-13 15:02:52 -0600 | [diff] [blame] | 4414 | uint32_t regionCount, const VkImageResolve* pRegions) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4415 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4416 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4417 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4418 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4419 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4420 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4421 | skipCall |= addCmd(dev_data, pCB, CMD_RESOLVEIMAGE); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4422 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4423 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResolveImage()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4424 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4425 | skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResolveImage"); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4426 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4427 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4428 | dev_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, pRegions); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4429 | } |
| 4430 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4431 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4432 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4433 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4434 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4435 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4436 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4437 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4438 | skipCall |= addCmd(dev_data, pCB, CMD_SETEVENT); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4439 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4440 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetEvent()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4441 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4442 | skipCall |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent"); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4443 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4444 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4445 | dev_data->device_dispatch_table->CmdSetEvent(commandBuffer, event, stageMask); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4446 | } |
| 4447 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4448 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4449 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4450 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4451 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4452 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4453 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4454 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4455 | skipCall |= addCmd(dev_data, pCB, CMD_RESETEVENT); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4456 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4457 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetEvent()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4458 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4459 | skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent"); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4460 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4461 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4462 | dev_data->device_dispatch_table->CmdResetEvent(commandBuffer, event, stageMask); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4463 | } |
| 4464 | |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4465 | bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, const void* const* ppMemBarriers) { |
| 4466 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); |
| 4467 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer); |
| 4468 | bool skip = false; |
Mark Lobodzinski | 78940a4 | 2015-11-30 16:48:53 -0700 | [diff] [blame] | 4469 | |
| 4470 | #ifdef DISABLE_IMAGE_LAYOUT_VALIDATION |
| 4471 | // TODO: Fix -- pay attention to image subresource ranges -- not all subresources transition at the same time |
| 4472 | return skip; |
| 4473 | #endif // DISABLE_IMAGE_LAYOUT_VALIDATION |
| 4474 | |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4475 | for (uint32_t i = 0; i < memBarrierCount; ++i) { |
| 4476 | auto mem_barrier = reinterpret_cast<const VkMemoryBarrier*>(ppMemBarriers[i]); |
| 4477 | if (mem_barrier && mem_barrier->sType == VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER) { |
| 4478 | auto image_mem_barrier = reinterpret_cast<const VkImageMemoryBarrier*>(mem_barrier); |
| 4479 | auto image_data = pCB->imageLayoutMap.find(image_mem_barrier->image); |
| 4480 | if (image_data == pCB->imageLayoutMap.end()) { |
| 4481 | pCB->imageLayoutMap[image_mem_barrier->image].initialLayout = image_mem_barrier->oldLayout; |
| 4482 | pCB->imageLayoutMap[image_mem_barrier->image].layout = image_mem_barrier->newLayout; |
| 4483 | } else { |
| 4484 | if (image_data->second.layout != image_mem_barrier->oldLayout) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4485 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Courtney Goeltzenleuchter | 95e6dba | 2015-11-25 11:38:54 -0700 | [diff] [blame] | 4486 | "You cannot transition the layout from %d when current layout is %d.", image_mem_barrier->oldLayout, image_data->second.layout); |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4487 | } |
| 4488 | image_data->second.layout = image_mem_barrier->newLayout; |
| 4489 | } |
| 4490 | } |
| 4491 | } |
| 4492 | return skip; |
| 4493 | } |
| 4494 | |
Michael Lentine | 8469dd6 | 2015-11-20 09:48:52 -0800 | [diff] [blame] | 4495 | // AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. |
| 4496 | // If required_bit is zero, accessMask must have at least one of 'optional_bits' set |
| 4497 | bool ValidateMaskBits(const layer_data* my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags& accessMask, const VkImageLayout& layout, VkAccessFlags required_bit, VkAccessFlags optional_bits) { |
Michael Lentine | 472af7d | 2015-10-16 18:08:09 -0500 | [diff] [blame] | 4498 | bool skip_call = false; |
Michael Lentine | 8469dd6 | 2015-11-20 09:48:52 -0800 | [diff] [blame] | 4499 | if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) { |
| 4500 | if (accessMask & !(required_bit | optional_bits)) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4501 | // TODO: Verify against Valid Use |
| 4502 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS", |
Michael Lentine | 8469dd6 | 2015-11-20 09:48:52 -0800 | [diff] [blame] | 4503 | "Additional bits in accessMask %d are specified when layout is %s.", accessMask, string_VkImageLayout(layout)); |
Michael Lentine | 472af7d | 2015-10-16 18:08:09 -0500 | [diff] [blame] | 4504 | } |
| 4505 | } else { |
Michael Lentine | 8469dd6 | 2015-11-20 09:48:52 -0800 | [diff] [blame] | 4506 | if (!required_bit) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4507 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS", |
Michael Lentine | 8469dd6 | 2015-11-20 09:48:52 -0800 | [diff] [blame] | 4508 | "AccessMask %d must contain at least one of access bits %d when layout is %s.", |
| 4509 | accessMask, optional_bits, string_VkImageLayout(layout)); |
| 4510 | } else { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4511 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS", |
Michael Lentine | 8469dd6 | 2015-11-20 09:48:52 -0800 | [diff] [blame] | 4512 | "AccessMask %d must have required access bit %d and may have optional bits %d when layout is %s.", |
| 4513 | accessMask, required_bit, optional_bits,string_VkImageLayout(layout)); |
| 4514 | } |
Michael Lentine | 472af7d | 2015-10-16 18:08:09 -0500 | [diff] [blame] | 4515 | } |
| 4516 | return skip_call; |
| 4517 | } |
| 4518 | |
Michael Lentine | 8469dd6 | 2015-11-20 09:48:52 -0800 | [diff] [blame] | 4519 | bool ValidateMaskBitsFromLayouts(const layer_data* my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags& accessMask, const VkImageLayout& layout) { |
Michael Lentine | 472af7d | 2015-10-16 18:08:09 -0500 | [diff] [blame] | 4520 | bool skip_call = false; |
Michael Lentine | 8469dd6 | 2015-11-20 09:48:52 -0800 | [diff] [blame] | 4521 | switch (layout) { |
| 4522 | case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: { |
| 4523 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, VK_ACCESS_COLOR_ATTACHMENT_READ_BIT); |
| 4524 | break; |
Michael Lentine | 472af7d | 2015-10-16 18:08:09 -0500 | [diff] [blame] | 4525 | } |
Michael Lentine | 8469dd6 | 2015-11-20 09:48:52 -0800 | [diff] [blame] | 4526 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: { |
| 4527 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT); |
| 4528 | break; |
Michael Lentine | 472af7d | 2015-10-16 18:08:09 -0500 | [diff] [blame] | 4529 | } |
Michael Lentine | 8469dd6 | 2015-11-20 09:48:52 -0800 | [diff] [blame] | 4530 | case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: { |
| 4531 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0); |
| 4532 | break; |
| 4533 | } |
| 4534 | case VK_IMAGE_LAYOUT_PREINITIALIZED: { |
| 4535 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0); |
| 4536 | break; |
| 4537 | } |
| 4538 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: { |
| 4539 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT); |
| 4540 | break; |
| 4541 | } |
| 4542 | case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: { |
| 4543 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT); |
| 4544 | break; |
| 4545 | } |
| 4546 | case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: { |
| 4547 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0); |
| 4548 | break; |
| 4549 | } |
| 4550 | case VK_IMAGE_LAYOUT_UNDEFINED: { |
| 4551 | if (accessMask != 0) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4552 | // TODO: Verify against Valid Use section spec |
| 4553 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS", |
Michael Lentine | 8469dd6 | 2015-11-20 09:48:52 -0800 | [diff] [blame] | 4554 | "Additional bits in accessMask %d are specified when layout is %s.", accessMask, string_VkImageLayout(layout)); |
| 4555 | } |
| 4556 | break; |
| 4557 | } |
| 4558 | case VK_IMAGE_LAYOUT_GENERAL: |
| 4559 | default: { |
| 4560 | break; |
| 4561 | } |
Michael Lentine | 472af7d | 2015-10-16 18:08:09 -0500 | [diff] [blame] | 4562 | } |
| 4563 | return skip_call; |
| 4564 | } |
| 4565 | |
Michael Lentine | 07ff1a1 | 2015-10-15 17:07:00 -0500 | [diff] [blame] | 4566 | bool ValidateBarriers(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, const void* const* ppMemBarriers) { |
| 4567 | bool skip_call = false; |
| 4568 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); |
| 4569 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer); |
| 4570 | if (pCB->activeRenderPass && memBarrierCount) { |
| 4571 | for (uint32_t i = 0; i < memBarrierCount; ++i) { |
| 4572 | auto mem_barrier = reinterpret_cast<const VkMemoryBarrier*>(ppMemBarriers[i]); |
| 4573 | if (mem_barrier && mem_barrier->sType != VK_STRUCTURE_TYPE_MEMORY_BARRIER) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4574 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS", |
Michael Lentine | 07ff1a1 | 2015-10-15 17:07:00 -0500 | [diff] [blame] | 4575 | "Image or Buffers Barriers cannot be used during a render pass."); |
| 4576 | } |
| 4577 | } |
| 4578 | if (!dev_data->renderPassMap[pCB->activeRenderPass]->hasSelfDependency[pCB->activeSubpass]) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4579 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS", |
Michael Lentine | 07ff1a1 | 2015-10-15 17:07:00 -0500 | [diff] [blame] | 4580 | "Barriers cannot be set during subpass %d with no self dependency specified.", pCB->activeSubpass); |
| 4581 | } |
| 4582 | } |
Mark Lobodzinski | b684b51 | 2015-11-20 09:27:27 -0700 | [diff] [blame] | 4583 | |
Michael Lentine | 472af7d | 2015-10-16 18:08:09 -0500 | [diff] [blame] | 4584 | for (uint32_t i = 0; i < memBarrierCount; ++i) { |
| 4585 | auto mem_barrier = reinterpret_cast<const VkMemoryBarrier*>(ppMemBarriers[i]); |
| 4586 | if (mem_barrier && mem_barrier->sType == VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER) { |
| 4587 | auto image_mem_barrier = reinterpret_cast<const VkImageMemoryBarrier*>(mem_barrier); |
Michael Lentine | 8469dd6 | 2015-11-20 09:48:52 -0800 | [diff] [blame] | 4588 | skip_call |= ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, image_mem_barrier->srcAccessMask, image_mem_barrier->oldLayout); |
| 4589 | skip_call |= ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, image_mem_barrier->dstAccessMask, image_mem_barrier->newLayout); |
Michael Lentine | 472af7d | 2015-10-16 18:08:09 -0500 | [diff] [blame] | 4590 | } |
| 4591 | } |
Mark Lobodzinski | b95fc09 | 2015-12-03 15:42:32 -0700 | [diff] [blame] | 4592 | |
Michael Lentine | 07ff1a1 | 2015-10-15 17:07:00 -0500 | [diff] [blame] | 4593 | return skip_call; |
| 4594 | } |
| 4595 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4596 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent* pEvents, VkPipelineStageFlags sourceStageMask, VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const void* const* ppMemoryBarriers) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4597 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4598 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4599 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4600 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4601 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4602 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4603 | skipCall |= addCmd(dev_data, pCB, CMD_WAITEVENTS); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4604 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4605 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4606 | } |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4607 | skipCall |= TransitionImageLayouts(commandBuffer, memoryBarrierCount, ppMemoryBarriers); |
Michael Lentine | 07ff1a1 | 2015-10-15 17:07:00 -0500 | [diff] [blame] | 4608 | skipCall |= ValidateBarriers(commandBuffer, memoryBarrierCount, ppMemoryBarriers); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4609 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4610 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4611 | dev_data->device_dispatch_table->CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, memoryBarrierCount, ppMemoryBarriers); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4612 | } |
| 4613 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4614 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const void* const* ppMemoryBarriers) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4615 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4616 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4617 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4618 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4619 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4620 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4621 | skipCall |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4622 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4623 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPipelineBarrier()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4624 | } |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4625 | skipCall |= TransitionImageLayouts(commandBuffer, memoryBarrierCount, ppMemoryBarriers); |
Michael Lentine | 07ff1a1 | 2015-10-15 17:07:00 -0500 | [diff] [blame] | 4626 | skipCall |= ValidateBarriers(commandBuffer, memoryBarrierCount, ppMemoryBarriers); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4627 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4628 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4629 | dev_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, memoryBarrierCount, ppMemoryBarriers); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4630 | } |
| 4631 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4632 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4633 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4634 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4635 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4636 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4637 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4638 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4639 | skipCall |= addCmd(dev_data, pCB, CMD_BEGINQUERY); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4640 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4641 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBeginQuery()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4642 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4643 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4644 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4645 | dev_data->device_dispatch_table->CmdBeginQuery(commandBuffer, queryPool, slot, flags); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4646 | } |
| 4647 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4648 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4649 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4650 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4651 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4652 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4653 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4654 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4655 | skipCall |= addCmd(dev_data, pCB, CMD_ENDQUERY); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4656 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4657 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4658 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4659 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4660 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4661 | dev_data->device_dispatch_table->CmdEndQuery(commandBuffer, queryPool, slot); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4662 | } |
| 4663 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4664 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t startQuery, uint32_t queryCount) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4665 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4666 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4667 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4668 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4669 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4670 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4671 | skipCall |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4672 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4673 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4674 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4675 | skipCall |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool"); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4676 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4677 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4678 | dev_data->device_dispatch_table->CmdResetQueryPool(commandBuffer, queryPool, startQuery, queryCount); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4679 | } |
| 4680 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4681 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t startQuery, |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4682 | uint32_t queryCount, VkBuffer dstBuffer, VkDeviceSize dstOffset, |
Chia-I Wu | 1f6942d | 2015-10-26 18:36:20 +0800 | [diff] [blame] | 4683 | VkDeviceSize stride, VkQueryResultFlags flags) |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 4684 | { |
| 4685 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4686 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4687 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 4688 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4689 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4690 | skipCall |= addCmd(dev_data, pCB, CMD_COPYQUERYPOOLRESULTS); |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 4691 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4692 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()"); |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 4693 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4694 | skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyQueryPoolResults"); |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 4695 | } |
| 4696 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4697 | dev_data->device_dispatch_table->CmdCopyQueryPoolResults(commandBuffer, queryPool, |
| 4698 | startQuery, queryCount, dstBuffer, dstOffset, stride, flags); |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 4699 | } |
| 4700 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4701 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4702 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4703 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4704 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 4705 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4706 | if (pCB) { |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 4707 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4708 | skipCall |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP); |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 4709 | } else { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4710 | skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()"); |
Tobin Ehlis | e42007c | 2015-06-19 13:00:59 -0600 | [diff] [blame] | 4711 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4712 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 4713 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4714 | dev_data->device_dispatch_table->CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 4715 | } |
| 4716 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4717 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkFramebuffer* pFramebuffer) |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 4718 | { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 4719 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 4720 | VkResult result = dev_data->device_dispatch_table->CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 4721 | if (VK_SUCCESS == result) { |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 4722 | // Shadow create info and store in map |
Courtney Goeltzenleuchter | 382489d | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 4723 | VkFramebufferCreateInfo* localFBCI = new VkFramebufferCreateInfo(*pCreateInfo); |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 4724 | if (pCreateInfo->pAttachments) { |
Courtney Goeltzenleuchter | 1856d6f | 2015-09-01 17:30:39 -0600 | [diff] [blame] | 4725 | localFBCI->pAttachments = new VkImageView[localFBCI->attachmentCount]; |
| 4726 | memcpy((void*)localFBCI->pAttachments, pCreateInfo->pAttachments, localFBCI->attachmentCount*sizeof(VkImageView)); |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 4727 | } |
Chia-I Wu | e420a33 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 4728 | dev_data->frameBufferMap[*pFramebuffer] = localFBCI; |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 4729 | } |
| 4730 | return result; |
| 4731 | } |
| 4732 | |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4733 | // Store the DAG. |
| 4734 | struct DAGNode { |
| 4735 | uint32_t pass; |
| 4736 | std::vector<uint32_t> prev; |
| 4737 | std::vector<uint32_t> next; |
| 4738 | }; |
| 4739 | |
Courtney Goeltzenleuchter | f2bca90 | 2015-11-03 15:41:43 -0700 | [diff] [blame] | 4740 | VkBool32 FindDependency(const int index, const int dependent, const std::vector<DAGNode>& subpass_to_node, std::unordered_set<uint32_t>& processed_nodes) { |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4741 | // If we have already checked this node we have not found a dependency path so return false. |
| 4742 | if (processed_nodes.count(index)) |
| 4743 | return false; |
| 4744 | processed_nodes.insert(index); |
| 4745 | const DAGNode& node = subpass_to_node[index]; |
| 4746 | // Look for a dependency path. If one exists return true else recurse on the previous nodes. |
| 4747 | if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) { |
| 4748 | for (auto elem : node.prev) { |
| 4749 | if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) |
| 4750 | return true; |
| 4751 | } |
| 4752 | } else { |
| 4753 | return true; |
| 4754 | } |
| 4755 | return false; |
| 4756 | } |
| 4757 | |
Courtney Goeltzenleuchter | f2bca90 | 2015-11-03 15:41:43 -0700 | [diff] [blame] | 4758 | VkBool32 CheckDependencyExists(const layer_data* my_data, VkDevice device, const int subpass, const std::vector<uint32_t>& dependent_subpasses, const std::vector<DAGNode>& subpass_to_node, VkBool32& skip_call) { |
| 4759 | VkBool32 result = true; |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4760 | // Loop through all subpasses that share the same attachment and make sure a dependency exists |
| 4761 | for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { |
| 4762 | if (subpass == dependent_subpasses[k]) |
| 4763 | continue; |
| 4764 | const DAGNode& node = subpass_to_node[subpass]; |
| 4765 | // Check for a specified dependency between the two nodes. If one exists we are done. |
| 4766 | auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); |
| 4767 | auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); |
| 4768 | if (prev_elem == node.prev.end() && next_elem == node.next.end()) { |
| 4769 | // If no dependency exits an implicit dependency still might. If so, warn and if not throw an error. |
| 4770 | std::unordered_set<uint32_t> processed_nodes; |
| 4771 | if (FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || |
| 4772 | FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes)) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4773 | // TODO: Verify against Valid Use section of spec |
| 4774 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS", |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4775 | "A dependency between subpasses %d and %d must exist but only an implicit one is specified.", |
| 4776 | subpass, dependent_subpasses[k]); |
| 4777 | } else { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4778 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS", |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4779 | "A dependency between subpasses %d and %d must exist but one is not specified.", |
| 4780 | subpass, dependent_subpasses[k]); |
| 4781 | result = false; |
| 4782 | } |
| 4783 | } |
| 4784 | } |
| 4785 | return result; |
| 4786 | } |
| 4787 | |
Courtney Goeltzenleuchter | f2bca90 | 2015-11-03 15:41:43 -0700 | [diff] [blame] | 4788 | VkBool32 CheckPreserved(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, const int index, const int attachment, const std::vector<DAGNode>& subpass_to_node, int depth, VkBool32& skip_call) { |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4789 | const DAGNode& node = subpass_to_node[index]; |
| 4790 | // If this node writes to the attachment return true as next nodes need to preserve the attachment. |
| 4791 | const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[index]; |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 4792 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4793 | if (attachment == subpass.pColorAttachments[j].attachment) |
Courtney Goeltzenleuchter | f2bca90 | 2015-11-03 15:41:43 -0700 | [diff] [blame] | 4794 | return VK_TRUE; |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4795 | } |
Chia-I Wu | ce532f7 | 2015-10-26 17:32:47 +0800 | [diff] [blame] | 4796 | if (subpass.pDepthStencilAttachment && |
| 4797 | subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| 4798 | if (attachment == subpass.pDepthStencilAttachment->attachment) |
Courtney Goeltzenleuchter | f2bca90 | 2015-11-03 15:41:43 -0700 | [diff] [blame] | 4799 | return VK_TRUE; |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4800 | } |
Courtney Goeltzenleuchter | f2bca90 | 2015-11-03 15:41:43 -0700 | [diff] [blame] | 4801 | VkBool32 result = VK_FALSE; |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4802 | // Loop through previous nodes and see if any of them write to the attachment. |
| 4803 | for (auto elem : node.prev) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4804 | result |= CheckPreserved(my_data, device, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call); |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4805 | } |
| 4806 | // If the attachment was written to by a previous node than this node needs to preserve it. |
| 4807 | if (result && depth > 0) { |
| 4808 | const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[index]; |
Courtney Goeltzenleuchter | f2bca90 | 2015-11-03 15:41:43 -0700 | [diff] [blame] | 4809 | VkBool32 has_preserved = false; |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 4810 | for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4811 | if (subpass.pPreserveAttachments[j].attachment == attachment) { |
| 4812 | has_preserved = true; |
| 4813 | break; |
| 4814 | } |
| 4815 | } |
| 4816 | if (!has_preserved) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4817 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS", |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4818 | "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); |
| 4819 | } |
| 4820 | } |
| 4821 | return result; |
| 4822 | } |
| 4823 | |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4824 | VkBool32 ValidateDependencies(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, std::vector<DAGNode>& subpass_to_node) { |
| 4825 | VkBool32 skip_call = false; |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4826 | std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); |
| 4827 | std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4828 | |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4829 | // Create DAG |
| 4830 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 4831 | DAGNode& subpass_node = subpass_to_node[i]; |
| 4832 | subpass_node.pass = i; |
| 4833 | } |
| 4834 | for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { |
| 4835 | const VkSubpassDependency& dependency = pCreateInfo->pDependencies[i]; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4836 | if (dependency.srcSubpass > dependency.dstSubpass) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4837 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS", |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4838 | "Dependency graph must be specified such that an earlier pass cannot depend on a later pass."); |
| 4839 | } |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 4840 | subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); |
| 4841 | subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4842 | } |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4843 | |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4844 | // Find for each attachment the subpasses that use them. |
| 4845 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 4846 | const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i]; |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 4847 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4848 | input_attachment_to_subpass[subpass.pInputAttachments[j].attachment].push_back(i); |
| 4849 | } |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 4850 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4851 | output_attachment_to_subpass[subpass.pColorAttachments[j].attachment].push_back(i); |
| 4852 | } |
Chia-I Wu | ce532f7 | 2015-10-26 17:32:47 +0800 | [diff] [blame] | 4853 | if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| 4854 | output_attachment_to_subpass[subpass.pDepthStencilAttachment->attachment].push_back(i); |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4855 | } |
| 4856 | } |
| 4857 | // If there is a dependency needed make sure one exists |
| 4858 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 4859 | const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i]; |
| 4860 | // If the attachment is an input then all subpasses that output must have a dependency relationship |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 4861 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4862 | const uint32_t& attachment = subpass.pInputAttachments[j].attachment; |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4863 | CheckDependencyExists(my_data, device, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4864 | } |
| 4865 | // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 4866 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4867 | const uint32_t& attachment = subpass.pColorAttachments[j].attachment; |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4868 | CheckDependencyExists(my_data, device, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); |
| 4869 | CheckDependencyExists(my_data, device, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4870 | } |
Chia-I Wu | ce532f7 | 2015-10-26 17:32:47 +0800 | [diff] [blame] | 4871 | if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| 4872 | const uint32_t& attachment = subpass.pDepthStencilAttachment->attachment; |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4873 | CheckDependencyExists(my_data, device, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); |
| 4874 | CheckDependencyExists(my_data, device, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4875 | } |
| 4876 | } |
| 4877 | // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was written. |
| 4878 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 4879 | const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i]; |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 4880 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4881 | CheckPreserved(my_data, device, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call); |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4882 | } |
| 4883 | } |
| 4884 | return skip_call; |
| 4885 | } |
| 4886 | |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4887 | bool ValidateLayouts(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo) { |
| 4888 | bool skip = false; |
Mark Lobodzinski | 78940a4 | 2015-11-30 16:48:53 -0700 | [diff] [blame] | 4889 | |
| 4890 | #ifdef DISABLE_IMAGE_LAYOUT_VALIDATION |
| 4891 | return skip; |
| 4892 | #endif // DISABLE_IMAGE_LAYOUT_VALIDATION |
| 4893 | |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4894 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 4895 | const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i]; |
| 4896 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
| 4897 | if (subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL && |
| 4898 | subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) { |
| 4899 | if (subpass.pInputAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4900 | // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance |
| 4901 | skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4902 | "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); |
| 4903 | } else { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4904 | skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4905 | "Layout for input attachment is %d but can only be READ_ONLY_OPTIMAL or GENERAL.", subpass.pInputAttachments[j].attachment); |
| 4906 | } |
| 4907 | } |
| 4908 | } |
| 4909 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
| 4910 | if (subpass.pColorAttachments[j].layout != VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL) { |
| 4911 | if (subpass.pColorAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4912 | // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance |
| 4913 | skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4914 | "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); |
| 4915 | } else { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4916 | skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4917 | "Layout for color attachment is %d but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", subpass.pColorAttachments[j].attachment); |
| 4918 | } |
| 4919 | } |
| 4920 | } |
Mark Lobodzinski | c344bef | 2015-10-28 13:03:56 -0600 | [diff] [blame] | 4921 | if ((subpass.pDepthStencilAttachment != NULL) && |
| 4922 | (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4923 | if (subpass.pDepthStencilAttachment->layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL) { |
| 4924 | if (subpass.pDepthStencilAttachment->layout == VK_IMAGE_LAYOUT_GENERAL) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4925 | // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance |
| 4926 | skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4927 | "Layout for depth attachment is GENERAL but should be DEPTH_STENCIL_ATTACHMENT_OPTIMAL."); |
| 4928 | } else { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4929 | skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4930 | "Layout for depth attachment is %d but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL or GENERAL.", subpass.pDepthStencilAttachment->attachment); |
| 4931 | } |
| 4932 | } |
| 4933 | } |
| 4934 | } |
| 4935 | return skip; |
| 4936 | } |
| 4937 | |
Michael Lentine | 07ff1a1 | 2015-10-15 17:07:00 -0500 | [diff] [blame] | 4938 | bool CreatePassDAG(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, std::vector<DAGNode>& subpass_to_node, std::vector<bool>& has_self_dependency) { |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4939 | bool skip_call = false; |
| 4940 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 4941 | DAGNode& subpass_node = subpass_to_node[i]; |
| 4942 | subpass_node.pass = i; |
| 4943 | } |
| 4944 | for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { |
| 4945 | const VkSubpassDependency& dependency = pCreateInfo->pDependencies[i]; |
| 4946 | if (dependency.srcSubpass > dependency.dstSubpass) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4947 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS", |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4948 | "Depedency graph must be specified such that an earlier pass cannot depend on a later pass."); |
Michael Lentine | 07ff1a1 | 2015-10-15 17:07:00 -0500 | [diff] [blame] | 4949 | } else if (dependency.srcSubpass == dependency.dstSubpass) { |
| 4950 | has_self_dependency[dependency.srcSubpass] = true; |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4951 | } |
| 4952 | subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); |
| 4953 | subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); |
| 4954 | } |
| 4955 | return skip_call; |
| 4956 | } |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 4957 | // TODOSC : Add intercept of vkCreateShaderModule |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4958 | |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 4959 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateShaderModule( |
| 4960 | VkDevice device, |
| 4961 | const VkShaderModuleCreateInfo *pCreateInfo, |
| 4962 | const VkAllocationCallbacks* pAllocator, |
| 4963 | VkShaderModule *pShaderModule) |
| 4964 | { |
| 4965 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 4966 | bool skip_call = false; |
| 4967 | if (!shader_is_spirv(pCreateInfo)) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 4968 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 4969 | /* dev */ 0, 0, SHADER_CHECKER_NON_SPIRV_SHADER, "SC", |
| 4970 | "Shader is not SPIR-V"); |
| 4971 | } |
| 4972 | |
| 4973 | if (skip_call) |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 4974 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 4975 | |
| 4976 | VkResult res = my_data->device_dispatch_table->CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); |
| 4977 | |
| 4978 | if (res == VK_SUCCESS) { |
| 4979 | loader_platform_thread_lock_mutex(&globalLock); |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 4980 | my_data->shaderModuleMap[*pShaderModule] = new shader_module(pCreateInfo); |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 4981 | loader_platform_thread_unlock_mutex(&globalLock); |
| 4982 | } |
| 4983 | return res; |
| 4984 | } |
| 4985 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 4986 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkRenderPass* pRenderPass) |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 4987 | { |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4988 | bool skip_call = false; |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 4989 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4990 | // Create DAG |
Michael Lentine | 07ff1a1 | 2015-10-15 17:07:00 -0500 | [diff] [blame] | 4991 | std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4992 | std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); |
Michael Lentine | 07ff1a1 | 2015-10-15 17:07:00 -0500 | [diff] [blame] | 4993 | skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency); |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 4994 | // Validate using DAG |
| 4995 | skip_call |= ValidateDependencies(dev_data, device, pCreateInfo, subpass_to_node); |
| 4996 | skip_call |= ValidateLayouts(dev_data, device, pCreateInfo); |
| 4997 | if (skip_call) { |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 4998 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Michael Lentine | 329697b | 2015-10-06 14:56:18 -0700 | [diff] [blame] | 4999 | } |
Chia-I Wu | 69f4012 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 5000 | VkResult result = dev_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5001 | if (VK_SUCCESS == result) { |
Tobin Ehlis | cb08529 | 2015-12-01 09:57:09 -0700 | [diff] [blame] | 5002 | // TODOSC : Merge in tracking of renderpass from ShaderChecker |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 5003 | // Shadow create info and store in map |
Courtney Goeltzenleuchter | 382489d | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 5004 | VkRenderPassCreateInfo* localRPCI = new VkRenderPassCreateInfo(*pCreateInfo); |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 5005 | if (pCreateInfo->pAttachments) { |
| 5006 | localRPCI->pAttachments = new VkAttachmentDescription[localRPCI->attachmentCount]; |
| 5007 | memcpy((void*)localRPCI->pAttachments, pCreateInfo->pAttachments, localRPCI->attachmentCount*sizeof(VkAttachmentDescription)); |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 5008 | } |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 5009 | if (pCreateInfo->pSubpasses) { |
| 5010 | localRPCI->pSubpasses = new VkSubpassDescription[localRPCI->subpassCount]; |
| 5011 | memcpy((void*)localRPCI->pSubpasses, pCreateInfo->pSubpasses, localRPCI->subpassCount*sizeof(VkSubpassDescription)); |
| 5012 | |
| 5013 | for (uint32_t i = 0; i < localRPCI->subpassCount; i++) { |
| 5014 | VkSubpassDescription *subpass = (VkSubpassDescription *) &localRPCI->pSubpasses[i]; |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 5015 | const uint32_t attachmentCount = subpass->inputAttachmentCount + |
| 5016 | subpass->colorAttachmentCount * (1 + (subpass->pResolveAttachments?1:0)) + |
Chia-I Wu | ce532f7 | 2015-10-26 17:32:47 +0800 | [diff] [blame] | 5017 | ((subpass->pDepthStencilAttachment) ? 1 : 0) + subpass->preserveAttachmentCount; |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 5018 | VkAttachmentReference *attachments = new VkAttachmentReference[attachmentCount]; |
| 5019 | |
Cody Northrop | 6de6b0b | 2015-08-04 11:16:41 -0600 | [diff] [blame] | 5020 | memcpy(attachments, subpass->pInputAttachments, |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 5021 | sizeof(attachments[0]) * subpass->inputAttachmentCount); |
Cody Northrop | 6de6b0b | 2015-08-04 11:16:41 -0600 | [diff] [blame] | 5022 | subpass->pInputAttachments = attachments; |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 5023 | attachments += subpass->inputAttachmentCount; |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 5024 | |
Cody Northrop | 6de6b0b | 2015-08-04 11:16:41 -0600 | [diff] [blame] | 5025 | memcpy(attachments, subpass->pColorAttachments, |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 5026 | sizeof(attachments[0]) * subpass->colorAttachmentCount); |
Cody Northrop | 6de6b0b | 2015-08-04 11:16:41 -0600 | [diff] [blame] | 5027 | subpass->pColorAttachments = attachments; |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 5028 | attachments += subpass->colorAttachmentCount; |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 5029 | |
Cody Northrop | 6de6b0b | 2015-08-04 11:16:41 -0600 | [diff] [blame] | 5030 | if (subpass->pResolveAttachments) { |
| 5031 | memcpy(attachments, subpass->pResolveAttachments, |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 5032 | sizeof(attachments[0]) * subpass->colorAttachmentCount); |
Cody Northrop | 6de6b0b | 2015-08-04 11:16:41 -0600 | [diff] [blame] | 5033 | subpass->pResolveAttachments = attachments; |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 5034 | attachments += subpass->colorAttachmentCount; |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 5035 | } |
| 5036 | |
Chia-I Wu | ce532f7 | 2015-10-26 17:32:47 +0800 | [diff] [blame] | 5037 | if (subpass->pDepthStencilAttachment) { |
| 5038 | memcpy(attachments, subpass->pDepthStencilAttachment, |
| 5039 | sizeof(attachments[0]) * 1); |
| 5040 | subpass->pDepthStencilAttachment = attachments; |
| 5041 | attachments += 1; |
| 5042 | } |
| 5043 | |
Cody Northrop | 6de6b0b | 2015-08-04 11:16:41 -0600 | [diff] [blame] | 5044 | memcpy(attachments, subpass->pPreserveAttachments, |
Chia-I Wu | 763a749 | 2015-10-26 20:48:51 +0800 | [diff] [blame] | 5045 | sizeof(attachments[0]) * subpass->preserveAttachmentCount); |
Cody Northrop | 6de6b0b | 2015-08-04 11:16:41 -0600 | [diff] [blame] | 5046 | subpass->pPreserveAttachments = attachments; |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 5047 | } |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 5048 | } |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 5049 | if (pCreateInfo->pDependencies) { |
| 5050 | localRPCI->pDependencies = new VkSubpassDependency[localRPCI->dependencyCount]; |
| 5051 | memcpy((void*)localRPCI->pDependencies, pCreateInfo->pDependencies, localRPCI->dependencyCount*sizeof(VkSubpassDependency)); |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 5052 | } |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 5053 | loader_platform_thread_lock_mutex(&globalLock); |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 5054 | dev_data->renderPassMap[*pRenderPass] = new RENDER_PASS_NODE(localRPCI); |
Michael Lentine | 07ff1a1 | 2015-10-15 17:07:00 -0500 | [diff] [blame] | 5055 | dev_data->renderPassMap[*pRenderPass]->hasSelfDependency = has_self_dependency; |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 5056 | loader_platform_thread_unlock_mutex(&globalLock); |
Tobin Ehlis | 2464b88 | 2015-04-01 08:40:34 -0600 | [diff] [blame] | 5057 | } |
| 5058 | return result; |
| 5059 | } |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 5060 | // Free the renderpass shadow |
| 5061 | static void deleteRenderPasses(layer_data* my_data) |
| 5062 | { |
| 5063 | if (my_data->renderPassMap.size() <= 0) |
| 5064 | return; |
| 5065 | for (auto ii=my_data->renderPassMap.begin(); ii!=my_data->renderPassMap.end(); ++ii) { |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 5066 | const VkRenderPassCreateInfo* pRenderPassInfo = (*ii).second->pCreateInfo; |
Michael Lentine | 07ff1a1 | 2015-10-15 17:07:00 -0500 | [diff] [blame] | 5067 | if (pRenderPassInfo->pAttachments) { |
| 5068 | delete[] pRenderPassInfo->pAttachments; |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 5069 | } |
Michael Lentine | 07ff1a1 | 2015-10-15 17:07:00 -0500 | [diff] [blame] | 5070 | if (pRenderPassInfo->pSubpasses) { |
| 5071 | for (uint32_t i=0; i<pRenderPassInfo->subpassCount; ++i) { |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 5072 | // Attachements are all allocated in a block, so just need to |
| 5073 | // find the first non-null one to delete |
Michael Lentine | 07ff1a1 | 2015-10-15 17:07:00 -0500 | [diff] [blame] | 5074 | if (pRenderPassInfo->pSubpasses[i].pInputAttachments) { |
| 5075 | delete[] pRenderPassInfo->pSubpasses[i].pInputAttachments; |
| 5076 | } else if (pRenderPassInfo->pSubpasses[i].pColorAttachments) { |
| 5077 | delete[] pRenderPassInfo->pSubpasses[i].pColorAttachments; |
| 5078 | } else if (pRenderPassInfo->pSubpasses[i].pResolveAttachments) { |
| 5079 | delete[] pRenderPassInfo->pSubpasses[i].pResolveAttachments; |
| 5080 | } else if (pRenderPassInfo->pSubpasses[i].pPreserveAttachments) { |
| 5081 | delete[] pRenderPassInfo->pSubpasses[i].pPreserveAttachments; |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 5082 | } |
| 5083 | } |
Michael Lentine | 07ff1a1 | 2015-10-15 17:07:00 -0500 | [diff] [blame] | 5084 | delete[] pRenderPassInfo->pSubpasses; |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 5085 | } |
Michael Lentine | 07ff1a1 | 2015-10-15 17:07:00 -0500 | [diff] [blame] | 5086 | if (pRenderPassInfo->pDependencies) { |
| 5087 | delete[] pRenderPassInfo->pDependencies; |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 5088 | } |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 5089 | delete pRenderPassInfo; |
Michael Lentine | 07ff1a1 | 2015-10-15 17:07:00 -0500 | [diff] [blame] | 5090 | delete (*ii).second; |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 5091 | } |
| 5092 | my_data->renderPassMap.clear(); |
| 5093 | } |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5094 | |
| 5095 | bool VerifyFramebufferAndRenderPassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo* pRenderPassBegin) { |
| 5096 | bool skip_call = false; |
| 5097 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); |
| 5098 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer); |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 5099 | const VkRenderPassCreateInfo* pRenderPassInfo = dev_data->renderPassMap[pRenderPassBegin->renderPass]->pCreateInfo; |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5100 | const VkFramebufferCreateInfo* pFramebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer]; |
| 5101 | if (pRenderPassInfo->attachmentCount != pFramebufferInfo->attachmentCount) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 5102 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS", |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5103 | "You cannot start a render pass using a framebuffer with a different number of attachments."); |
| 5104 | } |
| 5105 | for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { |
| 5106 | const VkImageView& image_view = pFramebufferInfo->pAttachments[i]; |
| 5107 | const VkImage& image = dev_data->imageViewMap[image_view]->image; |
| 5108 | auto image_data = pCB->imageLayoutMap.find(image); |
| 5109 | if (image_data == pCB->imageLayoutMap.end()) { |
| 5110 | pCB->imageLayoutMap[image].initialLayout = pRenderPassInfo->pAttachments[i].initialLayout; |
| 5111 | pCB->imageLayoutMap[image].layout = pRenderPassInfo->pAttachments[i].initialLayout; |
| 5112 | } else if (pRenderPassInfo->pAttachments[i].initialLayout != image_data->second.layout) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 5113 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS", |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5114 | "You cannot start a render pass using attachment %i where the intial layout differs from the starting layout.", i); |
| 5115 | } |
| 5116 | } |
| 5117 | return skip_call; |
| 5118 | } |
| 5119 | |
| 5120 | void TransitionSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo* pRenderPassBegin, const int subpass_index) { |
| 5121 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); |
| 5122 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer); |
| 5123 | auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); |
| 5124 | if (render_pass_data == dev_data->renderPassMap.end()) { |
| 5125 | return; |
| 5126 | } |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 5127 | const VkRenderPassCreateInfo* pRenderPassInfo = render_pass_data->second->pCreateInfo; |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5128 | auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer); |
| 5129 | if (framebuffer_data == dev_data->frameBufferMap.end()) { |
| 5130 | return; |
| 5131 | } |
| 5132 | const VkFramebufferCreateInfo* pFramebufferInfo = framebuffer_data->second; |
| 5133 | const VkSubpassDescription& subpass = pRenderPassInfo->pSubpasses[subpass_index]; |
| 5134 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
| 5135 | const VkImageView& image_view = pFramebufferInfo->pAttachments[subpass.pInputAttachments[j].attachment]; |
| 5136 | auto image_view_data = dev_data->imageViewMap.find(image_view); |
| 5137 | if (image_view_data != dev_data->imageViewMap.end()) { |
| 5138 | auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image); |
| 5139 | if (image_layout != pCB->imageLayoutMap.end()) { |
| 5140 | image_layout->second.layout = subpass.pInputAttachments[j].layout; |
| 5141 | } |
| 5142 | } |
| 5143 | } |
| 5144 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
| 5145 | const VkImageView& image_view = pFramebufferInfo->pAttachments[subpass.pColorAttachments[j].attachment]; |
| 5146 | auto image_view_data = dev_data->imageViewMap.find(image_view); |
| 5147 | if (image_view_data != dev_data->imageViewMap.end()) { |
| 5148 | auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image); |
| 5149 | if (image_layout != pCB->imageLayoutMap.end()) { |
| 5150 | image_layout->second.layout = subpass.pColorAttachments[j].layout; |
| 5151 | } |
| 5152 | } |
| 5153 | } |
Michael Lentine | 2b9eda4 | 2015-10-28 15:55:18 -0700 | [diff] [blame] | 5154 | if ((subpass.pDepthStencilAttachment != NULL) && |
Mark Lobodzinski | c344bef | 2015-10-28 13:03:56 -0600 | [diff] [blame] | 5155 | (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5156 | const VkImageView& image_view = pFramebufferInfo->pAttachments[subpass.pDepthStencilAttachment->attachment]; |
| 5157 | auto image_view_data = dev_data->imageViewMap.find(image_view); |
| 5158 | if (image_view_data != dev_data->imageViewMap.end()) { |
| 5159 | auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image); |
| 5160 | if (image_layout != pCB->imageLayoutMap.end()) { |
| 5161 | image_layout->second.layout = subpass.pDepthStencilAttachment->layout; |
| 5162 | } |
| 5163 | } |
| 5164 | } |
| 5165 | } |
| 5166 | |
Michael Lentine | 2b9eda4 | 2015-10-28 15:55:18 -0700 | [diff] [blame] | 5167 | bool validatePrimaryCommandBuffer(const layer_data* my_data, const GLOBAL_CB_NODE* pCB, const std::string& cmd_name) { |
| 5168 | bool skip_call = false; |
| 5169 | if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 5170 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
Michael Lentine | 2b9eda4 | 2015-10-28 15:55:18 -0700 | [diff] [blame] | 5171 | "Cannot execute command %s on a secondary command buffer.", cmd_name.c_str()); |
| 5172 | } |
| 5173 | return skip_call; |
| 5174 | } |
| 5175 | |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5176 | void TransitionFinalSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo* pRenderPassBegin) { |
| 5177 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); |
| 5178 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer); |
| 5179 | auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); |
| 5180 | if (render_pass_data == dev_data->renderPassMap.end()) { |
| 5181 | return; |
| 5182 | } |
Tobin Ehlis | ad61de4 | 2015-12-02 13:53:34 -0700 | [diff] [blame] | 5183 | const VkRenderPassCreateInfo* pRenderPassInfo = render_pass_data->second->pCreateInfo; |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5184 | auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer); |
| 5185 | if (framebuffer_data == dev_data->frameBufferMap.end()) { |
| 5186 | return; |
| 5187 | } |
| 5188 | const VkFramebufferCreateInfo* pFramebufferInfo = framebuffer_data->second; |
| 5189 | for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { |
| 5190 | const VkImageView& image_view = pFramebufferInfo->pAttachments[i]; |
| 5191 | auto image_view_data = dev_data->imageViewMap.find(image_view); |
| 5192 | if (image_view_data != dev_data->imageViewMap.end()) { |
| 5193 | auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image); |
| 5194 | if (image_layout != pCB->imageLayoutMap.end()) { |
| 5195 | image_layout->second.layout = pRenderPassInfo->pAttachments[i].finalLayout; |
| 5196 | } |
| 5197 | } |
| 5198 | } |
| 5199 | } |
| 5200 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 5201 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5202 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 5203 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 5204 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 5205 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5206 | if (pCB) { |
Tobin Ehlis | 8b6c235 | 2015-06-23 16:13:03 -0600 | [diff] [blame] | 5207 | if (pRenderPassBegin && pRenderPassBegin->renderPass) { |
Mark Lobodzinski | c344bef | 2015-10-28 13:03:56 -0600 | [diff] [blame] | 5208 | skipCall |= VerifyFramebufferAndRenderPassLayouts(commandBuffer, pRenderPassBegin); |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 5209 | skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBeginRenderPass"); |
Michael Lentine | 2b9eda4 | 2015-10-28 15:55:18 -0700 | [diff] [blame] | 5210 | skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdBeginRenderPass"); |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 5211 | skipCall |= addCmd(dev_data, pCB, CMD_BEGINRENDERPASS); |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 5212 | pCB->activeRenderPass = pRenderPassBegin->renderPass; |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5213 | // This is a shallow copy as that is all that is needed for now |
| 5214 | pCB->activeRenderPassBeginInfo = *pRenderPassBegin; |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 5215 | pCB->activeSubpass = 0; |
| 5216 | pCB->framebuffer = pRenderPassBegin->framebuffer; |
| 5217 | if (pCB->lastBoundPipeline) { |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 5218 | skipCall |= validatePipelineState(dev_data, pCB, VK_PIPELINE_BIND_POINT_GRAPHICS, pCB->lastBoundPipeline); |
Tobin Ehlis | 8b6c235 | 2015-06-23 16:13:03 -0600 | [diff] [blame] | 5219 | } |
Tobin Ehlis | e407678 | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 5220 | } else { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 5221 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS", |
Tobin Ehlis | 8b6c235 | 2015-06-23 16:13:03 -0600 | [diff] [blame] | 5222 | "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()"); |
Tony Barbour | b9f82ba | 2015-04-06 11:09:26 -0600 | [diff] [blame] | 5223 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5224 | } |
Mark Lobodzinski | c344bef | 2015-10-28 13:03:56 -0600 | [diff] [blame] | 5225 | if (VK_FALSE == skipCall) { |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 5226 | dev_data->device_dispatch_table->CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); |
Mark Lobodzinski | c344bef | 2015-10-28 13:03:56 -0600 | [diff] [blame] | 5227 | // This is a shallow copy as that is all that is needed for now |
| 5228 | dev_data->renderPassBeginInfo = *pRenderPassBegin; |
| 5229 | dev_data->currentSubpass = 0; |
| 5230 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5231 | } |
| 5232 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 5233 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 5234 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 5235 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 5236 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 5237 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5238 | TransitionSubpassLayouts(commandBuffer, &dev_data->renderPassBeginInfo, ++dev_data->currentSubpass); |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 5239 | if (pCB) { |
Michael Lentine | 2b9eda4 | 2015-10-28 15:55:18 -0700 | [diff] [blame] | 5240 | skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass"); |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 5241 | skipCall |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS); |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 5242 | pCB->activeSubpass++; |
Tony Barbour | cbc0fa8 | 2015-12-15 10:24:45 -0700 | [diff] [blame] | 5243 | TransitionSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 5244 | if (pCB->lastBoundPipeline) { |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 5245 | skipCall |= validatePipelineState(dev_data, pCB, VK_PIPELINE_BIND_POINT_GRAPHICS, pCB->lastBoundPipeline); |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 5246 | } |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 5247 | skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass"); |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 5248 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 5249 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 5250 | dev_data->device_dispatch_table->CmdNextSubpass(commandBuffer, contents); |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 5251 | } |
| 5252 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 5253 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndRenderPass(VkCommandBuffer commandBuffer) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5254 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 5255 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 5256 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 5257 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5258 | TransitionFinalSubpassLayouts(commandBuffer, &dev_data->renderPassBeginInfo); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5259 | if (pCB) { |
Michael Lentine | 2b9eda4 | 2015-10-28 15:55:18 -0700 | [diff] [blame] | 5260 | skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass"); |
Michael Lentine | 2b9eda4 | 2015-10-28 15:55:18 -0700 | [diff] [blame] | 5261 | skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass"); |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 5262 | skipCall |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS); |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5263 | TransitionFinalSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo); |
Mark Lobodzinski | a0f061c | 2015-09-30 16:19:16 -0600 | [diff] [blame] | 5264 | pCB->activeRenderPass = 0; |
| 5265 | pCB->activeSubpass = 0; |
Chia-I Wu | 88eaa3b | 2015-06-26 15:34:39 +0800 | [diff] [blame] | 5266 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 5267 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 5268 | dev_data->device_dispatch_table->CmdEndRenderPass(commandBuffer); |
Chia-I Wu | 88eaa3b | 2015-06-26 15:34:39 +0800 | [diff] [blame] | 5269 | } |
| 5270 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 5271 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer* pCommandBuffers) |
Chia-I Wu | 88eaa3b | 2015-06-26 15:34:39 +0800 | [diff] [blame] | 5272 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 5273 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 5274 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 5275 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Chia-I Wu | 88eaa3b | 2015-06-26 15:34:39 +0800 | [diff] [blame] | 5276 | if (pCB) { |
Tobin Ehlis | 5f728d3 | 2015-09-17 14:18:16 -0600 | [diff] [blame] | 5277 | GLOBAL_CB_NODE* pSubCB = NULL; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 5278 | for (uint32_t i=0; i<commandBuffersCount; i++) { |
| 5279 | pSubCB = getCBNode(dev_data, pCommandBuffers[i]); |
Tobin Ehlis | 5f728d3 | 2015-09-17 14:18:16 -0600 | [diff] [blame] | 5280 | if (!pSubCB) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 5281 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 5282 | "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p in element %u of pCommandBuffers array.", (void*)pCommandBuffers[i], i); |
| 5283 | } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 5284 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 5285 | "vkCmdExecuteCommands() called w/ Primary Cmd Buffer %p in element %u of pCommandBuffers array. All cmd buffers in pCommandBuffers array must be secondary.", (void*)pCommandBuffers[i], i); |
Tobin Ehlis | 5f728d3 | 2015-09-17 14:18:16 -0600 | [diff] [blame] | 5286 | } |
| 5287 | } |
Michael Lentine | 2b9eda4 | 2015-10-28 15:55:18 -0700 | [diff] [blame] | 5288 | skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands"); |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 5289 | skipCall |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5290 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 5291 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 5292 | dev_data->device_dispatch_table->CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5293 | } |
| 5294 | |
Michael Lentine | ee4ad4d | 2015-10-23 12:41:44 -0700 | [diff] [blame] | 5295 | bool ValidateMapImageLayouts(VkDevice device, VkDeviceMemory mem) { |
| 5296 | bool skip_call = false; |
| 5297 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 5298 | auto mem_data = dev_data->memImageMap.find(mem); |
| 5299 | if (mem_data != dev_data->memImageMap.end()) { |
| 5300 | auto image_data = dev_data->imageLayoutMap.find(mem_data->second); |
| 5301 | if (image_data != dev_data->imageLayoutMap.end()) { |
| 5302 | if (image_data->second->layout != VK_IMAGE_LAYOUT_PREINITIALIZED && image_data->second->layout != VK_IMAGE_LAYOUT_GENERAL) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 5303 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Michael Lentine | ee4ad4d | 2015-10-23 12:41:44 -0700 | [diff] [blame] | 5304 | "Cannot map an image with layout %d. Only GENERAL or PREINITIALIZED are supported.", image_data->second->layout); |
| 5305 | } |
| 5306 | } |
| 5307 | } |
| 5308 | return skip_call; |
| 5309 | } |
| 5310 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 5311 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkMapMemory( |
Michael Lentine | ee4ad4d | 2015-10-23 12:41:44 -0700 | [diff] [blame] | 5312 | VkDevice device, |
| 5313 | VkDeviceMemory mem, |
| 5314 | VkDeviceSize offset, |
| 5315 | VkDeviceSize size, |
| 5316 | VkFlags flags, |
| 5317 | void **ppData) |
| 5318 | { |
| 5319 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Mark Lobodzinski | 78940a4 | 2015-11-30 16:48:53 -0700 | [diff] [blame] | 5320 | |
| 5321 | bool skip_call = VK_FALSE; |
| 5322 | #ifndef DISABLE_IMAGE_LAYOUT_VALIDATION |
| 5323 | skip_call = ValidateMapImageLayouts(device, mem); |
| 5324 | #endif // DISABLE_IMAGE_LAYOUT_VALIDATION |
| 5325 | |
Michael Lentine | ee4ad4d | 2015-10-23 12:41:44 -0700 | [diff] [blame] | 5326 | if (VK_FALSE == skip_call) { |
| 5327 | return dev_data->device_dispatch_table->MapMemory(device, mem, offset, size, flags, ppData); |
| 5328 | } |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 5329 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Michael Lentine | ee4ad4d | 2015-10-23 12:41:44 -0700 | [diff] [blame] | 5330 | } |
| 5331 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 5332 | VKAPI_ATTR VkResult VKAPI_CALL vkBindImageMemory( |
Michael Lentine | ee4ad4d | 2015-10-23 12:41:44 -0700 | [diff] [blame] | 5333 | VkDevice device, |
| 5334 | VkImage image, |
| 5335 | VkDeviceMemory mem, |
| 5336 | VkDeviceSize memOffset) |
| 5337 | { |
| 5338 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 5339 | VkResult result = dev_data->device_dispatch_table->BindImageMemory(device, image, mem, memOffset); |
| 5340 | loader_platform_thread_lock_mutex(&globalLock); |
| 5341 | dev_data->memImageMap[mem] = image; |
| 5342 | loader_platform_thread_unlock_mutex(&globalLock); |
| 5343 | return result; |
| 5344 | } |
| 5345 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 5346 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSwapchainKHR( |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5347 | VkDevice device, |
| 5348 | const VkSwapchainCreateInfoKHR *pCreateInfo, |
Ian Elliott | c623ba5 | 2015-11-20 14:13:17 -0700 | [diff] [blame] | 5349 | const VkAllocationCallbacks *pAllocator, |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5350 | VkSwapchainKHR *pSwapchain) |
| 5351 | { |
| 5352 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Ian Elliott | c623ba5 | 2015-11-20 14:13:17 -0700 | [diff] [blame] | 5353 | VkResult result = dev_data->device_dispatch_table->CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5354 | |
| 5355 | if (VK_SUCCESS == result) { |
| 5356 | SWAPCHAIN_NODE *swapchain_data = new SWAPCHAIN_NODE; |
| 5357 | loader_platform_thread_lock_mutex(&globalLock); |
| 5358 | dev_data->device_extensions.swapchainMap[*pSwapchain] = swapchain_data; |
| 5359 | loader_platform_thread_unlock_mutex(&globalLock); |
| 5360 | } |
| 5361 | |
| 5362 | return result; |
| 5363 | } |
| 5364 | |
Ian Elliott | c623ba5 | 2015-11-20 14:13:17 -0700 | [diff] [blame] | 5365 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroySwapchainKHR( |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5366 | VkDevice device, |
Ian Elliott | c623ba5 | 2015-11-20 14:13:17 -0700 | [diff] [blame] | 5367 | VkSwapchainKHR swapchain, |
| 5368 | const VkAllocationCallbacks *pAllocator) |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5369 | { |
| 5370 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5371 | |
| 5372 | loader_platform_thread_lock_mutex(&globalLock); |
| 5373 | auto swapchain_data = dev_data->device_extensions.swapchainMap.find(swapchain); |
| 5374 | if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) { |
| 5375 | if (swapchain_data->second->images.size() > 0) { |
| 5376 | for (auto swapchain_image : swapchain_data->second->images) { |
| 5377 | auto image_item = dev_data->imageLayoutMap.find(swapchain_image); |
| 5378 | if (image_item != dev_data->imageLayoutMap.end()) |
| 5379 | dev_data->imageLayoutMap.erase(image_item); |
| 5380 | } |
| 5381 | } |
| 5382 | delete swapchain_data->second; |
| 5383 | dev_data->device_extensions.swapchainMap.erase(swapchain); |
| 5384 | } |
| 5385 | loader_platform_thread_unlock_mutex(&globalLock); |
Ian Elliott | c623ba5 | 2015-11-20 14:13:17 -0700 | [diff] [blame] | 5386 | return dev_data->device_dispatch_table->DestroySwapchainKHR(device, swapchain, pAllocator); |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5387 | } |
| 5388 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 5389 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkGetSwapchainImagesKHR( |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5390 | VkDevice device, |
| 5391 | VkSwapchainKHR swapchain, |
| 5392 | uint32_t* pCount, |
| 5393 | VkImage* pSwapchainImages) |
| 5394 | { |
| 5395 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 5396 | VkResult result = dev_data->device_dispatch_table->GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages); |
| 5397 | |
| 5398 | if (result == VK_SUCCESS && pSwapchainImages != NULL) { |
| 5399 | // This should never happen and is checked by param checker. |
| 5400 | if (!pCount) return result; |
| 5401 | for (uint32_t i = 0; i < *pCount; ++i) { |
| 5402 | IMAGE_NODE* image_node = new IMAGE_NODE; |
| 5403 | image_node->layout = VK_IMAGE_LAYOUT_UNDEFINED; |
| 5404 | loader_platform_thread_lock_mutex(&globalLock); |
| 5405 | dev_data->device_extensions.swapchainMap[swapchain]->images.push_back(pSwapchainImages[i]); |
| 5406 | dev_data->imageLayoutMap[pSwapchainImages[i]] = image_node; |
| 5407 | loader_platform_thread_unlock_mutex(&globalLock); |
| 5408 | } |
| 5409 | } |
| 5410 | return result; |
| 5411 | } |
| 5412 | |
Ian Elliott | c623ba5 | 2015-11-20 14:13:17 -0700 | [diff] [blame] | 5413 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR* pPresentInfo) |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5414 | { |
| 5415 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); |
| 5416 | bool skip_call = false; |
| 5417 | |
Mark Lobodzinski | 78940a4 | 2015-11-30 16:48:53 -0700 | [diff] [blame] | 5418 | #ifndef DISABLE_IMAGE_LAYOUT_VALIDATION |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5419 | if (pPresentInfo) { |
| 5420 | for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { |
Ian Elliott | c623ba5 | 2015-11-20 14:13:17 -0700 | [diff] [blame] | 5421 | auto swapchain_data = dev_data->device_extensions.swapchainMap.find(pPresentInfo->pSwapchains[i]); |
| 5422 | if (swapchain_data != dev_data->device_extensions.swapchainMap.end() && pPresentInfo->pImageIndices[i] < swapchain_data->second->images.size()) { |
| 5423 | VkImage image = swapchain_data->second->images[pPresentInfo->pImageIndices[i]]; |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5424 | auto image_data = dev_data->imageLayoutMap.find(image); |
| 5425 | if (image_data != dev_data->imageLayoutMap.end()) { |
Ian Elliott | c623ba5 | 2015-11-20 14:13:17 -0700 | [diff] [blame] | 5426 | if (image_data->second->layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 5427 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, (uint64_t)queue, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5428 | "Images passed to present must be in layout PRESENT_SOURCE_KHR but is in %d", image_data->second->layout); |
| 5429 | } |
| 5430 | } |
| 5431 | } |
| 5432 | } |
| 5433 | } |
Mark Lobodzinski | 78940a4 | 2015-11-30 16:48:53 -0700 | [diff] [blame] | 5434 | #endif // DISABLE_IMAGE_LAYOUT_VALIDATION |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5435 | |
| 5436 | if (VK_FALSE == skip_call) |
| 5437 | return dev_data->device_dispatch_table->QueuePresentKHR(queue, pPresentInfo); |
Courtney Goeltzenleuchter | 48605a5 | 2015-12-10 16:41:22 -0700 | [diff] [blame^] | 5438 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5439 | } |
| 5440 | |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 5441 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugReportCallbackEXT( |
| 5442 | VkInstance instance, |
| 5443 | const VkDebugReportCallbackCreateInfoEXT* pCreateInfo, |
| 5444 | const VkAllocationCallbacks* pAllocator, |
| 5445 | VkDebugReportCallbackEXT* pMsgCallback) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5446 | { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 5447 | layer_data* my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); |
Courtney Goeltzenleuchter | f6a6e22 | 2015-11-30 12:13:14 -0700 | [diff] [blame] | 5448 | VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 5449 | VkResult res = pTable->CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); |
Tobin Ehlis | c91330b | 2015-06-16 09:04:30 -0600 | [diff] [blame] | 5450 | if (VK_SUCCESS == res) { |
Courtney Goeltzenleuchter | f6a6e22 | 2015-11-30 12:13:14 -0700 | [diff] [blame] | 5451 | res = layer_create_msg_callback(my_data->report_data, pCreateInfo, pAllocator, pMsgCallback); |
Tobin Ehlis | c91330b | 2015-06-16 09:04:30 -0600 | [diff] [blame] | 5452 | } |
| 5453 | return res; |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5454 | } |
| 5455 | |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 5456 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT( |
Courtney Goeltzenleuchter | f6a6e22 | 2015-11-30 12:13:14 -0700 | [diff] [blame] | 5457 | VkInstance instance, |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 5458 | VkDebugReportCallbackEXT msgCallback, |
Courtney Goeltzenleuchter | f6a6e22 | 2015-11-30 12:13:14 -0700 | [diff] [blame] | 5459 | const VkAllocationCallbacks* pAllocator) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5460 | { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 5461 | layer_data* my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); |
Courtney Goeltzenleuchter | f6a6e22 | 2015-11-30 12:13:14 -0700 | [diff] [blame] | 5462 | VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 5463 | pTable->DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); |
Courtney Goeltzenleuchter | f6a6e22 | 2015-11-30 12:13:14 -0700 | [diff] [blame] | 5464 | layer_destroy_msg_callback(my_data->report_data, msgCallback, pAllocator); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5465 | } |
| 5466 | |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 5467 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDebugReportMessageEXT( |
Courtney Goeltzenleuchter | 5a424ce | 2015-12-01 14:10:55 -0700 | [diff] [blame] | 5468 | VkInstance instance, |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 5469 | VkDebugReportFlagsEXT flags, |
| 5470 | VkDebugReportObjectTypeEXT objType, |
Courtney Goeltzenleuchter | 5a424ce | 2015-12-01 14:10:55 -0700 | [diff] [blame] | 5471 | uint64_t object, |
| 5472 | size_t location, |
| 5473 | int32_t msgCode, |
| 5474 | const char* pLayerPrefix, |
| 5475 | const char* pMsg) |
| 5476 | { |
| 5477 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 5478 | my_data->instance_dispatch_table->DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); |
Courtney Goeltzenleuchter | 5a424ce | 2015-12-01 14:10:55 -0700 | [diff] [blame] | 5479 | } |
| 5480 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 5481 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDbgMarkerBegin(VkCommandBuffer commandBuffer, const char* pMarker) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5482 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 5483 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 5484 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 5485 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 5486 | if (!dev_data->device_extensions.debug_marker_enabled) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 5487 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, 0, DRAWSTATE_INVALID_EXTENSION, "DS", |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 5488 | "Attempt to use CmdDbgMarkerBegin but extension disabled!"); |
Jon Ashburn | 6f8cd63 | 2015-06-01 09:37:38 -0600 | [diff] [blame] | 5489 | return; |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 5490 | } else if (pCB) { |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 5491 | |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 5492 | skipCall |= addCmd(dev_data, pCB, CMD_DBGMARKERBEGIN); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5493 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 5494 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 5495 | debug_marker_dispatch_table(commandBuffer)->CmdDbgMarkerBegin(commandBuffer, pMarker); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5496 | } |
| 5497 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 5498 | VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDbgMarkerEnd(VkCommandBuffer commandBuffer) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5499 | { |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 5500 | VkBool32 skipCall = VK_FALSE; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 5501 | layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 5502 | GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 5503 | if (!dev_data->device_extensions.debug_marker_enabled) { |
Courtney Goeltzenleuchter | acb1359 | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 5504 | skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, 0, DRAWSTATE_INVALID_EXTENSION, "DS", |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 5505 | "Attempt to use CmdDbgMarkerEnd but extension disabled!"); |
Jon Ashburn | 6f8cd63 | 2015-06-01 09:37:38 -0600 | [diff] [blame] | 5506 | return; |
Tobin Ehlis | a366ca2 | 2015-06-19 15:07:05 -0600 | [diff] [blame] | 5507 | } else if (pCB) { |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 5508 | |
Tobin Ehlis | 42d440c | 2015-10-20 17:06:16 -0600 | [diff] [blame] | 5509 | skipCall |= addCmd(dev_data, pCB, CMD_DBGMARKEREND); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5510 | } |
Tobin Ehlis | 48ddcb8 | 2015-09-09 11:31:10 -0600 | [diff] [blame] | 5511 | if (VK_FALSE == skipCall) |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 5512 | debug_marker_dispatch_table(commandBuffer)->CmdDbgMarkerEnd(commandBuffer); |
Jon Ashburn | 6f8cd63 | 2015-06-01 09:37:38 -0600 | [diff] [blame] | 5513 | } |
| 5514 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 5515 | VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char* funcName) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5516 | { |
Jon Ashburn | 1245cec | 2015-05-18 13:20:15 -0600 | [diff] [blame] | 5517 | if (dev == NULL) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5518 | return NULL; |
Jon Ashburn | e0fa228 | 2015-05-20 09:00:28 -0600 | [diff] [blame] | 5519 | |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 5520 | layer_data *dev_data; |
Jon Ashburn | 4f2575f | 2015-05-28 16:25:02 -0600 | [diff] [blame] | 5521 | /* loader uses this to force layer initialization; device object is wrapped */ |
| 5522 | if (!strcmp(funcName, "vkGetDeviceProcAddr")) { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 5523 | VkBaseLayerObject* wrapped_dev = (VkBaseLayerObject*) dev; |
| 5524 | dev_data = get_my_data_ptr(get_dispatch_key(wrapped_dev->baseObject), layer_data_map); |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 5525 | dev_data->device_dispatch_table = new VkLayerDispatchTable; |
| 5526 | layer_initialize_dispatch_table(dev_data->device_dispatch_table, wrapped_dev); |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5527 | return (PFN_vkVoidFunction) vkGetDeviceProcAddr; |
Jon Ashburn | 4f2575f | 2015-05-28 16:25:02 -0600 | [diff] [blame] | 5528 | } |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 5529 | dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); |
Courtney Goeltzenleuchter | be63799 | 2015-06-25 18:01:43 -0600 | [diff] [blame] | 5530 | if (!strcmp(funcName, "vkCreateDevice")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5531 | return (PFN_vkVoidFunction) vkCreateDevice; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5532 | if (!strcmp(funcName, "vkDestroyDevice")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5533 | return (PFN_vkVoidFunction) vkDestroyDevice; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5534 | if (!strcmp(funcName, "vkQueueSubmit")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5535 | return (PFN_vkVoidFunction) vkQueueSubmit; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 5536 | if (!strcmp(funcName, "vkDestroyInstance")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5537 | return (PFN_vkVoidFunction) vkDestroyInstance; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 5538 | if (!strcmp(funcName, "vkDestroyDevice")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5539 | return (PFN_vkVoidFunction) vkDestroyDevice; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 5540 | if (!strcmp(funcName, "vkDestroyFence")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5541 | return (PFN_vkVoidFunction) vkDestroyFence; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 5542 | if (!strcmp(funcName, "vkDestroySemaphore")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5543 | return (PFN_vkVoidFunction) vkDestroySemaphore; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 5544 | if (!strcmp(funcName, "vkDestroyEvent")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5545 | return (PFN_vkVoidFunction) vkDestroyEvent; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 5546 | if (!strcmp(funcName, "vkDestroyQueryPool")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5547 | return (PFN_vkVoidFunction) vkDestroyQueryPool; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 5548 | if (!strcmp(funcName, "vkDestroyBuffer")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5549 | return (PFN_vkVoidFunction) vkDestroyBuffer; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 5550 | if (!strcmp(funcName, "vkDestroyBufferView")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5551 | return (PFN_vkVoidFunction) vkDestroyBufferView; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 5552 | if (!strcmp(funcName, "vkDestroyImage")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5553 | return (PFN_vkVoidFunction) vkDestroyImage; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 5554 | if (!strcmp(funcName, "vkDestroyImageView")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5555 | return (PFN_vkVoidFunction) vkDestroyImageView; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 5556 | if (!strcmp(funcName, "vkDestroyShaderModule")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5557 | return (PFN_vkVoidFunction) vkDestroyShaderModule; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 5558 | if (!strcmp(funcName, "vkDestroyPipeline")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5559 | return (PFN_vkVoidFunction) vkDestroyPipeline; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 5560 | if (!strcmp(funcName, "vkDestroyPipelineLayout")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5561 | return (PFN_vkVoidFunction) vkDestroyPipelineLayout; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 5562 | if (!strcmp(funcName, "vkDestroySampler")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5563 | return (PFN_vkVoidFunction) vkDestroySampler; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 5564 | if (!strcmp(funcName, "vkDestroyDescriptorSetLayout")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5565 | return (PFN_vkVoidFunction) vkDestroyDescriptorSetLayout; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 5566 | if (!strcmp(funcName, "vkDestroyDescriptorPool")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5567 | return (PFN_vkVoidFunction) vkDestroyDescriptorPool; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 5568 | if (!strcmp(funcName, "vkDestroyFramebuffer")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5569 | return (PFN_vkVoidFunction) vkDestroyFramebuffer; |
Tobin Ehlis | 1dce5f1 | 2015-07-07 10:42:20 -0600 | [diff] [blame] | 5570 | if (!strcmp(funcName, "vkDestroyRenderPass")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5571 | return (PFN_vkVoidFunction) vkDestroyRenderPass; |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 5572 | if (!strcmp(funcName, "vkCreateBuffer")) |
| 5573 | return (PFN_vkVoidFunction) vkCreateBuffer; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5574 | if (!strcmp(funcName, "vkCreateBufferView")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5575 | return (PFN_vkVoidFunction) vkCreateBufferView; |
Tobin Ehlis | b46be81 | 2015-10-23 16:00:08 -0600 | [diff] [blame] | 5576 | if (!strcmp(funcName, "vkCreateImage")) |
| 5577 | return (PFN_vkVoidFunction) vkCreateImage; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5578 | if (!strcmp(funcName, "vkCreateImageView")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5579 | return (PFN_vkVoidFunction) vkCreateImageView; |
Jon Ashburn | 0d60d27 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 5580 | if (!strcmp(funcName, "CreatePipelineCache")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5581 | return (PFN_vkVoidFunction) vkCreatePipelineCache; |
Jon Ashburn | 0d60d27 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 5582 | if (!strcmp(funcName, "DestroyPipelineCache")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5583 | return (PFN_vkVoidFunction) vkDestroyPipelineCache; |
Jon Ashburn | 0d60d27 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 5584 | if (!strcmp(funcName, "GetPipelineCacheData")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5585 | return (PFN_vkVoidFunction) vkGetPipelineCacheData; |
Jon Ashburn | 0d60d27 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 5586 | if (!strcmp(funcName, "MergePipelineCaches")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5587 | return (PFN_vkVoidFunction) vkMergePipelineCaches; |
Jon Ashburn | 0d60d27 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 5588 | if (!strcmp(funcName, "vkCreateGraphicsPipelines")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5589 | return (PFN_vkVoidFunction) vkCreateGraphicsPipelines; |
Mark Lobodzinski | 2adea75 | 2015-11-10 15:25:01 -0700 | [diff] [blame] | 5590 | if (!strcmp(funcName, "vkCreateComputePipelines")) |
| 5591 | return (PFN_vkVoidFunction) vkCreateComputePipelines; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5592 | if (!strcmp(funcName, "vkCreateSampler")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5593 | return (PFN_vkVoidFunction) vkCreateSampler; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5594 | if (!strcmp(funcName, "vkCreateDescriptorSetLayout")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5595 | return (PFN_vkVoidFunction) vkCreateDescriptorSetLayout; |
Mark Lobodzinski | 556f721 | 2015-04-17 14:11:39 -0500 | [diff] [blame] | 5596 | if (!strcmp(funcName, "vkCreatePipelineLayout")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5597 | return (PFN_vkVoidFunction) vkCreatePipelineLayout; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5598 | if (!strcmp(funcName, "vkCreateDescriptorPool")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5599 | return (PFN_vkVoidFunction) vkCreateDescriptorPool; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5600 | if (!strcmp(funcName, "vkResetDescriptorPool")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5601 | return (PFN_vkVoidFunction) vkResetDescriptorPool; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 5602 | if (!strcmp(funcName, "vkAllocateDescriptorSets")) |
| 5603 | return (PFN_vkVoidFunction) vkAllocateDescriptorSets; |
Tobin Ehlis | 3c54311 | 2015-10-08 13:13:50 -0600 | [diff] [blame] | 5604 | if (!strcmp(funcName, "vkFreeDescriptorSets")) |
| 5605 | return (PFN_vkVoidFunction) vkFreeDescriptorSets; |
Chia-I Wu | 8cd8ecd | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 5606 | if (!strcmp(funcName, "vkUpdateDescriptorSets")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5607 | return (PFN_vkVoidFunction) vkUpdateDescriptorSets; |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 5608 | if (!strcmp(funcName, "vkCreateCommandPool")) |
| 5609 | return (PFN_vkVoidFunction) vkCreateCommandPool; |
| 5610 | if (!strcmp(funcName, "vkDestroyCommandPool")) |
| 5611 | return (PFN_vkVoidFunction) vkDestroyCommandPool; |
Tobin Ehlis | 4c8381e | 2015-12-14 13:46:38 -0700 | [diff] [blame] | 5612 | if (!strcmp(funcName, "vkResetCommandPool")) |
| 5613 | return (PFN_vkVoidFunction) vkResetCommandPool; |
Chia-I Wu | 1f85191 | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 5614 | if (!strcmp(funcName, "vkAllocateCommandBuffers")) |
| 5615 | return (PFN_vkVoidFunction) vkAllocateCommandBuffers; |
Mark Lobodzinski | a3b99d8 | 2015-11-18 08:38:27 -0700 | [diff] [blame] | 5616 | if (!strcmp(funcName, "vkFreeCommandBuffers")) |
| 5617 | return (PFN_vkVoidFunction) vkFreeCommandBuffers; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5618 | if (!strcmp(funcName, "vkBeginCommandBuffer")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5619 | return (PFN_vkVoidFunction) vkBeginCommandBuffer; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5620 | if (!strcmp(funcName, "vkEndCommandBuffer")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5621 | return (PFN_vkVoidFunction) vkEndCommandBuffer; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5622 | if (!strcmp(funcName, "vkResetCommandBuffer")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5623 | return (PFN_vkVoidFunction) vkResetCommandBuffer; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5624 | if (!strcmp(funcName, "vkCmdBindPipeline")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5625 | return (PFN_vkVoidFunction) vkCmdBindPipeline; |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 5626 | if (!strcmp(funcName, "vkCmdSetViewport")) |
| 5627 | return (PFN_vkVoidFunction) vkCmdSetViewport; |
Courtney Goeltzenleuchter | 932cdb5 | 2015-09-21 11:44:06 -0600 | [diff] [blame] | 5628 | if (!strcmp(funcName, "vkCmdSetScissor")) |
| 5629 | return (PFN_vkVoidFunction) vkCmdSetScissor; |
Courtney Goeltzenleuchter | 09772bb | 2015-09-17 15:06:17 -0600 | [diff] [blame] | 5630 | if (!strcmp(funcName, "vkCmdSetLineWidth")) |
| 5631 | return (PFN_vkVoidFunction) vkCmdSetLineWidth; |
| 5632 | if (!strcmp(funcName, "vkCmdSetDepthBias")) |
| 5633 | return (PFN_vkVoidFunction) vkCmdSetDepthBias; |
| 5634 | if (!strcmp(funcName, "vkCmdSetBlendConstants")) |
| 5635 | return (PFN_vkVoidFunction) vkCmdSetBlendConstants; |
| 5636 | if (!strcmp(funcName, "vkCmdSetDepthBounds")) |
| 5637 | return (PFN_vkVoidFunction) vkCmdSetDepthBounds; |
| 5638 | if (!strcmp(funcName, "vkCmdSetStencilCompareMask")) |
| 5639 | return (PFN_vkVoidFunction) vkCmdSetStencilCompareMask; |
| 5640 | if (!strcmp(funcName, "vkCmdSetStencilWriteMask")) |
| 5641 | return (PFN_vkVoidFunction) vkCmdSetStencilWriteMask; |
| 5642 | if (!strcmp(funcName, "vkCmdSetStencilReference")) |
| 5643 | return (PFN_vkVoidFunction) vkCmdSetStencilReference; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5644 | if (!strcmp(funcName, "vkCmdBindDescriptorSets")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5645 | return (PFN_vkVoidFunction) vkCmdBindDescriptorSets; |
Courtney Goeltzenleuchter | 4696294 | 2015-04-16 13:38:46 -0600 | [diff] [blame] | 5646 | if (!strcmp(funcName, "vkCmdBindVertexBuffers")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5647 | return (PFN_vkVoidFunction) vkCmdBindVertexBuffers; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5648 | if (!strcmp(funcName, "vkCmdBindIndexBuffer")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5649 | return (PFN_vkVoidFunction) vkCmdBindIndexBuffer; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5650 | if (!strcmp(funcName, "vkCmdDraw")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5651 | return (PFN_vkVoidFunction) vkCmdDraw; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5652 | if (!strcmp(funcName, "vkCmdDrawIndexed")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5653 | return (PFN_vkVoidFunction) vkCmdDrawIndexed; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5654 | if (!strcmp(funcName, "vkCmdDrawIndirect")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5655 | return (PFN_vkVoidFunction) vkCmdDrawIndirect; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5656 | if (!strcmp(funcName, "vkCmdDrawIndexedIndirect")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5657 | return (PFN_vkVoidFunction) vkCmdDrawIndexedIndirect; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5658 | if (!strcmp(funcName, "vkCmdDispatch")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5659 | return (PFN_vkVoidFunction) vkCmdDispatch; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5660 | if (!strcmp(funcName, "vkCmdDispatchIndirect")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5661 | return (PFN_vkVoidFunction) vkCmdDispatchIndirect; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5662 | if (!strcmp(funcName, "vkCmdCopyBuffer")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5663 | return (PFN_vkVoidFunction) vkCmdCopyBuffer; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5664 | if (!strcmp(funcName, "vkCmdCopyImage")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5665 | return (PFN_vkVoidFunction) vkCmdCopyImage; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5666 | if (!strcmp(funcName, "vkCmdCopyBufferToImage")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5667 | return (PFN_vkVoidFunction) vkCmdCopyBufferToImage; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5668 | if (!strcmp(funcName, "vkCmdCopyImageToBuffer")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5669 | return (PFN_vkVoidFunction) vkCmdCopyImageToBuffer; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5670 | if (!strcmp(funcName, "vkCmdUpdateBuffer")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5671 | return (PFN_vkVoidFunction) vkCmdUpdateBuffer; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5672 | if (!strcmp(funcName, "vkCmdFillBuffer")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5673 | return (PFN_vkVoidFunction) vkCmdFillBuffer; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5674 | if (!strcmp(funcName, "vkCmdClearColorImage")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5675 | return (PFN_vkVoidFunction) vkCmdClearColorImage; |
Chris Forbes | 2951d7d | 2015-06-22 17:21:59 +1200 | [diff] [blame] | 5676 | if (!strcmp(funcName, "vkCmdClearDepthStencilImage")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5677 | return (PFN_vkVoidFunction) vkCmdClearDepthStencilImage; |
Courtney Goeltzenleuchter | 9feb073 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 5678 | if (!strcmp(funcName, "vkCmdClearAttachments")) |
| 5679 | return (PFN_vkVoidFunction) vkCmdClearAttachments; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5680 | if (!strcmp(funcName, "vkCmdResolveImage")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5681 | return (PFN_vkVoidFunction) vkCmdResolveImage; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5682 | if (!strcmp(funcName, "vkCmdSetEvent")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5683 | return (PFN_vkVoidFunction) vkCmdSetEvent; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5684 | if (!strcmp(funcName, "vkCmdResetEvent")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5685 | return (PFN_vkVoidFunction) vkCmdResetEvent; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5686 | if (!strcmp(funcName, "vkCmdWaitEvents")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5687 | return (PFN_vkVoidFunction) vkCmdWaitEvents; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5688 | if (!strcmp(funcName, "vkCmdPipelineBarrier")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5689 | return (PFN_vkVoidFunction) vkCmdPipelineBarrier; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5690 | if (!strcmp(funcName, "vkCmdBeginQuery")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5691 | return (PFN_vkVoidFunction) vkCmdBeginQuery; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5692 | if (!strcmp(funcName, "vkCmdEndQuery")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5693 | return (PFN_vkVoidFunction) vkCmdEndQuery; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5694 | if (!strcmp(funcName, "vkCmdResetQueryPool")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5695 | return (PFN_vkVoidFunction) vkCmdResetQueryPool; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5696 | if (!strcmp(funcName, "vkCmdWriteTimestamp")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5697 | return (PFN_vkVoidFunction) vkCmdWriteTimestamp; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5698 | if (!strcmp(funcName, "vkCreateFramebuffer")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5699 | return (PFN_vkVoidFunction) vkCreateFramebuffer; |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 5700 | if (!strcmp(funcName, "vkCreateShaderModule")) |
| 5701 | return (PFN_vkVoidFunction) vkCreateShaderModule; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5702 | if (!strcmp(funcName, "vkCreateRenderPass")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5703 | return (PFN_vkVoidFunction) vkCreateRenderPass; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5704 | if (!strcmp(funcName, "vkCmdBeginRenderPass")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5705 | return (PFN_vkVoidFunction) vkCmdBeginRenderPass; |
Chia-I Wu | c278df8 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 5706 | if (!strcmp(funcName, "vkCmdNextSubpass")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5707 | return (PFN_vkVoidFunction) vkCmdNextSubpass; |
Courtney Goeltzenleuchter | 9cc421e | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 5708 | if (!strcmp(funcName, "vkCmdEndRenderPass")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5709 | return (PFN_vkVoidFunction) vkCmdEndRenderPass; |
Tobin Ehlis | 5f728d3 | 2015-09-17 14:18:16 -0600 | [diff] [blame] | 5710 | if (!strcmp(funcName, "vkCmdExecuteCommands")) |
| 5711 | return (PFN_vkVoidFunction) vkCmdExecuteCommands; |
Michael Lentine | ee4ad4d | 2015-10-23 12:41:44 -0700 | [diff] [blame] | 5712 | if (!strcmp(funcName, "vkMapMemory")) |
| 5713 | return (PFN_vkVoidFunction) vkMapMemory; |
Jon Ashburn | 6f8cd63 | 2015-06-01 09:37:38 -0600 | [diff] [blame] | 5714 | |
Michael Lentine | 27b0f90 | 2015-10-12 11:30:14 -0500 | [diff] [blame] | 5715 | if (dev_data->device_extensions.wsi_enabled) |
| 5716 | { |
| 5717 | if (!strcmp(funcName, "vkCreateSwapchainKHR")) |
| 5718 | return (PFN_vkVoidFunction) vkCreateSwapchainKHR; |
| 5719 | if (!strcmp(funcName, "vkDestroySwapchainKHR")) |
| 5720 | return (PFN_vkVoidFunction) vkDestroySwapchainKHR; |
| 5721 | if (!strcmp(funcName, "vkGetSwapchainImagesKHR")) |
| 5722 | return (PFN_vkVoidFunction) vkGetSwapchainImagesKHR; |
| 5723 | if (!strcmp(funcName, "vkQueuePresentKHR")) |
| 5724 | return (PFN_vkVoidFunction) vkQueuePresentKHR; |
| 5725 | } |
| 5726 | |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 5727 | VkLayerDispatchTable* pTable = dev_data->device_dispatch_table; |
| 5728 | if (dev_data->device_extensions.debug_marker_enabled) |
Jon Ashburn | 4f2575f | 2015-05-28 16:25:02 -0600 | [diff] [blame] | 5729 | { |
Jon Ashburn | 7e07faf | 2015-06-18 15:02:58 -0600 | [diff] [blame] | 5730 | if (!strcmp(funcName, "vkCmdDbgMarkerBegin")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5731 | return (PFN_vkVoidFunction) vkCmdDbgMarkerBegin; |
Jon Ashburn | 7e07faf | 2015-06-18 15:02:58 -0600 | [diff] [blame] | 5732 | if (!strcmp(funcName, "vkCmdDbgMarkerEnd")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5733 | return (PFN_vkVoidFunction) vkCmdDbgMarkerEnd; |
Jon Ashburn | 6f8cd63 | 2015-06-01 09:37:38 -0600 | [diff] [blame] | 5734 | } |
| 5735 | { |
Jon Ashburn | 4f2575f | 2015-05-28 16:25:02 -0600 | [diff] [blame] | 5736 | if (pTable->GetDeviceProcAddr == NULL) |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5737 | return NULL; |
Jon Ashburn | 4f2575f | 2015-05-28 16:25:02 -0600 | [diff] [blame] | 5738 | return pTable->GetDeviceProcAddr(dev, funcName); |
Jon Ashburn | 79b78ac | 2015-05-05 14:22:52 -0600 | [diff] [blame] | 5739 | } |
| 5740 | } |
| 5741 | |
Chia-I Wu | af9e4fd | 2015-11-06 06:42:02 +0800 | [diff] [blame] | 5742 | VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char* funcName) |
Jon Ashburn | 79b78ac | 2015-05-05 14:22:52 -0600 | [diff] [blame] | 5743 | { |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5744 | PFN_vkVoidFunction fptr; |
Jon Ashburn | 79b78ac | 2015-05-05 14:22:52 -0600 | [diff] [blame] | 5745 | if (instance == NULL) |
| 5746 | return NULL; |
| 5747 | |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 5748 | layer_data* my_data; |
Jon Ashburn | 4f2575f | 2015-05-28 16:25:02 -0600 | [diff] [blame] | 5749 | /* loader uses this to force layer initialization; instance object is wrapped */ |
| 5750 | if (!strcmp(funcName, "vkGetInstanceProcAddr")) { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 5751 | VkBaseLayerObject* wrapped_inst = (VkBaseLayerObject*) instance; |
| 5752 | my_data = get_my_data_ptr(get_dispatch_key(wrapped_inst->baseObject), layer_data_map); |
Tobin Ehlis | d04ccab | 2015-10-07 15:40:22 -0600 | [diff] [blame] | 5753 | my_data->instance_dispatch_table = new VkLayerInstanceDispatchTable; |
| 5754 | layer_init_instance_dispatch_table(my_data->instance_dispatch_table, wrapped_inst); |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5755 | return (PFN_vkVoidFunction) vkGetInstanceProcAddr; |
Jon Ashburn | 4f2575f | 2015-05-28 16:25:02 -0600 | [diff] [blame] | 5756 | } |
Courtney Goeltzenleuchter | 3c9f6ec | 2015-06-01 14:29:58 -0600 | [diff] [blame] | 5757 | if (!strcmp(funcName, "vkCreateInstance")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5758 | return (PFN_vkVoidFunction) vkCreateInstance; |
Jon Ashburn | e0fa228 | 2015-05-20 09:00:28 -0600 | [diff] [blame] | 5759 | if (!strcmp(funcName, "vkDestroyInstance")) |
Courtney Goeltzenleuchter | a4c8c71 | 2015-07-12 14:35:22 -0600 | [diff] [blame] | 5760 | return (PFN_vkVoidFunction) vkDestroyInstance; |
Courtney Goeltzenleuchter | 74c4ce9 | 2015-09-14 17:22:16 -0600 | [diff] [blame] | 5761 | if (!strcmp(funcName, "vkEnumerateInstanceLayerProperties")) |
| 5762 | return (PFN_vkVoidFunction) vkEnumerateInstanceLayerProperties; |
| 5763 | if (!strcmp(funcName, "vkEnumerateInstanceExtensionProperties")) |
| 5764 | return (PFN_vkVoidFunction) vkEnumerateInstanceExtensionProperties; |
| 5765 | if (!strcmp(funcName, "vkEnumerateDeviceLayerProperties")) |
| 5766 | return (PFN_vkVoidFunction) vkEnumerateDeviceLayerProperties; |
| 5767 | if (!strcmp(funcName, "vkEnumerateDeviceExtensionProperties")) |
| 5768 | return (PFN_vkVoidFunction) vkEnumerateDeviceExtensionProperties; |
Courtney Goeltzenleuchter | cc899fe | 2015-06-01 14:33:14 -0600 | [diff] [blame] | 5769 | |
Tobin Ehlis | 3247935 | 2015-12-01 09:48:58 -0700 | [diff] [blame] | 5770 | my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); |
Tobin Ehlis | fde4dce | 2015-06-16 15:50:44 -0600 | [diff] [blame] | 5771 | fptr = debug_report_get_instance_proc_addr(my_data->report_data, funcName); |
Courtney Goeltzenleuchter | cc899fe | 2015-06-01 14:33:14 -0600 | [diff] [blame] | 5772 | if (fptr) |
| 5773 | return fptr; |
| 5774 | |
Jon Ashburn | 4f2575f | 2015-05-28 16:25:02 -0600 | [diff] [blame] | 5775 | { |
Tobin Ehlis | e6ab55a | 2015-10-07 09:38:40 -0600 | [diff] [blame] | 5776 | VkLayerInstanceDispatchTable* pTable = my_data->instance_dispatch_table; |
Jon Ashburn | 4f2575f | 2015-05-28 16:25:02 -0600 | [diff] [blame] | 5777 | if (pTable->GetInstanceProcAddr == NULL) |
Jon Ashburn | 79b78ac | 2015-05-05 14:22:52 -0600 | [diff] [blame] | 5778 | return NULL; |
Jon Ashburn | 4f2575f | 2015-05-28 16:25:02 -0600 | [diff] [blame] | 5779 | return pTable->GetInstanceProcAddr(instance, funcName); |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5780 | } |
Tobin Ehlis | 63bb948 | 2015-03-17 16:24:32 -0600 | [diff] [blame] | 5781 | } |