Mark Lobodzinski | 6eda00a | 2016-02-02 15:55:36 -0700 | [diff] [blame] | 1 | /* Copyright (c) 2015-2016 The Khronos Group Inc. |
| 2 | * Copyright (c) 2015-2016 Valve Corporation |
| 3 | * Copyright (c) 2015-2016 LunarG, Inc. |
| 4 | * Copyright (C) 2015-2016 Google Inc. |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 5 | * |
Jon Ashburn | 3ebf125 | 2016-04-19 11:30:31 -0600 | [diff] [blame] | 6 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 7 | * you may not use this file except in compliance with the License. |
| 8 | * You may obtain a copy of the License at |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 9 | * |
Jon Ashburn | 3ebf125 | 2016-04-19 11:30:31 -0600 | [diff] [blame] | 10 | * http://www.apache.org/licenses/LICENSE-2.0 |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 11 | * |
Jon Ashburn | 3ebf125 | 2016-04-19 11:30:31 -0600 | [diff] [blame] | 12 | * Unless required by applicable law or agreed to in writing, software |
| 13 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 14 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 15 | * See the License for the specific language governing permissions and |
| 16 | * limitations under the License. |
Courtney Goeltzenleuchter | 0555952 | 2015-10-30 11:14:30 -0600 | [diff] [blame] | 17 | * |
| 18 | * Author: Jeremy Hayes <jeremy@lunarg.com> |
| 19 | * Author: Mark Lobodzinski <mark@lunarg.com> |
| 20 | * Author: Mike Stroyan <mike@LunarG.com> |
| 21 | * Author: Tobin Ehlis <tobin@lunarg.com> |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 22 | */ |
| 23 | |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 24 | // Allow use of STL min and max functions in Windows |
| 25 | #define NOMINMAX |
| 26 | |
Jeremy Hayes | e0ed6a2 | 2016-04-08 09:53:54 -0600 | [diff] [blame] | 27 | #include <algorithm> |
| 28 | #include <assert.h> |
Karl Schultz | d7f3754 | 2016-05-10 11:36:08 -0600 | [diff] [blame] | 29 | #include <cinttypes> |
Jeremy Hayes | e0ed6a2 | 2016-04-08 09:53:54 -0600 | [diff] [blame] | 30 | #include <memory> |
| 31 | #include <mutex> |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 32 | #include <stdio.h> |
| 33 | #include <stdlib.h> |
| 34 | #include <string.h> |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 35 | #include <unordered_map> |
Jeremy Hayes | e0ed6a2 | 2016-04-08 09:53:54 -0600 | [diff] [blame] | 36 | #include <vector> |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 37 | |
Tobin Ehlis | b835d1b | 2015-07-03 10:34:49 -0600 | [diff] [blame] | 38 | #include "vk_loader_platform.h" |
Courtney Goeltzenleuchter | 8f8367e | 2015-10-07 08:38:30 -0600 | [diff] [blame] | 39 | #include "vk_dispatch_table_helper.h" |
| 40 | #include "vk_struct_string_helper_cpp.h" |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 41 | #include "vk_enum_validate_helper.h" |
Courtney Goeltzenleuchter | 8f8367e | 2015-10-07 08:38:30 -0600 | [diff] [blame] | 42 | #include "image.h" |
| 43 | #include "vk_layer_config.h" |
| 44 | #include "vk_layer_extension_utils.h" |
Tobin Ehlis | a0cb02e | 2015-07-03 10:15:26 -0600 | [diff] [blame] | 45 | #include "vk_layer_table.h" |
| 46 | #include "vk_layer_data.h" |
Courtney Goeltzenleuchter | 426e187 | 2015-07-07 11:18:30 -0600 | [diff] [blame] | 47 | #include "vk_layer_extension_utils.h" |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 48 | #include "vk_layer_utils.h" |
Courtney Goeltzenleuchter | 8f8367e | 2015-10-07 08:38:30 -0600 | [diff] [blame] | 49 | #include "vk_layer_logging.h" |
Mark Lobodzinski | 69b52fe | 2016-10-14 11:43:06 -0600 | [diff] [blame] | 50 | #include "vk_validation_error_messages.h" |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 51 | |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 52 | using namespace std; |
| 53 | |
Chia-I Wu | aacb0fc | 2016-04-28 11:27:46 +0800 | [diff] [blame] | 54 | namespace image { |
| 55 | |
Cody Northrop | 55443ef | 2015-09-28 15:09:32 -0600 | [diff] [blame] | 56 | struct layer_data { |
Chia-I Wu | 2cfc77c | 2016-04-28 16:04:15 +0800 | [diff] [blame] | 57 | VkInstance instance; |
| 58 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 59 | debug_report_data *report_data; |
| 60 | vector<VkDebugReportCallbackEXT> logging_callback; |
| 61 | VkLayerDispatchTable *device_dispatch_table; |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 62 | VkLayerInstanceDispatchTable *instance_dispatch_table; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 63 | VkPhysicalDevice physicalDevice; |
| 64 | VkPhysicalDeviceProperties physicalDeviceProperties; |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 65 | |
Chia-I Wu | e2fc552 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 66 | unordered_map<VkImage, IMAGE_STATE> imageMap; |
Cody Northrop | 55443ef | 2015-09-28 15:09:32 -0600 | [diff] [blame] | 67 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 68 | layer_data() |
| 69 | : report_data(nullptr), device_dispatch_table(nullptr), instance_dispatch_table(nullptr), physicalDevice(0), |
| 70 | physicalDeviceProperties(){}; |
Cody Northrop | 55443ef | 2015-09-28 15:09:32 -0600 | [diff] [blame] | 71 | }; |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 72 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 73 | static unordered_map<void *, layer_data *> layer_data_map; |
Jeremy Hayes | e0ed6a2 | 2016-04-08 09:53:54 -0600 | [diff] [blame] | 74 | static std::mutex global_lock; |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 75 | |
Mark Lobodzinski | 1079e1b | 2016-03-15 14:21:59 -0600 | [diff] [blame] | 76 | static void init_image(layer_data *my_data, const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | 1079e1b | 2016-03-15 14:21:59 -0600 | [diff] [blame] | 77 | layer_debug_actions(my_data->report_data, my_data->logging_callback, pAllocator, "lunarg_image"); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 78 | } |
| 79 | |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 80 | static IMAGE_STATE const *getImageState(layer_data const *dev_data, VkImage image) { |
| 81 | auto it = dev_data->imageMap.find(image); |
| 82 | if (it == dev_data->imageMap.end()) { |
| 83 | return nullptr; |
| 84 | } |
| 85 | return &it->second; |
| 86 | } |
| 87 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 88 | VKAPI_ATTR VkResult VKAPI_CALL |
| 89 | CreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, |
| 90 | const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 91 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); |
| 92 | VkResult res = my_data->instance_dispatch_table->CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 93 | if (res == VK_SUCCESS) { |
Mark Lobodzinski | 97c4d51 | 2016-05-19 15:27:18 -0600 | [diff] [blame] | 94 | res = layer_create_msg_callback(my_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 95 | } |
| 96 | return res; |
| 97 | } |
| 98 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 99 | VKAPI_ATTR void VKAPI_CALL DestroyDebugReportCallbackEXT(VkInstance instance, |
| 100 | VkDebugReportCallbackEXT msgCallback, |
| 101 | const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 102 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); |
| 103 | my_data->instance_dispatch_table->DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); |
Courtney Goeltzenleuchter | 05854bf | 2015-11-30 12:13:14 -0700 | [diff] [blame] | 104 | layer_destroy_msg_callback(my_data->report_data, msgCallback, pAllocator); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 105 | } |
| 106 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 107 | VKAPI_ATTR void VKAPI_CALL |
| 108 | DebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, |
| 109 | size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 110 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 111 | my_data->instance_dispatch_table->DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, |
| 112 | pMsg); |
Courtney Goeltzenleuchter | f0de724 | 2015-12-01 14:10:55 -0700 | [diff] [blame] | 113 | } |
| 114 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 115 | VKAPI_ATTR VkResult VKAPI_CALL |
| 116 | CreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 117 | VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 118 | |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 119 | assert(chain_info->u.pLayerInfo); |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 120 | PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 121 | PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 122 | if (fpCreateInstance == NULL) { |
| 123 | return VK_ERROR_INITIALIZATION_FAILED; |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 124 | } |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 125 | |
| 126 | // Advance the link info for the next element on the chain |
| 127 | chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; |
| 128 | |
| 129 | VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); |
| 130 | if (result != VK_SUCCESS) |
| 131 | return result; |
| 132 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 133 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map); |
Chia-I Wu | 2cfc77c | 2016-04-28 16:04:15 +0800 | [diff] [blame] | 134 | my_data->instance = *pInstance; |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 135 | my_data->instance_dispatch_table = new VkLayerInstanceDispatchTable; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 136 | layer_init_instance_dispatch_table(*pInstance, my_data->instance_dispatch_table, fpGetInstanceProcAddr); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 137 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 138 | my_data->report_data = debug_report_create_instance(my_data->instance_dispatch_table, *pInstance, |
| 139 | pCreateInfo->enabledExtensionCount, pCreateInfo->ppEnabledExtensionNames); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 140 | |
Mark Lobodzinski | 1079e1b | 2016-03-15 14:21:59 -0600 | [diff] [blame] | 141 | init_image(my_data, pAllocator); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 142 | |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 143 | return result; |
| 144 | } |
| 145 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 146 | VKAPI_ATTR void VKAPI_CALL DestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 147 | // Grab the key before the instance is destroyed. |
| 148 | dispatch_key key = get_dispatch_key(instance); |
Tobin Ehlis | b74f6ab | 2015-10-29 14:19:18 -0600 | [diff] [blame] | 149 | layer_data *my_data = get_my_data_ptr(key, layer_data_map); |
| 150 | VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; |
Chia-I Wu | f7458c5 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 151 | pTable->DestroyInstance(instance, pAllocator); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 152 | |
| 153 | // Clean up logging callback, if any |
Courtney Goeltzenleuchter | ffcdd8b | 2015-10-05 15:59:11 -0600 | [diff] [blame] | 154 | while (my_data->logging_callback.size() > 0) { |
Courtney Goeltzenleuchter | 7415d5a | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 155 | VkDebugReportCallbackEXT callback = my_data->logging_callback.back(); |
Courtney Goeltzenleuchter | 05854bf | 2015-11-30 12:13:14 -0700 | [diff] [blame] | 156 | layer_destroy_msg_callback(my_data->report_data, callback, pAllocator); |
Courtney Goeltzenleuchter | ffcdd8b | 2015-10-05 15:59:11 -0600 | [diff] [blame] | 157 | my_data->logging_callback.pop_back(); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 158 | } |
| 159 | |
Tobin Ehlis | b74f6ab | 2015-10-29 14:19:18 -0600 | [diff] [blame] | 160 | layer_debug_report_destroy_instance(my_data->report_data); |
| 161 | delete my_data->instance_dispatch_table; |
| 162 | layer_data_map.erase(key); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 163 | } |
| 164 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 165 | VKAPI_ATTR VkResult VKAPI_CALL CreateDevice(VkPhysicalDevice physicalDevice, |
| 166 | const VkDeviceCreateInfo *pCreateInfo, |
| 167 | const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { |
Chia-I Wu | 2cfc77c | 2016-04-28 16:04:15 +0800 | [diff] [blame] | 168 | layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(physicalDevice), layer_data_map); |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 169 | VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 170 | |
| 171 | assert(chain_info->u.pLayerInfo); |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 172 | PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; |
| 173 | PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; |
Chia-I Wu | 2cfc77c | 2016-04-28 16:04:15 +0800 | [diff] [blame] | 174 | PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice"); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 175 | if (fpCreateDevice == NULL) { |
| 176 | return VK_ERROR_INITIALIZATION_FAILED; |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 177 | } |
| 178 | |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 179 | // Advance the link info for the next element on the chain |
| 180 | chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; |
| 181 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 182 | VkResult result = fpCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 183 | if (result != VK_SUCCESS) { |
| 184 | return result; |
| 185 | } |
| 186 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 187 | layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 188 | |
| 189 | // Setup device dispatch table |
| 190 | my_device_data->device_dispatch_table = new VkLayerDispatchTable; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 191 | layer_init_device_dispatch_table(*pDevice, my_device_data->device_dispatch_table, fpGetDeviceProcAddr); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 192 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 193 | my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 194 | my_device_data->physicalDevice = physicalDevice; |
| 195 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 196 | my_instance_data->instance_dispatch_table->GetPhysicalDeviceProperties(physicalDevice, |
| 197 | &(my_device_data->physicalDeviceProperties)); |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 198 | |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 199 | return result; |
| 200 | } |
| 201 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 202 | VKAPI_ATTR void VKAPI_CALL DestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 203 | dispatch_key key = get_dispatch_key(device); |
Tobin Ehlis | b74f6ab | 2015-10-29 14:19:18 -0600 | [diff] [blame] | 204 | layer_data *my_data = get_my_data_ptr(key, layer_data_map); |
Chia-I Wu | f7458c5 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 205 | my_data->device_dispatch_table->DestroyDevice(device, pAllocator); |
Tobin Ehlis | b74f6ab | 2015-10-29 14:19:18 -0600 | [diff] [blame] | 206 | delete my_data->device_dispatch_table; |
| 207 | layer_data_map.erase(key); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 208 | } |
| 209 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 210 | static const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 211 | |
Chia-I Wu | 740891e | 2016-04-28 14:12:27 +0800 | [diff] [blame] | 212 | static const VkLayerProperties global_layer = { |
Jon Ashburn | dc9111c | 2016-03-22 12:57:13 -0600 | [diff] [blame] | 213 | "VK_LAYER_LUNARG_image", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", |
Chia-I Wu | 740891e | 2016-04-28 14:12:27 +0800 | [diff] [blame] | 214 | }; |
Courtney Goeltzenleuchter | 5285766 | 2015-12-01 14:08:28 -0700 | [diff] [blame] | 215 | |
Mark Lobodzinski | 2fd634c | 2015-07-29 09:21:22 -0600 | [diff] [blame] | 216 | // Start of the Image layer proper |
| 217 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 218 | static inline uint32_t validate_VkImageLayoutKHR(VkImageLayout input_value) { |
| 219 | return ((validate_VkImageLayout(input_value) == 1) || (input_value == VK_IMAGE_LAYOUT_PRESENT_SRC_KHR)); |
Mark Lobodzinski | 601ed15 | 2015-11-10 11:01:32 -0700 | [diff] [blame] | 220 | } |
| 221 | |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 222 | VKAPI_ATTR VkResult VKAPI_CALL CreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, |
| 223 | const VkAllocationCallbacks *pAllocator, VkImage *pImage) { |
| 224 | bool skip_call = false; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 225 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
Michael Lentine | 0a369f6 | 2016-02-03 16:51:46 -0600 | [diff] [blame] | 226 | VkImageFormatProperties ImageFormatProperties; |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 227 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 228 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 229 | VkPhysicalDevice physicalDevice = device_data->physicalDevice; |
| 230 | layer_data *phy_dev_data = get_my_data_ptr(get_dispatch_key(physicalDevice), layer_data_map); |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 231 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 232 | if (pCreateInfo->format != VK_FORMAT_UNDEFINED) { |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 233 | VkFormatProperties properties; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 234 | phy_dev_data->instance_dispatch_table->GetPhysicalDeviceFormatProperties(device_data->physicalDevice, pCreateInfo->format, |
| 235 | &properties); |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 236 | if ((properties.linearTilingFeatures) == 0 && (properties.optimalTilingFeatures == 0)) { |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 237 | std::stringstream ss; |
| 238 | ss << "vkCreateImage format parameter (" << string_VkFormat(pCreateInfo->format) << ") is an unsupported format"; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 239 | // TODO: Verify against Valid Use section of spec. Generally if something yield an undefined result, it's invalid |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 240 | skip_call |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, |
| 241 | 0, __LINE__, IMAGE_FORMAT_UNSUPPORTED, "IMAGE", "%s", ss.str().c_str()); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 242 | } |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 243 | |
| 244 | // Validate that format supports usage as color attachment |
| 245 | if (pCreateInfo->usage & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT) { |
| 246 | if ((pCreateInfo->tiling == VK_IMAGE_TILING_OPTIMAL) && |
| 247 | ((properties.optimalTilingFeatures & VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT) == 0)) { |
| 248 | std::stringstream ss; |
| 249 | ss << "vkCreateImage: VkFormat for TILING_OPTIMAL image (" << string_VkFormat(pCreateInfo->format) |
| 250 | << ") does not support requested Image usage type VK_IMAGE_USAGE_COLOR_ATTACHMENT"; |
| 251 | skip_call |= |
| 252 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 253 | __LINE__, IMAGE_INVALID_FORMAT, "IMAGE", "%s", ss.str().c_str()); |
| 254 | } |
| 255 | if ((pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR) && |
| 256 | ((properties.linearTilingFeatures & VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT) == 0)) { |
| 257 | std::stringstream ss; |
| 258 | ss << "vkCreateImage: VkFormat for TILING_LINEAR image (" << string_VkFormat(pCreateInfo->format) |
| 259 | << ") does not support requested Image usage type VK_IMAGE_USAGE_COLOR_ATTACHMENT"; |
| 260 | skip_call |= |
| 261 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 262 | __LINE__, IMAGE_INVALID_FORMAT, "IMAGE", "%s", ss.str().c_str()); |
| 263 | } |
| 264 | } |
| 265 | // Validate that format supports usage as depth/stencil attachment |
| 266 | if (pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) { |
| 267 | if ((pCreateInfo->tiling == VK_IMAGE_TILING_OPTIMAL) && |
| 268 | ((properties.optimalTilingFeatures & VK_FORMAT_FEATURE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0)) { |
| 269 | std::stringstream ss; |
| 270 | ss << "vkCreateImage: VkFormat for TILING_OPTIMAL image (" << string_VkFormat(pCreateInfo->format) |
| 271 | << ") does not support requested Image usage type VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT"; |
| 272 | skip_call |= |
| 273 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 274 | __LINE__, IMAGE_INVALID_FORMAT, "IMAGE", "%s", ss.str().c_str()); |
| 275 | } |
| 276 | if ((pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR) && |
| 277 | ((properties.linearTilingFeatures & VK_FORMAT_FEATURE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0)) { |
| 278 | std::stringstream ss; |
| 279 | ss << "vkCreateImage: VkFormat for TILING_LINEAR image (" << string_VkFormat(pCreateInfo->format) |
| 280 | << ") does not support requested Image usage type VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT"; |
| 281 | skip_call |= |
| 282 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 283 | __LINE__, IMAGE_INVALID_FORMAT, "IMAGE", "%s", ss.str().c_str()); |
| 284 | } |
| 285 | } |
| 286 | } else { |
| 287 | skip_call |= |
| 288 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| 289 | IMAGE_INVALID_FORMAT, "IMAGE", "vkCreateImage: VkFormat for image must not be VK_FORMAT_UNDEFINED"); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 290 | } |
| 291 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 292 | // Internal call to get format info. Still goes through layers, could potentially go directly to ICD. |
| 293 | phy_dev_data->instance_dispatch_table->GetPhysicalDeviceImageFormatProperties( |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 294 | physicalDevice, pCreateInfo->format, pCreateInfo->imageType, pCreateInfo->tiling, pCreateInfo->usage, pCreateInfo->flags, |
| 295 | &ImageFormatProperties); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 296 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 297 | VkDeviceSize imageGranularity = device_data->physicalDeviceProperties.limits.bufferImageGranularity; |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 298 | imageGranularity = imageGranularity == 1 ? 0 : imageGranularity; |
| 299 | |
Mark Young | c48c4c1 | 2016-04-11 14:26:49 -0600 | [diff] [blame] | 300 | // Make sure all required dimension are non-zero at least. |
| 301 | bool failedMinSize = false; |
| 302 | switch (pCreateInfo->imageType) { |
| 303 | case VK_IMAGE_TYPE_3D: |
| 304 | if (pCreateInfo->extent.depth == 0) { |
| 305 | failedMinSize = true; |
| 306 | } |
| 307 | // Intentional fall-through |
| 308 | case VK_IMAGE_TYPE_2D: |
| 309 | if (pCreateInfo->extent.height == 0) { |
| 310 | failedMinSize = true; |
| 311 | } |
| 312 | // Intentional fall-through |
| 313 | case VK_IMAGE_TYPE_1D: |
| 314 | if (pCreateInfo->extent.width == 0) { |
| 315 | failedMinSize = true; |
| 316 | } |
| 317 | break; |
| 318 | default: |
| 319 | break; |
| 320 | } |
| 321 | if (failedMinSize) { |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 322 | skip_call |= |
Mark Young | c48c4c1 | 2016-04-11 14:26:49 -0600 | [diff] [blame] | 323 | log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 324 | 0, __LINE__, IMAGE_INVALID_FORMAT_LIMITS_VIOLATION, "Image", |
Mark Young | c48c4c1 | 2016-04-11 14:26:49 -0600 | [diff] [blame] | 325 | "CreateImage extents is 0 for at least one required dimension for image of type %d: " |
| 326 | "Width = %d Height = %d Depth = %d.", |
| 327 | pCreateInfo->imageType, pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth); |
| 328 | } |
| 329 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 330 | if ((pCreateInfo->extent.depth > ImageFormatProperties.maxExtent.depth) || |
| 331 | (pCreateInfo->extent.width > ImageFormatProperties.maxExtent.width) || |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 332 | (pCreateInfo->extent.height > ImageFormatProperties.maxExtent.height)) { |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 333 | skip_call |= log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 334 | 0, __LINE__, IMAGE_INVALID_FORMAT_LIMITS_VIOLATION, "Image", |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 335 | "CreateImage extents exceed allowable limits for format: " |
| 336 | "Width = %d Height = %d Depth = %d: Limits for Width = %d Height = %d Depth = %d for format %s.", |
| 337 | pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth, |
| 338 | ImageFormatProperties.maxExtent.width, ImageFormatProperties.maxExtent.height, |
| 339 | ImageFormatProperties.maxExtent.depth, string_VkFormat(pCreateInfo->format)); |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 340 | } |
| 341 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 342 | uint64_t totalSize = ((uint64_t)pCreateInfo->extent.width * (uint64_t)pCreateInfo->extent.height * |
| 343 | (uint64_t)pCreateInfo->extent.depth * (uint64_t)pCreateInfo->arrayLayers * |
| 344 | (uint64_t)pCreateInfo->samples * (uint64_t)vk_format_get_size(pCreateInfo->format) + |
| 345 | (uint64_t)imageGranularity) & |
| 346 | ~(uint64_t)imageGranularity; |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 347 | |
| 348 | if (totalSize > ImageFormatProperties.maxResourceSize) { |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 349 | skip_call |= log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 350 | 0, __LINE__, IMAGE_INVALID_FORMAT_LIMITS_VIOLATION, "Image", |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 351 | "CreateImage resource size exceeds allowable maximum " |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 352 | "Image resource size = 0x%" PRIxLEAST64 ", maximum resource size = 0x%" PRIxLEAST64 " ", |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 353 | totalSize, ImageFormatProperties.maxResourceSize); |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 354 | } |
| 355 | |
| 356 | if (pCreateInfo->mipLevels > ImageFormatProperties.maxMipLevels) { |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 357 | skip_call |= log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 358 | 0, __LINE__, IMAGE_INVALID_FORMAT_LIMITS_VIOLATION, "Image", |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 359 | "CreateImage mipLevels=%d exceeds allowable maximum supported by format of %d", pCreateInfo->mipLevels, |
| 360 | ImageFormatProperties.maxMipLevels); |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 361 | } |
| 362 | |
| 363 | if (pCreateInfo->arrayLayers > ImageFormatProperties.maxArrayLayers) { |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 364 | skip_call |= log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 365 | 0, __LINE__, IMAGE_INVALID_FORMAT_LIMITS_VIOLATION, "Image", |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 366 | "CreateImage arrayLayers=%d exceeds allowable maximum supported by format of %d", |
| 367 | pCreateInfo->arrayLayers, ImageFormatProperties.maxArrayLayers); |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 368 | } |
| 369 | |
| 370 | if ((pCreateInfo->samples & ImageFormatProperties.sampleCounts) == 0) { |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 371 | skip_call |= log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 372 | 0, __LINE__, IMAGE_INVALID_FORMAT_LIMITS_VIOLATION, "Image", |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 373 | "CreateImage samples %s is not supported by format 0x%.8X", |
| 374 | string_VkSampleCountFlagBits(pCreateInfo->samples), ImageFormatProperties.sampleCounts); |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 375 | } |
| 376 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 377 | if (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED && pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED) { |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 378 | skip_call |= log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 379 | 0, __LINE__, IMAGE_INVALID_LAYOUT, "Image", |
Jeremy Hayes | ffc8a70 | 2016-03-01 14:01:45 -0700 | [diff] [blame] | 380 | "vkCreateImage parameter, pCreateInfo->initialLayout, must be VK_IMAGE_LAYOUT_UNDEFINED or " |
| 381 | "VK_IMAGE_LAYOUT_PREINITIALIZED"); |
| 382 | } |
| 383 | |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 384 | if (!skip_call) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 385 | result = device_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage); |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 386 | } |
| 387 | if (result == VK_SUCCESS) { |
Jeremy Hayes | e0ed6a2 | 2016-04-08 09:53:54 -0600 | [diff] [blame] | 388 | std::lock_guard<std::mutex> lock(global_lock); |
Chia-I Wu | e2fc552 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 389 | device_data->imageMap[*pImage] = IMAGE_STATE(pCreateInfo); |
Tobin Ehlis | ad8c446 | 2015-09-21 15:20:28 -0600 | [diff] [blame] | 390 | } |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 391 | return result; |
| 392 | } |
| 393 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 394 | VKAPI_ATTR void VKAPI_CALL DestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 395 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Jeremy Hayes | e0ed6a2 | 2016-04-08 09:53:54 -0600 | [diff] [blame] | 396 | std::unique_lock<std::mutex> lock(global_lock); |
Chia-I Wu | e2fc552 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 397 | device_data->imageMap.erase(image); |
Jeremy Hayes | e0ed6a2 | 2016-04-08 09:53:54 -0600 | [diff] [blame] | 398 | lock.unlock(); |
Chia-I Wu | f7458c5 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 399 | device_data->device_dispatch_table->DestroyImage(device, image, pAllocator); |
Tobin Ehlis | ad8c446 | 2015-09-21 15:20:28 -0600 | [diff] [blame] | 400 | } |
| 401 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 402 | VKAPI_ATTR VkResult VKAPI_CALL CreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, |
Mark Lobodzinski | f2eabc8 | 2016-08-05 11:20:21 -0600 | [diff] [blame] | 403 | const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 404 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Mark Lobodzinski | f2eabc8 | 2016-08-05 11:20:21 -0600 | [diff] [blame] | 405 | bool skip_call = false; |
| 406 | bool depth_format_present = false; |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 407 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 408 | for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { |
Mark Lobodzinski | 27ced8b | 2016-08-05 11:30:15 -0600 | [diff] [blame] | 409 | if (pCreateInfo->pAttachments[i].format == VK_FORMAT_UNDEFINED) { |
| 410 | std::stringstream ss; |
| 411 | ss << "vkCreateRenderPass: pCreateInfo->pAttachments[" << i << "].format is VK_FORMAT_UNDEFINED"; |
| 412 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 413 | IMAGE_RENDERPASS_INVALID_ATTACHMENT, "IMAGE", "%s", ss.str().c_str()); |
| 414 | } |
| 415 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 416 | if (!validate_VkImageLayoutKHR(pCreateInfo->pAttachments[i].initialLayout) || |
| 417 | !validate_VkImageLayoutKHR(pCreateInfo->pAttachments[i].finalLayout)) { |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 418 | std::stringstream ss; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 419 | ss << "vkCreateRenderPass parameter, VkImageLayout in pCreateInfo->pAttachments[" << i << "], is unrecognized"; |
| 420 | // TODO: Verify against Valid Use section of spec. Generally if something yield an undefined result, it's invalid |
Mark Lobodzinski | f2eabc8 | 2016-08-05 11:20:21 -0600 | [diff] [blame] | 421 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 422 | IMAGE_RENDERPASS_INVALID_ATTACHMENT, "IMAGE", "%s", ss.str().c_str()); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 423 | } |
Mark Lobodzinski | 27ced8b | 2016-08-05 11:30:15 -0600 | [diff] [blame] | 424 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 425 | if (!validate_VkAttachmentLoadOp(pCreateInfo->pAttachments[i].loadOp)) { |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 426 | std::stringstream ss; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 427 | ss << "vkCreateRenderPass parameter, VkAttachmentLoadOp in pCreateInfo->pAttachments[" << i << "], is unrecognized"; |
| 428 | // TODO: Verify against Valid Use section of spec. Generally if something yield an undefined result, it's invalid |
Mark Lobodzinski | f2eabc8 | 2016-08-05 11:20:21 -0600 | [diff] [blame] | 429 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 430 | IMAGE_RENDERPASS_INVALID_ATTACHMENT, "IMAGE", "%s", ss.str().c_str()); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 431 | } |
Mark Lobodzinski | 27ced8b | 2016-08-05 11:30:15 -0600 | [diff] [blame] | 432 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 433 | if (!validate_VkAttachmentStoreOp(pCreateInfo->pAttachments[i].storeOp)) { |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 434 | std::stringstream ss; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 435 | ss << "vkCreateRenderPass parameter, VkAttachmentStoreOp in pCreateInfo->pAttachments[" << i << "], is unrecognized"; |
| 436 | // TODO: Verify against Valid Use section of spec. Generally if something yield an undefined result, it's invalid |
Mark Lobodzinski | f2eabc8 | 2016-08-05 11:20:21 -0600 | [diff] [blame] | 437 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 438 | IMAGE_RENDERPASS_INVALID_ATTACHMENT, "IMAGE", "%s", ss.str().c_str()); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 439 | } |
Mark Lobodzinski | 27ced8b | 2016-08-05 11:30:15 -0600 | [diff] [blame] | 440 | |
Mark Lobodzinski | f2eabc8 | 2016-08-05 11:20:21 -0600 | [diff] [blame] | 441 | // Any depth buffers specified as attachments? |
| 442 | depth_format_present |= vk_format_is_depth_or_stencil(pCreateInfo->pAttachments[i].format); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 443 | } |
| 444 | |
Mark Lobodzinski | f2eabc8 | 2016-08-05 11:20:21 -0600 | [diff] [blame] | 445 | if (!depth_format_present) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 446 | // No depth attachment is present, validate that subpasses set depthStencilAttachment to VK_ATTACHMENT_UNUSED; |
Mark Lobodzinski | 2fd634c | 2015-07-29 09:21:22 -0600 | [diff] [blame] | 447 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; i++) { |
Chia-I Wu | 1efb7e5 | 2015-10-26 17:32:47 +0800 | [diff] [blame] | 448 | if (pCreateInfo->pSubpasses[i].pDepthStencilAttachment && |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 449 | pCreateInfo->pSubpasses[i].pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
Mark Lobodzinski | 2fd634c | 2015-07-29 09:21:22 -0600 | [diff] [blame] | 450 | std::stringstream ss; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 451 | ss << "vkCreateRenderPass has no depth/stencil attachment, yet subpass[" << i |
| 452 | << "] has VkSubpassDescription::depthStencilAttachment value that is not VK_ATTACHMENT_UNUSED"; |
Mark Lobodzinski | f2eabc8 | 2016-08-05 11:20:21 -0600 | [diff] [blame] | 453 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 454 | __LINE__, IMAGE_RENDERPASS_INVALID_DS_ATTACHMENT, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | 2fd634c | 2015-07-29 09:21:22 -0600 | [diff] [blame] | 455 | } |
| 456 | } |
| 457 | } |
Mark Lobodzinski | f2eabc8 | 2016-08-05 11:20:21 -0600 | [diff] [blame] | 458 | if (skip_call) { |
Courtney Goeltzenleuchter | 52fee65 | 2015-12-10 16:41:22 -0700 | [diff] [blame] | 459 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Mark Lobodzinski | f2eabc8 | 2016-08-05 11:20:21 -0600 | [diff] [blame] | 460 | } |
Mark Lobodzinski | 2fd634c | 2015-07-29 09:21:22 -0600 | [diff] [blame] | 461 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 462 | VkResult result = my_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 463 | |
| 464 | return result; |
| 465 | } |
| 466 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 467 | VKAPI_ATTR void VKAPI_CALL CmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, |
| 468 | VkImageLayout imageLayout, const VkClearColorValue *pColor, |
| 469 | uint32_t rangeCount, const VkImageSubresourceRange *pRanges) { |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 470 | bool skipCall = false; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 471 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | a4dc0ac | 2016-03-01 16:51:02 -0700 | [diff] [blame] | 472 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 473 | if (imageLayout != VK_IMAGE_LAYOUT_GENERAL && imageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { |
Jeremy Hayes | a4dc0ac | 2016-03-01 16:51:02 -0700 | [diff] [blame] | 474 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 475 | (uint64_t)commandBuffer, __LINE__, IMAGE_INVALID_LAYOUT, "IMAGE", |
| 476 | "vkCmdClearColorImage parameter, imageLayout, must be VK_IMAGE_LAYOUT_GENERAL or " |
| 477 | "VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL"); |
| 478 | } |
| 479 | |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 480 | // For each range, image aspect must be color only |
| 481 | for (uint32_t i = 0; i < rangeCount; i++) { |
| 482 | if (pRanges[i].aspectMask != VK_IMAGE_ASPECT_COLOR_BIT) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 483 | char const str[] = |
| 484 | "vkCmdClearColorImage aspectMasks for all subresource ranges must be set to VK_IMAGE_ASPECT_COLOR_BIT"; |
| 485 | skipCall |= |
| 486 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 487 | (uint64_t)commandBuffer, __LINE__, IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", str); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 488 | } |
| 489 | } |
| 490 | |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 491 | auto image_state = getImageState(device_data, image); |
| 492 | if (image_state) { |
| 493 | if (vk_format_is_depth_or_stencil(image_state->format)) { |
| 494 | char const str[] = "vkCmdClearColorImage called with depth/stencil image."; |
| 495 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 496 | reinterpret_cast<uint64_t &>(image), __LINE__, IMAGE_INVALID_FORMAT, "IMAGE", str); |
| 497 | } else if (vk_format_is_compressed(image_state->format)) { |
| 498 | char const str[] = "vkCmdClearColorImage called with compressed image."; |
| 499 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 500 | reinterpret_cast<uint64_t &>(image), __LINE__, IMAGE_INVALID_FORMAT, "IMAGE", str); |
| 501 | } |
Tony Barbour | 26434b9 | 2016-06-02 09:43:50 -0600 | [diff] [blame] | 502 | |
| 503 | if (!(image_state->usage & VK_IMAGE_USAGE_TRANSFER_DST_BIT)) { |
| 504 | char const str[] = "vkCmdClearColorImage called with image created without VK_IMAGE_USAGE_TRANSFER_DST_BIT."; |
| 505 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 506 | reinterpret_cast<uint64_t &>(image), __LINE__, IMAGE_INVALID_USAGE, "IMAGE", str); |
| 507 | } |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 508 | } |
| 509 | |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 510 | if (!skipCall) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 511 | device_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 512 | } |
| 513 | } |
| 514 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 515 | VKAPI_ATTR void VKAPI_CALL |
| 516 | CmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, |
| 517 | const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, |
| 518 | const VkImageSubresourceRange *pRanges) { |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 519 | bool skipCall = false; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 520 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 521 | // For each range, Image aspect must be depth or stencil or both |
| 522 | for (uint32_t i = 0; i < rangeCount; i++) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 523 | if (((pRanges[i].aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) != VK_IMAGE_ASPECT_DEPTH_BIT) && |
| 524 | ((pRanges[i].aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT) != VK_IMAGE_ASPECT_STENCIL_BIT)) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 525 | char const str[] = "vkCmdClearDepthStencilImage aspectMasks for all subresource ranges must be " |
| 526 | "set to VK_IMAGE_ASPECT_DEPTH_BIT and/or VK_IMAGE_ASPECT_STENCIL_BIT"; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 527 | skipCall |= |
| 528 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 529 | (uint64_t)commandBuffer, __LINE__, IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", str); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 530 | } |
| 531 | } |
| 532 | |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 533 | auto image_state = getImageState(device_data, image); |
| 534 | if (image_state && !vk_format_is_depth_or_stencil(image_state->format)) { |
| 535 | char const str[] = "vkCmdClearDepthStencilImage called without a depth/stencil image."; |
| 536 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 537 | reinterpret_cast<uint64_t &>(image), __LINE__, IMAGE_INVALID_FORMAT, "IMAGE", str); |
| 538 | } |
| 539 | |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 540 | if (!skipCall) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 541 | device_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, |
| 542 | pRanges); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 543 | } |
| 544 | } |
| 545 | |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 546 | // Returns true if [x, xoffset] and [y, yoffset] overlap |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 547 | static bool RangesIntersect(int32_t start, uint32_t start_offset, int32_t end, uint32_t end_offset) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 548 | bool result = false; |
| 549 | uint32_t intersection_min = std::max(static_cast<uint32_t>(start), static_cast<uint32_t>(end)); |
| 550 | uint32_t intersection_max = std::min(static_cast<uint32_t>(start) + start_offset, static_cast<uint32_t>(end) + end_offset); |
| 551 | |
| 552 | if (intersection_max > intersection_min) { |
| 553 | result = true; |
| 554 | } |
| 555 | return result; |
| 556 | } |
| 557 | |
| 558 | // Returns true if two VkImageCopy structures overlap |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 559 | static bool RegionIntersects(const VkImageCopy *src, const VkImageCopy *dst, VkImageType type) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 560 | bool result = true; |
| 561 | if ((src->srcSubresource.mipLevel == dst->dstSubresource.mipLevel) && |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 562 | (RangesIntersect(src->srcSubresource.baseArrayLayer, src->srcSubresource.layerCount, dst->dstSubresource.baseArrayLayer, |
| 563 | dst->dstSubresource.layerCount))) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 564 | |
| 565 | switch (type) { |
| 566 | case VK_IMAGE_TYPE_3D: |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 567 | result &= RangesIntersect(src->srcOffset.z, src->extent.depth, dst->dstOffset.z, dst->extent.depth); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 568 | // Intentionally fall through to 2D case |
| 569 | case VK_IMAGE_TYPE_2D: |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 570 | result &= RangesIntersect(src->srcOffset.y, src->extent.height, dst->dstOffset.y, dst->extent.height); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 571 | // Intentionally fall through to 1D case |
| 572 | case VK_IMAGE_TYPE_1D: |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 573 | result &= RangesIntersect(src->srcOffset.x, src->extent.width, dst->dstOffset.x, dst->extent.width); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 574 | break; |
| 575 | default: |
| 576 | // Unrecognized or new IMAGE_TYPE enums will be caught in parameter_validation |
| 577 | assert(false); |
| 578 | } |
| 579 | } |
| 580 | return result; |
| 581 | } |
| 582 | |
| 583 | // Returns true if offset and extent exceed image extents |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 584 | static bool ExceedsBounds(const VkOffset3D *offset, const VkExtent3D *extent, const IMAGE_STATE *image) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 585 | bool result = false; |
| 586 | // Extents/depths cannot be negative but checks left in for clarity |
Mark Lobodzinski | 39573d2 | 2016-10-14 10:59:27 -0600 | [diff] [blame] | 587 | switch (image->imageType) { |
| 588 | case VK_IMAGE_TYPE_3D: // Validate z and depth |
| 589 | if ((offset->z + extent->depth > image->extent.depth) || (offset->z < 0) || |
| 590 | ((offset->z + static_cast<int32_t>(extent->depth)) < 0)) { |
| 591 | result = true; |
| 592 | } |
| 593 | // Intentionally fall through to 2D case to check height |
| 594 | case VK_IMAGE_TYPE_2D: // Validate y and height |
| 595 | if ((offset->y + extent->height > image->extent.height) || (offset->y < 0) || |
| 596 | ((offset->y + static_cast<int32_t>(extent->height)) < 0)) { |
| 597 | result = true; |
| 598 | } |
| 599 | // Intentionally fall through to 1D case to check width |
| 600 | case VK_IMAGE_TYPE_1D: // Validate x and width |
| 601 | if ((offset->x + extent->width > image->extent.width) || (offset->x < 0) || |
| 602 | ((offset->x + static_cast<int32_t>(extent->width)) < 0)) { |
| 603 | result = true; |
| 604 | } |
| 605 | break; |
| 606 | default: |
| 607 | assert(false); |
| 608 | } |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 609 | return result; |
| 610 | } |
| 611 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 612 | bool PreCallValidateCmdCopyImage(VkCommandBuffer command_buffer, VkImage src_image, VkImage dst_image, uint32_t region_count, |
| 613 | const VkImageCopy *regions) { |
| 614 | bool skip = false; |
| 615 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(command_buffer), layer_data_map); |
| 616 | auto src_image_entry = getImageState(device_data, src_image); |
| 617 | auto dst_image_entry = getImageState(device_data, dst_image); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 618 | |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 619 | // TODO: This does not cover swapchain-created images. This should fall out when this layer is moved |
| 620 | // into the core_validation layer |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 621 | if (src_image_entry && dst_image_entry) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 622 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 623 | for (uint32_t i = 0; i < region_count; i++) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 624 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 625 | if (regions[i].srcSubresource.layerCount == 0) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 626 | std::stringstream ss; |
| 627 | ss << "vkCmdCopyImage: number of layers in pRegions[" << i << "] srcSubresource is zero"; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 628 | skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| 629 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t &>(command_buffer), |
| 630 | __LINE__, IMAGE_MISMATCHED_IMAGE_ASPECT, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 631 | } |
| 632 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 633 | if (regions[i].dstSubresource.layerCount == 0) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 634 | std::stringstream ss; |
| 635 | ss << "vkCmdCopyImage: number of layers in pRegions[" << i << "] dstSubresource is zero"; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 636 | skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| 637 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t &>(command_buffer), |
| 638 | __LINE__, IMAGE_MISMATCHED_IMAGE_ASPECT, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 639 | } |
| 640 | |
| 641 | // For each region the layerCount member of srcSubresource and dstSubresource must match |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 642 | if (regions[i].srcSubresource.layerCount != regions[i].dstSubresource.layerCount) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 643 | std::stringstream ss; |
| 644 | ss << "vkCmdCopyImage: number of layers in source and destination subresources for pRegions[" << i |
| 645 | << "] do not match"; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 646 | skip |= |
Mark Lobodzinski | a9a69ad | 2016-10-14 12:13:33 -0600 | [diff] [blame] | 647 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 648 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, VALIDATION_ERROR_01198, "IMAGE", "%s. %s", |
Mark Lobodzinski | a9a69ad | 2016-10-14 12:13:33 -0600 | [diff] [blame] | 649 | ss.str().c_str(), validation_error_map[VALIDATION_ERROR_01198]); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 650 | } |
| 651 | |
| 652 | // For each region, the aspectMask member of srcSubresource and dstSubresource must match |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 653 | if (regions[i].srcSubresource.aspectMask != regions[i].dstSubresource.aspectMask) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 654 | char const str[] = "vkCmdCopyImage: Src and dest aspectMasks for each region must match"; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 655 | skip |= |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 656 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 657 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, IMAGE_MISMATCHED_IMAGE_ASPECT, "IMAGE", str); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 658 | } |
| 659 | |
| 660 | // AspectMask must not contain VK_IMAGE_ASPECT_METADATA_BIT |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 661 | if ((regions[i].srcSubresource.aspectMask & VK_IMAGE_ASPECT_METADATA_BIT) || |
| 662 | (regions[i].dstSubresource.aspectMask & VK_IMAGE_ASPECT_METADATA_BIT)) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 663 | std::stringstream ss; |
| 664 | ss << "vkCmdCopyImage: pRegions[" << i << "] may not specify aspectMask containing VK_IMAGE_ASPECT_METADATA_BIT"; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 665 | skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 666 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t &>(command_buffer), |
| 667 | __LINE__, IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 668 | } |
| 669 | |
| 670 | // For each region, if aspectMask contains VK_IMAGE_ASPECT_COLOR_BIT, it must not contain either of |
| 671 | // VK_IMAGE_ASPECT_DEPTH_BIT or VK_IMAGE_ASPECT_STENCIL_BIT |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 672 | if ((regions[i].srcSubresource.aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) && |
| 673 | (regions[i].srcSubresource.aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT))) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 674 | char const str[] = "vkCmdCopyImage aspectMask cannot specify both COLOR and DEPTH/STENCIL aspects"; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 675 | skip |= |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 676 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 677 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", str); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 678 | } |
| 679 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 680 | // If either of the calling command's src_image or dst_image parameters are of VkImageType VK_IMAGE_TYPE_3D, |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 681 | // the baseArrayLayer and layerCount members of both srcSubresource and dstSubresource must be 0 and 1, respectively |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 682 | if (((src_image_entry->imageType == VK_IMAGE_TYPE_3D) || (dst_image_entry->imageType == VK_IMAGE_TYPE_3D)) && |
| 683 | ((regions[i].srcSubresource.baseArrayLayer != 0) || (regions[i].srcSubresource.layerCount != 1) || |
| 684 | (regions[i].dstSubresource.baseArrayLayer != 0) || (regions[i].dstSubresource.layerCount != 1))) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 685 | std::stringstream ss; |
| 686 | ss << "vkCmdCopyImage: src or dstImage type was IMAGE_TYPE_3D, but in subRegion[" << i |
| 687 | << "] baseArrayLayer was not zero or layerCount was not 1."; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 688 | skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 689 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t &>(command_buffer), |
| 690 | __LINE__, IMAGE_INVALID_EXTENTS, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 691 | } |
| 692 | |
| 693 | // MipLevel must be less than the mipLevels specified in VkImageCreateInfo when the image was created |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 694 | if (regions[i].srcSubresource.mipLevel >= src_image_entry->mipLevels) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 695 | std::stringstream ss; |
| 696 | ss << "vkCmdCopyImage: pRegions[" << i |
| 697 | << "] specifies a src mipLevel greater than the number specified when the srcImage was created."; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 698 | skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 699 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t &>(command_buffer), |
| 700 | __LINE__, IMAGE_INVALID_EXTENTS, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 701 | } |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 702 | if (regions[i].dstSubresource.mipLevel >= dst_image_entry->mipLevels) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 703 | std::stringstream ss; |
| 704 | ss << "vkCmdCopyImage: pRegions[" << i |
| 705 | << "] specifies a dst mipLevel greater than the number specified when the dstImage was created."; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 706 | skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 707 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t &>(command_buffer), |
| 708 | __LINE__, IMAGE_INVALID_EXTENTS, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 709 | } |
| 710 | |
| 711 | // (baseArrayLayer + layerCount) must be less than or equal to the arrayLayers specified in VkImageCreateInfo when the |
| 712 | // image was created |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 713 | if ((regions[i].srcSubresource.baseArrayLayer + regions[i].srcSubresource.layerCount) > src_image_entry->arraySize) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 714 | std::stringstream ss; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 715 | ss << "vkCmdCopyImage: srcImage arrayLayers was " << src_image_entry->arraySize << " but subRegion[" << i |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 716 | << "] baseArrayLayer + layerCount is " |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 717 | << (regions[i].srcSubresource.baseArrayLayer + regions[i].srcSubresource.layerCount); |
| 718 | skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 719 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t &>(command_buffer), |
| 720 | __LINE__, IMAGE_INVALID_EXTENTS, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 721 | } |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 722 | if ((regions[i].dstSubresource.baseArrayLayer + regions[i].dstSubresource.layerCount) > dst_image_entry->arraySize) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 723 | std::stringstream ss; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 724 | ss << "vkCmdCopyImage: dstImage arrayLayers was " << dst_image_entry->arraySize << " but subRegion[" << i |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 725 | << "] baseArrayLayer + layerCount is " |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 726 | << (regions[i].dstSubresource.baseArrayLayer + regions[i].dstSubresource.layerCount); |
| 727 | skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 728 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t &>(command_buffer), |
| 729 | __LINE__, IMAGE_INVALID_EXTENTS, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 730 | } |
| 731 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 732 | // The source region specified by a given element of regions must be a region that is contained within srcImage |
| 733 | if (ExceedsBounds(®ions[i].srcOffset, ®ions[i].extent, src_image_entry)) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 734 | std::stringstream ss; |
| 735 | ss << "vkCmdCopyImage: srcSubResource in pRegions[" << i << "] exceeds extents srcImage was created with"; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 736 | skip |= |
Mark Lobodzinski | 8ea6eb0 | 2016-10-14 11:40:31 -0600 | [diff] [blame] | 737 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 738 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, VALIDATION_ERROR_01175, "IMAGE", "%s. %s", |
Tobin Ehlis | 15edfa8 | 2016-10-18 07:31:22 -0600 | [diff] [blame] | 739 | ss.str().c_str(), validation_error_map[VALIDATION_ERROR_01175]); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 740 | } |
| 741 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 742 | // The destination region specified by a given element of regions must be a region that is contained within dst_image |
| 743 | if (ExceedsBounds(®ions[i].dstOffset, ®ions[i].extent, dst_image_entry)) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 744 | std::stringstream ss; |
| 745 | ss << "vkCmdCopyImage: dstSubResource in pRegions[" << i << "] exceeds extents dstImage was created with"; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 746 | skip |= |
Mark Lobodzinski | 8ea6eb0 | 2016-10-14 11:40:31 -0600 | [diff] [blame] | 747 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 748 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, VALIDATION_ERROR_01176, "IMAGE", "%s. %s", |
Mark Lobodzinski | 8ea6eb0 | 2016-10-14 11:40:31 -0600 | [diff] [blame] | 749 | ss.str().c_str(), validation_error_map[VALIDATION_ERROR_01176]); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 750 | } |
| 751 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 752 | // The union of all source regions, and the union of all destination regions, specified by the elements of regions, |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 753 | // must not overlap in memory |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 754 | if (src_image == dst_image) { |
| 755 | for (uint32_t j = 0; j < region_count; j++) { |
| 756 | if (RegionIntersects(®ions[i], ®ions[j], src_image_entry->imageType)) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 757 | std::stringstream ss; |
| 758 | ss << "vkCmdCopyImage: pRegions[" << i << "] src overlaps with pRegions[" << j << "]."; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 759 | skip |= |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 760 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 761 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t &>(command_buffer), |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 762 | __LINE__, IMAGE_INVALID_EXTENTS, "IMAGE", "%s", ss.str().c_str()); |
| 763 | } |
| 764 | } |
| 765 | } |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 766 | } |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 767 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 768 | // The formats of src_image and dst_image must be compatible. Formats are considered compatible if their texel size in bytes |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 769 | // is the same between both formats. For example, VK_FORMAT_R8G8B8A8_UNORM is compatible with VK_FORMAT_R32_UINT because |
| 770 | // because both texels are 4 bytes in size. Depth/stencil formats must match exactly. |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 771 | if (vk_format_is_depth_or_stencil(src_image_entry->format) || vk_format_is_depth_or_stencil(dst_image_entry->format)) { |
| 772 | if (src_image_entry->format != dst_image_entry->format) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 773 | char const str[] = "vkCmdCopyImage called with unmatched source and dest image depth/stencil formats."; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 774 | skip |= |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 775 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 776 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, IMAGE_MISMATCHED_IMAGE_FORMAT, "IMAGE", str); |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 777 | } |
| 778 | } else { |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 779 | size_t srcSize = vk_format_get_size(src_image_entry->format); |
| 780 | size_t destSize = vk_format_get_size(dst_image_entry->format); |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 781 | if (srcSize != destSize) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 782 | char const str[] = "vkCmdCopyImage called with unmatched source and dest image format sizes."; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 783 | skip |= |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 784 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 785 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, VALIDATION_ERROR_01184, "IMAGE", "%s. %s", str, |
Tobin Ehlis | 15edfa8 | 2016-10-18 07:31:22 -0600 | [diff] [blame] | 786 | validation_error_map[VALIDATION_ERROR_01184]); |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 787 | } |
| 788 | } |
| 789 | } |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 790 | return skip; |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 791 | } |
| 792 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 793 | VKAPI_ATTR void VKAPI_CALL CmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, |
| 794 | VkImageLayout srcImageLayout, VkImage dstImage, |
| 795 | VkImageLayout dstImageLayout, uint32_t regionCount, |
| 796 | const VkImageCopy *pRegions) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 797 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 798 | bool skip = false; |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 799 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 800 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 801 | skip = PreCallValidateCmdCopyImage(commandBuffer, srcImage, dstImage, regionCount, pRegions); |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 802 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 803 | if (!skip) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 804 | device_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, |
| 805 | regionCount, pRegions); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 806 | } |
| 807 | } |
| 808 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 809 | VKAPI_ATTR void VKAPI_CALL CmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, |
| 810 | const VkClearAttachment *pAttachments, uint32_t rectCount, |
| 811 | const VkClearRect *pRects) { |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 812 | bool skipCall = false; |
Courtney Goeltzenleuchter | c9323e0 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 813 | VkImageAspectFlags aspectMask; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 814 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Courtney Goeltzenleuchter | c9323e0 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 815 | for (uint32_t i = 0; i < attachmentCount; i++) { |
| 816 | aspectMask = pAttachments[i].aspectMask; |
| 817 | if (aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { |
| 818 | if (aspectMask != VK_IMAGE_ASPECT_COLOR_BIT) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 819 | // VK_IMAGE_ASPECT_COLOR_BIT is not the only bit set for this attachment |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 820 | char const str[] = |
| 821 | "vkCmdClearAttachments aspectMask [%d] must set only VK_IMAGE_ASPECT_COLOR_BIT of a color attachment."; |
| 822 | skipCall |= |
| 823 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 824 | (uint64_t)commandBuffer, __LINE__, IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", str, i); |
Courtney Goeltzenleuchter | c9323e0 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 825 | } |
| 826 | } else { |
| 827 | // Image aspect must be depth or stencil or both |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 828 | if (((aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) != VK_IMAGE_ASPECT_DEPTH_BIT) && |
| 829 | ((aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT) != VK_IMAGE_ASPECT_STENCIL_BIT)) { |
| 830 | char const str[] = "vkCmdClearAttachments aspectMask [%d] must be set to VK_IMAGE_ASPECT_DEPTH_BIT and/or " |
| 831 | "VK_IMAGE_ASPECT_STENCIL_BIT"; |
| 832 | skipCall |= |
| 833 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 834 | (uint64_t)commandBuffer, __LINE__, IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", str, i); |
Courtney Goeltzenleuchter | c9323e0 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 835 | } |
| 836 | } |
| 837 | } |
| 838 | |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 839 | if (!skipCall) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 840 | device_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); |
Courtney Goeltzenleuchter | c9323e0 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 841 | } |
| 842 | } |
| 843 | |
Mark Lobodzinski | 576d839 | 2016-11-22 10:44:37 -0700 | [diff] [blame^] | 844 | static bool ValidateBufferImageCopyData(layer_data *dev_data, uint32_t regionCount, const VkBufferImageCopy *pRegions, |
| 845 | VkImage image, const char *function) { |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 846 | bool skip = false; |
| 847 | |
| 848 | for (uint32_t i = 0; i < regionCount; i++) { |
| 849 | |
| 850 | auto image_info = getImageState(dev_data, image); |
| 851 | if (image_info) { |
| 852 | // BufferOffset must be a multiple of the calling command's VkImage parameter's texel size |
| 853 | auto texel_size = vk_format_get_size(image_info->format); |
| 854 | if (vk_safe_modulo(pRegions[i].bufferOffset, texel_size) != 0) { |
| 855 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | 576d839 | 2016-11-22 10:44:37 -0700 | [diff] [blame^] | 856 | reinterpret_cast<uint64_t &>(image), __LINE__, VALIDATION_ERROR_01263, "IMAGE", |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 857 | "%s(): pRegion[%d] bufferOffset 0x%" PRIxLEAST64 |
Mark Lobodzinski | 576d839 | 2016-11-22 10:44:37 -0700 | [diff] [blame^] | 858 | " must be a multiple of this format's texel size (" PRINTF_SIZE_T_SPECIFIER "). %s", |
| 859 | function, i, pRegions[i].bufferOffset, texel_size, validation_error_map[VALIDATION_ERROR_01263]); |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 860 | } |
| 861 | // BufferOffset must be a multiple of 4 |
| 862 | if (vk_safe_modulo(pRegions[i].bufferOffset, 4) != 0) { |
| 863 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | 576d839 | 2016-11-22 10:44:37 -0700 | [diff] [blame^] | 864 | reinterpret_cast<uint64_t &>(image), __LINE__, VALIDATION_ERROR_01264, "IMAGE", |
| 865 | "%s(): pRegion[%d] bufferOffset 0x%" PRIxLEAST64 " must be a multiple of 4. %s", function, i, |
| 866 | pRegions[i].bufferOffset, validation_error_map[VALIDATION_ERROR_01264]); |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 867 | } |
| 868 | |
| 869 | // BufferRowLength must be 0, or greater than or equal to the width member of imageExtent |
| 870 | if ((pRegions[i].bufferRowLength != 0) && (pRegions[i].bufferRowLength < pRegions[i].imageExtent.width)) { |
| 871 | skip |= log_msg( |
| 872 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | 576d839 | 2016-11-22 10:44:37 -0700 | [diff] [blame^] | 873 | reinterpret_cast<uint64_t &>(image), __LINE__, VALIDATION_ERROR_01265, "IMAGE", |
| 874 | "%s(): pRegion[%d] bufferRowLength (%d) must be zero or greater-than-or-equal-to imageExtent.width (%d). %s", |
| 875 | function, i, pRegions[i].bufferRowLength, pRegions[i].imageExtent.width, |
| 876 | validation_error_map[VALIDATION_ERROR_01265]); |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 877 | } |
| 878 | |
| 879 | // BufferImageHeight must be 0, or greater than or equal to the height member of imageExtent |
| 880 | if ((pRegions[i].bufferImageHeight != 0) && (pRegions[i].bufferImageHeight < pRegions[i].imageExtent.height)) { |
| 881 | skip |= log_msg( |
| 882 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | 576d839 | 2016-11-22 10:44:37 -0700 | [diff] [blame^] | 883 | reinterpret_cast<uint64_t &>(image), __LINE__, VALIDATION_ERROR_01266, "IMAGE", |
| 884 | "%s(): pRegion[%d] bufferImageHeight (%d) must be zero or greater-than-or-equal-to imageExtent.height (%d). %s", |
| 885 | function, i, pRegions[i].bufferImageHeight, pRegions[i].imageExtent.height, |
| 886 | validation_error_map[VALIDATION_ERROR_01266]); |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 887 | } |
| 888 | } |
| 889 | } |
| 890 | |
| 891 | return skip; |
| 892 | } |
| 893 | |
Mark Lobodzinski | 39b8328 | 2016-11-22 09:33:23 -0700 | [diff] [blame] | 894 | static bool PreCallValidateCmdCopyImageToBuffer(layer_data *dev_data, VkCommandBuffer commandBuffer, VkImage srcImage, |
| 895 | VkImageLayout srcImageLayout, VkBuffer dstBuffer, uint32_t regionCount, |
| 896 | const VkBufferImageCopy *pRegions, const char *func_name) { |
Mark Lobodzinski | a95bc4e | 2016-11-22 09:37:10 -0700 | [diff] [blame] | 897 | bool skip = false; |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 898 | |
Mark Lobodzinski | a95bc4e | 2016-11-22 09:37:10 -0700 | [diff] [blame] | 899 | skip |= ValidateBufferImageCopyData(dev_data, regionCount, pRegions, srcImage, "vkCmdCopyImageToBuffer"); |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 900 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 901 | // For each region, the number of layers in the image subresource should not be zero |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 902 | // Image aspect must be ONE OF color, depth, stencil |
| 903 | for (uint32_t i = 0; i < regionCount; i++) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 904 | if (pRegions[i].imageSubresource.layerCount == 0) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 905 | char const str[] = "vkCmdCopyImageToBuffer: number of layers in image subresource is zero"; |
| 906 | // TODO: Verify against Valid Use section of spec, if this case yields undefined results, then it's an error |
Mark Lobodzinski | a95bc4e | 2016-11-22 09:37:10 -0700 | [diff] [blame] | 907 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 908 | (uint64_t)commandBuffer, __LINE__, IMAGE_MISMATCHED_IMAGE_ASPECT, "IMAGE", str); |
Jeremy Hayes | 148bab2 | 2015-10-28 13:01:39 -0600 | [diff] [blame] | 909 | } |
| 910 | |
Chia-I Wu | ab83a0e | 2015-10-27 19:00:15 +0800 | [diff] [blame] | 911 | VkImageAspectFlags aspectMask = pRegions[i].imageSubresource.aspectMask; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 912 | if ((aspectMask != VK_IMAGE_ASPECT_COLOR_BIT) && (aspectMask != VK_IMAGE_ASPECT_DEPTH_BIT) && |
Chia-I Wu | ab83a0e | 2015-10-27 19:00:15 +0800 | [diff] [blame] | 913 | (aspectMask != VK_IMAGE_ASPECT_STENCIL_BIT)) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 914 | char const str[] = "vkCmdCopyImageToBuffer: aspectMasks for each region must specify only COLOR or DEPTH or STENCIL"; |
Mark Lobodzinski | a95bc4e | 2016-11-22 09:37:10 -0700 | [diff] [blame] | 915 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 916 | (uint64_t)commandBuffer, __LINE__, IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", str); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 917 | } |
| 918 | } |
Mark Lobodzinski | a95bc4e | 2016-11-22 09:37:10 -0700 | [diff] [blame] | 919 | return skip; |
Mark Lobodzinski | 39b8328 | 2016-11-22 09:33:23 -0700 | [diff] [blame] | 920 | } |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 921 | |
Mark Lobodzinski | 39b8328 | 2016-11-22 09:33:23 -0700 | [diff] [blame] | 922 | VKAPI_ATTR void VKAPI_CALL CmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, |
| 923 | VkBuffer dstBuffer, uint32_t regionCount, const VkBufferImageCopy *pRegions) { |
| 924 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 925 | |
| 926 | if (!PreCallValidateCmdCopyImageToBuffer(device_data, commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, pRegions, |
| 927 | "vkCmdCopyImageToBuffer()")) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 928 | device_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, |
| 929 | pRegions); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 930 | } |
| 931 | } |
| 932 | |
Mark Lobodzinski | 39b8328 | 2016-11-22 09:33:23 -0700 | [diff] [blame] | 933 | static bool PreCallValidateCmdCopyBufferToImage(layer_data *dev_data, VkCommandBuffer commandBuffer, VkBuffer srcBuffer, |
| 934 | VkImage dstImage, VkImageLayout dstImageLayout, uint32_t regionCount, |
| 935 | const VkBufferImageCopy *pRegions, const char *func_name) { |
Mark Lobodzinski | a95bc4e | 2016-11-22 09:37:10 -0700 | [diff] [blame] | 936 | bool skip = false; |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 937 | |
Mark Lobodzinski | a95bc4e | 2016-11-22 09:37:10 -0700 | [diff] [blame] | 938 | skip |= ValidateBufferImageCopyData(dev_data, regionCount, pRegions, dstImage, "vkCmdCopyBufferToImage"); |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 939 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 940 | // For each region, the number of layers in the image subresource should not be zero |
Mark Lobodzinski | 39b8328 | 2016-11-22 09:33:23 -0700 | [diff] [blame] | 941 | // Image aspect must be ONE OF color, depth, or stencil |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 942 | for (uint32_t i = 0; i < regionCount; i++) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 943 | if (pRegions[i].imageSubresource.layerCount == 0) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 944 | char const str[] = "vkCmdCopyBufferToImage: number of layers in image subresource is zero"; |
| 945 | // TODO: Verify against Valid Use section of spec, if this case yields undefined results, then it's an error |
Mark Lobodzinski | a95bc4e | 2016-11-22 09:37:10 -0700 | [diff] [blame] | 946 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 947 | (uint64_t)commandBuffer, __LINE__, IMAGE_MISMATCHED_IMAGE_ASPECT, "IMAGE", str); |
Jeremy Hayes | 148bab2 | 2015-10-28 13:01:39 -0600 | [diff] [blame] | 948 | } |
| 949 | |
Chia-I Wu | ab83a0e | 2015-10-27 19:00:15 +0800 | [diff] [blame] | 950 | VkImageAspectFlags aspectMask = pRegions[i].imageSubresource.aspectMask; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 951 | if ((aspectMask != VK_IMAGE_ASPECT_COLOR_BIT) && (aspectMask != VK_IMAGE_ASPECT_DEPTH_BIT) && |
Chia-I Wu | ab83a0e | 2015-10-27 19:00:15 +0800 | [diff] [blame] | 952 | (aspectMask != VK_IMAGE_ASPECT_STENCIL_BIT)) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 953 | char const str[] = "vkCmdCopyBufferToImage: aspectMasks for each region must specify only COLOR or DEPTH or STENCIL"; |
Mark Lobodzinski | a95bc4e | 2016-11-22 09:37:10 -0700 | [diff] [blame] | 954 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 955 | (uint64_t)commandBuffer, __LINE__, IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", str); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 956 | } |
| 957 | } |
Mark Lobodzinski | a95bc4e | 2016-11-22 09:37:10 -0700 | [diff] [blame] | 958 | return skip; |
Mark Lobodzinski | 39b8328 | 2016-11-22 09:33:23 -0700 | [diff] [blame] | 959 | } |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 960 | |
Mark Lobodzinski | 39b8328 | 2016-11-22 09:33:23 -0700 | [diff] [blame] | 961 | VKAPI_ATTR void VKAPI_CALL CmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkImage dstImage, |
| 962 | VkImageLayout dstImageLayout, uint32_t regionCount, |
| 963 | const VkBufferImageCopy *pRegions) { |
| 964 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 965 | |
| 966 | if (!PreCallValidateCmdCopyBufferToImage(device_data, commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, pRegions, |
| 967 | "vkCmdCopyBufferToImage()")) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 968 | device_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, |
| 969 | pRegions); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 970 | } |
| 971 | } |
| 972 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 973 | VKAPI_ATTR void VKAPI_CALL |
| 974 | CmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, |
| 975 | VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) { |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 976 | bool skipCall = false; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 977 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 978 | |
Mark Lobodzinski | 1af172a | 2016-08-16 11:51:12 -0600 | [diff] [blame] | 979 | // Warn for zero-sized regions |
| 980 | for (uint32_t i = 0; i < regionCount; i++) { |
| 981 | if ((pRegions[i].srcOffsets[0].x == pRegions[i].srcOffsets[1].x) || |
| 982 | (pRegions[i].srcOffsets[0].y == pRegions[i].srcOffsets[1].y) || |
| 983 | (pRegions[i].srcOffsets[0].z == pRegions[i].srcOffsets[1].z)) { |
| 984 | std::stringstream ss; |
| 985 | ss << "vkCmdBlitImage: pRegions[" << i << "].srcOffsets specify a zero-volume area."; |
| 986 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| 987 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), |
| 988 | __LINE__, IMAGE_INVALID_EXTENTS, "IMAGE", "%s", ss.str().c_str()); |
| 989 | } |
| 990 | if ((pRegions[i].dstOffsets[0].x == pRegions[i].dstOffsets[1].x) || |
| 991 | (pRegions[i].dstOffsets[0].y == pRegions[i].dstOffsets[1].y) || |
| 992 | (pRegions[i].dstOffsets[0].z == pRegions[i].dstOffsets[1].z)) { |
| 993 | std::stringstream ss; |
| 994 | ss << "vkCmdBlitImage: pRegions[" << i << "].dstOffsets specify a zero-volume area."; |
| 995 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| 996 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), |
| 997 | __LINE__, IMAGE_INVALID_EXTENTS, "IMAGE", "%s", ss.str().c_str()); |
| 998 | } |
| 999 | } |
| 1000 | |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 1001 | auto srcImageEntry = getImageState(device_data, srcImage); |
| 1002 | auto dstImageEntry = getImageState(device_data, dstImage); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1003 | |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 1004 | if (srcImageEntry && dstImageEntry) { |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1005 | |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 1006 | VkFormat srcFormat = srcImageEntry->format; |
| 1007 | VkFormat dstFormat = dstImageEntry->format; |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1008 | |
| 1009 | // Validate consistency for signed and unsigned formats |
| 1010 | if ((vk_format_is_sint(srcFormat) && !vk_format_is_sint(dstFormat)) || |
| 1011 | (vk_format_is_uint(srcFormat) && !vk_format_is_uint(dstFormat))) { |
| 1012 | std::stringstream ss; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1013 | ss << "vkCmdBlitImage: If one of srcImage and dstImage images has signed/unsigned integer format, " |
| 1014 | << "the other one must also have signed/unsigned integer format. " |
| 1015 | << "Source format is " << string_VkFormat(srcFormat) << " Destination format is " << string_VkFormat(dstFormat); |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1016 | skipCall |= |
| 1017 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 1018 | (uint64_t)commandBuffer, __LINE__, IMAGE_INVALID_FORMAT, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1019 | } |
| 1020 | |
| 1021 | // Validate aspect bits and formats for depth/stencil images |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1022 | if (vk_format_is_depth_or_stencil(srcFormat) || vk_format_is_depth_or_stencil(dstFormat)) { |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1023 | if (srcFormat != dstFormat) { |
| 1024 | std::stringstream ss; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1025 | ss << "vkCmdBlitImage: If one of srcImage and dstImage images has a format of depth, stencil or depth " |
| 1026 | << "stencil, the other one must have exactly the same format. " |
| 1027 | << "Source format is " << string_VkFormat(srcFormat) << " Destination format is " << string_VkFormat(dstFormat); |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1028 | skipCall |= |
| 1029 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 1030 | (uint64_t)commandBuffer, __LINE__, IMAGE_INVALID_FORMAT, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1031 | } |
| 1032 | |
| 1033 | for (uint32_t i = 0; i < regionCount; i++) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1034 | if (pRegions[i].srcSubresource.layerCount == 0) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1035 | char const str[] = "vkCmdBlitImage: number of layers in source subresource is zero"; |
| 1036 | // TODO: Verify against Valid Use section of spec, if this case yields undefined results, then it's an error |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1037 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 1038 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 1039 | IMAGE_MISMATCHED_IMAGE_ASPECT, "IMAGE", str); |
Jeremy Hayes | 148bab2 | 2015-10-28 13:01:39 -0600 | [diff] [blame] | 1040 | } |
| 1041 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1042 | if (pRegions[i].dstSubresource.layerCount == 0) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1043 | char const str[] = "vkCmdBlitImage: number of layers in destination subresource is zero"; |
| 1044 | // TODO: Verify against Valid Use section of spec, if this case yields undefined results, then it's an error |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1045 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 1046 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 1047 | IMAGE_MISMATCHED_IMAGE_ASPECT, "IMAGE", str); |
Jeremy Hayes | 148bab2 | 2015-10-28 13:01:39 -0600 | [diff] [blame] | 1048 | } |
| 1049 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1050 | if (pRegions[i].srcSubresource.layerCount != pRegions[i].dstSubresource.layerCount) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1051 | char const str[] = "vkCmdBlitImage: number of layers in source and destination subresources must match"; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1052 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 1053 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 1054 | IMAGE_MISMATCHED_IMAGE_ASPECT, "IMAGE", str); |
Jeremy Hayes | 148bab2 | 2015-10-28 13:01:39 -0600 | [diff] [blame] | 1055 | } |
| 1056 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1057 | VkImageAspectFlags srcAspect = pRegions[i].srcSubresource.aspectMask; |
| 1058 | VkImageAspectFlags dstAspect = pRegions[i].dstSubresource.aspectMask; |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1059 | |
| 1060 | if (srcAspect != dstAspect) { |
| 1061 | std::stringstream ss; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1062 | ss << "vkCmdBlitImage: Image aspects of depth/stencil images should match"; |
| 1063 | // TODO: Verify against Valid Use section of spec, if this case yields undefined results, then it's an error |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1064 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 1065 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 1066 | IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1067 | } |
| 1068 | if (vk_format_is_depth_and_stencil(srcFormat)) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1069 | if ((srcAspect != VK_IMAGE_ASPECT_DEPTH_BIT) && (srcAspect != VK_IMAGE_ASPECT_STENCIL_BIT)) { |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1070 | std::stringstream ss; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1071 | ss << "vkCmdBlitImage: Combination depth/stencil image formats must have only one of " |
| 1072 | "VK_IMAGE_ASPECT_DEPTH_BIT " |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1073 | << "and VK_IMAGE_ASPECT_STENCIL_BIT set in srcImage and dstImage"; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1074 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 1075 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 1076 | IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1077 | } |
| 1078 | } else if (vk_format_is_stencil_only(srcFormat)) { |
| 1079 | if (srcAspect != VK_IMAGE_ASPECT_STENCIL_BIT) { |
| 1080 | std::stringstream ss; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1081 | ss << "vkCmdBlitImage: Stencil-only image formats must have only the VK_IMAGE_ASPECT_STENCIL_BIT " |
Chia-I Wu | 3432a0c | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 1082 | << "set in both the srcImage and dstImage"; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1083 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 1084 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 1085 | IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1086 | } |
| 1087 | } else if (vk_format_is_depth_only(srcFormat)) { |
| 1088 | if (srcAspect != VK_IMAGE_ASPECT_DEPTH_BIT) { |
| 1089 | std::stringstream ss; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1090 | ss << "vkCmdBlitImage: Depth-only image formats must have only the VK_IMAGE_ASPECT_DEPTH " |
Chia-I Wu | 3432a0c | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 1091 | << "set in both the srcImage and dstImage"; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1092 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 1093 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 1094 | IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1095 | } |
| 1096 | } |
| 1097 | } |
| 1098 | } |
| 1099 | |
| 1100 | // Validate filter |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1101 | if (vk_format_is_depth_or_stencil(srcFormat) || vk_format_is_int(srcFormat)) { |
Chia-I Wu | b99df44 | 2015-10-26 16:49:32 +0800 | [diff] [blame] | 1102 | if (filter != VK_FILTER_NEAREST) { |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1103 | std::stringstream ss; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1104 | ss << "vkCmdBlitImage: If the format of srcImage is a depth, stencil, depth stencil or integer-based format " |
Chia-I Wu | b99df44 | 2015-10-26 16:49:32 +0800 | [diff] [blame] | 1105 | << "then filter must be VK_FILTER_NEAREST."; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1106 | skipCall |= |
| 1107 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 1108 | (uint64_t)commandBuffer, __LINE__, IMAGE_INVALID_FILTER, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1109 | } |
| 1110 | } |
| 1111 | } |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 1112 | |
Tony Barbour | f830910 | 2016-05-05 10:50:21 -0600 | [diff] [blame] | 1113 | if (!skipCall) { |
| 1114 | device_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, |
| 1115 | pRegions, filter); |
| 1116 | } |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 1117 | } |
| 1118 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1119 | VKAPI_ATTR void VKAPI_CALL |
| 1120 | CmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, |
| 1121 | VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, |
| 1122 | uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, |
| 1123 | uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 1124 | bool skipCall = false; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1125 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | 01b3889 | 2015-11-17 18:19:55 -0700 | [diff] [blame] | 1126 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1127 | for (uint32_t i = 0; i < imageMemoryBarrierCount; ++i) { |
| 1128 | VkImageMemoryBarrier const *const barrier = (VkImageMemoryBarrier const *const) & pImageMemoryBarriers[i]; |
| 1129 | if (barrier->sType == VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER) { |
| 1130 | if (barrier->subresourceRange.layerCount == 0) { |
Jeremy Hayes | 01b3889 | 2015-11-17 18:19:55 -0700 | [diff] [blame] | 1131 | std::stringstream ss; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1132 | ss << "vkCmdPipelineBarrier called with 0 in ppMemoryBarriers[" << i << "]->subresourceRange.layerCount."; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1133 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 1134 | __LINE__, IMAGE_INVALID_IMAGE_RESOURCE, "IMAGE", "%s", ss.str().c_str()); |
Jeremy Hayes | 01b3889 | 2015-11-17 18:19:55 -0700 | [diff] [blame] | 1135 | } |
| 1136 | } |
| 1137 | } |
| 1138 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1139 | if (skipCall) { |
Jeremy Hayes | 01b3889 | 2015-11-17 18:19:55 -0700 | [diff] [blame] | 1140 | return; |
| 1141 | } |
| 1142 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1143 | device_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1144 | memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, |
| 1145 | pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); |
Jeremy Hayes | 01b3889 | 2015-11-17 18:19:55 -0700 | [diff] [blame] | 1146 | } |
| 1147 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1148 | VKAPI_ATTR void VKAPI_CALL |
| 1149 | CmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, |
| 1150 | VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageResolve *pRegions) { |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 1151 | bool skipCall = false; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1152 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 1153 | auto srcImageEntry = getImageState(device_data, srcImage); |
| 1154 | auto dstImageEntry = getImageState(device_data, dstImage); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 1155 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1156 | // For each region, the number of layers in the image subresource should not be zero |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 1157 | // For each region, src and dest image aspect must be color only |
| 1158 | for (uint32_t i = 0; i < regionCount; i++) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1159 | if (pRegions[i].srcSubresource.layerCount == 0) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1160 | char const str[] = "vkCmdResolveImage: number of layers in source subresource is zero"; |
| 1161 | // TODO: Verify against Valid Use section of spec. Generally if something yield an undefined result, it's invalid/error |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1162 | skipCall |= |
| 1163 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 1164 | (uint64_t)commandBuffer, __LINE__, IMAGE_MISMATCHED_IMAGE_ASPECT, "IMAGE", str); |
Jeremy Hayes | 148bab2 | 2015-10-28 13:01:39 -0600 | [diff] [blame] | 1165 | } |
| 1166 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1167 | if (pRegions[i].dstSubresource.layerCount == 0) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1168 | char const str[] = "vkCmdResolveImage: number of layers in destination subresource is zero"; |
Courtney Goeltzenleuchter | 7415d5a | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1169 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1170 | // TODO: Verify against Valid Use section of spec. Generally if something yield an undefined result, it's invalid/error |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1171 | skipCall |= |
| 1172 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 1173 | (uint64_t)commandBuffer, __LINE__, IMAGE_MISMATCHED_IMAGE_ASPECT, "IMAGE", str); |
Jeremy Hayes | 148bab2 | 2015-10-28 13:01:39 -0600 | [diff] [blame] | 1174 | } |
| 1175 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1176 | if ((pRegions[i].srcSubresource.aspectMask != VK_IMAGE_ASPECT_COLOR_BIT) || |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1177 | (pRegions[i].dstSubresource.aspectMask != VK_IMAGE_ASPECT_COLOR_BIT)) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1178 | char const str[] = |
| 1179 | "vkCmdResolveImage: src and dest aspectMasks for each region must specify only VK_IMAGE_ASPECT_COLOR_BIT"; |
| 1180 | skipCall |= |
| 1181 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 1182 | (uint64_t)commandBuffer, __LINE__, IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", str); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 1183 | } |
| 1184 | } |
| 1185 | |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 1186 | if (srcImageEntry && dstImageEntry) { |
| 1187 | if (srcImageEntry->format != dstImageEntry->format) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1188 | char const str[] = "vkCmdResolveImage called with unmatched source and dest formats."; |
| 1189 | skipCall |= |
| 1190 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 1191 | (uint64_t)commandBuffer, __LINE__, IMAGE_MISMATCHED_IMAGE_FORMAT, "IMAGE", str); |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 1192 | } |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 1193 | if (srcImageEntry->imageType != dstImageEntry->imageType) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1194 | char const str[] = "vkCmdResolveImage called with unmatched source and dest image types."; |
| 1195 | skipCall |= |
| 1196 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 1197 | (uint64_t)commandBuffer, __LINE__, IMAGE_MISMATCHED_IMAGE_TYPE, "IMAGE", str); |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 1198 | } |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 1199 | if (srcImageEntry->samples == VK_SAMPLE_COUNT_1_BIT) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1200 | char const str[] = "vkCmdResolveImage called with source sample count less than 2."; |
| 1201 | skipCall |= |
| 1202 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 1203 | (uint64_t)commandBuffer, __LINE__, IMAGE_INVALID_RESOLVE_SAMPLES, "IMAGE", str); |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 1204 | } |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 1205 | if (dstImageEntry->samples != VK_SAMPLE_COUNT_1_BIT) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1206 | char const str[] = "vkCmdResolveImage called with dest sample count greater than 1."; |
| 1207 | skipCall |= |
| 1208 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 1209 | (uint64_t)commandBuffer, __LINE__, IMAGE_INVALID_RESOLVE_SAMPLES, "IMAGE", str); |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 1210 | } |
| 1211 | } |
| 1212 | |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 1213 | if (!skipCall) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1214 | device_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, |
| 1215 | regionCount, pRegions); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 1216 | } |
| 1217 | } |
| 1218 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1219 | VKAPI_ATTR void VKAPI_CALL |
| 1220 | GetImageSubresourceLayout(VkDevice device, VkImage image, const VkImageSubresource *pSubresource, VkSubresourceLayout *pLayout) { |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 1221 | bool skipCall = false; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1222 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1223 | VkFormat format; |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 1224 | |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 1225 | auto imageEntry = getImageState(device_data, image); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1226 | |
| 1227 | // Validate that image aspects match formats |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 1228 | if (imageEntry) { |
| 1229 | format = imageEntry->format; |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1230 | if (vk_format_is_color(format)) { |
Chia-I Wu | 52b07e7 | 2015-10-27 19:55:05 +0800 | [diff] [blame] | 1231 | if (pSubresource->aspectMask != VK_IMAGE_ASPECT_COLOR_BIT) { |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1232 | std::stringstream ss; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1233 | ss << "vkGetImageSubresourceLayout: For color formats, the aspectMask field of VkImageSubresource must be " |
| 1234 | "VK_IMAGE_ASPECT_COLOR."; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1235 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1236 | (uint64_t)image, __LINE__, IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1237 | } |
| 1238 | } else if (vk_format_is_depth_or_stencil(format)) { |
Chia-I Wu | 52b07e7 | 2015-10-27 19:55:05 +0800 | [diff] [blame] | 1239 | if ((pSubresource->aspectMask != VK_IMAGE_ASPECT_DEPTH_BIT) && |
| 1240 | (pSubresource->aspectMask != VK_IMAGE_ASPECT_STENCIL_BIT)) { |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1241 | std::stringstream ss; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1242 | ss << "vkGetImageSubresourceLayout: For depth/stencil formats, the aspectMask selects either the depth or stencil " |
| 1243 | "image aspectMask."; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1244 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1245 | (uint64_t)image, __LINE__, IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1246 | } |
| 1247 | } |
| 1248 | } |
| 1249 | |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 1250 | if (!skipCall) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1251 | device_data->device_dispatch_table->GetImageSubresourceLayout(device, image, pSubresource, pLayout); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1252 | } |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 1253 | } |
| 1254 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1255 | VKAPI_ATTR void VKAPI_CALL |
| 1256 | GetPhysicalDeviceProperties(VkPhysicalDevice physicalDevice, VkPhysicalDeviceProperties *pProperties) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1257 | layer_data *phy_dev_data = get_my_data_ptr(get_dispatch_key(physicalDevice), layer_data_map); |
| 1258 | phy_dev_data->instance_dispatch_table->GetPhysicalDeviceProperties(physicalDevice, pProperties); |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 1259 | } |
| 1260 | |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 1261 | VKAPI_ATTR VkResult VKAPI_CALL |
| 1262 | EnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { |
| 1263 | return util_GetLayerProperties(1, &global_layer, pCount, pProperties); |
| 1264 | } |
| 1265 | |
| 1266 | VKAPI_ATTR VkResult VKAPI_CALL |
| 1267 | EnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { |
| 1268 | return util_GetLayerProperties(1, &global_layer, pCount, pProperties); |
| 1269 | } |
| 1270 | |
| 1271 | VKAPI_ATTR VkResult VKAPI_CALL |
| 1272 | EnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { |
| 1273 | if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) |
| 1274 | return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); |
| 1275 | |
| 1276 | return VK_ERROR_LAYER_NOT_PRESENT; |
| 1277 | } |
| 1278 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1279 | VKAPI_ATTR VkResult VKAPI_CALL EnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, |
| 1280 | const char *pLayerName, uint32_t *pCount, |
| 1281 | VkExtensionProperties *pProperties) { |
Chia-I Wu | eec9a31 | 2016-04-28 11:21:49 +0800 | [diff] [blame] | 1282 | // Image does not have any physical device extensions |
Chia-I Wu | 3f32622 | 2016-04-28 14:21:13 +0800 | [diff] [blame] | 1283 | if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) |
Chia-I Wu | eec9a31 | 2016-04-28 11:21:49 +0800 | [diff] [blame] | 1284 | return util_GetExtensionProperties(0, NULL, pCount, pProperties); |
Chia-I Wu | 3f32622 | 2016-04-28 14:21:13 +0800 | [diff] [blame] | 1285 | |
| 1286 | assert(physicalDevice); |
| 1287 | |
| 1288 | dispatch_key key = get_dispatch_key(physicalDevice); |
| 1289 | layer_data *my_data = get_my_data_ptr(key, layer_data_map); |
| 1290 | VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; |
| 1291 | return pTable->EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); |
Chia-I Wu | eec9a31 | 2016-04-28 11:21:49 +0800 | [diff] [blame] | 1292 | } |
| 1293 | |
Chia-I Wu | 64df8ed | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1294 | static PFN_vkVoidFunction |
Chia-I Wu | 428eba0 | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1295 | intercept_core_instance_command(const char *name); |
| 1296 | static PFN_vkVoidFunction |
Chia-I Wu | 64df8ed | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1297 | intercept_core_device_command(const char *name); |
Tobin Ehlis | b74f6ab | 2015-10-29 14:19:18 -0600 | [diff] [blame] | 1298 | |
Chia-I Wu | 64df8ed | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1299 | VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetDeviceProcAddr(VkDevice device, const char *funcName) { |
| 1300 | PFN_vkVoidFunction proc = intercept_core_device_command(funcName); |
| 1301 | if (proc) |
| 1302 | return proc; |
| 1303 | |
| 1304 | assert(device); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 1305 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1306 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 1307 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1308 | VkLayerDispatchTable *pTable = my_data->device_dispatch_table; |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 1309 | { |
Tobin Ehlis | b74f6ab | 2015-10-29 14:19:18 -0600 | [diff] [blame] | 1310 | if (pTable->GetDeviceProcAddr == NULL) |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 1311 | return NULL; |
Tobin Ehlis | b74f6ab | 2015-10-29 14:19:18 -0600 | [diff] [blame] | 1312 | return pTable->GetDeviceProcAddr(device, funcName); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 1313 | } |
| 1314 | } |
| 1315 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1316 | VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetInstanceProcAddr(VkInstance instance, const char *funcName) { |
Chia-I Wu | 428eba0 | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1317 | PFN_vkVoidFunction proc = intercept_core_instance_command(funcName); |
Chia-I Wu | f89922c | 2016-04-28 15:16:59 +0800 | [diff] [blame] | 1318 | if (!proc) |
| 1319 | proc = intercept_core_device_command(funcName); |
Chia-I Wu | 428eba0 | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1320 | if (proc) |
| 1321 | return proc; |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 1322 | |
Chia-I Wu | f89922c | 2016-04-28 15:16:59 +0800 | [diff] [blame] | 1323 | assert(instance); |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1324 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 1325 | |
Chia-I Wu | f89922c | 2016-04-28 15:16:59 +0800 | [diff] [blame] | 1326 | proc = debug_report_get_instance_proc_addr(my_data->report_data, funcName); |
| 1327 | if (proc) |
| 1328 | return proc; |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 1329 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1330 | VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 1331 | if (pTable->GetInstanceProcAddr == NULL) |
| 1332 | return NULL; |
| 1333 | return pTable->GetInstanceProcAddr(instance, funcName); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 1334 | } |
Chia-I Wu | eec9a31 | 2016-04-28 11:21:49 +0800 | [diff] [blame] | 1335 | |
Chia-I Wu | 64df8ed | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1336 | static PFN_vkVoidFunction |
Chia-I Wu | 428eba0 | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1337 | intercept_core_instance_command(const char *name) { |
| 1338 | static const struct { |
| 1339 | const char *name; |
| 1340 | PFN_vkVoidFunction proc; |
| 1341 | } core_instance_commands[] = { |
| 1342 | { "vkGetInstanceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetInstanceProcAddr) }, |
| 1343 | { "vkCreateInstance", reinterpret_cast<PFN_vkVoidFunction>(CreateInstance) }, |
| 1344 | { "vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance) }, |
| 1345 | { "vkCreateDevice", reinterpret_cast<PFN_vkVoidFunction>(CreateDevice) }, |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 1346 | { "vkEnumerateInstanceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceLayerProperties) }, |
| 1347 | { "vkEnumerateDeviceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceLayerProperties) }, |
| 1348 | { "vkEnumerateInstanceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceExtensionProperties) }, |
Chia-I Wu | 428eba0 | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1349 | { "vkEnumerateDeviceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceExtensionProperties) }, |
| 1350 | { "vkGetPhysicalDeviceProperties", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceProperties) }, |
| 1351 | }; |
| 1352 | |
| 1353 | for (size_t i = 0; i < ARRAY_SIZE(core_instance_commands); i++) { |
| 1354 | if (!strcmp(core_instance_commands[i].name, name)) |
| 1355 | return core_instance_commands[i].proc; |
| 1356 | } |
| 1357 | |
| 1358 | return nullptr; |
| 1359 | } |
| 1360 | |
| 1361 | static PFN_vkVoidFunction |
Chia-I Wu | 64df8ed | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1362 | intercept_core_device_command(const char *name) { |
| 1363 | static const struct { |
| 1364 | const char *name; |
| 1365 | PFN_vkVoidFunction proc; |
| 1366 | } core_device_commands[] = { |
Tobin Ehlis | 1623987 | 2016-10-26 10:42:49 -0600 | [diff] [blame] | 1367 | {"vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr)}, |
| 1368 | {"vkDestroyDevice", reinterpret_cast<PFN_vkVoidFunction>(DestroyDevice)}, |
| 1369 | {"vkCreateImage", reinterpret_cast<PFN_vkVoidFunction>(CreateImage)}, |
| 1370 | {"vkDestroyImage", reinterpret_cast<PFN_vkVoidFunction>(DestroyImage)}, |
| 1371 | {"vkCreateRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CreateRenderPass)}, |
| 1372 | {"vkCmdClearColorImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearColorImage)}, |
| 1373 | {"vkCmdClearDepthStencilImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearDepthStencilImage)}, |
| 1374 | {"vkCmdClearAttachments", reinterpret_cast<PFN_vkVoidFunction>(CmdClearAttachments)}, |
| 1375 | {"vkCmdCopyImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImage)}, |
| 1376 | {"vkCmdCopyImageToBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImageToBuffer)}, |
| 1377 | {"vkCmdCopyBufferToImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBufferToImage)}, |
| 1378 | {"vkCmdBlitImage", reinterpret_cast<PFN_vkVoidFunction>(CmdBlitImage)}, |
| 1379 | {"vkCmdPipelineBarrier", reinterpret_cast<PFN_vkVoidFunction>(CmdPipelineBarrier)}, |
| 1380 | {"vkCmdResolveImage", reinterpret_cast<PFN_vkVoidFunction>(CmdResolveImage)}, |
| 1381 | {"vkGetImageSubresourceLayout", reinterpret_cast<PFN_vkVoidFunction>(GetImageSubresourceLayout)}, |
Chia-I Wu | 64df8ed | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1382 | }; |
| 1383 | |
| 1384 | for (size_t i = 0; i < ARRAY_SIZE(core_device_commands); i++) { |
| 1385 | if (!strcmp(core_device_commands[i].name, name)) |
| 1386 | return core_device_commands[i].proc; |
| 1387 | } |
| 1388 | |
| 1389 | return nullptr; |
| 1390 | } |
| 1391 | |
Chia-I Wu | aacb0fc | 2016-04-28 11:27:46 +0800 | [diff] [blame] | 1392 | } // namespace image |
| 1393 | |
| 1394 | // vk_layer_logging.h expects these to be defined |
| 1395 | |
| 1396 | VKAPI_ATTR VkResult VKAPI_CALL |
| 1397 | vkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, |
| 1398 | const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1399 | return image::CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); |
Chia-I Wu | aacb0fc | 2016-04-28 11:27:46 +0800 | [diff] [blame] | 1400 | } |
| 1401 | |
| 1402 | VKAPI_ATTR void VKAPI_CALL |
| 1403 | vkDestroyDebugReportCallbackEXT(VkInstance instance, |
| 1404 | VkDebugReportCallbackEXT msgCallback, |
| 1405 | const VkAllocationCallbacks *pAllocator) { |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1406 | image::DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); |
Chia-I Wu | aacb0fc | 2016-04-28 11:27:46 +0800 | [diff] [blame] | 1407 | } |
| 1408 | |
| 1409 | VKAPI_ATTR void VKAPI_CALL |
| 1410 | vkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, |
| 1411 | size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1412 | image::DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); |
Chia-I Wu | aacb0fc | 2016-04-28 11:27:46 +0800 | [diff] [blame] | 1413 | } |
| 1414 | |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 1415 | // loader-layer interface v0, just wrappers since there is only a layer |
Chia-I Wu | aacb0fc | 2016-04-28 11:27:46 +0800 | [diff] [blame] | 1416 | |
Chia-I Wu | eec9a31 | 2016-04-28 11:21:49 +0800 | [diff] [blame] | 1417 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL |
| 1418 | vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 1419 | return image::EnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties); |
Chia-I Wu | eec9a31 | 2016-04-28 11:21:49 +0800 | [diff] [blame] | 1420 | } |
| 1421 | |
| 1422 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL |
| 1423 | vkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 1424 | return image::EnumerateInstanceLayerProperties(pCount, pProperties); |
Chia-I Wu | eec9a31 | 2016-04-28 11:21:49 +0800 | [diff] [blame] | 1425 | } |
| 1426 | |
| 1427 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL |
| 1428 | vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 1429 | // the layer command handles VK_NULL_HANDLE just fine internally |
| 1430 | assert(physicalDevice == VK_NULL_HANDLE); |
| 1431 | return image::EnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties); |
Chia-I Wu | aacb0fc | 2016-04-28 11:27:46 +0800 | [diff] [blame] | 1432 | } |
| 1433 | |
| 1434 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, |
| 1435 | const char *pLayerName, uint32_t *pCount, |
| 1436 | VkExtensionProperties *pProperties) { |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 1437 | // the layer command handles VK_NULL_HANDLE just fine internally |
| 1438 | assert(physicalDevice == VK_NULL_HANDLE); |
Chia-I Wu | 3f32622 | 2016-04-28 14:21:13 +0800 | [diff] [blame] | 1439 | return image::EnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties); |
Chia-I Wu | aacb0fc | 2016-04-28 11:27:46 +0800 | [diff] [blame] | 1440 | } |
| 1441 | |
| 1442 | VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1443 | return image::GetDeviceProcAddr(dev, funcName); |
Chia-I Wu | aacb0fc | 2016-04-28 11:27:46 +0800 | [diff] [blame] | 1444 | } |
| 1445 | |
| 1446 | VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1447 | return image::GetInstanceProcAddr(instance, funcName); |
Chia-I Wu | eec9a31 | 2016-04-28 11:21:49 +0800 | [diff] [blame] | 1448 | } |