Mark Lobodzinski | 6eda00a | 2016-02-02 15:55:36 -0700 | [diff] [blame] | 1 | /* Copyright (c) 2015-2016 The Khronos Group Inc. |
| 2 | * Copyright (c) 2015-2016 Valve Corporation |
| 3 | * Copyright (c) 2015-2016 LunarG, Inc. |
| 4 | * Copyright (C) 2015-2016 Google Inc. |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 5 | * |
Jon Ashburn | 3ebf125 | 2016-04-19 11:30:31 -0600 | [diff] [blame] | 6 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 7 | * you may not use this file except in compliance with the License. |
| 8 | * You may obtain a copy of the License at |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 9 | * |
Jon Ashburn | 3ebf125 | 2016-04-19 11:30:31 -0600 | [diff] [blame] | 10 | * http://www.apache.org/licenses/LICENSE-2.0 |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 11 | * |
Jon Ashburn | 3ebf125 | 2016-04-19 11:30:31 -0600 | [diff] [blame] | 12 | * Unless required by applicable law or agreed to in writing, software |
| 13 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 14 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 15 | * See the License for the specific language governing permissions and |
| 16 | * limitations under the License. |
Courtney Goeltzenleuchter | 0555952 | 2015-10-30 11:14:30 -0600 | [diff] [blame] | 17 | * |
| 18 | * Author: Jeremy Hayes <jeremy@lunarg.com> |
| 19 | * Author: Mark Lobodzinski <mark@lunarg.com> |
| 20 | * Author: Mike Stroyan <mike@LunarG.com> |
| 21 | * Author: Tobin Ehlis <tobin@lunarg.com> |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 22 | */ |
| 23 | |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 24 | // Allow use of STL min and max functions in Windows |
| 25 | #define NOMINMAX |
| 26 | |
Jeremy Hayes | e0ed6a2 | 2016-04-08 09:53:54 -0600 | [diff] [blame] | 27 | #include <algorithm> |
| 28 | #include <assert.h> |
Karl Schultz | d7f3754 | 2016-05-10 11:36:08 -0600 | [diff] [blame] | 29 | #include <cinttypes> |
Jeremy Hayes | e0ed6a2 | 2016-04-08 09:53:54 -0600 | [diff] [blame] | 30 | #include <memory> |
| 31 | #include <mutex> |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 32 | #include <stdio.h> |
| 33 | #include <stdlib.h> |
| 34 | #include <string.h> |
Mark Lobodzinski | 040142c | 2016-11-22 11:18:46 -0700 | [diff] [blame] | 35 | #include <limits.h> |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 36 | #include <unordered_map> |
Jeremy Hayes | e0ed6a2 | 2016-04-08 09:53:54 -0600 | [diff] [blame] | 37 | #include <vector> |
Mark Lobodzinski | 040142c | 2016-11-22 11:18:46 -0700 | [diff] [blame] | 38 | #include <bitset> |
Mark Lobodzinski | 9acd2e3 | 2016-12-21 15:22:39 -0700 | [diff] [blame] | 39 | #include <sstream> |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 40 | |
Tobin Ehlis | b835d1b | 2015-07-03 10:34:49 -0600 | [diff] [blame] | 41 | #include "vk_loader_platform.h" |
Courtney Goeltzenleuchter | 8f8367e | 2015-10-07 08:38:30 -0600 | [diff] [blame] | 42 | #include "vk_dispatch_table_helper.h" |
Mark Lobodzinski | 9acd2e3 | 2016-12-21 15:22:39 -0700 | [diff] [blame] | 43 | #include "vk_enum_string_helper.h" |
Courtney Goeltzenleuchter | 8f8367e | 2015-10-07 08:38:30 -0600 | [diff] [blame] | 44 | #include "image.h" |
| 45 | #include "vk_layer_config.h" |
| 46 | #include "vk_layer_extension_utils.h" |
Tobin Ehlis | a0cb02e | 2015-07-03 10:15:26 -0600 | [diff] [blame] | 47 | #include "vk_layer_table.h" |
| 48 | #include "vk_layer_data.h" |
Courtney Goeltzenleuchter | 426e187 | 2015-07-07 11:18:30 -0600 | [diff] [blame] | 49 | #include "vk_layer_extension_utils.h" |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 50 | #include "vk_layer_utils.h" |
Courtney Goeltzenleuchter | 8f8367e | 2015-10-07 08:38:30 -0600 | [diff] [blame] | 51 | #include "vk_layer_logging.h" |
Mark Lobodzinski | 69b52fe | 2016-10-14 11:43:06 -0600 | [diff] [blame] | 52 | #include "vk_validation_error_messages.h" |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 53 | |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 54 | using namespace std; |
| 55 | |
Chia-I Wu | aacb0fc | 2016-04-28 11:27:46 +0800 | [diff] [blame] | 56 | namespace image { |
| 57 | |
Cody Northrop | 55443ef | 2015-09-28 15:09:32 -0600 | [diff] [blame] | 58 | struct layer_data { |
Chia-I Wu | 2cfc77c | 2016-04-28 16:04:15 +0800 | [diff] [blame] | 59 | VkInstance instance; |
| 60 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 61 | debug_report_data *report_data; |
| 62 | vector<VkDebugReportCallbackEXT> logging_callback; |
| 63 | VkLayerDispatchTable *device_dispatch_table; |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 64 | VkLayerInstanceDispatchTable *instance_dispatch_table; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 65 | VkPhysicalDevice physicalDevice; |
| 66 | VkPhysicalDeviceProperties physicalDeviceProperties; |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 67 | |
Chia-I Wu | e2fc552 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 68 | unordered_map<VkImage, IMAGE_STATE> imageMap; |
Cody Northrop | 55443ef | 2015-09-28 15:09:32 -0600 | [diff] [blame] | 69 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 70 | layer_data() |
| 71 | : report_data(nullptr), device_dispatch_table(nullptr), instance_dispatch_table(nullptr), physicalDevice(0), |
| 72 | physicalDeviceProperties(){}; |
Cody Northrop | 55443ef | 2015-09-28 15:09:32 -0600 | [diff] [blame] | 73 | }; |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 74 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 75 | static unordered_map<void *, layer_data *> layer_data_map; |
Jeremy Hayes | e0ed6a2 | 2016-04-08 09:53:54 -0600 | [diff] [blame] | 76 | static std::mutex global_lock; |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 77 | |
Mark Lobodzinski | 1079e1b | 2016-03-15 14:21:59 -0600 | [diff] [blame] | 78 | static void init_image(layer_data *my_data, const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | 1079e1b | 2016-03-15 14:21:59 -0600 | [diff] [blame] | 79 | layer_debug_actions(my_data->report_data, my_data->logging_callback, pAllocator, "lunarg_image"); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 80 | } |
| 81 | |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 82 | static IMAGE_STATE const *getImageState(layer_data const *dev_data, VkImage image) { |
| 83 | auto it = dev_data->imageMap.find(image); |
| 84 | if (it == dev_data->imageMap.end()) { |
| 85 | return nullptr; |
| 86 | } |
| 87 | return &it->second; |
| 88 | } |
| 89 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 90 | VKAPI_ATTR VkResult VKAPI_CALL |
| 91 | CreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, |
| 92 | const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 93 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); |
| 94 | VkResult res = my_data->instance_dispatch_table->CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 95 | if (res == VK_SUCCESS) { |
Mark Lobodzinski | 97c4d51 | 2016-05-19 15:27:18 -0600 | [diff] [blame] | 96 | res = layer_create_msg_callback(my_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 97 | } |
| 98 | return res; |
| 99 | } |
| 100 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 101 | VKAPI_ATTR void VKAPI_CALL DestroyDebugReportCallbackEXT(VkInstance instance, |
| 102 | VkDebugReportCallbackEXT msgCallback, |
| 103 | const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 104 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); |
| 105 | my_data->instance_dispatch_table->DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); |
Courtney Goeltzenleuchter | 05854bf | 2015-11-30 12:13:14 -0700 | [diff] [blame] | 106 | layer_destroy_msg_callback(my_data->report_data, msgCallback, pAllocator); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 107 | } |
| 108 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 109 | VKAPI_ATTR void VKAPI_CALL |
| 110 | DebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, |
| 111 | size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 112 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 113 | my_data->instance_dispatch_table->DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, |
| 114 | pMsg); |
Courtney Goeltzenleuchter | f0de724 | 2015-12-01 14:10:55 -0700 | [diff] [blame] | 115 | } |
| 116 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 117 | VKAPI_ATTR VkResult VKAPI_CALL |
| 118 | CreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 119 | VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 120 | |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 121 | assert(chain_info->u.pLayerInfo); |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 122 | PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 123 | PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 124 | if (fpCreateInstance == NULL) { |
| 125 | return VK_ERROR_INITIALIZATION_FAILED; |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 126 | } |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 127 | |
| 128 | // Advance the link info for the next element on the chain |
| 129 | chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; |
| 130 | |
| 131 | VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); |
| 132 | if (result != VK_SUCCESS) |
| 133 | return result; |
| 134 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 135 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map); |
Chia-I Wu | 2cfc77c | 2016-04-28 16:04:15 +0800 | [diff] [blame] | 136 | my_data->instance = *pInstance; |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 137 | my_data->instance_dispatch_table = new VkLayerInstanceDispatchTable; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 138 | layer_init_instance_dispatch_table(*pInstance, my_data->instance_dispatch_table, fpGetInstanceProcAddr); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 139 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 140 | my_data->report_data = debug_report_create_instance(my_data->instance_dispatch_table, *pInstance, |
| 141 | pCreateInfo->enabledExtensionCount, pCreateInfo->ppEnabledExtensionNames); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 142 | |
Mark Lobodzinski | 1079e1b | 2016-03-15 14:21:59 -0600 | [diff] [blame] | 143 | init_image(my_data, pAllocator); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 144 | |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 145 | return result; |
| 146 | } |
| 147 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 148 | VKAPI_ATTR void VKAPI_CALL DestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 149 | // Grab the key before the instance is destroyed. |
| 150 | dispatch_key key = get_dispatch_key(instance); |
Tobin Ehlis | b74f6ab | 2015-10-29 14:19:18 -0600 | [diff] [blame] | 151 | layer_data *my_data = get_my_data_ptr(key, layer_data_map); |
| 152 | VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; |
Chia-I Wu | f7458c5 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 153 | pTable->DestroyInstance(instance, pAllocator); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 154 | |
| 155 | // Clean up logging callback, if any |
Courtney Goeltzenleuchter | ffcdd8b | 2015-10-05 15:59:11 -0600 | [diff] [blame] | 156 | while (my_data->logging_callback.size() > 0) { |
Courtney Goeltzenleuchter | 7415d5a | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 157 | VkDebugReportCallbackEXT callback = my_data->logging_callback.back(); |
Courtney Goeltzenleuchter | 05854bf | 2015-11-30 12:13:14 -0700 | [diff] [blame] | 158 | layer_destroy_msg_callback(my_data->report_data, callback, pAllocator); |
Courtney Goeltzenleuchter | ffcdd8b | 2015-10-05 15:59:11 -0600 | [diff] [blame] | 159 | my_data->logging_callback.pop_back(); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 160 | } |
| 161 | |
Tobin Ehlis | b74f6ab | 2015-10-29 14:19:18 -0600 | [diff] [blame] | 162 | layer_debug_report_destroy_instance(my_data->report_data); |
| 163 | delete my_data->instance_dispatch_table; |
| 164 | layer_data_map.erase(key); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 165 | } |
| 166 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 167 | VKAPI_ATTR VkResult VKAPI_CALL CreateDevice(VkPhysicalDevice physicalDevice, |
| 168 | const VkDeviceCreateInfo *pCreateInfo, |
| 169 | const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { |
Chia-I Wu | 2cfc77c | 2016-04-28 16:04:15 +0800 | [diff] [blame] | 170 | layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(physicalDevice), layer_data_map); |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 171 | VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 172 | |
| 173 | assert(chain_info->u.pLayerInfo); |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 174 | PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; |
| 175 | PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; |
Chia-I Wu | 2cfc77c | 2016-04-28 16:04:15 +0800 | [diff] [blame] | 176 | PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice"); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 177 | if (fpCreateDevice == NULL) { |
| 178 | return VK_ERROR_INITIALIZATION_FAILED; |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 179 | } |
| 180 | |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 181 | // Advance the link info for the next element on the chain |
| 182 | chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; |
| 183 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 184 | VkResult result = fpCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 185 | if (result != VK_SUCCESS) { |
| 186 | return result; |
| 187 | } |
| 188 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 189 | layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 190 | |
| 191 | // Setup device dispatch table |
| 192 | my_device_data->device_dispatch_table = new VkLayerDispatchTable; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 193 | layer_init_device_dispatch_table(*pDevice, my_device_data->device_dispatch_table, fpGetDeviceProcAddr); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 194 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 195 | my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 196 | my_device_data->physicalDevice = physicalDevice; |
| 197 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 198 | my_instance_data->instance_dispatch_table->GetPhysicalDeviceProperties(physicalDevice, |
| 199 | &(my_device_data->physicalDeviceProperties)); |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 200 | |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 201 | return result; |
| 202 | } |
| 203 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 204 | VKAPI_ATTR void VKAPI_CALL DestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 205 | dispatch_key key = get_dispatch_key(device); |
Tobin Ehlis | b74f6ab | 2015-10-29 14:19:18 -0600 | [diff] [blame] | 206 | layer_data *my_data = get_my_data_ptr(key, layer_data_map); |
Chia-I Wu | f7458c5 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 207 | my_data->device_dispatch_table->DestroyDevice(device, pAllocator); |
Tobin Ehlis | b74f6ab | 2015-10-29 14:19:18 -0600 | [diff] [blame] | 208 | delete my_data->device_dispatch_table; |
| 209 | layer_data_map.erase(key); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 210 | } |
| 211 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 212 | static const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 213 | |
Chia-I Wu | 740891e | 2016-04-28 14:12:27 +0800 | [diff] [blame] | 214 | static const VkLayerProperties global_layer = { |
Jon Ashburn | dc9111c | 2016-03-22 12:57:13 -0600 | [diff] [blame] | 215 | "VK_LAYER_LUNARG_image", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", |
Chia-I Wu | 740891e | 2016-04-28 14:12:27 +0800 | [diff] [blame] | 216 | }; |
Courtney Goeltzenleuchter | 5285766 | 2015-12-01 14:08:28 -0700 | [diff] [blame] | 217 | |
Mark Lobodzinski | 2fd634c | 2015-07-29 09:21:22 -0600 | [diff] [blame] | 218 | // Start of the Image layer proper |
| 219 | |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 220 | VKAPI_ATTR VkResult VKAPI_CALL CreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, |
| 221 | const VkAllocationCallbacks *pAllocator, VkImage *pImage) { |
| 222 | bool skip_call = false; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 223 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
Michael Lentine | 0a369f6 | 2016-02-03 16:51:46 -0600 | [diff] [blame] | 224 | VkImageFormatProperties ImageFormatProperties; |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 225 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 226 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 227 | VkPhysicalDevice physicalDevice = device_data->physicalDevice; |
| 228 | layer_data *phy_dev_data = get_my_data_ptr(get_dispatch_key(physicalDevice), layer_data_map); |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 229 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 230 | if (pCreateInfo->format != VK_FORMAT_UNDEFINED) { |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 231 | VkFormatProperties properties; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 232 | phy_dev_data->instance_dispatch_table->GetPhysicalDeviceFormatProperties(device_data->physicalDevice, pCreateInfo->format, |
| 233 | &properties); |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 234 | if ((pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR) && (properties.linearTilingFeatures == 0)) { |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 235 | std::stringstream ss; |
| 236 | ss << "vkCreateImage format parameter (" << string_VkFormat(pCreateInfo->format) << ") is an unsupported format"; |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 237 | skip_call |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 238 | 0, __LINE__, VALIDATION_ERROR_02150, "IMAGE", "%s. %s", ss.str().c_str(), |
| 239 | validation_error_map[VALIDATION_ERROR_02150]); |
| 240 | } |
| 241 | |
| 242 | if ((pCreateInfo->tiling == VK_IMAGE_TILING_OPTIMAL) && (properties.optimalTilingFeatures == 0)) { |
| 243 | std::stringstream ss; |
| 244 | ss << "vkCreateImage format parameter (" << string_VkFormat(pCreateInfo->format) << ") is an unsupported format"; |
| 245 | skip_call |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, |
| 246 | 0, __LINE__, VALIDATION_ERROR_02155, "IMAGE", "%s. %s", ss.str().c_str(), |
| 247 | validation_error_map[VALIDATION_ERROR_02155]); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 248 | } |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 249 | |
| 250 | // Validate that format supports usage as color attachment |
| 251 | if (pCreateInfo->usage & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT) { |
| 252 | if ((pCreateInfo->tiling == VK_IMAGE_TILING_OPTIMAL) && |
| 253 | ((properties.optimalTilingFeatures & VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT) == 0)) { |
| 254 | std::stringstream ss; |
| 255 | ss << "vkCreateImage: VkFormat for TILING_OPTIMAL image (" << string_VkFormat(pCreateInfo->format) |
| 256 | << ") does not support requested Image usage type VK_IMAGE_USAGE_COLOR_ATTACHMENT"; |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 257 | skip_call |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 258 | VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, VALIDATION_ERROR_02158, "IMAGE", |
| 259 | "%s. %s", ss.str().c_str(), validation_error_map[VALIDATION_ERROR_02158]); |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 260 | } |
| 261 | if ((pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR) && |
| 262 | ((properties.linearTilingFeatures & VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT) == 0)) { |
| 263 | std::stringstream ss; |
| 264 | ss << "vkCreateImage: VkFormat for TILING_LINEAR image (" << string_VkFormat(pCreateInfo->format) |
| 265 | << ") does not support requested Image usage type VK_IMAGE_USAGE_COLOR_ATTACHMENT"; |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 266 | skip_call |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 267 | VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, VALIDATION_ERROR_02153, "IMAGE", |
| 268 | "%s. %s", ss.str().c_str(), validation_error_map[VALIDATION_ERROR_02153]); |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 269 | } |
| 270 | } |
| 271 | // Validate that format supports usage as depth/stencil attachment |
| 272 | if (pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) { |
| 273 | if ((pCreateInfo->tiling == VK_IMAGE_TILING_OPTIMAL) && |
| 274 | ((properties.optimalTilingFeatures & VK_FORMAT_FEATURE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0)) { |
| 275 | std::stringstream ss; |
| 276 | ss << "vkCreateImage: VkFormat for TILING_OPTIMAL image (" << string_VkFormat(pCreateInfo->format) |
| 277 | << ") does not support requested Image usage type VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT"; |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 278 | skip_call |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 279 | VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, VALIDATION_ERROR_02159, "IMAGE", |
| 280 | "%s. %s", ss.str().c_str(), validation_error_map[VALIDATION_ERROR_02159]); |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 281 | } |
| 282 | if ((pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR) && |
| 283 | ((properties.linearTilingFeatures & VK_FORMAT_FEATURE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0)) { |
| 284 | std::stringstream ss; |
| 285 | ss << "vkCreateImage: VkFormat for TILING_LINEAR image (" << string_VkFormat(pCreateInfo->format) |
| 286 | << ") does not support requested Image usage type VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT"; |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 287 | skip_call |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 288 | VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, VALIDATION_ERROR_02154, "IMAGE", |
| 289 | "%s. %s", ss.str().c_str(), validation_error_map[VALIDATION_ERROR_02154]); |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 290 | } |
| 291 | } |
| 292 | } else { |
| 293 | skip_call |= |
| 294 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 295 | VALIDATION_ERROR_00715, "IMAGE", "vkCreateImage: VkFormat for image must not be VK_FORMAT_UNDEFINED. %s", |
| 296 | validation_error_map[VALIDATION_ERROR_00715]); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 297 | } |
| 298 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 299 | // Internal call to get format info. Still goes through layers, could potentially go directly to ICD. |
| 300 | phy_dev_data->instance_dispatch_table->GetPhysicalDeviceImageFormatProperties( |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 301 | physicalDevice, pCreateInfo->format, pCreateInfo->imageType, pCreateInfo->tiling, pCreateInfo->usage, pCreateInfo->flags, |
| 302 | &ImageFormatProperties); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 303 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 304 | VkDeviceSize imageGranularity = device_data->physicalDeviceProperties.limits.bufferImageGranularity; |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 305 | imageGranularity = imageGranularity == 1 ? 0 : imageGranularity; |
| 306 | |
Mark Young | c48c4c1 | 2016-04-11 14:26:49 -0600 | [diff] [blame] | 307 | // Make sure all required dimension are non-zero at least. |
| 308 | bool failedMinSize = false; |
| 309 | switch (pCreateInfo->imageType) { |
| 310 | case VK_IMAGE_TYPE_3D: |
| 311 | if (pCreateInfo->extent.depth == 0) { |
| 312 | failedMinSize = true; |
| 313 | } |
| 314 | // Intentional fall-through |
| 315 | case VK_IMAGE_TYPE_2D: |
| 316 | if (pCreateInfo->extent.height == 0) { |
| 317 | failedMinSize = true; |
| 318 | } |
| 319 | // Intentional fall-through |
| 320 | case VK_IMAGE_TYPE_1D: |
| 321 | if (pCreateInfo->extent.width == 0) { |
| 322 | failedMinSize = true; |
| 323 | } |
| 324 | break; |
| 325 | default: |
| 326 | break; |
| 327 | } |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 328 | // TODO: VALIDATION_ERROR_00716 |
| 329 | // this is *almost* VU 00716, except should not be condidtional on image type - all extents must be non-zero for all types |
Mark Young | c48c4c1 | 2016-04-11 14:26:49 -0600 | [diff] [blame] | 330 | if (failedMinSize) { |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 331 | skip_call |= |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 332 | log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 0, __LINE__, |
| 333 | IMAGE_INVALID_FORMAT_LIMITS_VIOLATION, "Image", |
Mark Young | c48c4c1 | 2016-04-11 14:26:49 -0600 | [diff] [blame] | 334 | "CreateImage extents is 0 for at least one required dimension for image of type %d: " |
| 335 | "Width = %d Height = %d Depth = %d.", |
| 336 | pCreateInfo->imageType, pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth); |
| 337 | } |
| 338 | |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 339 | // TODO: VALIDATION_ERROR_02125 VALIDATION_ERROR_02126 VALIDATION_ERROR_02128 VALIDATION_ERROR_00720 |
| 340 | // All these extent-related VUs should be checked here |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 341 | if ((pCreateInfo->extent.depth > ImageFormatProperties.maxExtent.depth) || |
| 342 | (pCreateInfo->extent.width > ImageFormatProperties.maxExtent.width) || |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 343 | (pCreateInfo->extent.height > ImageFormatProperties.maxExtent.height)) { |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 344 | skip_call |= log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 0, |
| 345 | __LINE__, IMAGE_INVALID_FORMAT_LIMITS_VIOLATION, "Image", |
| 346 | "CreateImage extents exceed allowable limits for format: " |
| 347 | "Width = %d Height = %d Depth = %d: Limits for Width = %d Height = %d Depth = %d for format %s.", |
| 348 | pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth, |
| 349 | ImageFormatProperties.maxExtent.width, ImageFormatProperties.maxExtent.height, |
| 350 | ImageFormatProperties.maxExtent.depth, string_VkFormat(pCreateInfo->format)); |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 351 | } |
| 352 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 353 | uint64_t totalSize = ((uint64_t)pCreateInfo->extent.width * (uint64_t)pCreateInfo->extent.height * |
| 354 | (uint64_t)pCreateInfo->extent.depth * (uint64_t)pCreateInfo->arrayLayers * |
| 355 | (uint64_t)pCreateInfo->samples * (uint64_t)vk_format_get_size(pCreateInfo->format) + |
| 356 | (uint64_t)imageGranularity) & |
| 357 | ~(uint64_t)imageGranularity; |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 358 | |
| 359 | if (totalSize > ImageFormatProperties.maxResourceSize) { |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 360 | skip_call |= log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 0, |
| 361 | __LINE__, IMAGE_INVALID_FORMAT_LIMITS_VIOLATION, "Image", |
| 362 | "CreateImage resource size exceeds allowable maximum " |
| 363 | "Image resource size = 0x%" PRIxLEAST64 ", maximum resource size = 0x%" PRIxLEAST64 " ", |
| 364 | totalSize, ImageFormatProperties.maxResourceSize); |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 365 | } |
| 366 | |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 367 | // TODO: VALIDATION_ERROR_02132 |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 368 | if (pCreateInfo->mipLevels > ImageFormatProperties.maxMipLevels) { |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 369 | skip_call |= log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 0, |
| 370 | __LINE__, IMAGE_INVALID_FORMAT_LIMITS_VIOLATION, "Image", |
| 371 | "CreateImage mipLevels=%d exceeds allowable maximum supported by format of %d", pCreateInfo->mipLevels, |
| 372 | ImageFormatProperties.maxMipLevels); |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 373 | } |
| 374 | |
| 375 | if (pCreateInfo->arrayLayers > ImageFormatProperties.maxArrayLayers) { |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 376 | skip_call |= log_msg( |
| 377 | phy_dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 0, __LINE__, |
| 378 | VALIDATION_ERROR_02133, "Image", "CreateImage arrayLayers=%d exceeds allowable maximum supported by format of %d. %s", |
| 379 | pCreateInfo->arrayLayers, ImageFormatProperties.maxArrayLayers, validation_error_map[VALIDATION_ERROR_02133]); |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 380 | } |
| 381 | |
| 382 | if ((pCreateInfo->samples & ImageFormatProperties.sampleCounts) == 0) { |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 383 | skip_call |= |
| 384 | log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 0, __LINE__, |
| 385 | VALIDATION_ERROR_02138, "Image", "CreateImage samples %s is not supported by format 0x%.8X. %s", |
| 386 | string_VkSampleCountFlagBits(pCreateInfo->samples), ImageFormatProperties.sampleCounts, |
| 387 | validation_error_map[VALIDATION_ERROR_02138]); |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 388 | } |
| 389 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 390 | if (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED && pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED) { |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 391 | skip_call |= log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 0, |
| 392 | __LINE__, VALIDATION_ERROR_00731, "Image", |
| 393 | "vkCreateImage parameter, pCreateInfo->initialLayout, must be VK_IMAGE_LAYOUT_UNDEFINED or " |
| 394 | "VK_IMAGE_LAYOUT_PREINITIALIZED. %s", |
| 395 | validation_error_map[VALIDATION_ERROR_00731]); |
Jeremy Hayes | ffc8a70 | 2016-03-01 14:01:45 -0700 | [diff] [blame] | 396 | } |
| 397 | |
Mark Lobodzinski | 9d1d6b1 | 2016-05-17 08:42:03 -0600 | [diff] [blame] | 398 | if (!skip_call) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 399 | result = device_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage); |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 400 | } |
| 401 | if (result == VK_SUCCESS) { |
Jeremy Hayes | e0ed6a2 | 2016-04-08 09:53:54 -0600 | [diff] [blame] | 402 | std::lock_guard<std::mutex> lock(global_lock); |
Chia-I Wu | e2fc552 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 403 | device_data->imageMap[*pImage] = IMAGE_STATE(pCreateInfo); |
Tobin Ehlis | ad8c446 | 2015-09-21 15:20:28 -0600 | [diff] [blame] | 404 | } |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 405 | return result; |
| 406 | } |
| 407 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 408 | VKAPI_ATTR void VKAPI_CALL DestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 409 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Jeremy Hayes | e0ed6a2 | 2016-04-08 09:53:54 -0600 | [diff] [blame] | 410 | std::unique_lock<std::mutex> lock(global_lock); |
Chia-I Wu | e2fc552 | 2015-10-26 20:04:44 +0800 | [diff] [blame] | 411 | device_data->imageMap.erase(image); |
Jeremy Hayes | e0ed6a2 | 2016-04-08 09:53:54 -0600 | [diff] [blame] | 412 | lock.unlock(); |
Chia-I Wu | f7458c5 | 2015-10-26 21:10:41 +0800 | [diff] [blame] | 413 | device_data->device_dispatch_table->DestroyImage(device, image, pAllocator); |
Tobin Ehlis | ad8c446 | 2015-09-21 15:20:28 -0600 | [diff] [blame] | 414 | } |
| 415 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 416 | VKAPI_ATTR VkResult VKAPI_CALL CreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, |
Mark Lobodzinski | f2eabc8 | 2016-08-05 11:20:21 -0600 | [diff] [blame] | 417 | const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 418 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Mark Lobodzinski | f2eabc8 | 2016-08-05 11:20:21 -0600 | [diff] [blame] | 419 | bool skip_call = false; |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 420 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 421 | for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { |
Mark Lobodzinski | 27ced8b | 2016-08-05 11:30:15 -0600 | [diff] [blame] | 422 | if (pCreateInfo->pAttachments[i].format == VK_FORMAT_UNDEFINED) { |
| 423 | std::stringstream ss; |
| 424 | ss << "vkCreateRenderPass: pCreateInfo->pAttachments[" << i << "].format is VK_FORMAT_UNDEFINED"; |
| 425 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 426 | IMAGE_RENDERPASS_INVALID_ATTACHMENT, "IMAGE", "%s", ss.str().c_str()); |
| 427 | } |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 428 | } |
| 429 | |
Mark Lobodzinski | f2eabc8 | 2016-08-05 11:20:21 -0600 | [diff] [blame] | 430 | if (skip_call) { |
Courtney Goeltzenleuchter | 52fee65 | 2015-12-10 16:41:22 -0700 | [diff] [blame] | 431 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Mark Lobodzinski | f2eabc8 | 2016-08-05 11:20:21 -0600 | [diff] [blame] | 432 | } |
Mark Lobodzinski | 2fd634c | 2015-07-29 09:21:22 -0600 | [diff] [blame] | 433 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 434 | VkResult result = my_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 435 | |
| 436 | return result; |
| 437 | } |
| 438 | |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 439 | VKAPI_ATTR void VKAPI_CALL CmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, |
| 440 | const VkClearColorValue *pColor, uint32_t rangeCount, |
| 441 | const VkImageSubresourceRange *pRanges) { |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 442 | bool skipCall = false; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 443 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | a4dc0ac | 2016-03-01 16:51:02 -0700 | [diff] [blame] | 444 | |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 445 | // For each range, image aspect must be color only |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 446 | // TODO: this is a 'must' in the spec, so there should be a VU enum for it |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 447 | for (uint32_t i = 0; i < rangeCount; i++) { |
| 448 | if (pRanges[i].aspectMask != VK_IMAGE_ASPECT_COLOR_BIT) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 449 | char const str[] = |
| 450 | "vkCmdClearColorImage aspectMasks for all subresource ranges must be set to VK_IMAGE_ASPECT_COLOR_BIT"; |
| 451 | skipCall |= |
| 452 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 453 | (uint64_t)commandBuffer, __LINE__, IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", str); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 454 | } |
| 455 | } |
| 456 | |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 457 | auto image_state = getImageState(device_data, image); |
| 458 | if (image_state) { |
| 459 | if (vk_format_is_depth_or_stencil(image_state->format)) { |
| 460 | char const str[] = "vkCmdClearColorImage called with depth/stencil image."; |
| 461 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 462 | reinterpret_cast<uint64_t &>(image), __LINE__, VALIDATION_ERROR_01088, "IMAGE", "%s. %s", str, |
| 463 | validation_error_map[VALIDATION_ERROR_01088]); |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 464 | } else if (vk_format_is_compressed(image_state->format)) { |
| 465 | char const str[] = "vkCmdClearColorImage called with compressed image."; |
| 466 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 467 | reinterpret_cast<uint64_t &>(image), __LINE__, VALIDATION_ERROR_01088, "IMAGE", "%s. %s", str, |
| 468 | validation_error_map[VALIDATION_ERROR_01088]); |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 469 | } |
Tony Barbour | 26434b9 | 2016-06-02 09:43:50 -0600 | [diff] [blame] | 470 | |
| 471 | if (!(image_state->usage & VK_IMAGE_USAGE_TRANSFER_DST_BIT)) { |
| 472 | char const str[] = "vkCmdClearColorImage called with image created without VK_IMAGE_USAGE_TRANSFER_DST_BIT."; |
| 473 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 474 | reinterpret_cast<uint64_t &>(image), __LINE__, VALIDATION_ERROR_01084, "IMAGE", "%s. %s", str, |
| 475 | validation_error_map[VALIDATION_ERROR_01084]); |
Tony Barbour | 26434b9 | 2016-06-02 09:43:50 -0600 | [diff] [blame] | 476 | } |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 477 | } |
| 478 | |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 479 | if (!skipCall) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 480 | device_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 481 | } |
| 482 | } |
| 483 | |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 484 | VKAPI_ATTR void VKAPI_CALL CmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, |
| 485 | const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, |
| 486 | const VkImageSubresourceRange *pRanges) { |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 487 | bool skipCall = false; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 488 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 489 | // For each range, Image aspect must be depth or stencil or both |
| 490 | for (uint32_t i = 0; i < rangeCount; i++) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 491 | if (((pRanges[i].aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) != VK_IMAGE_ASPECT_DEPTH_BIT) && |
| 492 | ((pRanges[i].aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT) != VK_IMAGE_ASPECT_STENCIL_BIT)) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 493 | char const str[] = "vkCmdClearDepthStencilImage aspectMasks for all subresource ranges must be " |
| 494 | "set to VK_IMAGE_ASPECT_DEPTH_BIT and/or VK_IMAGE_ASPECT_STENCIL_BIT"; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 495 | skipCall |= |
| 496 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 497 | (uint64_t)commandBuffer, __LINE__, IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", str); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 498 | } |
| 499 | } |
| 500 | |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 501 | auto image_state = getImageState(device_data, image); |
| 502 | if (image_state && !vk_format_is_depth_or_stencil(image_state->format)) { |
| 503 | char const str[] = "vkCmdClearDepthStencilImage called without a depth/stencil image."; |
| 504 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 505 | reinterpret_cast<uint64_t &>(image), __LINE__, VALIDATION_ERROR_01103, "IMAGE", "%s. %s", str, |
| 506 | validation_error_map[VALIDATION_ERROR_01103]); |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 507 | } |
| 508 | |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 509 | if (!skipCall) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 510 | device_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, |
| 511 | pRanges); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 512 | } |
| 513 | } |
| 514 | |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 515 | // Returns true if [x, xoffset] and [y, yoffset] overlap |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 516 | static bool RangesIntersect(int32_t start, uint32_t start_offset, int32_t end, uint32_t end_offset) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 517 | bool result = false; |
| 518 | uint32_t intersection_min = std::max(static_cast<uint32_t>(start), static_cast<uint32_t>(end)); |
| 519 | uint32_t intersection_max = std::min(static_cast<uint32_t>(start) + start_offset, static_cast<uint32_t>(end) + end_offset); |
| 520 | |
| 521 | if (intersection_max > intersection_min) { |
| 522 | result = true; |
| 523 | } |
| 524 | return result; |
| 525 | } |
| 526 | |
| 527 | // Returns true if two VkImageCopy structures overlap |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 528 | static bool RegionIntersects(const VkImageCopy *src, const VkImageCopy *dst, VkImageType type) { |
Alex Smith | 7b56744 | 2017-01-17 11:13:23 +0000 | [diff] [blame^] | 529 | bool result = false; |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 530 | if ((src->srcSubresource.mipLevel == dst->dstSubresource.mipLevel) && |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 531 | (RangesIntersect(src->srcSubresource.baseArrayLayer, src->srcSubresource.layerCount, dst->dstSubresource.baseArrayLayer, |
| 532 | dst->dstSubresource.layerCount))) { |
Alex Smith | 7b56744 | 2017-01-17 11:13:23 +0000 | [diff] [blame^] | 533 | result = true; |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 534 | switch (type) { |
| 535 | case VK_IMAGE_TYPE_3D: |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 536 | result &= RangesIntersect(src->srcOffset.z, src->extent.depth, dst->dstOffset.z, dst->extent.depth); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 537 | // Intentionally fall through to 2D case |
| 538 | case VK_IMAGE_TYPE_2D: |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 539 | result &= RangesIntersect(src->srcOffset.y, src->extent.height, dst->dstOffset.y, dst->extent.height); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 540 | // Intentionally fall through to 1D case |
| 541 | case VK_IMAGE_TYPE_1D: |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 542 | result &= RangesIntersect(src->srcOffset.x, src->extent.width, dst->dstOffset.x, dst->extent.width); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 543 | break; |
| 544 | default: |
| 545 | // Unrecognized or new IMAGE_TYPE enums will be caught in parameter_validation |
| 546 | assert(false); |
| 547 | } |
| 548 | } |
| 549 | return result; |
| 550 | } |
| 551 | |
| 552 | // Returns true if offset and extent exceed image extents |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 553 | static bool ExceedsBounds(const VkOffset3D *offset, const VkExtent3D *extent, const IMAGE_STATE *image) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 554 | bool result = false; |
| 555 | // Extents/depths cannot be negative but checks left in for clarity |
Mark Lobodzinski | 39573d2 | 2016-10-14 10:59:27 -0600 | [diff] [blame] | 556 | switch (image->imageType) { |
| 557 | case VK_IMAGE_TYPE_3D: // Validate z and depth |
| 558 | if ((offset->z + extent->depth > image->extent.depth) || (offset->z < 0) || |
| 559 | ((offset->z + static_cast<int32_t>(extent->depth)) < 0)) { |
| 560 | result = true; |
| 561 | } |
| 562 | // Intentionally fall through to 2D case to check height |
| 563 | case VK_IMAGE_TYPE_2D: // Validate y and height |
| 564 | if ((offset->y + extent->height > image->extent.height) || (offset->y < 0) || |
| 565 | ((offset->y + static_cast<int32_t>(extent->height)) < 0)) { |
| 566 | result = true; |
| 567 | } |
| 568 | // Intentionally fall through to 1D case to check width |
| 569 | case VK_IMAGE_TYPE_1D: // Validate x and width |
| 570 | if ((offset->x + extent->width > image->extent.width) || (offset->x < 0) || |
| 571 | ((offset->x + static_cast<int32_t>(extent->width)) < 0)) { |
| 572 | result = true; |
| 573 | } |
| 574 | break; |
| 575 | default: |
| 576 | assert(false); |
| 577 | } |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 578 | return result; |
| 579 | } |
| 580 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 581 | bool PreCallValidateCmdCopyImage(VkCommandBuffer command_buffer, VkImage src_image, VkImage dst_image, uint32_t region_count, |
| 582 | const VkImageCopy *regions) { |
| 583 | bool skip = false; |
| 584 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(command_buffer), layer_data_map); |
| 585 | auto src_image_entry = getImageState(device_data, src_image); |
| 586 | auto dst_image_entry = getImageState(device_data, dst_image); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 587 | |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 588 | // TODO: This does not cover swapchain-created images. This should fall out when this layer is moved |
| 589 | // into the core_validation layer |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 590 | if (src_image_entry && dst_image_entry) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 591 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 592 | for (uint32_t i = 0; i < region_count; i++) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 593 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 594 | if (regions[i].srcSubresource.layerCount == 0) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 595 | std::stringstream ss; |
| 596 | ss << "vkCmdCopyImage: number of layers in pRegions[" << i << "] srcSubresource is zero"; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 597 | skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| 598 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t &>(command_buffer), |
| 599 | __LINE__, IMAGE_MISMATCHED_IMAGE_ASPECT, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 600 | } |
| 601 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 602 | if (regions[i].dstSubresource.layerCount == 0) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 603 | std::stringstream ss; |
| 604 | ss << "vkCmdCopyImage: number of layers in pRegions[" << i << "] dstSubresource is zero"; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 605 | skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| 606 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t &>(command_buffer), |
| 607 | __LINE__, IMAGE_MISMATCHED_IMAGE_ASPECT, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 608 | } |
| 609 | |
| 610 | // For each region the layerCount member of srcSubresource and dstSubresource must match |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 611 | if (regions[i].srcSubresource.layerCount != regions[i].dstSubresource.layerCount) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 612 | std::stringstream ss; |
| 613 | ss << "vkCmdCopyImage: number of layers in source and destination subresources for pRegions[" << i |
| 614 | << "] do not match"; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 615 | skip |= |
Mark Lobodzinski | a9a69ad | 2016-10-14 12:13:33 -0600 | [diff] [blame] | 616 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 617 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, VALIDATION_ERROR_01198, "IMAGE", "%s. %s", |
Mark Lobodzinski | a9a69ad | 2016-10-14 12:13:33 -0600 | [diff] [blame] | 618 | ss.str().c_str(), validation_error_map[VALIDATION_ERROR_01198]); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 619 | } |
| 620 | |
| 621 | // For each region, the aspectMask member of srcSubresource and dstSubresource must match |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 622 | if (regions[i].srcSubresource.aspectMask != regions[i].dstSubresource.aspectMask) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 623 | char const str[] = "vkCmdCopyImage: Src and dest aspectMasks for each region must match"; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 624 | skip |= |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 625 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 626 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, VALIDATION_ERROR_01197, "IMAGE", "%s. %s", str, |
| 627 | validation_error_map[VALIDATION_ERROR_01197]); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 628 | } |
| 629 | |
| 630 | // AspectMask must not contain VK_IMAGE_ASPECT_METADATA_BIT |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 631 | if ((regions[i].srcSubresource.aspectMask & VK_IMAGE_ASPECT_METADATA_BIT) || |
| 632 | (regions[i].dstSubresource.aspectMask & VK_IMAGE_ASPECT_METADATA_BIT)) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 633 | std::stringstream ss; |
| 634 | ss << "vkCmdCopyImage: pRegions[" << i << "] may not specify aspectMask containing VK_IMAGE_ASPECT_METADATA_BIT"; |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 635 | skip |= |
| 636 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 637 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, VALIDATION_ERROR_01222, "IMAGE", "%s. %s", |
| 638 | ss.str().c_str(), validation_error_map[VALIDATION_ERROR_01222]); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 639 | } |
| 640 | |
| 641 | // For each region, if aspectMask contains VK_IMAGE_ASPECT_COLOR_BIT, it must not contain either of |
| 642 | // VK_IMAGE_ASPECT_DEPTH_BIT or VK_IMAGE_ASPECT_STENCIL_BIT |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 643 | if ((regions[i].srcSubresource.aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) && |
| 644 | (regions[i].srcSubresource.aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT))) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 645 | char const str[] = "vkCmdCopyImage aspectMask cannot specify both COLOR and DEPTH/STENCIL aspects"; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 646 | skip |= |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 647 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 648 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, VALIDATION_ERROR_01221, "IMAGE", "%s. %s", str, |
| 649 | validation_error_map[VALIDATION_ERROR_01221]); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 650 | } |
| 651 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 652 | // If either of the calling command's src_image or dst_image parameters are of VkImageType VK_IMAGE_TYPE_3D, |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 653 | // the baseArrayLayer and layerCount members of both srcSubresource and dstSubresource must be 0 and 1, respectively |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 654 | if (((src_image_entry->imageType == VK_IMAGE_TYPE_3D) || (dst_image_entry->imageType == VK_IMAGE_TYPE_3D)) && |
| 655 | ((regions[i].srcSubresource.baseArrayLayer != 0) || (regions[i].srcSubresource.layerCount != 1) || |
| 656 | (regions[i].dstSubresource.baseArrayLayer != 0) || (regions[i].dstSubresource.layerCount != 1))) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 657 | std::stringstream ss; |
| 658 | ss << "vkCmdCopyImage: src or dstImage type was IMAGE_TYPE_3D, but in subRegion[" << i |
| 659 | << "] baseArrayLayer was not zero or layerCount was not 1."; |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 660 | skip |= |
| 661 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 662 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, VALIDATION_ERROR_01199, "IMAGE", "%s. %s", |
| 663 | ss.str().c_str(), validation_error_map[VALIDATION_ERROR_01199]); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 664 | } |
| 665 | |
| 666 | // MipLevel must be less than the mipLevels specified in VkImageCreateInfo when the image was created |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 667 | if (regions[i].srcSubresource.mipLevel >= src_image_entry->mipLevels) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 668 | std::stringstream ss; |
| 669 | ss << "vkCmdCopyImage: pRegions[" << i |
| 670 | << "] specifies a src mipLevel greater than the number specified when the srcImage was created."; |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 671 | skip |= |
| 672 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 673 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, VALIDATION_ERROR_01223, "IMAGE", "%s. %s", |
| 674 | ss.str().c_str(), validation_error_map[VALIDATION_ERROR_01223]); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 675 | } |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 676 | if (regions[i].dstSubresource.mipLevel >= dst_image_entry->mipLevels) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 677 | std::stringstream ss; |
| 678 | ss << "vkCmdCopyImage: pRegions[" << i |
| 679 | << "] specifies a dst mipLevel greater than the number specified when the dstImage was created."; |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 680 | skip |= |
| 681 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 682 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, VALIDATION_ERROR_01223, "IMAGE", "%s. %s", |
| 683 | ss.str().c_str(), validation_error_map[VALIDATION_ERROR_01223]); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 684 | } |
| 685 | |
| 686 | // (baseArrayLayer + layerCount) must be less than or equal to the arrayLayers specified in VkImageCreateInfo when the |
| 687 | // image was created |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 688 | if ((regions[i].srcSubresource.baseArrayLayer + regions[i].srcSubresource.layerCount) > src_image_entry->arraySize) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 689 | std::stringstream ss; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 690 | ss << "vkCmdCopyImage: srcImage arrayLayers was " << src_image_entry->arraySize << " but subRegion[" << i |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 691 | << "] baseArrayLayer + layerCount is " |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 692 | << (regions[i].srcSubresource.baseArrayLayer + regions[i].srcSubresource.layerCount); |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 693 | skip |= |
| 694 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 695 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, VALIDATION_ERROR_01224, "IMAGE", "%s. %s", |
| 696 | ss.str().c_str(), validation_error_map[VALIDATION_ERROR_01224]); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 697 | } |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 698 | if ((regions[i].dstSubresource.baseArrayLayer + regions[i].dstSubresource.layerCount) > dst_image_entry->arraySize) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 699 | std::stringstream ss; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 700 | ss << "vkCmdCopyImage: dstImage arrayLayers was " << dst_image_entry->arraySize << " but subRegion[" << i |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 701 | << "] baseArrayLayer + layerCount is " |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 702 | << (regions[i].dstSubresource.baseArrayLayer + regions[i].dstSubresource.layerCount); |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 703 | skip |= |
| 704 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 705 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, VALIDATION_ERROR_01224, "IMAGE", "%s. %s", |
| 706 | ss.str().c_str(), validation_error_map[VALIDATION_ERROR_01224]); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 707 | } |
| 708 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 709 | // The source region specified by a given element of regions must be a region that is contained within srcImage |
| 710 | if (ExceedsBounds(®ions[i].srcOffset, ®ions[i].extent, src_image_entry)) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 711 | std::stringstream ss; |
| 712 | ss << "vkCmdCopyImage: srcSubResource in pRegions[" << i << "] exceeds extents srcImage was created with"; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 713 | skip |= |
Mark Lobodzinski | 8ea6eb0 | 2016-10-14 11:40:31 -0600 | [diff] [blame] | 714 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 715 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, VALIDATION_ERROR_01175, "IMAGE", "%s. %s", |
Tobin Ehlis | 15edfa8 | 2016-10-18 07:31:22 -0600 | [diff] [blame] | 716 | ss.str().c_str(), validation_error_map[VALIDATION_ERROR_01175]); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 717 | } |
| 718 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 719 | // The destination region specified by a given element of regions must be a region that is contained within dst_image |
| 720 | if (ExceedsBounds(®ions[i].dstOffset, ®ions[i].extent, dst_image_entry)) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 721 | std::stringstream ss; |
| 722 | ss << "vkCmdCopyImage: dstSubResource in pRegions[" << i << "] exceeds extents dstImage was created with"; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 723 | skip |= |
Mark Lobodzinski | 8ea6eb0 | 2016-10-14 11:40:31 -0600 | [diff] [blame] | 724 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 725 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, VALIDATION_ERROR_01176, "IMAGE", "%s. %s", |
Mark Lobodzinski | 8ea6eb0 | 2016-10-14 11:40:31 -0600 | [diff] [blame] | 726 | ss.str().c_str(), validation_error_map[VALIDATION_ERROR_01176]); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 727 | } |
| 728 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 729 | // The union of all source regions, and the union of all destination regions, specified by the elements of regions, |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 730 | // must not overlap in memory |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 731 | if (src_image == dst_image) { |
| 732 | for (uint32_t j = 0; j < region_count; j++) { |
| 733 | if (RegionIntersects(®ions[i], ®ions[j], src_image_entry->imageType)) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 734 | std::stringstream ss; |
| 735 | ss << "vkCmdCopyImage: pRegions[" << i << "] src overlaps with pRegions[" << j << "]."; |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 736 | skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 737 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 738 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, VALIDATION_ERROR_01177, "IMAGE", |
| 739 | "%s. %s", ss.str().c_str(), validation_error_map[VALIDATION_ERROR_01177]); |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 740 | } |
| 741 | } |
| 742 | } |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 743 | } |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 744 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 745 | // The formats of src_image and dst_image must be compatible. Formats are considered compatible if their texel size in bytes |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 746 | // is the same between both formats. For example, VK_FORMAT_R8G8B8A8_UNORM is compatible with VK_FORMAT_R32_UINT because |
| 747 | // because both texels are 4 bytes in size. Depth/stencil formats must match exactly. |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 748 | if (vk_format_is_depth_or_stencil(src_image_entry->format) || vk_format_is_depth_or_stencil(dst_image_entry->format)) { |
| 749 | if (src_image_entry->format != dst_image_entry->format) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 750 | char const str[] = "vkCmdCopyImage called with unmatched source and dest image depth/stencil formats."; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 751 | skip |= |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 752 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 753 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, IMAGE_MISMATCHED_IMAGE_FORMAT, "IMAGE", str); |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 754 | } |
| 755 | } else { |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 756 | size_t srcSize = vk_format_get_size(src_image_entry->format); |
| 757 | size_t destSize = vk_format_get_size(dst_image_entry->format); |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 758 | if (srcSize != destSize) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 759 | char const str[] = "vkCmdCopyImage called with unmatched source and dest image format sizes."; |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 760 | skip |= |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 761 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 762 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, VALIDATION_ERROR_01184, "IMAGE", "%s. %s", str, |
Tobin Ehlis | 15edfa8 | 2016-10-18 07:31:22 -0600 | [diff] [blame] | 763 | validation_error_map[VALIDATION_ERROR_01184]); |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 764 | } |
| 765 | } |
| 766 | } |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 767 | return skip; |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 768 | } |
| 769 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 770 | VKAPI_ATTR void VKAPI_CALL CmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, |
| 771 | VkImageLayout srcImageLayout, VkImage dstImage, |
| 772 | VkImageLayout dstImageLayout, uint32_t regionCount, |
| 773 | const VkImageCopy *pRegions) { |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 774 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 775 | bool skip = false; |
Mark Lobodzinski | b2ad702 | 2016-03-29 17:10:14 -0600 | [diff] [blame] | 776 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 777 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 778 | skip = PreCallValidateCmdCopyImage(commandBuffer, srcImage, dstImage, regionCount, pRegions); |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 779 | |
Mark Lobodzinski | a9920fb | 2016-10-14 13:09:48 -0600 | [diff] [blame] | 780 | if (!skip) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 781 | device_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, |
| 782 | regionCount, pRegions); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 783 | } |
| 784 | } |
| 785 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 786 | VKAPI_ATTR void VKAPI_CALL CmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, |
| 787 | const VkClearAttachment *pAttachments, uint32_t rectCount, |
| 788 | const VkClearRect *pRects) { |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 789 | bool skipCall = false; |
Courtney Goeltzenleuchter | c9323e0 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 790 | VkImageAspectFlags aspectMask; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 791 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Courtney Goeltzenleuchter | c9323e0 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 792 | for (uint32_t i = 0; i < attachmentCount; i++) { |
| 793 | aspectMask = pAttachments[i].aspectMask; |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 794 | if (0 == aspectMask) { |
| 795 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 796 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 797 | VALIDATION_ERROR_01128, "IMAGE", "%s", validation_error_map[VALIDATION_ERROR_01128]); |
| 798 | } else if (aspectMask & VK_IMAGE_ASPECT_METADATA_BIT) { |
| 799 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 800 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 801 | VALIDATION_ERROR_01126, "IMAGE", "%s", validation_error_map[VALIDATION_ERROR_01126]); |
| 802 | } else if (aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { |
| 803 | if ((aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) || (aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT)) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 804 | char const str[] = |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 805 | "vkCmdClearAttachments aspectMask [%d] must set only VK_IMAGE_ASPECT_COLOR_BIT of a color attachment. %s"; |
| 806 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 807 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 808 | VALIDATION_ERROR_01125, "IMAGE", str, i, validation_error_map[VALIDATION_ERROR_01125]); |
Courtney Goeltzenleuchter | c9323e0 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 809 | } |
| 810 | } else { |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 811 | // Having eliminated all other possibilities, image aspect must be depth or stencil or both |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 812 | if (((aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) != VK_IMAGE_ASPECT_DEPTH_BIT) && |
| 813 | ((aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT) != VK_IMAGE_ASPECT_STENCIL_BIT)) { |
| 814 | char const str[] = "vkCmdClearAttachments aspectMask [%d] must be set to VK_IMAGE_ASPECT_DEPTH_BIT and/or " |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 815 | "VK_IMAGE_ASPECT_STENCIL_BIT. %s"; |
| 816 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 817 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 818 | VALIDATION_ERROR_01127, "IMAGE", str, i, validation_error_map[VALIDATION_ERROR_01127]); |
Courtney Goeltzenleuchter | c9323e0 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 819 | } |
| 820 | } |
| 821 | } |
| 822 | |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 823 | if (!skipCall) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 824 | device_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); |
Courtney Goeltzenleuchter | c9323e0 | 2015-10-15 16:51:05 -0600 | [diff] [blame] | 825 | } |
| 826 | } |
| 827 | |
Mark Lobodzinski | 576d839 | 2016-11-22 10:44:37 -0700 | [diff] [blame] | 828 | static bool ValidateBufferImageCopyData(layer_data *dev_data, uint32_t regionCount, const VkBufferImageCopy *pRegions, |
| 829 | VkImage image, const char *function) { |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 830 | bool skip = false; |
| 831 | |
| 832 | for (uint32_t i = 0; i < regionCount; i++) { |
| 833 | |
| 834 | auto image_info = getImageState(dev_data, image); |
| 835 | if (image_info) { |
Mark Lobodzinski | 1bda889 | 2016-11-22 14:46:39 -0700 | [diff] [blame] | 836 | |
| 837 | if ((image_info->imageType == VK_IMAGE_TYPE_1D) || (image_info->imageType == VK_IMAGE_TYPE_2D)) { |
| 838 | if ((pRegions[i].imageOffset.z != 0) || (pRegions[i].imageExtent.depth != 1)) { |
| 839 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 840 | reinterpret_cast<uint64_t &>(image), __LINE__, VALIDATION_ERROR_01269, "IMAGE", |
| 841 | "%s(): pRegion[%d] imageOffset.z is %d and imageExtent.depth is %d. These must be 0 and 1, " |
| 842 | "respectively. %s", |
| 843 | function, i, pRegions[i].imageOffset.z, pRegions[i].imageExtent.depth, |
| 844 | validation_error_map[VALIDATION_ERROR_01269]); |
| 845 | } |
| 846 | } |
| 847 | |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 848 | // BufferOffset must be a multiple of the calling command's VkImage parameter's texel size |
| 849 | auto texel_size = vk_format_get_size(image_info->format); |
| 850 | if (vk_safe_modulo(pRegions[i].bufferOffset, texel_size) != 0) { |
| 851 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | 576d839 | 2016-11-22 10:44:37 -0700 | [diff] [blame] | 852 | reinterpret_cast<uint64_t &>(image), __LINE__, VALIDATION_ERROR_01263, "IMAGE", |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 853 | "%s(): pRegion[%d] bufferOffset 0x%" PRIxLEAST64 |
Mark Lobodzinski | 576d839 | 2016-11-22 10:44:37 -0700 | [diff] [blame] | 854 | " must be a multiple of this format's texel size (" PRINTF_SIZE_T_SPECIFIER "). %s", |
| 855 | function, i, pRegions[i].bufferOffset, texel_size, validation_error_map[VALIDATION_ERROR_01263]); |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 856 | } |
Mark Lobodzinski | 1bda889 | 2016-11-22 14:46:39 -0700 | [diff] [blame] | 857 | |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 858 | // BufferOffset must be a multiple of 4 |
| 859 | if (vk_safe_modulo(pRegions[i].bufferOffset, 4) != 0) { |
| 860 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | 576d839 | 2016-11-22 10:44:37 -0700 | [diff] [blame] | 861 | reinterpret_cast<uint64_t &>(image), __LINE__, VALIDATION_ERROR_01264, "IMAGE", |
| 862 | "%s(): pRegion[%d] bufferOffset 0x%" PRIxLEAST64 " must be a multiple of 4. %s", function, i, |
| 863 | pRegions[i].bufferOffset, validation_error_map[VALIDATION_ERROR_01264]); |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 864 | } |
| 865 | |
| 866 | // BufferRowLength must be 0, or greater than or equal to the width member of imageExtent |
| 867 | if ((pRegions[i].bufferRowLength != 0) && (pRegions[i].bufferRowLength < pRegions[i].imageExtent.width)) { |
| 868 | skip |= log_msg( |
| 869 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | 576d839 | 2016-11-22 10:44:37 -0700 | [diff] [blame] | 870 | reinterpret_cast<uint64_t &>(image), __LINE__, VALIDATION_ERROR_01265, "IMAGE", |
| 871 | "%s(): pRegion[%d] bufferRowLength (%d) must be zero or greater-than-or-equal-to imageExtent.width (%d). %s", |
| 872 | function, i, pRegions[i].bufferRowLength, pRegions[i].imageExtent.width, |
| 873 | validation_error_map[VALIDATION_ERROR_01265]); |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 874 | } |
| 875 | |
| 876 | // BufferImageHeight must be 0, or greater than or equal to the height member of imageExtent |
| 877 | if ((pRegions[i].bufferImageHeight != 0) && (pRegions[i].bufferImageHeight < pRegions[i].imageExtent.height)) { |
| 878 | skip |= log_msg( |
| 879 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | 576d839 | 2016-11-22 10:44:37 -0700 | [diff] [blame] | 880 | reinterpret_cast<uint64_t &>(image), __LINE__, VALIDATION_ERROR_01266, "IMAGE", |
| 881 | "%s(): pRegion[%d] bufferImageHeight (%d) must be zero or greater-than-or-equal-to imageExtent.height (%d). %s", |
| 882 | function, i, pRegions[i].bufferImageHeight, pRegions[i].imageExtent.height, |
| 883 | validation_error_map[VALIDATION_ERROR_01266]); |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 884 | } |
Mark Lobodzinski | 040142c | 2016-11-22 11:18:46 -0700 | [diff] [blame] | 885 | |
| 886 | const int num_bits = sizeof(VkFlags) * CHAR_BIT; |
Mark Lobodzinski | 3702e93 | 2016-11-22 11:40:48 -0700 | [diff] [blame] | 887 | std::bitset<num_bits> aspect_mask_bits(pRegions[i].imageSubresource.aspectMask); |
Mark Lobodzinski | 040142c | 2016-11-22 11:18:46 -0700 | [diff] [blame] | 888 | if (aspect_mask_bits.count() != 1) { |
| 889 | skip |= |
| 890 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 891 | reinterpret_cast<uint64_t &>(image), __LINE__, VALIDATION_ERROR_01280, "IMAGE", |
| 892 | "%s: aspectMasks for imageSubresource in each region must have only a single bit set. %s", function, |
| 893 | validation_error_map[VALIDATION_ERROR_01280]); |
| 894 | } |
Mark Lobodzinski | a0efcdd | 2016-08-19 08:50:15 -0600 | [diff] [blame] | 895 | } |
| 896 | } |
| 897 | |
| 898 | return skip; |
| 899 | } |
| 900 | |
Mark Lobodzinski | 3702e93 | 2016-11-22 11:40:48 -0700 | [diff] [blame] | 901 | static bool PreCallValidateCmdCopyImageToBuffer(layer_data *dev_data, VkImage srcImage, uint32_t regionCount, |
Mark Lobodzinski | 39b8328 | 2016-11-22 09:33:23 -0700 | [diff] [blame] | 902 | const VkBufferImageCopy *pRegions, const char *func_name) { |
Mark Lobodzinski | 3702e93 | 2016-11-22 11:40:48 -0700 | [diff] [blame] | 903 | return ValidateBufferImageCopyData(dev_data, regionCount, pRegions, srcImage, "vkCmdCopyImageToBuffer"); |
Mark Lobodzinski | 39b8328 | 2016-11-22 09:33:23 -0700 | [diff] [blame] | 904 | } |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 905 | |
Mark Lobodzinski | 39b8328 | 2016-11-22 09:33:23 -0700 | [diff] [blame] | 906 | VKAPI_ATTR void VKAPI_CALL CmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, |
| 907 | VkBuffer dstBuffer, uint32_t regionCount, const VkBufferImageCopy *pRegions) { |
| 908 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 909 | |
Mark Lobodzinski | 3702e93 | 2016-11-22 11:40:48 -0700 | [diff] [blame] | 910 | if (!PreCallValidateCmdCopyImageToBuffer(device_data, srcImage, regionCount, pRegions, "vkCmdCopyImageToBuffer()")) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 911 | device_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, |
| 912 | pRegions); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 913 | } |
| 914 | } |
| 915 | |
Mark Lobodzinski | 3702e93 | 2016-11-22 11:40:48 -0700 | [diff] [blame] | 916 | static bool PreCallValidateCmdCopyBufferToImage(layer_data *dev_data, VkImage dstImage, uint32_t regionCount, |
Mark Lobodzinski | 39b8328 | 2016-11-22 09:33:23 -0700 | [diff] [blame] | 917 | const VkBufferImageCopy *pRegions, const char *func_name) { |
Mark Lobodzinski | 3702e93 | 2016-11-22 11:40:48 -0700 | [diff] [blame] | 918 | return ValidateBufferImageCopyData(dev_data, regionCount, pRegions, dstImage, "vkCmdCopyBufferToImage"); |
Mark Lobodzinski | 39b8328 | 2016-11-22 09:33:23 -0700 | [diff] [blame] | 919 | } |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 920 | |
Mark Lobodzinski | 39b8328 | 2016-11-22 09:33:23 -0700 | [diff] [blame] | 921 | VKAPI_ATTR void VKAPI_CALL CmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkImage dstImage, |
| 922 | VkImageLayout dstImageLayout, uint32_t regionCount, |
| 923 | const VkBufferImageCopy *pRegions) { |
| 924 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 925 | |
Mark Lobodzinski | 3702e93 | 2016-11-22 11:40:48 -0700 | [diff] [blame] | 926 | if (!PreCallValidateCmdCopyBufferToImage(device_data, dstImage, regionCount, pRegions, "vkCmdCopyBufferToImage()")) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 927 | device_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, |
| 928 | pRegions); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 929 | } |
| 930 | } |
| 931 | |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 932 | VKAPI_ATTR void VKAPI_CALL CmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, |
| 933 | VkImage dstImage, VkImageLayout dstImageLayout, uint32_t regionCount, |
| 934 | const VkImageBlit *pRegions, VkFilter filter) { |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 935 | bool skipCall = false; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 936 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 937 | |
Mark Lobodzinski | 1af172a | 2016-08-16 11:51:12 -0600 | [diff] [blame] | 938 | // Warn for zero-sized regions |
| 939 | for (uint32_t i = 0; i < regionCount; i++) { |
| 940 | if ((pRegions[i].srcOffsets[0].x == pRegions[i].srcOffsets[1].x) || |
| 941 | (pRegions[i].srcOffsets[0].y == pRegions[i].srcOffsets[1].y) || |
| 942 | (pRegions[i].srcOffsets[0].z == pRegions[i].srcOffsets[1].z)) { |
| 943 | std::stringstream ss; |
| 944 | ss << "vkCmdBlitImage: pRegions[" << i << "].srcOffsets specify a zero-volume area."; |
| 945 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 946 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), __LINE__, |
| 947 | IMAGE_INVALID_EXTENTS, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | 1af172a | 2016-08-16 11:51:12 -0600 | [diff] [blame] | 948 | } |
| 949 | if ((pRegions[i].dstOffsets[0].x == pRegions[i].dstOffsets[1].x) || |
| 950 | (pRegions[i].dstOffsets[0].y == pRegions[i].dstOffsets[1].y) || |
| 951 | (pRegions[i].dstOffsets[0].z == pRegions[i].dstOffsets[1].z)) { |
| 952 | std::stringstream ss; |
| 953 | ss << "vkCmdBlitImage: pRegions[" << i << "].dstOffsets specify a zero-volume area."; |
| 954 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 955 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), __LINE__, |
| 956 | IMAGE_INVALID_EXTENTS, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | 1af172a | 2016-08-16 11:51:12 -0600 | [diff] [blame] | 957 | } |
| 958 | } |
| 959 | |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 960 | auto srcImageEntry = getImageState(device_data, srcImage); |
| 961 | auto dstImageEntry = getImageState(device_data, dstImage); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 962 | |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 963 | if (srcImageEntry && dstImageEntry) { |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 964 | |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 965 | VkFormat srcFormat = srcImageEntry->format; |
| 966 | VkFormat dstFormat = dstImageEntry->format; |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 967 | |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 968 | // Validate consistency for unsigned formats |
| 969 | if (vk_format_is_uint(srcFormat) != vk_format_is_uint(dstFormat)) { |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 970 | std::stringstream ss; |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 971 | ss << "vkCmdBlitImage: If one of srcImage and dstImage images has unsigned integer format, " |
| 972 | << "the other one must also have unsigned integer format. " |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 973 | << "Source format is " << string_VkFormat(srcFormat) << " Destination format is " << string_VkFormat(dstFormat); |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 974 | skipCall |= |
| 975 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 976 | (uint64_t)commandBuffer, __LINE__, VALIDATION_ERROR_02191, "IMAGE", "%s. %s", ss.str().c_str(), |
| 977 | validation_error_map[VALIDATION_ERROR_02191]); |
| 978 | } |
| 979 | |
| 980 | // Validate consistency for signed formats |
| 981 | if (vk_format_is_sint(srcFormat) != vk_format_is_sint(dstFormat)) { |
| 982 | std::stringstream ss; |
| 983 | ss << "vkCmdBlitImage: If one of srcImage and dstImage images has signed integer format, " |
| 984 | << "the other one must also have signed integer format. " |
| 985 | << "Source format is " << string_VkFormat(srcFormat) << " Destination format is " << string_VkFormat(dstFormat); |
| 986 | skipCall |= |
| 987 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 988 | (uint64_t)commandBuffer, __LINE__, VALIDATION_ERROR_02190, "IMAGE", "%s. %s", ss.str().c_str(), |
| 989 | validation_error_map[VALIDATION_ERROR_02190]); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 990 | } |
| 991 | |
| 992 | // Validate aspect bits and formats for depth/stencil images |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 993 | if (vk_format_is_depth_or_stencil(srcFormat) || vk_format_is_depth_or_stencil(dstFormat)) { |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 994 | if (srcFormat != dstFormat) { |
| 995 | std::stringstream ss; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 996 | ss << "vkCmdBlitImage: If one of srcImage and dstImage images has a format of depth, stencil or depth " |
| 997 | << "stencil, the other one must have exactly the same format. " |
| 998 | << "Source format is " << string_VkFormat(srcFormat) << " Destination format is " << string_VkFormat(dstFormat); |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 999 | skipCall |= |
| 1000 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 1001 | (uint64_t)commandBuffer, __LINE__, VALIDATION_ERROR_02192, "IMAGE", "%s. %s", ss.str().c_str(), |
| 1002 | validation_error_map[VALIDATION_ERROR_02192]); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1003 | } |
| 1004 | |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 1005 | // TODO: Confirm that all these checks are intended to be nested under depth/stencil only |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1006 | for (uint32_t i = 0; i < regionCount; i++) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1007 | if (pRegions[i].srcSubresource.layerCount == 0) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1008 | char const str[] = "vkCmdBlitImage: number of layers in source subresource is zero"; |
| 1009 | // TODO: Verify against Valid Use section of spec, if this case yields undefined results, then it's an error |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1010 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 1011 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 1012 | IMAGE_MISMATCHED_IMAGE_ASPECT, "IMAGE", str); |
Jeremy Hayes | 148bab2 | 2015-10-28 13:01:39 -0600 | [diff] [blame] | 1013 | } |
| 1014 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1015 | if (pRegions[i].dstSubresource.layerCount == 0) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1016 | char const str[] = "vkCmdBlitImage: number of layers in destination subresource is zero"; |
| 1017 | // TODO: Verify against Valid Use section of spec, if this case yields undefined results, then it's an error |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1018 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 1019 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 1020 | IMAGE_MISMATCHED_IMAGE_ASPECT, "IMAGE", str); |
Jeremy Hayes | 148bab2 | 2015-10-28 13:01:39 -0600 | [diff] [blame] | 1021 | } |
| 1022 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1023 | if (pRegions[i].srcSubresource.layerCount != pRegions[i].dstSubresource.layerCount) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1024 | char const str[] = "vkCmdBlitImage: number of layers in source and destination subresources must match"; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1025 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 1026 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 1027 | IMAGE_MISMATCHED_IMAGE_ASPECT, "IMAGE", str); |
Jeremy Hayes | 148bab2 | 2015-10-28 13:01:39 -0600 | [diff] [blame] | 1028 | } |
| 1029 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1030 | VkImageAspectFlags srcAspect = pRegions[i].srcSubresource.aspectMask; |
| 1031 | VkImageAspectFlags dstAspect = pRegions[i].dstSubresource.aspectMask; |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1032 | |
| 1033 | if (srcAspect != dstAspect) { |
| 1034 | std::stringstream ss; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1035 | ss << "vkCmdBlitImage: Image aspects of depth/stencil images should match"; |
| 1036 | // TODO: Verify against Valid Use section of spec, if this case yields undefined results, then it's an error |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1037 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 1038 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 1039 | IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1040 | } |
| 1041 | if (vk_format_is_depth_and_stencil(srcFormat)) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1042 | if ((srcAspect != VK_IMAGE_ASPECT_DEPTH_BIT) && (srcAspect != VK_IMAGE_ASPECT_STENCIL_BIT)) { |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1043 | std::stringstream ss; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1044 | ss << "vkCmdBlitImage: Combination depth/stencil image formats must have only one of " |
| 1045 | "VK_IMAGE_ASPECT_DEPTH_BIT " |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1046 | << "and VK_IMAGE_ASPECT_STENCIL_BIT set in srcImage and dstImage"; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1047 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 1048 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 1049 | IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1050 | } |
| 1051 | } else if (vk_format_is_stencil_only(srcFormat)) { |
| 1052 | if (srcAspect != VK_IMAGE_ASPECT_STENCIL_BIT) { |
| 1053 | std::stringstream ss; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1054 | ss << "vkCmdBlitImage: Stencil-only image formats must have only the VK_IMAGE_ASPECT_STENCIL_BIT " |
Chia-I Wu | 3432a0c | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 1055 | << "set in both the srcImage and dstImage"; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1056 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 1057 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 1058 | IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1059 | } |
| 1060 | } else if (vk_format_is_depth_only(srcFormat)) { |
| 1061 | if (srcAspect != VK_IMAGE_ASPECT_DEPTH_BIT) { |
| 1062 | std::stringstream ss; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1063 | ss << "vkCmdBlitImage: Depth-only image formats must have only the VK_IMAGE_ASPECT_DEPTH " |
Chia-I Wu | 3432a0c | 2015-10-27 18:04:07 +0800 | [diff] [blame] | 1064 | << "set in both the srcImage and dstImage"; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1065 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 1066 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 1067 | IMAGE_INVALID_IMAGE_ASPECT, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1068 | } |
| 1069 | } |
| 1070 | } |
| 1071 | } |
| 1072 | |
| 1073 | // Validate filter |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 1074 | if (vk_format_is_depth_or_stencil(srcFormat) && (filter != VK_FILTER_NEAREST)) { |
| 1075 | std::stringstream ss; |
| 1076 | ss << "vkCmdBlitImage: If the format of srcImage is a depth, stencil, or depth stencil " |
| 1077 | << "then filter must be VK_FILTER_NEAREST."; |
| 1078 | skipCall |= |
| 1079 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 1080 | (uint64_t)commandBuffer, __LINE__, VALIDATION_ERROR_02193, "IMAGE", "%s. %s", ss.str().c_str(), |
| 1081 | validation_error_map[VALIDATION_ERROR_02193]); |
| 1082 | } |
| 1083 | if (vk_format_is_int(srcFormat) && (filter != VK_FILTER_NEAREST)) { |
| 1084 | std::stringstream ss; |
| 1085 | ss << "vkCmdBlitImage: If the format of srcImage is an integer-based format " |
| 1086 | << "then filter must be VK_FILTER_NEAREST."; |
| 1087 | skipCall |= |
| 1088 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 1089 | (uint64_t)commandBuffer, __LINE__, IMAGE_INVALID_FILTER, "IMAGE", "%s", ss.str().c_str()); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1090 | } |
| 1091 | } |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 1092 | |
Tony Barbour | f830910 | 2016-05-05 10:50:21 -0600 | [diff] [blame] | 1093 | if (!skipCall) { |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 1094 | device_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, |
| 1095 | regionCount, pRegions, filter); |
Tony Barbour | f830910 | 2016-05-05 10:50:21 -0600 | [diff] [blame] | 1096 | } |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 1097 | } |
| 1098 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1099 | VKAPI_ATTR void VKAPI_CALL |
| 1100 | CmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, |
| 1101 | VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, |
| 1102 | uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, |
| 1103 | uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 1104 | bool skipCall = false; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1105 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | 01b3889 | 2015-11-17 18:19:55 -0700 | [diff] [blame] | 1106 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1107 | for (uint32_t i = 0; i < imageMemoryBarrierCount; ++i) { |
| 1108 | VkImageMemoryBarrier const *const barrier = (VkImageMemoryBarrier const *const) & pImageMemoryBarriers[i]; |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 1109 | // TODO: add VALIDATION_ERROR_00309 (sType == VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER) here |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1110 | if (barrier->sType == VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER) { |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 1111 | // TODO: this check should include VALIDATION_ERROR_00301 and VALIDATION_ERROR_00316 |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1112 | if (barrier->subresourceRange.layerCount == 0) { |
Jeremy Hayes | 01b3889 | 2015-11-17 18:19:55 -0700 | [diff] [blame] | 1113 | std::stringstream ss; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1114 | ss << "vkCmdPipelineBarrier called with 0 in ppMemoryBarriers[" << i << "]->subresourceRange.layerCount."; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1115 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 1116 | __LINE__, IMAGE_INVALID_IMAGE_RESOURCE, "IMAGE", "%s", ss.str().c_str()); |
Jeremy Hayes | 01b3889 | 2015-11-17 18:19:55 -0700 | [diff] [blame] | 1117 | } |
| 1118 | } |
| 1119 | } |
| 1120 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1121 | if (skipCall) { |
Jeremy Hayes | 01b3889 | 2015-11-17 18:19:55 -0700 | [diff] [blame] | 1122 | return; |
| 1123 | } |
| 1124 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1125 | device_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1126 | memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, |
| 1127 | pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); |
Jeremy Hayes | 01b3889 | 2015-11-17 18:19:55 -0700 | [diff] [blame] | 1128 | } |
| 1129 | |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 1130 | VKAPI_ATTR void VKAPI_CALL CmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, |
| 1131 | VkImage dstImage, VkImageLayout dstImageLayout, uint32_t regionCount, |
| 1132 | const VkImageResolve *pRegions) { |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 1133 | bool skipCall = false; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1134 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 1135 | auto srcImageEntry = getImageState(device_data, srcImage); |
| 1136 | auto dstImageEntry = getImageState(device_data, dstImage); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 1137 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1138 | // For each region, the number of layers in the image subresource should not be zero |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 1139 | // For each region, src and dest image aspect must be color only |
| 1140 | for (uint32_t i = 0; i < regionCount; i++) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1141 | if (pRegions[i].srcSubresource.layerCount == 0) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1142 | char const str[] = "vkCmdResolveImage: number of layers in source subresource is zero"; |
| 1143 | // TODO: Verify against Valid Use section of spec. Generally if something yield an undefined result, it's invalid/error |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1144 | skipCall |= |
| 1145 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 1146 | (uint64_t)commandBuffer, __LINE__, IMAGE_MISMATCHED_IMAGE_ASPECT, "IMAGE", str); |
Jeremy Hayes | 148bab2 | 2015-10-28 13:01:39 -0600 | [diff] [blame] | 1147 | } |
| 1148 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1149 | if (pRegions[i].dstSubresource.layerCount == 0) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1150 | char const str[] = "vkCmdResolveImage: number of layers in destination subresource is zero"; |
Courtney Goeltzenleuchter | 7415d5a | 2015-12-09 15:48:16 -0700 | [diff] [blame] | 1151 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1152 | // TODO: Verify against Valid Use section of spec. Generally if something yield an undefined result, it's invalid/error |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1153 | skipCall |= |
| 1154 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 1155 | (uint64_t)commandBuffer, __LINE__, IMAGE_MISMATCHED_IMAGE_ASPECT, "IMAGE", str); |
Jeremy Hayes | 148bab2 | 2015-10-28 13:01:39 -0600 | [diff] [blame] | 1156 | } |
| 1157 | |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 1158 | // TODO: VALIDATION_ERROR_01339 |
| 1159 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1160 | if ((pRegions[i].srcSubresource.aspectMask != VK_IMAGE_ASPECT_COLOR_BIT) || |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1161 | (pRegions[i].dstSubresource.aspectMask != VK_IMAGE_ASPECT_COLOR_BIT)) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1162 | char const str[] = |
| 1163 | "vkCmdResolveImage: src and dest aspectMasks for each region must specify only VK_IMAGE_ASPECT_COLOR_BIT"; |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 1164 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 1165 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 1166 | VALIDATION_ERROR_01338, "IMAGE", "%s. %s", str, validation_error_map[VALIDATION_ERROR_01338]); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 1167 | } |
| 1168 | } |
| 1169 | |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 1170 | if (srcImageEntry && dstImageEntry) { |
| 1171 | if (srcImageEntry->format != dstImageEntry->format) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1172 | char const str[] = "vkCmdResolveImage called with unmatched source and dest formats."; |
| 1173 | skipCall |= |
| 1174 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 1175 | (uint64_t)commandBuffer, __LINE__, IMAGE_MISMATCHED_IMAGE_FORMAT, "IMAGE", str); |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 1176 | } |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 1177 | if (srcImageEntry->imageType != dstImageEntry->imageType) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1178 | char const str[] = "vkCmdResolveImage called with unmatched source and dest image types."; |
| 1179 | skipCall |= |
| 1180 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 1181 | (uint64_t)commandBuffer, __LINE__, IMAGE_MISMATCHED_IMAGE_TYPE, "IMAGE", str); |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 1182 | } |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 1183 | if (srcImageEntry->samples == VK_SAMPLE_COUNT_1_BIT) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1184 | char const str[] = "vkCmdResolveImage called with source sample count less than 2."; |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 1185 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 1186 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 1187 | VALIDATION_ERROR_01320, "IMAGE", "%s. %s", str, validation_error_map[VALIDATION_ERROR_01320]); |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 1188 | } |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 1189 | if (dstImageEntry->samples != VK_SAMPLE_COUNT_1_BIT) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1190 | char const str[] = "vkCmdResolveImage called with dest sample count greater than 1."; |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 1191 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 1192 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 1193 | VALIDATION_ERROR_01321, "IMAGE", "%s. %s", str, validation_error_map[VALIDATION_ERROR_01321]); |
Mike Stroyan | a308243 | 2015-09-25 13:39:21 -0600 | [diff] [blame] | 1194 | } |
| 1195 | } |
| 1196 | |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 1197 | if (!skipCall) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1198 | device_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, |
| 1199 | regionCount, pRegions); |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 1200 | } |
| 1201 | } |
| 1202 | |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 1203 | VKAPI_ATTR void VKAPI_CALL GetImageSubresourceLayout(VkDevice device, VkImage image, const VkImageSubresource *pSubresource, |
| 1204 | VkSubresourceLayout *pLayout) { |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 1205 | bool skipCall = false; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1206 | layer_data *device_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1207 | VkFormat format; |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 1208 | |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 1209 | auto imageEntry = getImageState(device_data, image); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1210 | |
| 1211 | // Validate that image aspects match formats |
Tobin Ehlis | f4d352b | 2016-05-19 09:59:30 -0600 | [diff] [blame] | 1212 | if (imageEntry) { |
| 1213 | format = imageEntry->format; |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1214 | if (vk_format_is_color(format)) { |
Chia-I Wu | 52b07e7 | 2015-10-27 19:55:05 +0800 | [diff] [blame] | 1215 | if (pSubresource->aspectMask != VK_IMAGE_ASPECT_COLOR_BIT) { |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1216 | std::stringstream ss; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1217 | ss << "vkGetImageSubresourceLayout: For color formats, the aspectMask field of VkImageSubresource must be " |
| 1218 | "VK_IMAGE_ASPECT_COLOR."; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1219 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 1220 | (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", "%s. %s", ss.str().c_str(), |
| 1221 | validation_error_map[VALIDATION_ERROR_00741]); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1222 | } |
| 1223 | } else if (vk_format_is_depth_or_stencil(format)) { |
Chia-I Wu | 52b07e7 | 2015-10-27 19:55:05 +0800 | [diff] [blame] | 1224 | if ((pSubresource->aspectMask != VK_IMAGE_ASPECT_DEPTH_BIT) && |
| 1225 | (pSubresource->aspectMask != VK_IMAGE_ASPECT_STENCIL_BIT)) { |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1226 | std::stringstream ss; |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1227 | ss << "vkGetImageSubresourceLayout: For depth/stencil formats, the aspectMask selects either the depth or stencil " |
| 1228 | "image aspectMask."; |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1229 | skipCall |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | 34df4cb | 2016-12-01 16:43:06 -0700 | [diff] [blame] | 1230 | (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", "%s. %s", ss.str().c_str(), |
| 1231 | validation_error_map[VALIDATION_ERROR_00741]); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1232 | } |
| 1233 | } |
| 1234 | } |
| 1235 | |
Dustin Graves | 080069b | 2016-04-05 13:48:15 -0600 | [diff] [blame] | 1236 | if (!skipCall) { |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1237 | device_data->device_dispatch_table->GetImageSubresourceLayout(device, image, pSubresource, pLayout); |
Mark Lobodzinski | dc86b85 | 2015-10-23 14:20:31 -0600 | [diff] [blame] | 1238 | } |
Mark Lobodzinski | a5eabe7 | 2015-10-05 17:16:05 -0600 | [diff] [blame] | 1239 | } |
| 1240 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1241 | VKAPI_ATTR void VKAPI_CALL |
| 1242 | GetPhysicalDeviceProperties(VkPhysicalDevice physicalDevice, VkPhysicalDeviceProperties *pProperties) { |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1243 | layer_data *phy_dev_data = get_my_data_ptr(get_dispatch_key(physicalDevice), layer_data_map); |
| 1244 | phy_dev_data->instance_dispatch_table->GetPhysicalDeviceProperties(physicalDevice, pProperties); |
Mark Lobodzinski | d5a2382 | 2015-11-12 15:14:35 -0700 | [diff] [blame] | 1245 | } |
| 1246 | |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 1247 | VKAPI_ATTR VkResult VKAPI_CALL |
| 1248 | EnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { |
| 1249 | return util_GetLayerProperties(1, &global_layer, pCount, pProperties); |
| 1250 | } |
| 1251 | |
| 1252 | VKAPI_ATTR VkResult VKAPI_CALL |
| 1253 | EnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { |
| 1254 | return util_GetLayerProperties(1, &global_layer, pCount, pProperties); |
| 1255 | } |
| 1256 | |
| 1257 | VKAPI_ATTR VkResult VKAPI_CALL |
| 1258 | EnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { |
| 1259 | if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) |
| 1260 | return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); |
| 1261 | |
| 1262 | return VK_ERROR_LAYER_NOT_PRESENT; |
| 1263 | } |
| 1264 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1265 | VKAPI_ATTR VkResult VKAPI_CALL EnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, |
| 1266 | const char *pLayerName, uint32_t *pCount, |
| 1267 | VkExtensionProperties *pProperties) { |
Chia-I Wu | eec9a31 | 2016-04-28 11:21:49 +0800 | [diff] [blame] | 1268 | // Image does not have any physical device extensions |
Chia-I Wu | 3f32622 | 2016-04-28 14:21:13 +0800 | [diff] [blame] | 1269 | if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) |
Chia-I Wu | eec9a31 | 2016-04-28 11:21:49 +0800 | [diff] [blame] | 1270 | return util_GetExtensionProperties(0, NULL, pCount, pProperties); |
Chia-I Wu | 3f32622 | 2016-04-28 14:21:13 +0800 | [diff] [blame] | 1271 | |
| 1272 | assert(physicalDevice); |
| 1273 | |
| 1274 | dispatch_key key = get_dispatch_key(physicalDevice); |
| 1275 | layer_data *my_data = get_my_data_ptr(key, layer_data_map); |
| 1276 | VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; |
| 1277 | return pTable->EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); |
Chia-I Wu | eec9a31 | 2016-04-28 11:21:49 +0800 | [diff] [blame] | 1278 | } |
| 1279 | |
Chia-I Wu | 64df8ed | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1280 | static PFN_vkVoidFunction |
Chia-I Wu | 428eba0 | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1281 | intercept_core_instance_command(const char *name); |
| 1282 | static PFN_vkVoidFunction |
Chia-I Wu | 64df8ed | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1283 | intercept_core_device_command(const char *name); |
Tobin Ehlis | b74f6ab | 2015-10-29 14:19:18 -0600 | [diff] [blame] | 1284 | |
Chia-I Wu | 64df8ed | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1285 | VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetDeviceProcAddr(VkDevice device, const char *funcName) { |
| 1286 | PFN_vkVoidFunction proc = intercept_core_device_command(funcName); |
| 1287 | if (proc) |
| 1288 | return proc; |
| 1289 | |
| 1290 | assert(device); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 1291 | |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1292 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 1293 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1294 | VkLayerDispatchTable *pTable = my_data->device_dispatch_table; |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 1295 | { |
Tobin Ehlis | b74f6ab | 2015-10-29 14:19:18 -0600 | [diff] [blame] | 1296 | if (pTable->GetDeviceProcAddr == NULL) |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 1297 | return NULL; |
Tobin Ehlis | b74f6ab | 2015-10-29 14:19:18 -0600 | [diff] [blame] | 1298 | return pTable->GetDeviceProcAddr(device, funcName); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 1299 | } |
| 1300 | } |
| 1301 | |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1302 | VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetInstanceProcAddr(VkInstance instance, const char *funcName) { |
Chia-I Wu | 428eba0 | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1303 | PFN_vkVoidFunction proc = intercept_core_instance_command(funcName); |
Chia-I Wu | f89922c | 2016-04-28 15:16:59 +0800 | [diff] [blame] | 1304 | if (!proc) |
| 1305 | proc = intercept_core_device_command(funcName); |
Chia-I Wu | 428eba0 | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1306 | if (proc) |
| 1307 | return proc; |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 1308 | |
Chia-I Wu | f89922c | 2016-04-28 15:16:59 +0800 | [diff] [blame] | 1309 | assert(instance); |
Mark Lobodzinski | 1ed594e | 2016-02-03 09:57:14 -0700 | [diff] [blame] | 1310 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 1311 | |
Chia-I Wu | f89922c | 2016-04-28 15:16:59 +0800 | [diff] [blame] | 1312 | proc = debug_report_get_instance_proc_addr(my_data->report_data, funcName); |
| 1313 | if (proc) |
| 1314 | return proc; |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 1315 | |
Jon Ashburn | 5484e0c | 2016-03-08 17:48:44 -0700 | [diff] [blame] | 1316 | VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; |
Courtney Goeltzenleuchter | 00150eb | 2016-01-08 12:18:43 -0700 | [diff] [blame] | 1317 | if (pTable->GetInstanceProcAddr == NULL) |
| 1318 | return NULL; |
| 1319 | return pTable->GetInstanceProcAddr(instance, funcName); |
Jeremy Hayes | 9cc3158 | 2015-06-18 10:12:39 -0600 | [diff] [blame] | 1320 | } |
Chia-I Wu | eec9a31 | 2016-04-28 11:21:49 +0800 | [diff] [blame] | 1321 | |
Chia-I Wu | 64df8ed | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1322 | static PFN_vkVoidFunction |
Chia-I Wu | 428eba0 | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1323 | intercept_core_instance_command(const char *name) { |
| 1324 | static const struct { |
| 1325 | const char *name; |
| 1326 | PFN_vkVoidFunction proc; |
| 1327 | } core_instance_commands[] = { |
| 1328 | { "vkGetInstanceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetInstanceProcAddr) }, |
| 1329 | { "vkCreateInstance", reinterpret_cast<PFN_vkVoidFunction>(CreateInstance) }, |
| 1330 | { "vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance) }, |
| 1331 | { "vkCreateDevice", reinterpret_cast<PFN_vkVoidFunction>(CreateDevice) }, |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 1332 | { "vkEnumerateInstanceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceLayerProperties) }, |
| 1333 | { "vkEnumerateDeviceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceLayerProperties) }, |
| 1334 | { "vkEnumerateInstanceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceExtensionProperties) }, |
Chia-I Wu | 428eba0 | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1335 | { "vkEnumerateDeviceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceExtensionProperties) }, |
| 1336 | { "vkGetPhysicalDeviceProperties", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceProperties) }, |
| 1337 | }; |
| 1338 | |
| 1339 | for (size_t i = 0; i < ARRAY_SIZE(core_instance_commands); i++) { |
| 1340 | if (!strcmp(core_instance_commands[i].name, name)) |
| 1341 | return core_instance_commands[i].proc; |
| 1342 | } |
| 1343 | |
| 1344 | return nullptr; |
| 1345 | } |
| 1346 | |
| 1347 | static PFN_vkVoidFunction |
Chia-I Wu | 64df8ed | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1348 | intercept_core_device_command(const char *name) { |
| 1349 | static const struct { |
| 1350 | const char *name; |
| 1351 | PFN_vkVoidFunction proc; |
| 1352 | } core_device_commands[] = { |
Tobin Ehlis | 1623987 | 2016-10-26 10:42:49 -0600 | [diff] [blame] | 1353 | {"vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr)}, |
| 1354 | {"vkDestroyDevice", reinterpret_cast<PFN_vkVoidFunction>(DestroyDevice)}, |
| 1355 | {"vkCreateImage", reinterpret_cast<PFN_vkVoidFunction>(CreateImage)}, |
| 1356 | {"vkDestroyImage", reinterpret_cast<PFN_vkVoidFunction>(DestroyImage)}, |
| 1357 | {"vkCreateRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CreateRenderPass)}, |
| 1358 | {"vkCmdClearColorImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearColorImage)}, |
| 1359 | {"vkCmdClearDepthStencilImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearDepthStencilImage)}, |
| 1360 | {"vkCmdClearAttachments", reinterpret_cast<PFN_vkVoidFunction>(CmdClearAttachments)}, |
| 1361 | {"vkCmdCopyImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImage)}, |
| 1362 | {"vkCmdCopyImageToBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImageToBuffer)}, |
| 1363 | {"vkCmdCopyBufferToImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBufferToImage)}, |
| 1364 | {"vkCmdBlitImage", reinterpret_cast<PFN_vkVoidFunction>(CmdBlitImage)}, |
| 1365 | {"vkCmdPipelineBarrier", reinterpret_cast<PFN_vkVoidFunction>(CmdPipelineBarrier)}, |
| 1366 | {"vkCmdResolveImage", reinterpret_cast<PFN_vkVoidFunction>(CmdResolveImage)}, |
| 1367 | {"vkGetImageSubresourceLayout", reinterpret_cast<PFN_vkVoidFunction>(GetImageSubresourceLayout)}, |
Chia-I Wu | 64df8ed | 2016-04-28 14:38:57 +0800 | [diff] [blame] | 1368 | }; |
| 1369 | |
| 1370 | for (size_t i = 0; i < ARRAY_SIZE(core_device_commands); i++) { |
| 1371 | if (!strcmp(core_device_commands[i].name, name)) |
| 1372 | return core_device_commands[i].proc; |
| 1373 | } |
| 1374 | |
| 1375 | return nullptr; |
| 1376 | } |
| 1377 | |
Chia-I Wu | aacb0fc | 2016-04-28 11:27:46 +0800 | [diff] [blame] | 1378 | } // namespace image |
| 1379 | |
| 1380 | // vk_layer_logging.h expects these to be defined |
| 1381 | |
| 1382 | VKAPI_ATTR VkResult VKAPI_CALL |
| 1383 | vkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, |
| 1384 | const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1385 | return image::CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); |
Chia-I Wu | aacb0fc | 2016-04-28 11:27:46 +0800 | [diff] [blame] | 1386 | } |
| 1387 | |
| 1388 | VKAPI_ATTR void VKAPI_CALL |
| 1389 | vkDestroyDebugReportCallbackEXT(VkInstance instance, |
| 1390 | VkDebugReportCallbackEXT msgCallback, |
| 1391 | const VkAllocationCallbacks *pAllocator) { |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1392 | image::DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); |
Chia-I Wu | aacb0fc | 2016-04-28 11:27:46 +0800 | [diff] [blame] | 1393 | } |
| 1394 | |
| 1395 | VKAPI_ATTR void VKAPI_CALL |
| 1396 | vkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, |
| 1397 | size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1398 | image::DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); |
Chia-I Wu | aacb0fc | 2016-04-28 11:27:46 +0800 | [diff] [blame] | 1399 | } |
| 1400 | |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 1401 | // loader-layer interface v0, just wrappers since there is only a layer |
Chia-I Wu | aacb0fc | 2016-04-28 11:27:46 +0800 | [diff] [blame] | 1402 | |
Chia-I Wu | eec9a31 | 2016-04-28 11:21:49 +0800 | [diff] [blame] | 1403 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL |
| 1404 | vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 1405 | return image::EnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties); |
Chia-I Wu | eec9a31 | 2016-04-28 11:21:49 +0800 | [diff] [blame] | 1406 | } |
| 1407 | |
| 1408 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL |
| 1409 | vkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 1410 | return image::EnumerateInstanceLayerProperties(pCount, pProperties); |
Chia-I Wu | eec9a31 | 2016-04-28 11:21:49 +0800 | [diff] [blame] | 1411 | } |
| 1412 | |
| 1413 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL |
| 1414 | vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 1415 | // the layer command handles VK_NULL_HANDLE just fine internally |
| 1416 | assert(physicalDevice == VK_NULL_HANDLE); |
| 1417 | return image::EnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties); |
Chia-I Wu | aacb0fc | 2016-04-28 11:27:46 +0800 | [diff] [blame] | 1418 | } |
| 1419 | |
| 1420 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, |
| 1421 | const char *pLayerName, uint32_t *pCount, |
| 1422 | VkExtensionProperties *pProperties) { |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 1423 | // the layer command handles VK_NULL_HANDLE just fine internally |
| 1424 | assert(physicalDevice == VK_NULL_HANDLE); |
Chia-I Wu | 3f32622 | 2016-04-28 14:21:13 +0800 | [diff] [blame] | 1425 | return image::EnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties); |
Chia-I Wu | aacb0fc | 2016-04-28 11:27:46 +0800 | [diff] [blame] | 1426 | } |
| 1427 | |
| 1428 | VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1429 | return image::GetDeviceProcAddr(dev, funcName); |
Chia-I Wu | aacb0fc | 2016-04-28 11:27:46 +0800 | [diff] [blame] | 1430 | } |
| 1431 | |
| 1432 | VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { |
Chia-I Wu | 4935c76 | 2016-04-28 14:01:30 +0800 | [diff] [blame] | 1433 | return image::GetInstanceProcAddr(instance, funcName); |
Chia-I Wu | eec9a31 | 2016-04-28 11:21:49 +0800 | [diff] [blame] | 1434 | } |