blob: 8f8cad53c32d7abf7e88719d281dbc596dc5af4c [file] [log] [blame]
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001/*
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002 *
Courtney Goeltzenleuchter8a17da52015-10-29 13:50:34 -06003 * Copyright (C) 2015 Valve Corporation
Michael Lentine329697b2015-10-06 14:56:18 -07004 * Copyright (C) 2015 Google, Inc.
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005 *
6 * Permission is hereby granted, free of charge, to any person obtaining a
7 * copy of this software and associated documentation files (the "Software"),
8 * to deal in the Software without restriction, including without limitation
9 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
10 * and/or sell copies of the Software, and to permit persons to whom the
11 * Software is furnished to do so, subject to the following conditions:
12 *
13 * The above copyright notice and this permission notice shall be included
14 * in all copies or substantial portions of the Software.
15 *
16 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
19 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
21 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
22 * DEALINGS IN THE SOFTWARE.
Courtney Goeltzenleuchter96cd7952015-10-30 11:14:30 -060023 *
24 * Author: Cody Northrop <cody@lunarg.com>
25 * Author: Michael Lentine <mlentine@google.com>
26 * Author: Tobin Ehlis <tobin@lunarg.com>
Tobin Ehlis63bb9482015-03-17 16:24:32 -060027 */
28
29#include <stdio.h>
30#include <stdlib.h>
31#include <string.h>
Michael Lentine329697b2015-10-06 14:56:18 -070032#include <algorithm>
33#include <memory>
Tobin Ehlis63bb9482015-03-17 16:24:32 -060034#include <unordered_map>
Michael Lentine329697b2015-10-06 14:56:18 -070035#include <unordered_set>
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -070036#include <list>
Tobin Ehlis63bb9482015-03-17 16:24:32 -060037
Tobin Ehlis7a51d902015-07-03 10:34:49 -060038#include "vk_loader_platform.h"
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -060039#include "vk_dispatch_table_helper.h"
40#include "vk_struct_string_helper_cpp.h"
Tony Barboura938abb2015-04-22 11:36:22 -060041#if defined(__GNUC__)
Tobin Ehlis63bb9482015-03-17 16:24:32 -060042#pragma GCC diagnostic ignored "-Wwrite-strings"
Tony Barboura938abb2015-04-22 11:36:22 -060043#endif
Tony Barboura938abb2015-04-22 11:36:22 -060044#if defined(__GNUC__)
Tobin Ehlis63bb9482015-03-17 16:24:32 -060045#pragma GCC diagnostic warning "-Wwrite-strings"
Tony Barboura938abb2015-04-22 11:36:22 -060046#endif
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -060047#include "vk_struct_size_helper.h"
Tobin Ehlis63bb9482015-03-17 16:24:32 -060048#include "draw_state.h"
Tobin Ehlis56d204a2015-07-03 10:15:26 -060049#include "vk_layer_config.h"
Jon Ashburnf0615e22015-05-25 14:11:37 -060050#include "vk_debug_marker_layer.h"
Tobin Ehlis56d204a2015-07-03 10:15:26 -060051#include "vk_layer_table.h"
52#include "vk_layer_debug_marker_table.h"
53#include "vk_layer_data.h"
54#include "vk_layer_logging.h"
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -060055#include "vk_layer_extension_utils.h"
Tobin Ehlisb46be812015-10-23 16:00:08 -060056#include "vk_layer_utils.h"
Tobin Ehlis63bb9482015-03-17 16:24:32 -060057
Tobin Ehlise6ab55a2015-10-07 09:38:40 -060058struct devExts {
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -070059 VkBool32 debug_marker_enabled;
Michael Lentine27b0f902015-10-12 11:30:14 -050060 VkBool32 wsi_enabled;
61 unordered_map<VkSwapchainKHR, SWAPCHAIN_NODE*> swapchainMap;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -060062};
63
Cody Northrop73bb6572015-09-28 15:09:32 -060064struct layer_data {
Tobin Ehlisc91330b2015-06-16 09:04:30 -060065 debug_report_data *report_data;
66 // TODO: put instance data here
Courtney Goeltzenleuchter1781b1c2015-10-05 15:58:38 -060067 std::vector<VkDbgMsgCallback> logging_callback;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -060068 VkLayerDispatchTable* device_dispatch_table;
69 VkLayerInstanceDispatchTable* instance_dispatch_table;
70 devExts device_extensions;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -060071 // Layer specific data
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -070072 unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> sampleMap;
73 unordered_map<VkImageView, unique_ptr<VkImageViewCreateInfo>> imageViewMap;
74 unordered_map<VkImage, unique_ptr<VkImageCreateInfo>> imageMap;
75 unordered_map<VkBufferView, unique_ptr<VkBufferViewCreateInfo>> bufferViewMap;
76 unordered_map<VkBuffer, unique_ptr<VkBufferCreateInfo>> bufferMap;
77 unordered_map<VkPipeline, PIPELINE_NODE*> pipelineMap;
78 unordered_map<VkCommandPool, list<VkCommandBuffer>> commandPoolMap;
79 unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE*> descriptorPoolMap;
80 unordered_map<VkDescriptorSet, SET_NODE*> setMap;
81 unordered_map<VkDescriptorSetLayout, LAYOUT_NODE*> layoutMap;
82 unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap;
83 unordered_map<VkDeviceMemory, VkImage> memImageMap;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -060084 // Map for layout chains
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -070085 unordered_map<void*, GLOBAL_CB_NODE*> commandBufferMap;
86 unordered_map<VkFramebuffer, VkFramebufferCreateInfo*> frameBufferMap;
87 unordered_map<VkImage, IMAGE_NODE*> imageLayoutMap;
88 unordered_map<VkRenderPass, RENDER_PASS_NODE*> renderPassMap;
Michael Lentine27b0f902015-10-12 11:30:14 -050089 // Current render pass
90 VkRenderPassBeginInfo renderPassBeginInfo;
91 uint32_t currentSubpass;
Cody Northrop73bb6572015-09-28 15:09:32 -060092
93 layer_data() :
94 report_data(nullptr),
Tobin Ehlise6ab55a2015-10-07 09:38:40 -060095 device_dispatch_table(nullptr),
96 instance_dispatch_table(nullptr),
97 device_extensions()
Cody Northrop73bb6572015-09-28 15:09:32 -060098 {};
99};
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600100// TODO : Do we need to guard access to layer_data_map w/ lock?
Tobin Ehlisc91330b2015-06-16 09:04:30 -0600101static std::unordered_map<void *, layer_data *> layer_data_map;
Courtney Goeltzenleuchterc280adc2015-06-13 21:23:09 -0600102
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600103static LOADER_PLATFORM_THREAD_ONCE_DECLARATION(g_initOnce);
Jon Ashburnd9564002015-05-07 10:27:37 -0600104
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600105// TODO : This can be much smarter, using separate locks for separate global data
106static int globalLockInitialized = 0;
107static loader_platform_thread_mutex globalLock;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600108#define MAX_TID 513
109static loader_platform_thread_id g_tidMapping[MAX_TID] = {0};
110static uint32_t g_maxTID = 0;
Tobin Ehlisfde4dce2015-06-16 15:50:44 -0600111
112template layer_data *get_my_data_ptr<layer_data>(
113 void *data_key,
114 std::unordered_map<void *, layer_data *> &data_map);
115
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600116// Map actual TID to an index value and return that index
117// This keeps TIDs in range from 0-MAX_TID and simplifies compares between runs
118static uint32_t getTIDIndex() {
119 loader_platform_thread_id tid = loader_platform_get_thread_id();
120 for (uint32_t i = 0; i < g_maxTID; i++) {
121 if (tid == g_tidMapping[i])
122 return i;
123 }
124 // Don't yet have mapping, set it and return newly set index
125 uint32_t retVal = (uint32_t) g_maxTID;
126 g_tidMapping[g_maxTID++] = tid;
127 assert(g_maxTID < MAX_TID);
128 return retVal;
129}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700130
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600131// Return a string representation of CMD_TYPE enum
132static string cmdTypeToString(CMD_TYPE cmd)
133{
134 switch (cmd)
135 {
136 case CMD_BINDPIPELINE:
137 return "CMD_BINDPIPELINE";
138 case CMD_BINDPIPELINEDELTA:
139 return "CMD_BINDPIPELINEDELTA";
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -0600140 case CMD_SETVIEWPORTSTATE:
141 return "CMD_SETVIEWPORTSTATE";
142 case CMD_SETLINEWIDTHSTATE:
143 return "CMD_SETLINEWIDTHSTATE";
144 case CMD_SETDEPTHBIASSTATE:
145 return "CMD_SETDEPTHBIASSTATE";
146 case CMD_SETBLENDSTATE:
147 return "CMD_SETBLENDSTATE";
148 case CMD_SETDEPTHBOUNDSSTATE:
149 return "CMD_SETDEPTHBOUNDSSTATE";
150 case CMD_SETSTENCILREADMASKSTATE:
151 return "CMD_SETSTENCILREADMASKSTATE";
152 case CMD_SETSTENCILWRITEMASKSTATE:
153 return "CMD_SETSTENCILWRITEMASKSTATE";
154 case CMD_SETSTENCILREFERENCESTATE:
155 return "CMD_SETSTENCILREFERENCESTATE";
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600156 case CMD_BINDDESCRIPTORSETS:
157 return "CMD_BINDDESCRIPTORSETS";
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600158 case CMD_BINDINDEXBUFFER:
159 return "CMD_BINDINDEXBUFFER";
160 case CMD_BINDVERTEXBUFFER:
161 return "CMD_BINDVERTEXBUFFER";
162 case CMD_DRAW:
163 return "CMD_DRAW";
164 case CMD_DRAWINDEXED:
165 return "CMD_DRAWINDEXED";
166 case CMD_DRAWINDIRECT:
167 return "CMD_DRAWINDIRECT";
168 case CMD_DRAWINDEXEDINDIRECT:
169 return "CMD_DRAWINDEXEDINDIRECT";
170 case CMD_DISPATCH:
171 return "CMD_DISPATCH";
172 case CMD_DISPATCHINDIRECT:
173 return "CMD_DISPATCHINDIRECT";
174 case CMD_COPYBUFFER:
175 return "CMD_COPYBUFFER";
176 case CMD_COPYIMAGE:
177 return "CMD_COPYIMAGE";
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600178 case CMD_BLITIMAGE:
179 return "CMD_BLITIMAGE";
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600180 case CMD_COPYBUFFERTOIMAGE:
181 return "CMD_COPYBUFFERTOIMAGE";
182 case CMD_COPYIMAGETOBUFFER:
183 return "CMD_COPYIMAGETOBUFFER";
184 case CMD_CLONEIMAGEDATA:
185 return "CMD_CLONEIMAGEDATA";
186 case CMD_UPDATEBUFFER:
187 return "CMD_UPDATEBUFFER";
188 case CMD_FILLBUFFER:
189 return "CMD_FILLBUFFER";
190 case CMD_CLEARCOLORIMAGE:
191 return "CMD_CLEARCOLORIMAGE";
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -0600192 case CMD_CLEARATTACHMENTS:
Tobin Ehlis8cd650e2015-07-01 16:46:13 -0600193 return "CMD_CLEARCOLORATTACHMENT";
194 case CMD_CLEARDEPTHSTENCILIMAGE:
195 return "CMD_CLEARDEPTHSTENCILIMAGE";
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600196 case CMD_RESOLVEIMAGE:
197 return "CMD_RESOLVEIMAGE";
198 case CMD_SETEVENT:
199 return "CMD_SETEVENT";
200 case CMD_RESETEVENT:
201 return "CMD_RESETEVENT";
202 case CMD_WAITEVENTS:
203 return "CMD_WAITEVENTS";
204 case CMD_PIPELINEBARRIER:
205 return "CMD_PIPELINEBARRIER";
206 case CMD_BEGINQUERY:
207 return "CMD_BEGINQUERY";
208 case CMD_ENDQUERY:
209 return "CMD_ENDQUERY";
210 case CMD_RESETQUERYPOOL:
211 return "CMD_RESETQUERYPOOL";
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -0600212 case CMD_COPYQUERYPOOLRESULTS:
213 return "CMD_COPYQUERYPOOLRESULTS";
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600214 case CMD_WRITETIMESTAMP:
215 return "CMD_WRITETIMESTAMP";
216 case CMD_INITATOMICCOUNTERS:
217 return "CMD_INITATOMICCOUNTERS";
218 case CMD_LOADATOMICCOUNTERS:
219 return "CMD_LOADATOMICCOUNTERS";
220 case CMD_SAVEATOMICCOUNTERS:
221 return "CMD_SAVEATOMICCOUNTERS";
222 case CMD_BEGINRENDERPASS:
223 return "CMD_BEGINRENDERPASS";
224 case CMD_ENDRENDERPASS:
225 return "CMD_ENDRENDERPASS";
226 case CMD_DBGMARKERBEGIN:
227 return "CMD_DBGMARKERBEGIN";
228 case CMD_DBGMARKEREND:
229 return "CMD_DBGMARKEREND";
230 default:
231 return "UNKNOWN";
232 }
233}
234// Block of code at start here for managing/tracking Pipeline state that this layer cares about
235// Just track 2 shaders for now
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600236#define MAX_SLOTS 2048
237#define NUM_COMMAND_BUFFERS_TO_DISPLAY 10
238
239static uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0};
240
Chia-I Wu1f851912015-10-27 18:04:07 +0800241// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600242// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates
243// to that same cmd buffer by separate thread are not changing state from underneath us
244// Track the last cmd buffer touched by this thread
Chia-I Wu1f851912015-10-27 18:04:07 +0800245static VkCommandBuffer g_lastCommandBuffer[MAX_TID] = {NULL};
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600246// Track the last group of CBs touched for displaying to dot file
Tobin Ehlis1dce5f12015-07-07 10:42:20 -0600247static GLOBAL_CB_NODE* g_pLastTouchedCB[NUM_COMMAND_BUFFERS_TO_DISPLAY] = {NULL};
248static uint32_t g_lastTouchedCBIndex = 0;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600249// Track the last global DrawState of interest touched by any thread
Tobin Ehlis1dce5f12015-07-07 10:42:20 -0600250static GLOBAL_CB_NODE* g_lastGlobalCB = NULL;
251static PIPELINE_NODE* g_lastBoundPipeline = NULL;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600252#define MAX_BINDING 0xFFFFFFFF // Default vtxBinding value in CB Node to identify if no vtxBinding set
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600253// prototype
Chia-I Wu1f851912015-10-27 18:04:07 +0800254static GLOBAL_CB_NODE* getCBNode(layer_data*, const VkCommandBuffer);
Tobin Ehlis982099b2015-11-05 09:52:49 -0700255
Chia-I Wu1f851912015-10-27 18:04:07 +0800256// Update global ptrs to reflect that specified commandBuffer has been used
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600257static void updateCBTracking(GLOBAL_CB_NODE* pCB)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600258{
Chia-I Wu1f851912015-10-27 18:04:07 +0800259 g_lastCommandBuffer[getTIDIndex()] = pCB->commandBuffer;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600260 loader_platform_thread_lock_mutex(&globalLock);
261 g_lastGlobalCB = pCB;
262 // TODO : This is a dumb algorithm. Need smart LRU that drops off oldest
263 for (uint32_t i = 0; i < NUM_COMMAND_BUFFERS_TO_DISPLAY; i++) {
264 if (g_pLastTouchedCB[i] == pCB) {
265 loader_platform_thread_unlock_mutex(&globalLock);
266 return;
267 }
268 }
269 g_pLastTouchedCB[g_lastTouchedCBIndex++] = pCB;
270 g_lastTouchedCBIndex = g_lastTouchedCBIndex % NUM_COMMAND_BUFFERS_TO_DISPLAY;
271 loader_platform_thread_unlock_mutex(&globalLock);
272}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700273
Courtney Goeltzenleuchter1f41f542015-07-09 11:44:38 -0600274static VkBool32 hasDrawCmd(GLOBAL_CB_NODE* pCB)
Tobin Ehlis8cd650e2015-07-01 16:46:13 -0600275{
276 for (uint32_t i=0; i<NUM_DRAW_TYPES; i++) {
277 if (pCB->drawCount[i])
278 return VK_TRUE;
279 }
280 return VK_FALSE;
281}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700282
Tobin Ehlis97866202015-06-10 12:57:07 -0600283// Check object status for selected flag state
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600284static VkBool32 validate_status(layer_data* my_data, GLOBAL_CB_NODE* pNode, CBStatusFlags enable_mask, CBStatusFlags status_mask, CBStatusFlags status_flag, VkFlags msg_flags, DRAW_STATE_ERROR error_code, const char* fail_msg)
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -0600285{
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600286 // If non-zero enable mask is present, check it against status but if enable_mask
287 // is 0 then no enable required so we should always just check status
288 if ((!enable_mask) || (enable_mask & pNode->status)) {
289 if ((pNode->status & status_mask) != status_flag) {
Tobin Ehlis1dce5f12015-07-07 10:42:20 -0600290 // TODO : How to pass dispatchable objects as srcObject? Here src obj should be cmd buffer
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600291 return log_msg(my_data->report_data, msg_flags, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, error_code, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +0800292 "CB object %#" PRIxLEAST64 ": %s", reinterpret_cast<uint64_t>(pNode->commandBuffer), fail_msg);
Tobin Ehlis97866202015-06-10 12:57:07 -0600293 }
Tobin Ehlis97866202015-06-10 12:57:07 -0600294 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600295 return VK_FALSE;
Tobin Ehlis97866202015-06-10 12:57:07 -0600296}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700297
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600298// Retrieve pipeline node ptr for given pipeline object
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600299static PIPELINE_NODE* getPipeline(layer_data* my_data, const VkPipeline pipeline)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600300{
301 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +0800302 if (my_data->pipelineMap.find(pipeline) == my_data->pipelineMap.end()) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600303 loader_platform_thread_unlock_mutex(&globalLock);
304 return NULL;
305 }
306 loader_platform_thread_unlock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +0800307 return my_data->pipelineMap[pipeline];
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600308}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700309
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600310// Return VK_TRUE if for a given PSO, the given state enum is dynamic, else return VK_FALSE
311static VkBool32 isDynamic(const PIPELINE_NODE* pPipeline, const VkDynamicState state)
312{
313 if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) {
314 for (uint32_t i=0; i<pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) {
315 if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i])
316 return VK_TRUE;
317 }
318 }
319 return VK_FALSE;
320}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700321
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600322// Validate state stored as flags at time of draw call
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600323static VkBool32 validate_draw_state_flags(layer_data* my_data, GLOBAL_CB_NODE* pCB, VkBool32 indexedDraw) {
Courtney Goeltzenleuchter1f41f542015-07-09 11:44:38 -0600324 VkBool32 result;
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600325 result = validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_VIEWPORT_SET, CBSTATUS_VIEWPORT_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_VIEWPORT_NOT_BOUND, "Dynamic viewport state not set for this command buffer");
Cody Northrop22cba2c2015-10-27 13:15:41 -0600326 result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_SCISSOR_SET, CBSTATUS_SCISSOR_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_SCISSOR_NOT_BOUND, "Dynamic scissor state not set for this command buffer");
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600327 result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_LINE_WIDTH_SET, CBSTATUS_LINE_WIDTH_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer");
328 result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_DEPTH_BIAS_SET, CBSTATUS_DEPTH_BIAS_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer");
329 result |= validate_status(my_data, pCB, CBSTATUS_COLOR_BLEND_WRITE_ENABLE, CBSTATUS_BLEND_SET, CBSTATUS_BLEND_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend object state not set for this command buffer");
330 result |= validate_status(my_data, pCB, CBSTATUS_DEPTH_WRITE_ENABLE, CBSTATUS_DEPTH_BOUNDS_SET, CBSTATUS_DEPTH_BOUNDS_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer");
331 result |= validate_status(my_data, pCB, CBSTATUS_STENCIL_TEST_ENABLE, CBSTATUS_STENCIL_READ_MASK_SET, CBSTATUS_STENCIL_READ_MASK_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer");
332 result |= validate_status(my_data, pCB, CBSTATUS_STENCIL_TEST_ENABLE, CBSTATUS_STENCIL_WRITE_MASK_SET, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer");
333 result |= validate_status(my_data, pCB, CBSTATUS_STENCIL_TEST_ENABLE, CBSTATUS_STENCIL_REFERENCE_SET, CBSTATUS_STENCIL_REFERENCE_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer");
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600334 if (indexedDraw)
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600335 result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_INDEX_BUFFER_BOUND, CBSTATUS_INDEX_BUFFER_BOUND, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_INDEX_BUFFER_NOT_BOUND, "Index buffer object not bound to this command buffer when Indexed Draw attempted");
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600336 return result;
337}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700338
339// For give SET_NODE, verify that its Set is compatible w/ the setLayout corresponding to pipelineLayout[layoutIndex]
340static bool verify_set_layout_compatibility(layer_data* my_data, const SET_NODE* pSet, const VkPipelineLayout layout, const uint32_t layoutIndex, string& errorMsg)
341{
342 if (my_data->pipelineLayoutMap.find(layout) == my_data->pipelineLayoutMap.end()) {
343 cout << errorMsg << "invalid VkPipelineLayout (" << layout << ")";
344 return false;
345 }
346 PIPELINE_LAYOUT_NODE pl = my_data->pipelineLayoutMap[layout];
347 if (layoutIndex >= pl.descriptorSetLayouts.size()) {
348 cout << errorMsg << "VkPipelineLayout (" << layout << ") only contains " << pl.descriptorSetLayouts.size() << " setLayouts corresponding to sets 0-" << pl.descriptorSetLayouts.size()-1 << ", but you're attempting to bind set to index " << layoutIndex;
349 return false;
350 }
351 // Get the specific setLayout from PipelineLayout that overlaps this set
352 LAYOUT_NODE* pLayoutNode = my_data->layoutMap[pl.descriptorSetLayouts[layoutIndex]];
353 if (pLayoutNode->layout == pSet->pLayout->layout) { // trivial pass case
354 return true;
355 }
356 uint32_t descriptorCount = pLayoutNode->descriptorTypes.size();
357 if (descriptorCount != pSet->pLayout->descriptorTypes.size()) {
358 cout << errorMsg << "setLayout " << layoutIndex << " from pipelineLayout " << layout << " has " << descriptorCount << " descriptors, but corresponding set being bound has " << pSet->pLayout->descriptorTypes.size() << " descriptors.";
359 return false; // trivial fail case
360 }
361 // Now need to check set against corresponding pipelineLayout to verify compatibility
362 for (uint32_t i=0; i<descriptorCount; ++i) {
363 // Need to verify that layouts are identically defined
364 // TODO : Is below sufficient? Making sure that types & stageFlags match per descriptor
365 // do we also need to check immutable samplers?
366 if (pLayoutNode->descriptorTypes[i] != pSet->pLayout->descriptorTypes[i]) {
367 cout << errorMsg << "descriptor " << i << " for descriptorSet being bound is type '" << string_VkDescriptorType(pSet->pLayout->descriptorTypes[i]) << "' but corresponding descriptor from pipelineLayout is type '" << string_VkDescriptorType(pLayoutNode->descriptorTypes[i]) << "'";
368 return false;
369 }
370 if (pLayoutNode->stageFlags[i] != pSet->pLayout->stageFlags[i]) {
371 cout << errorMsg << "stageFlags " << i << " for descriptorSet being bound is " << pSet->pLayout->stageFlags[i] << "' but corresponding descriptor from pipelineLayout has stageFlags " << pLayoutNode->stageFlags[i];
372 return false;
373 }
374 }
375 return true;
376}
377
378// Check if given pipeline layouts are compatible from set 0 up through descriptorSet numDescriptorSets-1
379//static VkBool32 validate_pipeline_layout_compatibility(layer_data* my_data, const VkPipelineLayout psoLayout, const VkPipelineLayout dsLayout, const uint32_t numDescriptorSets)
380//{
381// VkBool32 skipCall = VK_FALSE;
382// // Handle trivial case of same pipeline layouts, which are obviously compatible
383// if (psoLayout == dsLayout)
384// return skipCall;
385// // Check for trivial fail cases
386// if (my_data->pipelineLayoutMap.find(psoLayout) == my_data->pipelineLayoutMap.end()) {
387// skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE_LAYOUT, (uint64_t) psoLayout, 0, DRAWSTATE_INVALID_PIPELINE_LAYOUT, "DS",
388// "PSO bound invalid pipelineLayout object %#" PRIxLEAST64, (uint64_t) psoLayout);
389//// skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE_LAYOUT, psoLayout, 0, DRAWSTATE_INVALID_PIPELINE_LAYOUT, "DS",
390//// "Created Descriptor Pool %#" PRIxLEAST64, (uint64_t) psoLayout);
391// //"PSO bound invalid pipelineLayout object %#" PRIxLEAST64, (uint64_t) psoLayout);
392// }
393// if (my_data->pipelineLayoutMap.find(dsLayout) == my_data->pipelineLayoutMap.end()) {
394// skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE_LAYOUT, (uint64_t) dsLayout, 0, DRAWSTATE_INVALID_PIPELINE_LAYOUT, "DS",
395// "Invalid pipelineLayout object (%#" PRIxLEAST64 ") bound at last vkCmdBindDescriptorSets() call.", (uint64_t) dsLayout);
396// }
397// if (skipCall) // If we hit fail case above, return early to avoid crash
398// return skipCall;
399// // Two pipeline layouts are defined to be "compatible for set N" if they were created with matching
400// // (the same, or identically defined) descriptor set layouts for sets zero through N.
401// PIPELINE_LAYOUT_NODE psoPL = my_data->pipelineLayoutMap[psoLayout];
402// PIPELINE_LAYOUT_NODE dsPL = my_data->pipelineLayoutMap[dsLayout];
403// // If either pipelineLayout doesn't have enough layouts, they can't be compatible
404// if (numDescriptorSets > psoPL.descriptorSetLayouts.size()) {
405// skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE_LAYOUT, (uint64_t) dsLayout, 0, DRAWSTATE_INVALID_PIPELINE_LAYOUT, "DS",
406// "Invalid pipelineLayout object (%#" PRIxLEAST64 ") bound at last vkCmdBindDescriptorSets() call.", (uint64_t) dsLayout);
407// }
408// if (numDescriptorSets > dsPL.descriptorSetLayouts.size()) {
409// // Not enough layouts, can't be compatible
410// }
411// // Now check each matching layout to confirm compatibility
412// LAYOUT_NODE *pPSOLayout, *pDSLayout;
413// for (uint32_t i=0; i<numDescriptorSets; ++i) {
414// pPSOLayout = my_data->layoutMap[psoPL.descriptorSetLayouts[i]];
415// pDSLayout = my_data->layoutMap[dsPL.descriptorSetLayouts[i]];
416// if (pPSOLayout == pDSLayout)
417// continue;
418// if (pPSOLayout->descriptorTypes.size() != pDSLayout->descriptorTypes.size()) {
419// // ERROR : different sizes in layouts
420// }
421// // Need to verify that layouts are identically defined
422// // TODO : Is below sufficient? Making sure that types & stageFlags match per descriptor
423// for (uint32_t j=0; j<pPSOLayout->descriptorTypes.size(); ++j) {
424// if (pPSOLayout->descriptorTypes[j] != pDSLayout->descriptorTypes[j]) {
425// // ERROR : Report type mismatch
426// }
427// if (pPSOLayout->stageFlags[j] != pDSLayout->stageFlags[j]) {
428// // ERROR : Report flags mismatch
429// }
430// }
431// }
432// return skipCall;
433//}
434
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600435// Validate overall state at the time of a draw call
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600436static VkBool32 validate_draw_state(layer_data* my_data, GLOBAL_CB_NODE* pCB, VkBool32 indexedDraw) {
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600437 // First check flag states
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600438 VkBool32 result = validate_draw_state_flags(my_data, pCB, indexedDraw);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600439 PIPELINE_NODE* pPipe = getPipeline(my_data, pCB->lastBoundPipeline);
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600440 // Now complete other state checks
Tobin Ehlis12ab7dc2015-09-09 13:31:01 -0600441 // TODO : Currently only performing next check if *something* was bound (non-zero last bound)
442 // There is probably a better way to gate when this check happens, and to know if something *should* have been bound
443 // We should have that check separately and then gate this check based on that check
Tobin Ehlis982099b2015-11-05 09:52:49 -0700444 if (pPipe && (pCB->lastBoundPipelineLayout)) {
445 // TODO : For all sets used by the PSO, need to make sure that something is bound AND that PSO pipelineLayout is compatible with each bound set
446 // first trick is how to get the sets used by PSO. ShaderChecker does this so perhaps move that code to utils
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600447 }
Tobin Ehlisd28acef2015-09-09 15:12:35 -0600448 // Verify Vtx binding
449 if (MAX_BINDING != pCB->lastVtxBinding) {
450 if (pCB->lastVtxBinding >= pPipe->vtxBindingCount) {
451 if (0 == pPipe->vtxBindingCount) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600452 result |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS",
Tobin Ehlisd28acef2015-09-09 15:12:35 -0600453 "Vtx Buffer Index %u was bound, but no vtx buffers are attached to PSO.", pCB->lastVtxBinding);
Tobin Ehlisd28acef2015-09-09 15:12:35 -0600454 }
455 else {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600456 result |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS",
Tobin Ehlisd28acef2015-09-09 15:12:35 -0600457 "Vtx binding Index of %u exceeds PSO pVertexBindingDescriptions max array index of %u.", pCB->lastVtxBinding, (pPipe->vtxBindingCount - 1));
Tobin Ehlisd28acef2015-09-09 15:12:35 -0600458 }
459 }
460 }
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600461 // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count
462 VkBool32 dynViewport = isDynamic(pPipe, VK_DYNAMIC_STATE_VIEWPORT);
463 VkBool32 dynScissor = isDynamic(pPipe, VK_DYNAMIC_STATE_SCISSOR);
464 if (dynViewport) {
465 if (pCB->viewports.size() != pPipe->graphicsPipelineCI.pViewportState->viewportCount) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600466 result |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -0800467 "Dynamic viewportCount from vkCmdSetViewport() is " PRINTF_SIZE_T_SPECIFIER ", but PSO viewportCount is %u. These counts must match.", pCB->viewports.size(), pPipe->graphicsPipelineCI.pViewportState->viewportCount);
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600468 }
469 }
470 if (dynScissor) {
471 if (pCB->scissors.size() != pPipe->graphicsPipelineCI.pViewportState->scissorCount) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600472 result |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -0800473 "Dynamic scissorCount from vkCmdSetScissor() is " PRINTF_SIZE_T_SPECIFIER ", but PSO scissorCount is %u. These counts must match.", pCB->scissors.size(), pPipe->graphicsPipelineCI.pViewportState->scissorCount);
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600474 }
475 }
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600476 return result;
477}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700478
Tobin Ehlisde63c532015-06-18 15:59:33 -0600479// Verify that create state for a pipeline is valid
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600480static VkBool32 verifyPipelineCreateState(layer_data* my_data, const VkDevice device, const PIPELINE_NODE* pPipeline)
Tobin Ehlisde63c532015-06-18 15:59:33 -0600481{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600482 VkBool32 skipCall = VK_FALSE;
Tobin Ehlisde63c532015-06-18 15:59:33 -0600483 // VS is required
484 if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600485 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Tobin Ehlisde63c532015-06-18 15:59:33 -0600486 "Invalid Pipeline CreateInfo State: Vtx Shader required");
Tobin Ehlisde63c532015-06-18 15:59:33 -0600487 }
488 // Either both or neither TC/TE shaders should be defined
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -0600489 if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) !=
490 ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0) ) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600491 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Tobin Ehlisde63c532015-06-18 15:59:33 -0600492 "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair");
Tobin Ehlisde63c532015-06-18 15:59:33 -0600493 }
494 // Compute shaders should be specified independent of Gfx shaders
495 if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) &&
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -0600496 (pPipeline->active_shaders & (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT |
497 VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | VK_SHADER_STAGE_GEOMETRY_BIT |
Tobin Ehlisde63c532015-06-18 15:59:33 -0600498 VK_SHADER_STAGE_FRAGMENT_BIT))) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600499 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Tobin Ehlisde63c532015-06-18 15:59:33 -0600500 "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline");
Tobin Ehlisde63c532015-06-18 15:59:33 -0600501 }
Chia-I Wu99ba2bb2015-10-31 00:31:16 +0800502 // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines.
Tobin Ehlisde63c532015-06-18 15:59:33 -0600503 // Mismatching primitive topology and tessellation fails graphics pipeline creation.
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -0600504 if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) &&
Chia-I Wu99ba2bb2015-10-31 00:31:16 +0800505 (pPipeline->iaStateCI.topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600506 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Chia-I Wu99ba2bb2015-10-31 00:31:16 +0800507 "Invalid Pipeline CreateInfo State: VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA topology for tessellation pipelines");
Tobin Ehlisde63c532015-06-18 15:59:33 -0600508 }
Chia-I Wu99ba2bb2015-10-31 00:31:16 +0800509 if (pPipeline->iaStateCI.topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) {
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -0600510 if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600511 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Chia-I Wu99ba2bb2015-10-31 00:31:16 +0800512 "Invalid Pipeline CreateInfo State: VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines");
Tobin Ehlis20693172015-09-17 08:46:18 -0600513 }
514 if (!pPipeline->tessStateCI.patchControlPoints || (pPipeline->tessStateCI.patchControlPoints > 32)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600515 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Chia-I Wu99ba2bb2015-10-31 00:31:16 +0800516 "Invalid Pipeline CreateInfo State: VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology used with patchControlPoints value %u."
Tobin Ehlis20693172015-09-17 08:46:18 -0600517 " patchControlPoints should be >0 and <=32.", pPipeline->tessStateCI.patchControlPoints);
518 }
Tobin Ehlisde63c532015-06-18 15:59:33 -0600519 }
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600520 // Viewport state must be included and viewport and scissor counts should always match
Tobin Ehlis9e839e52015-10-01 11:15:13 -0600521 // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600522 if (!pPipeline->graphicsPipelineCI.pViewportState) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600523 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600524 "Gfx Pipeline pViewportState is null. Even if viewport and scissors are dynamic PSO must include viewportCount and scissorCount in pViewportState.");
525 } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != pPipeline->graphicsPipelineCI.pViewportState->viewportCount) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600526 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Tobin Ehlis9e839e52015-10-01 11:15:13 -0600527 "Gfx Pipeline viewport count (%u) must match scissor count (%u).", pPipeline->vpStateCI.viewportCount, pPipeline->vpStateCI.scissorCount);
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600528 } else {
529 // If viewport or scissor are not dynamic, then verify that data is appropriate for count
530 VkBool32 dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT);
531 VkBool32 dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR);
532 if (!dynViewport) {
533 if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && !pPipeline->graphicsPipelineCI.pViewportState->pViewports) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600534 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600535 "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you must either include pViewports data, or include viewport in pDynamicState and set it with vkCmdSetViewport().", pPipeline->graphicsPipelineCI.pViewportState->viewportCount);
Tobin Ehlis9e839e52015-10-01 11:15:13 -0600536 }
537 }
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600538 if (!dynScissor) {
539 if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && !pPipeline->graphicsPipelineCI.pViewportState->pScissors) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600540 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600541 "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you must either include pScissors data, or include scissor in pDynamicState and set it with vkCmdSetScissor().", pPipeline->graphicsPipelineCI.pViewportState->scissorCount);
542 }
Tobin Ehlis9e839e52015-10-01 11:15:13 -0600543 }
544 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600545 return skipCall;
Tobin Ehlisde63c532015-06-18 15:59:33 -0600546}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700547
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600548// Init the pipeline mapping info based on pipeline create info LL tree
549// Threading note : Calls to this function should wrapped in mutex
Chia-I Wuf273d5a2015-10-26 19:52:46 +0800550static PIPELINE_NODE* initPipeline(layer_data* dev_data, const VkGraphicsPipelineCreateInfo* pCreateInfo, PIPELINE_NODE* pBasePipeline)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600551{
Tobin Ehlisde63c532015-06-18 15:59:33 -0600552 PIPELINE_NODE* pPipeline = new PIPELINE_NODE;
553 if (pBasePipeline) {
554 memcpy((void*)pPipeline, (void*)pBasePipeline, sizeof(PIPELINE_NODE));
Tobin Ehlise42007c2015-06-19 13:00:59 -0600555 } else {
Tobin Ehlisde63c532015-06-18 15:59:33 -0600556 memset((void*)pPipeline, 0, sizeof(PIPELINE_NODE));
557 }
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600558 // First init create info
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -0600559 memcpy(&pPipeline->graphicsPipelineCI, pCreateInfo, sizeof(VkGraphicsPipelineCreateInfo));
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600560
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600561 size_t bufferSize = 0;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600562 const VkPipelineVertexInputStateCreateInfo* pVICI = NULL;
Tobin Ehlis59db5712015-07-13 13:14:24 -0600563 const VkPipelineColorBlendStateCreateInfo* pCBCI = NULL;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600564
565 for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) {
566 const VkPipelineShaderStageCreateInfo *pPSSCI = &pCreateInfo->pStages[i];
567
Chia-I Wu062ad152015-10-31 00:31:16 +0800568 switch (pPSSCI->stage) {
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -0600569 case VK_SHADER_STAGE_VERTEX_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600570 memcpy(&pPipeline->vsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
571 pPipeline->active_shaders |= VK_SHADER_STAGE_VERTEX_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600572 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -0600573 case VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600574 memcpy(&pPipeline->tcsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -0600575 pPipeline->active_shaders |= VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600576 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -0600577 case VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600578 memcpy(&pPipeline->tesCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -0600579 pPipeline->active_shaders |= VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600580 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -0600581 case VK_SHADER_STAGE_GEOMETRY_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600582 memcpy(&pPipeline->gsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
583 pPipeline->active_shaders |= VK_SHADER_STAGE_GEOMETRY_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600584 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -0600585 case VK_SHADER_STAGE_FRAGMENT_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600586 memcpy(&pPipeline->fsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
587 pPipeline->active_shaders |= VK_SHADER_STAGE_FRAGMENT_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600588 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -0600589 case VK_SHADER_STAGE_COMPUTE_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600590 // TODO : Flag error, CS is specified through VkComputePipelineCreateInfo
591 pPipeline->active_shaders |= VK_SHADER_STAGE_COMPUTE_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600592 break;
593 default:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600594 // TODO : Flag error
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600595 break;
596 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600597 }
Tobin Ehlisf6cb4672015-09-29 08:18:34 -0600598 // Copy over GraphicsPipelineCreateInfo structure embedded pointers
599 if (pCreateInfo->stageCount != 0) {
600 pPipeline->graphicsPipelineCI.pStages = new VkPipelineShaderStageCreateInfo[pCreateInfo->stageCount];
601 bufferSize = pCreateInfo->stageCount * sizeof(VkPipelineShaderStageCreateInfo);
602 memcpy((void*)pPipeline->graphicsPipelineCI.pStages, pCreateInfo->pStages, bufferSize);
603 }
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600604 if (pCreateInfo->pVertexInputState != NULL) {
605 memcpy((void*)&pPipeline->vertexInputCI, pCreateInfo->pVertexInputState , sizeof(VkPipelineVertexInputStateCreateInfo));
606 // Copy embedded ptrs
607 pVICI = pCreateInfo->pVertexInputState;
Chia-I Wu763a7492015-10-26 20:48:51 +0800608 pPipeline->vtxBindingCount = pVICI->vertexBindingDescriptionCount;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600609 if (pPipeline->vtxBindingCount) {
610 pPipeline->pVertexBindingDescriptions = new VkVertexInputBindingDescription[pPipeline->vtxBindingCount];
611 bufferSize = pPipeline->vtxBindingCount * sizeof(VkVertexInputBindingDescription);
612 memcpy((void*)pPipeline->pVertexBindingDescriptions, pVICI->pVertexBindingDescriptions, bufferSize);
613 }
Chia-I Wu763a7492015-10-26 20:48:51 +0800614 pPipeline->vtxAttributeCount = pVICI->vertexAttributeDescriptionCount;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600615 if (pPipeline->vtxAttributeCount) {
616 pPipeline->pVertexAttributeDescriptions = new VkVertexInputAttributeDescription[pPipeline->vtxAttributeCount];
617 bufferSize = pPipeline->vtxAttributeCount * sizeof(VkVertexInputAttributeDescription);
618 memcpy((void*)pPipeline->pVertexAttributeDescriptions, pVICI->pVertexAttributeDescriptions, bufferSize);
619 }
620 pPipeline->graphicsPipelineCI.pVertexInputState = &pPipeline->vertexInputCI;
621 }
Tony Barboure307f582015-07-10 15:29:03 -0600622 if (pCreateInfo->pInputAssemblyState != NULL) {
623 memcpy((void*)&pPipeline->iaStateCI, pCreateInfo->pInputAssemblyState, sizeof(VkPipelineInputAssemblyStateCreateInfo));
624 pPipeline->graphicsPipelineCI.pInputAssemblyState = &pPipeline->iaStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600625 }
Tony Barboure307f582015-07-10 15:29:03 -0600626 if (pCreateInfo->pTessellationState != NULL) {
627 memcpy((void*)&pPipeline->tessStateCI, pCreateInfo->pTessellationState, sizeof(VkPipelineTessellationStateCreateInfo));
628 pPipeline->graphicsPipelineCI.pTessellationState = &pPipeline->tessStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600629 }
Tony Barboure307f582015-07-10 15:29:03 -0600630 if (pCreateInfo->pViewportState != NULL) {
631 memcpy((void*)&pPipeline->vpStateCI, pCreateInfo->pViewportState, sizeof(VkPipelineViewportStateCreateInfo));
632 pPipeline->graphicsPipelineCI.pViewportState = &pPipeline->vpStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600633 }
Chia-I Wu1f851912015-10-27 18:04:07 +0800634 if (pCreateInfo->pRasterizationState != NULL) {
635 memcpy((void*)&pPipeline->rsStateCI, pCreateInfo->pRasterizationState, sizeof(VkPipelineRasterizationStateCreateInfo));
636 pPipeline->graphicsPipelineCI.pRasterizationState = &pPipeline->rsStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600637 }
Tony Barboure307f582015-07-10 15:29:03 -0600638 if (pCreateInfo->pMultisampleState != NULL) {
639 memcpy((void*)&pPipeline->msStateCI, pCreateInfo->pMultisampleState, sizeof(VkPipelineMultisampleStateCreateInfo));
640 pPipeline->graphicsPipelineCI.pMultisampleState = &pPipeline->msStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600641 }
Tobin Ehlisf6cb4672015-09-29 08:18:34 -0600642 if (pCreateInfo->pDepthStencilState != NULL) {
643 memcpy((void*)&pPipeline->dsStateCI, pCreateInfo->pDepthStencilState, sizeof(VkPipelineDepthStencilStateCreateInfo));
644 pPipeline->graphicsPipelineCI.pDepthStencilState = &pPipeline->dsStateCI;
645 }
Tony Barboure307f582015-07-10 15:29:03 -0600646 if (pCreateInfo->pColorBlendState != NULL) {
647 memcpy((void*)&pPipeline->cbStateCI, pCreateInfo->pColorBlendState, sizeof(VkPipelineColorBlendStateCreateInfo));
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600648 // Copy embedded ptrs
Tony Barboure307f582015-07-10 15:29:03 -0600649 pCBCI = pCreateInfo->pColorBlendState;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600650 pPipeline->attachmentCount = pCBCI->attachmentCount;
651 if (pPipeline->attachmentCount) {
Tony Barboure307f582015-07-10 15:29:03 -0600652 pPipeline->pAttachments = new VkPipelineColorBlendAttachmentState[pPipeline->attachmentCount];
653 bufferSize = pPipeline->attachmentCount * sizeof(VkPipelineColorBlendAttachmentState);
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600654 memcpy((void*)pPipeline->pAttachments, pCBCI->pAttachments, bufferSize);
655 }
Tony Barboure307f582015-07-10 15:29:03 -0600656 pPipeline->graphicsPipelineCI.pColorBlendState = &pPipeline->cbStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600657 }
Tobin Ehlisf6cb4672015-09-29 08:18:34 -0600658 if (pCreateInfo->pDynamicState != NULL) {
659 memcpy((void*)&pPipeline->dynStateCI, pCreateInfo->pDynamicState, sizeof(VkPipelineDynamicStateCreateInfo));
660 if (pPipeline->dynStateCI.dynamicStateCount) {
661 pPipeline->dynStateCI.pDynamicStates = new VkDynamicState[pPipeline->dynStateCI.dynamicStateCount];
662 bufferSize = pPipeline->dynStateCI.dynamicStateCount * sizeof(VkDynamicState);
663 memcpy((void*)pPipeline->dynStateCI.pDynamicStates, pCreateInfo->pDynamicState->pDynamicStates, bufferSize);
664 }
665 pPipeline->graphicsPipelineCI.pDynamicState = &pPipeline->dynStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600666 }
667
Tobin Ehlisde63c532015-06-18 15:59:33 -0600668 return pPipeline;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600669}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700670
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600671// Free the Pipeline nodes
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600672static void deletePipelines(layer_data* my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600673{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600674 if (my_data->pipelineMap.size() <= 0)
David Pinedof5997ab2015-04-27 16:36:17 -0600675 return;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600676 for (auto ii=my_data->pipelineMap.begin(); ii!=my_data->pipelineMap.end(); ++ii) {
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600677 if ((*ii).second->graphicsPipelineCI.stageCount != 0) {
678 delete[] (*ii).second->graphicsPipelineCI.pStages;
679 }
Tobin Ehliscd3109e2015-04-01 11:59:08 -0600680 if ((*ii).second->pVertexBindingDescriptions) {
681 delete[] (*ii).second->pVertexBindingDescriptions;
682 }
683 if ((*ii).second->pVertexAttributeDescriptions) {
684 delete[] (*ii).second->pVertexAttributeDescriptions;
685 }
686 if ((*ii).second->pAttachments) {
687 delete[] (*ii).second->pAttachments;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600688 }
Tobin Ehlisf6cb4672015-09-29 08:18:34 -0600689 if ((*ii).second->dynStateCI.dynamicStateCount != 0) {
690 delete[] (*ii).second->dynStateCI.pDynamicStates;
691 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600692 delete (*ii).second;
693 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600694 my_data->pipelineMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600695}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700696
Tobin Ehlis2464b882015-04-01 08:40:34 -0600697// For given pipeline, return number of MSAA samples, or one if MSAA disabled
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800698static VkSampleCountFlagBits getNumSamples(layer_data* my_data, const VkPipeline pipeline)
Tobin Ehlis2464b882015-04-01 08:40:34 -0600699{
Chia-I Wue420a332015-10-26 20:04:44 +0800700 PIPELINE_NODE* pPipe = my_data->pipelineMap[pipeline];
Tobin Ehlisb3a506f2015-07-13 14:51:15 -0600701 if (VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pPipe->msStateCI.sType) {
Chia-I Wu1f851912015-10-27 18:04:07 +0800702 return pPipe->msStateCI.rasterizationSamples;
Tobin Ehlisb3a506f2015-07-13 14:51:15 -0600703 }
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800704 return VK_SAMPLE_COUNT_1_BIT;
Tobin Ehlis2464b882015-04-01 08:40:34 -0600705}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700706
Tobin Ehlis2464b882015-04-01 08:40:34 -0600707// Validate state related to the PSO
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600708static VkBool32 validatePipelineState(layer_data* my_data, const GLOBAL_CB_NODE* pCB, const VkPipelineBindPoint pipelineBindPoint, const VkPipeline pipeline)
Tobin Ehlis2464b882015-04-01 08:40:34 -0600709{
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -0600710 if (VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) {
Tobin Ehlis2464b882015-04-01 08:40:34 -0600711 // Verify that any MSAA request in PSO matches sample# in bound FB
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800712 VkSampleCountFlagBits psoNumSamples = getNumSamples(my_data, pipeline);
Tobin Ehlis2464b882015-04-01 08:40:34 -0600713 if (pCB->activeRenderPass) {
Michael Lentine07ff1a12015-10-15 17:07:00 -0500714 const VkRenderPassCreateInfo* pRPCI = my_data->renderPassMap[pCB->activeRenderPass]->createInfo;
Chia-I Wuc278df82015-07-07 11:50:03 +0800715 const VkSubpassDescription* pSD = &pRPCI->pSubpasses[pCB->activeSubpass];
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800716 VkSampleCountFlagBits subpassNumSamples = (VkSampleCountFlagBits) 0;
Chia-I Wuc278df82015-07-07 11:50:03 +0800717 uint32_t i;
718
Chia-I Wu763a7492015-10-26 20:48:51 +0800719 for (i = 0; i < pSD->colorAttachmentCount; i++) {
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800720 VkSampleCountFlagBits samples;
Chia-I Wuc278df82015-07-07 11:50:03 +0800721
Cody Northrop6de6b0b2015-08-04 11:16:41 -0600722 if (pSD->pColorAttachments[i].attachment == VK_ATTACHMENT_UNUSED)
Chia-I Wuc278df82015-07-07 11:50:03 +0800723 continue;
724
Cody Northrop6de6b0b2015-08-04 11:16:41 -0600725 samples = pRPCI->pAttachments[pSD->pColorAttachments[i].attachment].samples;
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800726 if (subpassNumSamples == (VkSampleCountFlagBits) 0) {
Chia-I Wuc278df82015-07-07 11:50:03 +0800727 subpassNumSamples = samples;
728 } else if (subpassNumSamples != samples) {
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800729 subpassNumSamples = (VkSampleCountFlagBits) -1;
Chia-I Wuc278df82015-07-07 11:50:03 +0800730 break;
731 }
732 }
Chia-I Wuce532f72015-10-26 17:32:47 +0800733 if (pSD->pDepthStencilAttachment && pSD->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) {
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800734 const VkSampleCountFlagBits samples = pRPCI->pAttachments[pSD->pDepthStencilAttachment->attachment].samples;
735 if (subpassNumSamples == (VkSampleCountFlagBits) 0)
Chia-I Wuc278df82015-07-07 11:50:03 +0800736 subpassNumSamples = samples;
737 else if (subpassNumSamples != samples)
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800738 subpassNumSamples = (VkSampleCountFlagBits) -1;
Chia-I Wuc278df82015-07-07 11:50:03 +0800739 }
740
741 if (psoNumSamples != subpassNumSamples) {
Chia-I Wue420a332015-10-26 20:04:44 +0800742 return log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE, (uint64_t) pipeline, 0, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS",
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -0600743 "Num samples mismatch! Binding PSO (%#" PRIxLEAST64 ") with %u samples while current RenderPass (%#" PRIxLEAST64 ") w/ %u samples!",
Chia-I Wue420a332015-10-26 20:04:44 +0800744 (uint64_t) pipeline, psoNumSamples, (uint64_t) pCB->activeRenderPass, subpassNumSamples);
Tobin Ehlis2464b882015-04-01 08:40:34 -0600745 }
746 } else {
747 // TODO : I believe it's an error if we reach this point and don't have an activeRenderPass
748 // Verify and flag error as appropriate
749 }
750 // TODO : Add more checks here
751 } else {
752 // TODO : Validate non-gfx pipeline updates
753 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600754 return VK_FALSE;
Tobin Ehlis2464b882015-04-01 08:40:34 -0600755}
756
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600757// Block of code at start here specifically for managing/tracking DSs
758
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600759// Return Pool node ptr for specified pool or else NULL
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -0700760static DESCRIPTOR_POOL_NODE* getPoolNode(layer_data* my_data, const VkDescriptorPool pool)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600761{
762 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -0700763 if (my_data->descriptorPoolMap.find(pool) == my_data->descriptorPoolMap.end()) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600764 loader_platform_thread_unlock_mutex(&globalLock);
765 return NULL;
766 }
767 loader_platform_thread_unlock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -0700768 return my_data->descriptorPoolMap[pool];
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600769}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700770
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600771// Return Set node ptr for specified set or else NULL
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600772static SET_NODE* getSetNode(layer_data* my_data, const VkDescriptorSet set)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600773{
774 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +0800775 if (my_data->setMap.find(set) == my_data->setMap.end()) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600776 loader_platform_thread_unlock_mutex(&globalLock);
777 return NULL;
778 }
779 loader_platform_thread_unlock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +0800780 return my_data->setMap[set];
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600781}
782
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600783static LAYOUT_NODE* getLayoutNode(layer_data* my_data, const VkDescriptorSetLayout layout) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600784 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +0800785 if (my_data->layoutMap.find(layout) == my_data->layoutMap.end()) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600786 loader_platform_thread_unlock_mutex(&globalLock);
787 return NULL;
788 }
789 loader_platform_thread_unlock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +0800790 return my_data->layoutMap[layout];
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600791}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700792
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600793// Return VK_FALSE if update struct is of valid type, otherwise flag error and return code from callback
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600794static VkBool32 validUpdateStruct(layer_data* my_data, const VkDevice device, const GENERIC_HEADER* pUpdateStruct)
Tobin Ehlis0b551cd2015-05-28 12:10:17 -0600795{
Tobin Ehlis0b551cd2015-05-28 12:10:17 -0600796 switch (pUpdateStruct->sType)
797 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800798 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
799 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600800 return VK_FALSE;
Tobin Ehlis0b551cd2015-05-28 12:10:17 -0600801 default:
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600802 return log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_UPDATE_STRUCT, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -0600803 "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType);
Tobin Ehlis0b551cd2015-05-28 12:10:17 -0600804 }
805}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700806
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600807// Set count for given update struct in the last parameter
808// Return value of skipCall, which is only VK_TRUE is error occurs and callback signals execution to cease
Tobin Ehlise66ec962015-10-27 12:54:50 -0600809static uint32_t getUpdateCount(layer_data* my_data, const VkDevice device, const GENERIC_HEADER* pUpdateStruct)
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600810{
811 switch (pUpdateStruct->sType)
812 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800813 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
Chia-I Wu763a7492015-10-26 20:48:51 +0800814 return ((VkWriteDescriptorSet*)pUpdateStruct)->descriptorCount;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800815 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600816 // TODO : Need to understand this case better and make sure code is correct
Chia-I Wu763a7492015-10-26 20:48:51 +0800817 return ((VkCopyDescriptorSet*)pUpdateStruct)->descriptorCount;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600818 }
819}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700820
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600821// For given Layout Node and binding, return index where that binding begins
822static uint32_t getBindingStartIndex(const LAYOUT_NODE* pLayout, const uint32_t binding)
823{
824 uint32_t offsetIndex = 0;
Chia-I Wub5689ee2015-10-31 00:31:16 +0800825 for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) {
826 if (pLayout->createInfo.pBinding[i].binding == binding)
827 break;
Chia-I Wu045654f2015-11-06 06:42:02 +0800828 offsetIndex += pLayout->createInfo.pBinding[i].descriptorCount;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600829 }
830 return offsetIndex;
831}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700832
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600833// For given layout node and binding, return last index that is updated
834static uint32_t getBindingEndIndex(const LAYOUT_NODE* pLayout, const uint32_t binding)
835{
836 uint32_t offsetIndex = 0;
Chia-I Wub5689ee2015-10-31 00:31:16 +0800837 for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) {
Chia-I Wu045654f2015-11-06 06:42:02 +0800838 offsetIndex += pLayout->createInfo.pBinding[i].descriptorCount;
Chia-I Wub5689ee2015-10-31 00:31:16 +0800839 if (pLayout->createInfo.pBinding[i].binding == binding)
840 break;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600841 }
842 return offsetIndex-1;
843}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700844
Tobin Ehlise66ec962015-10-27 12:54:50 -0600845// For given layout and update, return the first overall index of the layout that is updated
Tobin Ehlisd2e246e2015-10-27 15:43:38 -0600846static uint32_t getUpdateStartIndex(layer_data* my_data, const VkDevice device, const LAYOUT_NODE* pLayout, const uint32_t binding, const uint32_t arrayIndex, const GENERIC_HEADER* pUpdateStruct)
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600847{
Tobin Ehlise66ec962015-10-27 12:54:50 -0600848 return getBindingStartIndex(pLayout, binding)+arrayIndex;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600849}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700850
Tobin Ehlisd2e246e2015-10-27 15:43:38 -0600851// For given layout and update, return the last overall index of the layout that is updated
852static uint32_t getUpdateEndIndex(layer_data* my_data, const VkDevice device, const LAYOUT_NODE* pLayout, const uint32_t binding, const uint32_t arrayIndex, const GENERIC_HEADER* pUpdateStruct)
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600853{
Tobin Ehlisd2e246e2015-10-27 15:43:38 -0600854 uint32_t count = getUpdateCount(my_data, device, pUpdateStruct);
Tobin Ehlise66ec962015-10-27 12:54:50 -0600855 return getBindingStartIndex(pLayout, binding)+arrayIndex+count-1;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600856}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700857
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600858// Verify that the descriptor type in the update struct matches what's expected by the layout
Tobin Ehlis68fbd442015-10-27 12:25:35 -0600859static VkBool32 validateUpdateConsistency(layer_data* my_data, const VkDevice device, const LAYOUT_NODE* pLayout, const GENERIC_HEADER* pUpdateStruct, uint32_t startIndex, uint32_t endIndex)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600860{
861 // First get actual type of update
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600862 VkBool32 skipCall = VK_FALSE;
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -0600863 VkDescriptorType actualType;
Tobin Ehlis68fbd442015-10-27 12:25:35 -0600864 uint32_t i = 0;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600865 switch (pUpdateStruct->sType)
866 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800867 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
868 actualType = ((VkWriteDescriptorSet*)pUpdateStruct)->descriptorType;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600869 break;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800870 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
871 /* no need to validate */
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600872 return VK_FALSE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600873 break;
874 default:
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600875 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_UPDATE_STRUCT, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -0600876 "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType);
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600877 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600878 if (VK_FALSE == skipCall) {
Tobin Ehlis68fbd442015-10-27 12:25:35 -0600879 // Set first stageFlags as reference and verify that all other updates match it
880 VkShaderStageFlags refStageFlags = pLayout->stageFlags[startIndex];
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600881 for (i = startIndex; i <= endIndex; i++) {
Tobin Ehlis91423d22015-10-20 10:11:55 -0600882 if (pLayout->descriptorTypes[i] != actualType) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600883 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS",
Tobin Ehlis68fbd442015-10-27 12:25:35 -0600884 "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!",
885 string_VkDescriptorType(actualType), string_VkDescriptorType(pLayout->descriptorTypes[i]));
886 }
887 if (pLayout->stageFlags[i] != refStageFlags) {
888 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_DESCRIPTOR_STAGEFLAGS_MISMATCH, "DS",
889 "Write descriptor update has stageFlags %x that do not match overlapping binding descriptor stageFlags of %x!",
890 refStageFlags, pLayout->stageFlags[i]);
Tobin Ehlis3b341092015-09-30 08:30:20 -0600891 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600892 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600893 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600894 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600895}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700896
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600897// Determine the update type, allocate a new struct of that type, shadow the given pUpdate
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600898// struct into the pNewNode param. Return VK_TRUE if error condition encountered and callback signals early exit.
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600899// NOTE : Calls to this function should be wrapped in mutex
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600900static VkBool32 shadowUpdateNode(layer_data* my_data, const VkDevice device, GENERIC_HEADER* pUpdate, GENERIC_HEADER** pNewNode)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600901{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600902 VkBool32 skipCall = VK_FALSE;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800903 VkWriteDescriptorSet* pWDS = NULL;
904 VkCopyDescriptorSet* pCDS = NULL;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600905 size_t array_size = 0;
906 size_t base_array_size = 0;
907 size_t total_array_size = 0;
908 size_t baseBuffAddr = 0;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600909 switch (pUpdate->sType)
910 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800911 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
912 pWDS = new VkWriteDescriptorSet;
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600913 *pNewNode = (GENERIC_HEADER*)pWDS;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800914 memcpy(pWDS, pUpdate, sizeof(VkWriteDescriptorSet));
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -0600915
916 switch (pWDS->descriptorType) {
917 case VK_DESCRIPTOR_TYPE_SAMPLER:
918 case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
919 case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
920 case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
921 {
Chia-I Wu763a7492015-10-26 20:48:51 +0800922 VkDescriptorImageInfo *info = new VkDescriptorImageInfo[pWDS->descriptorCount];
923 memcpy(info, pWDS->pImageInfo, pWDS->descriptorCount * sizeof(VkDescriptorImageInfo));
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -0600924 pWDS->pImageInfo = info;
925 }
926 break;
927 case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
928 case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
929 {
Chia-I Wu763a7492015-10-26 20:48:51 +0800930 VkBufferView *info = new VkBufferView[pWDS->descriptorCount];
931 memcpy(info, pWDS->pTexelBufferView, pWDS->descriptorCount * sizeof(VkBufferView));
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -0600932 pWDS->pTexelBufferView = info;
933 }
934 break;
935 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER:
936 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER:
937 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
938 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
939 {
Chia-I Wu763a7492015-10-26 20:48:51 +0800940 VkDescriptorBufferInfo *info = new VkDescriptorBufferInfo[pWDS->descriptorCount];
941 memcpy(info, pWDS->pBufferInfo, pWDS->descriptorCount * sizeof(VkDescriptorBufferInfo));
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -0600942 pWDS->pBufferInfo = info;
943 }
944 break;
945 default:
946 return VK_ERROR_VALIDATION_FAILED;
947 break;
948 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600949 break;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800950 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
951 pCDS = new VkCopyDescriptorSet;
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600952 *pNewNode = (GENERIC_HEADER*)pCDS;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800953 memcpy(pCDS, pUpdate, sizeof(VkCopyDescriptorSet));
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600954 break;
955 default:
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600956 if (log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_UPDATE_STRUCT, "DS",
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600957 "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", string_VkStructureType(pUpdate->sType), pUpdate->sType))
958 return VK_TRUE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600959 }
960 // Make sure that pNext for the end of shadow copy is NULL
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600961 (*pNewNode)->pNext = NULL;
962 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600963}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700964
Tobin Ehlisb46be812015-10-23 16:00:08 -0600965// Verify that given sampler is valid
966static VkBool32 validateSampler(const layer_data* my_data, const VkSampler* pSampler, const VkBool32 immutable)
967{
968 VkBool32 skipCall = VK_FALSE;
Chia-I Wue420a332015-10-26 20:04:44 +0800969 auto sampIt = my_data->sampleMap.find(*pSampler);
Tobin Ehlisb46be812015-10-23 16:00:08 -0600970 if (sampIt == my_data->sampleMap.end()) {
971 if (!immutable) {
Chia-I Wue420a332015-10-26 20:04:44 +0800972 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_SAMPLER, (uint64_t) *pSampler, 0, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS",
973 "vkUpdateDescriptorSets: Attempt to update descriptor with invalid sampler %#" PRIxLEAST64, (uint64_t) *pSampler);
Tobin Ehlisb46be812015-10-23 16:00:08 -0600974 } else { // immutable
Chia-I Wue420a332015-10-26 20:04:44 +0800975 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_SAMPLER, (uint64_t) *pSampler, 0, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS",
976 "vkUpdateDescriptorSets: Attempt to update descriptor whose binding has an invalid immutable sampler %#" PRIxLEAST64, (uint64_t) *pSampler);
Tobin Ehlisb46be812015-10-23 16:00:08 -0600977 }
978 } else {
979 // TODO : Any further checks we want to do on the sampler?
980 }
981 return skipCall;
982}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700983
Tobin Ehlisb46be812015-10-23 16:00:08 -0600984// Verify that given imageView is valid
985static VkBool32 validateImageView(const layer_data* my_data, const VkImageView* pImageView, const VkImageLayout imageLayout)
986{
987 VkBool32 skipCall = VK_FALSE;
Chia-I Wue420a332015-10-26 20:04:44 +0800988 auto ivIt = my_data->imageViewMap.find(*pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -0600989 if (ivIt == my_data->imageViewMap.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +0800990 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE_VIEW, (uint64_t) *pImageView, 0, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS",
991 "vkUpdateDescriptorSets: Attempt to update descriptor with invalid imageView %#" PRIxLEAST64, (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -0600992 } else {
993 // Validate that imageLayout is compatible with aspectMask and image format
994 VkImageAspectFlags aspectMask = ivIt->second->subresourceRange.aspectMask;
Chia-I Wue420a332015-10-26 20:04:44 +0800995 VkImage image = ivIt->second->image;
Michael Lentineee4ad4d2015-10-23 12:41:44 -0700996 // TODO : Check here in case we have a bad image
Chia-I Wue420a332015-10-26 20:04:44 +0800997 auto imgIt = my_data->imageMap.find(image);
Tobin Ehlisb46be812015-10-23 16:00:08 -0600998 if (imgIt == my_data->imageMap.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +0800999 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE, (uint64_t) image, 0, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS",
Michael Lentineee4ad4d2015-10-23 12:41:44 -07001000 "vkUpdateDescriptorSets: Attempt to update descriptor with invalid image %#" PRIxLEAST64 " in imageView %#" PRIxLEAST64, (uint64_t) image, (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001001 } else {
1002 VkFormat format = (*imgIt).second->format;
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07001003 VkBool32 ds = vk_format_is_depth_or_stencil(format);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001004 switch (imageLayout) {
1005 case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL:
1006 // Only Color bit must be set
1007 if ((aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) != VK_IMAGE_ASPECT_COLOR_BIT) {
Chia-I Wue420a332015-10-26 20:04:44 +08001008 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE_VIEW, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001009 DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL and imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001010 " that does not have VK_IMAGE_ASPECT_COLOR_BIT set.", (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001011 }
1012 // format must NOT be DS
1013 if (ds) {
Chia-I Wue420a332015-10-26 20:04:44 +08001014 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE_VIEW, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001015 DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL and imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001016 " but the image format is %s which is not a color format.", (uint64_t) *pImageView, string_VkFormat(format));
Tobin Ehlisb46be812015-10-23 16:00:08 -06001017 }
1018 break;
1019 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL:
1020 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL:
1021 // Depth or stencil bit must be set, but both must NOT be set
1022 if (aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) {
1023 if (aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT) {
1024 // both must NOT be set
Chia-I Wue420a332015-10-26 20:04:44 +08001025 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE_VIEW, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001026 DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", "vkUpdateDescriptorSets: Updating descriptor with imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001027 " that has both STENCIL and DEPTH aspects set", (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001028 }
1029 } else if (!(aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT)) {
1030 // Neither were set
Chia-I Wue420a332015-10-26 20:04:44 +08001031 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE_VIEW, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001032 DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001033 " that does not have STENCIL or DEPTH aspect set.", string_VkImageLayout(imageLayout), (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001034 }
1035 // format must be DS
1036 if (!ds) {
Chia-I Wue420a332015-10-26 20:04:44 +08001037 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE_VIEW, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001038 DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001039 " but the image format is %s which is not a depth/stencil format.", string_VkImageLayout(imageLayout), (uint64_t) *pImageView, string_VkFormat(format));
Tobin Ehlisb46be812015-10-23 16:00:08 -06001040 }
1041 break;
1042 default:
1043 // anything to check for other layouts?
1044 break;
1045 }
1046 }
1047 }
1048 return skipCall;
1049}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001050
Tobin Ehlisb46be812015-10-23 16:00:08 -06001051// Verify that given bufferView is valid
1052static VkBool32 validateBufferView(const layer_data* my_data, const VkBufferView* pBufferView)
1053{
1054 VkBool32 skipCall = VK_FALSE;
Chia-I Wue420a332015-10-26 20:04:44 +08001055 auto sampIt = my_data->bufferViewMap.find(*pBufferView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001056 if (sampIt == my_data->bufferViewMap.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +08001057 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_BUFFER_VIEW, (uint64_t) *pBufferView, 0, DRAWSTATE_BUFFERVIEW_DESCRIPTOR_ERROR, "DS",
1058 "vkUpdateDescriptorSets: Attempt to update descriptor with invalid bufferView %#" PRIxLEAST64, (uint64_t) *pBufferView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001059 } else {
1060 // TODO : Any further checks we want to do on the bufferView?
1061 }
1062 return skipCall;
1063}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001064
Tobin Ehlisb46be812015-10-23 16:00:08 -06001065// Verify that given bufferInfo is valid
1066static VkBool32 validateBufferInfo(const layer_data* my_data, const VkDescriptorBufferInfo* pBufferInfo)
1067{
1068 VkBool32 skipCall = VK_FALSE;
Chia-I Wue420a332015-10-26 20:04:44 +08001069 auto sampIt = my_data->bufferMap.find(pBufferInfo->buffer);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001070 if (sampIt == my_data->bufferMap.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +08001071 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_BUFFER, (uint64_t) pBufferInfo->buffer, 0, DRAWSTATE_BUFFERINFO_DESCRIPTOR_ERROR, "DS",
1072 "vkUpdateDescriptorSets: Attempt to update descriptor where bufferInfo has invalid buffer %#" PRIxLEAST64, (uint64_t) pBufferInfo->buffer);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001073 } else {
1074 // TODO : Any further checks we want to do on the bufferView?
1075 }
1076 return skipCall;
1077}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001078
Tobin Ehlisb46be812015-10-23 16:00:08 -06001079static VkBool32 validateUpdateContents(const layer_data* my_data, const VkWriteDescriptorSet *pWDS, const VkDescriptorSetLayoutBinding* pLayoutBinding)
1080{
1081 VkBool32 skipCall = VK_FALSE;
1082 // First verify that for the given Descriptor type, the correct DescriptorInfo data is supplied
1083 VkBufferView* pBufferView = NULL;
1084 const VkSampler* pSampler = NULL;
1085 VkImageView* pImageView = NULL;
1086 VkImageLayout* pImageLayout = NULL;
1087 VkDescriptorBufferInfo* pBufferInfo = NULL;
1088 VkBool32 immutable = VK_FALSE;
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001089 uint32_t i = 0;
1090 // For given update type, verify that update contents are correct
1091 switch (pWDS->descriptorType) {
1092 case VK_DESCRIPTOR_TYPE_SAMPLER:
Chia-I Wu763a7492015-10-26 20:48:51 +08001093 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001094 skipCall |= validateSampler(my_data, &(pWDS->pImageInfo[i].sampler), immutable);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001095 }
1096 break;
1097 case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
Chia-I Wu763a7492015-10-26 20:48:51 +08001098 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001099 if (NULL == pLayoutBinding->pImmutableSamplers) {
1100 pSampler = &(pWDS->pImageInfo[i].sampler);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001101 if (immutable) {
Chia-I Wue420a332015-10-26 20:04:44 +08001102 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_SAMPLER, (uint64_t) *pSampler, 0, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS",
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001103 "vkUpdateDescriptorSets: Update #%u is not an immutable sampler %#" PRIxLEAST64 ", but previous update(s) from this "
1104 "VkWriteDescriptorSet struct used an immutable sampler. All updates from a single struct must either "
Chia-I Wue420a332015-10-26 20:04:44 +08001105 "use immutable or non-immutable samplers.", i, (uint64_t) *pSampler);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001106 }
Tobin Ehlisb46be812015-10-23 16:00:08 -06001107 } else {
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001108 if (i>0 && !immutable) {
Chia-I Wue420a332015-10-26 20:04:44 +08001109 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_SAMPLER, (uint64_t) *pSampler, 0, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS",
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001110 "vkUpdateDescriptorSets: Update #%u is an immutable sampler, but previous update(s) from this "
1111 "VkWriteDescriptorSet struct used a non-immutable sampler. All updates from a single struct must either "
1112 "use immutable or non-immutable samplers.", i);
1113 }
Tobin Ehlisb46be812015-10-23 16:00:08 -06001114 immutable = VK_TRUE;
1115 pSampler = &(pLayoutBinding->pImmutableSamplers[i]);
1116 }
1117 skipCall |= validateSampler(my_data, pSampler, immutable);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001118 }
1119 // Intentionally fall through here to also validate image stuff
1120 case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
1121 case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
1122 case VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT:
Chia-I Wu763a7492015-10-26 20:48:51 +08001123 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001124 skipCall |= validateImageView(my_data, &(pWDS->pImageInfo[i].imageView), pWDS->pImageInfo[i].imageLayout);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001125 }
1126 break;
1127 case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
1128 case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
Chia-I Wu763a7492015-10-26 20:48:51 +08001129 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001130 skipCall |= validateBufferView(my_data, &(pWDS->pTexelBufferView[i]));
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001131 }
1132 break;
1133 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER:
1134 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER:
1135 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
1136 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
Chia-I Wu763a7492015-10-26 20:48:51 +08001137 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001138 skipCall |= validateBufferInfo(my_data, &(pWDS->pBufferInfo[i]));
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001139 }
1140 break;
Tobin Ehlisb46be812015-10-23 16:00:08 -06001141 }
1142 return skipCall;
1143}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001144
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001145// update DS mappings based on write and copy update arrays
Chia-I Wu483e7702015-10-26 17:20:32 +08001146static VkBool32 dsUpdate(layer_data* my_data, VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet* pWDS, uint32_t descriptorCopyCount, const VkCopyDescriptorSet* pCDS)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001147{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001148 VkBool32 skipCall = VK_FALSE;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001149
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001150 loader_platform_thread_lock_mutex(&globalLock);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001151 LAYOUT_NODE* pLayout = NULL;
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06001152 VkDescriptorSetLayoutCreateInfo* pLayoutCI = NULL;
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001153 // Validate Write updates
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001154 uint32_t i = 0;
Chia-I Wu483e7702015-10-26 17:20:32 +08001155 for (i=0; i < descriptorWriteCount; i++) {
Chia-I Wu1f851912015-10-27 18:04:07 +08001156 VkDescriptorSet ds = pWDS[i].dstSet;
Chia-I Wue420a332015-10-26 20:04:44 +08001157 SET_NODE* pSet = my_data->setMap[ds];
Tobin Ehlisb46be812015-10-23 16:00:08 -06001158 GENERIC_HEADER* pUpdate = (GENERIC_HEADER*) &pWDS[i];
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001159 pLayout = pSet->pLayout;
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06001160 // First verify valid update struct
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001161 if ((skipCall = validUpdateStruct(my_data, device, pUpdate)) == VK_TRUE) {
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06001162 break;
1163 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001164 uint32_t binding = 0, endIndex = 0;
Chia-I Wu1f851912015-10-27 18:04:07 +08001165 binding = pWDS[i].dstBinding;
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001166 // Make sure that layout being updated has the binding being updated
Chia-I Wub5689ee2015-10-31 00:31:16 +08001167 if (pLayout->bindings.find(binding) == pLayout->bindings.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +08001168 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) ds, 0, DRAWSTATE_INVALID_UPDATE_INDEX, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001169 "Descriptor Set %" PRIu64 " does not have binding to match update binding %u for update type %s!", reinterpret_cast<uint64_t>(ds), binding, string_VkStructureType(pUpdate->sType));
Tobin Ehlise42007c2015-06-19 13:00:59 -06001170 } else {
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001171 // Next verify that update falls within size of given binding
Chia-I Wu1f851912015-10-27 18:04:07 +08001172 endIndex = getUpdateEndIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001173 if (getBindingEndIndex(pLayout, binding) < endIndex) {
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001174 pLayoutCI = &pLayout->createInfo;
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06001175 string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} ");
Chia-I Wue420a332015-10-26 20:04:44 +08001176 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) ds, 0, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS",
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001177 "Descriptor update type of %s is out of bounds for matching binding %u in Layout w/ CI:\n%s!", string_VkStructureType(pUpdate->sType), binding, DSstr.c_str());
Tobin Ehlise42007c2015-06-19 13:00:59 -06001178 } else { // TODO : should we skip update on a type mismatch or force it?
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001179 uint32_t startIndex;
Chia-I Wu1f851912015-10-27 18:04:07 +08001180 startIndex = getUpdateStartIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001181 // Layout bindings match w/ update, now verify that update type & stageFlags are the same for entire update
1182 if ((skipCall = validateUpdateConsistency(my_data, device, pLayout, pUpdate, startIndex, endIndex)) == VK_FALSE) {
1183 // The update is within bounds and consistent, but need to make sure contents make sense as well
Chia-I Wuf03cbf72015-10-31 00:31:16 +08001184 if ((skipCall = validateUpdateContents(my_data, &pWDS[i], &pLayout->createInfo.pBinding[binding])) == VK_FALSE) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001185 // Update is good. Save the update info
1186 // Create new update struct for this set's shadow copy
1187 GENERIC_HEADER* pNewNode = NULL;
1188 skipCall |= shadowUpdateNode(my_data, device, pUpdate, &pNewNode);
1189 if (NULL == pNewNode) {
Chia-I Wue420a332015-10-26 20:04:44 +08001190 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) ds, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Tobin Ehlisb46be812015-10-23 16:00:08 -06001191 "Out of memory while attempting to allocate UPDATE struct in vkUpdateDescriptors()");
1192 } else {
1193 // Insert shadow node into LL of updates for this set
1194 pNewNode->pNext = pSet->pUpdateStructs;
1195 pSet->pUpdateStructs = pNewNode;
1196 // Now update appropriate descriptor(s) to point to new Update node
Tobin Ehlisb46be812015-10-23 16:00:08 -06001197 for (uint32_t j = startIndex; j <= endIndex; j++) {
1198 assert(j<pSet->descriptorCount);
1199 pSet->ppDescriptors[j] = pNewNode;
1200 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001201 }
1202 }
1203 }
1204 }
1205 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001206 }
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001207 // Now validate copy updates
Chia-I Wu483e7702015-10-26 17:20:32 +08001208 for (i=0; i < descriptorCopyCount; ++i) {
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001209 SET_NODE *pSrcSet = NULL, *pDstSet = NULL;
1210 LAYOUT_NODE *pSrcLayout = NULL, *pDstLayout = NULL;
1211 uint32_t srcStartIndex = 0, srcEndIndex = 0, dstStartIndex = 0, dstEndIndex = 0;
1212 // For each copy make sure that update falls within given layout and that types match
Chia-I Wue420a332015-10-26 20:04:44 +08001213 pSrcSet = my_data->setMap[pCDS[i].srcSet];
Chia-I Wu1f851912015-10-27 18:04:07 +08001214 pDstSet = my_data->setMap[pCDS[i].dstSet];
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001215 pSrcLayout = pSrcSet->pLayout;
1216 pDstLayout = pDstSet->pLayout;
1217 // Validate that src binding is valid for src set layout
Chia-I Wub5689ee2015-10-31 00:31:16 +08001218 if (pSrcLayout->bindings.find(pCDS[i].srcBinding) == pSrcLayout->bindings.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +08001219 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pSrcSet->set, 0, DRAWSTATE_INVALID_UPDATE_INDEX, "DS",
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001220 "Copy descriptor update %u has srcBinding %u which is out of bounds for underlying SetLayout %#" PRIxLEAST64 " which only has bindings 0-%u.",
Chia-I Wu763a7492015-10-26 20:48:51 +08001221 i, pCDS[i].srcBinding, (uint64_t) pSrcLayout->layout, pSrcLayout->createInfo.bindingCount-1);
Chia-I Wub5689ee2015-10-31 00:31:16 +08001222 } else if (pDstLayout->bindings.find(pCDS[i].dstBinding) == pDstLayout->bindings.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +08001223 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDstSet->set, 0, DRAWSTATE_INVALID_UPDATE_INDEX, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08001224 "Copy descriptor update %u has dstBinding %u which is out of bounds for underlying SetLayout %#" PRIxLEAST64 " which only has bindings 0-%u.",
1225 i, pCDS[i].dstBinding, (uint64_t) pDstLayout->layout, pDstLayout->createInfo.bindingCount-1);
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001226 } else {
1227 // Proceed with validation. Bindings are ok, but make sure update is within bounds of given layout
1228 srcEndIndex = getUpdateEndIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, (const GENERIC_HEADER*)&(pCDS[i]));
Chia-I Wu1f851912015-10-27 18:04:07 +08001229 dstEndIndex = getUpdateEndIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, (const GENERIC_HEADER*)&(pCDS[i]));
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001230 if (getBindingEndIndex(pSrcLayout, pCDS[i].srcBinding) < srcEndIndex) {
1231 pLayoutCI = &pSrcLayout->createInfo;
1232 string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} ");
Chia-I Wue420a332015-10-26 20:04:44 +08001233 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pSrcSet->set, 0, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS",
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001234 "Copy descriptor src update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", pCDS[i].srcBinding, DSstr.c_str());
Chia-I Wu1f851912015-10-27 18:04:07 +08001235 } else if (getBindingEndIndex(pDstLayout, pCDS[i].dstBinding) < dstEndIndex) {
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001236 pLayoutCI = &pDstLayout->createInfo;
1237 string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} ");
Chia-I Wue420a332015-10-26 20:04:44 +08001238 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDstSet->set, 0, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08001239 "Copy descriptor dest update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", pCDS[i].dstBinding, DSstr.c_str());
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001240 } else {
1241 srcStartIndex = getUpdateStartIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, (const GENERIC_HEADER*)&(pCDS[i]));
Chia-I Wu1f851912015-10-27 18:04:07 +08001242 dstStartIndex = getUpdateStartIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, (const GENERIC_HEADER*)&(pCDS[i]));
Chia-I Wu763a7492015-10-26 20:48:51 +08001243 for (uint32_t j=0; j<pCDS[i].descriptorCount; ++j) {
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001244 // For copy just make sure that the types match and then perform the update
1245 if (pSrcLayout->descriptorTypes[srcStartIndex+j] != pDstLayout->descriptorTypes[dstStartIndex+j]) {
1246 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS",
1247 "Copy descriptor update index %u, update count #%u, has src update descriptor type %s that does not match overlapping dest descriptor type of %s!",
1248 i, j+1, string_VkDescriptorType(pSrcLayout->descriptorTypes[srcStartIndex+j]), string_VkDescriptorType(pDstLayout->descriptorTypes[dstStartIndex+j]));
1249 } else {
1250 // point dst descriptor at corresponding src descriptor
1251 pDstSet->ppDescriptors[j+dstStartIndex] = pSrcSet->ppDescriptors[j+srcStartIndex];
1252 }
1253 }
1254 }
1255 }
1256 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001257 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001258 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001259}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001260
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001261// Verify that given pool has descriptors that are being requested for allocation
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001262static VkBool32 validate_descriptor_availability_in_pool(layer_data* dev_data, DESCRIPTOR_POOL_NODE* pPoolNode, uint32_t count, const VkDescriptorSetLayout* pSetLayouts)
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001263{
1264 VkBool32 skipCall = VK_FALSE;
1265 uint32_t i = 0, j = 0;
1266 for (i=0; i<count; ++i) {
1267 LAYOUT_NODE* pLayout = getLayoutNode(dev_data, pSetLayouts[i]);
1268 if (NULL == pLayout) {
Chia-I Wue420a332015-10-26 20:04:44 +08001269 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT, (uint64_t) pSetLayouts[i], 0, DRAWSTATE_INVALID_LAYOUT, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08001270 "Unable to find set layout node for layout %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", (uint64_t) pSetLayouts[i]);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001271 } else {
Chia-I Wuc51b1212015-10-27 19:25:11 +08001272 uint32_t typeIndex = 0, poolSizeCount = 0;
Chia-I Wu763a7492015-10-26 20:48:51 +08001273 for (j=0; j<pLayout->createInfo.bindingCount; ++j) {
Chia-I Wuf03cbf72015-10-31 00:31:16 +08001274 typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBinding[j].descriptorType);
Chia-I Wu045654f2015-11-06 06:42:02 +08001275 poolSizeCount = pLayout->createInfo.pBinding[j].descriptorCount;
Chia-I Wuc51b1212015-10-27 19:25:11 +08001276 if (poolSizeCount > pPoolNode->availableDescriptorTypeCount[typeIndex]) {
Chia-I Wue420a332015-10-26 20:04:44 +08001277 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT, (uint64_t) pLayout->layout, 0, DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS",
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001278 "Unable to allocate %u descriptors of type %s from pool %#" PRIxLEAST64 ". This pool only has %u descriptors of this type remaining.",
Chia-I Wuf03cbf72015-10-31 00:31:16 +08001279 poolSizeCount, string_VkDescriptorType(pLayout->createInfo.pBinding[j].descriptorType), (uint64_t) pPoolNode->pool, pPoolNode->availableDescriptorTypeCount[typeIndex]);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001280 } else { // Decrement available descriptors of this type
Chia-I Wuc51b1212015-10-27 19:25:11 +08001281 pPoolNode->availableDescriptorTypeCount[typeIndex] -= poolSizeCount;
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001282 }
1283 }
1284 }
1285 }
1286 return skipCall;
1287}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001288
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001289// Free the shadowed update node for this Set
1290// NOTE : Calls to this function should be wrapped in mutex
1291static void freeShadowUpdateTree(SET_NODE* pSet)
1292{
1293 GENERIC_HEADER* pShadowUpdate = pSet->pUpdateStructs;
1294 pSet->pUpdateStructs = NULL;
1295 GENERIC_HEADER* pFreeUpdate = pShadowUpdate;
1296 // Clear the descriptor mappings as they will now be invalid
1297 memset(pSet->ppDescriptors, 0, pSet->descriptorCount*sizeof(GENERIC_HEADER*));
1298 while(pShadowUpdate) {
1299 pFreeUpdate = pShadowUpdate;
1300 pShadowUpdate = (GENERIC_HEADER*)pShadowUpdate->pNext;
1301 uint32_t index = 0;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001302 VkWriteDescriptorSet * pWDS = NULL;
1303 VkCopyDescriptorSet * pCDS = NULL;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001304 void** ppToFree = NULL;
1305 switch (pFreeUpdate->sType)
1306 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001307 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
1308 pWDS = (VkWriteDescriptorSet*)pFreeUpdate;
Tony Barbourf740f902015-11-02 11:46:29 -07001309 switch (pWDS->descriptorType) {
1310 case VK_DESCRIPTOR_TYPE_SAMPLER:
1311 case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
1312 case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
1313 case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
1314 {
1315 delete[] pWDS->pImageInfo;
1316 }
1317 break;
1318 case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
1319 case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
1320 {
1321 delete[] pWDS->pTexelBufferView;
1322 }
1323 break;
1324 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER:
1325 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER:
1326 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
1327 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
1328 {
1329 delete[] pWDS->pBufferInfo;
1330 }
1331 break;
1332 default:
1333 break;
Courtney Goeltzenleuchtere4099742015-10-22 15:31:56 -06001334 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001335 break;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001336 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001337 break;
1338 default:
1339 assert(0);
1340 break;
1341 }
Tobin Ehliseaf28662015-04-08 10:58:37 -06001342 delete pFreeUpdate;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001343 }
1344}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001345
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001346// Free all DS Pools including their Sets & related sub-structs
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001347// NOTE : Calls to this function should be wrapped in mutex
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001348static void deletePools(layer_data* my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001349{
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001350 if (my_data->descriptorPoolMap.size() <= 0)
David Pinedof5997ab2015-04-27 16:36:17 -06001351 return;
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001352 for (auto ii=my_data->descriptorPoolMap.begin(); ii!=my_data->descriptorPoolMap.end(); ++ii) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001353 SET_NODE* pSet = (*ii).second->pSets;
1354 SET_NODE* pFreeSet = pSet;
1355 while (pSet) {
1356 pFreeSet = pSet;
1357 pSet = pSet->pNext;
Tobin Ehliseaf28662015-04-08 10:58:37 -06001358 // Freeing layouts handled in deleteLayouts() function
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001359 // Free Update shadow struct tree
1360 freeShadowUpdateTree(pFreeSet);
1361 if (pFreeSet->ppDescriptors) {
Chris Forbes4506d3f2015-06-04 10:49:27 +12001362 delete[] pFreeSet->ppDescriptors;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001363 }
1364 delete pFreeSet;
1365 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001366 delete (*ii).second;
1367 }
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001368 my_data->descriptorPoolMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001369}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001370
Tobin Ehliseaf28662015-04-08 10:58:37 -06001371// WARN : Once deleteLayouts() called, any layout ptrs in Pool/Set data structure will be invalid
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001372// NOTE : Calls to this function should be wrapped in mutex
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001373static void deleteLayouts(layer_data* my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001374{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001375 if (my_data->layoutMap.size() <= 0)
David Pinedof5997ab2015-04-27 16:36:17 -06001376 return;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001377 for (auto ii=my_data->layoutMap.begin(); ii!=my_data->layoutMap.end(); ++ii) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001378 LAYOUT_NODE* pLayout = (*ii).second;
Chia-I Wuf03cbf72015-10-31 00:31:16 +08001379 if (pLayout->createInfo.pBinding) {
Chia-I Wu763a7492015-10-26 20:48:51 +08001380 for (uint32_t i=0; i<pLayout->createInfo.bindingCount; i++) {
Chia-I Wuf03cbf72015-10-31 00:31:16 +08001381 if (pLayout->createInfo.pBinding[i].pImmutableSamplers)
1382 delete[] pLayout->createInfo.pBinding[i].pImmutableSamplers;
Tobin Ehliseaf28662015-04-08 10:58:37 -06001383 }
Chia-I Wuf03cbf72015-10-31 00:31:16 +08001384 delete[] pLayout->createInfo.pBinding;
Tobin Ehliseaf28662015-04-08 10:58:37 -06001385 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001386 delete pLayout;
1387 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001388 my_data->layoutMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001389}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001390
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001391// Currently clearing a set is removing all previous updates to that set
1392// TODO : Validate if this is correct clearing behavior
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001393static void clearDescriptorSet(layer_data* my_data, VkDescriptorSet set)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001394{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001395 SET_NODE* pSet = getSetNode(my_data, set);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001396 if (!pSet) {
1397 // TODO : Return error
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001398 } else {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001399 loader_platform_thread_lock_mutex(&globalLock);
1400 freeShadowUpdateTree(pSet);
1401 loader_platform_thread_unlock_mutex(&globalLock);
1402 }
1403}
1404
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06001405static void clearDescriptorPool(layer_data* my_data, const VkDevice device, const VkDescriptorPool pool, VkDescriptorPoolResetFlags flags)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001406{
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001407 DESCRIPTOR_POOL_NODE* pPool = getPoolNode(my_data, pool);
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001408 if (!pPool) {
Chia-I Wue420a332015-10-26 20:04:44 +08001409 log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_POOL, (uint64_t) pool, 0, DRAWSTATE_INVALID_POOL, "DS",
1410 "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkResetDescriptorPool() call", (uint64_t) pool);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001411 } else {
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06001412 // TODO: validate flags
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001413 // For every set off of this pool, clear it
1414 SET_NODE* pSet = pPool->pSets;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001415 while (pSet) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001416 clearDescriptorSet(my_data, pSet->set);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001417 }
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001418 // Reset available count to max count for this pool
1419 for (uint32_t i=0; i<pPool->availableDescriptorTypeCount.size(); ++i) {
1420 pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i];
1421 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001422 }
1423}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001424
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001425// For given CB object, fetch associated CB Node from map
Chia-I Wu1f851912015-10-27 18:04:07 +08001426static GLOBAL_CB_NODE* getCBNode(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001427{
1428 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wu1f851912015-10-27 18:04:07 +08001429 if (my_data->commandBufferMap.find(cb) == my_data->commandBufferMap.end()) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001430 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06001431 // TODO : How to pass cb as srcObj here?
Chia-I Wu1f851912015-10-27 18:04:07 +08001432 log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
1433 "Attempt to use CommandBuffer %#" PRIxLEAST64 " that doesn't exist!", reinterpret_cast<uint64_t>(cb));
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001434 return NULL;
1435 }
1436 loader_platform_thread_unlock_mutex(&globalLock);
Chia-I Wu1f851912015-10-27 18:04:07 +08001437 return my_data->commandBufferMap[cb];
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001438}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001439
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001440// Free all CB Nodes
1441// NOTE : Calls to this function should be wrapped in mutex
Chia-I Wu1f851912015-10-27 18:04:07 +08001442static void deleteCommandBuffers(layer_data* my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001443{
Chia-I Wu1f851912015-10-27 18:04:07 +08001444 if (my_data->commandBufferMap.size() <= 0)
David Pinedof5997ab2015-04-27 16:36:17 -06001445 return;
Chia-I Wu1f851912015-10-27 18:04:07 +08001446 for (auto ii=my_data->commandBufferMap.begin(); ii!=my_data->commandBufferMap.end(); ++ii) {
Courtney Goeltzenleuchter09098a72015-04-27 15:04:43 -06001447 vector<CMD_NODE*> cmd_node_list = (*ii).second->pCmds;
1448 while (!cmd_node_list.empty()) {
1449 CMD_NODE* cmd_node = cmd_node_list.back();
1450 delete cmd_node;
1451 cmd_node_list.pop_back();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001452 }
1453 delete (*ii).second;
1454 }
Chia-I Wu1f851912015-10-27 18:04:07 +08001455 my_data->commandBufferMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001456}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001457
Chia-I Wu1f851912015-10-27 18:04:07 +08001458static VkBool32 report_error_no_cb_begin(const layer_data* dev_data, const VkCommandBuffer cb, const char* caller_name)
Tobin Ehlise42007c2015-06-19 13:00:59 -06001459{
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06001460 // TODO : How to pass cb as srcObj here?
Chia-I Wu1f851912015-10-27 18:04:07 +08001461 return log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001462 "You must call vkBeginCommandBuffer() before this call to %s", caller_name);
Tobin Ehlise42007c2015-06-19 13:00:59 -06001463}
Michael Lentine2b9eda42015-10-28 15:55:18 -07001464
1465bool validateCmdsInCmdBuffer(const layer_data* dev_data, const GLOBAL_CB_NODE* pCB, const CMD_TYPE cmd_type) {
1466 bool skip_call = false;
1467 for (auto cmd : pCB->pCmds) {
1468 if (cmd_type == CMD_EXECUTECOMMANDS && cmd->type != CMD_EXECUTECOMMANDS) {
1469 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
1470 "vkCmdExecuteCommands() cannot be called on a cmd buffer with exsiting commands.");
1471 }
1472 if (cmd_type != CMD_EXECUTECOMMANDS && cmd->type == CMD_EXECUTECOMMANDS) {
1473 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
1474 "Commands cannot be added to a cmd buffer with exsiting secondary commands.");
1475 }
1476 }
1477 return skip_call;
1478}
1479
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001480static VkBool32 addCmd(const layer_data* my_data, GLOBAL_CB_NODE* pCB, const CMD_TYPE cmd)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001481{
Michael Lentine2b9eda42015-10-28 15:55:18 -07001482 VkBool32 skipCall = validateCmdsInCmdBuffer(my_data, pCB, cmd);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001483 CMD_NODE* pCmd = new CMD_NODE;
1484 if (pCmd) {
1485 // init cmd node and append to end of cmd LL
1486 memset(pCmd, 0, sizeof(CMD_NODE));
1487 pCmd->cmdNumber = ++pCB->numCmds;
1488 pCmd->type = cmd;
1489 pCB->pCmds.push_back(pCmd);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001490 } else {
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06001491 // TODO : How to pass cb as srcObj here?
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001492 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08001493 "Out of memory while attempting to allocate new CMD_NODE for commandBuffer %#" PRIxLEAST64, reinterpret_cast<uint64_t>(pCB->commandBuffer));
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001494 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001495 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001496}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001497
Chia-I Wu1f851912015-10-27 18:04:07 +08001498static void resetCB(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001499{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001500 GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001501 if (pCB) {
Courtney Goeltzenleuchterf03711e2015-04-27 17:16:56 -06001502 vector<CMD_NODE*> cmd_list = pCB->pCmds;
1503 while (!cmd_list.empty()) {
1504 delete cmd_list.back();
1505 cmd_list.pop_back();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001506 }
Courtney Goeltzenleuchterf03711e2015-04-27 17:16:56 -06001507 pCB->pCmds.clear();
Tobin Ehlis0cea4082015-08-18 07:10:58 -06001508 // Reset CB state (need to save createInfo)
Chia-I Wu1f851912015-10-27 18:04:07 +08001509 VkCommandBufferAllocateInfo saveCBCI = pCB->createInfo;
Chia-I Wu1f851912015-10-27 18:04:07 +08001510 pCB->commandBuffer = cb;
Tobin Ehlis0cea4082015-08-18 07:10:58 -06001511 pCB->createInfo = saveCBCI;
Michael Lentine27b0f902015-10-12 11:30:14 -05001512 memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo));
1513 pCB->fence = 0;
1514 pCB->numCmds = 0;
1515 memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t));
1516 pCB->state = CB_NEW;
1517 pCB->submitCount = 0;
1518 pCB->status = 0;
1519 pCB->pCmds.clear();
1520 pCB->lastBoundPipeline = 0;
1521 pCB->viewports.clear();
1522 pCB->scissors.clear();
1523 pCB->lineWidth = 0;
1524 pCB->depthBiasConstantFactor = 0;
1525 pCB->depthBiasClamp = 0;
1526 pCB->depthBiasSlopeFactor = 0;
1527 memset(pCB->blendConstants, 0, 4 * sizeof(float));
1528 pCB->minDepthBounds = 0;
1529 pCB->maxDepthBounds = 0;
1530 memset(&pCB->front, 0, sizeof(stencil_data));
1531 memset(&pCB->back, 0, sizeof(stencil_data));
1532 pCB->lastBoundDescriptorSet = 0;
1533 pCB->lastBoundPipelineLayout = 0;
1534 pCB->activeRenderPass = 0;
1535 pCB->activeSubpass = 0;
1536 pCB->framebuffer = 0;
Michael Lentine27b0f902015-10-12 11:30:14 -05001537 pCB->boundDescriptorSets.clear();
1538 pCB->imageLayoutMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001539 pCB->lastVtxBinding = MAX_BINDING;
1540 }
1541}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001542
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001543// Set PSO-related status bits for CB, including dynamic state set via PSO
Tobin Ehlis97866202015-06-10 12:57:07 -06001544static void set_cb_pso_status(GLOBAL_CB_NODE* pCB, const PIPELINE_NODE* pPipe)
1545{
1546 for (uint32_t i = 0; i < pPipe->cbStateCI.attachmentCount; i++) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08001547 if (0 != pPipe->pAttachments[i].colorWriteMask) {
Tobin Ehlis97866202015-06-10 12:57:07 -06001548 pCB->status |= CBSTATUS_COLOR_BLEND_WRITE_ENABLE;
1549 }
1550 }
1551 if (pPipe->dsStateCI.depthWriteEnable) {
Cody Northrop2605cb02015-08-18 15:21:16 -06001552 pCB->status |= CBSTATUS_DEPTH_WRITE_ENABLE;
1553 }
Cody Northrop2605cb02015-08-18 15:21:16 -06001554 if (pPipe->dsStateCI.stencilTestEnable) {
1555 pCB->status |= CBSTATUS_STENCIL_TEST_ENABLE;
Tobin Ehlis97866202015-06-10 12:57:07 -06001556 }
Tobin Ehlisa88e2f52015-10-02 11:00:56 -06001557 // Account for any dynamic state not set via this PSO
1558 if (!pPipe->dynStateCI.dynamicStateCount) { // All state is static
1559 pCB->status = CBSTATUS_ALL;
1560 } else {
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001561 // First consider all state on
1562 // Then unset any state that's noted as dynamic in PSO
1563 // Finally OR that into CB statemask
1564 CBStatusFlags psoDynStateMask = CBSTATUS_ALL;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001565 for (uint32_t i=0; i < pPipe->dynStateCI.dynamicStateCount; i++) {
1566 switch (pPipe->dynStateCI.pDynamicStates[i]) {
1567 case VK_DYNAMIC_STATE_VIEWPORT:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001568 psoDynStateMask &= ~CBSTATUS_VIEWPORT_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001569 break;
1570 case VK_DYNAMIC_STATE_SCISSOR:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001571 psoDynStateMask &= ~CBSTATUS_SCISSOR_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001572 break;
1573 case VK_DYNAMIC_STATE_LINE_WIDTH:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001574 psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001575 break;
1576 case VK_DYNAMIC_STATE_DEPTH_BIAS:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001577 psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001578 break;
1579 case VK_DYNAMIC_STATE_BLEND_CONSTANTS:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001580 psoDynStateMask &= ~CBSTATUS_BLEND_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001581 break;
1582 case VK_DYNAMIC_STATE_DEPTH_BOUNDS:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001583 psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001584 break;
1585 case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001586 psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001587 break;
1588 case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001589 psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001590 break;
1591 case VK_DYNAMIC_STATE_STENCIL_REFERENCE:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001592 psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001593 break;
1594 default:
1595 // TODO : Flag error here
1596 break;
1597 }
1598 }
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001599 pCB->status |= psoDynStateMask;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001600 }
Tobin Ehlis97866202015-06-10 12:57:07 -06001601}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001602
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001603// Print the last bound Gfx Pipeline
Chia-I Wu1f851912015-10-27 18:04:07 +08001604static VkBool32 printPipeline(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001605{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001606 VkBool32 skipCall = VK_FALSE;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001607 GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001608 if (pCB) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001609 PIPELINE_NODE *pPipeTrav = getPipeline(my_data, pCB->lastBoundPipeline);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001610 if (!pPipeTrav) {
1611 // nothing to print
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001612 } else {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001613 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001614 "%s", vk_print_vkgraphicspipelinecreateinfo(&pPipeTrav->graphicsPipelineCI, "{DS}").c_str());
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001615 }
1616 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001617 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001618}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001619
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001620// Print details of DS config to stdout
Chia-I Wu1f851912015-10-27 18:04:07 +08001621static VkBool32 printDSConfig(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001622{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001623 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001624 char ds_config_str[1024*256] = {0}; // TODO : Currently making this buffer HUGE w/o overrun protection. Need to be smarter, start smaller, and grow as needed.
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001625 GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb);
Tobin Ehlis7297f192015-06-09 08:39:32 -06001626 if (pCB && pCB->lastBoundDescriptorSet) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001627 SET_NODE* pSet = getSetNode(my_data, pCB->lastBoundDescriptorSet);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001628 DESCRIPTOR_POOL_NODE* pPool = getPoolNode(my_data, pSet->pool);
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001629 // Print out pool details
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001630 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001631 "Details for pool %#" PRIxLEAST64 ".", (uint64_t) pPool->pool);
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06001632 string poolStr = vk_print_vkdescriptorpoolcreateinfo(&pPool->createInfo, " ");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001633 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001634 "%s", poolStr.c_str());
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001635 // Print out set details
1636 char prefix[10];
1637 uint32_t index = 0;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001638 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001639 "Details for descriptor set %#" PRIxLEAST64 ".", (uint64_t) pSet->set);
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001640 LAYOUT_NODE* pLayout = pSet->pLayout;
1641 // Print layout details
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001642 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001643 "Layout #%u, (object %#" PRIxLEAST64 ") for DS %#" PRIxLEAST64 ".", index+1, reinterpret_cast<uint64_t>(pLayout->layout), reinterpret_cast<uint64_t>(pSet->set));
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001644 sprintf(prefix, " [L%u] ", index);
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06001645 string DSLstr = vk_print_vkdescriptorsetlayoutcreateinfo(&pLayout->createInfo, prefix).c_str();
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001646 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001647 "%s", DSLstr.c_str());
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001648 index++;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001649 GENERIC_HEADER* pUpdate = pSet->pUpdateStructs;
1650 if (pUpdate) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001651 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001652 "Update Chain [UC] for descriptor set %#" PRIxLEAST64 ":", (uint64_t) pSet->set);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001653 sprintf(prefix, " [UC] ");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001654 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001655 "%s", dynamic_display(pUpdate, prefix).c_str());
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001656 // TODO : If there is a "view" associated with this update, print CI for that view
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001657 } else {
Tobin Ehlis2bca8b02015-06-15 08:41:17 -06001658 if (0 != pSet->descriptorCount) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001659 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001660 "No Update Chain for descriptor set %#" PRIxLEAST64 " which has %u descriptors (vkUpdateDescriptors has not been called)", (uint64_t) pSet->set, pSet->descriptorCount);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001661 } else {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001662 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001663 "FYI: No descriptors in descriptor set %#" PRIxLEAST64 ".", (uint64_t) pSet->set);
Tobin Ehlis2bca8b02015-06-15 08:41:17 -06001664 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001665 }
1666 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001667 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001668}
1669
Chia-I Wu1f851912015-10-27 18:04:07 +08001670static void printCB(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001671{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001672 GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb);
David Pinedof5997ab2015-04-27 16:36:17 -06001673 if (pCB && pCB->pCmds.size() > 0) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001674 log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001675 "Cmds in CB %p", (void*)cb);
Courtney Goeltzenleuchtercf2a5362015-04-27 11:16:35 -06001676 vector<CMD_NODE*> pCmds = pCB->pCmds;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06001677 for (auto ii=pCmds.begin(); ii!=pCmds.end(); ++ii) {
1678 // TODO : Need to pass cb as srcObj here
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001679 log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001680 " CMD#%" PRIu64 ": %s", (*ii)->cmdNumber, cmdTypeToString((*ii)->type).c_str());
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001681 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001682 } else {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001683 // Nothing to print
1684 }
1685}
1686
Chia-I Wu1f851912015-10-27 18:04:07 +08001687static VkBool32 synchAndPrintDSConfig(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001688{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001689 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001690 if (!(my_data->report_data->active_flags & VK_DBG_REPORT_INFO_BIT)) {
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001691 return skipCall;
Mike Stroyanfa2f2222015-08-12 17:11:28 -06001692 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001693 skipCall |= printDSConfig(my_data, cb);
1694 skipCall |= printPipeline(my_data, cb);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001695 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001696}
1697
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001698// Flags validation error if the associated call is made inside a render pass. The apiName
1699// routine should ONLY be called outside a render pass.
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001700static VkBool32 insideRenderPass(const layer_data* my_data, GLOBAL_CB_NODE *pCB, const char *apiName)
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001701{
1702 VkBool32 inside = VK_FALSE;
1703 if (pCB->activeRenderPass) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001704 inside = log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER,
Chia-I Wu1f851912015-10-27 18:04:07 +08001705 (uint64_t)pCB->commandBuffer, 0, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS",
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001706 "%s: It is invalid to issue this call inside an active render pass (%#" PRIxLEAST64 ")",
Chia-I Wue420a332015-10-26 20:04:44 +08001707 apiName, (uint64_t) pCB->activeRenderPass);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001708 }
1709 return inside;
1710}
1711
1712// Flags validation error if the associated call is made outside a render pass. The apiName
1713// routine should ONLY be called inside a render pass.
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001714static VkBool32 outsideRenderPass(const layer_data* my_data, GLOBAL_CB_NODE *pCB, const char *apiName)
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001715{
1716 VkBool32 outside = VK_FALSE;
1717 if (!pCB->activeRenderPass) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001718 outside = log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER,
Chia-I Wu1f851912015-10-27 18:04:07 +08001719 (uint64_t)pCB->commandBuffer, 0, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS",
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001720 "%s: This call must be issued inside an active render pass.", apiName);
1721 }
1722 return outside;
1723}
1724
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001725static void init_draw_state(layer_data *my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001726{
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001727 uint32_t report_flags = 0;
1728 uint32_t debug_action = 0;
1729 FILE *log_output = NULL;
1730 const char *option_str;
Courtney Goeltzenleuchter1781b1c2015-10-05 15:58:38 -06001731 VkDbgMsgCallback callback;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001732 // initialize DrawState options
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001733 report_flags = getLayerOptionFlags("DrawStateReportFlags", 0);
1734 getLayerOptionEnum("DrawStateDebugAction", (uint32_t *) &debug_action);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001735
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001736 if (debug_action & VK_DBG_LAYER_ACTION_LOG_MSG)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001737 {
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001738 option_str = getLayerOption("DrawStateLogFilename");
Tobin Ehlisb4b6e7c2015-09-15 09:55:54 -06001739 log_output = getLayerLogOutput(option_str, "DrawState");
Courtney Goeltzenleuchter1781b1c2015-10-05 15:58:38 -06001740 layer_create_msg_callback(my_data->report_data, report_flags, log_callback, (void *) log_output, &callback);
1741 my_data->logging_callback.push_back(callback);
1742 }
1743
1744 if (debug_action & VK_DBG_LAYER_ACTION_DEBUG_OUTPUT) {
1745 layer_create_msg_callback(my_data->report_data, report_flags, win32_debug_output_msg, NULL, &callback);
1746 my_data->logging_callback.push_back(callback);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001747 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001748
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001749 if (!globalLockInitialized)
1750 {
Mike Stroyand9dd0072015-08-18 15:56:18 -06001751 // This mutex may be deleted by vkDestroyInstance of last instance.
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001752 loader_platform_thread_create_mutex(&globalLock);
1753 globalLockInitialized = 1;
1754 }
1755}
1756
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001757VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(const VkInstanceCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkInstance* pInstance)
Courtney Goeltzenleuchter3c9f6ec2015-06-01 14:29:58 -06001758{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001759 layer_data *my_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map);
1760 VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table;
Chia-I Wu69f40122015-10-26 21:10:41 +08001761 VkResult result = pTable->CreateInstance(pCreateInfo, pAllocator, pInstance);
Courtney Goeltzenleuchter3c9f6ec2015-06-01 14:29:58 -06001762
1763 if (result == VK_SUCCESS) {
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001764 layer_data *my_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map);
1765 my_data->report_data = debug_report_create_instance(
1766 pTable,
1767 *pInstance,
Chia-I Wu763a7492015-10-26 20:48:51 +08001768 pCreateInfo->enabledExtensionNameCount,
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001769 pCreateInfo->ppEnabledExtensionNames);
Courtney Goeltzenleuchterf4a2eba2015-06-08 14:58:39 -06001770
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001771 init_draw_state(my_data);
Courtney Goeltzenleuchter3c9f6ec2015-06-01 14:29:58 -06001772 }
1773 return result;
1774}
1775
Jon Ashburne0fa2282015-05-20 09:00:28 -06001776/* hook DestroyInstance to remove tableInstanceMap entry */
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001777VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks* pAllocator)
Jon Ashburne0fa2282015-05-20 09:00:28 -06001778{
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001779 dispatch_key key = get_dispatch_key(instance);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001780 layer_data *my_data = get_my_data_ptr(key, layer_data_map);
1781 VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table;
Chia-I Wu69f40122015-10-26 21:10:41 +08001782 pTable->DestroyInstance(instance, pAllocator);
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001783
1784 // Clean up logging callback, if any
Courtney Goeltzenleuchter1781b1c2015-10-05 15:58:38 -06001785 while (my_data->logging_callback.size() > 0) {
1786 VkDbgMsgCallback callback = my_data->logging_callback.back();
1787 layer_destroy_msg_callback(my_data->report_data, callback);
1788 my_data->logging_callback.pop_back();
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001789 }
1790
Courtney Goeltzenleuchter2d034fd2015-06-28 13:01:17 -06001791 layer_debug_report_destroy_instance(my_data->report_data);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001792 delete my_data->instance_dispatch_table;
1793 layer_data_map.erase(key);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001794 // TODO : Potential race here with separate threads creating/destroying instance
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001795 if (layer_data_map.empty()) {
Mike Stroyand9dd0072015-08-18 15:56:18 -06001796 // Release mutex when destroying last instance.
1797 loader_platform_thread_delete_mutex(&globalLock);
1798 globalLockInitialized = 0;
1799 }
Jon Ashburne0fa2282015-05-20 09:00:28 -06001800}
1801
Jon Ashburnf0615e22015-05-25 14:11:37 -06001802static void createDeviceRegisterExtensions(const VkDeviceCreateInfo* pCreateInfo, VkDevice device)
1803{
Tony Barbour29b12062015-07-13 13:37:24 -06001804 uint32_t i;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001805 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
1806 dev_data->device_extensions.debug_marker_enabled = false;
Michael Lentine27b0f902015-10-12 11:30:14 -05001807 dev_data->device_extensions.wsi_enabled = false;
1808
1809
1810 VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table;
1811 PFN_vkGetDeviceProcAddr gpa = pDisp->GetDeviceProcAddr;
1812
1813 pDisp->GetSurfacePropertiesKHR = (PFN_vkGetSurfacePropertiesKHR) gpa(device, "vkGetSurfacePropertiesKHR");
1814 pDisp->GetSurfaceFormatsKHR = (PFN_vkGetSurfaceFormatsKHR) gpa(device, "vkGetSurfaceFormatsKHR");
1815 pDisp->GetSurfacePresentModesKHR = (PFN_vkGetSurfacePresentModesKHR) gpa(device, "vkGetSurfacePresentModesKHR");
1816 pDisp->CreateSwapchainKHR = (PFN_vkCreateSwapchainKHR) gpa(device, "vkCreateSwapchainKHR");
1817 pDisp->DestroySwapchainKHR = (PFN_vkDestroySwapchainKHR) gpa(device, "vkDestroySwapchainKHR");
1818 pDisp->GetSwapchainImagesKHR = (PFN_vkGetSwapchainImagesKHR) gpa(device, "vkGetSwapchainImagesKHR");
1819 pDisp->AcquireNextImageKHR = (PFN_vkAcquireNextImageKHR) gpa(device, "vkAcquireNextImageKHR");
1820 pDisp->QueuePresentKHR = (PFN_vkQueuePresentKHR) gpa(device, "vkQueuePresentKHR");
Jon Ashburnf0615e22015-05-25 14:11:37 -06001821
Chia-I Wu763a7492015-10-26 20:48:51 +08001822 for (i = 0; i < pCreateInfo->enabledExtensionNameCount; i++) {
Michael Lentine27b0f902015-10-12 11:30:14 -05001823 if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_EXT_KHR_DEVICE_SWAPCHAIN_EXTENSION_NAME) == 0) {
1824 dev_data->device_extensions.wsi_enabled = true;
1825 }
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001826 if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], DEBUG_MARKER_EXTENSION_NAME) == 0) {
Jon Ashburn6f8cd632015-06-01 09:37:38 -06001827 /* Found a matching extension name, mark it enabled and init dispatch table*/
1828 initDebugMarkerTable(device);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001829 dev_data->device_extensions.debug_marker_enabled = true;
Jon Ashburnf0615e22015-05-25 14:11:37 -06001830 }
Jon Ashburnf0615e22015-05-25 14:11:37 -06001831 }
1832}
1833
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001834VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDevice* pDevice)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001835{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001836 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08001837 VkResult result = dev_data->device_dispatch_table->CreateDevice(gpu, pCreateInfo, pAllocator, pDevice);
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001838 if (result == VK_SUCCESS) {
1839 layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), layer_data_map);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001840 dev_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice);
Jon Ashburn7e07faf2015-06-18 15:02:58 -06001841 createDeviceRegisterExtensions(pCreateInfo, *pDevice);
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001842 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001843 return result;
1844}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001845
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001846// prototype
1847static void deleteRenderPasses(layer_data*);
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001848VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001849{
Jeremy Hayesea1fef52015-06-19 11:37:38 -06001850 dispatch_key key = get_dispatch_key(device);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001851 layer_data* dev_data = get_my_data_ptr(key, layer_data_map);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001852 // Free all the memory
1853 loader_platform_thread_lock_mutex(&globalLock);
1854 deletePipelines(dev_data);
1855 deleteRenderPasses(dev_data);
Chia-I Wu1f851912015-10-27 18:04:07 +08001856 deleteCommandBuffers(dev_data);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001857 deletePools(dev_data);
1858 deleteLayouts(dev_data);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001859 dev_data->imageViewMap.clear();
1860 dev_data->imageMap.clear();
1861 dev_data->bufferViewMap.clear();
1862 dev_data->bufferMap.clear();
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001863 loader_platform_thread_unlock_mutex(&globalLock);
1864
Chia-I Wu69f40122015-10-26 21:10:41 +08001865 dev_data->device_dispatch_table->DestroyDevice(device, pAllocator);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001866 tableDebugMarkerMap.erase(key);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001867 delete dev_data->device_dispatch_table;
1868 layer_data_map.erase(key);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001869}
1870
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001871static const VkLayerProperties ds_global_layers[] = {
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -06001872 {
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -06001873 "DrawState",
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001874 VK_API_VERSION,
1875 VK_MAKE_VERSION(0, 1, 0),
1876 "Validation layer: DrawState",
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -06001877 }
Jon Ashburneb2728b2015-04-10 14:33:07 -06001878};
1879
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001880VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001881 const char *pLayerName,
1882 uint32_t *pCount,
1883 VkExtensionProperties* pProperties)
Jon Ashburneb2728b2015-04-10 14:33:07 -06001884{
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001885 /* DrawState does not have any global extensions */
1886 return util_GetExtensionProperties(0, NULL, pCount, pProperties);
1887}
Jon Ashburneb2728b2015-04-10 14:33:07 -06001888
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001889VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001890 uint32_t *pCount,
1891 VkLayerProperties* pProperties)
1892{
1893 return util_GetLayerProperties(ARRAY_SIZE(ds_global_layers),
1894 ds_global_layers,
1895 pCount, pProperties);
1896}
Jon Ashburneb2728b2015-04-10 14:33:07 -06001897
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001898static const VkExtensionProperties ds_device_extensions[] = {
1899 {
1900 DEBUG_MARKER_EXTENSION_NAME,
1901 VK_MAKE_VERSION(0, 1, 0),
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001902 }
1903};
1904
1905static const VkLayerProperties ds_device_layers[] = {
1906 {
1907 "DrawState",
1908 VK_API_VERSION,
1909 VK_MAKE_VERSION(0, 1, 0),
1910 "Validation layer: DrawState",
1911 }
1912};
1913
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001914VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001915 VkPhysicalDevice physicalDevice,
1916 const char* pLayerName,
1917 uint32_t* pCount,
1918 VkExtensionProperties* pProperties)
1919{
Jon Ashburnaff81ff2015-11-02 17:37:20 -07001920 if (pLayerName == NULL) {
1921 dispatch_key key = get_dispatch_key(physicalDevice);
1922 layer_data *my_data = get_my_data_ptr(key, layer_data_map);
1923 VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table;
1924 return pTable->EnumerateDeviceExtensionProperties(
1925 physicalDevice,
1926 NULL,
1927 pCount,
1928 pProperties);
1929 } else {
1930 return util_GetExtensionProperties(ARRAY_SIZE(ds_device_extensions),
1931 ds_device_extensions,
1932 pCount, pProperties);
1933 }
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001934}
1935
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001936VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001937 VkPhysicalDevice physicalDevice,
1938 uint32_t* pCount,
1939 VkLayerProperties* pProperties)
1940{
1941 /* Mem tracker's physical device layers are the same as global */
1942 return util_GetLayerProperties(ARRAY_SIZE(ds_device_layers), ds_device_layers,
1943 pCount, pProperties);
Jon Ashburneb2728b2015-04-10 14:33:07 -06001944}
1945
Michael Lentine27b0f902015-10-12 11:30:14 -05001946bool ValidateCmdBufImageLayouts(VkCommandBuffer cmdBuffer) {
1947 bool skip_call = false;
1948 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
1949 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
1950 for (auto cb_image_data : pCB->imageLayoutMap) {
1951 auto image_data = dev_data->imageLayoutMap.find(cb_image_data.first);
1952 if (image_data == dev_data->imageLayoutMap.end()) {
1953 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001954 "Cannot submit cmd buffer using deleted image %" PRIu64 ".", reinterpret_cast<uint64_t>(cb_image_data.first));
Michael Lentine27b0f902015-10-12 11:30:14 -05001955 } else {
1956 if (dev_data->imageLayoutMap[cb_image_data.first]->layout != cb_image_data.second.initialLayout) {
1957 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
1958 "Cannot submit cmd buffer using image with layout %d when first use is %d.", dev_data->imageLayoutMap[cb_image_data.first]->layout, cb_image_data.second.initialLayout);
1959 }
1960 dev_data->imageLayoutMap[cb_image_data.first]->layout = cb_image_data.second.layout;
1961 }
1962 }
1963 return skip_call;
1964}
1965
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001966VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo* pSubmits, VkFence fence)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001967{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001968 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis28be0be2015-05-22 12:38:16 -06001969 GLOBAL_CB_NODE* pCB = NULL;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001970 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map);
Courtney Goeltzenleuchter3ec31622015-10-20 18:04:07 -06001971 for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) {
Chia-I Wu483e7702015-10-26 17:20:32 +08001972 const VkSubmitInfo *submit = &pSubmits[submit_idx];
Chia-I Wu763a7492015-10-26 20:48:51 +08001973 for (uint32_t i=0; i < submit->commandBufferCount; i++) {
Michael Lentine27b0f902015-10-12 11:30:14 -05001974 skipCall |= ValidateCmdBufImageLayouts(submit->pCommandBuffers[i]);
Courtney Goeltzenleuchter3ec31622015-10-20 18:04:07 -06001975 // Validate that cmd buffers have been updated
1976 pCB = getCBNode(dev_data, submit->pCommandBuffers[i]);
1977 loader_platform_thread_lock_mutex(&globalLock);
1978 pCB->submitCount++; // increment submit count
Chia-I Wu1f851912015-10-27 18:04:07 +08001979 if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) {
1980 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05001981 "CB %#" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT set, but has been submitted %#" PRIxLEAST64 " times.",
1982 reinterpret_cast<uint64_t>(pCB->commandBuffer), pCB->submitCount);
Courtney Goeltzenleuchter3ec31622015-10-20 18:04:07 -06001983 }
1984 if (CB_UPDATE_COMPLETE != pCB->state) {
1985 // Flag error for using CB w/o vkEndCommandBuffer() called
1986 // TODO : How to pass cb as srcObj?
Chia-I Wu1f851912015-10-27 18:04:07 +08001987 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS",
1988 "You must call vkEndCommandBuffer() on CB %#" PRIxLEAST64 " before this call to vkQueueSubmit()!", reinterpret_cast<uint64_t>(pCB->commandBuffer));
Courtney Goeltzenleuchter3ec31622015-10-20 18:04:07 -06001989 loader_platform_thread_unlock_mutex(&globalLock);
1990 return VK_ERROR_VALIDATION_FAILED;
1991 }
Tobin Ehlise90b1712015-05-27 14:30:06 -06001992 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis28be0be2015-05-22 12:38:16 -06001993 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001994 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001995 if (VK_FALSE == skipCall)
Chia-I Wu483e7702015-10-26 17:20:32 +08001996 return dev_data->device_dispatch_table->QueueSubmit(queue, submitCount, pSubmits, fence);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001997 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001998}
1999
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002000VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002001{
Chia-I Wu69f40122015-10-26 21:10:41 +08002002 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyFence(device, fence, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002003 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002004}
2005
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002006VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002007{
Chia-I Wu69f40122015-10-26 21:10:41 +08002008 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySemaphore(device, semaphore, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002009 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002010}
2011
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002012VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002013{
Chia-I Wu69f40122015-10-26 21:10:41 +08002014 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyEvent(device, event, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002015 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002016}
2017
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002018VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002019{
Chia-I Wu69f40122015-10-26 21:10:41 +08002020 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyQueryPool(device, queryPool, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002021 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002022}
2023
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002024VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyBuffer(VkDevice device, VkBuffer buffer, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002025{
Tobin Ehlisb46be812015-10-23 16:00:08 -06002026 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002027 dev_data->device_dispatch_table->DestroyBuffer(device, buffer, pAllocator);
Chia-I Wue420a332015-10-26 20:04:44 +08002028 dev_data->bufferMap.erase(buffer);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002029}
2030
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002031VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002032{
Tobin Ehlisb46be812015-10-23 16:00:08 -06002033 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002034 dev_data->device_dispatch_table->DestroyBufferView(device, bufferView, pAllocator);
Chia-I Wue420a332015-10-26 20:04:44 +08002035 dev_data->bufferViewMap.erase(bufferView);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002036}
2037
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002038VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002039{
Tobin Ehlisb46be812015-10-23 16:00:08 -06002040 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002041 dev_data->device_dispatch_table->DestroyImage(device, image, pAllocator);
Chia-I Wue420a332015-10-26 20:04:44 +08002042 dev_data->imageMap.erase(image);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002043}
2044
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002045VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002046{
Chia-I Wu69f40122015-10-26 21:10:41 +08002047 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyImageView(device, imageView, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002048 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002049}
2050
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002051VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002052{
Chia-I Wu69f40122015-10-26 21:10:41 +08002053 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyShaderModule(device, shaderModule, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002054 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002055}
2056
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002057VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002058{
Chia-I Wu69f40122015-10-26 21:10:41 +08002059 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipeline(device, pipeline, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002060 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002061}
2062
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002063VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002064{
Chia-I Wu69f40122015-10-26 21:10:41 +08002065 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipelineLayout(device, pipelineLayout, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002066 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002067}
2068
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002069VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002070{
Chia-I Wu69f40122015-10-26 21:10:41 +08002071 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySampler(device, sampler, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002072 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002073}
2074
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002075VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002076{
Chia-I Wu69f40122015-10-26 21:10:41 +08002077 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002078 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002079}
2080
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002081VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002082{
Chia-I Wu69f40122015-10-26 21:10:41 +08002083 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyDescriptorPool(device, descriptorPool, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002084 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002085}
2086
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002087VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t count, const VkCommandBuffer *pCommandBuffers)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002088{
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002089 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
2090
2091 for (auto i = 0; i < count; i++) {
2092 // Delete CB information structure, and remove from commandBufferMap
2093 auto cb = dev_data->commandBufferMap.find(pCommandBuffers[i]);
2094 if (cb != dev_data->commandBufferMap.end()) {
2095 delete (*cb).second;
2096 dev_data->commandBufferMap.erase(cb);
2097 }
2098
2099 // Remove commandBuffer reference from commandPoolMap
2100 dev_data->commandPoolMap[commandPool].remove(pCommandBuffers[i]);
2101 }
2102
2103 dev_data->device_dispatch_table->FreeCommandBuffers(device, commandPool, count, pCommandBuffers);
2104}
2105
2106VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkCommandPool* pCommandPool)
2107{
2108 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
2109
2110 VkResult result = dev_data->device_dispatch_table->CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
2111
2112 if (VK_SUCCESS == result) {
2113 dev_data->commandPoolMap[*pCommandPool];
2114 }
2115 return result;
2116}
2117
2118VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks* pAllocator)
2119{
2120 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
2121
2122 // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandPoolMap
2123 if (dev_data->commandPoolMap.find(commandPool) != dev_data->commandPoolMap.end()) {
2124 for (auto poolCb = dev_data->commandPoolMap[commandPool].begin(); poolCb != dev_data->commandPoolMap[commandPool].end();) {
2125 auto del_cb = dev_data->commandBufferMap.find(*poolCb);
2126 delete (*del_cb).second; // delete CB info structure
2127 dev_data->commandBufferMap.erase(del_cb); // Remove this command buffer from cbMap
2128 poolCb = dev_data->commandPoolMap[commandPool].erase(poolCb); // Remove CB reference from commandPoolMap's list
2129 }
2130 }
2131 dev_data->commandPoolMap.erase(commandPool);
2132 dev_data->device_dispatch_table->DestroyCommandPool(device, commandPool, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002133}
2134
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002135VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002136{
Chia-I Wu69f40122015-10-26 21:10:41 +08002137 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyFramebuffer(device, framebuffer, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002138 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002139}
2140
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002141VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002142{
Chia-I Wu69f40122015-10-26 21:10:41 +08002143 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyRenderPass(device, renderPass, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002144 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002145}
2146
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002147VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBuffer(VkDevice device, const VkBufferCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkBuffer* pBuffer)
Tobin Ehlisb46be812015-10-23 16:00:08 -06002148{
2149 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002150 VkResult result = dev_data->device_dispatch_table->CreateBuffer(device, pCreateInfo, pAllocator, pBuffer);
Tobin Ehlisb46be812015-10-23 16:00:08 -06002151 if (VK_SUCCESS == result) {
2152 loader_platform_thread_lock_mutex(&globalLock);
2153 // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid
Chia-I Wue420a332015-10-26 20:04:44 +08002154 dev_data->bufferMap[*pBuffer] = unique_ptr<VkBufferCreateInfo>(new VkBufferCreateInfo(*pCreateInfo));
Tobin Ehlisb46be812015-10-23 16:00:08 -06002155 loader_platform_thread_unlock_mutex(&globalLock);
2156 }
2157 return result;
2158}
2159
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002160VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBufferView(VkDevice device, const VkBufferViewCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkBufferView* pView)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002161{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002162 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002163 VkResult result = dev_data->device_dispatch_table->CreateBufferView(device, pCreateInfo, pAllocator, pView);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002164 if (VK_SUCCESS == result) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002165 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08002166 dev_data->bufferViewMap[*pView] = unique_ptr<VkBufferViewCreateInfo>(new VkBufferViewCreateInfo(*pCreateInfo));
Tobin Ehlisb46be812015-10-23 16:00:08 -06002167 loader_platform_thread_unlock_mutex(&globalLock);
2168 }
2169 return result;
2170}
2171
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002172VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImage(VkDevice device, const VkImageCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkImage* pImage)
Tobin Ehlisb46be812015-10-23 16:00:08 -06002173{
2174 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002175 VkResult result = dev_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage);
Tobin Ehlisb46be812015-10-23 16:00:08 -06002176 if (VK_SUCCESS == result) {
Michael Lentine27b0f902015-10-12 11:30:14 -05002177 IMAGE_NODE* image_node = new IMAGE_NODE;
2178 image_node->layout = pCreateInfo->initialLayout;
Tobin Ehlisb46be812015-10-23 16:00:08 -06002179 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08002180 dev_data->imageMap[*pImage] = unique_ptr<VkImageCreateInfo>(new VkImageCreateInfo(*pCreateInfo));
Michael Lentine27b0f902015-10-12 11:30:14 -05002181 dev_data->imageLayoutMap[*pImage] = image_node;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002182 loader_platform_thread_unlock_mutex(&globalLock);
2183 }
2184 return result;
2185}
2186
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002187VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImageView(VkDevice device, const VkImageViewCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkImageView* pView)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002188{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002189 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002190 VkResult result = dev_data->device_dispatch_table->CreateImageView(device, pCreateInfo, pAllocator, pView);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002191 if (VK_SUCCESS == result) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002192 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08002193 dev_data->imageViewMap[*pView] = unique_ptr<VkImageViewCreateInfo>(new VkImageViewCreateInfo(*pCreateInfo));
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06002194 loader_platform_thread_unlock_mutex(&globalLock);
2195 }
2196 return result;
2197}
2198
Jon Ashburn0d60d272015-07-09 15:02:25 -06002199//TODO handle pipeline caches
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002200VKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineCache(
Jon Ashburn0d60d272015-07-09 15:02:25 -06002201 VkDevice device,
2202 const VkPipelineCacheCreateInfo* pCreateInfo,
Chia-I Wu1f851912015-10-27 18:04:07 +08002203 const VkAllocationCallbacks* pAllocator,
Jon Ashburn0d60d272015-07-09 15:02:25 -06002204 VkPipelineCache* pPipelineCache)
2205{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002206 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002207 VkResult result = dev_data->device_dispatch_table->CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache);
Jon Ashburn0d60d272015-07-09 15:02:25 -06002208 return result;
2209}
2210
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002211VKAPI_ATTR void VKAPI_CALL vkDestroyPipelineCache(
Jon Ashburn0d60d272015-07-09 15:02:25 -06002212 VkDevice device,
Chia-I Wu69f40122015-10-26 21:10:41 +08002213 VkPipelineCache pipelineCache,
Chia-I Wu1f851912015-10-27 18:04:07 +08002214 const VkAllocationCallbacks* pAllocator)
Jon Ashburn0d60d272015-07-09 15:02:25 -06002215{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002216 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002217 dev_data->device_dispatch_table->DestroyPipelineCache(device, pipelineCache, pAllocator);
Jon Ashburn0d60d272015-07-09 15:02:25 -06002218}
2219
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002220VKAPI_ATTR VkResult VKAPI_CALL vkGetPipelineCacheData(
Jon Ashburn0d60d272015-07-09 15:02:25 -06002221 VkDevice device,
2222 VkPipelineCache pipelineCache,
Chia-I Wu28c3c432015-10-26 19:17:06 +08002223 size_t* pDataSize,
Jon Ashburn0d60d272015-07-09 15:02:25 -06002224 void* pData)
2225{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002226 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu28c3c432015-10-26 19:17:06 +08002227 VkResult result = dev_data->device_dispatch_table->GetPipelineCacheData(device, pipelineCache, pDataSize, pData);
Jon Ashburn0d60d272015-07-09 15:02:25 -06002228 return result;
2229}
2230
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002231VKAPI_ATTR VkResult VKAPI_CALL vkMergePipelineCaches(
Jon Ashburn0d60d272015-07-09 15:02:25 -06002232 VkDevice device,
Chia-I Wu1f851912015-10-27 18:04:07 +08002233 VkPipelineCache dstCache,
Jon Ashburn0d60d272015-07-09 15:02:25 -06002234 uint32_t srcCacheCount,
2235 const VkPipelineCache* pSrcCaches)
2236{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002237 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu1f851912015-10-27 18:04:07 +08002238 VkResult result = dev_data->device_dispatch_table->MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches);
Jon Ashburn0d60d272015-07-09 15:02:25 -06002239 return result;
2240}
2241
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002242VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, const VkGraphicsPipelineCreateInfo* pCreateInfos, const VkAllocationCallbacks* pAllocator, VkPipeline* pPipelines)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002243{
Courtney Goeltzenleuchtera54b76a2015-09-04 13:39:59 -06002244 VkResult result = VK_SUCCESS;
Tobin Ehlise48be202015-09-16 10:33:53 -06002245 //TODO What to do with pipelineCache?
Tobin Ehlisde63c532015-06-18 15:59:33 -06002246 // The order of operations here is a little convoluted but gets the job done
2247 // 1. Pipeline create state is first shadowed into PIPELINE_NODE struct
2248 // 2. Create state is then validated (which uses flags setup during shadowing)
2249 // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap
Tobin Ehlise48be202015-09-16 10:33:53 -06002250 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis76c18852015-09-17 16:33:58 -06002251 // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic
2252 vector<PIPELINE_NODE*> pPipeNode(count);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002253 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Tobin Ehlise48be202015-09-16 10:33:53 -06002254 uint32_t i=0;
Tobin Ehlisde63c532015-06-18 15:59:33 -06002255 loader_platform_thread_lock_mutex(&globalLock);
Tobin Ehlise48be202015-09-16 10:33:53 -06002256 for (i=0; i<count; i++) {
Chia-I Wuf273d5a2015-10-26 19:52:46 +08002257 pPipeNode[i] = initPipeline(dev_data, &pCreateInfos[i], NULL);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002258 skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]);
Tobin Ehlise48be202015-09-16 10:33:53 -06002259 }
Tobin Ehlisde63c532015-06-18 15:59:33 -06002260 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002261 if (VK_FALSE == skipCall) {
Chia-I Wu69f40122015-10-26 21:10:41 +08002262 result = dev_data->device_dispatch_table->CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, pPipelines);
Tobin Ehlisde63c532015-06-18 15:59:33 -06002263 loader_platform_thread_lock_mutex(&globalLock);
Tobin Ehlise48be202015-09-16 10:33:53 -06002264 for (i=0; i<count; i++) {
2265 pPipeNode[i]->pipeline = pPipelines[i];
Chia-I Wue420a332015-10-26 20:04:44 +08002266 dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i];
Tobin Ehlise48be202015-09-16 10:33:53 -06002267 }
Tobin Ehlisde63c532015-06-18 15:59:33 -06002268 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002269 } else {
Tobin Ehlise48be202015-09-16 10:33:53 -06002270 for (i=0; i<count; i++) {
2271 if (pPipeNode[i]) {
2272 // If we allocated a pipeNode, need to clean it up here
2273 delete[] pPipeNode[i]->pVertexBindingDescriptions;
2274 delete[] pPipeNode[i]->pVertexAttributeDescriptions;
2275 delete[] pPipeNode[i]->pAttachments;
2276 delete pPipeNode[i];
2277 }
Tobin Ehlisde63c532015-06-18 15:59:33 -06002278 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002279 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlisde63c532015-06-18 15:59:33 -06002280 }
Courtney Goeltzenleuchter9452ac22015-04-13 16:16:04 -06002281 return result;
2282}
2283
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002284VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSampler(VkDevice device, const VkSamplerCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkSampler* pSampler)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002285{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002286 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002287 VkResult result = dev_data->device_dispatch_table->CreateSampler(device, pCreateInfo, pAllocator, pSampler);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002288 if (VK_SUCCESS == result) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002289 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08002290 dev_data->sampleMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo));
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002291 loader_platform_thread_unlock_mutex(&globalLock);
2292 }
2293 return result;
2294}
2295
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002296VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDescriptorSetLayout* pSetLayout)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002297{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002298 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002299 VkResult result = dev_data->device_dispatch_table->CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002300 if (VK_SUCCESS == result) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002301 LAYOUT_NODE* pNewNode = new LAYOUT_NODE;
2302 if (NULL == pNewNode) {
Chia-I Wue420a332015-10-26 20:04:44 +08002303 if (log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT, (uint64_t) *pSetLayout, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002304 "Out of memory while attempting to allocate LAYOUT_NODE in vkCreateDescriptorSetLayout()"))
2305 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002306 }
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06002307 memcpy((void*)&pNewNode->createInfo, pCreateInfo, sizeof(VkDescriptorSetLayoutCreateInfo));
Chia-I Wuf03cbf72015-10-31 00:31:16 +08002308 pNewNode->createInfo.pBinding = new VkDescriptorSetLayoutBinding[pCreateInfo->bindingCount];
2309 memcpy((void*)pNewNode->createInfo.pBinding, pCreateInfo->pBinding, sizeof(VkDescriptorSetLayoutBinding)*pCreateInfo->bindingCount);
Chia-I Wub5689ee2015-10-31 00:31:16 +08002310 // g++ does not like reserve with size 0
2311 if (pCreateInfo->bindingCount)
2312 pNewNode->bindings.reserve(pCreateInfo->bindingCount);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002313 uint32_t totalCount = 0;
Chia-I Wu763a7492015-10-26 20:48:51 +08002314 for (uint32_t i=0; i<pCreateInfo->bindingCount; i++) {
Chia-I Wub5689ee2015-10-31 00:31:16 +08002315 if (!pNewNode->bindings.insert(pCreateInfo->pBinding[i].binding).second) {
2316 if (log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT, (uint64_t) *pSetLayout, 0, DRAWSTATE_INVALID_LAYOUT, "DS",
2317 "duplicated binding number in VkDescriptorSetLayoutBinding"))
2318 return VK_ERROR_VALIDATION_FAILED;
2319 }
2320
Chia-I Wu045654f2015-11-06 06:42:02 +08002321 totalCount += pCreateInfo->pBinding[i].descriptorCount;
Chia-I Wuf03cbf72015-10-31 00:31:16 +08002322 if (pCreateInfo->pBinding[i].pImmutableSamplers) {
2323 VkSampler** ppIS = (VkSampler**)&pNewNode->createInfo.pBinding[i].pImmutableSamplers;
Chia-I Wu045654f2015-11-06 06:42:02 +08002324 *ppIS = new VkSampler[pCreateInfo->pBinding[i].descriptorCount];
2325 memcpy(*ppIS, pCreateInfo->pBinding[i].pImmutableSamplers, pCreateInfo->pBinding[i].descriptorCount*sizeof(VkSampler));
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002326 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002327 }
2328 if (totalCount > 0) {
Cody Northrop8a908322015-10-26 14:07:35 -06002329 pNewNode->descriptorTypes.resize(totalCount);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06002330 pNewNode->stageFlags.resize(totalCount);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002331 uint32_t offset = 0;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002332 uint32_t j = 0;
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002333 VkDescriptorType dType;
Chia-I Wu763a7492015-10-26 20:48:51 +08002334 for (uint32_t i=0; i<pCreateInfo->bindingCount; i++) {
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002335 dType = pCreateInfo->pBinding[i].descriptorType;
Chia-I Wu045654f2015-11-06 06:42:02 +08002336 for (j = 0; j < pCreateInfo->pBinding[i].descriptorCount; j++) {
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002337 pNewNode->descriptorTypes[offset + j] = dType;
Chia-I Wuf03cbf72015-10-31 00:31:16 +08002338 pNewNode->stageFlags[offset + j] = pCreateInfo->pBinding[i].stageFlags;
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002339 if ((dType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2340 (dType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2341 pNewNode->dynamicDescriptorCount++;
2342 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002343 }
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002344 offset += j;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002345 }
2346 }
2347 pNewNode->layout = *pSetLayout;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002348 pNewNode->startIndex = 0;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002349 pNewNode->endIndex = pNewNode->startIndex + totalCount - 1;
2350 assert(pNewNode->endIndex >= pNewNode->startIndex);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002351 // Put new node at Head of global Layer list
2352 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08002353 dev_data->layoutMap[*pSetLayout] = pNewNode;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002354 loader_platform_thread_unlock_mutex(&globalLock);
2355 }
2356 return result;
2357}
2358
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002359VKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkPipelineLayout* pPipelineLayout)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002360{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002361 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002362 VkResult result = dev_data->device_dispatch_table->CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002363 if (VK_SUCCESS == result) {
Tobin Ehlis982099b2015-11-05 09:52:49 -07002364 PIPELINE_LAYOUT_NODE& plNode = dev_data->pipelineLayoutMap[*pPipelineLayout];
Chia-I Wu763a7492015-10-26 20:48:51 +08002365 plNode.descriptorSetLayouts.resize(pCreateInfo->setLayoutCount);
Tobin Ehlis91423d22015-10-20 10:11:55 -06002366 uint32_t i = 0;
Chia-I Wu763a7492015-10-26 20:48:51 +08002367 for (i=0; i<pCreateInfo->setLayoutCount; ++i) {
Tobin Ehlis91423d22015-10-20 10:11:55 -06002368 plNode.descriptorSetLayouts[i] = pCreateInfo->pSetLayouts[i];
2369 }
Cody Northrop8a908322015-10-26 14:07:35 -06002370 plNode.pushConstantRanges.resize(pCreateInfo->pushConstantRangeCount);
Tobin Ehlis91423d22015-10-20 10:11:55 -06002371 for (i=0; i<pCreateInfo->pushConstantRangeCount; ++i) {
2372 plNode.pushConstantRanges[i] = pCreateInfo->pPushConstantRanges[i];
2373 }
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002374 }
2375 return result;
2376}
2377
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002378VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDescriptorPool* pDescriptorPool)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002379{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002380 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002381 VkResult result = dev_data->device_dispatch_table->CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002382 if (VK_SUCCESS == result) {
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002383 // Insert this pool into Global Pool LL at head
Chia-I Wue420a332015-10-26 20:04:44 +08002384 if (log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_DESCRIPTOR_POOL, (uint64_t) *pDescriptorPool, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
2385 "Created Descriptor Pool %#" PRIxLEAST64, (uint64_t) *pDescriptorPool))
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002386 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002387 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002388 DESCRIPTOR_POOL_NODE* pNewNode = new DESCRIPTOR_POOL_NODE(*pDescriptorPool, pCreateInfo);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002389 if (NULL == pNewNode) {
Chia-I Wue420a332015-10-26 20:04:44 +08002390 if (log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_POOL, (uint64_t) *pDescriptorPool, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002391 "Out of memory while attempting to allocate DESCRIPTOR_POOL_NODE in vkCreateDescriptorPool()"))
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002392 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002393 } else {
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002394 dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002395 }
2396 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002397 } else {
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002398 // Need to do anything if pool create fails?
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002399 }
2400 return result;
2401}
2402
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002403VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002404{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002405 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06002406 VkResult result = dev_data->device_dispatch_table->ResetDescriptorPool(device, descriptorPool, flags);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002407 if (VK_SUCCESS == result) {
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06002408 clearDescriptorPool(dev_data, device, descriptorPool, flags);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002409 }
2410 return result;
2411}
2412
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002413VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo* pAllocateInfo, VkDescriptorSet* pDescriptorSets)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002414{
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002415 VkBool32 skipCall = VK_FALSE;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002416 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002417 // Verify that requested descriptorSets are available in pool
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002418 DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002419 if (!pPoolNode) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002420 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_POOL, (uint64_t) pAllocateInfo->descriptorPool, 0, DRAWSTATE_INVALID_POOL, "DS",
2421 "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", (uint64_t) pAllocateInfo->descriptorPool);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002422 } else { // Make sure pool has all the available descriptors before calling down chain
Chia-I Wu1f851912015-10-27 18:04:07 +08002423 skipCall |= validate_descriptor_availability_in_pool(dev_data, pPoolNode, pAllocateInfo->setLayoutCount, pAllocateInfo->pSetLayouts);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002424 }
2425 if (skipCall)
2426 return VK_ERROR_VALIDATION_FAILED;
Chia-I Wu1f851912015-10-27 18:04:07 +08002427 VkResult result = dev_data->device_dispatch_table->AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets);
Cody Northropc8aa4a52015-08-03 12:47:29 -06002428 if (VK_SUCCESS == result) {
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002429 DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002430 if (pPoolNode) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002431 if (pAllocateInfo->setLayoutCount == 0) {
2432 log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, pAllocateInfo->setLayoutCount, 0, DRAWSTATE_NONE, "DS",
2433 "AllocateDescriptorSets called with 0 count");
Cody Northropc8aa4a52015-08-03 12:47:29 -06002434 }
Chia-I Wu1f851912015-10-27 18:04:07 +08002435 for (uint32_t i = 0; i < pAllocateInfo->setLayoutCount; i++) {
Chia-I Wue420a332015-10-26 20:04:44 +08002436 log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_NONE, "DS",
2437 "Created Descriptor Set %#" PRIxLEAST64, (uint64_t) pDescriptorSets[i]);
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002438 // Create new set node and add to head of pool nodes
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002439 SET_NODE* pNewNode = new SET_NODE;
2440 if (NULL == pNewNode) {
Chia-I Wue420a332015-10-26 20:04:44 +08002441 if (log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08002442 "Out of memory while attempting to allocate SET_NODE in vkAllocateDescriptorSets()"))
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002443 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002444 } else {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002445 memset(pNewNode, 0, sizeof(SET_NODE));
Tobin Ehlisf6e93e02015-10-19 12:09:13 -06002446 // TODO : Pool should store a total count of each type of Descriptor available
2447 // When descriptors are allocated, decrement the count and validate here
2448 // that the count doesn't go below 0. One reset/free need to bump count back up.
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002449 // Insert set at head of Set LL for this pool
2450 pNewNode->pNext = pPoolNode->pSets;
2451 pPoolNode->pSets = pNewNode;
Chia-I Wu1f851912015-10-27 18:04:07 +08002452 LAYOUT_NODE* pLayout = getLayoutNode(dev_data, pAllocateInfo->pSetLayouts[i]);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002453 if (NULL == pLayout) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002454 if (log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT, (uint64_t) pAllocateInfo->pSetLayouts[i], 0, DRAWSTATE_INVALID_LAYOUT, "DS",
2455 "Unable to find set layout node for layout %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", (uint64_t) pAllocateInfo->pSetLayouts[i]))
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002456 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002457 }
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002458 pNewNode->pLayout = pLayout;
Chia-I Wu1f851912015-10-27 18:04:07 +08002459 pNewNode->pool = pAllocateInfo->descriptorPool;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002460 pNewNode->set = pDescriptorSets[i];
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002461 pNewNode->descriptorCount = pLayout->endIndex + 1;
2462 if (pNewNode->descriptorCount) {
2463 size_t descriptorArraySize = sizeof(GENERIC_HEADER*)*pNewNode->descriptorCount;
2464 pNewNode->ppDescriptors = new GENERIC_HEADER*[descriptorArraySize];
2465 memset(pNewNode->ppDescriptors, 0, descriptorArraySize);
2466 }
Chia-I Wue420a332015-10-26 20:04:44 +08002467 dev_data->setMap[pDescriptorSets[i]] = pNewNode;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002468 }
2469 }
2470 }
2471 }
2472 return result;
2473}
2474
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002475VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet* pDescriptorSets)
Tony Barbourb857d312015-07-10 10:50:45 -06002476{
Tobin Ehlis3c543112015-10-08 13:13:50 -06002477 VkBool32 skipCall = VK_FALSE;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002478 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002479 DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, descriptorPool);
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06002480 if (pPoolNode && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pPoolNode->createInfo.flags)) {
2481 // Can't Free from a NON_FREE pool
2482 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DEVICE, (uint64_t)device, 0, DRAWSTATE_CANT_FREE_FROM_NON_FREE_POOL, "DS",
2483 "It is invalid to call vkFreeDescriptorSets() with a pool created without setting VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT.");
Tobin Ehlis3c543112015-10-08 13:13:50 -06002484 }
2485 if (skipCall)
2486 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002487 VkResult result = dev_data->device_dispatch_table->FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002488 if (VK_SUCCESS == result) {
2489 // For each freed descriptor add it back into the pool as available
2490 for (uint32_t i=0; i<count; ++i) {
Chia-I Wue420a332015-10-26 20:04:44 +08002491 SET_NODE* pSet = dev_data->setMap[pDescriptorSets[i]]; // getSetNode() without locking
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002492 LAYOUT_NODE* pLayout = pSet->pLayout;
Chia-I Wuc51b1212015-10-27 19:25:11 +08002493 uint32_t typeIndex = 0, poolSizeCount = 0;
Chia-I Wu763a7492015-10-26 20:48:51 +08002494 for (uint32_t j=0; j<pLayout->createInfo.bindingCount; ++j) {
Chia-I Wuf03cbf72015-10-31 00:31:16 +08002495 typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBinding[j].descriptorType);
Chia-I Wu045654f2015-11-06 06:42:02 +08002496 poolSizeCount = pLayout->createInfo.pBinding[j].descriptorCount;
Chia-I Wuc51b1212015-10-27 19:25:11 +08002497 pPoolNode->availableDescriptorTypeCount[typeIndex] += poolSizeCount;
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002498 }
2499 }
2500 }
2501 // TODO : Any other clean-up or book-keeping to do here?
Tony Barbourb857d312015-07-10 10:50:45 -06002502 return result;
2503}
2504
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002505VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet* pDescriptorWrites, uint32_t descriptorCopyCount, const VkCopyDescriptorSet* pDescriptorCopies)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002506{
Tobin Ehlis68fbd442015-10-27 12:25:35 -06002507 // dsUpdate will return VK_TRUE only if a bailout error occurs, so we want to call down tree when update returns VK_FALSE
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002508 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu483e7702015-10-26 17:20:32 +08002509 if (!dsUpdate(dev_data, device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, pDescriptorCopies)) {
2510 dev_data->device_dispatch_table->UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, pDescriptorCopies);
Jon Ashburne0fa2282015-05-20 09:00:28 -06002511 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002512}
2513
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002514VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo* pCreateInfo, VkCommandBuffer* pCommandBuffer)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002515{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002516 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu1f851912015-10-27 18:04:07 +08002517 VkResult result = dev_data->device_dispatch_table->AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002518 if (VK_SUCCESS == result) {
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002519 for (auto i = 0; i < pCreateInfo->bufferCount; i++) {
2520 // Validate command pool
2521 if (dev_data->commandPoolMap.find(pCreateInfo->commandPool) != dev_data->commandPoolMap.end()) {
2522 // Add command buffer to its commandPool map
2523 dev_data->commandPoolMap[pCreateInfo->commandPool].push_back(pCommandBuffer[i]);
2524
2525 GLOBAL_CB_NODE* pCB = new GLOBAL_CB_NODE;
2526 // Add command buffer to map
2527 dev_data->commandBufferMap[pCommandBuffer[i]] = pCB;
2528 resetCB(dev_data, pCommandBuffer[i]);
2529 pCB->commandBuffer = pCommandBuffer[i];
2530 pCB->createInfo = *pCreateInfo;
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002531 updateCBTracking(pCB);
2532 }
2533 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002534 }
2535 return result;
2536}
2537
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002538VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo* pBeginInfo)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002539{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002540 VkBool32 skipCall = false;
Chia-I Wu1f851912015-10-27 18:04:07 +08002541 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002542 // Validate command buffer level
Chia-I Wu1f851912015-10-27 18:04:07 +08002543 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002544 if (pCB) {
Mark Lobodzinskia1420862015-11-19 13:22:11 -07002545 if (pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) {
Chia-I Wue420a332015-10-26 20:04:44 +08002546 if (pBeginInfo->renderPass || pBeginInfo->framebuffer) {
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002547 // These should be NULL for a Primary CB
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002548 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS",
Mark Lobodzinskifc0ec622015-11-19 12:07:21 -07002549 "vkBeginCommandBuffer(): Primary Command Buffer (%p) may not specify framebuffer or renderpass parameters", (void*)commandBuffer);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002550 }
2551 } else {
Chia-I Wue420a332015-10-26 20:04:44 +08002552 if (!pBeginInfo->renderPass || !pBeginInfo->framebuffer) {
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002553 // These should NOT be null for an Secondary CB
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002554 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS",
Mark Lobodzinskifc0ec622015-11-19 12:07:21 -07002555 "vkBeginCommandBuffer(): Secondary Command Buffers (%p) must specify framebuffer and renderpass parameters", (void*)commandBuffer);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002556 }
2557 }
Tobin Ehlis0cea4082015-08-18 07:10:58 -06002558 pCB->beginInfo = *pBeginInfo;
2559 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002560 // TODO : Need to pass commandBuffer as objType here
2561 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
2562 "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB %p!", (void*)commandBuffer);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002563 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002564 if (skipCall) {
2565 return VK_ERROR_VALIDATION_FAILED;
Courtney Goeltzenleuchter3abd86e2015-09-04 15:03:52 -06002566 }
Chia-I Wu1f851912015-10-27 18:04:07 +08002567 VkResult result = dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo);
Mark Lobodzinski2ad35592015-11-12 16:14:04 -07002568 if ((VK_SUCCESS == result) && (pCB != NULL)) {
2569 if (CB_NEW != pCB->state) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002570 resetCB(dev_data, commandBuffer);
Mark Lobodzinski2ad35592015-11-12 16:14:04 -07002571 }
Tobin Ehlis0cea4082015-08-18 07:10:58 -06002572 pCB->state = CB_UPDATE_ACTIVE;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002573 updateCBTracking(pCB);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002574 }
2575 return result;
2576}
2577
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002578VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEndCommandBuffer(VkCommandBuffer commandBuffer)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002579{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002580 VkBool32 skipCall = VK_FALSE;
Courtney Goeltzenleuchtera54b76a2015-09-04 13:39:59 -06002581 VkResult result = VK_SUCCESS;
Chia-I Wu1f851912015-10-27 18:04:07 +08002582 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2583 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchtera54b76a2015-09-04 13:39:59 -06002584 /* TODO: preference is to always call API function after reporting any validation errors */
Tobin Ehlise42007c2015-06-19 13:00:59 -06002585 if (pCB) {
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002586 if (pCB->state != CB_UPDATE_ACTIVE) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002587 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkEndCommandBuffer()");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002588 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002589 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002590 if (VK_FALSE == skipCall) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002591 result = dev_data->device_dispatch_table->EndCommandBuffer(commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002592 if (VK_SUCCESS == result) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002593 updateCBTracking(pCB);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002594 pCB->state = CB_UPDATE_COMPLETE;
2595 // Reset CB status flags
2596 pCB->status = 0;
Chia-I Wu1f851912015-10-27 18:04:07 +08002597 printCB(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002598 }
2599 } else {
2600 result = VK_ERROR_VALIDATION_FAILED;
2601 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002602 return result;
2603}
2604
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002605VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002606{
Chia-I Wu1f851912015-10-27 18:04:07 +08002607 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2608 VkResult result = dev_data->device_dispatch_table->ResetCommandBuffer(commandBuffer, flags);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002609 if (VK_SUCCESS == result) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002610 resetCB(dev_data, commandBuffer);
2611 updateCBTracking(getCBNode(dev_data, commandBuffer));
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002612 }
2613 return result;
2614}
2615
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002616VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002617{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002618 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002619 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2620 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002621 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06002622 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002623 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002624 skipCall |= addCmd(dev_data, pCB, CMD_BINDPIPELINE);
Tobin Ehlis642d5a52015-06-23 08:46:18 -06002625 if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) {
Chia-I Wue420a332015-10-26 20:04:44 +08002626 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE, (uint64_t) pipeline,
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06002627 0, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS",
2628 "Incorrectly binding compute pipeline (%#" PRIxLEAST64 ") during active RenderPass (%#" PRIxLEAST64 ")",
Chia-I Wue420a332015-10-26 20:04:44 +08002629 (uint64_t) pipeline, (uint64_t) pCB->activeRenderPass);
Tobin Ehlise4076782015-06-24 15:53:07 -06002630 } else if ((VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) && (!pCB->activeRenderPass)) {
Chia-I Wue420a332015-10-26 20:04:44 +08002631 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE, (uint64_t) pipeline,
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06002632 0, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", "Incorrectly binding graphics pipeline "
Chia-I Wue420a332015-10-26 20:04:44 +08002633 " (%#" PRIxLEAST64 ") without an active RenderPass", (uint64_t) pipeline);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002634 } else {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002635 PIPELINE_NODE* pPN = getPipeline(dev_data, pipeline);
Tobin Ehlise4076782015-06-24 15:53:07 -06002636 if (pPN) {
2637 pCB->lastBoundPipeline = pipeline;
2638 loader_platform_thread_lock_mutex(&globalLock);
2639 set_cb_pso_status(pCB, pPN);
2640 g_lastBoundPipeline = pPN;
2641 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002642 skipCall |= validatePipelineState(dev_data, pCB, pipelineBindPoint, pipeline);
Tobin Ehlise4076782015-06-24 15:53:07 -06002643 } else {
Chia-I Wue420a332015-10-26 20:04:44 +08002644 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE, (uint64_t) pipeline,
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06002645 0, DRAWSTATE_INVALID_PIPELINE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08002646 "Attempt to bind Pipeline %#" PRIxLEAST64 " that doesn't exist!", reinterpret_cast<uint64_t>(pipeline));
Tobin Ehlise4076782015-06-24 15:53:07 -06002647 }
Tobin Ehlise42007c2015-06-19 13:00:59 -06002648 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002649 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002650 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindPipeline()");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002651 }
2652 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002653 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002654 dev_data->device_dispatch_table->CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002655}
2656
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002657VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetViewport(
Chia-I Wu1f851912015-10-27 18:04:07 +08002658 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002659 uint32_t viewportCount,
2660 const VkViewport* pViewports)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002661{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002662 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002663 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2664 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlise42007c2015-06-19 13:00:59 -06002665 if (pCB) {
2666 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002667 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002668 skipCall |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE);
Tobin Ehlise42007c2015-06-19 13:00:59 -06002669 loader_platform_thread_lock_mutex(&globalLock);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002670 pCB->status |= CBSTATUS_VIEWPORT_SET;
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002671 pCB->viewports.resize(viewportCount);
Tobin Ehlis9e839e52015-10-01 11:15:13 -06002672 memcpy(pCB->viewports.data(), pViewports, viewportCount * sizeof(VkViewport));
Tobin Ehlise42007c2015-06-19 13:00:59 -06002673 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlise42007c2015-06-19 13:00:59 -06002674 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002675 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetViewport()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06002676 }
2677 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002678 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002679 dev_data->device_dispatch_table->CmdSetViewport(commandBuffer, viewportCount, pViewports);
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002680}
2681
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002682VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetScissor(
Chia-I Wu1f851912015-10-27 18:04:07 +08002683 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002684 uint32_t scissorCount,
2685 const VkRect2D* pScissors)
2686{
2687 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002688 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2689 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002690 if (pCB) {
2691 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002692 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002693 skipCall |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE);
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002694 loader_platform_thread_lock_mutex(&globalLock);
2695 pCB->status |= CBSTATUS_SCISSOR_SET;
2696 pCB->scissors.resize(scissorCount);
Tobin Ehlis9e839e52015-10-01 11:15:13 -06002697 memcpy(pCB->scissors.data(), pScissors, scissorCount * sizeof(VkRect2D));
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002698 loader_platform_thread_unlock_mutex(&globalLock);
2699 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002700 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetScissor()");
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002701 }
2702 }
2703 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002704 dev_data->device_dispatch_table->CmdSetScissor(commandBuffer, scissorCount, pScissors);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002705}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002706
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002707VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002708{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002709 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002710 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2711 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002712 if (pCB) {
2713 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002714 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002715 skipCall |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002716 /* TODO: Do we still need this lock? */
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002717 loader_platform_thread_lock_mutex(&globalLock);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002718 pCB->status |= CBSTATUS_LINE_WIDTH_SET;
2719 pCB->lineWidth = lineWidth;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002720 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002721 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002722 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDynamicLineWidthState()");
Cody Northropf5bd2252015-08-17 11:10:49 -06002723 }
2724 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002725 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002726 dev_data->device_dispatch_table->CmdSetLineWidth(commandBuffer, lineWidth);
Cody Northropf5bd2252015-08-17 11:10:49 -06002727}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002728
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002729VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetDepthBias(
Chia-I Wu1f851912015-10-27 18:04:07 +08002730 VkCommandBuffer commandBuffer,
Chia-I Wufa950c52015-10-26 19:08:09 +08002731 float depthBiasConstantFactor,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002732 float depthBiasClamp,
Chia-I Wufa950c52015-10-26 19:08:09 +08002733 float depthBiasSlopeFactor)
Cody Northropf5bd2252015-08-17 11:10:49 -06002734{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002735 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002736 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2737 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Cody Northropf5bd2252015-08-17 11:10:49 -06002738 if (pCB) {
2739 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002740 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002741 skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002742 pCB->status |= CBSTATUS_DEPTH_BIAS_SET;
Chia-I Wufa950c52015-10-26 19:08:09 +08002743 pCB->depthBiasConstantFactor = depthBiasConstantFactor;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002744 pCB->depthBiasClamp = depthBiasClamp;
Chia-I Wufa950c52015-10-26 19:08:09 +08002745 pCB->depthBiasSlopeFactor = depthBiasSlopeFactor;
Cody Northropf5bd2252015-08-17 11:10:49 -06002746 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002747 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetDepthBias()");
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002748 }
2749 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002750 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002751 dev_data->device_dispatch_table->CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, depthBiasSlopeFactor);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002752}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002753
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002754VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4])
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002755{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002756 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002757 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2758 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002759 if (pCB) {
2760 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002761 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002762 skipCall |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002763 pCB->status |= CBSTATUS_BLEND_SET;
Chia-I Wu7e470702015-10-26 17:24:52 +08002764 memcpy(pCB->blendConstants, blendConstants, 4 * sizeof(float));
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002765 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002766 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetBlendConstants()");
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002767 }
2768 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002769 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002770 dev_data->device_dispatch_table->CmdSetBlendConstants(commandBuffer, blendConstants);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002771}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002772
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002773VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetDepthBounds(
Chia-I Wu1f851912015-10-27 18:04:07 +08002774 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002775 float minDepthBounds,
2776 float maxDepthBounds)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002777{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002778 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002779 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2780 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002781 if (pCB) {
2782 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002783 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002784 skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002785 pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET;
2786 pCB->minDepthBounds = minDepthBounds;
2787 pCB->maxDepthBounds = maxDepthBounds;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002788 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002789 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetDepthBounds()");
Cody Northrop2605cb02015-08-18 15:21:16 -06002790 }
2791 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002792 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002793 dev_data->device_dispatch_table->CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds);
Cody Northrop2605cb02015-08-18 15:21:16 -06002794}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002795
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002796VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetStencilCompareMask(
Chia-I Wu1f851912015-10-27 18:04:07 +08002797 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002798 VkStencilFaceFlags faceMask,
Chia-I Wuc51b1212015-10-27 19:25:11 +08002799 uint32_t compareMask)
Cody Northrop2605cb02015-08-18 15:21:16 -06002800{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002801 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002802 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2803 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Cody Northrop2605cb02015-08-18 15:21:16 -06002804 if (pCB) {
2805 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002806 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002807 skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002808 if (faceMask & VK_STENCIL_FACE_FRONT_BIT) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002809 pCB->front.compareMask = compareMask;
Cody Northrop2605cb02015-08-18 15:21:16 -06002810 }
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002811 if (faceMask & VK_STENCIL_FACE_BACK_BIT) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002812 pCB->back.compareMask = compareMask;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002813 }
2814 /* TODO: Do we need to track front and back separately? */
2815 /* TODO: We aren't capturing the faceMask, do we need to? */
2816 pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET;
Cody Northrop2605cb02015-08-18 15:21:16 -06002817 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002818 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetStencilCompareMask()");
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002819 }
2820 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002821 if (VK_FALSE == skipCall)
Chia-I Wuc51b1212015-10-27 19:25:11 +08002822 dev_data->device_dispatch_table->CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002823}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002824
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002825VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetStencilWriteMask(
Chia-I Wu1f851912015-10-27 18:04:07 +08002826 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002827 VkStencilFaceFlags faceMask,
Chia-I Wuc51b1212015-10-27 19:25:11 +08002828 uint32_t writeMask)
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002829{
2830 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002831 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2832 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002833 if (pCB) {
2834 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002835 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002836 skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002837 if (faceMask & VK_STENCIL_FACE_FRONT_BIT) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002838 pCB->front.writeMask = writeMask;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002839 }
2840 if (faceMask & VK_STENCIL_FACE_BACK_BIT) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002841 pCB->back.writeMask = writeMask;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002842 }
2843 pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET;
2844 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002845 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetStencilWriteMask()");
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002846 }
2847 }
2848 if (VK_FALSE == skipCall)
Chia-I Wuc51b1212015-10-27 19:25:11 +08002849 dev_data->device_dispatch_table->CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002850}
2851
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002852VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetStencilReference(
Chia-I Wu1f851912015-10-27 18:04:07 +08002853 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002854 VkStencilFaceFlags faceMask,
Chia-I Wuc51b1212015-10-27 19:25:11 +08002855 uint32_t reference)
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002856{
2857 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002858 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2859 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002860 if (pCB) {
2861 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002862 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002863 skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002864 if (faceMask & VK_STENCIL_FACE_FRONT_BIT) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002865 pCB->front.reference = reference;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002866 }
2867 if (faceMask & VK_STENCIL_FACE_BACK_BIT) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002868 pCB->back.reference = reference;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002869 }
2870 pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET;
2871 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002872 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetStencilReference()");
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002873 }
2874 }
2875 if (VK_FALSE == skipCall)
Chia-I Wuc51b1212015-10-27 19:25:11 +08002876 dev_data->device_dispatch_table->CmdSetStencilReference(commandBuffer, faceMask, reference);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002877}
2878
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002879VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, uint32_t firstSet, uint32_t setCount, const VkDescriptorSet* pDescriptorSets, uint32_t dynamicOffsetCount, const uint32_t* pDynamicOffsets)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002880{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002881 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002882 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2883 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002884 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06002885 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlise4076782015-06-24 15:53:07 -06002886 if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002887 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08002888 "Incorrectly binding compute DescriptorSets during active RenderPass (%#" PRIxLEAST64 ")", (uint64_t) pCB->activeRenderPass);
Tobin Ehlise4076782015-06-24 15:53:07 -06002889 } else if ((VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) && (!pCB->activeRenderPass)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002890 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS",
Tobin Ehlise4076782015-06-24 15:53:07 -06002891 "Incorrectly binding graphics DescriptorSets without an active RenderPass");
Tobin Ehlisd28acef2015-09-09 15:12:35 -06002892 } else {
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002893 // Track total count of dynamic descriptor types to make sure we have an offset for each one
2894 uint32_t totalDynamicDescriptors = 0;
Tobin Ehlis982099b2015-11-05 09:52:49 -07002895 string errorString = "";
2896 uint32_t lastSetIndex = firstSet+setCount;
2897 if (lastSetIndex >= pCB->boundDescriptorSets.size())
2898 pCB->boundDescriptorSets.resize(lastSetIndex+1);
2899 VkDescriptorSet oldFinalBoundSet = pCB->boundDescriptorSets[lastSetIndex];
Tobin Ehlise42007c2015-06-19 13:00:59 -06002900 for (uint32_t i=0; i<setCount; i++) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002901 SET_NODE* pSet = getSetNode(dev_data, pDescriptorSets[i]);
Tobin Ehlis55c1c602015-06-24 17:27:33 -06002902 if (pSet) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06002903 loader_platform_thread_lock_mutex(&globalLock);
2904 pCB->lastBoundDescriptorSet = pDescriptorSets[i];
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -06002905 pCB->lastBoundPipelineLayout = layout;
Tobin Ehlis982099b2015-11-05 09:52:49 -07002906 pCB->boundDescriptorSets[i+firstSet] = pDescriptorSets[i];
Tobin Ehlise42007c2015-06-19 13:00:59 -06002907 loader_platform_thread_unlock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08002908 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_NONE, "DS",
2909 "DS %#" PRIxLEAST64 " bound on pipeline %s", (uint64_t) pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint));
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002910 if (!pSet->pUpdateStructs) {
Chia-I Wue420a332015-10-26 20:04:44 +08002911 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_WARN_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS",
2912 "DS %#" PRIxLEAST64 " bound but it was never updated. You may want to either update it or not bind it.", (uint64_t) pDescriptorSets[i]);
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002913 }
Tobin Ehlis982099b2015-11-05 09:52:49 -07002914 // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout
2915 if (!verify_set_layout_compatibility(dev_data, pSet, layout, i+firstSet, errorString)) {
2916 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS",
2917 "descriptorSet #%u being bound is not compatible with overlapping layout in pipelineLayout due to: %s", i, errorString.c_str());
2918 }
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002919 totalDynamicDescriptors += pSet->pLayout->dynamicDescriptorCount;
Tobin Ehlise42007c2015-06-19 13:00:59 -06002920 } else {
Chia-I Wue420a332015-10-26 20:04:44 +08002921 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_INVALID_SET, "DS",
2922 "Attempt to bind DS %#" PRIxLEAST64 " that doesn't exist!", (uint64_t) pDescriptorSets[i]);
Tobin Ehlise42007c2015-06-19 13:00:59 -06002923 }
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06002924 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002925 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002926 skipCall |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS);
Tobin Ehlis982099b2015-11-05 09:52:49 -07002927 // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update
2928 if (firstSet > 0) { // Check set #s below the first bound set
2929 for (uint32_t i=0; i<firstSet; ++i) {
2930 if (!verify_set_layout_compatibility(dev_data, dev_data->setMap[pCB->boundDescriptorSets[i]], layout, i, errorString)) {
2931 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pCB->boundDescriptorSets[i], 0, DRAWSTATE_NONE, "DS",
2932 "DescriptorSetDS %#" PRIxLEAST64 " previously bound as set #%u was disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", (uint64_t) pCB->boundDescriptorSets[i], i, (uint64_t) layout);
2933 pCB->boundDescriptorSets[i] = VK_NULL_HANDLE;
2934 }
2935 }
2936 }
2937 // Check if newly last bound set invalidates any remaining bound sets
2938 if ((pCB->boundDescriptorSets.size()-1) > (lastSetIndex)) {
2939 if (!verify_set_layout_compatibility(dev_data, dev_data->setMap[oldFinalBoundSet], layout, lastSetIndex, errorString)) {
2940 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) oldFinalBoundSet, 0, DRAWSTATE_NONE, "DS",
2941 "DescriptorSetDS %#" PRIxLEAST64 " previously bound as set #%u and all subsequent sets were disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", (uint64_t) oldFinalBoundSet, lastSetIndex, (uint64_t) layout);
2942 pCB->boundDescriptorSets.resize(lastSetIndex+1);
2943 }
2944 }
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002945 // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound
2946 if (totalDynamicDescriptors != dynamicOffsetCount) {
2947 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, (uint64_t) commandBuffer, 0, DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS",
2948 "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount is %u. It should exactly match the number of dynamic descriptors.", setCount, totalDynamicDescriptors, dynamicOffsetCount);
2949 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002950 }
Tobin Ehlise42007c2015-06-19 13:00:59 -06002951 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002952 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002953 }
2954 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002955 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002956 dev_data->device_dispatch_table->CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, pDescriptorSets, dynamicOffsetCount, pDynamicOffsets);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002957}
2958
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002959VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002960{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002961 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002962 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2963 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002964 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06002965 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlis8d199e52015-09-17 12:24:13 -06002966 VkDeviceSize offset_align = 0;
2967 switch (indexType) {
2968 case VK_INDEX_TYPE_UINT16:
2969 offset_align = 2;
2970 break;
2971 case VK_INDEX_TYPE_UINT32:
2972 offset_align = 4;
2973 break;
2974 default:
2975 // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0
2976 break;
2977 }
2978 if (!offset_align || (offset % offset_align)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002979 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS",
Tobin Ehlis8d199e52015-09-17 12:24:13 -06002980 "vkCmdBindIndexBuffer() offset (%#" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", offset, string_VkIndexType(indexType));
Tobin Ehlise4076782015-06-24 15:53:07 -06002981 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002982 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002983 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindIndexBuffer()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06002984 }
Tobin Ehlis8d199e52015-09-17 12:24:13 -06002985 pCB->status |= CBSTATUS_INDEX_BUFFER_BOUND;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002986 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002987 skipCall |= addCmd(dev_data, pCB, CMD_BINDINDEXBUFFER);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002988 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002989 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002990 dev_data->device_dispatch_table->CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002991}
2992
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002993VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindVertexBuffers(
Chia-I Wu1f851912015-10-27 18:04:07 +08002994 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter46962942015-04-16 13:38:46 -06002995 uint32_t startBinding,
2996 uint32_t bindingCount,
2997 const VkBuffer* pBuffers,
Tony Barbour8205d902015-04-16 15:59:00 -06002998 const VkDeviceSize* pOffsets)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002999{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003000 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003001 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3002 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003003 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003004 if (pCB->state == CB_UPDATE_ACTIVE) {
3005 /* TODO: Need to track all the vertex buffers, not just last one */
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003006 pCB->lastVtxBinding = startBinding + bindingCount -1;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003007 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003008 addCmd(dev_data, pCB, CMD_BINDVERTEXBUFFER);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003009 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003010 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()");
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06003011 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003012 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003013 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003014 dev_data->device_dispatch_table->CmdBindVertexBuffers(commandBuffer, startBinding, bindingCount, pBuffers, pOffsets);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003015}
3016
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003017VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, uint32_t firstVertex, uint32_t firstInstance)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003018{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003019 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003020 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3021 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003022 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003023 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003024 pCB->drawCount[DRAW]++;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003025 skipCall |= validate_draw_state(dev_data, pCB, VK_FALSE);
Chia-I Wu1f851912015-10-27 18:04:07 +08003026 // TODO : Need to pass commandBuffer as srcObj here
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003027 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08003028 "vkCmdDraw() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW]++);
Chia-I Wu1f851912015-10-27 18:04:07 +08003029 skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003030 if (VK_FALSE == skipCall) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003031 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003032 skipCall |= addCmd(dev_data, pCB, CMD_DRAW);
Tobin Ehlise42007c2015-06-19 13:00:59 -06003033 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003034 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003035 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDraw()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003036 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003037 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDraw");
Jon Ashburne0fa2282015-05-20 09:00:28 -06003038 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003039 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003040 dev_data->device_dispatch_table->CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003041}
3042
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003043VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, uint32_t firstInstance)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003044{
Chia-I Wu1f851912015-10-27 18:04:07 +08003045 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3046 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003047 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003048 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003049 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003050 pCB->drawCount[DRAW_INDEXED]++;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003051 skipCall |= validate_draw_state(dev_data, pCB, VK_TRUE);
Chia-I Wu1f851912015-10-27 18:04:07 +08003052 // TODO : Need to pass commandBuffer as srcObj here
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003053 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08003054 "vkCmdDrawIndexed() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++);
Chia-I Wu1f851912015-10-27 18:04:07 +08003055 skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003056 if (VK_FALSE == skipCall) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003057 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003058 skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXED);
Tobin Ehlise42007c2015-06-19 13:00:59 -06003059 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003060 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003061 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDrawIndexed()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003062 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003063 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed");
Jon Ashburne0fa2282015-05-20 09:00:28 -06003064 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003065 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003066 dev_data->device_dispatch_table->CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, firstInstance);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003067}
3068
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003069VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003070{
Chia-I Wu1f851912015-10-27 18:04:07 +08003071 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3072 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003073 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003074 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003075 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003076 pCB->drawCount[DRAW_INDIRECT]++;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003077 skipCall |= validate_draw_state(dev_data, pCB, VK_FALSE);
Chia-I Wu1f851912015-10-27 18:04:07 +08003078 // TODO : Need to pass commandBuffer as srcObj here
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003079 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08003080 "vkCmdDrawIndirect() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++);
Chia-I Wu1f851912015-10-27 18:04:07 +08003081 skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003082 if (VK_FALSE == skipCall) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003083 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003084 skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDIRECT);
Tobin Ehlise42007c2015-06-19 13:00:59 -06003085 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003086 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003087 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDrawIndirect()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003088 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003089 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndirect");
Jon Ashburne0fa2282015-05-20 09:00:28 -06003090 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003091 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003092 dev_data->device_dispatch_table->CmdDrawIndirect(commandBuffer, buffer, offset, count, stride);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003093}
3094
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003095VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003096{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003097 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003098 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3099 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003100 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003101 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003102 pCB->drawCount[DRAW_INDEXED_INDIRECT]++;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003103 skipCall |= validate_draw_state(dev_data, pCB, VK_TRUE);
Chia-I Wu1f851912015-10-27 18:04:07 +08003104 // TODO : Need to pass commandBuffer as srcObj here
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003105 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08003106 "vkCmdDrawIndexedIndirect() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDEXED_INDIRECT]++);
Chia-I Wu1f851912015-10-27 18:04:07 +08003107 skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003108 if (VK_FALSE == skipCall) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003109 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003110 skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXEDINDIRECT);
Tobin Ehlise42007c2015-06-19 13:00:59 -06003111 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003112 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003113 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDrawIndexedIndirect()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003114 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003115 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexedIndirect");
Jon Ashburne0fa2282015-05-20 09:00:28 -06003116 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003117 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003118 dev_data->device_dispatch_table->CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003119}
3120
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003121VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003122{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003123 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003124 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3125 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003126 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003127 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003128 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003129 skipCall |= addCmd(dev_data, pCB, CMD_DISPATCH);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003130 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003131 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDispatch()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003132 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003133 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatch");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003134 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003135 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003136 dev_data->device_dispatch_table->CmdDispatch(commandBuffer, x, y, z);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003137}
3138
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003139VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003140{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003141 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003142 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3143 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003144 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003145 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003146 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003147 skipCall |= addCmd(dev_data, pCB, CMD_DISPATCHINDIRECT);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003148 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003149 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDispatchIndirect()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003150 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003151 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatchIndirect");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003152 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003153 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003154 dev_data->device_dispatch_table->CmdDispatchIndirect(commandBuffer, buffer, offset);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003155}
3156
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003157VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, uint32_t regionCount, const VkBufferCopy* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003158{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003159 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003160 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3161 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003162 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003163 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003164 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003165 skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFER);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003166 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003167 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyBuffer()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003168 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003169 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBuffer");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003170 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003171 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003172 dev_data->device_dispatch_table->CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003173}
3174
Michael Lentine27b0f902015-10-12 11:30:14 -05003175bool VerifySourceImageLayout(VkCommandBuffer cmdBuffer, VkImage srcImage, VkImageLayout srcImageLayout) {
3176 bool skip_call = false;
3177 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
3178 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
3179 auto src_image_element = pCB->imageLayoutMap.find(srcImage);
3180 if (src_image_element == pCB->imageLayoutMap.end()) {
3181 pCB->imageLayoutMap[srcImage].initialLayout = srcImageLayout;
3182 pCB->imageLayoutMap[srcImage].layout = srcImageLayout;
3183 return false;
3184 }
3185 if (src_image_element->second.layout != srcImageLayout) {
3186 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
3187 "Cannot copy from an image whose source layout is %d and doesn't match the current layout %d.", srcImageLayout, src_image_element->second.layout);
3188 }
3189 if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) {
3190 if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) {
3191 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine472af7d2015-10-16 18:08:09 -05003192 "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL.");
Michael Lentine27b0f902015-10-12 11:30:14 -05003193 } else {
3194 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine472af7d2015-10-16 18:08:09 -05003195 "Layout for input image is %d but can only be TRANSFER_SRC_OPTIMAL or GENERAL.", srcImageLayout);
Michael Lentine27b0f902015-10-12 11:30:14 -05003196 }
3197 }
3198 return skip_call;
3199}
3200
3201bool VerifyDestImageLayout(VkCommandBuffer cmdBuffer, VkImage destImage, VkImageLayout destImageLayout) {
3202 bool skip_call = false;
3203 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
3204 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
3205 auto dest_image_element = pCB->imageLayoutMap.find(destImage);
3206 if (dest_image_element == pCB->imageLayoutMap.end()) {
3207 pCB->imageLayoutMap[destImage].initialLayout = destImageLayout;
3208 pCB->imageLayoutMap[destImage].layout = destImageLayout;
3209 return false;
3210 }
3211 if (dest_image_element->second.layout != destImageLayout) {
3212 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
3213 "Cannot copy from an image whose dest layout is %d and doesn't match the current layout %d.", destImageLayout, dest_image_element->second.layout);
3214 }
3215 if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) {
3216 if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) {
3217 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
3218 "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL.");
3219 } else {
3220 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
3221 "Layout for output image is %d but can only be TRANSFER_DST_OPTIMAL or GENERAL.", destImageLayout);
3222 }
3223 }
3224 return skip_call;
3225}
3226
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003227VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyImage(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003228 VkImage srcImage,
3229 VkImageLayout srcImageLayout,
Chia-I Wu1f851912015-10-27 18:04:07 +08003230 VkImage dstImage,
3231 VkImageLayout dstImageLayout,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003232 uint32_t regionCount, const VkImageCopy* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003233{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003234 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003235 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3236 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003237 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003238 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003239 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003240 skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGE);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003241 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003242 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyImage()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003243 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003244 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImage");
Michael Lentine27b0f902015-10-12 11:30:14 -05003245 skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, srcImageLayout);
3246 skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, dstImageLayout);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003247 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003248 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003249 dev_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003250}
3251
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003252VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBlitImage(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003253 VkImage srcImage, VkImageLayout srcImageLayout,
Chia-I Wu1f851912015-10-27 18:04:07 +08003254 VkImage dstImage, VkImageLayout dstImageLayout,
Mark Lobodzinski20f68592015-05-22 14:43:25 -05003255 uint32_t regionCount, const VkImageBlit* pRegions,
Chia-I Wu3603b082015-10-26 16:49:32 +08003256 VkFilter filter)
Courtney Goeltzenleuchter6ff8ebc2015-04-03 14:42:51 -06003257{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003258 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003259 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3260 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchter6ff8ebc2015-04-03 14:42:51 -06003261 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003262 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003263 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003264 skipCall |= addCmd(dev_data, pCB, CMD_BLITIMAGE);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003265 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003266 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBlitImage()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003267 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003268 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBlitImage");
Courtney Goeltzenleuchter6ff8ebc2015-04-03 14:42:51 -06003269 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003270 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003271 dev_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, pRegions, filter);
Courtney Goeltzenleuchter6ff8ebc2015-04-03 14:42:51 -06003272}
3273
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003274VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003275 VkBuffer srcBuffer,
Chia-I Wu1f851912015-10-27 18:04:07 +08003276 VkImage dstImage, VkImageLayout dstImageLayout,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003277 uint32_t regionCount, const VkBufferImageCopy* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003278{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003279 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003280 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3281 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003282 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003283 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003284 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003285 skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFERTOIMAGE);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003286 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003287 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyBufferToImage()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003288 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003289 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBufferToImage");
Michael Lentine27b0f902015-10-12 11:30:14 -05003290 skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, dstImageLayout);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003291 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003292 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003293 dev_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003294}
3295
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003296VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003297 VkImage srcImage, VkImageLayout srcImageLayout,
Chia-I Wu1f851912015-10-27 18:04:07 +08003298 VkBuffer dstBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003299 uint32_t regionCount, const VkBufferImageCopy* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003300{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003301 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003302 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3303 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003304 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003305 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003306 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003307 skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGETOBUFFER);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003308 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003309 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyImageToBuffer()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003310 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003311 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImageToBuffer");
Michael Lentine27b0f902015-10-12 11:30:14 -05003312 skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, srcImageLayout);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003313 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003314 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003315 dev_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003316}
3317
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003318VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t* pData)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003319{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003320 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003321 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3322 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003323 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003324 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003325 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003326 skipCall |= addCmd(dev_data, pCB, CMD_UPDATEBUFFER);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003327 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003328 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdUpdateBuffer()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003329 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003330 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyUpdateBuffer");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003331 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003332 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003333 dev_data->device_dispatch_table->CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003334}
3335
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003336VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003337{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003338 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003339 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3340 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003341 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003342 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003343 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003344 skipCall |= addCmd(dev_data, pCB, CMD_FILLBUFFER);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003345 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003346 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdFillBuffer()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003347 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003348 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyFillBuffer");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003349 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003350 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003351 dev_data->device_dispatch_table->CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003352}
3353
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003354VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearAttachments(
Chia-I Wu1f851912015-10-27 18:04:07 +08003355 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003356 uint32_t attachmentCount,
3357 const VkClearAttachment* pAttachments,
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003358 uint32_t rectCount,
Courtney Goeltzenleuchtera12e2912015-10-15 18:22:08 -06003359 const VkClearRect* pRects)
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003360{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003361 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003362 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3363 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003364 if (pCB) {
3365 if (pCB->state == CB_UPDATE_ACTIVE) {
3366 // Warn if this is issued prior to Draw Cmd
3367 if (!hasDrawCmd(pCB)) {
Chia-I Wu1f851912015-10-27 18:04:07 +08003368 // TODO : commandBuffer should be srcObj
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003369 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_WARN_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS",
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003370 "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds."
Chia-I Wu1f851912015-10-27 18:04:07 +08003371 " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", reinterpret_cast<uint64_t>(commandBuffer));
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003372 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003373 updateCBTracking(pCB);
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003374 skipCall |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS);
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003375 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003376 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdClearAttachments()");
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003377 }
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003378 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments");
3379 }
3380
3381 // Validate that attachment is in reference list of active subpass
3382 if (pCB->activeRenderPass) {
Michael Lentine07ff1a12015-10-15 17:07:00 -05003383 const VkRenderPassCreateInfo *pRPCI = dev_data->renderPassMap[pCB->activeRenderPass]->createInfo;
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003384 const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass];
3385
3386 for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) {
3387 const VkClearAttachment *attachment = &pAttachments[attachment_idx];
3388 if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) {
3389 VkBool32 found = VK_FALSE;
Chia-I Wu763a7492015-10-26 20:48:51 +08003390 for (uint32_t i = 0; i < pSD->colorAttachmentCount; i++) {
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003391 if (attachment->colorAttachment == pSD->pColorAttachments[i].attachment) {
3392 found = VK_TRUE;
3393 break;
3394 }
3395 }
3396 if (VK_FALSE == found) {
3397 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER,
Chia-I Wu1f851912015-10-27 18:04:07 +08003398 (uint64_t)commandBuffer, 0, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS",
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003399 "vkCmdClearAttachments() attachment index %d not found in attachment reference array of active subpass %d",
3400 attachment->colorAttachment, pCB->activeSubpass);
3401 }
3402 } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) {
Mark Lobodzinski1523e3a2015-11-17 15:11:24 -07003403 if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass
Mark Lobodzinskiea1fff22015-11-18 08:58:31 -07003404 (pSD->pDepthStencilAttachment->attachment == VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass
Mark Lobodzinski1523e3a2015-11-17 15:11:24 -07003405
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003406 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER,
Mark Lobodzinski1523e3a2015-11-17 15:11:24 -07003407 (uint64_t)commandBuffer, 0, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS",
3408 "vkCmdClearAttachments() attachment index %d does not match depthStencilAttachment.attachment (%d) found in active subpass %d",
3409 attachment->colorAttachment,
3410 (pSD->pDepthStencilAttachment) ? pSD->pDepthStencilAttachment->attachment : VK_ATTACHMENT_UNUSED,
3411 pCB->activeSubpass);
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003412 }
3413 }
3414 }
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003415 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003416 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003417 dev_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects);
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003418}
3419
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003420VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearColorImage(
Chia-I Wu1f851912015-10-27 18:04:07 +08003421 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchterda4a99e2015-04-23 17:49:22 -06003422 VkImage image, VkImageLayout imageLayout,
Chris Forbese3105972015-06-24 14:34:53 +12003423 const VkClearColorValue *pColor,
Courtney Goeltzenleuchterda4a99e2015-04-23 17:49:22 -06003424 uint32_t rangeCount, const VkImageSubresourceRange* pRanges)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003425{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003426 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003427 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3428 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003429 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003430 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003431 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003432 skipCall |= addCmd(dev_data, pCB, CMD_CLEARCOLORIMAGE);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003433 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003434 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdClearColorImage()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003435 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003436 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearColorImage");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003437 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003438 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003439 dev_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003440}
3441
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003442VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearDepthStencilImage(
Chia-I Wu1f851912015-10-27 18:04:07 +08003443 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter315ad992015-09-15 18:03:22 -06003444 VkImage image, VkImageLayout imageLayout,
3445 const VkClearDepthStencilValue *pDepthStencil,
3446 uint32_t rangeCount,
3447 const VkImageSubresourceRange* pRanges)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003448{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003449 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003450 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3451 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003452 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003453 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003454 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003455 skipCall |= addCmd(dev_data, pCB, CMD_CLEARDEPTHSTENCILIMAGE);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003456 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003457 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdClearDepthStencilImage()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003458 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003459 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearDepthStencilImage");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003460 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003461 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003462 dev_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, pRanges);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003463}
3464
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003465VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdResolveImage(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003466 VkImage srcImage, VkImageLayout srcImageLayout,
Chia-I Wu1f851912015-10-27 18:04:07 +08003467 VkImage dstImage, VkImageLayout dstImageLayout,
Tony Barbour11f74372015-04-13 15:02:52 -06003468 uint32_t regionCount, const VkImageResolve* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003469{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003470 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003471 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3472 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003473 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003474 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003475 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003476 skipCall |= addCmd(dev_data, pCB, CMD_RESOLVEIMAGE);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003477 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003478 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResolveImage()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003479 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003480 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResolveImage");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003481 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003482 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003483 dev_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003484}
3485
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003486VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003487{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003488 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003489 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3490 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003491 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003492 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003493 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003494 skipCall |= addCmd(dev_data, pCB, CMD_SETEVENT);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003495 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003496 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetEvent()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003497 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003498 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003499 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003500 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003501 dev_data->device_dispatch_table->CmdSetEvent(commandBuffer, event, stageMask);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003502}
3503
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003504VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003505{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003506 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003507 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3508 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003509 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003510 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003511 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003512 skipCall |= addCmd(dev_data, pCB, CMD_RESETEVENT);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003513 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003514 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetEvent()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003515 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003516 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003517 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003518 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003519 dev_data->device_dispatch_table->CmdResetEvent(commandBuffer, event, stageMask);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003520}
3521
Michael Lentine27b0f902015-10-12 11:30:14 -05003522bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, const void* const* ppMemBarriers) {
3523 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
3524 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
3525 bool skip = false;
3526 for (uint32_t i = 0; i < memBarrierCount; ++i) {
3527 auto mem_barrier = reinterpret_cast<const VkMemoryBarrier*>(ppMemBarriers[i]);
3528 if (mem_barrier && mem_barrier->sType == VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER) {
3529 auto image_mem_barrier = reinterpret_cast<const VkImageMemoryBarrier*>(mem_barrier);
3530 auto image_data = pCB->imageLayoutMap.find(image_mem_barrier->image);
3531 if (image_data == pCB->imageLayoutMap.end()) {
3532 pCB->imageLayoutMap[image_mem_barrier->image].initialLayout = image_mem_barrier->oldLayout;
3533 pCB->imageLayoutMap[image_mem_barrier->image].layout = image_mem_barrier->newLayout;
3534 } else {
3535 if (image_data->second.layout != image_mem_barrier->oldLayout) {
3536 skip |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
3537 "You cannot transition the layout from %d when current layout is %d.", image_mem_barrier->oldLayout, image_data->second.layout);
3538 }
3539 image_data->second.layout = image_mem_barrier->newLayout;
3540 }
3541 }
3542 }
3543 return skip;
3544}
3545
Michael Lentine472af7d2015-10-16 18:08:09 -05003546bool ValidateOutputMaskBits(const layer_data* my_data, VkCommandBuffer cmdBuffer, const VkImageMemoryBarrier* image_mem_barrier, VkAccessFlags bit) {
3547 bool skip_call = false;
Mark Lobodzinski5f6ba8e2015-11-04 13:51:23 -07003548 if (image_mem_barrier->srcAccessMask & bit) {
Michael Lentine472af7d2015-10-16 18:08:09 -05003549 if (image_mem_barrier->srcAccessMask != bit) {
3550 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
3551 "Additional bits in srcAccessMask %d are specified when source layout is %d.", image_mem_barrier->srcAccessMask, image_mem_barrier->oldLayout);
3552 }
3553 } else {
3554 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
3555 "Cannot specify srcAccessMask %d without %d when source layout is %d.", image_mem_barrier->srcAccessMask, bit, image_mem_barrier->oldLayout);
3556 }
3557 return skip_call;
3558}
3559
3560//TODO: Combine this with function below
3561bool ValidateInputMaskBits(const layer_data* my_data, VkCommandBuffer cmdBuffer, const VkImageMemoryBarrier* image_mem_barrier, VkAccessFlags bit) {
3562 bool skip_call = false;
Mark Lobodzinski5f6ba8e2015-11-04 13:51:23 -07003563 if (image_mem_barrier->dstAccessMask & bit) {
Michael Lentine472af7d2015-10-16 18:08:09 -05003564 if (image_mem_barrier->dstAccessMask != bit) {
3565 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
Mark Lobodzinski0ef8ca12015-11-19 10:40:58 -07003566 "Additional bits in dstAccessMask %d are specified when dest layout is %d.", image_mem_barrier->dstAccessMask, image_mem_barrier->newLayout);
Michael Lentine472af7d2015-10-16 18:08:09 -05003567 }
3568 } else {
3569 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
Mark Lobodzinski0ef8ca12015-11-19 10:40:58 -07003570 "Cannot specify dstAccessMask %d without %d when dest layout is %d.", image_mem_barrier->dstAccessMask, bit, image_mem_barrier->newLayout);
Michael Lentine472af7d2015-10-16 18:08:09 -05003571 }
3572 return skip_call;
3573}
3574
3575bool ValidateInputMaskBits(const layer_data* my_data, VkCommandBuffer cmdBuffer, const VkImageMemoryBarrier* image_mem_barrier, VkAccessFlags bit1, VkAccessFlags bit2) {
3576 bool skip_call = false;
Mark Lobodzinski5f6ba8e2015-11-04 13:51:23 -07003577 if (image_mem_barrier->dstAccessMask & bit1 || image_mem_barrier->dstAccessMask & bit2) {
Michael Lentine472af7d2015-10-16 18:08:09 -05003578 if (image_mem_barrier->dstAccessMask & !(bit1 | bit2)) {
3579 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
Mark Lobodzinski0ef8ca12015-11-19 10:40:58 -07003580 "Additional bits in dstAccessMask %d are specified when dest layout is %d.", image_mem_barrier->dstAccessMask, image_mem_barrier->newLayout);
Michael Lentine472af7d2015-10-16 18:08:09 -05003581 }
3582 } else {
3583 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
Mark Lobodzinski0ef8ca12015-11-19 10:40:58 -07003584 "Cannot specify dstAccessMask %d without %d or %d when dest layout is %d.", image_mem_barrier->dstAccessMask, bit1, bit2, image_mem_barrier->newLayout);
Michael Lentine472af7d2015-10-16 18:08:09 -05003585 }
3586 return skip_call;
3587}
3588
Michael Lentine07ff1a12015-10-15 17:07:00 -05003589bool ValidateBarriers(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, const void* const* ppMemBarriers) {
3590 bool skip_call = false;
3591 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
3592 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
3593 if (pCB->activeRenderPass && memBarrierCount) {
3594 for (uint32_t i = 0; i < memBarrierCount; ++i) {
3595 auto mem_barrier = reinterpret_cast<const VkMemoryBarrier*>(ppMemBarriers[i]);
3596 if (mem_barrier && mem_barrier->sType != VK_STRUCTURE_TYPE_MEMORY_BARRIER) {
3597 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
3598 "Image or Buffers Barriers cannot be used during a render pass.");
3599 }
3600 }
3601 if (!dev_data->renderPassMap[pCB->activeRenderPass]->hasSelfDependency[pCB->activeSubpass]) {
3602 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
3603 "Barriers cannot be set during subpass %d with no self dependency specified.", pCB->activeSubpass);
3604 }
3605 }
Michael Lentine472af7d2015-10-16 18:08:09 -05003606 for (uint32_t i = 0; i < memBarrierCount; ++i) {
3607 auto mem_barrier = reinterpret_cast<const VkMemoryBarrier*>(ppMemBarriers[i]);
3608 if (mem_barrier && mem_barrier->sType == VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER) {
3609 auto image_mem_barrier = reinterpret_cast<const VkImageMemoryBarrier*>(mem_barrier);
3610 switch (image_mem_barrier->oldLayout) {
3611 case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: {
3612 ValidateOutputMaskBits(dev_data, cmdBuffer, image_mem_barrier, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT);
3613 break;
3614 }
3615 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: {
3616 ValidateOutputMaskBits(dev_data, cmdBuffer, image_mem_barrier, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT);
3617 break;
3618 }
3619 case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: {
3620 ValidateOutputMaskBits(dev_data, cmdBuffer, image_mem_barrier, VK_ACCESS_TRANSFER_WRITE_BIT);
3621 break;
3622 }
3623 case VK_IMAGE_LAYOUT_PREINITIALIZED: {
3624 ValidateOutputMaskBits(dev_data, cmdBuffer, image_mem_barrier, VK_ACCESS_HOST_WRITE_BIT);
3625 break;
3626 }
3627 case VK_IMAGE_LAYOUT_UNDEFINED:
3628 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL:
3629 case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL:
3630 case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: {
3631 if (image_mem_barrier->srcAccessMask != 0) {
3632 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
3633 "Additional bits in srcAccessMask %d are specified when source layout is %d.", image_mem_barrier->srcAccessMask, image_mem_barrier->oldLayout);
3634 }
3635 break;
3636 }
3637 case VK_IMAGE_LAYOUT_GENERAL:
3638 default: {
3639 break;
3640 }
3641 }
3642 switch (image_mem_barrier->newLayout) {
3643 case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: {
3644 ValidateInputMaskBits(dev_data, cmdBuffer, image_mem_barrier, VK_ACCESS_COLOR_ATTACHMENT_READ_BIT);
3645 break;
3646 }
3647 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: {
3648 ValidateInputMaskBits(dev_data, cmdBuffer, image_mem_barrier, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT);
3649 break;
3650 }
3651 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: {
3652 ValidateInputMaskBits(dev_data, cmdBuffer, image_mem_barrier, VK_ACCESS_SHADER_READ_BIT, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT);
3653 break;
3654 }
3655 case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: {
3656 ValidateInputMaskBits(dev_data, cmdBuffer, image_mem_barrier, VK_ACCESS_SHADER_READ_BIT, VK_ACCESS_INPUT_ATTACHMENT_READ_BIT);
3657 break;
3658 }
3659 case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: {
Mark Lobodzinski0ef8ca12015-11-19 10:40:58 -07003660 ValidateInputMaskBits(dev_data, cmdBuffer, image_mem_barrier, VK_ACCESS_TRANSFER_READ_BIT);
Michael Lentine472af7d2015-10-16 18:08:09 -05003661 break;
3662 }
3663 case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: {
3664 if (image_mem_barrier->srcAccessMask != 0) {
3665 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
3666 "Additional bits in dstAccessMask %d are specified when dest layout is %d.", image_mem_barrier->dstAccessMask, image_mem_barrier->newLayout);
3667 }
3668 break;
3669 }
3670 case VK_IMAGE_LAYOUT_PREINITIALIZED:
3671 case VK_IMAGE_LAYOUT_UNDEFINED:
3672 case VK_IMAGE_LAYOUT_GENERAL:
3673 default: {
3674 break;
3675 }
3676 }
3677 }
3678 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05003679 return skip_call;
3680}
3681
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003682VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent* pEvents, VkPipelineStageFlags sourceStageMask, VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const void* const* ppMemoryBarriers)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003683{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003684 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003685 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3686 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003687 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003688 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003689 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003690 skipCall |= addCmd(dev_data, pCB, CMD_WAITEVENTS);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003691 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003692 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003693 }
Michael Lentine27b0f902015-10-12 11:30:14 -05003694 skipCall |= TransitionImageLayouts(commandBuffer, memoryBarrierCount, ppMemoryBarriers);
Michael Lentine07ff1a12015-10-15 17:07:00 -05003695 skipCall |= ValidateBarriers(commandBuffer, memoryBarrierCount, ppMemoryBarriers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003696 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003697 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003698 dev_data->device_dispatch_table->CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, memoryBarrierCount, ppMemoryBarriers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003699}
3700
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003701VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const void* const* ppMemoryBarriers)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003702{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003703 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003704 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3705 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003706 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003707 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003708 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003709 skipCall |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003710 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003711 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPipelineBarrier()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003712 }
Michael Lentine27b0f902015-10-12 11:30:14 -05003713 skipCall |= TransitionImageLayouts(commandBuffer, memoryBarrierCount, ppMemoryBarriers);
Michael Lentine07ff1a12015-10-15 17:07:00 -05003714 skipCall |= ValidateBarriers(commandBuffer, memoryBarrierCount, ppMemoryBarriers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003715 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003716 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003717 dev_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, memoryBarrierCount, ppMemoryBarriers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003718}
3719
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003720VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003721{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003722 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003723 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3724 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003725 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003726 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003727 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003728 skipCall |= addCmd(dev_data, pCB, CMD_BEGINQUERY);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003729 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003730 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBeginQuery()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003731 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003732 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003733 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003734 dev_data->device_dispatch_table->CmdBeginQuery(commandBuffer, queryPool, slot, flags);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003735}
3736
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003737VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003738{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003739 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003740 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3741 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003742 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003743 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003744 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003745 skipCall |= addCmd(dev_data, pCB, CMD_ENDQUERY);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003746 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003747 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003748 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003749 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003750 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003751 dev_data->device_dispatch_table->CmdEndQuery(commandBuffer, queryPool, slot);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003752}
3753
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003754VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t startQuery, uint32_t queryCount)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003755{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003756 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003757 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3758 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003759 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003760 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003761 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003762 skipCall |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003763 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003764 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003765 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003766 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003767 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003768 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003769 dev_data->device_dispatch_table->CmdResetQueryPool(commandBuffer, queryPool, startQuery, queryCount);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003770}
3771
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003772VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t startQuery,
Chia-I Wu1f851912015-10-27 18:04:07 +08003773 uint32_t queryCount, VkBuffer dstBuffer, VkDeviceSize dstOffset,
Chia-I Wu1f6942d2015-10-26 18:36:20 +08003774 VkDeviceSize stride, VkQueryResultFlags flags)
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003775{
3776 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003777 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3778 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003779 if (pCB) {
3780 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003781 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003782 skipCall |= addCmd(dev_data, pCB, CMD_COPYQUERYPOOLRESULTS);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003783 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003784 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()");
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003785 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003786 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyQueryPoolResults");
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003787 }
3788 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003789 dev_data->device_dispatch_table->CmdCopyQueryPoolResults(commandBuffer, queryPool,
3790 startQuery, queryCount, dstBuffer, dstOffset, stride, flags);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003791}
3792
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003793VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003794{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003795 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003796 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3797 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003798 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003799 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003800 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003801 skipCall |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003802 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003803 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003804 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003805 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003806 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003807 dev_data->device_dispatch_table->CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003808}
3809
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003810VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkFramebuffer* pFramebuffer)
Tobin Ehlis2464b882015-04-01 08:40:34 -06003811{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003812 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08003813 VkResult result = dev_data->device_dispatch_table->CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06003814 if (VK_SUCCESS == result) {
Tobin Ehlis2464b882015-04-01 08:40:34 -06003815 // Shadow create info and store in map
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003816 VkFramebufferCreateInfo* localFBCI = new VkFramebufferCreateInfo(*pCreateInfo);
Chia-I Wuc278df82015-07-07 11:50:03 +08003817 if (pCreateInfo->pAttachments) {
Courtney Goeltzenleuchter1856d6f2015-09-01 17:30:39 -06003818 localFBCI->pAttachments = new VkImageView[localFBCI->attachmentCount];
3819 memcpy((void*)localFBCI->pAttachments, pCreateInfo->pAttachments, localFBCI->attachmentCount*sizeof(VkImageView));
Tobin Ehlis2464b882015-04-01 08:40:34 -06003820 }
Chia-I Wue420a332015-10-26 20:04:44 +08003821 dev_data->frameBufferMap[*pFramebuffer] = localFBCI;
Tobin Ehlis2464b882015-04-01 08:40:34 -06003822 }
3823 return result;
3824}
3825
Michael Lentine329697b2015-10-06 14:56:18 -07003826// Store the DAG.
3827struct DAGNode {
3828 uint32_t pass;
3829 std::vector<uint32_t> prev;
3830 std::vector<uint32_t> next;
3831};
3832
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003833VkBool32 FindDependency(const int index, const int dependent, const std::vector<DAGNode>& subpass_to_node, std::unordered_set<uint32_t>& processed_nodes) {
Michael Lentine329697b2015-10-06 14:56:18 -07003834 // If we have already checked this node we have not found a dependency path so return false.
3835 if (processed_nodes.count(index))
3836 return false;
3837 processed_nodes.insert(index);
3838 const DAGNode& node = subpass_to_node[index];
3839 // Look for a dependency path. If one exists return true else recurse on the previous nodes.
3840 if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) {
3841 for (auto elem : node.prev) {
3842 if (FindDependency(elem, dependent, subpass_to_node, processed_nodes))
3843 return true;
3844 }
3845 } else {
3846 return true;
3847 }
3848 return false;
3849}
3850
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003851VkBool32 CheckDependencyExists(const layer_data* my_data, VkDevice device, const int subpass, const std::vector<uint32_t>& dependent_subpasses, const std::vector<DAGNode>& subpass_to_node, VkBool32& skip_call) {
3852 VkBool32 result = true;
Michael Lentine329697b2015-10-06 14:56:18 -07003853 // Loop through all subpasses that share the same attachment and make sure a dependency exists
3854 for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) {
3855 if (subpass == dependent_subpasses[k])
3856 continue;
3857 const DAGNode& node = subpass_to_node[subpass];
3858 // Check for a specified dependency between the two nodes. If one exists we are done.
3859 auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]);
3860 auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]);
3861 if (prev_elem == node.prev.end() && next_elem == node.next.end()) {
3862 // If no dependency exits an implicit dependency still might. If so, warn and if not throw an error.
3863 std::unordered_set<uint32_t> processed_nodes;
3864 if (FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) ||
3865 FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003866 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine329697b2015-10-06 14:56:18 -07003867 "A dependency between subpasses %d and %d must exist but only an implicit one is specified.",
3868 subpass, dependent_subpasses[k]);
3869 } else {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003870 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine329697b2015-10-06 14:56:18 -07003871 "A dependency between subpasses %d and %d must exist but one is not specified.",
3872 subpass, dependent_subpasses[k]);
3873 result = false;
3874 }
3875 }
3876 }
3877 return result;
3878}
3879
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003880VkBool32 CheckPreserved(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, const int index, const int attachment, const std::vector<DAGNode>& subpass_to_node, int depth, VkBool32& skip_call) {
Michael Lentine329697b2015-10-06 14:56:18 -07003881 const DAGNode& node = subpass_to_node[index];
3882 // If this node writes to the attachment return true as next nodes need to preserve the attachment.
3883 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[index];
Chia-I Wu763a7492015-10-26 20:48:51 +08003884 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07003885 if (attachment == subpass.pColorAttachments[j].attachment)
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003886 return VK_TRUE;
Michael Lentine329697b2015-10-06 14:56:18 -07003887 }
Chia-I Wuce532f72015-10-26 17:32:47 +08003888 if (subpass.pDepthStencilAttachment &&
3889 subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) {
3890 if (attachment == subpass.pDepthStencilAttachment->attachment)
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003891 return VK_TRUE;
Michael Lentine329697b2015-10-06 14:56:18 -07003892 }
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003893 VkBool32 result = VK_FALSE;
Michael Lentine329697b2015-10-06 14:56:18 -07003894 // Loop through previous nodes and see if any of them write to the attachment.
3895 for (auto elem : node.prev) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003896 result |= CheckPreserved(my_data, device, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07003897 }
3898 // If the attachment was written to by a previous node than this node needs to preserve it.
3899 if (result && depth > 0) {
3900 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[index];
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003901 VkBool32 has_preserved = false;
Chia-I Wu763a7492015-10-26 20:48:51 +08003902 for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07003903 if (subpass.pPreserveAttachments[j].attachment == attachment) {
3904 has_preserved = true;
3905 break;
3906 }
3907 }
3908 if (!has_preserved) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003909 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine329697b2015-10-06 14:56:18 -07003910 "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index);
3911 }
3912 }
3913 return result;
3914}
3915
Michael Lentine27b0f902015-10-12 11:30:14 -05003916VkBool32 ValidateDependencies(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, std::vector<DAGNode>& subpass_to_node) {
3917 VkBool32 skip_call = false;
Michael Lentine329697b2015-10-06 14:56:18 -07003918 std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount);
3919 std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount);
Michael Lentine27b0f902015-10-12 11:30:14 -05003920
Michael Lentine329697b2015-10-06 14:56:18 -07003921 // Create DAG
3922 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
3923 DAGNode& subpass_node = subpass_to_node[i];
3924 subpass_node.pass = i;
3925 }
3926 for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) {
3927 const VkSubpassDependency& dependency = pCreateInfo->pDependencies[i];
Chia-I Wu1f851912015-10-27 18:04:07 +08003928 if (dependency.srcSubpass > dependency.dstSubpass) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003929 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine329697b2015-10-06 14:56:18 -07003930 "Dependency graph must be specified such that an earlier pass cannot depend on a later pass.");
3931 }
Chia-I Wu1f851912015-10-27 18:04:07 +08003932 subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass);
3933 subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass);
Michael Lentine329697b2015-10-06 14:56:18 -07003934 }
Michael Lentine27b0f902015-10-12 11:30:14 -05003935
Michael Lentine329697b2015-10-06 14:56:18 -07003936 // Find for each attachment the subpasses that use them.
3937 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
3938 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i];
Chia-I Wu763a7492015-10-26 20:48:51 +08003939 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07003940 input_attachment_to_subpass[subpass.pInputAttachments[j].attachment].push_back(i);
3941 }
Chia-I Wu763a7492015-10-26 20:48:51 +08003942 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07003943 output_attachment_to_subpass[subpass.pColorAttachments[j].attachment].push_back(i);
3944 }
Chia-I Wuce532f72015-10-26 17:32:47 +08003945 if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) {
3946 output_attachment_to_subpass[subpass.pDepthStencilAttachment->attachment].push_back(i);
Michael Lentine329697b2015-10-06 14:56:18 -07003947 }
3948 }
3949 // If there is a dependency needed make sure one exists
3950 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
3951 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i];
3952 // If the attachment is an input then all subpasses that output must have a dependency relationship
Chia-I Wu763a7492015-10-26 20:48:51 +08003953 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07003954 const uint32_t& attachment = subpass.pInputAttachments[j].attachment;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003955 CheckDependencyExists(my_data, device, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07003956 }
3957 // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship
Chia-I Wu763a7492015-10-26 20:48:51 +08003958 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07003959 const uint32_t& attachment = subpass.pColorAttachments[j].attachment;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003960 CheckDependencyExists(my_data, device, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call);
3961 CheckDependencyExists(my_data, device, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07003962 }
Chia-I Wuce532f72015-10-26 17:32:47 +08003963 if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) {
3964 const uint32_t& attachment = subpass.pDepthStencilAttachment->attachment;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003965 CheckDependencyExists(my_data, device, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call);
3966 CheckDependencyExists(my_data, device, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07003967 }
3968 }
3969 // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was written.
3970 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
3971 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i];
Chia-I Wu763a7492015-10-26 20:48:51 +08003972 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003973 CheckPreserved(my_data, device, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07003974 }
3975 }
3976 return skip_call;
3977}
3978
Michael Lentine27b0f902015-10-12 11:30:14 -05003979bool ValidateLayouts(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo) {
3980 bool skip = false;
3981 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
3982 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i];
3983 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
3984 if (subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL &&
3985 subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) {
3986 if (subpass.pInputAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) {
3987 skip |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
3988 "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL.");
3989 } else {
3990 skip |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
3991 "Layout for input attachment is %d but can only be READ_ONLY_OPTIMAL or GENERAL.", subpass.pInputAttachments[j].attachment);
3992 }
3993 }
3994 }
3995 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
3996 if (subpass.pColorAttachments[j].layout != VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL) {
3997 if (subpass.pColorAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) {
3998 skip |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
3999 "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL.");
4000 } else {
4001 skip |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4002 "Layout for color attachment is %d but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", subpass.pColorAttachments[j].attachment);
4003 }
4004 }
4005 }
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06004006 if ((subpass.pDepthStencilAttachment != NULL) &&
4007 (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) {
Michael Lentine27b0f902015-10-12 11:30:14 -05004008 if (subpass.pDepthStencilAttachment->layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL) {
4009 if (subpass.pDepthStencilAttachment->layout == VK_IMAGE_LAYOUT_GENERAL) {
4010 skip |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4011 "Layout for depth attachment is GENERAL but should be DEPTH_STENCIL_ATTACHMENT_OPTIMAL.");
4012 } else {
4013 skip |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4014 "Layout for depth attachment is %d but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL or GENERAL.", subpass.pDepthStencilAttachment->attachment);
4015 }
4016 }
4017 }
4018 }
4019 return skip;
4020}
4021
Michael Lentine07ff1a12015-10-15 17:07:00 -05004022bool CreatePassDAG(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, std::vector<DAGNode>& subpass_to_node, std::vector<bool>& has_self_dependency) {
Michael Lentine27b0f902015-10-12 11:30:14 -05004023 bool skip_call = false;
4024 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
4025 DAGNode& subpass_node = subpass_to_node[i];
4026 subpass_node.pass = i;
4027 }
4028 for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) {
4029 const VkSubpassDependency& dependency = pCreateInfo->pDependencies[i];
4030 if (dependency.srcSubpass > dependency.dstSubpass) {
4031 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
4032 "Depedency graph must be specified such that an earlier pass cannot depend on a later pass.");
Michael Lentine07ff1a12015-10-15 17:07:00 -05004033 } else if (dependency.srcSubpass == dependency.dstSubpass) {
4034 has_self_dependency[dependency.srcSubpass] = true;
Michael Lentine27b0f902015-10-12 11:30:14 -05004035 }
4036 subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass);
4037 subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass);
4038 }
4039 return skip_call;
4040}
4041
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004042VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkRenderPass* pRenderPass)
Tobin Ehlis2464b882015-04-01 08:40:34 -06004043{
Michael Lentine27b0f902015-10-12 11:30:14 -05004044 bool skip_call = false;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004045 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Michael Lentine27b0f902015-10-12 11:30:14 -05004046 // Create DAG
Michael Lentine07ff1a12015-10-15 17:07:00 -05004047 std::vector<bool> has_self_dependency(pCreateInfo->subpassCount);
Michael Lentine27b0f902015-10-12 11:30:14 -05004048 std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount);
Michael Lentine07ff1a12015-10-15 17:07:00 -05004049 skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency);
Michael Lentine27b0f902015-10-12 11:30:14 -05004050 // Validate using DAG
4051 skip_call |= ValidateDependencies(dev_data, device, pCreateInfo, subpass_to_node);
4052 skip_call |= ValidateLayouts(dev_data, device, pCreateInfo);
4053 if (skip_call) {
Michael Lentine329697b2015-10-06 14:56:18 -07004054 return VK_ERROR_VALIDATION_FAILED;
4055 }
Chia-I Wu69f40122015-10-26 21:10:41 +08004056 VkResult result = dev_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004057 if (VK_SUCCESS == result) {
Tobin Ehlis2464b882015-04-01 08:40:34 -06004058 // Shadow create info and store in map
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06004059 VkRenderPassCreateInfo* localRPCI = new VkRenderPassCreateInfo(*pCreateInfo);
Chia-I Wuc278df82015-07-07 11:50:03 +08004060 if (pCreateInfo->pAttachments) {
4061 localRPCI->pAttachments = new VkAttachmentDescription[localRPCI->attachmentCount];
4062 memcpy((void*)localRPCI->pAttachments, pCreateInfo->pAttachments, localRPCI->attachmentCount*sizeof(VkAttachmentDescription));
Tobin Ehlis2464b882015-04-01 08:40:34 -06004063 }
Chia-I Wuc278df82015-07-07 11:50:03 +08004064 if (pCreateInfo->pSubpasses) {
4065 localRPCI->pSubpasses = new VkSubpassDescription[localRPCI->subpassCount];
4066 memcpy((void*)localRPCI->pSubpasses, pCreateInfo->pSubpasses, localRPCI->subpassCount*sizeof(VkSubpassDescription));
4067
4068 for (uint32_t i = 0; i < localRPCI->subpassCount; i++) {
4069 VkSubpassDescription *subpass = (VkSubpassDescription *) &localRPCI->pSubpasses[i];
Chia-I Wu763a7492015-10-26 20:48:51 +08004070 const uint32_t attachmentCount = subpass->inputAttachmentCount +
4071 subpass->colorAttachmentCount * (1 + (subpass->pResolveAttachments?1:0)) +
Chia-I Wuce532f72015-10-26 17:32:47 +08004072 ((subpass->pDepthStencilAttachment) ? 1 : 0) + subpass->preserveAttachmentCount;
Chia-I Wuc278df82015-07-07 11:50:03 +08004073 VkAttachmentReference *attachments = new VkAttachmentReference[attachmentCount];
4074
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004075 memcpy(attachments, subpass->pInputAttachments,
Chia-I Wu763a7492015-10-26 20:48:51 +08004076 sizeof(attachments[0]) * subpass->inputAttachmentCount);
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004077 subpass->pInputAttachments = attachments;
Chia-I Wu763a7492015-10-26 20:48:51 +08004078 attachments += subpass->inputAttachmentCount;
Chia-I Wuc278df82015-07-07 11:50:03 +08004079
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004080 memcpy(attachments, subpass->pColorAttachments,
Chia-I Wu763a7492015-10-26 20:48:51 +08004081 sizeof(attachments[0]) * subpass->colorAttachmentCount);
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004082 subpass->pColorAttachments = attachments;
Chia-I Wu763a7492015-10-26 20:48:51 +08004083 attachments += subpass->colorAttachmentCount;
Chia-I Wuc278df82015-07-07 11:50:03 +08004084
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004085 if (subpass->pResolveAttachments) {
4086 memcpy(attachments, subpass->pResolveAttachments,
Chia-I Wu763a7492015-10-26 20:48:51 +08004087 sizeof(attachments[0]) * subpass->colorAttachmentCount);
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004088 subpass->pResolveAttachments = attachments;
Chia-I Wu763a7492015-10-26 20:48:51 +08004089 attachments += subpass->colorAttachmentCount;
Chia-I Wuc278df82015-07-07 11:50:03 +08004090 }
4091
Chia-I Wuce532f72015-10-26 17:32:47 +08004092 if (subpass->pDepthStencilAttachment) {
4093 memcpy(attachments, subpass->pDepthStencilAttachment,
4094 sizeof(attachments[0]) * 1);
4095 subpass->pDepthStencilAttachment = attachments;
4096 attachments += 1;
4097 }
4098
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004099 memcpy(attachments, subpass->pPreserveAttachments,
Chia-I Wu763a7492015-10-26 20:48:51 +08004100 sizeof(attachments[0]) * subpass->preserveAttachmentCount);
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004101 subpass->pPreserveAttachments = attachments;
Chia-I Wuc278df82015-07-07 11:50:03 +08004102 }
Tobin Ehlis2464b882015-04-01 08:40:34 -06004103 }
Chia-I Wuc278df82015-07-07 11:50:03 +08004104 if (pCreateInfo->pDependencies) {
4105 localRPCI->pDependencies = new VkSubpassDependency[localRPCI->dependencyCount];
4106 memcpy((void*)localRPCI->pDependencies, pCreateInfo->pDependencies, localRPCI->dependencyCount*sizeof(VkSubpassDependency));
Tobin Ehlis2464b882015-04-01 08:40:34 -06004107 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004108 dev_data->renderPassMap[*pRenderPass] = new RENDER_PASS_NODE();
4109 dev_data->renderPassMap[*pRenderPass]->hasSelfDependency = has_self_dependency;
4110 dev_data->renderPassMap[*pRenderPass]->createInfo = localRPCI;
Tobin Ehlis2464b882015-04-01 08:40:34 -06004111 }
4112 return result;
4113}
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004114// Free the renderpass shadow
4115static void deleteRenderPasses(layer_data* my_data)
4116{
4117 if (my_data->renderPassMap.size() <= 0)
4118 return;
4119 for (auto ii=my_data->renderPassMap.begin(); ii!=my_data->renderPassMap.end(); ++ii) {
Michael Lentine07ff1a12015-10-15 17:07:00 -05004120 const VkRenderPassCreateInfo* pRenderPassInfo = (*ii).second->createInfo;
4121 if (pRenderPassInfo->pAttachments) {
4122 delete[] pRenderPassInfo->pAttachments;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004123 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004124 if (pRenderPassInfo->pSubpasses) {
4125 for (uint32_t i=0; i<pRenderPassInfo->subpassCount; ++i) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004126 // Attachements are all allocated in a block, so just need to
4127 // find the first non-null one to delete
Michael Lentine07ff1a12015-10-15 17:07:00 -05004128 if (pRenderPassInfo->pSubpasses[i].pInputAttachments) {
4129 delete[] pRenderPassInfo->pSubpasses[i].pInputAttachments;
4130 } else if (pRenderPassInfo->pSubpasses[i].pColorAttachments) {
4131 delete[] pRenderPassInfo->pSubpasses[i].pColorAttachments;
4132 } else if (pRenderPassInfo->pSubpasses[i].pResolveAttachments) {
4133 delete[] pRenderPassInfo->pSubpasses[i].pResolveAttachments;
4134 } else if (pRenderPassInfo->pSubpasses[i].pPreserveAttachments) {
4135 delete[] pRenderPassInfo->pSubpasses[i].pPreserveAttachments;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004136 }
4137 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004138 delete[] pRenderPassInfo->pSubpasses;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004139 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004140 if (pRenderPassInfo->pDependencies) {
4141 delete[] pRenderPassInfo->pDependencies;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004142 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004143 delete (*ii).second;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004144 }
4145 my_data->renderPassMap.clear();
4146}
Michael Lentine27b0f902015-10-12 11:30:14 -05004147
4148bool VerifyFramebufferAndRenderPassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo* pRenderPassBegin) {
4149 bool skip_call = false;
4150 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
4151 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
Michael Lentine07ff1a12015-10-15 17:07:00 -05004152 const VkRenderPassCreateInfo* pRenderPassInfo = dev_data->renderPassMap[pRenderPassBegin->renderPass]->createInfo;
Michael Lentine27b0f902015-10-12 11:30:14 -05004153 const VkFramebufferCreateInfo* pFramebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer];
4154 if (pRenderPassInfo->attachmentCount != pFramebufferInfo->attachmentCount) {
4155 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
4156 "You cannot start a render pass using a framebuffer with a different number of attachments.");
4157 }
4158 for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) {
4159 const VkImageView& image_view = pFramebufferInfo->pAttachments[i];
4160 const VkImage& image = dev_data->imageViewMap[image_view]->image;
4161 auto image_data = pCB->imageLayoutMap.find(image);
4162 if (image_data == pCB->imageLayoutMap.end()) {
4163 pCB->imageLayoutMap[image].initialLayout = pRenderPassInfo->pAttachments[i].initialLayout;
4164 pCB->imageLayoutMap[image].layout = pRenderPassInfo->pAttachments[i].initialLayout;
4165 } else if (pRenderPassInfo->pAttachments[i].initialLayout != image_data->second.layout) {
4166 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
4167 "You cannot start a render pass using attachment %i where the intial layout differs from the starting layout.", i);
4168 }
4169 }
4170 return skip_call;
4171}
4172
4173void TransitionSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo* pRenderPassBegin, const int subpass_index) {
4174 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
4175 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
4176 auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass);
4177 if (render_pass_data == dev_data->renderPassMap.end()) {
4178 return;
4179 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004180 const VkRenderPassCreateInfo* pRenderPassInfo = render_pass_data->second->createInfo;
Michael Lentine27b0f902015-10-12 11:30:14 -05004181 auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer);
4182 if (framebuffer_data == dev_data->frameBufferMap.end()) {
4183 return;
4184 }
4185 const VkFramebufferCreateInfo* pFramebufferInfo = framebuffer_data->second;
4186 const VkSubpassDescription& subpass = pRenderPassInfo->pSubpasses[subpass_index];
4187 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
4188 const VkImageView& image_view = pFramebufferInfo->pAttachments[subpass.pInputAttachments[j].attachment];
4189 auto image_view_data = dev_data->imageViewMap.find(image_view);
4190 if (image_view_data != dev_data->imageViewMap.end()) {
4191 auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image);
4192 if (image_layout != pCB->imageLayoutMap.end()) {
4193 image_layout->second.layout = subpass.pInputAttachments[j].layout;
4194 }
4195 }
4196 }
4197 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
4198 const VkImageView& image_view = pFramebufferInfo->pAttachments[subpass.pColorAttachments[j].attachment];
4199 auto image_view_data = dev_data->imageViewMap.find(image_view);
4200 if (image_view_data != dev_data->imageViewMap.end()) {
4201 auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image);
4202 if (image_layout != pCB->imageLayoutMap.end()) {
4203 image_layout->second.layout = subpass.pColorAttachments[j].layout;
4204 }
4205 }
4206 }
Michael Lentine2b9eda42015-10-28 15:55:18 -07004207 if ((subpass.pDepthStencilAttachment != NULL) &&
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06004208 (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) {
Michael Lentine27b0f902015-10-12 11:30:14 -05004209 const VkImageView& image_view = pFramebufferInfo->pAttachments[subpass.pDepthStencilAttachment->attachment];
4210 auto image_view_data = dev_data->imageViewMap.find(image_view);
4211 if (image_view_data != dev_data->imageViewMap.end()) {
4212 auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image);
4213 if (image_layout != pCB->imageLayoutMap.end()) {
4214 image_layout->second.layout = subpass.pDepthStencilAttachment->layout;
4215 }
4216 }
4217 }
4218}
4219
Michael Lentine2b9eda42015-10-28 15:55:18 -07004220bool validatePrimaryCommandBuffer(const layer_data* my_data, const GLOBAL_CB_NODE* pCB, const std::string& cmd_name) {
4221 bool skip_call = false;
4222 if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) {
4223 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
4224 "Cannot execute command %s on a secondary command buffer.", cmd_name.c_str());
4225 }
4226 return skip_call;
4227}
4228
Michael Lentine27b0f902015-10-12 11:30:14 -05004229void TransitionFinalSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo* pRenderPassBegin) {
4230 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
4231 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
4232 auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass);
4233 if (render_pass_data == dev_data->renderPassMap.end()) {
4234 return;
4235 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004236 const VkRenderPassCreateInfo* pRenderPassInfo = render_pass_data->second->createInfo;
Michael Lentine27b0f902015-10-12 11:30:14 -05004237 auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer);
4238 if (framebuffer_data == dev_data->frameBufferMap.end()) {
4239 return;
4240 }
4241 const VkFramebufferCreateInfo* pFramebufferInfo = framebuffer_data->second;
4242 for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) {
4243 const VkImageView& image_view = pFramebufferInfo->pAttachments[i];
4244 auto image_view_data = dev_data->imageViewMap.find(image_view);
4245 if (image_view_data != dev_data->imageViewMap.end()) {
4246 auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image);
4247 if (image_layout != pCB->imageLayoutMap.end()) {
4248 image_layout->second.layout = pRenderPassInfo->pAttachments[i].finalLayout;
4249 }
4250 }
4251 }
4252}
4253
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004254VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004255{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004256 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004257 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4258 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004259 if (pCB) {
Tobin Ehlis8b6c2352015-06-23 16:13:03 -06004260 if (pRenderPassBegin && pRenderPassBegin->renderPass) {
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06004261 skipCall |= VerifyFramebufferAndRenderPassLayouts(commandBuffer, pRenderPassBegin);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004262 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBeginRenderPass");
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004263 updateCBTracking(pCB);
Michael Lentine2b9eda42015-10-28 15:55:18 -07004264 skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdBeginRenderPass");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004265 skipCall |= addCmd(dev_data, pCB, CMD_BEGINRENDERPASS);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004266 pCB->activeRenderPass = pRenderPassBegin->renderPass;
Michael Lentine27b0f902015-10-12 11:30:14 -05004267 // This is a shallow copy as that is all that is needed for now
4268 pCB->activeRenderPassBeginInfo = *pRenderPassBegin;
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004269 pCB->activeSubpass = 0;
4270 pCB->framebuffer = pRenderPassBegin->framebuffer;
4271 if (pCB->lastBoundPipeline) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004272 skipCall |= validatePipelineState(dev_data, pCB, VK_PIPELINE_BIND_POINT_GRAPHICS, pCB->lastBoundPipeline);
Tobin Ehlis8b6c2352015-06-23 16:13:03 -06004273 }
Tobin Ehlise4076782015-06-24 15:53:07 -06004274 } else {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004275 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Tobin Ehlis8b6c2352015-06-23 16:13:03 -06004276 "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()");
Tony Barbourb9f82ba2015-04-06 11:09:26 -06004277 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004278 }
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06004279 if (VK_FALSE == skipCall) {
Chia-I Wu1f851912015-10-27 18:04:07 +08004280 dev_data->device_dispatch_table->CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents);
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06004281 // This is a shallow copy as that is all that is needed for now
4282 dev_data->renderPassBeginInfo = *pRenderPassBegin;
4283 dev_data->currentSubpass = 0;
4284 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004285}
4286
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004287VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents)
Chia-I Wuc278df82015-07-07 11:50:03 +08004288{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004289 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004290 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4291 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Michael Lentine27b0f902015-10-12 11:30:14 -05004292 TransitionSubpassLayouts(commandBuffer, &dev_data->renderPassBeginInfo, ++dev_data->currentSubpass);
Chia-I Wuc278df82015-07-07 11:50:03 +08004293 if (pCB) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004294 updateCBTracking(pCB);
Michael Lentine2b9eda42015-10-28 15:55:18 -07004295 skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004296 skipCall |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004297 pCB->activeSubpass++;
Michael Lentine27b0f902015-10-12 11:30:14 -05004298 TransitionSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo, ++pCB->activeSubpass);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004299 if (pCB->lastBoundPipeline) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004300 skipCall |= validatePipelineState(dev_data, pCB, VK_PIPELINE_BIND_POINT_GRAPHICS, pCB->lastBoundPipeline);
Chia-I Wuc278df82015-07-07 11:50:03 +08004301 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004302 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass");
Chia-I Wuc278df82015-07-07 11:50:03 +08004303 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004304 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004305 dev_data->device_dispatch_table->CmdNextSubpass(commandBuffer, contents);
Chia-I Wuc278df82015-07-07 11:50:03 +08004306}
4307
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004308VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndRenderPass(VkCommandBuffer commandBuffer)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004309{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004310 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004311 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4312 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Michael Lentine27b0f902015-10-12 11:30:14 -05004313 TransitionFinalSubpassLayouts(commandBuffer, &dev_data->renderPassBeginInfo);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004314 if (pCB) {
Michael Lentine2b9eda42015-10-28 15:55:18 -07004315 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass");
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004316 updateCBTracking(pCB);
Michael Lentine2b9eda42015-10-28 15:55:18 -07004317 skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004318 skipCall |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS);
Michael Lentine27b0f902015-10-12 11:30:14 -05004319 TransitionFinalSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004320 pCB->activeRenderPass = 0;
4321 pCB->activeSubpass = 0;
Chia-I Wu88eaa3b2015-06-26 15:34:39 +08004322 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004323 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004324 dev_data->device_dispatch_table->CmdEndRenderPass(commandBuffer);
Chia-I Wu88eaa3b2015-06-26 15:34:39 +08004325}
4326
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004327VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer* pCommandBuffers)
Chia-I Wu88eaa3b2015-06-26 15:34:39 +08004328{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004329 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004330 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4331 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Chia-I Wu88eaa3b2015-06-26 15:34:39 +08004332 if (pCB) {
Tobin Ehlis5f728d32015-09-17 14:18:16 -06004333 GLOBAL_CB_NODE* pSubCB = NULL;
Chia-I Wu1f851912015-10-27 18:04:07 +08004334 for (uint32_t i=0; i<commandBuffersCount; i++) {
4335 pSubCB = getCBNode(dev_data, pCommandBuffers[i]);
Tobin Ehlis5f728d32015-09-17 14:18:16 -06004336 if (!pSubCB) {
Chia-I Wu1f851912015-10-27 18:04:07 +08004337 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS",
4338 "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p in element %u of pCommandBuffers array.", (void*)pCommandBuffers[i], i);
4339 } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) {
4340 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS",
4341 "vkCmdExecuteCommands() called w/ Primary Cmd Buffer %p in element %u of pCommandBuffers array. All cmd buffers in pCommandBuffers array must be secondary.", (void*)pCommandBuffers[i], i);
Tobin Ehlis5f728d32015-09-17 14:18:16 -06004342 }
4343 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004344 updateCBTracking(pCB);
Michael Lentine2b9eda42015-10-28 15:55:18 -07004345 skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004346 skipCall |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004347 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004348 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004349 dev_data->device_dispatch_table->CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004350}
4351
Michael Lentineee4ad4d2015-10-23 12:41:44 -07004352bool ValidateMapImageLayouts(VkDevice device, VkDeviceMemory mem) {
4353 bool skip_call = false;
4354 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
4355 auto mem_data = dev_data->memImageMap.find(mem);
4356 if (mem_data != dev_data->memImageMap.end()) {
4357 auto image_data = dev_data->imageLayoutMap.find(mem_data->second);
4358 if (image_data != dev_data->imageLayoutMap.end()) {
4359 if (image_data->second->layout != VK_IMAGE_LAYOUT_PREINITIALIZED && image_data->second->layout != VK_IMAGE_LAYOUT_GENERAL) {
4360 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4361 "Cannot map an image with layout %d. Only GENERAL or PREINITIALIZED are supported.", image_data->second->layout);
4362 }
4363 }
4364 }
4365 return skip_call;
4366}
4367
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004368VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkMapMemory(
Michael Lentineee4ad4d2015-10-23 12:41:44 -07004369 VkDevice device,
4370 VkDeviceMemory mem,
4371 VkDeviceSize offset,
4372 VkDeviceSize size,
4373 VkFlags flags,
4374 void **ppData)
4375{
4376 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
4377 bool skip_call = ValidateMapImageLayouts(device, mem);
4378 if (VK_FALSE == skip_call) {
4379 return dev_data->device_dispatch_table->MapMemory(device, mem, offset, size, flags, ppData);
4380 }
4381 return VK_ERROR_VALIDATION_FAILED;
4382}
4383
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004384VKAPI_ATTR VkResult VKAPI_CALL vkBindImageMemory(
Michael Lentineee4ad4d2015-10-23 12:41:44 -07004385 VkDevice device,
4386 VkImage image,
4387 VkDeviceMemory mem,
4388 VkDeviceSize memOffset)
4389{
4390 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
4391 VkResult result = dev_data->device_dispatch_table->BindImageMemory(device, image, mem, memOffset);
4392 loader_platform_thread_lock_mutex(&globalLock);
4393 dev_data->memImageMap[mem] = image;
4394 loader_platform_thread_unlock_mutex(&globalLock);
4395 return result;
4396}
4397
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004398VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSwapchainKHR(
Michael Lentine27b0f902015-10-12 11:30:14 -05004399 VkDevice device,
4400 const VkSwapchainCreateInfoKHR *pCreateInfo,
4401 VkSwapchainKHR *pSwapchain)
4402{
4403 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
4404 VkResult result = dev_data->device_dispatch_table->CreateSwapchainKHR(device, pCreateInfo, pSwapchain);
4405
4406 if (VK_SUCCESS == result) {
4407 SWAPCHAIN_NODE *swapchain_data = new SWAPCHAIN_NODE;
4408 loader_platform_thread_lock_mutex(&globalLock);
4409 dev_data->device_extensions.swapchainMap[*pSwapchain] = swapchain_data;
4410 loader_platform_thread_unlock_mutex(&globalLock);
4411 }
4412
4413 return result;
4414}
4415
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004416VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkDestroySwapchainKHR(
Michael Lentine27b0f902015-10-12 11:30:14 -05004417 VkDevice device,
4418 VkSwapchainKHR swapchain)
4419{
4420 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Michael Lentine27b0f902015-10-12 11:30:14 -05004421
4422 loader_platform_thread_lock_mutex(&globalLock);
4423 auto swapchain_data = dev_data->device_extensions.swapchainMap.find(swapchain);
4424 if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) {
4425 if (swapchain_data->second->images.size() > 0) {
4426 for (auto swapchain_image : swapchain_data->second->images) {
4427 auto image_item = dev_data->imageLayoutMap.find(swapchain_image);
4428 if (image_item != dev_data->imageLayoutMap.end())
4429 dev_data->imageLayoutMap.erase(image_item);
4430 }
4431 }
4432 delete swapchain_data->second;
4433 dev_data->device_extensions.swapchainMap.erase(swapchain);
4434 }
4435 loader_platform_thread_unlock_mutex(&globalLock);
4436 return dev_data->device_dispatch_table->DestroySwapchainKHR(device, swapchain);
4437}
4438
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004439VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkGetSwapchainImagesKHR(
Michael Lentine27b0f902015-10-12 11:30:14 -05004440 VkDevice device,
4441 VkSwapchainKHR swapchain,
4442 uint32_t* pCount,
4443 VkImage* pSwapchainImages)
4444{
4445 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
4446 VkResult result = dev_data->device_dispatch_table->GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages);
4447
4448 if (result == VK_SUCCESS && pSwapchainImages != NULL) {
4449 // This should never happen and is checked by param checker.
4450 if (!pCount) return result;
4451 for (uint32_t i = 0; i < *pCount; ++i) {
4452 IMAGE_NODE* image_node = new IMAGE_NODE;
4453 image_node->layout = VK_IMAGE_LAYOUT_UNDEFINED;
4454 loader_platform_thread_lock_mutex(&globalLock);
4455 dev_data->device_extensions.swapchainMap[swapchain]->images.push_back(pSwapchainImages[i]);
4456 dev_data->imageLayoutMap[pSwapchainImages[i]] = image_node;
4457 loader_platform_thread_unlock_mutex(&globalLock);
4458 }
4459 }
4460 return result;
4461}
4462
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004463VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueuePresentKHR(VkQueue queue, VkPresentInfoKHR* pPresentInfo)
Michael Lentine27b0f902015-10-12 11:30:14 -05004464{
4465 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map);
4466 bool skip_call = false;
4467
4468 if (pPresentInfo) {
4469 for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) {
4470 auto swapchain_data = dev_data->device_extensions.swapchainMap.find(pPresentInfo->swapchains[i]);
4471 if (swapchain_data != dev_data->device_extensions.swapchainMap.end() && pPresentInfo->imageIndices[i] < swapchain_data->second->images.size()) {
4472 VkImage image = swapchain_data->second->images[pPresentInfo->imageIndices[i]];
4473 auto image_data = dev_data->imageLayoutMap.find(image);
4474 if (image_data != dev_data->imageLayoutMap.end()) {
4475 if (image_data->second->layout != VK_IMAGE_LAYOUT_PRESENT_SOURCE_KHR) {
4476 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_QUEUE, (uint64_t)queue, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4477 "Images passed to present must be in layout PRESENT_SOURCE_KHR but is in %d", image_data->second->layout);
4478 }
4479 }
4480 }
4481 }
4482 }
4483
4484 if (VK_FALSE == skip_call)
4485 return dev_data->device_dispatch_table->QueuePresentKHR(queue, pPresentInfo);
4486 return VK_ERROR_VALIDATION_FAILED;
4487}
4488
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004489VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkDbgCreateMsgCallback(
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -06004490 VkInstance instance,
4491 VkFlags msgFlags,
4492 const PFN_vkDbgMsgCallback pfnMsgCallback,
4493 void* pUserData,
4494 VkDbgMsgCallback* pMsgCallback)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004495{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004496 layer_data* my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map);
4497 VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table;
Tobin Ehlisc91330b2015-06-16 09:04:30 -06004498 VkResult res = pTable->DbgCreateMsgCallback(instance, msgFlags, pfnMsgCallback, pUserData, pMsgCallback);
4499 if (VK_SUCCESS == res) {
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004500 //layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map);
Tobin Ehlisc91330b2015-06-16 09:04:30 -06004501 res = layer_create_msg_callback(my_data->report_data, msgFlags, pfnMsgCallback, pUserData, pMsgCallback);
4502 }
4503 return res;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004504}
4505
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004506VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkDbgDestroyMsgCallback(
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -06004507 VkInstance instance,
4508 VkDbgMsgCallback msgCallback)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004509{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004510 layer_data* my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map);
4511 VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table;
Tobin Ehlisc91330b2015-06-16 09:04:30 -06004512 VkResult res = pTable->DbgDestroyMsgCallback(instance, msgCallback);
Tobin Ehlisc91330b2015-06-16 09:04:30 -06004513 layer_destroy_msg_callback(my_data->report_data, msgCallback);
4514 return res;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004515}
4516
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004517VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDbgMarkerBegin(VkCommandBuffer commandBuffer, const char* pMarker)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004518{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004519 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004520 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4521 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004522 if (!dev_data->device_extensions.debug_marker_enabled) {
Chia-I Wu1f851912015-10-27 18:04:07 +08004523 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, (uint64_t)commandBuffer, 0, DRAWSTATE_INVALID_EXTENSION, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06004524 "Attempt to use CmdDbgMarkerBegin but extension disabled!");
Jon Ashburn6f8cd632015-06-01 09:37:38 -06004525 return;
Tobin Ehlisa366ca22015-06-19 15:07:05 -06004526 } else if (pCB) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004527 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004528 skipCall |= addCmd(dev_data, pCB, CMD_DBGMARKERBEGIN);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004529 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004530 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004531 debug_marker_dispatch_table(commandBuffer)->CmdDbgMarkerBegin(commandBuffer, pMarker);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004532}
4533
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004534VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDbgMarkerEnd(VkCommandBuffer commandBuffer)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004535{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004536 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004537 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4538 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004539 if (!dev_data->device_extensions.debug_marker_enabled) {
Chia-I Wu1f851912015-10-27 18:04:07 +08004540 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, (uint64_t)commandBuffer, 0, DRAWSTATE_INVALID_EXTENSION, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06004541 "Attempt to use CmdDbgMarkerEnd but extension disabled!");
Jon Ashburn6f8cd632015-06-01 09:37:38 -06004542 return;
Tobin Ehlisa366ca22015-06-19 15:07:05 -06004543 } else if (pCB) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004544 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004545 skipCall |= addCmd(dev_data, pCB, CMD_DBGMARKEREND);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004546 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004547 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004548 debug_marker_dispatch_table(commandBuffer)->CmdDbgMarkerEnd(commandBuffer);
Jon Ashburn6f8cd632015-06-01 09:37:38 -06004549}
4550
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004551VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char* funcName)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004552{
Jon Ashburn1245cec2015-05-18 13:20:15 -06004553 if (dev == NULL)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004554 return NULL;
Jon Ashburne0fa2282015-05-20 09:00:28 -06004555
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004556 layer_data *dev_data;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004557 /* loader uses this to force layer initialization; device object is wrapped */
4558 if (!strcmp(funcName, "vkGetDeviceProcAddr")) {
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004559 VkBaseLayerObject* wrapped_dev = (VkBaseLayerObject*) dev;
4560 dev_data = get_my_data_ptr(get_dispatch_key(wrapped_dev->baseObject), layer_data_map);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004561 dev_data->device_dispatch_table = new VkLayerDispatchTable;
4562 layer_initialize_dispatch_table(dev_data->device_dispatch_table, wrapped_dev);
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004563 return (PFN_vkVoidFunction) vkGetDeviceProcAddr;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004564 }
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004565 dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map);
Courtney Goeltzenleuchterbe637992015-06-25 18:01:43 -06004566 if (!strcmp(funcName, "vkCreateDevice"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004567 return (PFN_vkVoidFunction) vkCreateDevice;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004568 if (!strcmp(funcName, "vkDestroyDevice"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004569 return (PFN_vkVoidFunction) vkDestroyDevice;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004570 if (!strcmp(funcName, "vkQueueSubmit"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004571 return (PFN_vkVoidFunction) vkQueueSubmit;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004572 if (!strcmp(funcName, "vkDestroyInstance"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004573 return (PFN_vkVoidFunction) vkDestroyInstance;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004574 if (!strcmp(funcName, "vkDestroyDevice"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004575 return (PFN_vkVoidFunction) vkDestroyDevice;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004576 if (!strcmp(funcName, "vkDestroyFence"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004577 return (PFN_vkVoidFunction) vkDestroyFence;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004578 if (!strcmp(funcName, "vkDestroySemaphore"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004579 return (PFN_vkVoidFunction) vkDestroySemaphore;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004580 if (!strcmp(funcName, "vkDestroyEvent"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004581 return (PFN_vkVoidFunction) vkDestroyEvent;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004582 if (!strcmp(funcName, "vkDestroyQueryPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004583 return (PFN_vkVoidFunction) vkDestroyQueryPool;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004584 if (!strcmp(funcName, "vkDestroyBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004585 return (PFN_vkVoidFunction) vkDestroyBuffer;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004586 if (!strcmp(funcName, "vkDestroyBufferView"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004587 return (PFN_vkVoidFunction) vkDestroyBufferView;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004588 if (!strcmp(funcName, "vkDestroyImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004589 return (PFN_vkVoidFunction) vkDestroyImage;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004590 if (!strcmp(funcName, "vkDestroyImageView"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004591 return (PFN_vkVoidFunction) vkDestroyImageView;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004592 if (!strcmp(funcName, "vkDestroyShaderModule"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004593 return (PFN_vkVoidFunction) vkDestroyShaderModule;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004594 if (!strcmp(funcName, "vkDestroyPipeline"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004595 return (PFN_vkVoidFunction) vkDestroyPipeline;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004596 if (!strcmp(funcName, "vkDestroyPipelineLayout"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004597 return (PFN_vkVoidFunction) vkDestroyPipelineLayout;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004598 if (!strcmp(funcName, "vkDestroySampler"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004599 return (PFN_vkVoidFunction) vkDestroySampler;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004600 if (!strcmp(funcName, "vkDestroyDescriptorSetLayout"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004601 return (PFN_vkVoidFunction) vkDestroyDescriptorSetLayout;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004602 if (!strcmp(funcName, "vkDestroyDescriptorPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004603 return (PFN_vkVoidFunction) vkDestroyDescriptorPool;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004604 if (!strcmp(funcName, "vkDestroyFramebuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004605 return (PFN_vkVoidFunction) vkDestroyFramebuffer;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004606 if (!strcmp(funcName, "vkDestroyRenderPass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004607 return (PFN_vkVoidFunction) vkDestroyRenderPass;
Tobin Ehlisb46be812015-10-23 16:00:08 -06004608 if (!strcmp(funcName, "vkCreateBuffer"))
4609 return (PFN_vkVoidFunction) vkCreateBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004610 if (!strcmp(funcName, "vkCreateBufferView"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004611 return (PFN_vkVoidFunction) vkCreateBufferView;
Tobin Ehlisb46be812015-10-23 16:00:08 -06004612 if (!strcmp(funcName, "vkCreateImage"))
4613 return (PFN_vkVoidFunction) vkCreateImage;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004614 if (!strcmp(funcName, "vkCreateImageView"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004615 return (PFN_vkVoidFunction) vkCreateImageView;
Jon Ashburn0d60d272015-07-09 15:02:25 -06004616 if (!strcmp(funcName, "CreatePipelineCache"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004617 return (PFN_vkVoidFunction) vkCreatePipelineCache;
Jon Ashburn0d60d272015-07-09 15:02:25 -06004618 if (!strcmp(funcName, "DestroyPipelineCache"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004619 return (PFN_vkVoidFunction) vkDestroyPipelineCache;
Jon Ashburn0d60d272015-07-09 15:02:25 -06004620 if (!strcmp(funcName, "GetPipelineCacheData"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004621 return (PFN_vkVoidFunction) vkGetPipelineCacheData;
Jon Ashburn0d60d272015-07-09 15:02:25 -06004622 if (!strcmp(funcName, "MergePipelineCaches"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004623 return (PFN_vkVoidFunction) vkMergePipelineCaches;
Jon Ashburn0d60d272015-07-09 15:02:25 -06004624 if (!strcmp(funcName, "vkCreateGraphicsPipelines"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004625 return (PFN_vkVoidFunction) vkCreateGraphicsPipelines;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004626 if (!strcmp(funcName, "vkCreateSampler"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004627 return (PFN_vkVoidFunction) vkCreateSampler;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004628 if (!strcmp(funcName, "vkCreateDescriptorSetLayout"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004629 return (PFN_vkVoidFunction) vkCreateDescriptorSetLayout;
Mark Lobodzinski556f7212015-04-17 14:11:39 -05004630 if (!strcmp(funcName, "vkCreatePipelineLayout"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004631 return (PFN_vkVoidFunction) vkCreatePipelineLayout;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004632 if (!strcmp(funcName, "vkCreateDescriptorPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004633 return (PFN_vkVoidFunction) vkCreateDescriptorPool;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004634 if (!strcmp(funcName, "vkResetDescriptorPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004635 return (PFN_vkVoidFunction) vkResetDescriptorPool;
Chia-I Wu1f851912015-10-27 18:04:07 +08004636 if (!strcmp(funcName, "vkAllocateDescriptorSets"))
4637 return (PFN_vkVoidFunction) vkAllocateDescriptorSets;
Tobin Ehlis3c543112015-10-08 13:13:50 -06004638 if (!strcmp(funcName, "vkFreeDescriptorSets"))
4639 return (PFN_vkVoidFunction) vkFreeDescriptorSets;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08004640 if (!strcmp(funcName, "vkUpdateDescriptorSets"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004641 return (PFN_vkVoidFunction) vkUpdateDescriptorSets;
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07004642 if (!strcmp(funcName, "vkCreateCommandPool"))
4643 return (PFN_vkVoidFunction) vkCreateCommandPool;
4644 if (!strcmp(funcName, "vkDestroyCommandPool"))
4645 return (PFN_vkVoidFunction) vkDestroyCommandPool;
Chia-I Wu1f851912015-10-27 18:04:07 +08004646 if (!strcmp(funcName, "vkAllocateCommandBuffers"))
4647 return (PFN_vkVoidFunction) vkAllocateCommandBuffers;
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07004648 if (!strcmp(funcName, "vkFreeCommandBuffers"))
4649 return (PFN_vkVoidFunction) vkFreeCommandBuffers;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004650 if (!strcmp(funcName, "vkBeginCommandBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004651 return (PFN_vkVoidFunction) vkBeginCommandBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004652 if (!strcmp(funcName, "vkEndCommandBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004653 return (PFN_vkVoidFunction) vkEndCommandBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004654 if (!strcmp(funcName, "vkResetCommandBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004655 return (PFN_vkVoidFunction) vkResetCommandBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004656 if (!strcmp(funcName, "vkCmdBindPipeline"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004657 return (PFN_vkVoidFunction) vkCmdBindPipeline;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06004658 if (!strcmp(funcName, "vkCmdSetViewport"))
4659 return (PFN_vkVoidFunction) vkCmdSetViewport;
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06004660 if (!strcmp(funcName, "vkCmdSetScissor"))
4661 return (PFN_vkVoidFunction) vkCmdSetScissor;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06004662 if (!strcmp(funcName, "vkCmdSetLineWidth"))
4663 return (PFN_vkVoidFunction) vkCmdSetLineWidth;
4664 if (!strcmp(funcName, "vkCmdSetDepthBias"))
4665 return (PFN_vkVoidFunction) vkCmdSetDepthBias;
4666 if (!strcmp(funcName, "vkCmdSetBlendConstants"))
4667 return (PFN_vkVoidFunction) vkCmdSetBlendConstants;
4668 if (!strcmp(funcName, "vkCmdSetDepthBounds"))
4669 return (PFN_vkVoidFunction) vkCmdSetDepthBounds;
4670 if (!strcmp(funcName, "vkCmdSetStencilCompareMask"))
4671 return (PFN_vkVoidFunction) vkCmdSetStencilCompareMask;
4672 if (!strcmp(funcName, "vkCmdSetStencilWriteMask"))
4673 return (PFN_vkVoidFunction) vkCmdSetStencilWriteMask;
4674 if (!strcmp(funcName, "vkCmdSetStencilReference"))
4675 return (PFN_vkVoidFunction) vkCmdSetStencilReference;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004676 if (!strcmp(funcName, "vkCmdBindDescriptorSets"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004677 return (PFN_vkVoidFunction) vkCmdBindDescriptorSets;
Courtney Goeltzenleuchter46962942015-04-16 13:38:46 -06004678 if (!strcmp(funcName, "vkCmdBindVertexBuffers"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004679 return (PFN_vkVoidFunction) vkCmdBindVertexBuffers;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004680 if (!strcmp(funcName, "vkCmdBindIndexBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004681 return (PFN_vkVoidFunction) vkCmdBindIndexBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004682 if (!strcmp(funcName, "vkCmdDraw"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004683 return (PFN_vkVoidFunction) vkCmdDraw;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004684 if (!strcmp(funcName, "vkCmdDrawIndexed"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004685 return (PFN_vkVoidFunction) vkCmdDrawIndexed;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004686 if (!strcmp(funcName, "vkCmdDrawIndirect"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004687 return (PFN_vkVoidFunction) vkCmdDrawIndirect;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004688 if (!strcmp(funcName, "vkCmdDrawIndexedIndirect"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004689 return (PFN_vkVoidFunction) vkCmdDrawIndexedIndirect;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004690 if (!strcmp(funcName, "vkCmdDispatch"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004691 return (PFN_vkVoidFunction) vkCmdDispatch;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004692 if (!strcmp(funcName, "vkCmdDispatchIndirect"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004693 return (PFN_vkVoidFunction) vkCmdDispatchIndirect;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004694 if (!strcmp(funcName, "vkCmdCopyBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004695 return (PFN_vkVoidFunction) vkCmdCopyBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004696 if (!strcmp(funcName, "vkCmdCopyImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004697 return (PFN_vkVoidFunction) vkCmdCopyImage;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004698 if (!strcmp(funcName, "vkCmdCopyBufferToImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004699 return (PFN_vkVoidFunction) vkCmdCopyBufferToImage;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004700 if (!strcmp(funcName, "vkCmdCopyImageToBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004701 return (PFN_vkVoidFunction) vkCmdCopyImageToBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004702 if (!strcmp(funcName, "vkCmdUpdateBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004703 return (PFN_vkVoidFunction) vkCmdUpdateBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004704 if (!strcmp(funcName, "vkCmdFillBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004705 return (PFN_vkVoidFunction) vkCmdFillBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004706 if (!strcmp(funcName, "vkCmdClearColorImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004707 return (PFN_vkVoidFunction) vkCmdClearColorImage;
Chris Forbes2951d7d2015-06-22 17:21:59 +12004708 if (!strcmp(funcName, "vkCmdClearDepthStencilImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004709 return (PFN_vkVoidFunction) vkCmdClearDepthStencilImage;
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06004710 if (!strcmp(funcName, "vkCmdClearAttachments"))
4711 return (PFN_vkVoidFunction) vkCmdClearAttachments;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004712 if (!strcmp(funcName, "vkCmdResolveImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004713 return (PFN_vkVoidFunction) vkCmdResolveImage;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004714 if (!strcmp(funcName, "vkCmdSetEvent"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004715 return (PFN_vkVoidFunction) vkCmdSetEvent;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004716 if (!strcmp(funcName, "vkCmdResetEvent"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004717 return (PFN_vkVoidFunction) vkCmdResetEvent;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004718 if (!strcmp(funcName, "vkCmdWaitEvents"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004719 return (PFN_vkVoidFunction) vkCmdWaitEvents;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004720 if (!strcmp(funcName, "vkCmdPipelineBarrier"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004721 return (PFN_vkVoidFunction) vkCmdPipelineBarrier;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004722 if (!strcmp(funcName, "vkCmdBeginQuery"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004723 return (PFN_vkVoidFunction) vkCmdBeginQuery;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004724 if (!strcmp(funcName, "vkCmdEndQuery"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004725 return (PFN_vkVoidFunction) vkCmdEndQuery;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004726 if (!strcmp(funcName, "vkCmdResetQueryPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004727 return (PFN_vkVoidFunction) vkCmdResetQueryPool;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004728 if (!strcmp(funcName, "vkCmdWriteTimestamp"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004729 return (PFN_vkVoidFunction) vkCmdWriteTimestamp;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004730 if (!strcmp(funcName, "vkCreateFramebuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004731 return (PFN_vkVoidFunction) vkCreateFramebuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004732 if (!strcmp(funcName, "vkCreateRenderPass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004733 return (PFN_vkVoidFunction) vkCreateRenderPass;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004734 if (!strcmp(funcName, "vkCmdBeginRenderPass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004735 return (PFN_vkVoidFunction) vkCmdBeginRenderPass;
Chia-I Wuc278df82015-07-07 11:50:03 +08004736 if (!strcmp(funcName, "vkCmdNextSubpass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004737 return (PFN_vkVoidFunction) vkCmdNextSubpass;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004738 if (!strcmp(funcName, "vkCmdEndRenderPass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004739 return (PFN_vkVoidFunction) vkCmdEndRenderPass;
Tobin Ehlis5f728d32015-09-17 14:18:16 -06004740 if (!strcmp(funcName, "vkCmdExecuteCommands"))
4741 return (PFN_vkVoidFunction) vkCmdExecuteCommands;
Michael Lentineee4ad4d2015-10-23 12:41:44 -07004742 if (!strcmp(funcName, "vkMapMemory"))
4743 return (PFN_vkVoidFunction) vkMapMemory;
Jon Ashburn6f8cd632015-06-01 09:37:38 -06004744
Michael Lentine27b0f902015-10-12 11:30:14 -05004745 if (dev_data->device_extensions.wsi_enabled)
4746 {
4747 if (!strcmp(funcName, "vkCreateSwapchainKHR"))
4748 return (PFN_vkVoidFunction) vkCreateSwapchainKHR;
4749 if (!strcmp(funcName, "vkDestroySwapchainKHR"))
4750 return (PFN_vkVoidFunction) vkDestroySwapchainKHR;
4751 if (!strcmp(funcName, "vkGetSwapchainImagesKHR"))
4752 return (PFN_vkVoidFunction) vkGetSwapchainImagesKHR;
4753 if (!strcmp(funcName, "vkQueuePresentKHR"))
4754 return (PFN_vkVoidFunction) vkQueuePresentKHR;
4755 }
4756
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004757 VkLayerDispatchTable* pTable = dev_data->device_dispatch_table;
4758 if (dev_data->device_extensions.debug_marker_enabled)
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004759 {
Jon Ashburn7e07faf2015-06-18 15:02:58 -06004760 if (!strcmp(funcName, "vkCmdDbgMarkerBegin"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004761 return (PFN_vkVoidFunction) vkCmdDbgMarkerBegin;
Jon Ashburn7e07faf2015-06-18 15:02:58 -06004762 if (!strcmp(funcName, "vkCmdDbgMarkerEnd"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004763 return (PFN_vkVoidFunction) vkCmdDbgMarkerEnd;
Jon Ashburn6f8cd632015-06-01 09:37:38 -06004764 }
4765 {
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004766 if (pTable->GetDeviceProcAddr == NULL)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004767 return NULL;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004768 return pTable->GetDeviceProcAddr(dev, funcName);
Jon Ashburn79b78ac2015-05-05 14:22:52 -06004769 }
4770}
4771
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004772VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char* funcName)
Jon Ashburn79b78ac2015-05-05 14:22:52 -06004773{
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004774 PFN_vkVoidFunction fptr;
Jon Ashburn79b78ac2015-05-05 14:22:52 -06004775 if (instance == NULL)
4776 return NULL;
4777
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004778 layer_data* my_data;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004779 /* loader uses this to force layer initialization; instance object is wrapped */
4780 if (!strcmp(funcName, "vkGetInstanceProcAddr")) {
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004781 VkBaseLayerObject* wrapped_inst = (VkBaseLayerObject*) instance;
4782 my_data = get_my_data_ptr(get_dispatch_key(wrapped_inst->baseObject), layer_data_map);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004783 my_data->instance_dispatch_table = new VkLayerInstanceDispatchTable;
4784 layer_init_instance_dispatch_table(my_data->instance_dispatch_table, wrapped_inst);
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004785 return (PFN_vkVoidFunction) vkGetInstanceProcAddr;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004786 }
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004787 my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map);
Courtney Goeltzenleuchter3c9f6ec2015-06-01 14:29:58 -06004788 if (!strcmp(funcName, "vkCreateInstance"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004789 return (PFN_vkVoidFunction) vkCreateInstance;
Jon Ashburne0fa2282015-05-20 09:00:28 -06004790 if (!strcmp(funcName, "vkDestroyInstance"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004791 return (PFN_vkVoidFunction) vkDestroyInstance;
Courtney Goeltzenleuchter74c4ce92015-09-14 17:22:16 -06004792 if (!strcmp(funcName, "vkEnumerateInstanceLayerProperties"))
4793 return (PFN_vkVoidFunction) vkEnumerateInstanceLayerProperties;
4794 if (!strcmp(funcName, "vkEnumerateInstanceExtensionProperties"))
4795 return (PFN_vkVoidFunction) vkEnumerateInstanceExtensionProperties;
4796 if (!strcmp(funcName, "vkEnumerateDeviceLayerProperties"))
4797 return (PFN_vkVoidFunction) vkEnumerateDeviceLayerProperties;
4798 if (!strcmp(funcName, "vkEnumerateDeviceExtensionProperties"))
4799 return (PFN_vkVoidFunction) vkEnumerateDeviceExtensionProperties;
Courtney Goeltzenleuchtercc899fe2015-06-01 14:33:14 -06004800
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06004801 fptr = debug_report_get_instance_proc_addr(my_data->report_data, funcName);
Courtney Goeltzenleuchtercc899fe2015-06-01 14:33:14 -06004802 if (fptr)
4803 return fptr;
4804
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004805 {
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004806 VkLayerInstanceDispatchTable* pTable = my_data->instance_dispatch_table;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004807 if (pTable->GetInstanceProcAddr == NULL)
Jon Ashburn79b78ac2015-05-05 14:22:52 -06004808 return NULL;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004809 return pTable->GetInstanceProcAddr(instance, funcName);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004810 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004811}