blob: 6c3661ce933cd3972a0b58383afeff8e1ae44575 [file] [log] [blame]
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001/*
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002 *
Courtney Goeltzenleuchter8a17da52015-10-29 13:50:34 -06003 * Copyright (C) 2015 Valve Corporation
Michael Lentine329697b2015-10-06 14:56:18 -07004 * Copyright (C) 2015 Google, Inc.
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005 *
6 * Permission is hereby granted, free of charge, to any person obtaining a
7 * copy of this software and associated documentation files (the "Software"),
8 * to deal in the Software without restriction, including without limitation
9 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
10 * and/or sell copies of the Software, and to permit persons to whom the
11 * Software is furnished to do so, subject to the following conditions:
12 *
13 * The above copyright notice and this permission notice shall be included
14 * in all copies or substantial portions of the Software.
15 *
16 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
19 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
21 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
22 * DEALINGS IN THE SOFTWARE.
Courtney Goeltzenleuchter96cd7952015-10-30 11:14:30 -060023 *
24 * Author: Cody Northrop <cody@lunarg.com>
25 * Author: Michael Lentine <mlentine@google.com>
26 * Author: Tobin Ehlis <tobin@lunarg.com>
Tobin Ehlis63bb9482015-03-17 16:24:32 -060027 */
28
29#include <stdio.h>
30#include <stdlib.h>
31#include <string.h>
Michael Lentine329697b2015-10-06 14:56:18 -070032#include <algorithm>
33#include <memory>
Tobin Ehlis63bb9482015-03-17 16:24:32 -060034#include <unordered_map>
Michael Lentine329697b2015-10-06 14:56:18 -070035#include <unordered_set>
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -070036#include <list>
Tobin Ehlis63bb9482015-03-17 16:24:32 -060037
Tobin Ehlis7a51d902015-07-03 10:34:49 -060038#include "vk_loader_platform.h"
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -060039#include "vk_dispatch_table_helper.h"
40#include "vk_struct_string_helper_cpp.h"
Tony Barboura938abb2015-04-22 11:36:22 -060041#if defined(__GNUC__)
Tobin Ehlis63bb9482015-03-17 16:24:32 -060042#pragma GCC diagnostic ignored "-Wwrite-strings"
Tony Barboura938abb2015-04-22 11:36:22 -060043#endif
Tony Barboura938abb2015-04-22 11:36:22 -060044#if defined(__GNUC__)
Tobin Ehlis63bb9482015-03-17 16:24:32 -060045#pragma GCC diagnostic warning "-Wwrite-strings"
Tony Barboura938abb2015-04-22 11:36:22 -060046#endif
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -060047#include "vk_struct_size_helper.h"
Tobin Ehlis63bb9482015-03-17 16:24:32 -060048#include "draw_state.h"
Tobin Ehlis56d204a2015-07-03 10:15:26 -060049#include "vk_layer_config.h"
Michael Lentine8469dd62015-11-20 09:48:52 -080050#include "vulkan/vk_debug_marker_layer.h"
Tobin Ehlis56d204a2015-07-03 10:15:26 -060051#include "vk_layer_table.h"
52#include "vk_layer_debug_marker_table.h"
53#include "vk_layer_data.h"
54#include "vk_layer_logging.h"
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -060055#include "vk_layer_extension_utils.h"
Tobin Ehlisb46be812015-10-23 16:00:08 -060056#include "vk_layer_utils.h"
Tobin Ehlis63bb9482015-03-17 16:24:32 -060057
Tobin Ehlise6ab55a2015-10-07 09:38:40 -060058struct devExts {
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -070059 VkBool32 debug_marker_enabled;
Michael Lentine27b0f902015-10-12 11:30:14 -050060 VkBool32 wsi_enabled;
61 unordered_map<VkSwapchainKHR, SWAPCHAIN_NODE*> swapchainMap;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -060062};
63
Cody Northrop73bb6572015-09-28 15:09:32 -060064struct layer_data {
Tobin Ehlisc91330b2015-06-16 09:04:30 -060065 debug_report_data *report_data;
66 // TODO: put instance data here
Courtney Goeltzenleuchter1781b1c2015-10-05 15:58:38 -060067 std::vector<VkDbgMsgCallback> logging_callback;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -060068 VkLayerDispatchTable* device_dispatch_table;
69 VkLayerInstanceDispatchTable* instance_dispatch_table;
70 devExts device_extensions;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -060071 // Layer specific data
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -070072 unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> sampleMap;
73 unordered_map<VkImageView, unique_ptr<VkImageViewCreateInfo>> imageViewMap;
74 unordered_map<VkImage, unique_ptr<VkImageCreateInfo>> imageMap;
75 unordered_map<VkBufferView, unique_ptr<VkBufferViewCreateInfo>> bufferViewMap;
76 unordered_map<VkBuffer, unique_ptr<VkBufferCreateInfo>> bufferMap;
77 unordered_map<VkPipeline, PIPELINE_NODE*> pipelineMap;
78 unordered_map<VkCommandPool, list<VkCommandBuffer>> commandPoolMap;
79 unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE*> descriptorPoolMap;
80 unordered_map<VkDescriptorSet, SET_NODE*> setMap;
81 unordered_map<VkDescriptorSetLayout, LAYOUT_NODE*> layoutMap;
82 unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap;
83 unordered_map<VkDeviceMemory, VkImage> memImageMap;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -060084 // Map for layout chains
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -070085 unordered_map<void*, GLOBAL_CB_NODE*> commandBufferMap;
86 unordered_map<VkFramebuffer, VkFramebufferCreateInfo*> frameBufferMap;
87 unordered_map<VkImage, IMAGE_NODE*> imageLayoutMap;
88 unordered_map<VkRenderPass, RENDER_PASS_NODE*> renderPassMap;
Michael Lentine27b0f902015-10-12 11:30:14 -050089 // Current render pass
90 VkRenderPassBeginInfo renderPassBeginInfo;
91 uint32_t currentSubpass;
Cody Northrop73bb6572015-09-28 15:09:32 -060092
93 layer_data() :
94 report_data(nullptr),
Tobin Ehlise6ab55a2015-10-07 09:38:40 -060095 device_dispatch_table(nullptr),
96 instance_dispatch_table(nullptr),
97 device_extensions()
Cody Northrop73bb6572015-09-28 15:09:32 -060098 {};
99};
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600100// TODO : Do we need to guard access to layer_data_map w/ lock?
Tobin Ehlisc91330b2015-06-16 09:04:30 -0600101static std::unordered_map<void *, layer_data *> layer_data_map;
Courtney Goeltzenleuchterc280adc2015-06-13 21:23:09 -0600102
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600103static LOADER_PLATFORM_THREAD_ONCE_DECLARATION(g_initOnce);
Jon Ashburnd9564002015-05-07 10:27:37 -0600104
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600105// TODO : This can be much smarter, using separate locks for separate global data
106static int globalLockInitialized = 0;
107static loader_platform_thread_mutex globalLock;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600108#define MAX_TID 513
109static loader_platform_thread_id g_tidMapping[MAX_TID] = {0};
110static uint32_t g_maxTID = 0;
Tobin Ehlisfde4dce2015-06-16 15:50:44 -0600111
112template layer_data *get_my_data_ptr<layer_data>(
113 void *data_key,
114 std::unordered_map<void *, layer_data *> &data_map);
115
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600116// Map actual TID to an index value and return that index
117// This keeps TIDs in range from 0-MAX_TID and simplifies compares between runs
118static uint32_t getTIDIndex() {
119 loader_platform_thread_id tid = loader_platform_get_thread_id();
120 for (uint32_t i = 0; i < g_maxTID; i++) {
121 if (tid == g_tidMapping[i])
122 return i;
123 }
124 // Don't yet have mapping, set it and return newly set index
125 uint32_t retVal = (uint32_t) g_maxTID;
126 g_tidMapping[g_maxTID++] = tid;
127 assert(g_maxTID < MAX_TID);
128 return retVal;
129}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700130
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600131// Return a string representation of CMD_TYPE enum
132static string cmdTypeToString(CMD_TYPE cmd)
133{
134 switch (cmd)
135 {
136 case CMD_BINDPIPELINE:
137 return "CMD_BINDPIPELINE";
138 case CMD_BINDPIPELINEDELTA:
139 return "CMD_BINDPIPELINEDELTA";
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -0600140 case CMD_SETVIEWPORTSTATE:
141 return "CMD_SETVIEWPORTSTATE";
142 case CMD_SETLINEWIDTHSTATE:
143 return "CMD_SETLINEWIDTHSTATE";
144 case CMD_SETDEPTHBIASSTATE:
145 return "CMD_SETDEPTHBIASSTATE";
146 case CMD_SETBLENDSTATE:
147 return "CMD_SETBLENDSTATE";
148 case CMD_SETDEPTHBOUNDSSTATE:
149 return "CMD_SETDEPTHBOUNDSSTATE";
150 case CMD_SETSTENCILREADMASKSTATE:
151 return "CMD_SETSTENCILREADMASKSTATE";
152 case CMD_SETSTENCILWRITEMASKSTATE:
153 return "CMD_SETSTENCILWRITEMASKSTATE";
154 case CMD_SETSTENCILREFERENCESTATE:
155 return "CMD_SETSTENCILREFERENCESTATE";
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600156 case CMD_BINDDESCRIPTORSETS:
157 return "CMD_BINDDESCRIPTORSETS";
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600158 case CMD_BINDINDEXBUFFER:
159 return "CMD_BINDINDEXBUFFER";
160 case CMD_BINDVERTEXBUFFER:
161 return "CMD_BINDVERTEXBUFFER";
162 case CMD_DRAW:
163 return "CMD_DRAW";
164 case CMD_DRAWINDEXED:
165 return "CMD_DRAWINDEXED";
166 case CMD_DRAWINDIRECT:
167 return "CMD_DRAWINDIRECT";
168 case CMD_DRAWINDEXEDINDIRECT:
169 return "CMD_DRAWINDEXEDINDIRECT";
170 case CMD_DISPATCH:
171 return "CMD_DISPATCH";
172 case CMD_DISPATCHINDIRECT:
173 return "CMD_DISPATCHINDIRECT";
174 case CMD_COPYBUFFER:
175 return "CMD_COPYBUFFER";
176 case CMD_COPYIMAGE:
177 return "CMD_COPYIMAGE";
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600178 case CMD_BLITIMAGE:
179 return "CMD_BLITIMAGE";
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600180 case CMD_COPYBUFFERTOIMAGE:
181 return "CMD_COPYBUFFERTOIMAGE";
182 case CMD_COPYIMAGETOBUFFER:
183 return "CMD_COPYIMAGETOBUFFER";
184 case CMD_CLONEIMAGEDATA:
185 return "CMD_CLONEIMAGEDATA";
186 case CMD_UPDATEBUFFER:
187 return "CMD_UPDATEBUFFER";
188 case CMD_FILLBUFFER:
189 return "CMD_FILLBUFFER";
190 case CMD_CLEARCOLORIMAGE:
191 return "CMD_CLEARCOLORIMAGE";
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -0600192 case CMD_CLEARATTACHMENTS:
Tobin Ehlis8cd650e2015-07-01 16:46:13 -0600193 return "CMD_CLEARCOLORATTACHMENT";
194 case CMD_CLEARDEPTHSTENCILIMAGE:
195 return "CMD_CLEARDEPTHSTENCILIMAGE";
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600196 case CMD_RESOLVEIMAGE:
197 return "CMD_RESOLVEIMAGE";
198 case CMD_SETEVENT:
199 return "CMD_SETEVENT";
200 case CMD_RESETEVENT:
201 return "CMD_RESETEVENT";
202 case CMD_WAITEVENTS:
203 return "CMD_WAITEVENTS";
204 case CMD_PIPELINEBARRIER:
205 return "CMD_PIPELINEBARRIER";
206 case CMD_BEGINQUERY:
207 return "CMD_BEGINQUERY";
208 case CMD_ENDQUERY:
209 return "CMD_ENDQUERY";
210 case CMD_RESETQUERYPOOL:
211 return "CMD_RESETQUERYPOOL";
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -0600212 case CMD_COPYQUERYPOOLRESULTS:
213 return "CMD_COPYQUERYPOOLRESULTS";
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600214 case CMD_WRITETIMESTAMP:
215 return "CMD_WRITETIMESTAMP";
216 case CMD_INITATOMICCOUNTERS:
217 return "CMD_INITATOMICCOUNTERS";
218 case CMD_LOADATOMICCOUNTERS:
219 return "CMD_LOADATOMICCOUNTERS";
220 case CMD_SAVEATOMICCOUNTERS:
221 return "CMD_SAVEATOMICCOUNTERS";
222 case CMD_BEGINRENDERPASS:
223 return "CMD_BEGINRENDERPASS";
224 case CMD_ENDRENDERPASS:
225 return "CMD_ENDRENDERPASS";
226 case CMD_DBGMARKERBEGIN:
227 return "CMD_DBGMARKERBEGIN";
228 case CMD_DBGMARKEREND:
229 return "CMD_DBGMARKEREND";
230 default:
231 return "UNKNOWN";
232 }
233}
234// Block of code at start here for managing/tracking Pipeline state that this layer cares about
235// Just track 2 shaders for now
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600236#define MAX_SLOTS 2048
237#define NUM_COMMAND_BUFFERS_TO_DISPLAY 10
238
239static uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0};
240
Chia-I Wu1f851912015-10-27 18:04:07 +0800241// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600242// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates
243// to that same cmd buffer by separate thread are not changing state from underneath us
244// Track the last cmd buffer touched by this thread
Chia-I Wu1f851912015-10-27 18:04:07 +0800245static VkCommandBuffer g_lastCommandBuffer[MAX_TID] = {NULL};
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600246// Track the last group of CBs touched for displaying to dot file
Tobin Ehlis1dce5f12015-07-07 10:42:20 -0600247static GLOBAL_CB_NODE* g_pLastTouchedCB[NUM_COMMAND_BUFFERS_TO_DISPLAY] = {NULL};
248static uint32_t g_lastTouchedCBIndex = 0;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600249// Track the last global DrawState of interest touched by any thread
Tobin Ehlis1dce5f12015-07-07 10:42:20 -0600250static GLOBAL_CB_NODE* g_lastGlobalCB = NULL;
251static PIPELINE_NODE* g_lastBoundPipeline = NULL;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600252#define MAX_BINDING 0xFFFFFFFF // Default vtxBinding value in CB Node to identify if no vtxBinding set
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600253// prototype
Chia-I Wu1f851912015-10-27 18:04:07 +0800254static GLOBAL_CB_NODE* getCBNode(layer_data*, const VkCommandBuffer);
Tobin Ehlis982099b2015-11-05 09:52:49 -0700255
Chia-I Wu1f851912015-10-27 18:04:07 +0800256// Update global ptrs to reflect that specified commandBuffer has been used
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600257static void updateCBTracking(GLOBAL_CB_NODE* pCB)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600258{
Chia-I Wu1f851912015-10-27 18:04:07 +0800259 g_lastCommandBuffer[getTIDIndex()] = pCB->commandBuffer;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600260 loader_platform_thread_lock_mutex(&globalLock);
261 g_lastGlobalCB = pCB;
262 // TODO : This is a dumb algorithm. Need smart LRU that drops off oldest
263 for (uint32_t i = 0; i < NUM_COMMAND_BUFFERS_TO_DISPLAY; i++) {
264 if (g_pLastTouchedCB[i] == pCB) {
265 loader_platform_thread_unlock_mutex(&globalLock);
266 return;
267 }
268 }
269 g_pLastTouchedCB[g_lastTouchedCBIndex++] = pCB;
270 g_lastTouchedCBIndex = g_lastTouchedCBIndex % NUM_COMMAND_BUFFERS_TO_DISPLAY;
271 loader_platform_thread_unlock_mutex(&globalLock);
272}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700273
Courtney Goeltzenleuchter1f41f542015-07-09 11:44:38 -0600274static VkBool32 hasDrawCmd(GLOBAL_CB_NODE* pCB)
Tobin Ehlis8cd650e2015-07-01 16:46:13 -0600275{
276 for (uint32_t i=0; i<NUM_DRAW_TYPES; i++) {
277 if (pCB->drawCount[i])
278 return VK_TRUE;
279 }
280 return VK_FALSE;
281}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700282
Tobin Ehlis97866202015-06-10 12:57:07 -0600283// Check object status for selected flag state
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600284static VkBool32 validate_status(layer_data* my_data, GLOBAL_CB_NODE* pNode, CBStatusFlags enable_mask, CBStatusFlags status_mask, CBStatusFlags status_flag, VkFlags msg_flags, DRAW_STATE_ERROR error_code, const char* fail_msg)
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -0600285{
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600286 // If non-zero enable mask is present, check it against status but if enable_mask
287 // is 0 then no enable required so we should always just check status
288 if ((!enable_mask) || (enable_mask & pNode->status)) {
289 if ((pNode->status & status_mask) != status_flag) {
Tobin Ehlis1dce5f12015-07-07 10:42:20 -0600290 // TODO : How to pass dispatchable objects as srcObject? Here src obj should be cmd buffer
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600291 return log_msg(my_data->report_data, msg_flags, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, error_code, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +0800292 "CB object %#" PRIxLEAST64 ": %s", reinterpret_cast<uint64_t>(pNode->commandBuffer), fail_msg);
Tobin Ehlis97866202015-06-10 12:57:07 -0600293 }
Tobin Ehlis97866202015-06-10 12:57:07 -0600294 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600295 return VK_FALSE;
Tobin Ehlis97866202015-06-10 12:57:07 -0600296}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700297
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600298// Retrieve pipeline node ptr for given pipeline object
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600299static PIPELINE_NODE* getPipeline(layer_data* my_data, const VkPipeline pipeline)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600300{
301 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +0800302 if (my_data->pipelineMap.find(pipeline) == my_data->pipelineMap.end()) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600303 loader_platform_thread_unlock_mutex(&globalLock);
304 return NULL;
305 }
306 loader_platform_thread_unlock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +0800307 return my_data->pipelineMap[pipeline];
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600308}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700309
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600310// Return VK_TRUE if for a given PSO, the given state enum is dynamic, else return VK_FALSE
311static VkBool32 isDynamic(const PIPELINE_NODE* pPipeline, const VkDynamicState state)
312{
313 if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) {
314 for (uint32_t i=0; i<pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) {
315 if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i])
316 return VK_TRUE;
317 }
318 }
319 return VK_FALSE;
320}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700321
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600322// Validate state stored as flags at time of draw call
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600323static VkBool32 validate_draw_state_flags(layer_data* my_data, GLOBAL_CB_NODE* pCB, VkBool32 indexedDraw) {
Courtney Goeltzenleuchter1f41f542015-07-09 11:44:38 -0600324 VkBool32 result;
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600325 result = validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_VIEWPORT_SET, CBSTATUS_VIEWPORT_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_VIEWPORT_NOT_BOUND, "Dynamic viewport state not set for this command buffer");
Cody Northrop22cba2c2015-10-27 13:15:41 -0600326 result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_SCISSOR_SET, CBSTATUS_SCISSOR_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_SCISSOR_NOT_BOUND, "Dynamic scissor state not set for this command buffer");
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600327 result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_LINE_WIDTH_SET, CBSTATUS_LINE_WIDTH_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer");
328 result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_DEPTH_BIAS_SET, CBSTATUS_DEPTH_BIAS_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer");
329 result |= validate_status(my_data, pCB, CBSTATUS_COLOR_BLEND_WRITE_ENABLE, CBSTATUS_BLEND_SET, CBSTATUS_BLEND_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend object state not set for this command buffer");
330 result |= validate_status(my_data, pCB, CBSTATUS_DEPTH_WRITE_ENABLE, CBSTATUS_DEPTH_BOUNDS_SET, CBSTATUS_DEPTH_BOUNDS_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer");
331 result |= validate_status(my_data, pCB, CBSTATUS_STENCIL_TEST_ENABLE, CBSTATUS_STENCIL_READ_MASK_SET, CBSTATUS_STENCIL_READ_MASK_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer");
332 result |= validate_status(my_data, pCB, CBSTATUS_STENCIL_TEST_ENABLE, CBSTATUS_STENCIL_WRITE_MASK_SET, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer");
333 result |= validate_status(my_data, pCB, CBSTATUS_STENCIL_TEST_ENABLE, CBSTATUS_STENCIL_REFERENCE_SET, CBSTATUS_STENCIL_REFERENCE_SET, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer");
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600334 if (indexedDraw)
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600335 result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_INDEX_BUFFER_BOUND, CBSTATUS_INDEX_BUFFER_BOUND, VK_DBG_REPORT_ERROR_BIT, DRAWSTATE_INDEX_BUFFER_NOT_BOUND, "Index buffer object not bound to this command buffer when Indexed Draw attempted");
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600336 return result;
337}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700338
339// For give SET_NODE, verify that its Set is compatible w/ the setLayout corresponding to pipelineLayout[layoutIndex]
340static bool verify_set_layout_compatibility(layer_data* my_data, const SET_NODE* pSet, const VkPipelineLayout layout, const uint32_t layoutIndex, string& errorMsg)
341{
342 if (my_data->pipelineLayoutMap.find(layout) == my_data->pipelineLayoutMap.end()) {
343 cout << errorMsg << "invalid VkPipelineLayout (" << layout << ")";
344 return false;
345 }
346 PIPELINE_LAYOUT_NODE pl = my_data->pipelineLayoutMap[layout];
347 if (layoutIndex >= pl.descriptorSetLayouts.size()) {
348 cout << errorMsg << "VkPipelineLayout (" << layout << ") only contains " << pl.descriptorSetLayouts.size() << " setLayouts corresponding to sets 0-" << pl.descriptorSetLayouts.size()-1 << ", but you're attempting to bind set to index " << layoutIndex;
349 return false;
350 }
351 // Get the specific setLayout from PipelineLayout that overlaps this set
352 LAYOUT_NODE* pLayoutNode = my_data->layoutMap[pl.descriptorSetLayouts[layoutIndex]];
353 if (pLayoutNode->layout == pSet->pLayout->layout) { // trivial pass case
354 return true;
355 }
356 uint32_t descriptorCount = pLayoutNode->descriptorTypes.size();
357 if (descriptorCount != pSet->pLayout->descriptorTypes.size()) {
358 cout << errorMsg << "setLayout " << layoutIndex << " from pipelineLayout " << layout << " has " << descriptorCount << " descriptors, but corresponding set being bound has " << pSet->pLayout->descriptorTypes.size() << " descriptors.";
359 return false; // trivial fail case
360 }
361 // Now need to check set against corresponding pipelineLayout to verify compatibility
362 for (uint32_t i=0; i<descriptorCount; ++i) {
363 // Need to verify that layouts are identically defined
364 // TODO : Is below sufficient? Making sure that types & stageFlags match per descriptor
365 // do we also need to check immutable samplers?
366 if (pLayoutNode->descriptorTypes[i] != pSet->pLayout->descriptorTypes[i]) {
367 cout << errorMsg << "descriptor " << i << " for descriptorSet being bound is type '" << string_VkDescriptorType(pSet->pLayout->descriptorTypes[i]) << "' but corresponding descriptor from pipelineLayout is type '" << string_VkDescriptorType(pLayoutNode->descriptorTypes[i]) << "'";
368 return false;
369 }
370 if (pLayoutNode->stageFlags[i] != pSet->pLayout->stageFlags[i]) {
371 cout << errorMsg << "stageFlags " << i << " for descriptorSet being bound is " << pSet->pLayout->stageFlags[i] << "' but corresponding descriptor from pipelineLayout has stageFlags " << pLayoutNode->stageFlags[i];
372 return false;
373 }
374 }
375 return true;
376}
377
378// Check if given pipeline layouts are compatible from set 0 up through descriptorSet numDescriptorSets-1
379//static VkBool32 validate_pipeline_layout_compatibility(layer_data* my_data, const VkPipelineLayout psoLayout, const VkPipelineLayout dsLayout, const uint32_t numDescriptorSets)
380//{
381// VkBool32 skipCall = VK_FALSE;
382// // Handle trivial case of same pipeline layouts, which are obviously compatible
383// if (psoLayout == dsLayout)
384// return skipCall;
385// // Check for trivial fail cases
386// if (my_data->pipelineLayoutMap.find(psoLayout) == my_data->pipelineLayoutMap.end()) {
387// skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE_LAYOUT, (uint64_t) psoLayout, 0, DRAWSTATE_INVALID_PIPELINE_LAYOUT, "DS",
388// "PSO bound invalid pipelineLayout object %#" PRIxLEAST64, (uint64_t) psoLayout);
389//// skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE_LAYOUT, psoLayout, 0, DRAWSTATE_INVALID_PIPELINE_LAYOUT, "DS",
390//// "Created Descriptor Pool %#" PRIxLEAST64, (uint64_t) psoLayout);
391// //"PSO bound invalid pipelineLayout object %#" PRIxLEAST64, (uint64_t) psoLayout);
392// }
393// if (my_data->pipelineLayoutMap.find(dsLayout) == my_data->pipelineLayoutMap.end()) {
394// skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE_LAYOUT, (uint64_t) dsLayout, 0, DRAWSTATE_INVALID_PIPELINE_LAYOUT, "DS",
395// "Invalid pipelineLayout object (%#" PRIxLEAST64 ") bound at last vkCmdBindDescriptorSets() call.", (uint64_t) dsLayout);
396// }
397// if (skipCall) // If we hit fail case above, return early to avoid crash
398// return skipCall;
399// // Two pipeline layouts are defined to be "compatible for set N" if they were created with matching
400// // (the same, or identically defined) descriptor set layouts for sets zero through N.
401// PIPELINE_LAYOUT_NODE psoPL = my_data->pipelineLayoutMap[psoLayout];
402// PIPELINE_LAYOUT_NODE dsPL = my_data->pipelineLayoutMap[dsLayout];
403// // If either pipelineLayout doesn't have enough layouts, they can't be compatible
404// if (numDescriptorSets > psoPL.descriptorSetLayouts.size()) {
405// skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE_LAYOUT, (uint64_t) dsLayout, 0, DRAWSTATE_INVALID_PIPELINE_LAYOUT, "DS",
406// "Invalid pipelineLayout object (%#" PRIxLEAST64 ") bound at last vkCmdBindDescriptorSets() call.", (uint64_t) dsLayout);
407// }
408// if (numDescriptorSets > dsPL.descriptorSetLayouts.size()) {
409// // Not enough layouts, can't be compatible
410// }
411// // Now check each matching layout to confirm compatibility
412// LAYOUT_NODE *pPSOLayout, *pDSLayout;
413// for (uint32_t i=0; i<numDescriptorSets; ++i) {
414// pPSOLayout = my_data->layoutMap[psoPL.descriptorSetLayouts[i]];
415// pDSLayout = my_data->layoutMap[dsPL.descriptorSetLayouts[i]];
416// if (pPSOLayout == pDSLayout)
417// continue;
418// if (pPSOLayout->descriptorTypes.size() != pDSLayout->descriptorTypes.size()) {
419// // ERROR : different sizes in layouts
420// }
421// // Need to verify that layouts are identically defined
422// // TODO : Is below sufficient? Making sure that types & stageFlags match per descriptor
423// for (uint32_t j=0; j<pPSOLayout->descriptorTypes.size(); ++j) {
424// if (pPSOLayout->descriptorTypes[j] != pDSLayout->descriptorTypes[j]) {
425// // ERROR : Report type mismatch
426// }
427// if (pPSOLayout->stageFlags[j] != pDSLayout->stageFlags[j]) {
428// // ERROR : Report flags mismatch
429// }
430// }
431// }
432// return skipCall;
433//}
434
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600435// Validate overall state at the time of a draw call
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600436static VkBool32 validate_draw_state(layer_data* my_data, GLOBAL_CB_NODE* pCB, VkBool32 indexedDraw) {
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600437 // First check flag states
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600438 VkBool32 result = validate_draw_state_flags(my_data, pCB, indexedDraw);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600439 PIPELINE_NODE* pPipe = getPipeline(my_data, pCB->lastBoundPipeline);
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600440 // Now complete other state checks
Tobin Ehlis12ab7dc2015-09-09 13:31:01 -0600441 // TODO : Currently only performing next check if *something* was bound (non-zero last bound)
442 // There is probably a better way to gate when this check happens, and to know if something *should* have been bound
443 // We should have that check separately and then gate this check based on that check
Tobin Ehlis982099b2015-11-05 09:52:49 -0700444 if (pPipe && (pCB->lastBoundPipelineLayout)) {
445 // TODO : For all sets used by the PSO, need to make sure that something is bound AND that PSO pipelineLayout is compatible with each bound set
446 // first trick is how to get the sets used by PSO. ShaderChecker does this so perhaps move that code to utils
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600447 }
Tobin Ehlisd28acef2015-09-09 15:12:35 -0600448 // Verify Vtx binding
449 if (MAX_BINDING != pCB->lastVtxBinding) {
450 if (pCB->lastVtxBinding >= pPipe->vtxBindingCount) {
451 if (0 == pPipe->vtxBindingCount) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600452 result |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS",
Tobin Ehlisd28acef2015-09-09 15:12:35 -0600453 "Vtx Buffer Index %u was bound, but no vtx buffers are attached to PSO.", pCB->lastVtxBinding);
Tobin Ehlisd28acef2015-09-09 15:12:35 -0600454 }
455 else {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600456 result |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS",
Tobin Ehlisd28acef2015-09-09 15:12:35 -0600457 "Vtx binding Index of %u exceeds PSO pVertexBindingDescriptions max array index of %u.", pCB->lastVtxBinding, (pPipe->vtxBindingCount - 1));
Tobin Ehlisd28acef2015-09-09 15:12:35 -0600458 }
459 }
460 }
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600461 // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count
462 VkBool32 dynViewport = isDynamic(pPipe, VK_DYNAMIC_STATE_VIEWPORT);
463 VkBool32 dynScissor = isDynamic(pPipe, VK_DYNAMIC_STATE_SCISSOR);
464 if (dynViewport) {
465 if (pCB->viewports.size() != pPipe->graphicsPipelineCI.pViewportState->viewportCount) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600466 result |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Mark Lobodzinski2adea752015-11-10 15:25:01 -0700467 "Dynamic viewportCount from vkCmdSetViewport() is " PRINTF_SIZE_T_SPECIFIER ", but PSO viewportCount is %u. These counts must match.",
468 pCB->viewports.size(), pPipe->graphicsPipelineCI.pViewportState->viewportCount);
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600469 }
470 }
471 if (dynScissor) {
472 if (pCB->scissors.size() != pPipe->graphicsPipelineCI.pViewportState->scissorCount) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600473 result |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Mark Lobodzinski2adea752015-11-10 15:25:01 -0700474 "Dynamic scissorCount from vkCmdSetScissor() is " PRINTF_SIZE_T_SPECIFIER ", but PSO scissorCount is %u. These counts must match.",
475 pCB->scissors.size(), pPipe->graphicsPipelineCI.pViewportState->scissorCount);
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600476 }
477 }
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -0600478 return result;
479}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700480
Tobin Ehlisde63c532015-06-18 15:59:33 -0600481// Verify that create state for a pipeline is valid
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600482static VkBool32 verifyPipelineCreateState(layer_data* my_data, const VkDevice device, const PIPELINE_NODE* pPipeline)
Tobin Ehlisde63c532015-06-18 15:59:33 -0600483{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600484 VkBool32 skipCall = VK_FALSE;
Tobin Ehlisde63c532015-06-18 15:59:33 -0600485 // VS is required
486 if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600487 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Tobin Ehlisde63c532015-06-18 15:59:33 -0600488 "Invalid Pipeline CreateInfo State: Vtx Shader required");
Tobin Ehlisde63c532015-06-18 15:59:33 -0600489 }
490 // Either both or neither TC/TE shaders should be defined
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -0600491 if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) !=
492 ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0) ) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600493 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Tobin Ehlisde63c532015-06-18 15:59:33 -0600494 "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair");
Tobin Ehlisde63c532015-06-18 15:59:33 -0600495 }
496 // Compute shaders should be specified independent of Gfx shaders
497 if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) &&
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -0600498 (pPipeline->active_shaders & (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT |
499 VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | VK_SHADER_STAGE_GEOMETRY_BIT |
Tobin Ehlisde63c532015-06-18 15:59:33 -0600500 VK_SHADER_STAGE_FRAGMENT_BIT))) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600501 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Tobin Ehlisde63c532015-06-18 15:59:33 -0600502 "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline");
Tobin Ehlisde63c532015-06-18 15:59:33 -0600503 }
Chia-I Wu99ba2bb2015-10-31 00:31:16 +0800504 // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines.
Tobin Ehlisde63c532015-06-18 15:59:33 -0600505 // Mismatching primitive topology and tessellation fails graphics pipeline creation.
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -0600506 if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) &&
Chia-I Wu99ba2bb2015-10-31 00:31:16 +0800507 (pPipeline->iaStateCI.topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600508 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Chia-I Wu99ba2bb2015-10-31 00:31:16 +0800509 "Invalid Pipeline CreateInfo State: VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA topology for tessellation pipelines");
Tobin Ehlisde63c532015-06-18 15:59:33 -0600510 }
Chia-I Wu99ba2bb2015-10-31 00:31:16 +0800511 if (pPipeline->iaStateCI.topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) {
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -0600512 if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600513 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Chia-I Wu99ba2bb2015-10-31 00:31:16 +0800514 "Invalid Pipeline CreateInfo State: VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines");
Tobin Ehlis20693172015-09-17 08:46:18 -0600515 }
516 if (!pPipeline->tessStateCI.patchControlPoints || (pPipeline->tessStateCI.patchControlPoints > 32)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600517 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Chia-I Wu99ba2bb2015-10-31 00:31:16 +0800518 "Invalid Pipeline CreateInfo State: VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology used with patchControlPoints value %u."
Tobin Ehlis20693172015-09-17 08:46:18 -0600519 " patchControlPoints should be >0 and <=32.", pPipeline->tessStateCI.patchControlPoints);
520 }
Tobin Ehlisde63c532015-06-18 15:59:33 -0600521 }
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600522 // Viewport state must be included and viewport and scissor counts should always match
Tobin Ehlis9e839e52015-10-01 11:15:13 -0600523 // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600524 if (!pPipeline->graphicsPipelineCI.pViewportState) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600525 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600526 "Gfx Pipeline pViewportState is null. Even if viewport and scissors are dynamic PSO must include viewportCount and scissorCount in pViewportState.");
527 } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != pPipeline->graphicsPipelineCI.pViewportState->viewportCount) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600528 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Tobin Ehlis9e839e52015-10-01 11:15:13 -0600529 "Gfx Pipeline viewport count (%u) must match scissor count (%u).", pPipeline->vpStateCI.viewportCount, pPipeline->vpStateCI.scissorCount);
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600530 } else {
531 // If viewport or scissor are not dynamic, then verify that data is appropriate for count
532 VkBool32 dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT);
533 VkBool32 dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR);
534 if (!dynViewport) {
535 if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && !pPipeline->graphicsPipelineCI.pViewportState->pViewports) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600536 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Mark Lobodzinski2adea752015-11-10 15:25:01 -0700537 "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you must either include pViewports data, or "
538 "include viewport in pDynamicState and set it with vkCmdSetViewport().", pPipeline->graphicsPipelineCI.pViewportState->viewportCount);
Tobin Ehlis9e839e52015-10-01 11:15:13 -0600539 }
540 }
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600541 if (!dynScissor) {
542 if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && !pPipeline->graphicsPipelineCI.pViewportState->pScissors) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600543 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Mark Lobodzinski2adea752015-11-10 15:25:01 -0700544 "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you must either include pScissors data, or include "
545 "scissor in pDynamicState and set it with vkCmdSetScissor().", pPipeline->graphicsPipelineCI.pViewportState->scissorCount);
Tobin Ehlisa88e2f52015-10-02 11:00:56 -0600546 }
Tobin Ehlis9e839e52015-10-01 11:15:13 -0600547 }
548 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600549 return skipCall;
Tobin Ehlisde63c532015-06-18 15:59:33 -0600550}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700551
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600552// Init the pipeline mapping info based on pipeline create info LL tree
553// Threading note : Calls to this function should wrapped in mutex
Mark Lobodzinski2adea752015-11-10 15:25:01 -0700554static PIPELINE_NODE* initGraphicsPipeline(layer_data* dev_data, const VkGraphicsPipelineCreateInfo* pCreateInfo, PIPELINE_NODE* pBasePipeline)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600555{
Tobin Ehlisde63c532015-06-18 15:59:33 -0600556 PIPELINE_NODE* pPipeline = new PIPELINE_NODE;
557 if (pBasePipeline) {
558 memcpy((void*)pPipeline, (void*)pBasePipeline, sizeof(PIPELINE_NODE));
Tobin Ehlise42007c2015-06-19 13:00:59 -0600559 } else {
Tobin Ehlisde63c532015-06-18 15:59:33 -0600560 memset((void*)pPipeline, 0, sizeof(PIPELINE_NODE));
561 }
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600562 // First init create info
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -0600563 memcpy(&pPipeline->graphicsPipelineCI, pCreateInfo, sizeof(VkGraphicsPipelineCreateInfo));
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600564
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600565 size_t bufferSize = 0;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600566 const VkPipelineVertexInputStateCreateInfo* pVICI = NULL;
Tobin Ehlis59db5712015-07-13 13:14:24 -0600567 const VkPipelineColorBlendStateCreateInfo* pCBCI = NULL;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600568
569 for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) {
570 const VkPipelineShaderStageCreateInfo *pPSSCI = &pCreateInfo->pStages[i];
571
Chia-I Wu062ad152015-10-31 00:31:16 +0800572 switch (pPSSCI->stage) {
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -0600573 case VK_SHADER_STAGE_VERTEX_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600574 memcpy(&pPipeline->vsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
575 pPipeline->active_shaders |= VK_SHADER_STAGE_VERTEX_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600576 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -0600577 case VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600578 memcpy(&pPipeline->tcsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -0600579 pPipeline->active_shaders |= VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600580 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -0600581 case VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600582 memcpy(&pPipeline->tesCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -0600583 pPipeline->active_shaders |= VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600584 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -0600585 case VK_SHADER_STAGE_GEOMETRY_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600586 memcpy(&pPipeline->gsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
587 pPipeline->active_shaders |= VK_SHADER_STAGE_GEOMETRY_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600588 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -0600589 case VK_SHADER_STAGE_FRAGMENT_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600590 memcpy(&pPipeline->fsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
591 pPipeline->active_shaders |= VK_SHADER_STAGE_FRAGMENT_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600592 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -0600593 case VK_SHADER_STAGE_COMPUTE_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600594 // TODO : Flag error, CS is specified through VkComputePipelineCreateInfo
595 pPipeline->active_shaders |= VK_SHADER_STAGE_COMPUTE_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600596 break;
597 default:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600598 // TODO : Flag error
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600599 break;
600 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600601 }
Tobin Ehlisf6cb4672015-09-29 08:18:34 -0600602 // Copy over GraphicsPipelineCreateInfo structure embedded pointers
603 if (pCreateInfo->stageCount != 0) {
604 pPipeline->graphicsPipelineCI.pStages = new VkPipelineShaderStageCreateInfo[pCreateInfo->stageCount];
605 bufferSize = pCreateInfo->stageCount * sizeof(VkPipelineShaderStageCreateInfo);
606 memcpy((void*)pPipeline->graphicsPipelineCI.pStages, pCreateInfo->pStages, bufferSize);
607 }
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600608 if (pCreateInfo->pVertexInputState != NULL) {
609 memcpy((void*)&pPipeline->vertexInputCI, pCreateInfo->pVertexInputState , sizeof(VkPipelineVertexInputStateCreateInfo));
610 // Copy embedded ptrs
611 pVICI = pCreateInfo->pVertexInputState;
Chia-I Wu763a7492015-10-26 20:48:51 +0800612 pPipeline->vtxBindingCount = pVICI->vertexBindingDescriptionCount;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600613 if (pPipeline->vtxBindingCount) {
614 pPipeline->pVertexBindingDescriptions = new VkVertexInputBindingDescription[pPipeline->vtxBindingCount];
615 bufferSize = pPipeline->vtxBindingCount * sizeof(VkVertexInputBindingDescription);
616 memcpy((void*)pPipeline->pVertexBindingDescriptions, pVICI->pVertexBindingDescriptions, bufferSize);
617 }
Chia-I Wu763a7492015-10-26 20:48:51 +0800618 pPipeline->vtxAttributeCount = pVICI->vertexAttributeDescriptionCount;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600619 if (pPipeline->vtxAttributeCount) {
620 pPipeline->pVertexAttributeDescriptions = new VkVertexInputAttributeDescription[pPipeline->vtxAttributeCount];
621 bufferSize = pPipeline->vtxAttributeCount * sizeof(VkVertexInputAttributeDescription);
622 memcpy((void*)pPipeline->pVertexAttributeDescriptions, pVICI->pVertexAttributeDescriptions, bufferSize);
623 }
624 pPipeline->graphicsPipelineCI.pVertexInputState = &pPipeline->vertexInputCI;
625 }
Tony Barboure307f582015-07-10 15:29:03 -0600626 if (pCreateInfo->pInputAssemblyState != NULL) {
627 memcpy((void*)&pPipeline->iaStateCI, pCreateInfo->pInputAssemblyState, sizeof(VkPipelineInputAssemblyStateCreateInfo));
628 pPipeline->graphicsPipelineCI.pInputAssemblyState = &pPipeline->iaStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600629 }
Tony Barboure307f582015-07-10 15:29:03 -0600630 if (pCreateInfo->pTessellationState != NULL) {
631 memcpy((void*)&pPipeline->tessStateCI, pCreateInfo->pTessellationState, sizeof(VkPipelineTessellationStateCreateInfo));
632 pPipeline->graphicsPipelineCI.pTessellationState = &pPipeline->tessStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600633 }
Tony Barboure307f582015-07-10 15:29:03 -0600634 if (pCreateInfo->pViewportState != NULL) {
635 memcpy((void*)&pPipeline->vpStateCI, pCreateInfo->pViewportState, sizeof(VkPipelineViewportStateCreateInfo));
636 pPipeline->graphicsPipelineCI.pViewportState = &pPipeline->vpStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600637 }
Chia-I Wu1f851912015-10-27 18:04:07 +0800638 if (pCreateInfo->pRasterizationState != NULL) {
639 memcpy((void*)&pPipeline->rsStateCI, pCreateInfo->pRasterizationState, sizeof(VkPipelineRasterizationStateCreateInfo));
640 pPipeline->graphicsPipelineCI.pRasterizationState = &pPipeline->rsStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600641 }
Tony Barboure307f582015-07-10 15:29:03 -0600642 if (pCreateInfo->pMultisampleState != NULL) {
643 memcpy((void*)&pPipeline->msStateCI, pCreateInfo->pMultisampleState, sizeof(VkPipelineMultisampleStateCreateInfo));
644 pPipeline->graphicsPipelineCI.pMultisampleState = &pPipeline->msStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600645 }
Tobin Ehlisf6cb4672015-09-29 08:18:34 -0600646 if (pCreateInfo->pDepthStencilState != NULL) {
647 memcpy((void*)&pPipeline->dsStateCI, pCreateInfo->pDepthStencilState, sizeof(VkPipelineDepthStencilStateCreateInfo));
648 pPipeline->graphicsPipelineCI.pDepthStencilState = &pPipeline->dsStateCI;
649 }
Tony Barboure307f582015-07-10 15:29:03 -0600650 if (pCreateInfo->pColorBlendState != NULL) {
651 memcpy((void*)&pPipeline->cbStateCI, pCreateInfo->pColorBlendState, sizeof(VkPipelineColorBlendStateCreateInfo));
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600652 // Copy embedded ptrs
Tony Barboure307f582015-07-10 15:29:03 -0600653 pCBCI = pCreateInfo->pColorBlendState;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600654 pPipeline->attachmentCount = pCBCI->attachmentCount;
655 if (pPipeline->attachmentCount) {
Tony Barboure307f582015-07-10 15:29:03 -0600656 pPipeline->pAttachments = new VkPipelineColorBlendAttachmentState[pPipeline->attachmentCount];
657 bufferSize = pPipeline->attachmentCount * sizeof(VkPipelineColorBlendAttachmentState);
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600658 memcpy((void*)pPipeline->pAttachments, pCBCI->pAttachments, bufferSize);
659 }
Tony Barboure307f582015-07-10 15:29:03 -0600660 pPipeline->graphicsPipelineCI.pColorBlendState = &pPipeline->cbStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600661 }
Tobin Ehlisf6cb4672015-09-29 08:18:34 -0600662 if (pCreateInfo->pDynamicState != NULL) {
663 memcpy((void*)&pPipeline->dynStateCI, pCreateInfo->pDynamicState, sizeof(VkPipelineDynamicStateCreateInfo));
664 if (pPipeline->dynStateCI.dynamicStateCount) {
665 pPipeline->dynStateCI.pDynamicStates = new VkDynamicState[pPipeline->dynStateCI.dynamicStateCount];
666 bufferSize = pPipeline->dynStateCI.dynamicStateCount * sizeof(VkDynamicState);
667 memcpy((void*)pPipeline->dynStateCI.pDynamicStates, pCreateInfo->pDynamicState->pDynamicStates, bufferSize);
668 }
669 pPipeline->graphicsPipelineCI.pDynamicState = &pPipeline->dynStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600670 }
671
Tobin Ehlisde63c532015-06-18 15:59:33 -0600672 return pPipeline;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600673}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700674
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600675// Free the Pipeline nodes
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600676static void deletePipelines(layer_data* my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600677{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600678 if (my_data->pipelineMap.size() <= 0)
David Pinedof5997ab2015-04-27 16:36:17 -0600679 return;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600680 for (auto ii=my_data->pipelineMap.begin(); ii!=my_data->pipelineMap.end(); ++ii) {
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -0600681 if ((*ii).second->graphicsPipelineCI.stageCount != 0) {
682 delete[] (*ii).second->graphicsPipelineCI.pStages;
683 }
Tobin Ehliscd3109e2015-04-01 11:59:08 -0600684 if ((*ii).second->pVertexBindingDescriptions) {
685 delete[] (*ii).second->pVertexBindingDescriptions;
686 }
687 if ((*ii).second->pVertexAttributeDescriptions) {
688 delete[] (*ii).second->pVertexAttributeDescriptions;
689 }
690 if ((*ii).second->pAttachments) {
691 delete[] (*ii).second->pAttachments;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600692 }
Tobin Ehlisf6cb4672015-09-29 08:18:34 -0600693 if ((*ii).second->dynStateCI.dynamicStateCount != 0) {
694 delete[] (*ii).second->dynStateCI.pDynamicStates;
695 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600696 delete (*ii).second;
697 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600698 my_data->pipelineMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600699}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700700
Tobin Ehlis2464b882015-04-01 08:40:34 -0600701// For given pipeline, return number of MSAA samples, or one if MSAA disabled
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800702static VkSampleCountFlagBits getNumSamples(layer_data* my_data, const VkPipeline pipeline)
Tobin Ehlis2464b882015-04-01 08:40:34 -0600703{
Chia-I Wue420a332015-10-26 20:04:44 +0800704 PIPELINE_NODE* pPipe = my_data->pipelineMap[pipeline];
Tobin Ehlisb3a506f2015-07-13 14:51:15 -0600705 if (VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pPipe->msStateCI.sType) {
Chia-I Wu1f851912015-10-27 18:04:07 +0800706 return pPipe->msStateCI.rasterizationSamples;
Tobin Ehlisb3a506f2015-07-13 14:51:15 -0600707 }
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800708 return VK_SAMPLE_COUNT_1_BIT;
Tobin Ehlis2464b882015-04-01 08:40:34 -0600709}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700710
Tobin Ehlis2464b882015-04-01 08:40:34 -0600711// Validate state related to the PSO
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600712static VkBool32 validatePipelineState(layer_data* my_data, const GLOBAL_CB_NODE* pCB, const VkPipelineBindPoint pipelineBindPoint, const VkPipeline pipeline)
Tobin Ehlis2464b882015-04-01 08:40:34 -0600713{
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -0600714 if (VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) {
Tobin Ehlis2464b882015-04-01 08:40:34 -0600715 // Verify that any MSAA request in PSO matches sample# in bound FB
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800716 VkSampleCountFlagBits psoNumSamples = getNumSamples(my_data, pipeline);
Tobin Ehlis2464b882015-04-01 08:40:34 -0600717 if (pCB->activeRenderPass) {
Michael Lentine07ff1a12015-10-15 17:07:00 -0500718 const VkRenderPassCreateInfo* pRPCI = my_data->renderPassMap[pCB->activeRenderPass]->createInfo;
Chia-I Wuc278df82015-07-07 11:50:03 +0800719 const VkSubpassDescription* pSD = &pRPCI->pSubpasses[pCB->activeSubpass];
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800720 VkSampleCountFlagBits subpassNumSamples = (VkSampleCountFlagBits) 0;
Chia-I Wuc278df82015-07-07 11:50:03 +0800721 uint32_t i;
722
Chia-I Wu763a7492015-10-26 20:48:51 +0800723 for (i = 0; i < pSD->colorAttachmentCount; i++) {
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800724 VkSampleCountFlagBits samples;
Chia-I Wuc278df82015-07-07 11:50:03 +0800725
Cody Northrop6de6b0b2015-08-04 11:16:41 -0600726 if (pSD->pColorAttachments[i].attachment == VK_ATTACHMENT_UNUSED)
Chia-I Wuc278df82015-07-07 11:50:03 +0800727 continue;
728
Cody Northrop6de6b0b2015-08-04 11:16:41 -0600729 samples = pRPCI->pAttachments[pSD->pColorAttachments[i].attachment].samples;
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800730 if (subpassNumSamples == (VkSampleCountFlagBits) 0) {
Chia-I Wuc278df82015-07-07 11:50:03 +0800731 subpassNumSamples = samples;
732 } else if (subpassNumSamples != samples) {
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800733 subpassNumSamples = (VkSampleCountFlagBits) -1;
Chia-I Wuc278df82015-07-07 11:50:03 +0800734 break;
735 }
736 }
Chia-I Wuce532f72015-10-26 17:32:47 +0800737 if (pSD->pDepthStencilAttachment && pSD->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) {
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800738 const VkSampleCountFlagBits samples = pRPCI->pAttachments[pSD->pDepthStencilAttachment->attachment].samples;
739 if (subpassNumSamples == (VkSampleCountFlagBits) 0)
Chia-I Wuc278df82015-07-07 11:50:03 +0800740 subpassNumSamples = samples;
741 else if (subpassNumSamples != samples)
Chia-I Wu3138d6a2015-10-31 00:31:16 +0800742 subpassNumSamples = (VkSampleCountFlagBits) -1;
Chia-I Wuc278df82015-07-07 11:50:03 +0800743 }
744
745 if (psoNumSamples != subpassNumSamples) {
Chia-I Wue420a332015-10-26 20:04:44 +0800746 return log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE, (uint64_t) pipeline, 0, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS",
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -0600747 "Num samples mismatch! Binding PSO (%#" PRIxLEAST64 ") with %u samples while current RenderPass (%#" PRIxLEAST64 ") w/ %u samples!",
Chia-I Wue420a332015-10-26 20:04:44 +0800748 (uint64_t) pipeline, psoNumSamples, (uint64_t) pCB->activeRenderPass, subpassNumSamples);
Tobin Ehlis2464b882015-04-01 08:40:34 -0600749 }
750 } else {
751 // TODO : I believe it's an error if we reach this point and don't have an activeRenderPass
752 // Verify and flag error as appropriate
753 }
754 // TODO : Add more checks here
755 } else {
756 // TODO : Validate non-gfx pipeline updates
757 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600758 return VK_FALSE;
Tobin Ehlis2464b882015-04-01 08:40:34 -0600759}
760
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600761// Block of code at start here specifically for managing/tracking DSs
762
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600763// Return Pool node ptr for specified pool or else NULL
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -0700764static DESCRIPTOR_POOL_NODE* getPoolNode(layer_data* my_data, const VkDescriptorPool pool)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600765{
766 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -0700767 if (my_data->descriptorPoolMap.find(pool) == my_data->descriptorPoolMap.end()) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600768 loader_platform_thread_unlock_mutex(&globalLock);
769 return NULL;
770 }
771 loader_platform_thread_unlock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -0700772 return my_data->descriptorPoolMap[pool];
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600773}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700774
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600775// Return Set node ptr for specified set or else NULL
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600776static SET_NODE* getSetNode(layer_data* my_data, const VkDescriptorSet set)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600777{
778 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +0800779 if (my_data->setMap.find(set) == my_data->setMap.end()) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600780 loader_platform_thread_unlock_mutex(&globalLock);
781 return NULL;
782 }
783 loader_platform_thread_unlock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +0800784 return my_data->setMap[set];
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600785}
786
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600787static LAYOUT_NODE* getLayoutNode(layer_data* my_data, const VkDescriptorSetLayout layout) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600788 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +0800789 if (my_data->layoutMap.find(layout) == my_data->layoutMap.end()) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600790 loader_platform_thread_unlock_mutex(&globalLock);
791 return NULL;
792 }
793 loader_platform_thread_unlock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +0800794 return my_data->layoutMap[layout];
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600795}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700796
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600797// Return VK_FALSE if update struct is of valid type, otherwise flag error and return code from callback
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600798static VkBool32 validUpdateStruct(layer_data* my_data, const VkDevice device, const GENERIC_HEADER* pUpdateStruct)
Tobin Ehlis0b551cd2015-05-28 12:10:17 -0600799{
Tobin Ehlis0b551cd2015-05-28 12:10:17 -0600800 switch (pUpdateStruct->sType)
801 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800802 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
803 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600804 return VK_FALSE;
Tobin Ehlis0b551cd2015-05-28 12:10:17 -0600805 default:
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600806 return log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_UPDATE_STRUCT, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -0600807 "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType);
Tobin Ehlis0b551cd2015-05-28 12:10:17 -0600808 }
809}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700810
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600811// Set count for given update struct in the last parameter
812// Return value of skipCall, which is only VK_TRUE is error occurs and callback signals execution to cease
Tobin Ehlise66ec962015-10-27 12:54:50 -0600813static uint32_t getUpdateCount(layer_data* my_data, const VkDevice device, const GENERIC_HEADER* pUpdateStruct)
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600814{
815 switch (pUpdateStruct->sType)
816 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800817 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
Chia-I Wu763a7492015-10-26 20:48:51 +0800818 return ((VkWriteDescriptorSet*)pUpdateStruct)->descriptorCount;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800819 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600820 // TODO : Need to understand this case better and make sure code is correct
Chia-I Wu763a7492015-10-26 20:48:51 +0800821 return ((VkCopyDescriptorSet*)pUpdateStruct)->descriptorCount;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600822 }
823}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700824
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600825// For given Layout Node and binding, return index where that binding begins
826static uint32_t getBindingStartIndex(const LAYOUT_NODE* pLayout, const uint32_t binding)
827{
828 uint32_t offsetIndex = 0;
Chia-I Wub5689ee2015-10-31 00:31:16 +0800829 for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) {
830 if (pLayout->createInfo.pBinding[i].binding == binding)
831 break;
Chia-I Wu045654f2015-11-06 06:42:02 +0800832 offsetIndex += pLayout->createInfo.pBinding[i].descriptorCount;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600833 }
834 return offsetIndex;
835}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700836
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600837// For given layout node and binding, return last index that is updated
838static uint32_t getBindingEndIndex(const LAYOUT_NODE* pLayout, const uint32_t binding)
839{
840 uint32_t offsetIndex = 0;
Chia-I Wub5689ee2015-10-31 00:31:16 +0800841 for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) {
Chia-I Wu045654f2015-11-06 06:42:02 +0800842 offsetIndex += pLayout->createInfo.pBinding[i].descriptorCount;
Chia-I Wub5689ee2015-10-31 00:31:16 +0800843 if (pLayout->createInfo.pBinding[i].binding == binding)
844 break;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600845 }
846 return offsetIndex-1;
847}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700848
Tobin Ehlise66ec962015-10-27 12:54:50 -0600849// For given layout and update, return the first overall index of the layout that is updated
Tobin Ehlisd2e246e2015-10-27 15:43:38 -0600850static uint32_t getUpdateStartIndex(layer_data* my_data, const VkDevice device, const LAYOUT_NODE* pLayout, const uint32_t binding, const uint32_t arrayIndex, const GENERIC_HEADER* pUpdateStruct)
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600851{
Tobin Ehlise66ec962015-10-27 12:54:50 -0600852 return getBindingStartIndex(pLayout, binding)+arrayIndex;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600853}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700854
Tobin Ehlisd2e246e2015-10-27 15:43:38 -0600855// For given layout and update, return the last overall index of the layout that is updated
856static uint32_t getUpdateEndIndex(layer_data* my_data, const VkDevice device, const LAYOUT_NODE* pLayout, const uint32_t binding, const uint32_t arrayIndex, const GENERIC_HEADER* pUpdateStruct)
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600857{
Tobin Ehlisd2e246e2015-10-27 15:43:38 -0600858 uint32_t count = getUpdateCount(my_data, device, pUpdateStruct);
Tobin Ehlise66ec962015-10-27 12:54:50 -0600859 return getBindingStartIndex(pLayout, binding)+arrayIndex+count-1;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600860}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700861
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600862// Verify that the descriptor type in the update struct matches what's expected by the layout
Tobin Ehlis68fbd442015-10-27 12:25:35 -0600863static VkBool32 validateUpdateConsistency(layer_data* my_data, const VkDevice device, const LAYOUT_NODE* pLayout, const GENERIC_HEADER* pUpdateStruct, uint32_t startIndex, uint32_t endIndex)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600864{
865 // First get actual type of update
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600866 VkBool32 skipCall = VK_FALSE;
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -0600867 VkDescriptorType actualType;
Tobin Ehlis68fbd442015-10-27 12:25:35 -0600868 uint32_t i = 0;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600869 switch (pUpdateStruct->sType)
870 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800871 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
872 actualType = ((VkWriteDescriptorSet*)pUpdateStruct)->descriptorType;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600873 break;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800874 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
875 /* no need to validate */
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600876 return VK_FALSE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600877 break;
878 default:
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600879 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_UPDATE_STRUCT, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -0600880 "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType);
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600881 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600882 if (VK_FALSE == skipCall) {
Tobin Ehlis68fbd442015-10-27 12:25:35 -0600883 // Set first stageFlags as reference and verify that all other updates match it
884 VkShaderStageFlags refStageFlags = pLayout->stageFlags[startIndex];
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600885 for (i = startIndex; i <= endIndex; i++) {
Tobin Ehlis91423d22015-10-20 10:11:55 -0600886 if (pLayout->descriptorTypes[i] != actualType) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600887 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS",
Tobin Ehlis68fbd442015-10-27 12:25:35 -0600888 "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!",
889 string_VkDescriptorType(actualType), string_VkDescriptorType(pLayout->descriptorTypes[i]));
890 }
891 if (pLayout->stageFlags[i] != refStageFlags) {
892 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_DESCRIPTOR_STAGEFLAGS_MISMATCH, "DS",
893 "Write descriptor update has stageFlags %x that do not match overlapping binding descriptor stageFlags of %x!",
894 refStageFlags, pLayout->stageFlags[i]);
Tobin Ehlis3b341092015-09-30 08:30:20 -0600895 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600896 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600897 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600898 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600899}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700900
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600901// Determine the update type, allocate a new struct of that type, shadow the given pUpdate
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600902// struct into the pNewNode param. Return VK_TRUE if error condition encountered and callback signals early exit.
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600903// NOTE : Calls to this function should be wrapped in mutex
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600904static VkBool32 shadowUpdateNode(layer_data* my_data, const VkDevice device, GENERIC_HEADER* pUpdate, GENERIC_HEADER** pNewNode)
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600905{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600906 VkBool32 skipCall = VK_FALSE;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800907 VkWriteDescriptorSet* pWDS = NULL;
908 VkCopyDescriptorSet* pCDS = NULL;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600909 size_t array_size = 0;
910 size_t base_array_size = 0;
911 size_t total_array_size = 0;
912 size_t baseBuffAddr = 0;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600913 switch (pUpdate->sType)
914 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800915 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
916 pWDS = new VkWriteDescriptorSet;
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600917 *pNewNode = (GENERIC_HEADER*)pWDS;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800918 memcpy(pWDS, pUpdate, sizeof(VkWriteDescriptorSet));
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -0600919
920 switch (pWDS->descriptorType) {
921 case VK_DESCRIPTOR_TYPE_SAMPLER:
922 case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
923 case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
924 case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
925 {
Chia-I Wu763a7492015-10-26 20:48:51 +0800926 VkDescriptorImageInfo *info = new VkDescriptorImageInfo[pWDS->descriptorCount];
927 memcpy(info, pWDS->pImageInfo, pWDS->descriptorCount * sizeof(VkDescriptorImageInfo));
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -0600928 pWDS->pImageInfo = info;
929 }
930 break;
931 case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
932 case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
933 {
Chia-I Wu763a7492015-10-26 20:48:51 +0800934 VkBufferView *info = new VkBufferView[pWDS->descriptorCount];
935 memcpy(info, pWDS->pTexelBufferView, pWDS->descriptorCount * sizeof(VkBufferView));
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -0600936 pWDS->pTexelBufferView = info;
937 }
938 break;
939 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER:
940 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER:
941 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
942 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
943 {
Chia-I Wu763a7492015-10-26 20:48:51 +0800944 VkDescriptorBufferInfo *info = new VkDescriptorBufferInfo[pWDS->descriptorCount];
945 memcpy(info, pWDS->pBufferInfo, pWDS->descriptorCount * sizeof(VkDescriptorBufferInfo));
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -0600946 pWDS->pBufferInfo = info;
947 }
948 break;
949 default:
950 return VK_ERROR_VALIDATION_FAILED;
951 break;
952 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600953 break;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800954 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
955 pCDS = new VkCopyDescriptorSet;
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600956 *pNewNode = (GENERIC_HEADER*)pCDS;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +0800957 memcpy(pCDS, pUpdate, sizeof(VkCopyDescriptorSet));
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600958 break;
959 default:
Tobin Ehlis42d440c2015-10-20 17:06:16 -0600960 if (log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_UPDATE_STRUCT, "DS",
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600961 "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", string_VkStructureType(pUpdate->sType), pUpdate->sType))
962 return VK_TRUE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600963 }
964 // Make sure that pNext for the end of shadow copy is NULL
Tobin Ehlis48ddcb82015-09-09 11:31:10 -0600965 (*pNewNode)->pNext = NULL;
966 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600967}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700968
Tobin Ehlisb46be812015-10-23 16:00:08 -0600969// Verify that given sampler is valid
970static VkBool32 validateSampler(const layer_data* my_data, const VkSampler* pSampler, const VkBool32 immutable)
971{
972 VkBool32 skipCall = VK_FALSE;
Chia-I Wue420a332015-10-26 20:04:44 +0800973 auto sampIt = my_data->sampleMap.find(*pSampler);
Tobin Ehlisb46be812015-10-23 16:00:08 -0600974 if (sampIt == my_data->sampleMap.end()) {
975 if (!immutable) {
Chia-I Wue420a332015-10-26 20:04:44 +0800976 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_SAMPLER, (uint64_t) *pSampler, 0, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS",
977 "vkUpdateDescriptorSets: Attempt to update descriptor with invalid sampler %#" PRIxLEAST64, (uint64_t) *pSampler);
Tobin Ehlisb46be812015-10-23 16:00:08 -0600978 } else { // immutable
Chia-I Wue420a332015-10-26 20:04:44 +0800979 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_SAMPLER, (uint64_t) *pSampler, 0, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS",
980 "vkUpdateDescriptorSets: Attempt to update descriptor whose binding has an invalid immutable sampler %#" PRIxLEAST64, (uint64_t) *pSampler);
Tobin Ehlisb46be812015-10-23 16:00:08 -0600981 }
982 } else {
983 // TODO : Any further checks we want to do on the sampler?
984 }
985 return skipCall;
986}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700987
Tobin Ehlisb46be812015-10-23 16:00:08 -0600988// Verify that given imageView is valid
989static VkBool32 validateImageView(const layer_data* my_data, const VkImageView* pImageView, const VkImageLayout imageLayout)
990{
991 VkBool32 skipCall = VK_FALSE;
Chia-I Wue420a332015-10-26 20:04:44 +0800992 auto ivIt = my_data->imageViewMap.find(*pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -0600993 if (ivIt == my_data->imageViewMap.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +0800994 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE_VIEW, (uint64_t) *pImageView, 0, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS",
995 "vkUpdateDescriptorSets: Attempt to update descriptor with invalid imageView %#" PRIxLEAST64, (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -0600996 } else {
997 // Validate that imageLayout is compatible with aspectMask and image format
998 VkImageAspectFlags aspectMask = ivIt->second->subresourceRange.aspectMask;
Chia-I Wue420a332015-10-26 20:04:44 +0800999 VkImage image = ivIt->second->image;
Michael Lentineee4ad4d2015-10-23 12:41:44 -07001000 // TODO : Check here in case we have a bad image
Chia-I Wue420a332015-10-26 20:04:44 +08001001 auto imgIt = my_data->imageMap.find(image);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001002 if (imgIt == my_data->imageMap.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +08001003 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE, (uint64_t) image, 0, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS",
Michael Lentineee4ad4d2015-10-23 12:41:44 -07001004 "vkUpdateDescriptorSets: Attempt to update descriptor with invalid image %#" PRIxLEAST64 " in imageView %#" PRIxLEAST64, (uint64_t) image, (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001005 } else {
1006 VkFormat format = (*imgIt).second->format;
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07001007 VkBool32 ds = vk_format_is_depth_or_stencil(format);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001008 switch (imageLayout) {
1009 case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL:
1010 // Only Color bit must be set
1011 if ((aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) != VK_IMAGE_ASPECT_COLOR_BIT) {
Chia-I Wue420a332015-10-26 20:04:44 +08001012 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE_VIEW, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001013 DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL and imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001014 " that does not have VK_IMAGE_ASPECT_COLOR_BIT set.", (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001015 }
1016 // format must NOT be DS
1017 if (ds) {
Chia-I Wue420a332015-10-26 20:04:44 +08001018 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE_VIEW, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001019 DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL and imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001020 " but the image format is %s which is not a color format.", (uint64_t) *pImageView, string_VkFormat(format));
Tobin Ehlisb46be812015-10-23 16:00:08 -06001021 }
1022 break;
1023 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL:
1024 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL:
1025 // Depth or stencil bit must be set, but both must NOT be set
1026 if (aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) {
1027 if (aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT) {
1028 // both must NOT be set
Chia-I Wue420a332015-10-26 20:04:44 +08001029 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE_VIEW, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001030 DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", "vkUpdateDescriptorSets: Updating descriptor with imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001031 " that has both STENCIL and DEPTH aspects set", (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001032 }
1033 } else if (!(aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT)) {
1034 // Neither were set
Chia-I Wue420a332015-10-26 20:04:44 +08001035 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE_VIEW, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001036 DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001037 " that does not have STENCIL or DEPTH aspect set.", string_VkImageLayout(imageLayout), (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001038 }
1039 // format must be DS
1040 if (!ds) {
Chia-I Wue420a332015-10-26 20:04:44 +08001041 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_IMAGE_VIEW, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001042 DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001043 " but the image format is %s which is not a depth/stencil format.", string_VkImageLayout(imageLayout), (uint64_t) *pImageView, string_VkFormat(format));
Tobin Ehlisb46be812015-10-23 16:00:08 -06001044 }
1045 break;
1046 default:
1047 // anything to check for other layouts?
1048 break;
1049 }
1050 }
1051 }
1052 return skipCall;
1053}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001054
Tobin Ehlisb46be812015-10-23 16:00:08 -06001055// Verify that given bufferView is valid
1056static VkBool32 validateBufferView(const layer_data* my_data, const VkBufferView* pBufferView)
1057{
1058 VkBool32 skipCall = VK_FALSE;
Chia-I Wue420a332015-10-26 20:04:44 +08001059 auto sampIt = my_data->bufferViewMap.find(*pBufferView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001060 if (sampIt == my_data->bufferViewMap.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +08001061 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_BUFFER_VIEW, (uint64_t) *pBufferView, 0, DRAWSTATE_BUFFERVIEW_DESCRIPTOR_ERROR, "DS",
1062 "vkUpdateDescriptorSets: Attempt to update descriptor with invalid bufferView %#" PRIxLEAST64, (uint64_t) *pBufferView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001063 } else {
1064 // TODO : Any further checks we want to do on the bufferView?
1065 }
1066 return skipCall;
1067}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001068
Tobin Ehlisb46be812015-10-23 16:00:08 -06001069// Verify that given bufferInfo is valid
1070static VkBool32 validateBufferInfo(const layer_data* my_data, const VkDescriptorBufferInfo* pBufferInfo)
1071{
1072 VkBool32 skipCall = VK_FALSE;
Chia-I Wue420a332015-10-26 20:04:44 +08001073 auto sampIt = my_data->bufferMap.find(pBufferInfo->buffer);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001074 if (sampIt == my_data->bufferMap.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +08001075 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_BUFFER, (uint64_t) pBufferInfo->buffer, 0, DRAWSTATE_BUFFERINFO_DESCRIPTOR_ERROR, "DS",
1076 "vkUpdateDescriptorSets: Attempt to update descriptor where bufferInfo has invalid buffer %#" PRIxLEAST64, (uint64_t) pBufferInfo->buffer);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001077 } else {
1078 // TODO : Any further checks we want to do on the bufferView?
1079 }
1080 return skipCall;
1081}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001082
Tobin Ehlisb46be812015-10-23 16:00:08 -06001083static VkBool32 validateUpdateContents(const layer_data* my_data, const VkWriteDescriptorSet *pWDS, const VkDescriptorSetLayoutBinding* pLayoutBinding)
1084{
1085 VkBool32 skipCall = VK_FALSE;
1086 // First verify that for the given Descriptor type, the correct DescriptorInfo data is supplied
1087 VkBufferView* pBufferView = NULL;
1088 const VkSampler* pSampler = NULL;
1089 VkImageView* pImageView = NULL;
1090 VkImageLayout* pImageLayout = NULL;
1091 VkDescriptorBufferInfo* pBufferInfo = NULL;
1092 VkBool32 immutable = VK_FALSE;
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001093 uint32_t i = 0;
1094 // For given update type, verify that update contents are correct
1095 switch (pWDS->descriptorType) {
1096 case VK_DESCRIPTOR_TYPE_SAMPLER:
Chia-I Wu763a7492015-10-26 20:48:51 +08001097 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001098 skipCall |= validateSampler(my_data, &(pWDS->pImageInfo[i].sampler), immutable);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001099 }
1100 break;
1101 case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
Chia-I Wu763a7492015-10-26 20:48:51 +08001102 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001103 if (NULL == pLayoutBinding->pImmutableSamplers) {
1104 pSampler = &(pWDS->pImageInfo[i].sampler);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001105 if (immutable) {
Chia-I Wue420a332015-10-26 20:04:44 +08001106 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_SAMPLER, (uint64_t) *pSampler, 0, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS",
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001107 "vkUpdateDescriptorSets: Update #%u is not an immutable sampler %#" PRIxLEAST64 ", but previous update(s) from this "
1108 "VkWriteDescriptorSet struct used an immutable sampler. All updates from a single struct must either "
Chia-I Wue420a332015-10-26 20:04:44 +08001109 "use immutable or non-immutable samplers.", i, (uint64_t) *pSampler);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001110 }
Tobin Ehlisb46be812015-10-23 16:00:08 -06001111 } else {
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001112 if (i>0 && !immutable) {
Chia-I Wue420a332015-10-26 20:04:44 +08001113 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_SAMPLER, (uint64_t) *pSampler, 0, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS",
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001114 "vkUpdateDescriptorSets: Update #%u is an immutable sampler, but previous update(s) from this "
1115 "VkWriteDescriptorSet struct used a non-immutable sampler. All updates from a single struct must either "
1116 "use immutable or non-immutable samplers.", i);
1117 }
Tobin Ehlisb46be812015-10-23 16:00:08 -06001118 immutable = VK_TRUE;
1119 pSampler = &(pLayoutBinding->pImmutableSamplers[i]);
1120 }
1121 skipCall |= validateSampler(my_data, pSampler, immutable);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001122 }
1123 // Intentionally fall through here to also validate image stuff
1124 case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
1125 case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
1126 case VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT:
Chia-I Wu763a7492015-10-26 20:48:51 +08001127 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001128 skipCall |= validateImageView(my_data, &(pWDS->pImageInfo[i].imageView), pWDS->pImageInfo[i].imageLayout);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001129 }
1130 break;
1131 case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
1132 case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
Chia-I Wu763a7492015-10-26 20:48:51 +08001133 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001134 skipCall |= validateBufferView(my_data, &(pWDS->pTexelBufferView[i]));
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001135 }
1136 break;
1137 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER:
1138 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER:
1139 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
1140 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
Chia-I Wu763a7492015-10-26 20:48:51 +08001141 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001142 skipCall |= validateBufferInfo(my_data, &(pWDS->pBufferInfo[i]));
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001143 }
1144 break;
Tobin Ehlisb46be812015-10-23 16:00:08 -06001145 }
1146 return skipCall;
1147}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001148
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001149// update DS mappings based on write and copy update arrays
Chia-I Wu483e7702015-10-26 17:20:32 +08001150static VkBool32 dsUpdate(layer_data* my_data, VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet* pWDS, uint32_t descriptorCopyCount, const VkCopyDescriptorSet* pCDS)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001151{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001152 VkBool32 skipCall = VK_FALSE;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001153
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001154 loader_platform_thread_lock_mutex(&globalLock);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001155 LAYOUT_NODE* pLayout = NULL;
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06001156 VkDescriptorSetLayoutCreateInfo* pLayoutCI = NULL;
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001157 // Validate Write updates
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001158 uint32_t i = 0;
Chia-I Wu483e7702015-10-26 17:20:32 +08001159 for (i=0; i < descriptorWriteCount; i++) {
Chia-I Wu1f851912015-10-27 18:04:07 +08001160 VkDescriptorSet ds = pWDS[i].dstSet;
Chia-I Wue420a332015-10-26 20:04:44 +08001161 SET_NODE* pSet = my_data->setMap[ds];
Tobin Ehlisb46be812015-10-23 16:00:08 -06001162 GENERIC_HEADER* pUpdate = (GENERIC_HEADER*) &pWDS[i];
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001163 pLayout = pSet->pLayout;
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06001164 // First verify valid update struct
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001165 if ((skipCall = validUpdateStruct(my_data, device, pUpdate)) == VK_TRUE) {
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06001166 break;
1167 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001168 uint32_t binding = 0, endIndex = 0;
Chia-I Wu1f851912015-10-27 18:04:07 +08001169 binding = pWDS[i].dstBinding;
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001170 // Make sure that layout being updated has the binding being updated
Chia-I Wub5689ee2015-10-31 00:31:16 +08001171 if (pLayout->bindings.find(binding) == pLayout->bindings.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +08001172 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) ds, 0, DRAWSTATE_INVALID_UPDATE_INDEX, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001173 "Descriptor Set %" PRIu64 " does not have binding to match update binding %u for update type %s!", reinterpret_cast<uint64_t>(ds), binding, string_VkStructureType(pUpdate->sType));
Tobin Ehlise42007c2015-06-19 13:00:59 -06001174 } else {
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001175 // Next verify that update falls within size of given binding
Chia-I Wu1f851912015-10-27 18:04:07 +08001176 endIndex = getUpdateEndIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001177 if (getBindingEndIndex(pLayout, binding) < endIndex) {
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001178 pLayoutCI = &pLayout->createInfo;
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06001179 string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} ");
Chia-I Wue420a332015-10-26 20:04:44 +08001180 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) ds, 0, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS",
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001181 "Descriptor update type of %s is out of bounds for matching binding %u in Layout w/ CI:\n%s!", string_VkStructureType(pUpdate->sType), binding, DSstr.c_str());
Tobin Ehlise42007c2015-06-19 13:00:59 -06001182 } else { // TODO : should we skip update on a type mismatch or force it?
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001183 uint32_t startIndex;
Chia-I Wu1f851912015-10-27 18:04:07 +08001184 startIndex = getUpdateStartIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001185 // Layout bindings match w/ update, now verify that update type & stageFlags are the same for entire update
1186 if ((skipCall = validateUpdateConsistency(my_data, device, pLayout, pUpdate, startIndex, endIndex)) == VK_FALSE) {
1187 // The update is within bounds and consistent, but need to make sure contents make sense as well
Chia-I Wuf03cbf72015-10-31 00:31:16 +08001188 if ((skipCall = validateUpdateContents(my_data, &pWDS[i], &pLayout->createInfo.pBinding[binding])) == VK_FALSE) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001189 // Update is good. Save the update info
1190 // Create new update struct for this set's shadow copy
1191 GENERIC_HEADER* pNewNode = NULL;
1192 skipCall |= shadowUpdateNode(my_data, device, pUpdate, &pNewNode);
1193 if (NULL == pNewNode) {
Chia-I Wue420a332015-10-26 20:04:44 +08001194 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) ds, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Tobin Ehlisb46be812015-10-23 16:00:08 -06001195 "Out of memory while attempting to allocate UPDATE struct in vkUpdateDescriptors()");
1196 } else {
1197 // Insert shadow node into LL of updates for this set
1198 pNewNode->pNext = pSet->pUpdateStructs;
1199 pSet->pUpdateStructs = pNewNode;
1200 // Now update appropriate descriptor(s) to point to new Update node
Tobin Ehlisb46be812015-10-23 16:00:08 -06001201 for (uint32_t j = startIndex; j <= endIndex; j++) {
1202 assert(j<pSet->descriptorCount);
1203 pSet->ppDescriptors[j] = pNewNode;
1204 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001205 }
1206 }
1207 }
1208 }
1209 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001210 }
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001211 // Now validate copy updates
Chia-I Wu483e7702015-10-26 17:20:32 +08001212 for (i=0; i < descriptorCopyCount; ++i) {
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001213 SET_NODE *pSrcSet = NULL, *pDstSet = NULL;
1214 LAYOUT_NODE *pSrcLayout = NULL, *pDstLayout = NULL;
1215 uint32_t srcStartIndex = 0, srcEndIndex = 0, dstStartIndex = 0, dstEndIndex = 0;
1216 // For each copy make sure that update falls within given layout and that types match
Chia-I Wue420a332015-10-26 20:04:44 +08001217 pSrcSet = my_data->setMap[pCDS[i].srcSet];
Chia-I Wu1f851912015-10-27 18:04:07 +08001218 pDstSet = my_data->setMap[pCDS[i].dstSet];
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001219 pSrcLayout = pSrcSet->pLayout;
1220 pDstLayout = pDstSet->pLayout;
1221 // Validate that src binding is valid for src set layout
Chia-I Wub5689ee2015-10-31 00:31:16 +08001222 if (pSrcLayout->bindings.find(pCDS[i].srcBinding) == pSrcLayout->bindings.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +08001223 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pSrcSet->set, 0, DRAWSTATE_INVALID_UPDATE_INDEX, "DS",
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001224 "Copy descriptor update %u has srcBinding %u which is out of bounds for underlying SetLayout %#" PRIxLEAST64 " which only has bindings 0-%u.",
Chia-I Wu763a7492015-10-26 20:48:51 +08001225 i, pCDS[i].srcBinding, (uint64_t) pSrcLayout->layout, pSrcLayout->createInfo.bindingCount-1);
Chia-I Wub5689ee2015-10-31 00:31:16 +08001226 } else if (pDstLayout->bindings.find(pCDS[i].dstBinding) == pDstLayout->bindings.end()) {
Chia-I Wue420a332015-10-26 20:04:44 +08001227 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDstSet->set, 0, DRAWSTATE_INVALID_UPDATE_INDEX, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08001228 "Copy descriptor update %u has dstBinding %u which is out of bounds for underlying SetLayout %#" PRIxLEAST64 " which only has bindings 0-%u.",
1229 i, pCDS[i].dstBinding, (uint64_t) pDstLayout->layout, pDstLayout->createInfo.bindingCount-1);
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001230 } else {
1231 // Proceed with validation. Bindings are ok, but make sure update is within bounds of given layout
1232 srcEndIndex = getUpdateEndIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, (const GENERIC_HEADER*)&(pCDS[i]));
Chia-I Wu1f851912015-10-27 18:04:07 +08001233 dstEndIndex = getUpdateEndIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, (const GENERIC_HEADER*)&(pCDS[i]));
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001234 if (getBindingEndIndex(pSrcLayout, pCDS[i].srcBinding) < srcEndIndex) {
1235 pLayoutCI = &pSrcLayout->createInfo;
1236 string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} ");
Chia-I Wue420a332015-10-26 20:04:44 +08001237 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pSrcSet->set, 0, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS",
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001238 "Copy descriptor src update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", pCDS[i].srcBinding, DSstr.c_str());
Chia-I Wu1f851912015-10-27 18:04:07 +08001239 } else if (getBindingEndIndex(pDstLayout, pCDS[i].dstBinding) < dstEndIndex) {
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001240 pLayoutCI = &pDstLayout->createInfo;
1241 string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} ");
Chia-I Wue420a332015-10-26 20:04:44 +08001242 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDstSet->set, 0, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08001243 "Copy descriptor dest update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", pCDS[i].dstBinding, DSstr.c_str());
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001244 } else {
1245 srcStartIndex = getUpdateStartIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, (const GENERIC_HEADER*)&(pCDS[i]));
Chia-I Wu1f851912015-10-27 18:04:07 +08001246 dstStartIndex = getUpdateStartIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, (const GENERIC_HEADER*)&(pCDS[i]));
Chia-I Wu763a7492015-10-26 20:48:51 +08001247 for (uint32_t j=0; j<pCDS[i].descriptorCount; ++j) {
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001248 // For copy just make sure that the types match and then perform the update
1249 if (pSrcLayout->descriptorTypes[srcStartIndex+j] != pDstLayout->descriptorTypes[dstStartIndex+j]) {
1250 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS",
1251 "Copy descriptor update index %u, update count #%u, has src update descriptor type %s that does not match overlapping dest descriptor type of %s!",
1252 i, j+1, string_VkDescriptorType(pSrcLayout->descriptorTypes[srcStartIndex+j]), string_VkDescriptorType(pDstLayout->descriptorTypes[dstStartIndex+j]));
1253 } else {
1254 // point dst descriptor at corresponding src descriptor
1255 pDstSet->ppDescriptors[j+dstStartIndex] = pSrcSet->ppDescriptors[j+srcStartIndex];
1256 }
1257 }
1258 }
1259 }
1260 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001261 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001262 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001263}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001264
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001265// Verify that given pool has descriptors that are being requested for allocation
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001266static VkBool32 validate_descriptor_availability_in_pool(layer_data* dev_data, DESCRIPTOR_POOL_NODE* pPoolNode, uint32_t count, const VkDescriptorSetLayout* pSetLayouts)
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001267{
1268 VkBool32 skipCall = VK_FALSE;
1269 uint32_t i = 0, j = 0;
1270 for (i=0; i<count; ++i) {
1271 LAYOUT_NODE* pLayout = getLayoutNode(dev_data, pSetLayouts[i]);
1272 if (NULL == pLayout) {
Chia-I Wue420a332015-10-26 20:04:44 +08001273 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT, (uint64_t) pSetLayouts[i], 0, DRAWSTATE_INVALID_LAYOUT, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08001274 "Unable to find set layout node for layout %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", (uint64_t) pSetLayouts[i]);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001275 } else {
Chia-I Wuc51b1212015-10-27 19:25:11 +08001276 uint32_t typeIndex = 0, poolSizeCount = 0;
Chia-I Wu763a7492015-10-26 20:48:51 +08001277 for (j=0; j<pLayout->createInfo.bindingCount; ++j) {
Chia-I Wuf03cbf72015-10-31 00:31:16 +08001278 typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBinding[j].descriptorType);
Chia-I Wu045654f2015-11-06 06:42:02 +08001279 poolSizeCount = pLayout->createInfo.pBinding[j].descriptorCount;
Chia-I Wuc51b1212015-10-27 19:25:11 +08001280 if (poolSizeCount > pPoolNode->availableDescriptorTypeCount[typeIndex]) {
Chia-I Wue420a332015-10-26 20:04:44 +08001281 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT, (uint64_t) pLayout->layout, 0, DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS",
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001282 "Unable to allocate %u descriptors of type %s from pool %#" PRIxLEAST64 ". This pool only has %u descriptors of this type remaining.",
Chia-I Wuf03cbf72015-10-31 00:31:16 +08001283 poolSizeCount, string_VkDescriptorType(pLayout->createInfo.pBinding[j].descriptorType), (uint64_t) pPoolNode->pool, pPoolNode->availableDescriptorTypeCount[typeIndex]);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001284 } else { // Decrement available descriptors of this type
Chia-I Wuc51b1212015-10-27 19:25:11 +08001285 pPoolNode->availableDescriptorTypeCount[typeIndex] -= poolSizeCount;
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001286 }
1287 }
1288 }
1289 }
1290 return skipCall;
1291}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001292
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001293// Free the shadowed update node for this Set
1294// NOTE : Calls to this function should be wrapped in mutex
1295static void freeShadowUpdateTree(SET_NODE* pSet)
1296{
1297 GENERIC_HEADER* pShadowUpdate = pSet->pUpdateStructs;
1298 pSet->pUpdateStructs = NULL;
1299 GENERIC_HEADER* pFreeUpdate = pShadowUpdate;
1300 // Clear the descriptor mappings as they will now be invalid
1301 memset(pSet->ppDescriptors, 0, pSet->descriptorCount*sizeof(GENERIC_HEADER*));
1302 while(pShadowUpdate) {
1303 pFreeUpdate = pShadowUpdate;
1304 pShadowUpdate = (GENERIC_HEADER*)pShadowUpdate->pNext;
1305 uint32_t index = 0;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001306 VkWriteDescriptorSet * pWDS = NULL;
1307 VkCopyDescriptorSet * pCDS = NULL;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001308 void** ppToFree = NULL;
1309 switch (pFreeUpdate->sType)
1310 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001311 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
1312 pWDS = (VkWriteDescriptorSet*)pFreeUpdate;
Tony Barbourf740f902015-11-02 11:46:29 -07001313 switch (pWDS->descriptorType) {
1314 case VK_DESCRIPTOR_TYPE_SAMPLER:
1315 case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
1316 case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
1317 case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
1318 {
1319 delete[] pWDS->pImageInfo;
1320 }
1321 break;
1322 case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
1323 case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
1324 {
1325 delete[] pWDS->pTexelBufferView;
1326 }
1327 break;
1328 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER:
1329 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER:
1330 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
1331 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
1332 {
1333 delete[] pWDS->pBufferInfo;
1334 }
1335 break;
1336 default:
1337 break;
Courtney Goeltzenleuchtere4099742015-10-22 15:31:56 -06001338 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001339 break;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001340 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001341 break;
1342 default:
1343 assert(0);
1344 break;
1345 }
Tobin Ehliseaf28662015-04-08 10:58:37 -06001346 delete pFreeUpdate;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001347 }
1348}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001349
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001350// Free all DS Pools including their Sets & related sub-structs
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001351// NOTE : Calls to this function should be wrapped in mutex
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001352static void deletePools(layer_data* my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001353{
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001354 if (my_data->descriptorPoolMap.size() <= 0)
David Pinedof5997ab2015-04-27 16:36:17 -06001355 return;
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001356 for (auto ii=my_data->descriptorPoolMap.begin(); ii!=my_data->descriptorPoolMap.end(); ++ii) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001357 SET_NODE* pSet = (*ii).second->pSets;
1358 SET_NODE* pFreeSet = pSet;
1359 while (pSet) {
1360 pFreeSet = pSet;
1361 pSet = pSet->pNext;
Tobin Ehliseaf28662015-04-08 10:58:37 -06001362 // Freeing layouts handled in deleteLayouts() function
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001363 // Free Update shadow struct tree
1364 freeShadowUpdateTree(pFreeSet);
1365 if (pFreeSet->ppDescriptors) {
Chris Forbes4506d3f2015-06-04 10:49:27 +12001366 delete[] pFreeSet->ppDescriptors;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001367 }
1368 delete pFreeSet;
1369 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001370 delete (*ii).second;
1371 }
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001372 my_data->descriptorPoolMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001373}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001374
Tobin Ehliseaf28662015-04-08 10:58:37 -06001375// WARN : Once deleteLayouts() called, any layout ptrs in Pool/Set data structure will be invalid
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001376// NOTE : Calls to this function should be wrapped in mutex
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001377static void deleteLayouts(layer_data* my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001378{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001379 if (my_data->layoutMap.size() <= 0)
David Pinedof5997ab2015-04-27 16:36:17 -06001380 return;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001381 for (auto ii=my_data->layoutMap.begin(); ii!=my_data->layoutMap.end(); ++ii) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001382 LAYOUT_NODE* pLayout = (*ii).second;
Chia-I Wuf03cbf72015-10-31 00:31:16 +08001383 if (pLayout->createInfo.pBinding) {
Chia-I Wu763a7492015-10-26 20:48:51 +08001384 for (uint32_t i=0; i<pLayout->createInfo.bindingCount; i++) {
Chia-I Wuf03cbf72015-10-31 00:31:16 +08001385 if (pLayout->createInfo.pBinding[i].pImmutableSamplers)
1386 delete[] pLayout->createInfo.pBinding[i].pImmutableSamplers;
Tobin Ehliseaf28662015-04-08 10:58:37 -06001387 }
Chia-I Wuf03cbf72015-10-31 00:31:16 +08001388 delete[] pLayout->createInfo.pBinding;
Tobin Ehliseaf28662015-04-08 10:58:37 -06001389 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001390 delete pLayout;
1391 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001392 my_data->layoutMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001393}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001394
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001395// Currently clearing a set is removing all previous updates to that set
1396// TODO : Validate if this is correct clearing behavior
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001397static void clearDescriptorSet(layer_data* my_data, VkDescriptorSet set)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001398{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001399 SET_NODE* pSet = getSetNode(my_data, set);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001400 if (!pSet) {
1401 // TODO : Return error
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001402 } else {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001403 loader_platform_thread_lock_mutex(&globalLock);
1404 freeShadowUpdateTree(pSet);
1405 loader_platform_thread_unlock_mutex(&globalLock);
1406 }
1407}
1408
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06001409static void clearDescriptorPool(layer_data* my_data, const VkDevice device, const VkDescriptorPool pool, VkDescriptorPoolResetFlags flags)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001410{
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001411 DESCRIPTOR_POOL_NODE* pPool = getPoolNode(my_data, pool);
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001412 if (!pPool) {
Chia-I Wue420a332015-10-26 20:04:44 +08001413 log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_POOL, (uint64_t) pool, 0, DRAWSTATE_INVALID_POOL, "DS",
1414 "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkResetDescriptorPool() call", (uint64_t) pool);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001415 } else {
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06001416 // TODO: validate flags
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001417 // For every set off of this pool, clear it
1418 SET_NODE* pSet = pPool->pSets;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001419 while (pSet) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001420 clearDescriptorSet(my_data, pSet->set);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001421 }
Tobin Ehlisc6457d22015-10-20 16:16:04 -06001422 // Reset available count to max count for this pool
1423 for (uint32_t i=0; i<pPool->availableDescriptorTypeCount.size(); ++i) {
1424 pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i];
1425 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001426 }
1427}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001428
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001429// For given CB object, fetch associated CB Node from map
Chia-I Wu1f851912015-10-27 18:04:07 +08001430static GLOBAL_CB_NODE* getCBNode(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001431{
1432 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinski13b66742015-11-20 14:33:48 -07001433 if (my_data->commandBufferMap.count(cb) == 0) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001434 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06001435 // TODO : How to pass cb as srcObj here?
Chia-I Wu1f851912015-10-27 18:04:07 +08001436 log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
1437 "Attempt to use CommandBuffer %#" PRIxLEAST64 " that doesn't exist!", reinterpret_cast<uint64_t>(cb));
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001438 return NULL;
1439 }
1440 loader_platform_thread_unlock_mutex(&globalLock);
Chia-I Wu1f851912015-10-27 18:04:07 +08001441 return my_data->commandBufferMap[cb];
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001442}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001443
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001444// Free all CB Nodes
1445// NOTE : Calls to this function should be wrapped in mutex
Chia-I Wu1f851912015-10-27 18:04:07 +08001446static void deleteCommandBuffers(layer_data* my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001447{
Mark Lobodzinski13b66742015-11-20 14:33:48 -07001448 if (my_data->commandBufferMap.size() <= 0) {
David Pinedof5997ab2015-04-27 16:36:17 -06001449 return;
Mark Lobodzinski13b66742015-11-20 14:33:48 -07001450 }
Chia-I Wu1f851912015-10-27 18:04:07 +08001451 for (auto ii=my_data->commandBufferMap.begin(); ii!=my_data->commandBufferMap.end(); ++ii) {
Courtney Goeltzenleuchter09098a72015-04-27 15:04:43 -06001452 vector<CMD_NODE*> cmd_node_list = (*ii).second->pCmds;
1453 while (!cmd_node_list.empty()) {
1454 CMD_NODE* cmd_node = cmd_node_list.back();
1455 delete cmd_node;
1456 cmd_node_list.pop_back();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001457 }
1458 delete (*ii).second;
1459 }
Chia-I Wu1f851912015-10-27 18:04:07 +08001460 my_data->commandBufferMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001461}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001462
Chia-I Wu1f851912015-10-27 18:04:07 +08001463static VkBool32 report_error_no_cb_begin(const layer_data* dev_data, const VkCommandBuffer cb, const char* caller_name)
Tobin Ehlise42007c2015-06-19 13:00:59 -06001464{
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06001465 // TODO : How to pass cb as srcObj here?
Chia-I Wu1f851912015-10-27 18:04:07 +08001466 return log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001467 "You must call vkBeginCommandBuffer() before this call to %s", caller_name);
Tobin Ehlise42007c2015-06-19 13:00:59 -06001468}
Michael Lentine2b9eda42015-10-28 15:55:18 -07001469
1470bool validateCmdsInCmdBuffer(const layer_data* dev_data, const GLOBAL_CB_NODE* pCB, const CMD_TYPE cmd_type) {
1471 bool skip_call = false;
1472 for (auto cmd : pCB->pCmds) {
1473 if (cmd_type == CMD_EXECUTECOMMANDS && cmd->type != CMD_EXECUTECOMMANDS) {
1474 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
1475 "vkCmdExecuteCommands() cannot be called on a cmd buffer with exsiting commands.");
1476 }
1477 if (cmd_type != CMD_EXECUTECOMMANDS && cmd->type == CMD_EXECUTECOMMANDS) {
1478 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
1479 "Commands cannot be added to a cmd buffer with exsiting secondary commands.");
1480 }
1481 }
1482 return skip_call;
1483}
1484
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001485static VkBool32 addCmd(const layer_data* my_data, GLOBAL_CB_NODE* pCB, const CMD_TYPE cmd)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001486{
Michael Lentine2b9eda42015-10-28 15:55:18 -07001487 VkBool32 skipCall = validateCmdsInCmdBuffer(my_data, pCB, cmd);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001488 CMD_NODE* pCmd = new CMD_NODE;
1489 if (pCmd) {
1490 // init cmd node and append to end of cmd LL
1491 memset(pCmd, 0, sizeof(CMD_NODE));
1492 pCmd->cmdNumber = ++pCB->numCmds;
1493 pCmd->type = cmd;
1494 pCB->pCmds.push_back(pCmd);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001495 } else {
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06001496 // TODO : How to pass cb as srcObj here?
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001497 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08001498 "Out of memory while attempting to allocate new CMD_NODE for commandBuffer %#" PRIxLEAST64, reinterpret_cast<uint64_t>(pCB->commandBuffer));
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001499 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001500 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001501}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001502
Chia-I Wu1f851912015-10-27 18:04:07 +08001503static void resetCB(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001504{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001505 GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001506 if (pCB) {
Courtney Goeltzenleuchterf03711e2015-04-27 17:16:56 -06001507 vector<CMD_NODE*> cmd_list = pCB->pCmds;
1508 while (!cmd_list.empty()) {
1509 delete cmd_list.back();
1510 cmd_list.pop_back();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001511 }
Courtney Goeltzenleuchterf03711e2015-04-27 17:16:56 -06001512 pCB->pCmds.clear();
Tobin Ehlis0cea4082015-08-18 07:10:58 -06001513 // Reset CB state (need to save createInfo)
Chia-I Wu1f851912015-10-27 18:04:07 +08001514 VkCommandBufferAllocateInfo saveCBCI = pCB->createInfo;
Chia-I Wu1f851912015-10-27 18:04:07 +08001515 pCB->commandBuffer = cb;
Tobin Ehlis0cea4082015-08-18 07:10:58 -06001516 pCB->createInfo = saveCBCI;
Michael Lentine27b0f902015-10-12 11:30:14 -05001517 memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo));
1518 pCB->fence = 0;
1519 pCB->numCmds = 0;
1520 memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t));
1521 pCB->state = CB_NEW;
1522 pCB->submitCount = 0;
1523 pCB->status = 0;
1524 pCB->pCmds.clear();
1525 pCB->lastBoundPipeline = 0;
1526 pCB->viewports.clear();
1527 pCB->scissors.clear();
1528 pCB->lineWidth = 0;
1529 pCB->depthBiasConstantFactor = 0;
1530 pCB->depthBiasClamp = 0;
1531 pCB->depthBiasSlopeFactor = 0;
1532 memset(pCB->blendConstants, 0, 4 * sizeof(float));
1533 pCB->minDepthBounds = 0;
1534 pCB->maxDepthBounds = 0;
1535 memset(&pCB->front, 0, sizeof(stencil_data));
1536 memset(&pCB->back, 0, sizeof(stencil_data));
1537 pCB->lastBoundDescriptorSet = 0;
1538 pCB->lastBoundPipelineLayout = 0;
1539 pCB->activeRenderPass = 0;
1540 pCB->activeSubpass = 0;
1541 pCB->framebuffer = 0;
Michael Lentine27b0f902015-10-12 11:30:14 -05001542 pCB->boundDescriptorSets.clear();
1543 pCB->imageLayoutMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001544 pCB->lastVtxBinding = MAX_BINDING;
1545 }
1546}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001547
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001548// Set PSO-related status bits for CB, including dynamic state set via PSO
Tobin Ehlis97866202015-06-10 12:57:07 -06001549static void set_cb_pso_status(GLOBAL_CB_NODE* pCB, const PIPELINE_NODE* pPipe)
1550{
1551 for (uint32_t i = 0; i < pPipe->cbStateCI.attachmentCount; i++) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08001552 if (0 != pPipe->pAttachments[i].colorWriteMask) {
Tobin Ehlis97866202015-06-10 12:57:07 -06001553 pCB->status |= CBSTATUS_COLOR_BLEND_WRITE_ENABLE;
1554 }
1555 }
1556 if (pPipe->dsStateCI.depthWriteEnable) {
Cody Northrop2605cb02015-08-18 15:21:16 -06001557 pCB->status |= CBSTATUS_DEPTH_WRITE_ENABLE;
1558 }
Cody Northrop2605cb02015-08-18 15:21:16 -06001559 if (pPipe->dsStateCI.stencilTestEnable) {
1560 pCB->status |= CBSTATUS_STENCIL_TEST_ENABLE;
Tobin Ehlis97866202015-06-10 12:57:07 -06001561 }
Tobin Ehlisa88e2f52015-10-02 11:00:56 -06001562 // Account for any dynamic state not set via this PSO
1563 if (!pPipe->dynStateCI.dynamicStateCount) { // All state is static
1564 pCB->status = CBSTATUS_ALL;
1565 } else {
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001566 // First consider all state on
1567 // Then unset any state that's noted as dynamic in PSO
1568 // Finally OR that into CB statemask
1569 CBStatusFlags psoDynStateMask = CBSTATUS_ALL;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001570 for (uint32_t i=0; i < pPipe->dynStateCI.dynamicStateCount; i++) {
1571 switch (pPipe->dynStateCI.pDynamicStates[i]) {
1572 case VK_DYNAMIC_STATE_VIEWPORT:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001573 psoDynStateMask &= ~CBSTATUS_VIEWPORT_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001574 break;
1575 case VK_DYNAMIC_STATE_SCISSOR:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001576 psoDynStateMask &= ~CBSTATUS_SCISSOR_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001577 break;
1578 case VK_DYNAMIC_STATE_LINE_WIDTH:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001579 psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001580 break;
1581 case VK_DYNAMIC_STATE_DEPTH_BIAS:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001582 psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001583 break;
1584 case VK_DYNAMIC_STATE_BLEND_CONSTANTS:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001585 psoDynStateMask &= ~CBSTATUS_BLEND_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001586 break;
1587 case VK_DYNAMIC_STATE_DEPTH_BOUNDS:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001588 psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001589 break;
1590 case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001591 psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001592 break;
1593 case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001594 psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001595 break;
1596 case VK_DYNAMIC_STATE_STENCIL_REFERENCE:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001597 psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001598 break;
1599 default:
1600 // TODO : Flag error here
1601 break;
1602 }
1603 }
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06001604 pCB->status |= psoDynStateMask;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001605 }
Tobin Ehlis97866202015-06-10 12:57:07 -06001606}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001607
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001608// Print the last bound Gfx Pipeline
Chia-I Wu1f851912015-10-27 18:04:07 +08001609static VkBool32 printPipeline(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001610{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001611 VkBool32 skipCall = VK_FALSE;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001612 GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001613 if (pCB) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001614 PIPELINE_NODE *pPipeTrav = getPipeline(my_data, pCB->lastBoundPipeline);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001615 if (!pPipeTrav) {
1616 // nothing to print
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001617 } else {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001618 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001619 "%s", vk_print_vkgraphicspipelinecreateinfo(&pPipeTrav->graphicsPipelineCI, "{DS}").c_str());
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001620 }
1621 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001622 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001623}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001624
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001625// Print details of DS config to stdout
Chia-I Wu1f851912015-10-27 18:04:07 +08001626static VkBool32 printDSConfig(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001627{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001628 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001629 char ds_config_str[1024*256] = {0}; // TODO : Currently making this buffer HUGE w/o overrun protection. Need to be smarter, start smaller, and grow as needed.
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001630 GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb);
Tobin Ehlis7297f192015-06-09 08:39:32 -06001631 if (pCB && pCB->lastBoundDescriptorSet) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001632 SET_NODE* pSet = getSetNode(my_data, pCB->lastBoundDescriptorSet);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001633 DESCRIPTOR_POOL_NODE* pPool = getPoolNode(my_data, pSet->pool);
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001634 // Print out pool details
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001635 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001636 "Details for pool %#" PRIxLEAST64 ".", (uint64_t) pPool->pool);
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06001637 string poolStr = vk_print_vkdescriptorpoolcreateinfo(&pPool->createInfo, " ");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001638 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001639 "%s", poolStr.c_str());
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001640 // Print out set details
1641 char prefix[10];
1642 uint32_t index = 0;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001643 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001644 "Details for descriptor set %#" PRIxLEAST64 ".", (uint64_t) pSet->set);
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001645 LAYOUT_NODE* pLayout = pSet->pLayout;
1646 // Print layout details
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001647 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001648 "Layout #%u, (object %#" PRIxLEAST64 ") for DS %#" PRIxLEAST64 ".", index+1, reinterpret_cast<uint64_t>(pLayout->layout), reinterpret_cast<uint64_t>(pSet->set));
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001649 sprintf(prefix, " [L%u] ", index);
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06001650 string DSLstr = vk_print_vkdescriptorsetlayoutcreateinfo(&pLayout->createInfo, prefix).c_str();
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001651 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001652 "%s", DSLstr.c_str());
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001653 index++;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001654 GENERIC_HEADER* pUpdate = pSet->pUpdateStructs;
1655 if (pUpdate) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001656 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001657 "Update Chain [UC] for descriptor set %#" PRIxLEAST64 ":", (uint64_t) pSet->set);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001658 sprintf(prefix, " [UC] ");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001659 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001660 "%s", dynamic_display(pUpdate, prefix).c_str());
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001661 // TODO : If there is a "view" associated with this update, print CI for that view
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001662 } else {
Tobin Ehlis2bca8b02015-06-15 08:41:17 -06001663 if (0 != pSet->descriptorCount) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001664 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001665 "No Update Chain for descriptor set %#" PRIxLEAST64 " which has %u descriptors (vkUpdateDescriptors has not been called)", (uint64_t) pSet->set, pSet->descriptorCount);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001666 } else {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001667 skipCall |= log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001668 "FYI: No descriptors in descriptor set %#" PRIxLEAST64 ".", (uint64_t) pSet->set);
Tobin Ehlis2bca8b02015-06-15 08:41:17 -06001669 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001670 }
1671 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001672 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001673}
1674
Chia-I Wu1f851912015-10-27 18:04:07 +08001675static void printCB(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001676{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001677 GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb);
David Pinedof5997ab2015-04-27 16:36:17 -06001678 if (pCB && pCB->pCmds.size() > 0) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001679 log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NONE, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001680 "Cmds in CB %p", (void*)cb);
Courtney Goeltzenleuchtercf2a5362015-04-27 11:16:35 -06001681 vector<CMD_NODE*> pCmds = pCB->pCmds;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06001682 for (auto ii=pCmds.begin(); ii!=pCmds.end(); ++ii) {
1683 // TODO : Need to pass cb as srcObj here
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001684 log_msg(my_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001685 " CMD#%" PRIu64 ": %s", (*ii)->cmdNumber, cmdTypeToString((*ii)->type).c_str());
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001686 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06001687 } else {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001688 // Nothing to print
1689 }
1690}
1691
Chia-I Wu1f851912015-10-27 18:04:07 +08001692static VkBool32 synchAndPrintDSConfig(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001693{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001694 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001695 if (!(my_data->report_data->active_flags & VK_DBG_REPORT_INFO_BIT)) {
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001696 return skipCall;
Mike Stroyanfa2f2222015-08-12 17:11:28 -06001697 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001698 skipCall |= printDSConfig(my_data, cb);
1699 skipCall |= printPipeline(my_data, cb);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001700 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001701}
1702
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001703// Flags validation error if the associated call is made inside a render pass. The apiName
1704// routine should ONLY be called outside a render pass.
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001705static VkBool32 insideRenderPass(const layer_data* my_data, GLOBAL_CB_NODE *pCB, const char *apiName)
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001706{
1707 VkBool32 inside = VK_FALSE;
1708 if (pCB->activeRenderPass) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001709 inside = log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER,
Chia-I Wu1f851912015-10-27 18:04:07 +08001710 (uint64_t)pCB->commandBuffer, 0, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS",
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001711 "%s: It is invalid to issue this call inside an active render pass (%#" PRIxLEAST64 ")",
Chia-I Wue420a332015-10-26 20:04:44 +08001712 apiName, (uint64_t) pCB->activeRenderPass);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001713 }
1714 return inside;
1715}
1716
1717// Flags validation error if the associated call is made outside a render pass. The apiName
1718// routine should ONLY be called inside a render pass.
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001719static VkBool32 outsideRenderPass(const layer_data* my_data, GLOBAL_CB_NODE *pCB, const char *apiName)
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001720{
1721 VkBool32 outside = VK_FALSE;
1722 if (!pCB->activeRenderPass) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001723 outside = log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER,
Chia-I Wu1f851912015-10-27 18:04:07 +08001724 (uint64_t)pCB->commandBuffer, 0, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS",
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001725 "%s: This call must be issued inside an active render pass.", apiName);
1726 }
1727 return outside;
1728}
1729
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001730static void init_draw_state(layer_data *my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001731{
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001732 uint32_t report_flags = 0;
1733 uint32_t debug_action = 0;
1734 FILE *log_output = NULL;
1735 const char *option_str;
Courtney Goeltzenleuchter1781b1c2015-10-05 15:58:38 -06001736 VkDbgMsgCallback callback;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001737 // initialize DrawState options
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001738 report_flags = getLayerOptionFlags("DrawStateReportFlags", 0);
1739 getLayerOptionEnum("DrawStateDebugAction", (uint32_t *) &debug_action);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001740
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001741 if (debug_action & VK_DBG_LAYER_ACTION_LOG_MSG)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001742 {
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001743 option_str = getLayerOption("DrawStateLogFilename");
Tobin Ehlisb4b6e7c2015-09-15 09:55:54 -06001744 log_output = getLayerLogOutput(option_str, "DrawState");
Courtney Goeltzenleuchter1781b1c2015-10-05 15:58:38 -06001745 layer_create_msg_callback(my_data->report_data, report_flags, log_callback, (void *) log_output, &callback);
1746 my_data->logging_callback.push_back(callback);
1747 }
1748
1749 if (debug_action & VK_DBG_LAYER_ACTION_DEBUG_OUTPUT) {
1750 layer_create_msg_callback(my_data->report_data, report_flags, win32_debug_output_msg, NULL, &callback);
1751 my_data->logging_callback.push_back(callback);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001752 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001753
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001754 if (!globalLockInitialized)
1755 {
Mike Stroyand9dd0072015-08-18 15:56:18 -06001756 // This mutex may be deleted by vkDestroyInstance of last instance.
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001757 loader_platform_thread_create_mutex(&globalLock);
1758 globalLockInitialized = 1;
1759 }
1760}
1761
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001762VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(const VkInstanceCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkInstance* pInstance)
Courtney Goeltzenleuchter3c9f6ec2015-06-01 14:29:58 -06001763{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001764 layer_data *my_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map);
1765 VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table;
Chia-I Wu69f40122015-10-26 21:10:41 +08001766 VkResult result = pTable->CreateInstance(pCreateInfo, pAllocator, pInstance);
Courtney Goeltzenleuchter3c9f6ec2015-06-01 14:29:58 -06001767
1768 if (result == VK_SUCCESS) {
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001769 layer_data *my_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map);
1770 my_data->report_data = debug_report_create_instance(
1771 pTable,
1772 *pInstance,
Chia-I Wu763a7492015-10-26 20:48:51 +08001773 pCreateInfo->enabledExtensionNameCount,
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001774 pCreateInfo->ppEnabledExtensionNames);
Courtney Goeltzenleuchterf4a2eba2015-06-08 14:58:39 -06001775
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001776 init_draw_state(my_data);
Courtney Goeltzenleuchter3c9f6ec2015-06-01 14:29:58 -06001777 }
1778 return result;
1779}
1780
Jon Ashburne0fa2282015-05-20 09:00:28 -06001781/* hook DestroyInstance to remove tableInstanceMap entry */
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001782VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks* pAllocator)
Jon Ashburne0fa2282015-05-20 09:00:28 -06001783{
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001784 dispatch_key key = get_dispatch_key(instance);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001785 layer_data *my_data = get_my_data_ptr(key, layer_data_map);
1786 VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table;
Chia-I Wu69f40122015-10-26 21:10:41 +08001787 pTable->DestroyInstance(instance, pAllocator);
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001788
1789 // Clean up logging callback, if any
Courtney Goeltzenleuchter1781b1c2015-10-05 15:58:38 -06001790 while (my_data->logging_callback.size() > 0) {
1791 VkDbgMsgCallback callback = my_data->logging_callback.back();
1792 layer_destroy_msg_callback(my_data->report_data, callback);
1793 my_data->logging_callback.pop_back();
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001794 }
1795
Courtney Goeltzenleuchter2d034fd2015-06-28 13:01:17 -06001796 layer_debug_report_destroy_instance(my_data->report_data);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001797 delete my_data->instance_dispatch_table;
1798 layer_data_map.erase(key);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001799 // TODO : Potential race here with separate threads creating/destroying instance
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001800 if (layer_data_map.empty()) {
Mike Stroyand9dd0072015-08-18 15:56:18 -06001801 // Release mutex when destroying last instance.
1802 loader_platform_thread_delete_mutex(&globalLock);
1803 globalLockInitialized = 0;
1804 }
Jon Ashburne0fa2282015-05-20 09:00:28 -06001805}
1806
Jon Ashburnf0615e22015-05-25 14:11:37 -06001807static void createDeviceRegisterExtensions(const VkDeviceCreateInfo* pCreateInfo, VkDevice device)
1808{
Tony Barbour29b12062015-07-13 13:37:24 -06001809 uint32_t i;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001810 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
1811 dev_data->device_extensions.debug_marker_enabled = false;
Michael Lentine27b0f902015-10-12 11:30:14 -05001812 dev_data->device_extensions.wsi_enabled = false;
1813
1814
1815 VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table;
1816 PFN_vkGetDeviceProcAddr gpa = pDisp->GetDeviceProcAddr;
1817
1818 pDisp->GetSurfacePropertiesKHR = (PFN_vkGetSurfacePropertiesKHR) gpa(device, "vkGetSurfacePropertiesKHR");
1819 pDisp->GetSurfaceFormatsKHR = (PFN_vkGetSurfaceFormatsKHR) gpa(device, "vkGetSurfaceFormatsKHR");
1820 pDisp->GetSurfacePresentModesKHR = (PFN_vkGetSurfacePresentModesKHR) gpa(device, "vkGetSurfacePresentModesKHR");
1821 pDisp->CreateSwapchainKHR = (PFN_vkCreateSwapchainKHR) gpa(device, "vkCreateSwapchainKHR");
1822 pDisp->DestroySwapchainKHR = (PFN_vkDestroySwapchainKHR) gpa(device, "vkDestroySwapchainKHR");
1823 pDisp->GetSwapchainImagesKHR = (PFN_vkGetSwapchainImagesKHR) gpa(device, "vkGetSwapchainImagesKHR");
1824 pDisp->AcquireNextImageKHR = (PFN_vkAcquireNextImageKHR) gpa(device, "vkAcquireNextImageKHR");
1825 pDisp->QueuePresentKHR = (PFN_vkQueuePresentKHR) gpa(device, "vkQueuePresentKHR");
Jon Ashburnf0615e22015-05-25 14:11:37 -06001826
Chia-I Wu763a7492015-10-26 20:48:51 +08001827 for (i = 0; i < pCreateInfo->enabledExtensionNameCount; i++) {
Michael Lentine27b0f902015-10-12 11:30:14 -05001828 if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_EXT_KHR_DEVICE_SWAPCHAIN_EXTENSION_NAME) == 0) {
1829 dev_data->device_extensions.wsi_enabled = true;
1830 }
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001831 if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], DEBUG_MARKER_EXTENSION_NAME) == 0) {
Jon Ashburn6f8cd632015-06-01 09:37:38 -06001832 /* Found a matching extension name, mark it enabled and init dispatch table*/
1833 initDebugMarkerTable(device);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001834 dev_data->device_extensions.debug_marker_enabled = true;
Jon Ashburnf0615e22015-05-25 14:11:37 -06001835 }
Jon Ashburnf0615e22015-05-25 14:11:37 -06001836 }
1837}
1838
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001839VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDevice* pDevice)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001840{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001841 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08001842 VkResult result = dev_data->device_dispatch_table->CreateDevice(gpu, pCreateInfo, pAllocator, pDevice);
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001843 if (result == VK_SUCCESS) {
1844 layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), layer_data_map);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001845 dev_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice);
Jon Ashburn7e07faf2015-06-18 15:02:58 -06001846 createDeviceRegisterExtensions(pCreateInfo, *pDevice);
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001847 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001848 return result;
1849}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001850
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001851// prototype
1852static void deleteRenderPasses(layer_data*);
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001853VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001854{
Jeremy Hayesea1fef52015-06-19 11:37:38 -06001855 dispatch_key key = get_dispatch_key(device);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001856 layer_data* dev_data = get_my_data_ptr(key, layer_data_map);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001857 // Free all the memory
1858 loader_platform_thread_lock_mutex(&globalLock);
1859 deletePipelines(dev_data);
1860 deleteRenderPasses(dev_data);
Chia-I Wu1f851912015-10-27 18:04:07 +08001861 deleteCommandBuffers(dev_data);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001862 deletePools(dev_data);
1863 deleteLayouts(dev_data);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001864 dev_data->imageViewMap.clear();
1865 dev_data->imageMap.clear();
1866 dev_data->bufferViewMap.clear();
1867 dev_data->bufferMap.clear();
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001868 loader_platform_thread_unlock_mutex(&globalLock);
1869
Chia-I Wu69f40122015-10-26 21:10:41 +08001870 dev_data->device_dispatch_table->DestroyDevice(device, pAllocator);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001871 tableDebugMarkerMap.erase(key);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001872 delete dev_data->device_dispatch_table;
1873 layer_data_map.erase(key);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001874}
1875
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001876static const VkLayerProperties ds_global_layers[] = {
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -06001877 {
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -06001878 "DrawState",
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001879 VK_API_VERSION,
1880 VK_MAKE_VERSION(0, 1, 0),
1881 "Validation layer: DrawState",
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -06001882 }
Jon Ashburneb2728b2015-04-10 14:33:07 -06001883};
1884
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001885VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001886 const char *pLayerName,
1887 uint32_t *pCount,
1888 VkExtensionProperties* pProperties)
Jon Ashburneb2728b2015-04-10 14:33:07 -06001889{
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001890 /* DrawState does not have any global extensions */
1891 return util_GetExtensionProperties(0, NULL, pCount, pProperties);
1892}
Jon Ashburneb2728b2015-04-10 14:33:07 -06001893
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001894VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001895 uint32_t *pCount,
1896 VkLayerProperties* pProperties)
1897{
1898 return util_GetLayerProperties(ARRAY_SIZE(ds_global_layers),
1899 ds_global_layers,
1900 pCount, pProperties);
1901}
Jon Ashburneb2728b2015-04-10 14:33:07 -06001902
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001903static const VkExtensionProperties ds_device_extensions[] = {
1904 {
1905 DEBUG_MARKER_EXTENSION_NAME,
1906 VK_MAKE_VERSION(0, 1, 0),
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001907 }
1908};
1909
1910static const VkLayerProperties ds_device_layers[] = {
1911 {
1912 "DrawState",
1913 VK_API_VERSION,
1914 VK_MAKE_VERSION(0, 1, 0),
1915 "Validation layer: DrawState",
1916 }
1917};
1918
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001919VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001920 VkPhysicalDevice physicalDevice,
1921 const char* pLayerName,
1922 uint32_t* pCount,
1923 VkExtensionProperties* pProperties)
1924{
Jon Ashburnaff81ff2015-11-02 17:37:20 -07001925 if (pLayerName == NULL) {
1926 dispatch_key key = get_dispatch_key(physicalDevice);
1927 layer_data *my_data = get_my_data_ptr(key, layer_data_map);
1928 VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table;
1929 return pTable->EnumerateDeviceExtensionProperties(
1930 physicalDevice,
1931 NULL,
1932 pCount,
1933 pProperties);
1934 } else {
1935 return util_GetExtensionProperties(ARRAY_SIZE(ds_device_extensions),
1936 ds_device_extensions,
1937 pCount, pProperties);
1938 }
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001939}
1940
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001941VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06001942 VkPhysicalDevice physicalDevice,
1943 uint32_t* pCount,
1944 VkLayerProperties* pProperties)
1945{
1946 /* Mem tracker's physical device layers are the same as global */
1947 return util_GetLayerProperties(ARRAY_SIZE(ds_device_layers), ds_device_layers,
1948 pCount, pProperties);
Jon Ashburneb2728b2015-04-10 14:33:07 -06001949}
1950
Michael Lentine27b0f902015-10-12 11:30:14 -05001951bool ValidateCmdBufImageLayouts(VkCommandBuffer cmdBuffer) {
1952 bool skip_call = false;
1953 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
1954 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
1955 for (auto cb_image_data : pCB->imageLayoutMap) {
1956 auto image_data = dev_data->imageLayoutMap.find(cb_image_data.first);
1957 if (image_data == dev_data->imageLayoutMap.end()) {
1958 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08001959 "Cannot submit cmd buffer using deleted image %" PRIu64 ".", reinterpret_cast<uint64_t>(cb_image_data.first));
Michael Lentine27b0f902015-10-12 11:30:14 -05001960 } else {
1961 if (dev_data->imageLayoutMap[cb_image_data.first]->layout != cb_image_data.second.initialLayout) {
1962 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
1963 "Cannot submit cmd buffer using image with layout %d when first use is %d.", dev_data->imageLayoutMap[cb_image_data.first]->layout, cb_image_data.second.initialLayout);
1964 }
1965 dev_data->imageLayoutMap[cb_image_data.first]->layout = cb_image_data.second.layout;
1966 }
1967 }
1968 return skip_call;
1969}
1970
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08001971VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo* pSubmits, VkFence fence)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001972{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001973 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis28be0be2015-05-22 12:38:16 -06001974 GLOBAL_CB_NODE* pCB = NULL;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06001975 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map);
Courtney Goeltzenleuchter3ec31622015-10-20 18:04:07 -06001976 for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) {
Chia-I Wu483e7702015-10-26 17:20:32 +08001977 const VkSubmitInfo *submit = &pSubmits[submit_idx];
Chia-I Wu763a7492015-10-26 20:48:51 +08001978 for (uint32_t i=0; i < submit->commandBufferCount; i++) {
Michael Lentine27b0f902015-10-12 11:30:14 -05001979 skipCall |= ValidateCmdBufImageLayouts(submit->pCommandBuffers[i]);
Courtney Goeltzenleuchter3ec31622015-10-20 18:04:07 -06001980 // Validate that cmd buffers have been updated
1981 pCB = getCBNode(dev_data, submit->pCommandBuffers[i]);
1982 loader_platform_thread_lock_mutex(&globalLock);
1983 pCB->submitCount++; // increment submit count
Chia-I Wu1f851912015-10-27 18:04:07 +08001984 if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) {
1985 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05001986 "CB %#" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT set, but has been submitted %#" PRIxLEAST64 " times.",
1987 reinterpret_cast<uint64_t>(pCB->commandBuffer), pCB->submitCount);
Courtney Goeltzenleuchter3ec31622015-10-20 18:04:07 -06001988 }
1989 if (CB_UPDATE_COMPLETE != pCB->state) {
1990 // Flag error for using CB w/o vkEndCommandBuffer() called
1991 // TODO : How to pass cb as srcObj?
Chia-I Wu1f851912015-10-27 18:04:07 +08001992 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS",
1993 "You must call vkEndCommandBuffer() on CB %#" PRIxLEAST64 " before this call to vkQueueSubmit()!", reinterpret_cast<uint64_t>(pCB->commandBuffer));
Courtney Goeltzenleuchter3ec31622015-10-20 18:04:07 -06001994 loader_platform_thread_unlock_mutex(&globalLock);
1995 return VK_ERROR_VALIDATION_FAILED;
1996 }
Tobin Ehlise90b1712015-05-27 14:30:06 -06001997 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis28be0be2015-05-22 12:38:16 -06001998 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001999 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002000 if (VK_FALSE == skipCall)
Chia-I Wu483e7702015-10-26 17:20:32 +08002001 return dev_data->device_dispatch_table->QueueSubmit(queue, submitCount, pSubmits, fence);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002002 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002003}
2004
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002005VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002006{
Chia-I Wu69f40122015-10-26 21:10:41 +08002007 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyFence(device, fence, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002008 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002009}
2010
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002011VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002012{
Chia-I Wu69f40122015-10-26 21:10:41 +08002013 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySemaphore(device, semaphore, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002014 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002015}
2016
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002017VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002018{
Chia-I Wu69f40122015-10-26 21:10:41 +08002019 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyEvent(device, event, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002020 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002021}
2022
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002023VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002024{
Chia-I Wu69f40122015-10-26 21:10:41 +08002025 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyQueryPool(device, queryPool, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002026 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002027}
2028
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002029VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyBuffer(VkDevice device, VkBuffer buffer, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002030{
Tobin Ehlisb46be812015-10-23 16:00:08 -06002031 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002032 dev_data->device_dispatch_table->DestroyBuffer(device, buffer, pAllocator);
Chia-I Wue420a332015-10-26 20:04:44 +08002033 dev_data->bufferMap.erase(buffer);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002034}
2035
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002036VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002037{
Tobin Ehlisb46be812015-10-23 16:00:08 -06002038 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002039 dev_data->device_dispatch_table->DestroyBufferView(device, bufferView, pAllocator);
Chia-I Wue420a332015-10-26 20:04:44 +08002040 dev_data->bufferViewMap.erase(bufferView);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002041}
2042
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002043VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002044{
Tobin Ehlisb46be812015-10-23 16:00:08 -06002045 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002046 dev_data->device_dispatch_table->DestroyImage(device, image, pAllocator);
Chia-I Wue420a332015-10-26 20:04:44 +08002047 dev_data->imageMap.erase(image);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002048}
2049
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002050VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002051{
Chia-I Wu69f40122015-10-26 21:10:41 +08002052 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyImageView(device, imageView, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002053 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002054}
2055
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002056VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002057{
Chia-I Wu69f40122015-10-26 21:10:41 +08002058 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyShaderModule(device, shaderModule, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002059 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002060}
2061
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002062VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002063{
Chia-I Wu69f40122015-10-26 21:10:41 +08002064 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipeline(device, pipeline, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002065 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002066}
2067
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002068VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002069{
Chia-I Wu69f40122015-10-26 21:10:41 +08002070 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipelineLayout(device, pipelineLayout, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002071 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002072}
2073
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002074VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002075{
Chia-I Wu69f40122015-10-26 21:10:41 +08002076 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySampler(device, sampler, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002077 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002078}
2079
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002080VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002081{
Chia-I Wu69f40122015-10-26 21:10:41 +08002082 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002083 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002084}
2085
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002086VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002087{
Chia-I Wu69f40122015-10-26 21:10:41 +08002088 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyDescriptorPool(device, descriptorPool, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002089 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002090}
2091
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002092VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t count, const VkCommandBuffer *pCommandBuffers)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002093{
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002094 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
2095
2096 for (auto i = 0; i < count; i++) {
2097 // Delete CB information structure, and remove from commandBufferMap
2098 auto cb = dev_data->commandBufferMap.find(pCommandBuffers[i]);
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002099 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002100 if (cb != dev_data->commandBufferMap.end()) {
2101 delete (*cb).second;
2102 dev_data->commandBufferMap.erase(cb);
2103 }
2104
2105 // Remove commandBuffer reference from commandPoolMap
2106 dev_data->commandPoolMap[commandPool].remove(pCommandBuffers[i]);
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002107 loader_platform_thread_unlock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002108 }
2109
2110 dev_data->device_dispatch_table->FreeCommandBuffers(device, commandPool, count, pCommandBuffers);
2111}
2112
2113VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkCommandPool* pCommandPool)
2114{
2115 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
2116
2117 VkResult result = dev_data->device_dispatch_table->CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
2118
2119 if (VK_SUCCESS == result) {
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002120 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002121 dev_data->commandPoolMap[*pCommandPool];
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002122 loader_platform_thread_unlock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002123 }
2124 return result;
2125}
2126
2127VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks* pAllocator)
2128{
2129 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002130 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002131
2132 // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandPoolMap
2133 if (dev_data->commandPoolMap.find(commandPool) != dev_data->commandPoolMap.end()) {
2134 for (auto poolCb = dev_data->commandPoolMap[commandPool].begin(); poolCb != dev_data->commandPoolMap[commandPool].end();) {
2135 auto del_cb = dev_data->commandBufferMap.find(*poolCb);
2136 delete (*del_cb).second; // delete CB info structure
2137 dev_data->commandBufferMap.erase(del_cb); // Remove this command buffer from cbMap
2138 poolCb = dev_data->commandPoolMap[commandPool].erase(poolCb); // Remove CB reference from commandPoolMap's list
2139 }
2140 }
2141 dev_data->commandPoolMap.erase(commandPool);
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002142
2143 loader_platform_thread_unlock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002144 dev_data->device_dispatch_table->DestroyCommandPool(device, commandPool, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002145}
2146
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002147VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002148{
Chia-I Wu69f40122015-10-26 21:10:41 +08002149 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyFramebuffer(device, framebuffer, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002150 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002151}
2152
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002153VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002154{
Chia-I Wu69f40122015-10-26 21:10:41 +08002155 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyRenderPass(device, renderPass, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002156 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002157}
2158
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002159VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBuffer(VkDevice device, const VkBufferCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkBuffer* pBuffer)
Tobin Ehlisb46be812015-10-23 16:00:08 -06002160{
2161 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002162 VkResult result = dev_data->device_dispatch_table->CreateBuffer(device, pCreateInfo, pAllocator, pBuffer);
Tobin Ehlisb46be812015-10-23 16:00:08 -06002163 if (VK_SUCCESS == result) {
2164 loader_platform_thread_lock_mutex(&globalLock);
2165 // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid
Chia-I Wue420a332015-10-26 20:04:44 +08002166 dev_data->bufferMap[*pBuffer] = unique_ptr<VkBufferCreateInfo>(new VkBufferCreateInfo(*pCreateInfo));
Tobin Ehlisb46be812015-10-23 16:00:08 -06002167 loader_platform_thread_unlock_mutex(&globalLock);
2168 }
2169 return result;
2170}
2171
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002172VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBufferView(VkDevice device, const VkBufferViewCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkBufferView* pView)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002173{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002174 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002175 VkResult result = dev_data->device_dispatch_table->CreateBufferView(device, pCreateInfo, pAllocator, pView);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002176 if (VK_SUCCESS == result) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002177 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08002178 dev_data->bufferViewMap[*pView] = unique_ptr<VkBufferViewCreateInfo>(new VkBufferViewCreateInfo(*pCreateInfo));
Tobin Ehlisb46be812015-10-23 16:00:08 -06002179 loader_platform_thread_unlock_mutex(&globalLock);
2180 }
2181 return result;
2182}
2183
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002184VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImage(VkDevice device, const VkImageCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkImage* pImage)
Tobin Ehlisb46be812015-10-23 16:00:08 -06002185{
2186 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002187 VkResult result = dev_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage);
Tobin Ehlisb46be812015-10-23 16:00:08 -06002188 if (VK_SUCCESS == result) {
Michael Lentine27b0f902015-10-12 11:30:14 -05002189 IMAGE_NODE* image_node = new IMAGE_NODE;
2190 image_node->layout = pCreateInfo->initialLayout;
Tobin Ehlisb46be812015-10-23 16:00:08 -06002191 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08002192 dev_data->imageMap[*pImage] = unique_ptr<VkImageCreateInfo>(new VkImageCreateInfo(*pCreateInfo));
Michael Lentine27b0f902015-10-12 11:30:14 -05002193 dev_data->imageLayoutMap[*pImage] = image_node;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002194 loader_platform_thread_unlock_mutex(&globalLock);
2195 }
2196 return result;
2197}
2198
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002199VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImageView(VkDevice device, const VkImageViewCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkImageView* pView)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002200{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002201 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002202 VkResult result = dev_data->device_dispatch_table->CreateImageView(device, pCreateInfo, pAllocator, pView);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002203 if (VK_SUCCESS == result) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002204 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08002205 dev_data->imageViewMap[*pView] = unique_ptr<VkImageViewCreateInfo>(new VkImageViewCreateInfo(*pCreateInfo));
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06002206 loader_platform_thread_unlock_mutex(&globalLock);
2207 }
2208 return result;
2209}
2210
Jon Ashburn0d60d272015-07-09 15:02:25 -06002211//TODO handle pipeline caches
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002212VKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineCache(
Jon Ashburn0d60d272015-07-09 15:02:25 -06002213 VkDevice device,
2214 const VkPipelineCacheCreateInfo* pCreateInfo,
Chia-I Wu1f851912015-10-27 18:04:07 +08002215 const VkAllocationCallbacks* pAllocator,
Jon Ashburn0d60d272015-07-09 15:02:25 -06002216 VkPipelineCache* pPipelineCache)
2217{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002218 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002219 VkResult result = dev_data->device_dispatch_table->CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache);
Jon Ashburn0d60d272015-07-09 15:02:25 -06002220 return result;
2221}
2222
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002223VKAPI_ATTR void VKAPI_CALL vkDestroyPipelineCache(
Jon Ashburn0d60d272015-07-09 15:02:25 -06002224 VkDevice device,
Chia-I Wu69f40122015-10-26 21:10:41 +08002225 VkPipelineCache pipelineCache,
Chia-I Wu1f851912015-10-27 18:04:07 +08002226 const VkAllocationCallbacks* pAllocator)
Jon Ashburn0d60d272015-07-09 15:02:25 -06002227{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002228 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002229 dev_data->device_dispatch_table->DestroyPipelineCache(device, pipelineCache, pAllocator);
Jon Ashburn0d60d272015-07-09 15:02:25 -06002230}
2231
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002232VKAPI_ATTR VkResult VKAPI_CALL vkGetPipelineCacheData(
Jon Ashburn0d60d272015-07-09 15:02:25 -06002233 VkDevice device,
2234 VkPipelineCache pipelineCache,
Chia-I Wu28c3c432015-10-26 19:17:06 +08002235 size_t* pDataSize,
Jon Ashburn0d60d272015-07-09 15:02:25 -06002236 void* pData)
2237{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002238 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu28c3c432015-10-26 19:17:06 +08002239 VkResult result = dev_data->device_dispatch_table->GetPipelineCacheData(device, pipelineCache, pDataSize, pData);
Jon Ashburn0d60d272015-07-09 15:02:25 -06002240 return result;
2241}
2242
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002243VKAPI_ATTR VkResult VKAPI_CALL vkMergePipelineCaches(
Jon Ashburn0d60d272015-07-09 15:02:25 -06002244 VkDevice device,
Chia-I Wu1f851912015-10-27 18:04:07 +08002245 VkPipelineCache dstCache,
Jon Ashburn0d60d272015-07-09 15:02:25 -06002246 uint32_t srcCacheCount,
2247 const VkPipelineCache* pSrcCaches)
2248{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002249 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu1f851912015-10-27 18:04:07 +08002250 VkResult result = dev_data->device_dispatch_table->MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches);
Jon Ashburn0d60d272015-07-09 15:02:25 -06002251 return result;
2252}
2253
Mark Lobodzinski2adea752015-11-10 15:25:01 -07002254VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateGraphicsPipelines(
2255 VkDevice device,
2256 VkPipelineCache pipelineCache,
2257 uint32_t count,
2258 const VkGraphicsPipelineCreateInfo *pCreateInfos,
2259 const VkAllocationCallbacks *pAllocator,
2260 VkPipeline *pPipelines)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002261{
Courtney Goeltzenleuchtera54b76a2015-09-04 13:39:59 -06002262 VkResult result = VK_SUCCESS;
Tobin Ehlise48be202015-09-16 10:33:53 -06002263 //TODO What to do with pipelineCache?
Tobin Ehlisde63c532015-06-18 15:59:33 -06002264 // The order of operations here is a little convoluted but gets the job done
2265 // 1. Pipeline create state is first shadowed into PIPELINE_NODE struct
2266 // 2. Create state is then validated (which uses flags setup during shadowing)
2267 // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap
Tobin Ehlise48be202015-09-16 10:33:53 -06002268 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis76c18852015-09-17 16:33:58 -06002269 // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic
2270 vector<PIPELINE_NODE*> pPipeNode(count);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002271 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Mark Lobodzinski2adea752015-11-10 15:25:01 -07002272
Tobin Ehlise48be202015-09-16 10:33:53 -06002273 uint32_t i=0;
Tobin Ehlisde63c532015-06-18 15:59:33 -06002274 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinski2adea752015-11-10 15:25:01 -07002275
Tobin Ehlise48be202015-09-16 10:33:53 -06002276 for (i=0; i<count; i++) {
Mark Lobodzinski2adea752015-11-10 15:25:01 -07002277 pPipeNode[i] = initGraphicsPipeline(dev_data, &pCreateInfos[i], NULL);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002278 skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]);
Tobin Ehlise48be202015-09-16 10:33:53 -06002279 }
Mark Lobodzinski2adea752015-11-10 15:25:01 -07002280
Tobin Ehlisde63c532015-06-18 15:59:33 -06002281 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002282 if (VK_FALSE == skipCall) {
Mark Lobodzinski2adea752015-11-10 15:25:01 -07002283 result = dev_data->device_dispatch_table->CreateGraphicsPipelines(device,
2284 pipelineCache, count, pCreateInfos, pAllocator, pPipelines);
Tobin Ehlisde63c532015-06-18 15:59:33 -06002285 loader_platform_thread_lock_mutex(&globalLock);
Tobin Ehlise48be202015-09-16 10:33:53 -06002286 for (i=0; i<count; i++) {
2287 pPipeNode[i]->pipeline = pPipelines[i];
Chia-I Wue420a332015-10-26 20:04:44 +08002288 dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i];
Tobin Ehlise48be202015-09-16 10:33:53 -06002289 }
Tobin Ehlisde63c532015-06-18 15:59:33 -06002290 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002291 } else {
Tobin Ehlise48be202015-09-16 10:33:53 -06002292 for (i=0; i<count; i++) {
2293 if (pPipeNode[i]) {
2294 // If we allocated a pipeNode, need to clean it up here
2295 delete[] pPipeNode[i]->pVertexBindingDescriptions;
2296 delete[] pPipeNode[i]->pVertexAttributeDescriptions;
2297 delete[] pPipeNode[i]->pAttachments;
2298 delete pPipeNode[i];
2299 }
Tobin Ehlisde63c532015-06-18 15:59:33 -06002300 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002301 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlisde63c532015-06-18 15:59:33 -06002302 }
Courtney Goeltzenleuchter9452ac22015-04-13 16:16:04 -06002303 return result;
2304}
2305
Mark Lobodzinski2adea752015-11-10 15:25:01 -07002306VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateComputePipelines(
2307 VkDevice device,
2308 VkPipelineCache pipelineCache,
2309 uint32_t count,
2310 const VkComputePipelineCreateInfo *pCreateInfos,
2311 const VkAllocationCallbacks *pAllocator,
2312 VkPipeline *pPipelines)
2313{
2314 VkResult result = VK_SUCCESS;
2315 VkBool32 skipCall = VK_FALSE;
2316
2317 // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic
2318 vector<PIPELINE_NODE*> pPipeNode(count);
2319 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
2320
2321 uint32_t i=0;
2322 loader_platform_thread_lock_mutex(&globalLock);
2323 for (i=0; i<count; i++) {
2324 // TODO: Verify compute stage bits
2325
2326 // Create and initialize internal tracking data structure
2327 pPipeNode[i] = new PIPELINE_NODE;
2328 memset((void*)pPipeNode[i], 0, sizeof(PIPELINE_NODE));
2329 memcpy(&pPipeNode[i]->computePipelineCI, (const void*)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo));
2330
2331 // TODO: Add Compute Pipeline Verification
2332 // skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]);
2333 }
2334 loader_platform_thread_unlock_mutex(&globalLock);
2335
2336 if (VK_FALSE == skipCall) {
2337 result = dev_data->device_dispatch_table->CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, pPipelines);
2338 loader_platform_thread_lock_mutex(&globalLock);
2339 for (i=0; i<count; i++) {
2340 pPipeNode[i]->pipeline = pPipelines[i];
2341 dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i];
2342 }
2343 loader_platform_thread_unlock_mutex(&globalLock);
2344 } else {
2345 for (i=0; i<count; i++) {
2346 if (pPipeNode[i]) {
2347 // Clean up any locally allocated data structures
2348 delete pPipeNode[i];
2349 }
2350 }
2351 return VK_ERROR_VALIDATION_FAILED;
2352 }
2353 return result;
2354}
2355
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002356VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSampler(VkDevice device, const VkSamplerCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkSampler* pSampler)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002357{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002358 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002359 VkResult result = dev_data->device_dispatch_table->CreateSampler(device, pCreateInfo, pAllocator, pSampler);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002360 if (VK_SUCCESS == result) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002361 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08002362 dev_data->sampleMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo));
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002363 loader_platform_thread_unlock_mutex(&globalLock);
2364 }
2365 return result;
2366}
2367
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002368VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDescriptorSetLayout* pSetLayout)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002369{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002370 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002371 VkResult result = dev_data->device_dispatch_table->CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002372 if (VK_SUCCESS == result) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002373 LAYOUT_NODE* pNewNode = new LAYOUT_NODE;
2374 if (NULL == pNewNode) {
Chia-I Wue420a332015-10-26 20:04:44 +08002375 if (log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT, (uint64_t) *pSetLayout, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002376 "Out of memory while attempting to allocate LAYOUT_NODE in vkCreateDescriptorSetLayout()"))
2377 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002378 }
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06002379 memcpy((void*)&pNewNode->createInfo, pCreateInfo, sizeof(VkDescriptorSetLayoutCreateInfo));
Chia-I Wuf03cbf72015-10-31 00:31:16 +08002380 pNewNode->createInfo.pBinding = new VkDescriptorSetLayoutBinding[pCreateInfo->bindingCount];
2381 memcpy((void*)pNewNode->createInfo.pBinding, pCreateInfo->pBinding, sizeof(VkDescriptorSetLayoutBinding)*pCreateInfo->bindingCount);
Chia-I Wub5689ee2015-10-31 00:31:16 +08002382 // g++ does not like reserve with size 0
2383 if (pCreateInfo->bindingCount)
2384 pNewNode->bindings.reserve(pCreateInfo->bindingCount);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002385 uint32_t totalCount = 0;
Chia-I Wu763a7492015-10-26 20:48:51 +08002386 for (uint32_t i=0; i<pCreateInfo->bindingCount; i++) {
Chia-I Wub5689ee2015-10-31 00:31:16 +08002387 if (!pNewNode->bindings.insert(pCreateInfo->pBinding[i].binding).second) {
2388 if (log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT, (uint64_t) *pSetLayout, 0, DRAWSTATE_INVALID_LAYOUT, "DS",
2389 "duplicated binding number in VkDescriptorSetLayoutBinding"))
2390 return VK_ERROR_VALIDATION_FAILED;
2391 }
2392
Chia-I Wu045654f2015-11-06 06:42:02 +08002393 totalCount += pCreateInfo->pBinding[i].descriptorCount;
Chia-I Wuf03cbf72015-10-31 00:31:16 +08002394 if (pCreateInfo->pBinding[i].pImmutableSamplers) {
2395 VkSampler** ppIS = (VkSampler**)&pNewNode->createInfo.pBinding[i].pImmutableSamplers;
Chia-I Wu045654f2015-11-06 06:42:02 +08002396 *ppIS = new VkSampler[pCreateInfo->pBinding[i].descriptorCount];
2397 memcpy(*ppIS, pCreateInfo->pBinding[i].pImmutableSamplers, pCreateInfo->pBinding[i].descriptorCount*sizeof(VkSampler));
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002398 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002399 }
2400 if (totalCount > 0) {
Cody Northrop8a908322015-10-26 14:07:35 -06002401 pNewNode->descriptorTypes.resize(totalCount);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06002402 pNewNode->stageFlags.resize(totalCount);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002403 uint32_t offset = 0;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002404 uint32_t j = 0;
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002405 VkDescriptorType dType;
Chia-I Wu763a7492015-10-26 20:48:51 +08002406 for (uint32_t i=0; i<pCreateInfo->bindingCount; i++) {
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002407 dType = pCreateInfo->pBinding[i].descriptorType;
Chia-I Wu045654f2015-11-06 06:42:02 +08002408 for (j = 0; j < pCreateInfo->pBinding[i].descriptorCount; j++) {
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002409 pNewNode->descriptorTypes[offset + j] = dType;
Chia-I Wuf03cbf72015-10-31 00:31:16 +08002410 pNewNode->stageFlags[offset + j] = pCreateInfo->pBinding[i].stageFlags;
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002411 if ((dType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2412 (dType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2413 pNewNode->dynamicDescriptorCount++;
2414 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002415 }
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002416 offset += j;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002417 }
2418 }
2419 pNewNode->layout = *pSetLayout;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002420 pNewNode->startIndex = 0;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002421 pNewNode->endIndex = pNewNode->startIndex + totalCount - 1;
2422 assert(pNewNode->endIndex >= pNewNode->startIndex);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002423 // Put new node at Head of global Layer list
2424 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08002425 dev_data->layoutMap[*pSetLayout] = pNewNode;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002426 loader_platform_thread_unlock_mutex(&globalLock);
2427 }
2428 return result;
2429}
2430
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002431VKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkPipelineLayout* pPipelineLayout)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002432{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002433 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002434 VkResult result = dev_data->device_dispatch_table->CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002435 if (VK_SUCCESS == result) {
Tobin Ehlis982099b2015-11-05 09:52:49 -07002436 PIPELINE_LAYOUT_NODE& plNode = dev_data->pipelineLayoutMap[*pPipelineLayout];
Chia-I Wu763a7492015-10-26 20:48:51 +08002437 plNode.descriptorSetLayouts.resize(pCreateInfo->setLayoutCount);
Tobin Ehlis91423d22015-10-20 10:11:55 -06002438 uint32_t i = 0;
Chia-I Wu763a7492015-10-26 20:48:51 +08002439 for (i=0; i<pCreateInfo->setLayoutCount; ++i) {
Tobin Ehlis91423d22015-10-20 10:11:55 -06002440 plNode.descriptorSetLayouts[i] = pCreateInfo->pSetLayouts[i];
2441 }
Cody Northrop8a908322015-10-26 14:07:35 -06002442 plNode.pushConstantRanges.resize(pCreateInfo->pushConstantRangeCount);
Tobin Ehlis91423d22015-10-20 10:11:55 -06002443 for (i=0; i<pCreateInfo->pushConstantRangeCount; ++i) {
2444 plNode.pushConstantRanges[i] = pCreateInfo->pPushConstantRanges[i];
2445 }
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002446 }
2447 return result;
2448}
2449
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002450VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDescriptorPool* pDescriptorPool)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002451{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002452 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002453 VkResult result = dev_data->device_dispatch_table->CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002454 if (VK_SUCCESS == result) {
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002455 // Insert this pool into Global Pool LL at head
Chia-I Wue420a332015-10-26 20:04:44 +08002456 if (log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_DESCRIPTOR_POOL, (uint64_t) *pDescriptorPool, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
2457 "Created Descriptor Pool %#" PRIxLEAST64, (uint64_t) *pDescriptorPool))
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002458 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002459 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002460 DESCRIPTOR_POOL_NODE* pNewNode = new DESCRIPTOR_POOL_NODE(*pDescriptorPool, pCreateInfo);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002461 if (NULL == pNewNode) {
Chia-I Wue420a332015-10-26 20:04:44 +08002462 if (log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_POOL, (uint64_t) *pDescriptorPool, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002463 "Out of memory while attempting to allocate DESCRIPTOR_POOL_NODE in vkCreateDescriptorPool()"))
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002464 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002465 } else {
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002466 dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002467 }
2468 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002469 } else {
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002470 // Need to do anything if pool create fails?
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002471 }
2472 return result;
2473}
2474
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002475VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002476{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002477 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06002478 VkResult result = dev_data->device_dispatch_table->ResetDescriptorPool(device, descriptorPool, flags);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002479 if (VK_SUCCESS == result) {
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06002480 clearDescriptorPool(dev_data, device, descriptorPool, flags);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002481 }
2482 return result;
2483}
2484
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002485VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo* pAllocateInfo, VkDescriptorSet* pDescriptorSets)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002486{
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002487 VkBool32 skipCall = VK_FALSE;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002488 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002489 // Verify that requested descriptorSets are available in pool
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002490 DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002491 if (!pPoolNode) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002492 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_POOL, (uint64_t) pAllocateInfo->descriptorPool, 0, DRAWSTATE_INVALID_POOL, "DS",
2493 "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", (uint64_t) pAllocateInfo->descriptorPool);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002494 } else { // Make sure pool has all the available descriptors before calling down chain
Chia-I Wu1f851912015-10-27 18:04:07 +08002495 skipCall |= validate_descriptor_availability_in_pool(dev_data, pPoolNode, pAllocateInfo->setLayoutCount, pAllocateInfo->pSetLayouts);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002496 }
2497 if (skipCall)
2498 return VK_ERROR_VALIDATION_FAILED;
Chia-I Wu1f851912015-10-27 18:04:07 +08002499 VkResult result = dev_data->device_dispatch_table->AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets);
Cody Northropc8aa4a52015-08-03 12:47:29 -06002500 if (VK_SUCCESS == result) {
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002501 DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002502 if (pPoolNode) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002503 if (pAllocateInfo->setLayoutCount == 0) {
2504 log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, pAllocateInfo->setLayoutCount, 0, DRAWSTATE_NONE, "DS",
2505 "AllocateDescriptorSets called with 0 count");
Cody Northropc8aa4a52015-08-03 12:47:29 -06002506 }
Chia-I Wu1f851912015-10-27 18:04:07 +08002507 for (uint32_t i = 0; i < pAllocateInfo->setLayoutCount; i++) {
Chia-I Wue420a332015-10-26 20:04:44 +08002508 log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_NONE, "DS",
2509 "Created Descriptor Set %#" PRIxLEAST64, (uint64_t) pDescriptorSets[i]);
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002510 // Create new set node and add to head of pool nodes
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002511 SET_NODE* pNewNode = new SET_NODE;
2512 if (NULL == pNewNode) {
Chia-I Wue420a332015-10-26 20:04:44 +08002513 if (log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08002514 "Out of memory while attempting to allocate SET_NODE in vkAllocateDescriptorSets()"))
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002515 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002516 } else {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002517 memset(pNewNode, 0, sizeof(SET_NODE));
Tobin Ehlisf6e93e02015-10-19 12:09:13 -06002518 // TODO : Pool should store a total count of each type of Descriptor available
2519 // When descriptors are allocated, decrement the count and validate here
2520 // that the count doesn't go below 0. One reset/free need to bump count back up.
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002521 // Insert set at head of Set LL for this pool
2522 pNewNode->pNext = pPoolNode->pSets;
2523 pPoolNode->pSets = pNewNode;
Chia-I Wu1f851912015-10-27 18:04:07 +08002524 LAYOUT_NODE* pLayout = getLayoutNode(dev_data, pAllocateInfo->pSetLayouts[i]);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002525 if (NULL == pLayout) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002526 if (log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT, (uint64_t) pAllocateInfo->pSetLayouts[i], 0, DRAWSTATE_INVALID_LAYOUT, "DS",
2527 "Unable to find set layout node for layout %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", (uint64_t) pAllocateInfo->pSetLayouts[i]))
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002528 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002529 }
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002530 pNewNode->pLayout = pLayout;
Chia-I Wu1f851912015-10-27 18:04:07 +08002531 pNewNode->pool = pAllocateInfo->descriptorPool;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002532 pNewNode->set = pDescriptorSets[i];
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002533 pNewNode->descriptorCount = pLayout->endIndex + 1;
2534 if (pNewNode->descriptorCount) {
2535 size_t descriptorArraySize = sizeof(GENERIC_HEADER*)*pNewNode->descriptorCount;
2536 pNewNode->ppDescriptors = new GENERIC_HEADER*[descriptorArraySize];
2537 memset(pNewNode->ppDescriptors, 0, descriptorArraySize);
2538 }
Chia-I Wue420a332015-10-26 20:04:44 +08002539 dev_data->setMap[pDescriptorSets[i]] = pNewNode;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002540 }
2541 }
2542 }
2543 }
2544 return result;
2545}
2546
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002547VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet* pDescriptorSets)
Tony Barbourb857d312015-07-10 10:50:45 -06002548{
Tobin Ehlis3c543112015-10-08 13:13:50 -06002549 VkBool32 skipCall = VK_FALSE;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002550 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002551 DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, descriptorPool);
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06002552 if (pPoolNode && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pPoolNode->createInfo.flags)) {
2553 // Can't Free from a NON_FREE pool
2554 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DEVICE, (uint64_t)device, 0, DRAWSTATE_CANT_FREE_FROM_NON_FREE_POOL, "DS",
2555 "It is invalid to call vkFreeDescriptorSets() with a pool created without setting VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT.");
Tobin Ehlis3c543112015-10-08 13:13:50 -06002556 }
2557 if (skipCall)
2558 return VK_ERROR_VALIDATION_FAILED;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002559 VkResult result = dev_data->device_dispatch_table->FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002560 if (VK_SUCCESS == result) {
2561 // For each freed descriptor add it back into the pool as available
2562 for (uint32_t i=0; i<count; ++i) {
Chia-I Wue420a332015-10-26 20:04:44 +08002563 SET_NODE* pSet = dev_data->setMap[pDescriptorSets[i]]; // getSetNode() without locking
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002564 LAYOUT_NODE* pLayout = pSet->pLayout;
Chia-I Wuc51b1212015-10-27 19:25:11 +08002565 uint32_t typeIndex = 0, poolSizeCount = 0;
Chia-I Wu763a7492015-10-26 20:48:51 +08002566 for (uint32_t j=0; j<pLayout->createInfo.bindingCount; ++j) {
Chia-I Wuf03cbf72015-10-31 00:31:16 +08002567 typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBinding[j].descriptorType);
Chia-I Wu045654f2015-11-06 06:42:02 +08002568 poolSizeCount = pLayout->createInfo.pBinding[j].descriptorCount;
Chia-I Wuc51b1212015-10-27 19:25:11 +08002569 pPoolNode->availableDescriptorTypeCount[typeIndex] += poolSizeCount;
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002570 }
2571 }
2572 }
2573 // TODO : Any other clean-up or book-keeping to do here?
Tony Barbourb857d312015-07-10 10:50:45 -06002574 return result;
2575}
2576
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002577VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet* pDescriptorWrites, uint32_t descriptorCopyCount, const VkCopyDescriptorSet* pDescriptorCopies)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002578{
Tobin Ehlis68fbd442015-10-27 12:25:35 -06002579 // dsUpdate will return VK_TRUE only if a bailout error occurs, so we want to call down tree when update returns VK_FALSE
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002580 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu483e7702015-10-26 17:20:32 +08002581 if (!dsUpdate(dev_data, device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, pDescriptorCopies)) {
2582 dev_data->device_dispatch_table->UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, pDescriptorCopies);
Jon Ashburne0fa2282015-05-20 09:00:28 -06002583 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002584}
2585
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002586VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo* pCreateInfo, VkCommandBuffer* pCommandBuffer)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002587{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002588 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu1f851912015-10-27 18:04:07 +08002589 VkResult result = dev_data->device_dispatch_table->AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002590 if (VK_SUCCESS == result) {
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002591 for (auto i = 0; i < pCreateInfo->bufferCount; i++) {
2592 // Validate command pool
2593 if (dev_data->commandPoolMap.find(pCreateInfo->commandPool) != dev_data->commandPoolMap.end()) {
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002594 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002595 // Add command buffer to its commandPool map
2596 dev_data->commandPoolMap[pCreateInfo->commandPool].push_back(pCommandBuffer[i]);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002597 GLOBAL_CB_NODE* pCB = new GLOBAL_CB_NODE;
2598 // Add command buffer to map
2599 dev_data->commandBufferMap[pCommandBuffer[i]] = pCB;
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002600 loader_platform_thread_unlock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002601 resetCB(dev_data, pCommandBuffer[i]);
2602 pCB->commandBuffer = pCommandBuffer[i];
2603 pCB->createInfo = *pCreateInfo;
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002604 updateCBTracking(pCB);
2605 }
2606 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002607 }
2608 return result;
2609}
2610
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002611VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo* pBeginInfo)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002612{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002613 VkBool32 skipCall = false;
Chia-I Wu1f851912015-10-27 18:04:07 +08002614 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002615 // Validate command buffer level
Chia-I Wu1f851912015-10-27 18:04:07 +08002616 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002617 if (pCB) {
Mark Lobodzinskia1420862015-11-19 13:22:11 -07002618 if (pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) {
Chia-I Wue420a332015-10-26 20:04:44 +08002619 if (pBeginInfo->renderPass || pBeginInfo->framebuffer) {
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002620 // These should be NULL for a Primary CB
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002621 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS",
Mark Lobodzinskifc0ec622015-11-19 12:07:21 -07002622 "vkBeginCommandBuffer(): Primary Command Buffer (%p) may not specify framebuffer or renderpass parameters", (void*)commandBuffer);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002623 }
2624 } else {
Chia-I Wue420a332015-10-26 20:04:44 +08002625 if (!pBeginInfo->renderPass || !pBeginInfo->framebuffer) {
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002626 // These should NOT be null for an Secondary CB
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002627 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS",
Mark Lobodzinskifc0ec622015-11-19 12:07:21 -07002628 "vkBeginCommandBuffer(): Secondary Command Buffers (%p) must specify framebuffer and renderpass parameters", (void*)commandBuffer);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002629 }
2630 }
Tobin Ehlis0cea4082015-08-18 07:10:58 -06002631 pCB->beginInfo = *pBeginInfo;
2632 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002633 // TODO : Need to pass commandBuffer as objType here
2634 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
2635 "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB %p!", (void*)commandBuffer);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06002636 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002637 if (skipCall) {
2638 return VK_ERROR_VALIDATION_FAILED;
Courtney Goeltzenleuchter3abd86e2015-09-04 15:03:52 -06002639 }
Chia-I Wu1f851912015-10-27 18:04:07 +08002640 VkResult result = dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo);
Mark Lobodzinski2ad35592015-11-12 16:14:04 -07002641 if ((VK_SUCCESS == result) && (pCB != NULL)) {
2642 if (CB_NEW != pCB->state) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002643 resetCB(dev_data, commandBuffer);
Mark Lobodzinski2ad35592015-11-12 16:14:04 -07002644 }
Tobin Ehlis0cea4082015-08-18 07:10:58 -06002645 pCB->state = CB_UPDATE_ACTIVE;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002646 updateCBTracking(pCB);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002647 }
2648 return result;
2649}
2650
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002651VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEndCommandBuffer(VkCommandBuffer commandBuffer)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002652{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002653 VkBool32 skipCall = VK_FALSE;
Courtney Goeltzenleuchtera54b76a2015-09-04 13:39:59 -06002654 VkResult result = VK_SUCCESS;
Chia-I Wu1f851912015-10-27 18:04:07 +08002655 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2656 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchtera54b76a2015-09-04 13:39:59 -06002657 /* TODO: preference is to always call API function after reporting any validation errors */
Tobin Ehlise42007c2015-06-19 13:00:59 -06002658 if (pCB) {
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002659 if (pCB->state != CB_UPDATE_ACTIVE) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002660 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkEndCommandBuffer()");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002661 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002662 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002663 if (VK_FALSE == skipCall) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002664 result = dev_data->device_dispatch_table->EndCommandBuffer(commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002665 if (VK_SUCCESS == result) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002666 updateCBTracking(pCB);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002667 pCB->state = CB_UPDATE_COMPLETE;
2668 // Reset CB status flags
2669 pCB->status = 0;
Chia-I Wu1f851912015-10-27 18:04:07 +08002670 printCB(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002671 }
2672 } else {
2673 result = VK_ERROR_VALIDATION_FAILED;
2674 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002675 return result;
2676}
2677
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002678VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002679{
Chia-I Wu1f851912015-10-27 18:04:07 +08002680 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2681 VkResult result = dev_data->device_dispatch_table->ResetCommandBuffer(commandBuffer, flags);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06002682 if (VK_SUCCESS == result) {
Chia-I Wu1f851912015-10-27 18:04:07 +08002683 resetCB(dev_data, commandBuffer);
2684 updateCBTracking(getCBNode(dev_data, commandBuffer));
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002685 }
2686 return result;
2687}
2688
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002689VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002690{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002691 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002692 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2693 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002694 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06002695 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002696 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002697 skipCall |= addCmd(dev_data, pCB, CMD_BINDPIPELINE);
Tobin Ehlis642d5a52015-06-23 08:46:18 -06002698 if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) {
Chia-I Wue420a332015-10-26 20:04:44 +08002699 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE, (uint64_t) pipeline,
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06002700 0, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS",
2701 "Incorrectly binding compute pipeline (%#" PRIxLEAST64 ") during active RenderPass (%#" PRIxLEAST64 ")",
Chia-I Wue420a332015-10-26 20:04:44 +08002702 (uint64_t) pipeline, (uint64_t) pCB->activeRenderPass);
Tobin Ehlise4076782015-06-24 15:53:07 -06002703 } else if ((VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) && (!pCB->activeRenderPass)) {
Chia-I Wue420a332015-10-26 20:04:44 +08002704 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE, (uint64_t) pipeline,
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06002705 0, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", "Incorrectly binding graphics pipeline "
Chia-I Wue420a332015-10-26 20:04:44 +08002706 " (%#" PRIxLEAST64 ") without an active RenderPass", (uint64_t) pipeline);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002707 } else {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002708 PIPELINE_NODE* pPN = getPipeline(dev_data, pipeline);
Tobin Ehlise4076782015-06-24 15:53:07 -06002709 if (pPN) {
2710 pCB->lastBoundPipeline = pipeline;
2711 loader_platform_thread_lock_mutex(&globalLock);
2712 set_cb_pso_status(pCB, pPN);
2713 g_lastBoundPipeline = pPN;
2714 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002715 skipCall |= validatePipelineState(dev_data, pCB, pipelineBindPoint, pipeline);
Tobin Ehlise4076782015-06-24 15:53:07 -06002716 } else {
Chia-I Wue420a332015-10-26 20:04:44 +08002717 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_PIPELINE, (uint64_t) pipeline,
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06002718 0, DRAWSTATE_INVALID_PIPELINE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08002719 "Attempt to bind Pipeline %#" PRIxLEAST64 " that doesn't exist!", reinterpret_cast<uint64_t>(pipeline));
Tobin Ehlise4076782015-06-24 15:53:07 -06002720 }
Tobin Ehlise42007c2015-06-19 13:00:59 -06002721 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002722 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002723 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindPipeline()");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002724 }
2725 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002726 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002727 dev_data->device_dispatch_table->CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002728}
2729
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002730VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetViewport(
Chia-I Wu1f851912015-10-27 18:04:07 +08002731 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002732 uint32_t viewportCount,
2733 const VkViewport* pViewports)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002734{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002735 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002736 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2737 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlise42007c2015-06-19 13:00:59 -06002738 if (pCB) {
2739 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002740 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002741 skipCall |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE);
Tobin Ehlise42007c2015-06-19 13:00:59 -06002742 loader_platform_thread_lock_mutex(&globalLock);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002743 pCB->status |= CBSTATUS_VIEWPORT_SET;
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002744 pCB->viewports.resize(viewportCount);
Tobin Ehlis9e839e52015-10-01 11:15:13 -06002745 memcpy(pCB->viewports.data(), pViewports, viewportCount * sizeof(VkViewport));
Tobin Ehlise42007c2015-06-19 13:00:59 -06002746 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlise42007c2015-06-19 13:00:59 -06002747 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002748 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetViewport()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06002749 }
2750 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002751 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002752 dev_data->device_dispatch_table->CmdSetViewport(commandBuffer, viewportCount, pViewports);
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002753}
2754
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002755VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetScissor(
Chia-I Wu1f851912015-10-27 18:04:07 +08002756 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002757 uint32_t scissorCount,
2758 const VkRect2D* pScissors)
2759{
2760 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002761 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2762 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002763 if (pCB) {
2764 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002765 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002766 skipCall |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE);
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002767 loader_platform_thread_lock_mutex(&globalLock);
2768 pCB->status |= CBSTATUS_SCISSOR_SET;
2769 pCB->scissors.resize(scissorCount);
Tobin Ehlis9e839e52015-10-01 11:15:13 -06002770 memcpy(pCB->scissors.data(), pScissors, scissorCount * sizeof(VkRect2D));
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002771 loader_platform_thread_unlock_mutex(&globalLock);
2772 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002773 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetScissor()");
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06002774 }
2775 }
2776 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002777 dev_data->device_dispatch_table->CmdSetScissor(commandBuffer, scissorCount, pScissors);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002778}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002779
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002780VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002781{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002782 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002783 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2784 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002785 if (pCB) {
2786 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002787 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002788 skipCall |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002789 /* TODO: Do we still need this lock? */
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002790 loader_platform_thread_lock_mutex(&globalLock);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002791 pCB->status |= CBSTATUS_LINE_WIDTH_SET;
2792 pCB->lineWidth = lineWidth;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002793 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002794 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002795 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDynamicLineWidthState()");
Cody Northropf5bd2252015-08-17 11:10:49 -06002796 }
2797 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002798 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002799 dev_data->device_dispatch_table->CmdSetLineWidth(commandBuffer, lineWidth);
Cody Northropf5bd2252015-08-17 11:10:49 -06002800}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002801
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002802VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetDepthBias(
Chia-I Wu1f851912015-10-27 18:04:07 +08002803 VkCommandBuffer commandBuffer,
Chia-I Wufa950c52015-10-26 19:08:09 +08002804 float depthBiasConstantFactor,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002805 float depthBiasClamp,
Chia-I Wufa950c52015-10-26 19:08:09 +08002806 float depthBiasSlopeFactor)
Cody Northropf5bd2252015-08-17 11:10:49 -06002807{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002808 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002809 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2810 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Cody Northropf5bd2252015-08-17 11:10:49 -06002811 if (pCB) {
2812 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002813 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002814 skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002815 pCB->status |= CBSTATUS_DEPTH_BIAS_SET;
Chia-I Wufa950c52015-10-26 19:08:09 +08002816 pCB->depthBiasConstantFactor = depthBiasConstantFactor;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002817 pCB->depthBiasClamp = depthBiasClamp;
Chia-I Wufa950c52015-10-26 19:08:09 +08002818 pCB->depthBiasSlopeFactor = depthBiasSlopeFactor;
Cody Northropf5bd2252015-08-17 11:10:49 -06002819 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002820 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetDepthBias()");
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002821 }
2822 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002823 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002824 dev_data->device_dispatch_table->CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, depthBiasSlopeFactor);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002825}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002826
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002827VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4])
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002828{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002829 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002830 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2831 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002832 if (pCB) {
2833 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002834 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002835 skipCall |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002836 pCB->status |= CBSTATUS_BLEND_SET;
Chia-I Wu7e470702015-10-26 17:24:52 +08002837 memcpy(pCB->blendConstants, blendConstants, 4 * sizeof(float));
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002838 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002839 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetBlendConstants()");
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002840 }
2841 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002842 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002843 dev_data->device_dispatch_table->CmdSetBlendConstants(commandBuffer, blendConstants);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002844}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002845
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002846VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetDepthBounds(
Chia-I Wu1f851912015-10-27 18:04:07 +08002847 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002848 float minDepthBounds,
2849 float maxDepthBounds)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002850{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002851 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002852 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2853 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002854 if (pCB) {
2855 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002856 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002857 skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002858 pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET;
2859 pCB->minDepthBounds = minDepthBounds;
2860 pCB->maxDepthBounds = maxDepthBounds;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002861 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002862 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetDepthBounds()");
Cody Northrop2605cb02015-08-18 15:21:16 -06002863 }
2864 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002865 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08002866 dev_data->device_dispatch_table->CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds);
Cody Northrop2605cb02015-08-18 15:21:16 -06002867}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002868
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002869VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetStencilCompareMask(
Chia-I Wu1f851912015-10-27 18:04:07 +08002870 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002871 VkStencilFaceFlags faceMask,
Chia-I Wuc51b1212015-10-27 19:25:11 +08002872 uint32_t compareMask)
Cody Northrop2605cb02015-08-18 15:21:16 -06002873{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002874 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002875 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2876 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Cody Northrop2605cb02015-08-18 15:21:16 -06002877 if (pCB) {
2878 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002879 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002880 skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002881 if (faceMask & VK_STENCIL_FACE_FRONT_BIT) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002882 pCB->front.compareMask = compareMask;
Cody Northrop2605cb02015-08-18 15:21:16 -06002883 }
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002884 if (faceMask & VK_STENCIL_FACE_BACK_BIT) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002885 pCB->back.compareMask = compareMask;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002886 }
2887 /* TODO: Do we need to track front and back separately? */
2888 /* TODO: We aren't capturing the faceMask, do we need to? */
2889 pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET;
Cody Northrop2605cb02015-08-18 15:21:16 -06002890 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002891 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetStencilCompareMask()");
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002892 }
2893 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002894 if (VK_FALSE == skipCall)
Chia-I Wuc51b1212015-10-27 19:25:11 +08002895 dev_data->device_dispatch_table->CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002896}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002897
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002898VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetStencilWriteMask(
Chia-I Wu1f851912015-10-27 18:04:07 +08002899 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002900 VkStencilFaceFlags faceMask,
Chia-I Wuc51b1212015-10-27 19:25:11 +08002901 uint32_t writeMask)
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002902{
2903 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002904 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2905 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002906 if (pCB) {
2907 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002908 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002909 skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002910 if (faceMask & VK_STENCIL_FACE_FRONT_BIT) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002911 pCB->front.writeMask = writeMask;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002912 }
2913 if (faceMask & VK_STENCIL_FACE_BACK_BIT) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002914 pCB->back.writeMask = writeMask;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002915 }
2916 pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET;
2917 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002918 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetStencilWriteMask()");
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002919 }
2920 }
2921 if (VK_FALSE == skipCall)
Chia-I Wuc51b1212015-10-27 19:25:11 +08002922 dev_data->device_dispatch_table->CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002923}
2924
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002925VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetStencilReference(
Chia-I Wu1f851912015-10-27 18:04:07 +08002926 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002927 VkStencilFaceFlags faceMask,
Chia-I Wuc51b1212015-10-27 19:25:11 +08002928 uint32_t reference)
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002929{
2930 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002931 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2932 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002933 if (pCB) {
2934 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002935 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002936 skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002937 if (faceMask & VK_STENCIL_FACE_FRONT_BIT) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002938 pCB->front.reference = reference;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002939 }
2940 if (faceMask & VK_STENCIL_FACE_BACK_BIT) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002941 pCB->back.reference = reference;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002942 }
2943 pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET;
2944 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08002945 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetStencilReference()");
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002946 }
2947 }
2948 if (VK_FALSE == skipCall)
Chia-I Wuc51b1212015-10-27 19:25:11 +08002949 dev_data->device_dispatch_table->CmdSetStencilReference(commandBuffer, faceMask, reference);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06002950}
2951
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002952VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, uint32_t firstSet, uint32_t setCount, const VkDescriptorSet* pDescriptorSets, uint32_t dynamicOffsetCount, const uint32_t* pDynamicOffsets)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002953{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002954 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08002955 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
2956 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002957 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06002958 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlise4076782015-06-24 15:53:07 -06002959 if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002960 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08002961 "Incorrectly binding compute DescriptorSets during active RenderPass (%#" PRIxLEAST64 ")", (uint64_t) pCB->activeRenderPass);
Tobin Ehlise4076782015-06-24 15:53:07 -06002962 } else if ((VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) && (!pCB->activeRenderPass)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002963 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS",
Tobin Ehlise4076782015-06-24 15:53:07 -06002964 "Incorrectly binding graphics DescriptorSets without an active RenderPass");
Tobin Ehlisd28acef2015-09-09 15:12:35 -06002965 } else {
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002966 // Track total count of dynamic descriptor types to make sure we have an offset for each one
2967 uint32_t totalDynamicDescriptors = 0;
Tobin Ehlis982099b2015-11-05 09:52:49 -07002968 string errorString = "";
2969 uint32_t lastSetIndex = firstSet+setCount;
2970 if (lastSetIndex >= pCB->boundDescriptorSets.size())
2971 pCB->boundDescriptorSets.resize(lastSetIndex+1);
2972 VkDescriptorSet oldFinalBoundSet = pCB->boundDescriptorSets[lastSetIndex];
Tobin Ehlise42007c2015-06-19 13:00:59 -06002973 for (uint32_t i=0; i<setCount; i++) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002974 SET_NODE* pSet = getSetNode(dev_data, pDescriptorSets[i]);
Tobin Ehlis55c1c602015-06-24 17:27:33 -06002975 if (pSet) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06002976 loader_platform_thread_lock_mutex(&globalLock);
2977 pCB->lastBoundDescriptorSet = pDescriptorSets[i];
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -06002978 pCB->lastBoundPipelineLayout = layout;
Tobin Ehlis982099b2015-11-05 09:52:49 -07002979 pCB->boundDescriptorSets[i+firstSet] = pDescriptorSets[i];
Tobin Ehlise42007c2015-06-19 13:00:59 -06002980 loader_platform_thread_unlock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08002981 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_NONE, "DS",
2982 "DS %#" PRIxLEAST64 " bound on pipeline %s", (uint64_t) pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint));
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002983 if (!pSet->pUpdateStructs) {
Chia-I Wue420a332015-10-26 20:04:44 +08002984 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_WARN_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS",
2985 "DS %#" PRIxLEAST64 " bound but it was never updated. You may want to either update it or not bind it.", (uint64_t) pDescriptorSets[i]);
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002986 }
Tobin Ehlis982099b2015-11-05 09:52:49 -07002987 // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout
2988 if (!verify_set_layout_compatibility(dev_data, pSet, layout, i+firstSet, errorString)) {
2989 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS",
2990 "descriptorSet #%u being bound is not compatible with overlapping layout in pipelineLayout due to: %s", i, errorString.c_str());
2991 }
Tobin Ehlis61ebb312015-11-04 12:28:28 -07002992 totalDynamicDescriptors += pSet->pLayout->dynamicDescriptorCount;
Tobin Ehlise42007c2015-06-19 13:00:59 -06002993 } else {
Chia-I Wue420a332015-10-26 20:04:44 +08002994 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_INVALID_SET, "DS",
2995 "Attempt to bind DS %#" PRIxLEAST64 " that doesn't exist!", (uint64_t) pDescriptorSets[i]);
Tobin Ehlise42007c2015-06-19 13:00:59 -06002996 }
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06002997 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002998 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002999 skipCall |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS);
Tobin Ehlis982099b2015-11-05 09:52:49 -07003000 // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update
3001 if (firstSet > 0) { // Check set #s below the first bound set
3002 for (uint32_t i=0; i<firstSet; ++i) {
3003 if (!verify_set_layout_compatibility(dev_data, dev_data->setMap[pCB->boundDescriptorSets[i]], layout, i, errorString)) {
3004 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) pCB->boundDescriptorSets[i], 0, DRAWSTATE_NONE, "DS",
3005 "DescriptorSetDS %#" PRIxLEAST64 " previously bound as set #%u was disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", (uint64_t) pCB->boundDescriptorSets[i], i, (uint64_t) layout);
3006 pCB->boundDescriptorSets[i] = VK_NULL_HANDLE;
3007 }
3008 }
3009 }
3010 // Check if newly last bound set invalidates any remaining bound sets
3011 if ((pCB->boundDescriptorSets.size()-1) > (lastSetIndex)) {
3012 if (!verify_set_layout_compatibility(dev_data, dev_data->setMap[oldFinalBoundSet], layout, lastSetIndex, errorString)) {
3013 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_DESCRIPTOR_SET, (uint64_t) oldFinalBoundSet, 0, DRAWSTATE_NONE, "DS",
3014 "DescriptorSetDS %#" PRIxLEAST64 " previously bound as set #%u and all subsequent sets were disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", (uint64_t) oldFinalBoundSet, lastSetIndex, (uint64_t) layout);
3015 pCB->boundDescriptorSets.resize(lastSetIndex+1);
3016 }
3017 }
Tobin Ehlis61ebb312015-11-04 12:28:28 -07003018 // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound
3019 if (totalDynamicDescriptors != dynamicOffsetCount) {
3020 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, (uint64_t) commandBuffer, 0, DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS",
3021 "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount is %u. It should exactly match the number of dynamic descriptors.", setCount, totalDynamicDescriptors, dynamicOffsetCount);
3022 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003023 }
Tobin Ehlise42007c2015-06-19 13:00:59 -06003024 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003025 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003026 }
3027 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003028 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003029 dev_data->device_dispatch_table->CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, pDescriptorSets, dynamicOffsetCount, pDynamicOffsets);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003030}
3031
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003032VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003033{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003034 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003035 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3036 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003037 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003038 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlis8d199e52015-09-17 12:24:13 -06003039 VkDeviceSize offset_align = 0;
3040 switch (indexType) {
3041 case VK_INDEX_TYPE_UINT16:
3042 offset_align = 2;
3043 break;
3044 case VK_INDEX_TYPE_UINT32:
3045 offset_align = 4;
3046 break;
3047 default:
3048 // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0
3049 break;
3050 }
3051 if (!offset_align || (offset % offset_align)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003052 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS",
Tobin Ehlis8d199e52015-09-17 12:24:13 -06003053 "vkCmdBindIndexBuffer() offset (%#" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", offset, string_VkIndexType(indexType));
Tobin Ehlise4076782015-06-24 15:53:07 -06003054 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003055 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003056 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindIndexBuffer()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003057 }
Tobin Ehlis8d199e52015-09-17 12:24:13 -06003058 pCB->status |= CBSTATUS_INDEX_BUFFER_BOUND;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003059 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003060 skipCall |= addCmd(dev_data, pCB, CMD_BINDINDEXBUFFER);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003061 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003062 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003063 dev_data->device_dispatch_table->CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003064}
3065
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003066VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindVertexBuffers(
Chia-I Wu1f851912015-10-27 18:04:07 +08003067 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter46962942015-04-16 13:38:46 -06003068 uint32_t startBinding,
3069 uint32_t bindingCount,
3070 const VkBuffer* pBuffers,
Tony Barbour8205d902015-04-16 15:59:00 -06003071 const VkDeviceSize* pOffsets)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003072{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003073 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003074 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3075 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003076 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003077 if (pCB->state == CB_UPDATE_ACTIVE) {
3078 /* TODO: Need to track all the vertex buffers, not just last one */
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003079 pCB->lastVtxBinding = startBinding + bindingCount -1;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003080 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003081 addCmd(dev_data, pCB, CMD_BINDVERTEXBUFFER);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003082 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003083 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()");
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06003084 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003085 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003086 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003087 dev_data->device_dispatch_table->CmdBindVertexBuffers(commandBuffer, startBinding, bindingCount, pBuffers, pOffsets);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003088}
3089
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003090VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, uint32_t firstVertex, uint32_t firstInstance)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003091{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003092 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003093 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3094 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003095 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003096 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003097 pCB->drawCount[DRAW]++;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003098 skipCall |= validate_draw_state(dev_data, pCB, VK_FALSE);
Chia-I Wu1f851912015-10-27 18:04:07 +08003099 // TODO : Need to pass commandBuffer as srcObj here
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003100 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08003101 "vkCmdDraw() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW]++);
Chia-I Wu1f851912015-10-27 18:04:07 +08003102 skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003103 if (VK_FALSE == skipCall) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003104 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003105 skipCall |= addCmd(dev_data, pCB, CMD_DRAW);
Tobin Ehlise42007c2015-06-19 13:00:59 -06003106 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003107 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003108 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDraw()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003109 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003110 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDraw");
Jon Ashburne0fa2282015-05-20 09:00:28 -06003111 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003112 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003113 dev_data->device_dispatch_table->CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003114}
3115
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003116VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, uint32_t firstInstance)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003117{
Chia-I Wu1f851912015-10-27 18:04:07 +08003118 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3119 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003120 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003121 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003122 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003123 pCB->drawCount[DRAW_INDEXED]++;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003124 skipCall |= validate_draw_state(dev_data, pCB, VK_TRUE);
Chia-I Wu1f851912015-10-27 18:04:07 +08003125 // TODO : Need to pass commandBuffer as srcObj here
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003126 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08003127 "vkCmdDrawIndexed() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++);
Chia-I Wu1f851912015-10-27 18:04:07 +08003128 skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003129 if (VK_FALSE == skipCall) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003130 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003131 skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXED);
Tobin Ehlise42007c2015-06-19 13:00:59 -06003132 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003133 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003134 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDrawIndexed()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003135 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003136 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed");
Jon Ashburne0fa2282015-05-20 09:00:28 -06003137 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003138 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003139 dev_data->device_dispatch_table->CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, firstInstance);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003140}
3141
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003142VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003143{
Chia-I Wu1f851912015-10-27 18:04:07 +08003144 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3145 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003146 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003147 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003148 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003149 pCB->drawCount[DRAW_INDIRECT]++;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003150 skipCall |= validate_draw_state(dev_data, pCB, VK_FALSE);
Chia-I Wu1f851912015-10-27 18:04:07 +08003151 // TODO : Need to pass commandBuffer as srcObj here
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003152 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08003153 "vkCmdDrawIndirect() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++);
Chia-I Wu1f851912015-10-27 18:04:07 +08003154 skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003155 if (VK_FALSE == skipCall) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003156 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003157 skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDIRECT);
Tobin Ehlise42007c2015-06-19 13:00:59 -06003158 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003159 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003160 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDrawIndirect()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003161 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003162 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndirect");
Jon Ashburne0fa2282015-05-20 09:00:28 -06003163 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003164 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003165 dev_data->device_dispatch_table->CmdDrawIndirect(commandBuffer, buffer, offset, count, stride);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003166}
3167
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003168VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003169{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003170 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003171 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3172 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003173 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003174 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003175 pCB->drawCount[DRAW_INDEXED_INDIRECT]++;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003176 skipCall |= validate_draw_state(dev_data, pCB, VK_TRUE);
Chia-I Wu1f851912015-10-27 18:04:07 +08003177 // TODO : Need to pass commandBuffer as srcObj here
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003178 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_INFO_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08003179 "vkCmdDrawIndexedIndirect() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDEXED_INDIRECT]++);
Chia-I Wu1f851912015-10-27 18:04:07 +08003180 skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003181 if (VK_FALSE == skipCall) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003182 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003183 skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXEDINDIRECT);
Tobin Ehlise42007c2015-06-19 13:00:59 -06003184 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003185 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003186 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDrawIndexedIndirect()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003187 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003188 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexedIndirect");
Jon Ashburne0fa2282015-05-20 09:00:28 -06003189 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003190 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003191 dev_data->device_dispatch_table->CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003192}
3193
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003194VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003195{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003196 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003197 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3198 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003199 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003200 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003201 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003202 skipCall |= addCmd(dev_data, pCB, CMD_DISPATCH);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003203 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003204 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDispatch()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003205 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003206 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatch");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003207 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003208 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003209 dev_data->device_dispatch_table->CmdDispatch(commandBuffer, x, y, z);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003210}
3211
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003212VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003213{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003214 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003215 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3216 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003217 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003218 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003219 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003220 skipCall |= addCmd(dev_data, pCB, CMD_DISPATCHINDIRECT);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003221 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003222 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdDispatchIndirect()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003223 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003224 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatchIndirect");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003225 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003226 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003227 dev_data->device_dispatch_table->CmdDispatchIndirect(commandBuffer, buffer, offset);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003228}
3229
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003230VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, uint32_t regionCount, const VkBufferCopy* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003231{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003232 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003233 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3234 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003235 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003236 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003237 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003238 skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFER);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003239 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003240 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyBuffer()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003241 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003242 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBuffer");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003243 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003244 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003245 dev_data->device_dispatch_table->CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003246}
3247
Michael Lentine27b0f902015-10-12 11:30:14 -05003248bool VerifySourceImageLayout(VkCommandBuffer cmdBuffer, VkImage srcImage, VkImageLayout srcImageLayout) {
3249 bool skip_call = false;
3250 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
3251 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
3252 auto src_image_element = pCB->imageLayoutMap.find(srcImage);
3253 if (src_image_element == pCB->imageLayoutMap.end()) {
3254 pCB->imageLayoutMap[srcImage].initialLayout = srcImageLayout;
3255 pCB->imageLayoutMap[srcImage].layout = srcImageLayout;
3256 return false;
3257 }
3258 if (src_image_element->second.layout != srcImageLayout) {
3259 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
3260 "Cannot copy from an image whose source layout is %d and doesn't match the current layout %d.", srcImageLayout, src_image_element->second.layout);
3261 }
3262 if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) {
3263 if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) {
3264 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine472af7d2015-10-16 18:08:09 -05003265 "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL.");
Michael Lentine27b0f902015-10-12 11:30:14 -05003266 } else {
3267 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine472af7d2015-10-16 18:08:09 -05003268 "Layout for input image is %d but can only be TRANSFER_SRC_OPTIMAL or GENERAL.", srcImageLayout);
Michael Lentine27b0f902015-10-12 11:30:14 -05003269 }
3270 }
3271 return skip_call;
3272}
3273
3274bool VerifyDestImageLayout(VkCommandBuffer cmdBuffer, VkImage destImage, VkImageLayout destImageLayout) {
3275 bool skip_call = false;
3276 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
3277 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
3278 auto dest_image_element = pCB->imageLayoutMap.find(destImage);
3279 if (dest_image_element == pCB->imageLayoutMap.end()) {
3280 pCB->imageLayoutMap[destImage].initialLayout = destImageLayout;
3281 pCB->imageLayoutMap[destImage].layout = destImageLayout;
3282 return false;
3283 }
3284 if (dest_image_element->second.layout != destImageLayout) {
3285 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
3286 "Cannot copy from an image whose dest layout is %d and doesn't match the current layout %d.", destImageLayout, dest_image_element->second.layout);
3287 }
3288 if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) {
3289 if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) {
3290 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
3291 "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL.");
3292 } else {
3293 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
3294 "Layout for output image is %d but can only be TRANSFER_DST_OPTIMAL or GENERAL.", destImageLayout);
3295 }
3296 }
3297 return skip_call;
3298}
3299
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003300VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyImage(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003301 VkImage srcImage,
3302 VkImageLayout srcImageLayout,
Chia-I Wu1f851912015-10-27 18:04:07 +08003303 VkImage dstImage,
3304 VkImageLayout dstImageLayout,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003305 uint32_t regionCount, const VkImageCopy* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003306{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003307 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003308 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3309 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003310 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003311 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003312 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003313 skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGE);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003314 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003315 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyImage()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003316 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003317 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImage");
Michael Lentine27b0f902015-10-12 11:30:14 -05003318 skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, srcImageLayout);
3319 skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, dstImageLayout);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003320 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003321 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003322 dev_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003323}
3324
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003325VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBlitImage(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003326 VkImage srcImage, VkImageLayout srcImageLayout,
Chia-I Wu1f851912015-10-27 18:04:07 +08003327 VkImage dstImage, VkImageLayout dstImageLayout,
Mark Lobodzinski20f68592015-05-22 14:43:25 -05003328 uint32_t regionCount, const VkImageBlit* pRegions,
Chia-I Wu3603b082015-10-26 16:49:32 +08003329 VkFilter filter)
Courtney Goeltzenleuchter6ff8ebc2015-04-03 14:42:51 -06003330{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003331 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003332 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3333 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchter6ff8ebc2015-04-03 14:42:51 -06003334 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003335 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003336 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003337 skipCall |= addCmd(dev_data, pCB, CMD_BLITIMAGE);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003338 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003339 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBlitImage()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003340 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003341 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBlitImage");
Courtney Goeltzenleuchter6ff8ebc2015-04-03 14:42:51 -06003342 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003343 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003344 dev_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, pRegions, filter);
Courtney Goeltzenleuchter6ff8ebc2015-04-03 14:42:51 -06003345}
3346
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003347VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003348 VkBuffer srcBuffer,
Chia-I Wu1f851912015-10-27 18:04:07 +08003349 VkImage dstImage, VkImageLayout dstImageLayout,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003350 uint32_t regionCount, const VkBufferImageCopy* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003351{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003352 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003353 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3354 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003355 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003356 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003357 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003358 skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFERTOIMAGE);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003359 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003360 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyBufferToImage()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003361 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003362 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBufferToImage");
Michael Lentine27b0f902015-10-12 11:30:14 -05003363 skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, dstImageLayout);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003364 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003365 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003366 dev_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003367}
3368
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003369VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003370 VkImage srcImage, VkImageLayout srcImageLayout,
Chia-I Wu1f851912015-10-27 18:04:07 +08003371 VkBuffer dstBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003372 uint32_t regionCount, const VkBufferImageCopy* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003373{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003374 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003375 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3376 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003377 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003378 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003379 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003380 skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGETOBUFFER);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003381 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003382 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyImageToBuffer()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003383 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003384 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImageToBuffer");
Michael Lentine27b0f902015-10-12 11:30:14 -05003385 skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, srcImageLayout);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003386 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003387 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003388 dev_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003389}
3390
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003391VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t* pData)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003392{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003393 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003394 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3395 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003396 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003397 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003398 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003399 skipCall |= addCmd(dev_data, pCB, CMD_UPDATEBUFFER);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003400 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003401 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdUpdateBuffer()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003402 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003403 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyUpdateBuffer");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003404 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003405 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003406 dev_data->device_dispatch_table->CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003407}
3408
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003409VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003410{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003411 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003412 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3413 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003414 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003415 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003416 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003417 skipCall |= addCmd(dev_data, pCB, CMD_FILLBUFFER);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003418 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003419 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdFillBuffer()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003420 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003421 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyFillBuffer");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003422 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003423 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003424 dev_data->device_dispatch_table->CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003425}
3426
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003427VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearAttachments(
Chia-I Wu1f851912015-10-27 18:04:07 +08003428 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003429 uint32_t attachmentCount,
3430 const VkClearAttachment* pAttachments,
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003431 uint32_t rectCount,
Courtney Goeltzenleuchtera12e2912015-10-15 18:22:08 -06003432 const VkClearRect* pRects)
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003433{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003434 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003435 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3436 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003437 if (pCB) {
3438 if (pCB->state == CB_UPDATE_ACTIVE) {
3439 // Warn if this is issued prior to Draw Cmd
3440 if (!hasDrawCmd(pCB)) {
Chia-I Wu1f851912015-10-27 18:04:07 +08003441 // TODO : commandBuffer should be srcObj
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003442 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_WARN_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, 0, 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS",
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003443 "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds."
Chia-I Wu1f851912015-10-27 18:04:07 +08003444 " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", reinterpret_cast<uint64_t>(commandBuffer));
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003445 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003446 updateCBTracking(pCB);
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003447 skipCall |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS);
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003448 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003449 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdClearAttachments()");
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003450 }
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003451 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments");
3452 }
3453
3454 // Validate that attachment is in reference list of active subpass
3455 if (pCB->activeRenderPass) {
Michael Lentine07ff1a12015-10-15 17:07:00 -05003456 const VkRenderPassCreateInfo *pRPCI = dev_data->renderPassMap[pCB->activeRenderPass]->createInfo;
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003457 const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass];
3458
3459 for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) {
3460 const VkClearAttachment *attachment = &pAttachments[attachment_idx];
3461 if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) {
3462 VkBool32 found = VK_FALSE;
Chia-I Wu763a7492015-10-26 20:48:51 +08003463 for (uint32_t i = 0; i < pSD->colorAttachmentCount; i++) {
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003464 if (attachment->colorAttachment == pSD->pColorAttachments[i].attachment) {
3465 found = VK_TRUE;
3466 break;
3467 }
3468 }
3469 if (VK_FALSE == found) {
3470 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER,
Chia-I Wu1f851912015-10-27 18:04:07 +08003471 (uint64_t)commandBuffer, 0, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS",
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003472 "vkCmdClearAttachments() attachment index %d not found in attachment reference array of active subpass %d",
3473 attachment->colorAttachment, pCB->activeSubpass);
3474 }
3475 } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) {
Mark Lobodzinski1523e3a2015-11-17 15:11:24 -07003476 if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass
Mark Lobodzinskiea1fff22015-11-18 08:58:31 -07003477 (pSD->pDepthStencilAttachment->attachment == VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass
Mark Lobodzinski1523e3a2015-11-17 15:11:24 -07003478
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003479 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER,
Mark Lobodzinski1523e3a2015-11-17 15:11:24 -07003480 (uint64_t)commandBuffer, 0, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS",
3481 "vkCmdClearAttachments() attachment index %d does not match depthStencilAttachment.attachment (%d) found in active subpass %d",
3482 attachment->colorAttachment,
3483 (pSD->pDepthStencilAttachment) ? pSD->pDepthStencilAttachment->attachment : VK_ATTACHMENT_UNUSED,
3484 pCB->activeSubpass);
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06003485 }
3486 }
3487 }
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003488 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003489 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003490 dev_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects);
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003491}
3492
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003493VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearColorImage(
Chia-I Wu1f851912015-10-27 18:04:07 +08003494 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchterda4a99e2015-04-23 17:49:22 -06003495 VkImage image, VkImageLayout imageLayout,
Chris Forbese3105972015-06-24 14:34:53 +12003496 const VkClearColorValue *pColor,
Courtney Goeltzenleuchterda4a99e2015-04-23 17:49:22 -06003497 uint32_t rangeCount, const VkImageSubresourceRange* pRanges)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003498{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003499 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003500 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3501 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003502 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003503 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003504 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003505 skipCall |= addCmd(dev_data, pCB, CMD_CLEARCOLORIMAGE);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003506 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003507 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdClearColorImage()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003508 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003509 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearColorImage");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003510 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003511 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003512 dev_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003513}
3514
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003515VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearDepthStencilImage(
Chia-I Wu1f851912015-10-27 18:04:07 +08003516 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter315ad992015-09-15 18:03:22 -06003517 VkImage image, VkImageLayout imageLayout,
3518 const VkClearDepthStencilValue *pDepthStencil,
3519 uint32_t rangeCount,
3520 const VkImageSubresourceRange* pRanges)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003521{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003522 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003523 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3524 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003525 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003526 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003527 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003528 skipCall |= addCmd(dev_data, pCB, CMD_CLEARDEPTHSTENCILIMAGE);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003529 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003530 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdClearDepthStencilImage()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003531 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003532 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearDepthStencilImage");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003533 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003534 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003535 dev_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, pRanges);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003536}
3537
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003538VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdResolveImage(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003539 VkImage srcImage, VkImageLayout srcImageLayout,
Chia-I Wu1f851912015-10-27 18:04:07 +08003540 VkImage dstImage, VkImageLayout dstImageLayout,
Tony Barbour11f74372015-04-13 15:02:52 -06003541 uint32_t regionCount, const VkImageResolve* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003542{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003543 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003544 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3545 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003546 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003547 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003548 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003549 skipCall |= addCmd(dev_data, pCB, CMD_RESOLVEIMAGE);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003550 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003551 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResolveImage()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003552 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003553 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResolveImage");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003554 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003555 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003556 dev_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003557}
3558
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003559VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003560{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003561 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003562 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3563 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003564 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003565 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003566 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003567 skipCall |= addCmd(dev_data, pCB, CMD_SETEVENT);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003568 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003569 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdSetEvent()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003570 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003571 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003572 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003573 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003574 dev_data->device_dispatch_table->CmdSetEvent(commandBuffer, event, stageMask);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003575}
3576
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003577VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003578{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003579 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003580 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3581 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003582 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003583 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003584 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003585 skipCall |= addCmd(dev_data, pCB, CMD_RESETEVENT);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003586 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003587 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetEvent()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003588 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003589 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003590 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003591 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003592 dev_data->device_dispatch_table->CmdResetEvent(commandBuffer, event, stageMask);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003593}
3594
Michael Lentine27b0f902015-10-12 11:30:14 -05003595bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, const void* const* ppMemBarriers) {
3596 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
3597 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
3598 bool skip = false;
3599 for (uint32_t i = 0; i < memBarrierCount; ++i) {
3600 auto mem_barrier = reinterpret_cast<const VkMemoryBarrier*>(ppMemBarriers[i]);
3601 if (mem_barrier && mem_barrier->sType == VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER) {
3602 auto image_mem_barrier = reinterpret_cast<const VkImageMemoryBarrier*>(mem_barrier);
3603 auto image_data = pCB->imageLayoutMap.find(image_mem_barrier->image);
3604 if (image_data == pCB->imageLayoutMap.end()) {
3605 pCB->imageLayoutMap[image_mem_barrier->image].initialLayout = image_mem_barrier->oldLayout;
3606 pCB->imageLayoutMap[image_mem_barrier->image].layout = image_mem_barrier->newLayout;
3607 } else {
3608 if (image_data->second.layout != image_mem_barrier->oldLayout) {
3609 skip |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine8469dd62015-11-20 09:48:52 -08003610 "You cannot transition the layout from %s when current layout is %s.",
3611 string_VkImageLayout(image_mem_barrier->oldLayout), string_VkImageLayout(image_data->second.layout));
Michael Lentine27b0f902015-10-12 11:30:14 -05003612 }
3613 image_data->second.layout = image_mem_barrier->newLayout;
3614 }
3615 }
3616 }
3617 return skip;
3618}
3619
Michael Lentine8469dd62015-11-20 09:48:52 -08003620// AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set.
3621// If required_bit is zero, accessMask must have at least one of 'optional_bits' set
3622bool ValidateMaskBits(const layer_data* my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags& accessMask, const VkImageLayout& layout, VkAccessFlags required_bit, VkAccessFlags optional_bits) {
Michael Lentine472af7d2015-10-16 18:08:09 -05003623 bool skip_call = false;
Michael Lentine8469dd62015-11-20 09:48:52 -08003624 if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) {
3625 if (accessMask & !(required_bit | optional_bits)) {
Michael Lentine472af7d2015-10-16 18:08:09 -05003626 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
Michael Lentine8469dd62015-11-20 09:48:52 -08003627 "Additional bits in accessMask %d are specified when layout is %s.", accessMask, string_VkImageLayout(layout));
Michael Lentine472af7d2015-10-16 18:08:09 -05003628 }
3629 } else {
Michael Lentine8469dd62015-11-20 09:48:52 -08003630 if (!required_bit) {
3631 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
3632 "AccessMask %d must contain at least one of access bits %d when layout is %s.",
3633 accessMask, optional_bits, string_VkImageLayout(layout));
3634 } else {
3635 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
3636 "AccessMask %d must have required access bit %d and may have optional bits %d when layout is %s.",
3637 accessMask, required_bit, optional_bits,string_VkImageLayout(layout));
3638 }
Michael Lentine472af7d2015-10-16 18:08:09 -05003639 }
3640 return skip_call;
3641}
3642
Michael Lentine8469dd62015-11-20 09:48:52 -08003643bool ValidateMaskBitsFromLayouts(const layer_data* my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags& accessMask, const VkImageLayout& layout) {
Michael Lentine472af7d2015-10-16 18:08:09 -05003644 bool skip_call = false;
Michael Lentine8469dd62015-11-20 09:48:52 -08003645 switch (layout) {
3646 case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: {
3647 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, VK_ACCESS_COLOR_ATTACHMENT_READ_BIT);
3648 break;
Michael Lentine472af7d2015-10-16 18:08:09 -05003649 }
Michael Lentine8469dd62015-11-20 09:48:52 -08003650 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: {
3651 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT);
3652 break;
Michael Lentine472af7d2015-10-16 18:08:09 -05003653 }
Michael Lentine8469dd62015-11-20 09:48:52 -08003654 case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: {
3655 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0);
3656 break;
3657 }
3658 case VK_IMAGE_LAYOUT_PREINITIALIZED: {
3659 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0);
3660 break;
3661 }
3662 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: {
3663 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT);
3664 break;
3665 }
3666 case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: {
3667 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT);
3668 break;
3669 }
3670 case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: {
3671 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0);
3672 break;
3673 }
3674 case VK_IMAGE_LAYOUT_UNDEFINED: {
3675 if (accessMask != 0) {
3676 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
3677 "Additional bits in accessMask %d are specified when layout is %s.", accessMask, string_VkImageLayout(layout));
3678 }
3679 break;
3680 }
3681 case VK_IMAGE_LAYOUT_GENERAL:
3682 default: {
3683 break;
3684 }
Michael Lentine472af7d2015-10-16 18:08:09 -05003685 }
3686 return skip_call;
3687}
3688
Michael Lentine07ff1a12015-10-15 17:07:00 -05003689bool ValidateBarriers(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, const void* const* ppMemBarriers) {
3690 bool skip_call = false;
3691 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
3692 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
3693 if (pCB->activeRenderPass && memBarrierCount) {
3694 for (uint32_t i = 0; i < memBarrierCount; ++i) {
3695 auto mem_barrier = reinterpret_cast<const VkMemoryBarrier*>(ppMemBarriers[i]);
3696 if (mem_barrier && mem_barrier->sType != VK_STRUCTURE_TYPE_MEMORY_BARRIER) {
3697 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
3698 "Image or Buffers Barriers cannot be used during a render pass.");
3699 }
3700 }
3701 if (!dev_data->renderPassMap[pCB->activeRenderPass]->hasSelfDependency[pCB->activeSubpass]) {
3702 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
3703 "Barriers cannot be set during subpass %d with no self dependency specified.", pCB->activeSubpass);
3704 }
3705 }
Mark Lobodzinskib684b512015-11-20 09:27:27 -07003706
3707/***********************************************************************************************************
3708// Disable this validation until an optimal version is agreed upon
3709
Michael Lentine472af7d2015-10-16 18:08:09 -05003710 for (uint32_t i = 0; i < memBarrierCount; ++i) {
3711 auto mem_barrier = reinterpret_cast<const VkMemoryBarrier*>(ppMemBarriers[i]);
3712 if (mem_barrier && mem_barrier->sType == VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER) {
3713 auto image_mem_barrier = reinterpret_cast<const VkImageMemoryBarrier*>(mem_barrier);
Michael Lentine8469dd62015-11-20 09:48:52 -08003714 skip_call |= ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, image_mem_barrier->srcAccessMask, image_mem_barrier->oldLayout);
3715 skip_call |= ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, image_mem_barrier->dstAccessMask, image_mem_barrier->newLayout);
Michael Lentine472af7d2015-10-16 18:08:09 -05003716 }
3717 }
Mark Lobodzinskib684b512015-11-20 09:27:27 -07003718******************************************************************************************************************/
Michael Lentine07ff1a12015-10-15 17:07:00 -05003719 return skip_call;
3720}
3721
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003722VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent* pEvents, VkPipelineStageFlags sourceStageMask, VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const void* const* ppMemoryBarriers)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003723{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003724 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003725 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3726 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003727 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003728 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003729 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003730 skipCall |= addCmd(dev_data, pCB, CMD_WAITEVENTS);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003731 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003732 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003733 }
Michael Lentine27b0f902015-10-12 11:30:14 -05003734 skipCall |= TransitionImageLayouts(commandBuffer, memoryBarrierCount, ppMemoryBarriers);
Michael Lentine07ff1a12015-10-15 17:07:00 -05003735 skipCall |= ValidateBarriers(commandBuffer, memoryBarrierCount, ppMemoryBarriers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003736 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003737 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003738 dev_data->device_dispatch_table->CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, memoryBarrierCount, ppMemoryBarriers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003739}
3740
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003741VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const void* const* ppMemoryBarriers)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003742{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003743 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003744 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3745 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003746 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003747 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003748 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003749 skipCall |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003750 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003751 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPipelineBarrier()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003752 }
Michael Lentine27b0f902015-10-12 11:30:14 -05003753 skipCall |= TransitionImageLayouts(commandBuffer, memoryBarrierCount, ppMemoryBarriers);
Michael Lentine07ff1a12015-10-15 17:07:00 -05003754 skipCall |= ValidateBarriers(commandBuffer, memoryBarrierCount, ppMemoryBarriers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003755 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003756 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003757 dev_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, memoryBarrierCount, ppMemoryBarriers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003758}
3759
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003760VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003761{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003762 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003763 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3764 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003765 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003766 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003767 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003768 skipCall |= addCmd(dev_data, pCB, CMD_BEGINQUERY);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003769 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003770 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBeginQuery()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003771 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003772 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003773 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003774 dev_data->device_dispatch_table->CmdBeginQuery(commandBuffer, queryPool, slot, flags);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003775}
3776
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003777VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003778{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003779 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003780 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3781 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003782 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003783 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003784 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003785 skipCall |= addCmd(dev_data, pCB, CMD_ENDQUERY);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003786 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003787 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003788 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003789 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003790 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003791 dev_data->device_dispatch_table->CmdEndQuery(commandBuffer, queryPool, slot);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003792}
3793
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003794VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t startQuery, uint32_t queryCount)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003795{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003796 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003797 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3798 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003799 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003800 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003801 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003802 skipCall |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003803 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003804 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003805 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003806 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003807 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003808 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003809 dev_data->device_dispatch_table->CmdResetQueryPool(commandBuffer, queryPool, startQuery, queryCount);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003810}
3811
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003812VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t startQuery,
Chia-I Wu1f851912015-10-27 18:04:07 +08003813 uint32_t queryCount, VkBuffer dstBuffer, VkDeviceSize dstOffset,
Chia-I Wu1f6942d2015-10-26 18:36:20 +08003814 VkDeviceSize stride, VkQueryResultFlags flags)
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003815{
3816 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003817 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3818 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003819 if (pCB) {
3820 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003821 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003822 skipCall |= addCmd(dev_data, pCB, CMD_COPYQUERYPOOLRESULTS);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003823 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003824 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()");
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003825 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003826 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyQueryPoolResults");
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003827 }
3828 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003829 dev_data->device_dispatch_table->CmdCopyQueryPoolResults(commandBuffer, queryPool,
3830 startQuery, queryCount, dstBuffer, dstOffset, stride, flags);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06003831}
3832
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003833VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003834{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003835 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003836 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3837 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003838 if (pCB) {
Tobin Ehlise42007c2015-06-19 13:00:59 -06003839 if (pCB->state == CB_UPDATE_ACTIVE) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003840 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003841 skipCall |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003842 } else {
Chia-I Wu1f851912015-10-27 18:04:07 +08003843 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()");
Tobin Ehlise42007c2015-06-19 13:00:59 -06003844 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003845 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003846 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003847 dev_data->device_dispatch_table->CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003848}
3849
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003850VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkFramebuffer* pFramebuffer)
Tobin Ehlis2464b882015-04-01 08:40:34 -06003851{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003852 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08003853 VkResult result = dev_data->device_dispatch_table->CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06003854 if (VK_SUCCESS == result) {
Tobin Ehlis2464b882015-04-01 08:40:34 -06003855 // Shadow create info and store in map
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003856 VkFramebufferCreateInfo* localFBCI = new VkFramebufferCreateInfo(*pCreateInfo);
Chia-I Wuc278df82015-07-07 11:50:03 +08003857 if (pCreateInfo->pAttachments) {
Courtney Goeltzenleuchter1856d6f2015-09-01 17:30:39 -06003858 localFBCI->pAttachments = new VkImageView[localFBCI->attachmentCount];
3859 memcpy((void*)localFBCI->pAttachments, pCreateInfo->pAttachments, localFBCI->attachmentCount*sizeof(VkImageView));
Tobin Ehlis2464b882015-04-01 08:40:34 -06003860 }
Chia-I Wue420a332015-10-26 20:04:44 +08003861 dev_data->frameBufferMap[*pFramebuffer] = localFBCI;
Tobin Ehlis2464b882015-04-01 08:40:34 -06003862 }
3863 return result;
3864}
3865
Michael Lentine329697b2015-10-06 14:56:18 -07003866// Store the DAG.
3867struct DAGNode {
3868 uint32_t pass;
3869 std::vector<uint32_t> prev;
3870 std::vector<uint32_t> next;
3871};
3872
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003873VkBool32 FindDependency(const int index, const int dependent, const std::vector<DAGNode>& subpass_to_node, std::unordered_set<uint32_t>& processed_nodes) {
Michael Lentine329697b2015-10-06 14:56:18 -07003874 // If we have already checked this node we have not found a dependency path so return false.
3875 if (processed_nodes.count(index))
3876 return false;
3877 processed_nodes.insert(index);
3878 const DAGNode& node = subpass_to_node[index];
3879 // Look for a dependency path. If one exists return true else recurse on the previous nodes.
3880 if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) {
3881 for (auto elem : node.prev) {
3882 if (FindDependency(elem, dependent, subpass_to_node, processed_nodes))
3883 return true;
3884 }
3885 } else {
3886 return true;
3887 }
3888 return false;
3889}
3890
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003891VkBool32 CheckDependencyExists(const layer_data* my_data, VkDevice device, const int subpass, const std::vector<uint32_t>& dependent_subpasses, const std::vector<DAGNode>& subpass_to_node, VkBool32& skip_call) {
3892 VkBool32 result = true;
Michael Lentine329697b2015-10-06 14:56:18 -07003893 // Loop through all subpasses that share the same attachment and make sure a dependency exists
3894 for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) {
3895 if (subpass == dependent_subpasses[k])
3896 continue;
3897 const DAGNode& node = subpass_to_node[subpass];
3898 // Check for a specified dependency between the two nodes. If one exists we are done.
3899 auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]);
3900 auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]);
3901 if (prev_elem == node.prev.end() && next_elem == node.next.end()) {
3902 // If no dependency exits an implicit dependency still might. If so, warn and if not throw an error.
3903 std::unordered_set<uint32_t> processed_nodes;
3904 if (FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) ||
3905 FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes)) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003906 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine329697b2015-10-06 14:56:18 -07003907 "A dependency between subpasses %d and %d must exist but only an implicit one is specified.",
3908 subpass, dependent_subpasses[k]);
3909 } else {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003910 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine329697b2015-10-06 14:56:18 -07003911 "A dependency between subpasses %d and %d must exist but one is not specified.",
3912 subpass, dependent_subpasses[k]);
3913 result = false;
3914 }
3915 }
3916 }
3917 return result;
3918}
3919
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003920VkBool32 CheckPreserved(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, const int index, const int attachment, const std::vector<DAGNode>& subpass_to_node, int depth, VkBool32& skip_call) {
Michael Lentine329697b2015-10-06 14:56:18 -07003921 const DAGNode& node = subpass_to_node[index];
3922 // If this node writes to the attachment return true as next nodes need to preserve the attachment.
3923 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[index];
Chia-I Wu763a7492015-10-26 20:48:51 +08003924 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07003925 if (attachment == subpass.pColorAttachments[j].attachment)
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003926 return VK_TRUE;
Michael Lentine329697b2015-10-06 14:56:18 -07003927 }
Chia-I Wuce532f72015-10-26 17:32:47 +08003928 if (subpass.pDepthStencilAttachment &&
3929 subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) {
3930 if (attachment == subpass.pDepthStencilAttachment->attachment)
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003931 return VK_TRUE;
Michael Lentine329697b2015-10-06 14:56:18 -07003932 }
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003933 VkBool32 result = VK_FALSE;
Michael Lentine329697b2015-10-06 14:56:18 -07003934 // Loop through previous nodes and see if any of them write to the attachment.
3935 for (auto elem : node.prev) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003936 result |= CheckPreserved(my_data, device, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07003937 }
3938 // If the attachment was written to by a previous node than this node needs to preserve it.
3939 if (result && depth > 0) {
3940 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[index];
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07003941 VkBool32 has_preserved = false;
Chia-I Wu763a7492015-10-26 20:48:51 +08003942 for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07003943 if (subpass.pPreserveAttachments[j].attachment == attachment) {
3944 has_preserved = true;
3945 break;
3946 }
3947 }
3948 if (!has_preserved) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003949 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine329697b2015-10-06 14:56:18 -07003950 "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index);
3951 }
3952 }
3953 return result;
3954}
3955
Michael Lentine27b0f902015-10-12 11:30:14 -05003956VkBool32 ValidateDependencies(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, std::vector<DAGNode>& subpass_to_node) {
3957 VkBool32 skip_call = false;
Michael Lentine329697b2015-10-06 14:56:18 -07003958 std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount);
3959 std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount);
Michael Lentine27b0f902015-10-12 11:30:14 -05003960
Michael Lentine329697b2015-10-06 14:56:18 -07003961 // Create DAG
3962 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
3963 DAGNode& subpass_node = subpass_to_node[i];
3964 subpass_node.pass = i;
3965 }
3966 for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) {
3967 const VkSubpassDependency& dependency = pCreateInfo->pDependencies[i];
Chia-I Wu1f851912015-10-27 18:04:07 +08003968 if (dependency.srcSubpass > dependency.dstSubpass) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003969 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine329697b2015-10-06 14:56:18 -07003970 "Dependency graph must be specified such that an earlier pass cannot depend on a later pass.");
3971 }
Chia-I Wu1f851912015-10-27 18:04:07 +08003972 subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass);
3973 subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass);
Michael Lentine329697b2015-10-06 14:56:18 -07003974 }
Michael Lentine27b0f902015-10-12 11:30:14 -05003975
Michael Lentine329697b2015-10-06 14:56:18 -07003976 // Find for each attachment the subpasses that use them.
3977 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
3978 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i];
Chia-I Wu763a7492015-10-26 20:48:51 +08003979 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07003980 input_attachment_to_subpass[subpass.pInputAttachments[j].attachment].push_back(i);
3981 }
Chia-I Wu763a7492015-10-26 20:48:51 +08003982 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07003983 output_attachment_to_subpass[subpass.pColorAttachments[j].attachment].push_back(i);
3984 }
Chia-I Wuce532f72015-10-26 17:32:47 +08003985 if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) {
3986 output_attachment_to_subpass[subpass.pDepthStencilAttachment->attachment].push_back(i);
Michael Lentine329697b2015-10-06 14:56:18 -07003987 }
3988 }
3989 // If there is a dependency needed make sure one exists
3990 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
3991 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i];
3992 // If the attachment is an input then all subpasses that output must have a dependency relationship
Chia-I Wu763a7492015-10-26 20:48:51 +08003993 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07003994 const uint32_t& attachment = subpass.pInputAttachments[j].attachment;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003995 CheckDependencyExists(my_data, device, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07003996 }
3997 // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship
Chia-I Wu763a7492015-10-26 20:48:51 +08003998 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07003999 const uint32_t& attachment = subpass.pColorAttachments[j].attachment;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004000 CheckDependencyExists(my_data, device, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call);
4001 CheckDependencyExists(my_data, device, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07004002 }
Chia-I Wuce532f72015-10-26 17:32:47 +08004003 if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) {
4004 const uint32_t& attachment = subpass.pDepthStencilAttachment->attachment;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004005 CheckDependencyExists(my_data, device, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call);
4006 CheckDependencyExists(my_data, device, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07004007 }
4008 }
4009 // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was written.
4010 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
4011 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i];
Chia-I Wu763a7492015-10-26 20:48:51 +08004012 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004013 CheckPreserved(my_data, device, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07004014 }
4015 }
4016 return skip_call;
4017}
4018
Michael Lentine27b0f902015-10-12 11:30:14 -05004019bool ValidateLayouts(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo) {
4020 bool skip = false;
4021 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
4022 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i];
4023 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
4024 if (subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL &&
4025 subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) {
4026 if (subpass.pInputAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) {
4027 skip |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4028 "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL.");
4029 } else {
4030 skip |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4031 "Layout for input attachment is %d but can only be READ_ONLY_OPTIMAL or GENERAL.", subpass.pInputAttachments[j].attachment);
4032 }
4033 }
4034 }
4035 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
4036 if (subpass.pColorAttachments[j].layout != VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL) {
4037 if (subpass.pColorAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) {
4038 skip |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4039 "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL.");
4040 } else {
4041 skip |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4042 "Layout for color attachment is %d but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", subpass.pColorAttachments[j].attachment);
4043 }
4044 }
4045 }
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06004046 if ((subpass.pDepthStencilAttachment != NULL) &&
4047 (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) {
Michael Lentine27b0f902015-10-12 11:30:14 -05004048 if (subpass.pDepthStencilAttachment->layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL) {
4049 if (subpass.pDepthStencilAttachment->layout == VK_IMAGE_LAYOUT_GENERAL) {
4050 skip |= log_msg(my_data->report_data, VK_DBG_REPORT_WARN_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4051 "Layout for depth attachment is GENERAL but should be DEPTH_STENCIL_ATTACHMENT_OPTIMAL.");
4052 } else {
4053 skip |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4054 "Layout for depth attachment is %d but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL or GENERAL.", subpass.pDepthStencilAttachment->attachment);
4055 }
4056 }
4057 }
4058 }
4059 return skip;
4060}
4061
Michael Lentine07ff1a12015-10-15 17:07:00 -05004062bool CreatePassDAG(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, std::vector<DAGNode>& subpass_to_node, std::vector<bool>& has_self_dependency) {
Michael Lentine27b0f902015-10-12 11:30:14 -05004063 bool skip_call = false;
4064 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
4065 DAGNode& subpass_node = subpass_to_node[i];
4066 subpass_node.pass = i;
4067 }
4068 for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) {
4069 const VkSubpassDependency& dependency = pCreateInfo->pDependencies[i];
4070 if (dependency.srcSubpass > dependency.dstSubpass) {
4071 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
4072 "Depedency graph must be specified such that an earlier pass cannot depend on a later pass.");
Michael Lentine07ff1a12015-10-15 17:07:00 -05004073 } else if (dependency.srcSubpass == dependency.dstSubpass) {
4074 has_self_dependency[dependency.srcSubpass] = true;
Michael Lentine27b0f902015-10-12 11:30:14 -05004075 }
4076 subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass);
4077 subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass);
4078 }
4079 return skip_call;
4080}
4081
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004082VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkRenderPass* pRenderPass)
Tobin Ehlis2464b882015-04-01 08:40:34 -06004083{
Michael Lentine27b0f902015-10-12 11:30:14 -05004084 bool skip_call = false;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004085 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Michael Lentine27b0f902015-10-12 11:30:14 -05004086 // Create DAG
Michael Lentine07ff1a12015-10-15 17:07:00 -05004087 std::vector<bool> has_self_dependency(pCreateInfo->subpassCount);
Michael Lentine27b0f902015-10-12 11:30:14 -05004088 std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount);
Michael Lentine07ff1a12015-10-15 17:07:00 -05004089 skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency);
Michael Lentine27b0f902015-10-12 11:30:14 -05004090 // Validate using DAG
4091 skip_call |= ValidateDependencies(dev_data, device, pCreateInfo, subpass_to_node);
4092 skip_call |= ValidateLayouts(dev_data, device, pCreateInfo);
4093 if (skip_call) {
Michael Lentine329697b2015-10-06 14:56:18 -07004094 return VK_ERROR_VALIDATION_FAILED;
4095 }
Chia-I Wu69f40122015-10-26 21:10:41 +08004096 VkResult result = dev_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004097 if (VK_SUCCESS == result) {
Tobin Ehlis2464b882015-04-01 08:40:34 -06004098 // Shadow create info and store in map
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06004099 VkRenderPassCreateInfo* localRPCI = new VkRenderPassCreateInfo(*pCreateInfo);
Chia-I Wuc278df82015-07-07 11:50:03 +08004100 if (pCreateInfo->pAttachments) {
4101 localRPCI->pAttachments = new VkAttachmentDescription[localRPCI->attachmentCount];
4102 memcpy((void*)localRPCI->pAttachments, pCreateInfo->pAttachments, localRPCI->attachmentCount*sizeof(VkAttachmentDescription));
Tobin Ehlis2464b882015-04-01 08:40:34 -06004103 }
Chia-I Wuc278df82015-07-07 11:50:03 +08004104 if (pCreateInfo->pSubpasses) {
4105 localRPCI->pSubpasses = new VkSubpassDescription[localRPCI->subpassCount];
4106 memcpy((void*)localRPCI->pSubpasses, pCreateInfo->pSubpasses, localRPCI->subpassCount*sizeof(VkSubpassDescription));
4107
4108 for (uint32_t i = 0; i < localRPCI->subpassCount; i++) {
4109 VkSubpassDescription *subpass = (VkSubpassDescription *) &localRPCI->pSubpasses[i];
Chia-I Wu763a7492015-10-26 20:48:51 +08004110 const uint32_t attachmentCount = subpass->inputAttachmentCount +
4111 subpass->colorAttachmentCount * (1 + (subpass->pResolveAttachments?1:0)) +
Chia-I Wuce532f72015-10-26 17:32:47 +08004112 ((subpass->pDepthStencilAttachment) ? 1 : 0) + subpass->preserveAttachmentCount;
Chia-I Wuc278df82015-07-07 11:50:03 +08004113 VkAttachmentReference *attachments = new VkAttachmentReference[attachmentCount];
4114
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004115 memcpy(attachments, subpass->pInputAttachments,
Chia-I Wu763a7492015-10-26 20:48:51 +08004116 sizeof(attachments[0]) * subpass->inputAttachmentCount);
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004117 subpass->pInputAttachments = attachments;
Chia-I Wu763a7492015-10-26 20:48:51 +08004118 attachments += subpass->inputAttachmentCount;
Chia-I Wuc278df82015-07-07 11:50:03 +08004119
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004120 memcpy(attachments, subpass->pColorAttachments,
Chia-I Wu763a7492015-10-26 20:48:51 +08004121 sizeof(attachments[0]) * subpass->colorAttachmentCount);
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004122 subpass->pColorAttachments = attachments;
Chia-I Wu763a7492015-10-26 20:48:51 +08004123 attachments += subpass->colorAttachmentCount;
Chia-I Wuc278df82015-07-07 11:50:03 +08004124
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004125 if (subpass->pResolveAttachments) {
4126 memcpy(attachments, subpass->pResolveAttachments,
Chia-I Wu763a7492015-10-26 20:48:51 +08004127 sizeof(attachments[0]) * subpass->colorAttachmentCount);
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004128 subpass->pResolveAttachments = attachments;
Chia-I Wu763a7492015-10-26 20:48:51 +08004129 attachments += subpass->colorAttachmentCount;
Chia-I Wuc278df82015-07-07 11:50:03 +08004130 }
4131
Chia-I Wuce532f72015-10-26 17:32:47 +08004132 if (subpass->pDepthStencilAttachment) {
4133 memcpy(attachments, subpass->pDepthStencilAttachment,
4134 sizeof(attachments[0]) * 1);
4135 subpass->pDepthStencilAttachment = attachments;
4136 attachments += 1;
4137 }
4138
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004139 memcpy(attachments, subpass->pPreserveAttachments,
Chia-I Wu763a7492015-10-26 20:48:51 +08004140 sizeof(attachments[0]) * subpass->preserveAttachmentCount);
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004141 subpass->pPreserveAttachments = attachments;
Chia-I Wuc278df82015-07-07 11:50:03 +08004142 }
Tobin Ehlis2464b882015-04-01 08:40:34 -06004143 }
Chia-I Wuc278df82015-07-07 11:50:03 +08004144 if (pCreateInfo->pDependencies) {
4145 localRPCI->pDependencies = new VkSubpassDependency[localRPCI->dependencyCount];
4146 memcpy((void*)localRPCI->pDependencies, pCreateInfo->pDependencies, localRPCI->dependencyCount*sizeof(VkSubpassDependency));
Tobin Ehlis2464b882015-04-01 08:40:34 -06004147 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004148 dev_data->renderPassMap[*pRenderPass] = new RENDER_PASS_NODE();
4149 dev_data->renderPassMap[*pRenderPass]->hasSelfDependency = has_self_dependency;
4150 dev_data->renderPassMap[*pRenderPass]->createInfo = localRPCI;
Tobin Ehlis2464b882015-04-01 08:40:34 -06004151 }
4152 return result;
4153}
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004154// Free the renderpass shadow
4155static void deleteRenderPasses(layer_data* my_data)
4156{
4157 if (my_data->renderPassMap.size() <= 0)
4158 return;
4159 for (auto ii=my_data->renderPassMap.begin(); ii!=my_data->renderPassMap.end(); ++ii) {
Michael Lentine07ff1a12015-10-15 17:07:00 -05004160 const VkRenderPassCreateInfo* pRenderPassInfo = (*ii).second->createInfo;
4161 if (pRenderPassInfo->pAttachments) {
4162 delete[] pRenderPassInfo->pAttachments;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004163 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004164 if (pRenderPassInfo->pSubpasses) {
4165 for (uint32_t i=0; i<pRenderPassInfo->subpassCount; ++i) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004166 // Attachements are all allocated in a block, so just need to
4167 // find the first non-null one to delete
Michael Lentine07ff1a12015-10-15 17:07:00 -05004168 if (pRenderPassInfo->pSubpasses[i].pInputAttachments) {
4169 delete[] pRenderPassInfo->pSubpasses[i].pInputAttachments;
4170 } else if (pRenderPassInfo->pSubpasses[i].pColorAttachments) {
4171 delete[] pRenderPassInfo->pSubpasses[i].pColorAttachments;
4172 } else if (pRenderPassInfo->pSubpasses[i].pResolveAttachments) {
4173 delete[] pRenderPassInfo->pSubpasses[i].pResolveAttachments;
4174 } else if (pRenderPassInfo->pSubpasses[i].pPreserveAttachments) {
4175 delete[] pRenderPassInfo->pSubpasses[i].pPreserveAttachments;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004176 }
4177 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004178 delete[] pRenderPassInfo->pSubpasses;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004179 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004180 if (pRenderPassInfo->pDependencies) {
4181 delete[] pRenderPassInfo->pDependencies;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004182 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004183 delete (*ii).second;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004184 }
4185 my_data->renderPassMap.clear();
4186}
Michael Lentine27b0f902015-10-12 11:30:14 -05004187
4188bool VerifyFramebufferAndRenderPassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo* pRenderPassBegin) {
4189 bool skip_call = false;
4190 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
4191 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
Michael Lentine07ff1a12015-10-15 17:07:00 -05004192 const VkRenderPassCreateInfo* pRenderPassInfo = dev_data->renderPassMap[pRenderPassBegin->renderPass]->createInfo;
Michael Lentine27b0f902015-10-12 11:30:14 -05004193 const VkFramebufferCreateInfo* pFramebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer];
4194 if (pRenderPassInfo->attachmentCount != pFramebufferInfo->attachmentCount) {
4195 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
4196 "You cannot start a render pass using a framebuffer with a different number of attachments.");
4197 }
4198 for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) {
4199 const VkImageView& image_view = pFramebufferInfo->pAttachments[i];
4200 const VkImage& image = dev_data->imageViewMap[image_view]->image;
4201 auto image_data = pCB->imageLayoutMap.find(image);
4202 if (image_data == pCB->imageLayoutMap.end()) {
4203 pCB->imageLayoutMap[image].initialLayout = pRenderPassInfo->pAttachments[i].initialLayout;
4204 pCB->imageLayoutMap[image].layout = pRenderPassInfo->pAttachments[i].initialLayout;
4205 } else if (pRenderPassInfo->pAttachments[i].initialLayout != image_data->second.layout) {
4206 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
4207 "You cannot start a render pass using attachment %i where the intial layout differs from the starting layout.", i);
4208 }
4209 }
4210 return skip_call;
4211}
4212
4213void TransitionSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo* pRenderPassBegin, const int subpass_index) {
4214 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
4215 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
4216 auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass);
4217 if (render_pass_data == dev_data->renderPassMap.end()) {
4218 return;
4219 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004220 const VkRenderPassCreateInfo* pRenderPassInfo = render_pass_data->second->createInfo;
Michael Lentine27b0f902015-10-12 11:30:14 -05004221 auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer);
4222 if (framebuffer_data == dev_data->frameBufferMap.end()) {
4223 return;
4224 }
4225 const VkFramebufferCreateInfo* pFramebufferInfo = framebuffer_data->second;
4226 const VkSubpassDescription& subpass = pRenderPassInfo->pSubpasses[subpass_index];
4227 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
4228 const VkImageView& image_view = pFramebufferInfo->pAttachments[subpass.pInputAttachments[j].attachment];
4229 auto image_view_data = dev_data->imageViewMap.find(image_view);
4230 if (image_view_data != dev_data->imageViewMap.end()) {
4231 auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image);
4232 if (image_layout != pCB->imageLayoutMap.end()) {
4233 image_layout->second.layout = subpass.pInputAttachments[j].layout;
4234 }
4235 }
4236 }
4237 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
4238 const VkImageView& image_view = pFramebufferInfo->pAttachments[subpass.pColorAttachments[j].attachment];
4239 auto image_view_data = dev_data->imageViewMap.find(image_view);
4240 if (image_view_data != dev_data->imageViewMap.end()) {
4241 auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image);
4242 if (image_layout != pCB->imageLayoutMap.end()) {
4243 image_layout->second.layout = subpass.pColorAttachments[j].layout;
4244 }
4245 }
4246 }
Michael Lentine2b9eda42015-10-28 15:55:18 -07004247 if ((subpass.pDepthStencilAttachment != NULL) &&
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06004248 (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) {
Michael Lentine27b0f902015-10-12 11:30:14 -05004249 const VkImageView& image_view = pFramebufferInfo->pAttachments[subpass.pDepthStencilAttachment->attachment];
4250 auto image_view_data = dev_data->imageViewMap.find(image_view);
4251 if (image_view_data != dev_data->imageViewMap.end()) {
4252 auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image);
4253 if (image_layout != pCB->imageLayoutMap.end()) {
4254 image_layout->second.layout = subpass.pDepthStencilAttachment->layout;
4255 }
4256 }
4257 }
4258}
4259
Michael Lentine2b9eda42015-10-28 15:55:18 -07004260bool validatePrimaryCommandBuffer(const layer_data* my_data, const GLOBAL_CB_NODE* pCB, const std::string& cmd_name) {
4261 bool skip_call = false;
4262 if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) {
4263 skip_call |= log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
4264 "Cannot execute command %s on a secondary command buffer.", cmd_name.c_str());
4265 }
4266 return skip_call;
4267}
4268
Michael Lentine27b0f902015-10-12 11:30:14 -05004269void TransitionFinalSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo* pRenderPassBegin) {
4270 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
4271 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
4272 auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass);
4273 if (render_pass_data == dev_data->renderPassMap.end()) {
4274 return;
4275 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004276 const VkRenderPassCreateInfo* pRenderPassInfo = render_pass_data->second->createInfo;
Michael Lentine27b0f902015-10-12 11:30:14 -05004277 auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer);
4278 if (framebuffer_data == dev_data->frameBufferMap.end()) {
4279 return;
4280 }
4281 const VkFramebufferCreateInfo* pFramebufferInfo = framebuffer_data->second;
4282 for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) {
4283 const VkImageView& image_view = pFramebufferInfo->pAttachments[i];
4284 auto image_view_data = dev_data->imageViewMap.find(image_view);
4285 if (image_view_data != dev_data->imageViewMap.end()) {
4286 auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image);
4287 if (image_layout != pCB->imageLayoutMap.end()) {
4288 image_layout->second.layout = pRenderPassInfo->pAttachments[i].finalLayout;
4289 }
4290 }
4291 }
4292}
4293
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004294VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004295{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004296 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004297 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4298 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004299 if (pCB) {
Tobin Ehlis8b6c2352015-06-23 16:13:03 -06004300 if (pRenderPassBegin && pRenderPassBegin->renderPass) {
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06004301 skipCall |= VerifyFramebufferAndRenderPassLayouts(commandBuffer, pRenderPassBegin);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004302 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBeginRenderPass");
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004303 updateCBTracking(pCB);
Michael Lentine2b9eda42015-10-28 15:55:18 -07004304 skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdBeginRenderPass");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004305 skipCall |= addCmd(dev_data, pCB, CMD_BEGINRENDERPASS);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004306 pCB->activeRenderPass = pRenderPassBegin->renderPass;
Michael Lentine27b0f902015-10-12 11:30:14 -05004307 // This is a shallow copy as that is all that is needed for now
4308 pCB->activeRenderPassBeginInfo = *pRenderPassBegin;
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004309 pCB->activeSubpass = 0;
4310 pCB->framebuffer = pRenderPassBegin->framebuffer;
4311 if (pCB->lastBoundPipeline) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004312 skipCall |= validatePipelineState(dev_data, pCB, VK_PIPELINE_BIND_POINT_GRAPHICS, pCB->lastBoundPipeline);
Tobin Ehlis8b6c2352015-06-23 16:13:03 -06004313 }
Tobin Ehlise4076782015-06-24 15:53:07 -06004314 } else {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004315 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Tobin Ehlis8b6c2352015-06-23 16:13:03 -06004316 "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()");
Tony Barbourb9f82ba2015-04-06 11:09:26 -06004317 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004318 }
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06004319 if (VK_FALSE == skipCall) {
Chia-I Wu1f851912015-10-27 18:04:07 +08004320 dev_data->device_dispatch_table->CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents);
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06004321 // This is a shallow copy as that is all that is needed for now
4322 dev_data->renderPassBeginInfo = *pRenderPassBegin;
4323 dev_data->currentSubpass = 0;
4324 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004325}
4326
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004327VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents)
Chia-I Wuc278df82015-07-07 11:50:03 +08004328{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004329 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004330 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4331 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Michael Lentine27b0f902015-10-12 11:30:14 -05004332 TransitionSubpassLayouts(commandBuffer, &dev_data->renderPassBeginInfo, ++dev_data->currentSubpass);
Chia-I Wuc278df82015-07-07 11:50:03 +08004333 if (pCB) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004334 updateCBTracking(pCB);
Michael Lentine2b9eda42015-10-28 15:55:18 -07004335 skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004336 skipCall |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004337 pCB->activeSubpass++;
Michael Lentine27b0f902015-10-12 11:30:14 -05004338 TransitionSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo, ++pCB->activeSubpass);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004339 if (pCB->lastBoundPipeline) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004340 skipCall |= validatePipelineState(dev_data, pCB, VK_PIPELINE_BIND_POINT_GRAPHICS, pCB->lastBoundPipeline);
Chia-I Wuc278df82015-07-07 11:50:03 +08004341 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004342 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass");
Chia-I Wuc278df82015-07-07 11:50:03 +08004343 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004344 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004345 dev_data->device_dispatch_table->CmdNextSubpass(commandBuffer, contents);
Chia-I Wuc278df82015-07-07 11:50:03 +08004346}
4347
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004348VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndRenderPass(VkCommandBuffer commandBuffer)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004349{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004350 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004351 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4352 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Michael Lentine27b0f902015-10-12 11:30:14 -05004353 TransitionFinalSubpassLayouts(commandBuffer, &dev_data->renderPassBeginInfo);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004354 if (pCB) {
Michael Lentine2b9eda42015-10-28 15:55:18 -07004355 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass");
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004356 updateCBTracking(pCB);
Michael Lentine2b9eda42015-10-28 15:55:18 -07004357 skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004358 skipCall |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS);
Michael Lentine27b0f902015-10-12 11:30:14 -05004359 TransitionFinalSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004360 pCB->activeRenderPass = 0;
4361 pCB->activeSubpass = 0;
Chia-I Wu88eaa3b2015-06-26 15:34:39 +08004362 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004363 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004364 dev_data->device_dispatch_table->CmdEndRenderPass(commandBuffer);
Chia-I Wu88eaa3b2015-06-26 15:34:39 +08004365}
4366
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004367VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer* pCommandBuffers)
Chia-I Wu88eaa3b2015-06-26 15:34:39 +08004368{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004369 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004370 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4371 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Chia-I Wu88eaa3b2015-06-26 15:34:39 +08004372 if (pCB) {
Tobin Ehlis5f728d32015-09-17 14:18:16 -06004373 GLOBAL_CB_NODE* pSubCB = NULL;
Chia-I Wu1f851912015-10-27 18:04:07 +08004374 for (uint32_t i=0; i<commandBuffersCount; i++) {
4375 pSubCB = getCBNode(dev_data, pCommandBuffers[i]);
Tobin Ehlis5f728d32015-09-17 14:18:16 -06004376 if (!pSubCB) {
Chia-I Wu1f851912015-10-27 18:04:07 +08004377 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS",
4378 "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p in element %u of pCommandBuffers array.", (void*)pCommandBuffers[i], i);
4379 } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) {
4380 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS",
4381 "vkCmdExecuteCommands() called w/ Primary Cmd Buffer %p in element %u of pCommandBuffers array. All cmd buffers in pCommandBuffers array must be secondary.", (void*)pCommandBuffers[i], i);
Tobin Ehlis5f728d32015-09-17 14:18:16 -06004382 }
4383 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004384 updateCBTracking(pCB);
Michael Lentine2b9eda42015-10-28 15:55:18 -07004385 skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004386 skipCall |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004387 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004388 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004389 dev_data->device_dispatch_table->CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004390}
4391
Michael Lentineee4ad4d2015-10-23 12:41:44 -07004392bool ValidateMapImageLayouts(VkDevice device, VkDeviceMemory mem) {
4393 bool skip_call = false;
4394 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
4395 auto mem_data = dev_data->memImageMap.find(mem);
4396 if (mem_data != dev_data->memImageMap.end()) {
4397 auto image_data = dev_data->imageLayoutMap.find(mem_data->second);
4398 if (image_data != dev_data->imageLayoutMap.end()) {
4399 if (image_data->second->layout != VK_IMAGE_LAYOUT_PREINITIALIZED && image_data->second->layout != VK_IMAGE_LAYOUT_GENERAL) {
4400 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType) 0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4401 "Cannot map an image with layout %d. Only GENERAL or PREINITIALIZED are supported.", image_data->second->layout);
4402 }
4403 }
4404 }
4405 return skip_call;
4406}
4407
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004408VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkMapMemory(
Michael Lentineee4ad4d2015-10-23 12:41:44 -07004409 VkDevice device,
4410 VkDeviceMemory mem,
4411 VkDeviceSize offset,
4412 VkDeviceSize size,
4413 VkFlags flags,
4414 void **ppData)
4415{
4416 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
4417 bool skip_call = ValidateMapImageLayouts(device, mem);
4418 if (VK_FALSE == skip_call) {
4419 return dev_data->device_dispatch_table->MapMemory(device, mem, offset, size, flags, ppData);
4420 }
4421 return VK_ERROR_VALIDATION_FAILED;
4422}
4423
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004424VKAPI_ATTR VkResult VKAPI_CALL vkBindImageMemory(
Michael Lentineee4ad4d2015-10-23 12:41:44 -07004425 VkDevice device,
4426 VkImage image,
4427 VkDeviceMemory mem,
4428 VkDeviceSize memOffset)
4429{
4430 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
4431 VkResult result = dev_data->device_dispatch_table->BindImageMemory(device, image, mem, memOffset);
4432 loader_platform_thread_lock_mutex(&globalLock);
4433 dev_data->memImageMap[mem] = image;
4434 loader_platform_thread_unlock_mutex(&globalLock);
4435 return result;
4436}
4437
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004438VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSwapchainKHR(
Michael Lentine27b0f902015-10-12 11:30:14 -05004439 VkDevice device,
4440 const VkSwapchainCreateInfoKHR *pCreateInfo,
4441 VkSwapchainKHR *pSwapchain)
4442{
4443 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
4444 VkResult result = dev_data->device_dispatch_table->CreateSwapchainKHR(device, pCreateInfo, pSwapchain);
4445
4446 if (VK_SUCCESS == result) {
4447 SWAPCHAIN_NODE *swapchain_data = new SWAPCHAIN_NODE;
4448 loader_platform_thread_lock_mutex(&globalLock);
4449 dev_data->device_extensions.swapchainMap[*pSwapchain] = swapchain_data;
4450 loader_platform_thread_unlock_mutex(&globalLock);
4451 }
4452
4453 return result;
4454}
4455
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004456VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkDestroySwapchainKHR(
Michael Lentine27b0f902015-10-12 11:30:14 -05004457 VkDevice device,
4458 VkSwapchainKHR swapchain)
4459{
4460 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Michael Lentine27b0f902015-10-12 11:30:14 -05004461
4462 loader_platform_thread_lock_mutex(&globalLock);
4463 auto swapchain_data = dev_data->device_extensions.swapchainMap.find(swapchain);
4464 if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) {
4465 if (swapchain_data->second->images.size() > 0) {
4466 for (auto swapchain_image : swapchain_data->second->images) {
4467 auto image_item = dev_data->imageLayoutMap.find(swapchain_image);
4468 if (image_item != dev_data->imageLayoutMap.end())
4469 dev_data->imageLayoutMap.erase(image_item);
4470 }
4471 }
4472 delete swapchain_data->second;
4473 dev_data->device_extensions.swapchainMap.erase(swapchain);
4474 }
4475 loader_platform_thread_unlock_mutex(&globalLock);
4476 return dev_data->device_dispatch_table->DestroySwapchainKHR(device, swapchain);
4477}
4478
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004479VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkGetSwapchainImagesKHR(
Michael Lentine27b0f902015-10-12 11:30:14 -05004480 VkDevice device,
4481 VkSwapchainKHR swapchain,
4482 uint32_t* pCount,
4483 VkImage* pSwapchainImages)
4484{
4485 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
4486 VkResult result = dev_data->device_dispatch_table->GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages);
4487
4488 if (result == VK_SUCCESS && pSwapchainImages != NULL) {
4489 // This should never happen and is checked by param checker.
4490 if (!pCount) return result;
4491 for (uint32_t i = 0; i < *pCount; ++i) {
4492 IMAGE_NODE* image_node = new IMAGE_NODE;
4493 image_node->layout = VK_IMAGE_LAYOUT_UNDEFINED;
4494 loader_platform_thread_lock_mutex(&globalLock);
4495 dev_data->device_extensions.swapchainMap[swapchain]->images.push_back(pSwapchainImages[i]);
4496 dev_data->imageLayoutMap[pSwapchainImages[i]] = image_node;
4497 loader_platform_thread_unlock_mutex(&globalLock);
4498 }
4499 }
4500 return result;
4501}
4502
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004503VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueuePresentKHR(VkQueue queue, VkPresentInfoKHR* pPresentInfo)
Michael Lentine27b0f902015-10-12 11:30:14 -05004504{
4505 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map);
4506 bool skip_call = false;
4507
4508 if (pPresentInfo) {
4509 for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) {
4510 auto swapchain_data = dev_data->device_extensions.swapchainMap.find(pPresentInfo->swapchains[i]);
4511 if (swapchain_data != dev_data->device_extensions.swapchainMap.end() && pPresentInfo->imageIndices[i] < swapchain_data->second->images.size()) {
4512 VkImage image = swapchain_data->second->images[pPresentInfo->imageIndices[i]];
4513 auto image_data = dev_data->imageLayoutMap.find(image);
4514 if (image_data != dev_data->imageLayoutMap.end()) {
4515 if (image_data->second->layout != VK_IMAGE_LAYOUT_PRESENT_SOURCE_KHR) {
4516 skip_call |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_QUEUE, (uint64_t)queue, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
4517 "Images passed to present must be in layout PRESENT_SOURCE_KHR but is in %d", image_data->second->layout);
4518 }
4519 }
4520 }
4521 }
4522 }
4523
4524 if (VK_FALSE == skip_call)
4525 return dev_data->device_dispatch_table->QueuePresentKHR(queue, pPresentInfo);
4526 return VK_ERROR_VALIDATION_FAILED;
4527}
4528
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004529VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkDbgCreateMsgCallback(
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -06004530 VkInstance instance,
4531 VkFlags msgFlags,
4532 const PFN_vkDbgMsgCallback pfnMsgCallback,
4533 void* pUserData,
4534 VkDbgMsgCallback* pMsgCallback)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004535{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004536 layer_data* my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map);
4537 VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table;
Tobin Ehlisc91330b2015-06-16 09:04:30 -06004538 VkResult res = pTable->DbgCreateMsgCallback(instance, msgFlags, pfnMsgCallback, pUserData, pMsgCallback);
4539 if (VK_SUCCESS == res) {
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004540 //layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map);
Tobin Ehlisc91330b2015-06-16 09:04:30 -06004541 res = layer_create_msg_callback(my_data->report_data, msgFlags, pfnMsgCallback, pUserData, pMsgCallback);
4542 }
4543 return res;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004544}
4545
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004546VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkDbgDestroyMsgCallback(
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -06004547 VkInstance instance,
4548 VkDbgMsgCallback msgCallback)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004549{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004550 layer_data* my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map);
4551 VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table;
Tobin Ehlisc91330b2015-06-16 09:04:30 -06004552 VkResult res = pTable->DbgDestroyMsgCallback(instance, msgCallback);
Tobin Ehlisc91330b2015-06-16 09:04:30 -06004553 layer_destroy_msg_callback(my_data->report_data, msgCallback);
4554 return res;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004555}
4556
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004557VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDbgMarkerBegin(VkCommandBuffer commandBuffer, const char* pMarker)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004558{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004559 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004560 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4561 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004562 if (!dev_data->device_extensions.debug_marker_enabled) {
Chia-I Wu1f851912015-10-27 18:04:07 +08004563 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, (uint64_t)commandBuffer, 0, DRAWSTATE_INVALID_EXTENSION, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06004564 "Attempt to use CmdDbgMarkerBegin but extension disabled!");
Jon Ashburn6f8cd632015-06-01 09:37:38 -06004565 return;
Tobin Ehlisa366ca22015-06-19 15:07:05 -06004566 } else if (pCB) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004567 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004568 skipCall |= addCmd(dev_data, pCB, CMD_DBGMARKERBEGIN);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004569 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004570 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004571 debug_marker_dispatch_table(commandBuffer)->CmdDbgMarkerBegin(commandBuffer, pMarker);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004572}
4573
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004574VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDbgMarkerEnd(VkCommandBuffer commandBuffer)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004575{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004576 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004577 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4578 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004579 if (!dev_data->device_extensions.debug_marker_enabled) {
Chia-I Wu1f851912015-10-27 18:04:07 +08004580 skipCall |= log_msg(dev_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_COMMAND_BUFFER, (uint64_t)commandBuffer, 0, DRAWSTATE_INVALID_EXTENSION, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06004581 "Attempt to use CmdDbgMarkerEnd but extension disabled!");
Jon Ashburn6f8cd632015-06-01 09:37:38 -06004582 return;
Tobin Ehlisa366ca22015-06-19 15:07:05 -06004583 } else if (pCB) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004584 updateCBTracking(pCB);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004585 skipCall |= addCmd(dev_data, pCB, CMD_DBGMARKEREND);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004586 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004587 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004588 debug_marker_dispatch_table(commandBuffer)->CmdDbgMarkerEnd(commandBuffer);
Jon Ashburn6f8cd632015-06-01 09:37:38 -06004589}
4590
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004591VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char* funcName)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004592{
Jon Ashburn1245cec2015-05-18 13:20:15 -06004593 if (dev == NULL)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004594 return NULL;
Jon Ashburne0fa2282015-05-20 09:00:28 -06004595
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004596 layer_data *dev_data;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004597 /* loader uses this to force layer initialization; device object is wrapped */
4598 if (!strcmp(funcName, "vkGetDeviceProcAddr")) {
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004599 VkBaseLayerObject* wrapped_dev = (VkBaseLayerObject*) dev;
4600 dev_data = get_my_data_ptr(get_dispatch_key(wrapped_dev->baseObject), layer_data_map);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004601 dev_data->device_dispatch_table = new VkLayerDispatchTable;
4602 layer_initialize_dispatch_table(dev_data->device_dispatch_table, wrapped_dev);
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004603 return (PFN_vkVoidFunction) vkGetDeviceProcAddr;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004604 }
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004605 dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map);
Courtney Goeltzenleuchterbe637992015-06-25 18:01:43 -06004606 if (!strcmp(funcName, "vkCreateDevice"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004607 return (PFN_vkVoidFunction) vkCreateDevice;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004608 if (!strcmp(funcName, "vkDestroyDevice"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004609 return (PFN_vkVoidFunction) vkDestroyDevice;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004610 if (!strcmp(funcName, "vkQueueSubmit"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004611 return (PFN_vkVoidFunction) vkQueueSubmit;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004612 if (!strcmp(funcName, "vkDestroyInstance"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004613 return (PFN_vkVoidFunction) vkDestroyInstance;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004614 if (!strcmp(funcName, "vkDestroyDevice"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004615 return (PFN_vkVoidFunction) vkDestroyDevice;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004616 if (!strcmp(funcName, "vkDestroyFence"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004617 return (PFN_vkVoidFunction) vkDestroyFence;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004618 if (!strcmp(funcName, "vkDestroySemaphore"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004619 return (PFN_vkVoidFunction) vkDestroySemaphore;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004620 if (!strcmp(funcName, "vkDestroyEvent"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004621 return (PFN_vkVoidFunction) vkDestroyEvent;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004622 if (!strcmp(funcName, "vkDestroyQueryPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004623 return (PFN_vkVoidFunction) vkDestroyQueryPool;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004624 if (!strcmp(funcName, "vkDestroyBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004625 return (PFN_vkVoidFunction) vkDestroyBuffer;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004626 if (!strcmp(funcName, "vkDestroyBufferView"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004627 return (PFN_vkVoidFunction) vkDestroyBufferView;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004628 if (!strcmp(funcName, "vkDestroyImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004629 return (PFN_vkVoidFunction) vkDestroyImage;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004630 if (!strcmp(funcName, "vkDestroyImageView"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004631 return (PFN_vkVoidFunction) vkDestroyImageView;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004632 if (!strcmp(funcName, "vkDestroyShaderModule"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004633 return (PFN_vkVoidFunction) vkDestroyShaderModule;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004634 if (!strcmp(funcName, "vkDestroyPipeline"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004635 return (PFN_vkVoidFunction) vkDestroyPipeline;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004636 if (!strcmp(funcName, "vkDestroyPipelineLayout"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004637 return (PFN_vkVoidFunction) vkDestroyPipelineLayout;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004638 if (!strcmp(funcName, "vkDestroySampler"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004639 return (PFN_vkVoidFunction) vkDestroySampler;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004640 if (!strcmp(funcName, "vkDestroyDescriptorSetLayout"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004641 return (PFN_vkVoidFunction) vkDestroyDescriptorSetLayout;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004642 if (!strcmp(funcName, "vkDestroyDescriptorPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004643 return (PFN_vkVoidFunction) vkDestroyDescriptorPool;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004644 if (!strcmp(funcName, "vkDestroyFramebuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004645 return (PFN_vkVoidFunction) vkDestroyFramebuffer;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06004646 if (!strcmp(funcName, "vkDestroyRenderPass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004647 return (PFN_vkVoidFunction) vkDestroyRenderPass;
Tobin Ehlisb46be812015-10-23 16:00:08 -06004648 if (!strcmp(funcName, "vkCreateBuffer"))
4649 return (PFN_vkVoidFunction) vkCreateBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004650 if (!strcmp(funcName, "vkCreateBufferView"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004651 return (PFN_vkVoidFunction) vkCreateBufferView;
Tobin Ehlisb46be812015-10-23 16:00:08 -06004652 if (!strcmp(funcName, "vkCreateImage"))
4653 return (PFN_vkVoidFunction) vkCreateImage;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004654 if (!strcmp(funcName, "vkCreateImageView"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004655 return (PFN_vkVoidFunction) vkCreateImageView;
Jon Ashburn0d60d272015-07-09 15:02:25 -06004656 if (!strcmp(funcName, "CreatePipelineCache"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004657 return (PFN_vkVoidFunction) vkCreatePipelineCache;
Jon Ashburn0d60d272015-07-09 15:02:25 -06004658 if (!strcmp(funcName, "DestroyPipelineCache"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004659 return (PFN_vkVoidFunction) vkDestroyPipelineCache;
Jon Ashburn0d60d272015-07-09 15:02:25 -06004660 if (!strcmp(funcName, "GetPipelineCacheData"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004661 return (PFN_vkVoidFunction) vkGetPipelineCacheData;
Jon Ashburn0d60d272015-07-09 15:02:25 -06004662 if (!strcmp(funcName, "MergePipelineCaches"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004663 return (PFN_vkVoidFunction) vkMergePipelineCaches;
Jon Ashburn0d60d272015-07-09 15:02:25 -06004664 if (!strcmp(funcName, "vkCreateGraphicsPipelines"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004665 return (PFN_vkVoidFunction) vkCreateGraphicsPipelines;
Mark Lobodzinski2adea752015-11-10 15:25:01 -07004666 if (!strcmp(funcName, "vkCreateComputePipelines"))
4667 return (PFN_vkVoidFunction) vkCreateComputePipelines;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004668 if (!strcmp(funcName, "vkCreateSampler"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004669 return (PFN_vkVoidFunction) vkCreateSampler;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004670 if (!strcmp(funcName, "vkCreateDescriptorSetLayout"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004671 return (PFN_vkVoidFunction) vkCreateDescriptorSetLayout;
Mark Lobodzinski556f7212015-04-17 14:11:39 -05004672 if (!strcmp(funcName, "vkCreatePipelineLayout"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004673 return (PFN_vkVoidFunction) vkCreatePipelineLayout;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004674 if (!strcmp(funcName, "vkCreateDescriptorPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004675 return (PFN_vkVoidFunction) vkCreateDescriptorPool;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004676 if (!strcmp(funcName, "vkResetDescriptorPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004677 return (PFN_vkVoidFunction) vkResetDescriptorPool;
Chia-I Wu1f851912015-10-27 18:04:07 +08004678 if (!strcmp(funcName, "vkAllocateDescriptorSets"))
4679 return (PFN_vkVoidFunction) vkAllocateDescriptorSets;
Tobin Ehlis3c543112015-10-08 13:13:50 -06004680 if (!strcmp(funcName, "vkFreeDescriptorSets"))
4681 return (PFN_vkVoidFunction) vkFreeDescriptorSets;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08004682 if (!strcmp(funcName, "vkUpdateDescriptorSets"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004683 return (PFN_vkVoidFunction) vkUpdateDescriptorSets;
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07004684 if (!strcmp(funcName, "vkCreateCommandPool"))
4685 return (PFN_vkVoidFunction) vkCreateCommandPool;
4686 if (!strcmp(funcName, "vkDestroyCommandPool"))
4687 return (PFN_vkVoidFunction) vkDestroyCommandPool;
Chia-I Wu1f851912015-10-27 18:04:07 +08004688 if (!strcmp(funcName, "vkAllocateCommandBuffers"))
4689 return (PFN_vkVoidFunction) vkAllocateCommandBuffers;
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07004690 if (!strcmp(funcName, "vkFreeCommandBuffers"))
4691 return (PFN_vkVoidFunction) vkFreeCommandBuffers;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004692 if (!strcmp(funcName, "vkBeginCommandBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004693 return (PFN_vkVoidFunction) vkBeginCommandBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004694 if (!strcmp(funcName, "vkEndCommandBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004695 return (PFN_vkVoidFunction) vkEndCommandBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004696 if (!strcmp(funcName, "vkResetCommandBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004697 return (PFN_vkVoidFunction) vkResetCommandBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004698 if (!strcmp(funcName, "vkCmdBindPipeline"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004699 return (PFN_vkVoidFunction) vkCmdBindPipeline;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06004700 if (!strcmp(funcName, "vkCmdSetViewport"))
4701 return (PFN_vkVoidFunction) vkCmdSetViewport;
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06004702 if (!strcmp(funcName, "vkCmdSetScissor"))
4703 return (PFN_vkVoidFunction) vkCmdSetScissor;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06004704 if (!strcmp(funcName, "vkCmdSetLineWidth"))
4705 return (PFN_vkVoidFunction) vkCmdSetLineWidth;
4706 if (!strcmp(funcName, "vkCmdSetDepthBias"))
4707 return (PFN_vkVoidFunction) vkCmdSetDepthBias;
4708 if (!strcmp(funcName, "vkCmdSetBlendConstants"))
4709 return (PFN_vkVoidFunction) vkCmdSetBlendConstants;
4710 if (!strcmp(funcName, "vkCmdSetDepthBounds"))
4711 return (PFN_vkVoidFunction) vkCmdSetDepthBounds;
4712 if (!strcmp(funcName, "vkCmdSetStencilCompareMask"))
4713 return (PFN_vkVoidFunction) vkCmdSetStencilCompareMask;
4714 if (!strcmp(funcName, "vkCmdSetStencilWriteMask"))
4715 return (PFN_vkVoidFunction) vkCmdSetStencilWriteMask;
4716 if (!strcmp(funcName, "vkCmdSetStencilReference"))
4717 return (PFN_vkVoidFunction) vkCmdSetStencilReference;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004718 if (!strcmp(funcName, "vkCmdBindDescriptorSets"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004719 return (PFN_vkVoidFunction) vkCmdBindDescriptorSets;
Courtney Goeltzenleuchter46962942015-04-16 13:38:46 -06004720 if (!strcmp(funcName, "vkCmdBindVertexBuffers"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004721 return (PFN_vkVoidFunction) vkCmdBindVertexBuffers;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004722 if (!strcmp(funcName, "vkCmdBindIndexBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004723 return (PFN_vkVoidFunction) vkCmdBindIndexBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004724 if (!strcmp(funcName, "vkCmdDraw"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004725 return (PFN_vkVoidFunction) vkCmdDraw;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004726 if (!strcmp(funcName, "vkCmdDrawIndexed"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004727 return (PFN_vkVoidFunction) vkCmdDrawIndexed;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004728 if (!strcmp(funcName, "vkCmdDrawIndirect"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004729 return (PFN_vkVoidFunction) vkCmdDrawIndirect;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004730 if (!strcmp(funcName, "vkCmdDrawIndexedIndirect"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004731 return (PFN_vkVoidFunction) vkCmdDrawIndexedIndirect;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004732 if (!strcmp(funcName, "vkCmdDispatch"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004733 return (PFN_vkVoidFunction) vkCmdDispatch;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004734 if (!strcmp(funcName, "vkCmdDispatchIndirect"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004735 return (PFN_vkVoidFunction) vkCmdDispatchIndirect;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004736 if (!strcmp(funcName, "vkCmdCopyBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004737 return (PFN_vkVoidFunction) vkCmdCopyBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004738 if (!strcmp(funcName, "vkCmdCopyImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004739 return (PFN_vkVoidFunction) vkCmdCopyImage;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004740 if (!strcmp(funcName, "vkCmdCopyBufferToImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004741 return (PFN_vkVoidFunction) vkCmdCopyBufferToImage;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004742 if (!strcmp(funcName, "vkCmdCopyImageToBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004743 return (PFN_vkVoidFunction) vkCmdCopyImageToBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004744 if (!strcmp(funcName, "vkCmdUpdateBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004745 return (PFN_vkVoidFunction) vkCmdUpdateBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004746 if (!strcmp(funcName, "vkCmdFillBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004747 return (PFN_vkVoidFunction) vkCmdFillBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004748 if (!strcmp(funcName, "vkCmdClearColorImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004749 return (PFN_vkVoidFunction) vkCmdClearColorImage;
Chris Forbes2951d7d2015-06-22 17:21:59 +12004750 if (!strcmp(funcName, "vkCmdClearDepthStencilImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004751 return (PFN_vkVoidFunction) vkCmdClearDepthStencilImage;
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06004752 if (!strcmp(funcName, "vkCmdClearAttachments"))
4753 return (PFN_vkVoidFunction) vkCmdClearAttachments;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004754 if (!strcmp(funcName, "vkCmdResolveImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004755 return (PFN_vkVoidFunction) vkCmdResolveImage;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004756 if (!strcmp(funcName, "vkCmdSetEvent"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004757 return (PFN_vkVoidFunction) vkCmdSetEvent;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004758 if (!strcmp(funcName, "vkCmdResetEvent"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004759 return (PFN_vkVoidFunction) vkCmdResetEvent;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004760 if (!strcmp(funcName, "vkCmdWaitEvents"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004761 return (PFN_vkVoidFunction) vkCmdWaitEvents;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004762 if (!strcmp(funcName, "vkCmdPipelineBarrier"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004763 return (PFN_vkVoidFunction) vkCmdPipelineBarrier;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004764 if (!strcmp(funcName, "vkCmdBeginQuery"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004765 return (PFN_vkVoidFunction) vkCmdBeginQuery;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004766 if (!strcmp(funcName, "vkCmdEndQuery"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004767 return (PFN_vkVoidFunction) vkCmdEndQuery;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004768 if (!strcmp(funcName, "vkCmdResetQueryPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004769 return (PFN_vkVoidFunction) vkCmdResetQueryPool;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004770 if (!strcmp(funcName, "vkCmdWriteTimestamp"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004771 return (PFN_vkVoidFunction) vkCmdWriteTimestamp;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004772 if (!strcmp(funcName, "vkCreateFramebuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004773 return (PFN_vkVoidFunction) vkCreateFramebuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004774 if (!strcmp(funcName, "vkCreateRenderPass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004775 return (PFN_vkVoidFunction) vkCreateRenderPass;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004776 if (!strcmp(funcName, "vkCmdBeginRenderPass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004777 return (PFN_vkVoidFunction) vkCmdBeginRenderPass;
Chia-I Wuc278df82015-07-07 11:50:03 +08004778 if (!strcmp(funcName, "vkCmdNextSubpass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004779 return (PFN_vkVoidFunction) vkCmdNextSubpass;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004780 if (!strcmp(funcName, "vkCmdEndRenderPass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004781 return (PFN_vkVoidFunction) vkCmdEndRenderPass;
Tobin Ehlis5f728d32015-09-17 14:18:16 -06004782 if (!strcmp(funcName, "vkCmdExecuteCommands"))
4783 return (PFN_vkVoidFunction) vkCmdExecuteCommands;
Michael Lentineee4ad4d2015-10-23 12:41:44 -07004784 if (!strcmp(funcName, "vkMapMemory"))
4785 return (PFN_vkVoidFunction) vkMapMemory;
Jon Ashburn6f8cd632015-06-01 09:37:38 -06004786
Michael Lentine27b0f902015-10-12 11:30:14 -05004787 if (dev_data->device_extensions.wsi_enabled)
4788 {
4789 if (!strcmp(funcName, "vkCreateSwapchainKHR"))
4790 return (PFN_vkVoidFunction) vkCreateSwapchainKHR;
4791 if (!strcmp(funcName, "vkDestroySwapchainKHR"))
4792 return (PFN_vkVoidFunction) vkDestroySwapchainKHR;
4793 if (!strcmp(funcName, "vkGetSwapchainImagesKHR"))
4794 return (PFN_vkVoidFunction) vkGetSwapchainImagesKHR;
4795 if (!strcmp(funcName, "vkQueuePresentKHR"))
4796 return (PFN_vkVoidFunction) vkQueuePresentKHR;
4797 }
4798
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004799 VkLayerDispatchTable* pTable = dev_data->device_dispatch_table;
4800 if (dev_data->device_extensions.debug_marker_enabled)
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004801 {
Jon Ashburn7e07faf2015-06-18 15:02:58 -06004802 if (!strcmp(funcName, "vkCmdDbgMarkerBegin"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004803 return (PFN_vkVoidFunction) vkCmdDbgMarkerBegin;
Jon Ashburn7e07faf2015-06-18 15:02:58 -06004804 if (!strcmp(funcName, "vkCmdDbgMarkerEnd"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004805 return (PFN_vkVoidFunction) vkCmdDbgMarkerEnd;
Jon Ashburn6f8cd632015-06-01 09:37:38 -06004806 }
4807 {
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004808 if (pTable->GetDeviceProcAddr == NULL)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004809 return NULL;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004810 return pTable->GetDeviceProcAddr(dev, funcName);
Jon Ashburn79b78ac2015-05-05 14:22:52 -06004811 }
4812}
4813
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004814VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char* funcName)
Jon Ashburn79b78ac2015-05-05 14:22:52 -06004815{
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004816 PFN_vkVoidFunction fptr;
Jon Ashburn79b78ac2015-05-05 14:22:52 -06004817 if (instance == NULL)
4818 return NULL;
4819
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004820 layer_data* my_data;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004821 /* loader uses this to force layer initialization; instance object is wrapped */
4822 if (!strcmp(funcName, "vkGetInstanceProcAddr")) {
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004823 VkBaseLayerObject* wrapped_inst = (VkBaseLayerObject*) instance;
4824 my_data = get_my_data_ptr(get_dispatch_key(wrapped_inst->baseObject), layer_data_map);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004825 my_data->instance_dispatch_table = new VkLayerInstanceDispatchTable;
4826 layer_init_instance_dispatch_table(my_data->instance_dispatch_table, wrapped_inst);
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004827 return (PFN_vkVoidFunction) vkGetInstanceProcAddr;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004828 }
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004829 my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map);
Courtney Goeltzenleuchter3c9f6ec2015-06-01 14:29:58 -06004830 if (!strcmp(funcName, "vkCreateInstance"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004831 return (PFN_vkVoidFunction) vkCreateInstance;
Jon Ashburne0fa2282015-05-20 09:00:28 -06004832 if (!strcmp(funcName, "vkDestroyInstance"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06004833 return (PFN_vkVoidFunction) vkDestroyInstance;
Courtney Goeltzenleuchter74c4ce92015-09-14 17:22:16 -06004834 if (!strcmp(funcName, "vkEnumerateInstanceLayerProperties"))
4835 return (PFN_vkVoidFunction) vkEnumerateInstanceLayerProperties;
4836 if (!strcmp(funcName, "vkEnumerateInstanceExtensionProperties"))
4837 return (PFN_vkVoidFunction) vkEnumerateInstanceExtensionProperties;
4838 if (!strcmp(funcName, "vkEnumerateDeviceLayerProperties"))
4839 return (PFN_vkVoidFunction) vkEnumerateDeviceLayerProperties;
4840 if (!strcmp(funcName, "vkEnumerateDeviceExtensionProperties"))
4841 return (PFN_vkVoidFunction) vkEnumerateDeviceExtensionProperties;
Courtney Goeltzenleuchtercc899fe2015-06-01 14:33:14 -06004842
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06004843 fptr = debug_report_get_instance_proc_addr(my_data->report_data, funcName);
Courtney Goeltzenleuchtercc899fe2015-06-01 14:33:14 -06004844 if (fptr)
4845 return fptr;
4846
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004847 {
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004848 VkLayerInstanceDispatchTable* pTable = my_data->instance_dispatch_table;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004849 if (pTable->GetInstanceProcAddr == NULL)
Jon Ashburn79b78ac2015-05-05 14:22:52 -06004850 return NULL;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06004851 return pTable->GetInstanceProcAddr(instance, funcName);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004852 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004853}