Stop using public_deps to depend on libyuv.
A lot of WebRTC targets were depending on //third_party/libyuv using
public_deps instead of deps. This causes issues because a the
inclusion of libyuv headers is not declared to the build system and
this creates hidden dependencies that put the modularity of the project
at risk.
Bug: webrtc:8603
Change-Id: Ide0ceb84eb5640ae664dc782f3a722b55c3b601a
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/28120
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21039}diff --git a/rtc_tools/BUILD.gn b/rtc_tools/BUILD.gn
index 1ed3756..595cc31 100644
--- a/rtc_tools/BUILD.gn
+++ b/rtc_tools/BUILD.gn
@@ -63,9 +63,8 @@
"frame_analyzer/video_quality_analysis.cc",
"frame_analyzer/video_quality_analysis.h",
]
-
- public_deps = [
- "../common_video",
+ deps = [
+ "$rtc_libyuv_dir",
]
}
@@ -77,6 +76,7 @@
deps = [
":command_line_parser",
":video_quality_analysis",
+ "$rtc_libyuv_dir",
"//build/win:default_exe_manifest",
]
}
@@ -92,6 +92,7 @@
deps = [
":command_line_parser",
":video_quality_analysis",
+ "$rtc_libyuv_dir",
"//build/win:default_exe_manifest",
]
}
@@ -104,6 +105,7 @@
deps = [
":video_quality_analysis",
+ "$rtc_libyuv_dir",
]
}
@@ -128,6 +130,7 @@
deps = [
":command_line_parser",
+ "$rtc_libyuv_dir",
"../common_video",
"//build/win:default_exe_manifest",
]
@@ -322,6 +325,8 @@
":frame_editing_lib",
":reference_less_video_analysis_lib",
":video_quality_analysis",
+ "$rtc_libyuv_dir",
+ "../common_video:common_video",
"../rtc_base",
"../test:test_main",
"//testing/gtest",