commit | 1cb20deb746a74d8e5f0b2364cbd589597413072 | [log] [tgz] |
---|---|---|
author | Niklas Enbom <niklas.enbom@webrtc.org> | Fri Oct 19 14:46:38 2018 +0000 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Oct 19 14:46:43 2018 +0000 |
tree | a4425dced631db7f9c86c93913a900df35d3524e | |
parent | 3c7d599750405bc734e1d5adbf1b54265b725a9d [diff] |
Revert "Make sure Chromium will pick the correct field_trial/metric impl." This reverts commit 8dc280d804bc49932f429955b27ff385054ddfa0. Reason for revert: Breaks NDK compile on Chrome bots: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932231862774278176/+/steps/compile__with_patch_/0/stdout Original change's description: > Make sure Chromium will pick the correct field_trial/metric impl. > > Chromium wants to pick its own field_trial and metrics implementation, > and WebRTC has an escape hatch to let it remove the definition of these > symbols. This obviously causes liker errors if Chromium will not pick > the correct dependency (which cannot be forced by GN check since there > is no header inclusion). > > Instead of hoping that the build target with the correct implementation > will be added as a dependency somewhere in the build graph, this CL > wants to explicitly add the dependency as close as possible to the > headers, so if they are included and WebRTC is built as part of Chromium > the correct implementation will be linked into the binary. > > Bug: webrtc:9631 > Change-Id: I2d1cfe541726341adfdf81e14e036464aa003d4d > Reviewed-on: https://webrtc-review.googlesource.com/c/107040 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25269} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: I4c04b60d198aa1b89278083d518bfa93c15d09bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9631 Reviewed-on: https://webrtc-review.googlesource.com/c/107140 Reviewed-by: Niklas Enbom <niklas.enbom@webrtc.org> Commit-Queue: Niklas Enbom <niklas.enbom@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25275}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.