commit 250155d0dbc55eacf122a99271126d52b609c306
author Alex Loiko <aleloi@webrtc.org> Mon Mar 26 14:36:46 2018 +0200
committer Commit Bot <commit-bot@chromium.org> Mon Mar 26 14:17:00 2018 +0000
tree d8d0e6a01d6a52d1feb26ee259e511f9e9db9c70
parent 1b3bd0bebd8bb741ee09f6579209da06a023a79c

Fix histogram logging in InterpolatedGainCurve.

We had the following pattern:

if (case_A) metric = METRIC_A;
if (case_B) metric = METRIC_B;
RTC_HISTOGRAM_COUNTS_10000(metric, value);

That's wrong, because once the logging macro runs once, it will use
the same histogram no matter what the first argument is. The macro
expands into roughly

static Histogram* histogram_ptr = nullptr;
if (histogram_ptr == nullptr) {
  // Look up the histogram and put in histogram_ptr
}
// Add data through the histogram pointer.

We change the logging to use macros with string literals. We add a
macro for every of the 4 possible invocations. The macros will expand
to one static pointer each.

Bug: webrtc:8925
Change-Id: Ic7e4a6299eff31dd5988047edfcedce7d369e5ce
Reviewed-on: https://webrtc-review.googlesource.com/64724
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Commit-Queue: Alex Loiko <aleloi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22606}