commit 262bbaee61f7a88eeda1c315e6cf282b80a374cd
author Henrik Boström <hbos@webrtc.org> Fri Sep 13 11:34:55 2019 +0200
committer Commit Bot <commit-bot@chromium.org> Fri Sep 13 11:35:22 2019 +0000
tree 0f1275b7bdb053de81fe43eb12f6d67591c81d3a
parent 65f17ca6b4cff0a342144cd71376e10bbabc054f

Fix rare audioLevel flake in RTCStatsIntegrationTest.

The integration test sets up a loopback call, verifies media is flowing,
and then asserts which metrics should be available.

One of the things it asserted was that audioLevel is positive. This
could flake in rare circumstances because audioLevel requires a certain
number of samples to have been received before it is updated or else it
would have its default value zero.

This test is a broad asserting things about 150+ metrics; it's not worth
adding a dependency on the "implementation detail" about how long you
have to wait before this specific metric is non-zero. The fix for the
flake is to only require the metric to have been set, but zero is also
an acceptable value.

We don't lose much test coverage; we're still asserting that other
audio metrics originating from the same class have positive values.

Bug: webrtc:10962
Change-Id: I5def9193da7150492d89ea62031858bac5c41646
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152821
Reviewed-by: Yves Gerey <yvesg@google.com>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29179}