commit 38e6c66f4aa8af6bd342107e24cb699a0b353d2c
author Amit Hilbuch <amithi@webrtc.org> Fri Mar 08 16:17:21 2019 -0800
committer Commit Bot <commit-bot@chromium.org> Thu Mar 14 17:18:51 2019 +0000
tree 8f87b071e8ac38523e19cfcc91c7c056c051f9b9
parent f1c9e21366b6e1c633e06fcab921154a8a29bb8b

CNAME is missing in simulcast layers.

CNAME is only set on the first simulcast layer.
It should be set on all of the layers.

Bug: webrtc:10383
Change-Id: Iea345a100769f45d09078adb93e51b7702326492
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126541
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Amit Hilbuch <amithi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27134}

call/rtp_video_sender.cc

diff --git a/call/rtp_video_sender.cc b/call/rtp_video_sender.cc
index 7b7f350..fb7b613 100644
--- a/call/rtp_video_sender.cc
+++ b/call/rtp_video_sender.cc
@@ -301,10 +301,9 @@
     }
   }
 
-  // TODO(pbos): Should we set CNAME on all RTP modules?
-  rtp_streams_.front().rtp_rtcp->SetCNAME(rtp_config.c_name.c_str());
-
   for (const RtpStreamSender& stream : rtp_streams_) {
+    // Simulcast has one module for each layer. Set the CNAME on all modules.
+    stream.rtp_rtcp->SetCNAME(rtp_config.c_name.c_str());
     stream.rtp_rtcp->RegisterRtcpStatisticsCallback(observers.rtcp_stats);
     stream.rtp_rtcp->RegisterSendChannelRtpStatisticsCallback(
         observers.rtp_stats);