commit 3cd9a30f96ff31e1bd5ae51dd9e7790da94c8b29
author tkchin <tkchin@webrtc.org> Wed Jun 08 12:40:28 2016 -0700
committer Commit bot <commit-bot@chromium.org> Wed Jun 08 19:40:33 2016 +0000
tree e74deb05ddc21a0d568f1ae59970f70ce99874f8
parent 1c76bf1fbe804e9f2c94e1d84f8f665b0c62107c

Allow 100 char lines for ObjC files.

NOTRY=True

BUG=

Review-Url: https://codereview.webrtc.org/2037173002
Cr-Commit-Position: refs/heads/master@{#13076}

PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index b09fc14..8492dc9 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -454,11 +454,22 @@
   # we need to have different license checks in talk/ and webrtc/ directories.
   # Instead, hand-picked checks are included below.
 
+  # .m and .mm files are ObjC files. For simplicity we will consider .h files in
+  # ObjC subdirectories ObjC headers.
+  objc_filter_list = (r'.+\.m$', r'.+\.mm$', r'.+objc\/.+\.h$')
   # Skip long-lines check for DEPS, GN and GYP files.
-  long_lines_sources = lambda x: input_api.FilterSourceFile(x,
-      black_list=(r'.+\.gyp$', r'.+\.gypi$', r'.+\.gn$', r'.+\.gni$', 'DEPS'))
+  build_file_filter_list = (r'.+\.gyp$', r'.+\.gypi$', r'.+\.gn$', r'.+\.gni$',
+      'DEPS')
+  eighty_char_sources = lambda x: input_api.FilterSourceFile(x,
+      black_list=build_file_filter_list + objc_filter_list)
+  hundred_char_sources = lambda x: input_api.FilterSourceFile(x,
+      white_list=objc_filter_list)
   results.extend(input_api.canned_checks.CheckLongLines(
-      input_api, output_api, maxlen=80, source_file_filter=long_lines_sources))
+      input_api, output_api, maxlen=80, source_file_filter=eighty_char_sources))
+  results.extend(input_api.canned_checks.CheckLongLines(
+      input_api, output_api, maxlen=100,
+      source_file_filter=hundred_char_sources))
+
   results.extend(input_api.canned_checks.CheckChangeHasNoTabs(
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace(