Suppress C5041 constexpr warning for MSVC 2019
Disable the C5041 warning which makes the build fail. This is a
C++17-only change and WebRTC doesn't support C++17 yet, so the code is
technically correct, but fails to build on MSVC 2019 and
warning-as-error active.
Also fix another warning-as-error build error with MSVC 2019 due to
ignoring the result of a [[nodiscard]] function.
No-Presubmit: True
Bug: webrtc:11275,webrtc:11276
Change-Id: I891a894ee87252f96e84fd8d282576f46907256f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165781
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30244}
diff --git a/BUILD.gn b/BUILD.gn
index eaa7ad5..49227d9 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -334,6 +334,9 @@
# TODO(bugs.webrtc.org/9274): Remove these warnings as soon as MSVC allows
# external headers warning suppression (or fix them upstream).
cflags += [ "/wd4702" ] # unreachable code
+
+ # MSVC 2019 warning suppressions for C++17 compiling
+ cflags += [ "/wd5041" ] # out-of-line definition for constexpr static data member is not needed and is deprecated in C++17
}
}