| commit | 4fe660785bf6573d859b5384331a4928324ec7ef | [log] [tgz] |
|---|---|---|
| author | Zijie He <zijiehe@chromium.org> | Wed Aug 30 16:58:14 2017 -0700 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu Aug 31 00:24:54 2017 +0000 |
| tree | 86e7de6c2e373edf7a31066266c0782278b97ecf | |
| parent | f7f685c9de873df2a378726d7570638477776811 [diff] |
Use GetWindowDrawableRect() instead of GetCroppedWindowRect() in WindowCapturerWin GetCroppingWindowRect() is too generic and easy to be misused. For example, in WindowCapturerWin, it's used to calculate the DesktopRect of the target window, which is inaccurate. See the screenshot in the bug, it wrongly crops borders on Windows 8+. So GetCroppingWindowRect() should be removed eventually, the logic should be placed in CroppingWindowCapturerWin. But since it's still used in the deprecated logic in MouseCursorMonitorWin, I would prefer to remove this function after MouseCursorMonitor improvement has been finished. But before that, WindowCapturerWin should use GetWindowDrawableRect() instead of GetCroppedWindowRect() to avoid the wrongly cropping behavior on Windows 8+. Bug: webrtc:8157 Change-Id: I012b663dced8105623c563dbe55ffcb8d7f17f75 Reviewed-on: https://chromium-review.googlesource.com/642092 Commit-Queue: Zijie He <zijiehe@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#19614}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.