| commit | 58530ed246b7d87e2208b96ab2c4836adb6fd5d7 | [log] [tgz] |
|---|---|---|
| author | minyue <minyue@webrtc.org> | Tue May 24 05:50:12 2016 -0700 |
| committer | Commit bot <commit-bot@chromium.org> | Tue May 24 12:50:29 2016 +0000 |
| tree | b3ccf0d2a6126dedc7f5467efbbf695b8185c29e | |
| parent | d36df89d40bde3c62ee5cbff841933e50b3c007b [diff] |
Updating APM unittests on the echo metrics. There were a series of changes in the calculation of echo metrics. There changes made the existing unittests lose, e.g., EXPECT_EQ become EXPECT_NEAR. It is good time to protect the echo calculation more strictly. The change is not simply generating a new reference file and change EXPECT_NEAR to EXPECT_EQ. It strengthens the test as well. Main changes are 1. the old test only sample a metric at the end of processing, while the new test takes metrics during the call with a certain time interval. This gives a much stronger protection. 2. added protection of a newly added metric, called divergent_filter_fraction. 3. as said, use EXPECT_EQ (actually ASSERT_EQ) instead of EXPECT_NEAR as much as possible, even for float point values. This may be too restrictive. But it can be good to be restrictive at the beginning. BUG= Review-Url: https://codereview.webrtc.org/1969403003 Cr-Commit-Position: refs/heads/master@{#12871}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.