| commit | 62351c9923b557b41e90c228ae8c3209a10796c5 | [log] [tgz] |
|---|---|---|
| author | Taylor Brandstetter <deadbeef@webrtc.org> | Thu Aug 11 16:05:07 2016 -0700 |
| committer | Taylor Brandstetter <deadbeef@webrtc.org> | Thu Aug 11 23:05:15 2016 +0000 |
| tree | 135f411c9c7580e371ac75d677b05a2aa2d7deee | |
| parent | 6f82535f45697fe75cbc90b8ed8756eefa82eef3 [diff] |
Fixing problems with ICE candidate pair prioritization. The main issue was that upon receiving a binding response with a srflx mapped address attribute, the local candidate was not updated from local to srflx. This means the two ICE agents view the same pair differently; one sees it as "X<->srflx" while the other sees it as "local<->X". This causes sub-optimal prioritization and could result in the wrong pair being selected if using aggressive nomination. The other issue was that TCP prflx candidates were not differentiated from UDP prflx candidates. This lead to TCP prflx candidates prioritized above TCP host candidates. After fixing these issues, I was able to re-enable many disabled tests, as well as restore the check for the candidate types of the controlled agent. BUG=webrtc:1953,webrtc:2383 R=honghaiz@webrtc.org, pthatcher@webrtc.org Review URL: https://codereview.webrtc.org/2125823004 . Cr-Commit-Position: refs/heads/master@{#13734}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.