commit 64f813e71fdc72c90c6ff0dccd80bc68da253c68
author Mirko Bonadei <mbonadei@webrtc.org> Wed Jul 18 15:37:01 2018 +0200
committer Commit Bot <commit-bot@chromium.org> Fri Jul 20 10:26:07 2018 +0000
tree a3713304a14cf7f7cd8f9e0f31ce30c4649c30c0
parent ee01a839d2ed0a3b2a4e58019ea9a37a614e0d8a

Enable clang::find_bad_constructs for remote_bitrate_estimator.

This CL removes //build/config/clang:find_bad_constructs from the
suppressed_configs list, which means that clang:find_bad_constructs
is now enabled on these translation units.

Bug: webrtc:9251, webrtc:163
Change-Id: Id377fcd78166e53aad7c663c3ffec5e57fdb1274
Reviewed-on: https://webrtc-review.googlesource.com/89383
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24049}

modules/bitrate_controller/BUILD.gn

diff --git a/modules/bitrate_controller/BUILD.gn b/modules/bitrate_controller/BUILD.gn
index f9c7156..f9960cf 100644
--- a/modules/bitrate_controller/BUILD.gn
+++ b/modules/bitrate_controller/BUILD.gn
@@ -11,6 +11,7 @@
 rtc_static_library("bitrate_controller") {
   visibility = [ "*" ]
   sources = [
+    "bitrate_controller.cc",
     "bitrate_controller_impl.cc",
     "bitrate_controller_impl.h",
     "include/bitrate_controller.h",

modules/bitrate_controller/bitrate_controller.cc

diff --git a/modules/bitrate_controller/bitrate_controller.cc b/modules/bitrate_controller/bitrate_controller.cc
new file mode 100644
index 0000000..46e908b
--- /dev/null
+++ b/modules/bitrate_controller/bitrate_controller.cc
@@ -0,0 +1,23 @@
+/*
+ *  Copyright (c) 2018 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ *
+ *  Usage: this class will register multiple RtcpBitrateObserver's one at each
+ *  RTCP module. It will aggregate the results and run one bandwidth estimation
+ *  and push the result to the encoders via BitrateObserver(s).
+ */
+
+#include "modules/bitrate_controller/include/bitrate_controller.h"
+
+namespace webrtc {
+
+size_t BitrateObserver::pacer_queue_size_in_bytes() {
+  return 0;
+}
+
+}  // namespace webrtc

modules/bitrate_controller/include/bitrate_controller.h

diff --git a/modules/bitrate_controller/include/bitrate_controller.h b/modules/bitrate_controller/include/bitrate_controller.h
index 0ab9913..6e692d2 100644
--- a/modules/bitrate_controller/include/bitrate_controller.h
+++ b/modules/bitrate_controller/include/bitrate_controller.h
@@ -45,7 +45,7 @@
                                 int64_t target_set_time,
                                 uint64_t congestion_window) {}
   virtual void OnBytesAcked(size_t bytes) {}
-  virtual size_t pacer_queue_size_in_bytes() { return 0; }
+  virtual size_t pacer_queue_size_in_bytes();
   virtual ~BitrateObserver() {}
 };
 
@@ -67,7 +67,7 @@
   static BitrateController* CreateBitrateController(const Clock* clock,
                                                     RtcEventLog* event_log);
 
-  virtual ~BitrateController() {}
+  ~BitrateController() override {}
 
   // Deprecated, use raw pointer to BitrateController instance instead.
   // Creates RtcpBandwidthObserver caller responsible to delete.