commit 64f813e71fdc72c90c6ff0dccd80bc68da253c68
author Mirko Bonadei <mbonadei@webrtc.org> Wed Jul 18 15:37:01 2018 +0200
committer Commit Bot <commit-bot@chromium.org> Fri Jul 20 10:26:07 2018 +0000
tree a3713304a14cf7f7cd8f9e0f31ce30c4649c30c0
parent ee01a839d2ed0a3b2a4e58019ea9a37a614e0d8a

Enable clang::find_bad_constructs for remote_bitrate_estimator.

This CL removes //build/config/clang:find_bad_constructs from the
suppressed_configs list, which means that clang:find_bad_constructs
is now enabled on these translation units.

Bug: webrtc:9251, webrtc:163
Change-Id: Id377fcd78166e53aad7c663c3ffec5e57fdb1274
Reviewed-on: https://webrtc-review.googlesource.com/89383
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24049}

modules/remote_bitrate_estimator/BUILD.gn

diff --git a/modules/remote_bitrate_estimator/BUILD.gn b/modules/remote_bitrate_estimator/BUILD.gn
index 828a992..abdd035 100644
--- a/modules/remote_bitrate_estimator/BUILD.gn
+++ b/modules/remote_bitrate_estimator/BUILD.gn
@@ -38,11 +38,6 @@
     defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ]
   }
 
-  if (!build_with_chromium && is_clang) {
-    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
-    suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
-  }
-
   deps = [
     "../..:webrtc_common",
     "../../:typedefs",
@@ -71,10 +66,6 @@
       "../../test:rtp_test_utils",
       "../rtp_rtcp",
     ]
-    if (is_clang) {
-      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
-      suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
-    }
   }
 }
 
@@ -101,6 +92,7 @@
       "test/estimators/congestion_window.h",
       "test/estimators/max_bandwidth_filter.cc",
       "test/estimators/max_bandwidth_filter.h",
+      "test/estimators/min_rtt_filter.cc",
       "test/estimators/min_rtt_filter.h",
       "test/estimators/nada.cc",
       "test/estimators/nada.h",
@@ -112,6 +104,7 @@
       "test/estimators/tcp.h",
       "test/metric_recorder.cc",
       "test/metric_recorder.h",
+      "test/packet.cc",
       "test/packet.h",
       "test/packet_receiver.cc",
       "test/packet_receiver.h",
@@ -125,11 +118,6 @@
       defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ]
     }
 
-    if (!build_with_chromium && is_clang) {
-      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
-      suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
-    }
-
     deps = [
       ":remote_bitrate_estimator",
       "..:module_api",