commit | 66cadfc0e33f5368a86f2ebb52cc200a95c3ba1a | [log] [tgz] |
---|---|---|
author | zijiehe <zijiehe@chromium.org> | Wed Sep 21 17:19:10 2016 -0700 |
committer | Commit bot <commit-bot@chromium.org> | Thu Sep 22 00:19:15 2016 +0000 |
tree | d58df52ae7c955124f617aa1b6890cdb2aff83e9 | |
parent | 6f79d840ba238b8122d7ab354f54a444bb22a4ca [diff] |
Several minor improvements of DirectX capturer 1. It looks like ComPtr cannot work well with vector::emplace_back, I got a consistent crash on one of my machine, but not the other. Move constructor should have no impact to lvalue reference, but I may be wrong here. The impact here is ComPtr released before it should be. So a simple solution is to use copy instead of reference. The D3dDevice is a collection of reference counted pointers (Microsoft::WRL::ComPtr), there is almost no extra cost. 2. Actively set several fields in D3D11_TEXTURE2D_DESC to avoid potential break if there are some platform changes later. 3. AcquireNextFrame returns both a DXGI_OUTDUPL_FRAME_INFO with AccumulatedFrames and an IDXGIResource. But there is no comment in MSDN to ensure IDXGIResource won't be nullptr if AccumulatedFrames > 0. Adding an extra check in DxgiOutputDuplicator makes it a safer. BUG=314516 Review-Url: https://codereview.webrtc.org/2345163002 Cr-Commit-Position: refs/heads/master@{#14341}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.