commit 6adb0a26846c0a6ddf7d7e72ebf80b829c34d693
author Mirko Bonadei <mbonadei@webrtc.org> Wed Oct 23 07:55:04 2019 -0700
committer Commit Bot <commit-bot@chromium.org> Wed Oct 23 16:07:22 2019 +0000
tree 118c756cb2c5d4a0ef4ef47315510e6f2408f093
parent 21bfa401ddea0d119b515c4806a36c0b00aa03ae

Do not compile webrtc_lib_link_test if is_asan=true.

This should avoid to get errors like the ones below when is_asan=true
and target_os="mac":

warning: (x86_64)  could not find object file symbol for symbol _write_mb_features
warning: (x86_64)  could not find object file symbol for symbol _update_mode
warning: (x86_64)  could not find object file symbol for symbol _vp8cx_base_skip_false_prob
warning: (x86_64)  could not find object file symbol for symbol _default_coef_counts
warning: (x86_64)  could not find object file symbol for symbol _vpx_skin_pixel

Bug: webrtc:11027
Change-Id: Iebcb55a43d1ed5c8d1ce43d456c0e83ffa5cc2c1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158000
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29587}

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index 2170564..a0eda8f 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -42,7 +42,6 @@
         ":rtc_unittests",
         ":slow_tests",
         ":video_engine_tests",
-        ":webrtc_lib_link_test",
         ":webrtc_nonparallel_tests",
         ":webrtc_perf_tests",
         "common_audio:common_audio_unittests",
@@ -66,6 +65,12 @@
         "video:sv_loopback",
         "video:video_loopback",
       ]
+      if (!is_asan) {
+        # Do not build :webrtc_lib_link_test because lld complains on some OS
+        # (e.g. when target_os = "mac") when is_asan=true. For more details,
+        # see bugs.webrtc.org/11027#c5.
+        deps += [ ":webrtc_lib_link_test" ]
+      }
       if (is_android) {
         deps += [
           ":android_junit_tests",