commit 6b3fcfd82318aea0cd4ce1705f510ece0057491a
author kjellander <kjellander@webrtc.org> Tue Feb 07 01:11:06 2017 -0800
committer Commit bot <commit-bot@chromium.org> Tue Feb 07 09:11:06 2017 +0000
tree 932ce4b94e0efedf6ff50fac9678b95c97ad437e
parent 6b34124a6d4733cf2d95986b4920bccec8b39397

Add support for extra GN args to Android build script.

By using the --extra-gn-args flag, it is now possible to
specify additional GN arguments for the build. This is needed
in order to pass a non-default Goma directory (needed for the bots).
Example use: --extra-gn-args goma_dir=\"/path/to/goma\"
You can also pass multiple args (separated by spaces).

BUG=chromium:684387
NOTRY=True
TESTED=Did a local successful run.

Review-Url: https://codereview.webrtc.org/2670743004
Cr-Commit-Position: refs/heads/master@{#16458}

tools-webrtc/android/build_aar.py

diff --git a/tools-webrtc/android/build_aar.py b/tools-webrtc/android/build_aar.py
index 7f6937f..d0cee97 100755
--- a/tools-webrtc/android/build_aar.py
+++ b/tools-webrtc/android/build_aar.py
@@ -48,12 +48,14 @@
   parser = argparse.ArgumentParser(description='libwebrtc.aar generator.')
   parser.add_argument('--output', default='libwebrtc.aar',
       help='Output file of the script.')
-  parser.add_argument('--arch', action='append', default=[],
-      help='Architectures to build. Defaults to ' + str(DEFAULT_ARCHS))
+  parser.add_argument('--arch', default=DEFAULT_ARCHS, nargs='*',
+      help='Architectures to build. Defaults to %(default)s.')
   parser.add_argument('--use-goma', action='store_true', default=False,
       help='Use goma.')
   parser.add_argument('--verbose', action='store_true', default=False,
       help='Debug logging.')
+  parser.add_argument('--extra-gn-args', default=[], nargs='*',
+      help='Additional GN args to be used during Ninja generation.')
   return parser.parse_args()
 
 
@@ -108,7 +110,7 @@
     raise Exception('Unknown arch: ' + arch)
 
 
-def Build(tmp_dir, arch, use_goma):
+def Build(tmp_dir, arch, use_goma, extra_gn_args):
   """Generates target architecture using GN and builds it using ninja."""
   logging.info('Building: %s', arch)
   output_directory = _GetOutputDirectory(tmp_dir, arch)
@@ -123,7 +125,7 @@
   if arm_version:
     gn_args['arm_version'] = arm_version
   gn_args_str = '--args=' + ' '.join([
-      k + '=' + _EncodeForGN(v) for k, v in gn_args.items()])
+      k + '=' + _EncodeForGN(v) for k, v in gn_args.items()] + extra_gn_args)
 
   _RunGN(['gen', output_directory, gn_args_str])
 
@@ -154,15 +156,12 @@
 
 def main():
   args = _ParseArgs()
-  if not args.arch:
-    args.arch = DEFAULT_ARCHS
-
   logging.basicConfig(level=logging.DEBUG if args.verbose else logging.INFO)
 
   tmp_dir = tempfile.mkdtemp()
 
   for arch in args.arch:
-    Build(tmp_dir, arch, args.use_goma)
+    Build(tmp_dir, arch, args.use_goma, args.extra_gn_args)
 
   with zipfile.ZipFile(args.output, 'w') as aar_file:
     # Architecture doesn't matter here, arbitrarily using the first one.