| commit | 32bcaf61f52f604c7e268533b43f1ee0a61dff43 | [log] [tgz] |
|---|---|---|
| author | kwiberg <kwiberg@webrtc.org> | Thu Oct 27 13:35:59 2016 -0700 |
| committer | Commit bot <commit-bot@chromium.org> | Thu Oct 27 20:36:08 2016 +0000 |
| tree | 3520a64dd7851414626e2cb25cc53c6a924891fe | |
| parent | a73df559d63b74acc1aeb8d9a4a8d26af6e6c6db [diff] |
Improve RTC_DCHECK_op so that it won't trigger useless compiler warnings Before this change, with DCHECKs switched off, this sort of check size_t index = ...; RTC_DCHECK_GE(index, 0u); would cause GCC (but no other compiler that we use) to complain that unsigned values are always greater than or equal to 0. With this change, it no longer complains. (It was and remains the case that there was no complaints if DCHECKs were switched on, or if you used RTC_CHECK_op.) The reason for doing this change is that it isn't useful for the compiler to force us to remove DCHECKs just because their condition can be verified statically. That causes us to remove the checks, and once that's happened, future code changes are free to violate the removed checks and no one will know... BUG=webrtc:6620 Review-Url: https://codereview.webrtc.org/2455943002 Cr-Commit-Position: refs/heads/master@{#14805}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.