commit 6bfac0383f345c8cb4c4fd5b00d93acada313be8
author Karl Wiberg <kwiberg@webrtc.org> Fri Oct 27 15:14:20 2017 +0200
committer Commit Bot <commit-bot@chromium.org> Sun Oct 29 03:04:33 2017 +0000
tree 4532460358275b2ea1ea561a9fb20a43f2fba8ff
parent c7b18fef19ffa7ad1a9ff231f3ae023d8f958ff0

.gn files in the API directories are part of the API too...

...since we can break users by changing the build targets they're
using.

BUG=webrtc:8445

Change-Id: Iaa549ce9802bd99639d8b966807ae2db43e7f14b
Reviewed-on: https://webrtc-review.googlesource.com/16460
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20471}

PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index c72fc19..a6d41c6 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -157,18 +157,19 @@
 def CheckNativeApiHeaderChanges(input_api, output_api):
   """Checks to remind proper changing of native APIs."""
   files = []
-  for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile):
-    if f.LocalPath().endswith('.h'):
-      for path in API_DIRS:
-        dn = os.path.dirname(f.LocalPath())
-        if path == 'api':
-          # Special case: Subdirectories included.
-          if dn == 'api' or dn.startswith('api/'):
-            files.append(f)
-        else:
-          # Normal case: Subdirectories not included.
-          if dn == path:
-            files.append(f)
+  source_file_filter = lambda x: input_api.FilterSourceFile(
+      x, white_list=[r'.+\.(gn|gni|h)$'])
+  for f in input_api.AffectedSourceFiles(source_file_filter):
+    for path in API_DIRS:
+      dn = os.path.dirname(f.LocalPath())
+      if path == 'api':
+        # Special case: Subdirectories included.
+        if dn == 'api' or dn.startswith('api/'):
+          files.append(f)
+      else:
+        # Normal case: Subdirectories not included.
+        if dn == path:
+          files.append(f)
 
   if files:
     return [output_api.PresubmitNotifyResult(API_CHANGE_MSG, files)]