commit 6f54e7ab679fe13c62e33c969d3b75d6f71eb4eb
author Henrik Lundin <henrik.lundin@webrtc.org> Tue Nov 28 15:26:52 2017 +0100
committer Commit Bot <commit-bot@chromium.org> Thu Dec 07 16:56:47 2017 +0000
tree 137c048a60675ba92c4cc5208ab63f23bb5c2255
parent 3863153267b935e50f4e7a26822201f97930d02c

Avoid integer-overflow in WebRtcSpl_FilterARFastQ12

Simply use int64_t instead of int32_t for two local variables.
This avoids integer-overflow in some rare cases.

Bug: chromium:784216
Change-Id: Ie96835d6dc04e338b157469b74ead29e8bd403dd
Reviewed-on: https://webrtc-review.googlesource.com/26580
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21141}

common_audio/signal_processing/filter_ar_fast_q12.c

diff --git a/common_audio/signal_processing/filter_ar_fast_q12.c b/common_audio/signal_processing/filter_ar_fast_q12.c
index 0767651..df9e518 100644
--- a/common_audio/signal_processing/filter_ar_fast_q12.c
+++ b/common_audio/signal_processing/filter_ar_fast_q12.c
@@ -25,8 +25,8 @@
   RTC_DCHECK_GT(coefficients_length, 1);
 
   for (i = 0; i < data_length; i++) {
-    int32_t output = 0;
-    int32_t sum = 0;
+    int64_t output = 0;
+    int64_t sum = 0;
 
     for (j = coefficients_length - 1; j > 0; j--) {
       sum += coefficients[j] * data_out[i - j];