commit | 6f7e6d6ff3533557ef99a0ceb01850f1fef071b3 | [log] [tgz] |
---|---|---|
author | Benjamin Wright <benwright@webrtc.org> | Wed May 02 13:46:31 2018 -0700 |
committer | Commit Bot <commit-bot@chromium.org> | Wed May 02 21:43:47 2018 +0000 |
tree | 1182c431abccd7766251aced5b654177fbda3ad8 | |
parent | 2199580590342381d07b215613be82964ab44871 [diff] |
Created PeerConnectionDependencies to avoid creating new CreatePeerConnection overloads. Currently CreatePeerConnection takes 3 parameters. This is going to expand to four with a new change. Every time a new parameter is added, we need to deprecate the old method, switch clients to the new one, update fake/mock classes and tests, and so on, which is a cumbersome process. To address this, this CL introduces a PeerConnectionDependencies structure to encapsulate all mandatory and optional dependencies (where a dependency is defined as non trivial executable code that an API user may want to provide to the native API). This allows adding a new injectable dependency by simply adding a new field to the struct, avoiding the hassle described above. You may think we could use RTCConfiguration for this. But since RTCConfiguration is both passed in and out of the PeerConnection (using GetConfiguration/SetConfiguration), it can't carry unique_ptrs. And we don't want to inject dependencies via raw pointers, since this could lead to lifetime management bugs, where the dependency is deleted before the PeerConnection is done using it. Bug: webrtc:7913 Change-Id: I38c3f4ce4f26b37e6fe219d1eeca271294b40db8 Reviewed-on: https://webrtc-review.googlesource.com/73663 Commit-Queue: Benjamin Wright <benwright@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23084}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.