commit 719487ec7a52d8e6e70c3dcf88ce7054ff68f131
author Harald Alvestrand <hta@webrtc.org> Wed Dec 13 12:26:04 2017 +0100
committer Commit Bot <commit-bot@chromium.org> Wed Dec 13 12:25:42 2017 +0000
tree 6980f9e7ca08c90adc6b3aeff75802bdacc58f8a
parent 7ca9ae2e26e9bea66f7773c2d40036c1cfdfc2c7

Generate signed packets_lost in WebRTC-stats

Bug: webrtc:8626
Change-Id: Ibeca29c5bb01e57c87fbf6a3c8589eb4e03089d5
Reviewed-on: https://webrtc-review.googlesource.com/32660
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21241}

pc/rtcstats_integrationtest.cc

diff --git a/pc/rtcstats_integrationtest.cc b/pc/rtcstats_integrationtest.cc
index b6c92f3..158d54b 100644
--- a/pc/rtcstats_integrationtest.cc
+++ b/pc/rtcstats_integrationtest.cc
@@ -633,7 +633,9 @@
     }
     verifier.TestMemberIsNonNegative<uint32_t>(inbound_stream.packets_received);
     verifier.TestMemberIsNonNegative<uint64_t>(inbound_stream.bytes_received);
-    verifier.TestMemberIsNonNegative<uint32_t>(inbound_stream.packets_lost);
+    // packets_lost is defined as signed, but this should never happen in
+    // this test. See RFC 3550.
+    verifier.TestMemberIsNonNegative<int32_t>(inbound_stream.packets_lost);
     if (inbound_stream.media_type.is_defined() &&
         *inbound_stream.media_type == "video") {
       verifier.TestMemberIsUndefined(inbound_stream.jitter);