| commit | 7439f973f72536cd9822d4e97b294185a9950b36 | [log] [tgz] |
|---|---|---|
| author | kjellander <kjellander@webrtc.org> | Mon Dec 05 22:47:46 2016 -0800 |
| committer | Commit bot <commit-bot@chromium.org> | Tue Dec 06 06:47:52 2016 +0000 |
| tree | 2cf7d366067ea66fea1c015421bcbb3e59146f11 | |
| parent | 5f7a9dc1c8c33e3bd09917944a746c0b079cef5e [diff] |
Split targets mixing .c and .cc sources. The Bazel build format doesn't support having separate lists of compilation flags for C and C++; it just has a single copts list for cc_library: https://bazel.build/versions/master/docs/be/c-cpp.html#cc_binary.copts This makes it hard to convert our GN targets to Bazel when there are compiler warnings that aren't supported for C (like -Woverloaded-virtual being added in bugs.webrtc.org/6653). The solution for this is to move all .c files to their own targets and remove C++-only compiler flags during conversion. New targets: //webrtc/common_audio:common_audio_c //webrtc/common_audio:common_audio_neon_c //webrtc/modules/audio_coding:g711_c //webrtc/modules/audio_coding:g722_c //webrtc/modules/audio_coding:ilbc_c //webrtc/modules/audio_coding:isac_c //webrtc/modules/audio_coding:isac_fix_c //webrtc/modules/audio_coding:isac_test_util //webrtc/modules/audio_coding:pcm16b_c //webrtc/modules/audio_coding:webrtc_opusj_c //webrtc/modules/audio_device:mac_portaudio //webrtc/modules/audio_procssing:audio_processing_c //webrtc/modules/audio_procssing:audio_processing_neon_c This CL also adds a PRESUBMIT.py check that will throw an error if targets are mixing .c and .cc files, to preven this from regressing. BUG=webrtc:6653 NOTRY=True Review-Url: https://codereview.webrtc.org/2550563003 Cr-Commit-Position: refs/heads/master@{#15433}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.