| commit | 76b3049e7c0cb6ec1c7bb741a83f71a5e791fbaf | [log] [tgz] |
|---|---|---|
| author | aleloi <aleloi@webrtc.org> | Fri Nov 18 02:03:04 2016 -0800 |
| committer | Commit bot <commit-bot@chromium.org> | Fri Nov 18 10:03:08 2016 +0000 |
| tree | 4ead89796350c05758d9bfc4d98752c2b41891df | |
| parent | a28780e994692f2494d8d54fb4539003a212dd6b [diff] |
Changed the interface AudioMixer::RemoveSource to have a void return type.
In the AudioMixerImpl implementation, removing a source never fails
and the return value is always true (see audio_mixer/audio_mixer_impl.cc).
A return value of |false| signaled that removing a source failed for
some reason. We have come to the conclusion that
* we don't know how to handle a return value of |false|
* we can't think of why an alternative implementation would need to
signal failure when removing a stream.
To avoid having a status code that is never read, never acted upon and
probably never set to anything but |true|, we change ::RemoveSource to
not have a return value.
NOTRY=True
BUG=webrtc:6346
Review-Url: https://codereview.webrtc.org/2506173003
Cr-Commit-Position: refs/heads/master@{#15150}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.