commit 7a284e1614a38286477ed2334ecbdde78e87b79c
author Jonas Oreland <jonaso@webrtc.org> Tue Jan 28 09:21:54 2020 +0100
committer Commit Bot <commit-bot@chromium.org> Tue Jan 28 09:50:06 2020 +0000
tree 6ebdb279cbb32c5e15f510f14d46cd2bc587cf21
parent 6136fdb287900f838dc7ac6a0c48b7b523534a66

TCPConnection: Defer FailAndPrune by signaling to self

What steps will reproduce the problem?
1. Connect a TCPPort, creating a TCPConnection
2. Disconnect the interface (e.g turn it off in android)
3. Send Ping on the TCPConnection

Crash.
The TCPConnection calls FailAndPrune when it fails to reconnect
the TCPConnection. FailAndPrune which removes the StunRequests.
When this is called from the Ping() code,
that will still access the StunRequest after the call to the Connection.

Solution: Instead of calling FailAndPrune deep down in the Ping()-stack
post a message to self to do this with a "clean" stack instead.

BUG: webrtc:11315
Change-Id: Id328b1b7c92311fa5b9adbfd2eb1dd14bf19805d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167522
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30389}