commit 818d91039282e5178b766d1123f17b543327269d
author Mirko Bonadei <mbonadei@webrtc.org> Tue Dec 12 12:46:13 2017 +0100
committer Commit Bot <commit-bot@chromium.org> Tue Dec 12 13:40:57 2017 +0000
tree c121bd0bb6849315535175919c09935d541eaaab
parent 9060eb1528715e96770ed2ec5f195c4bf51398af

Stop using public_deps in logging/.

Bug: webrtc:8603
Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/30940
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21228}

logging/BUILD.gn

diff --git a/logging/BUILD.gn b/logging/BUILD.gn
index ee2f455..9d1acf0 100644
--- a/logging/BUILD.gn
+++ b/logging/BUILD.gn
@@ -14,11 +14,11 @@
 }
 
 group("logging") {
-  public_deps = [
+  deps = [
     ":rtc_event_log_impl",
   ]
   if (rtc_enable_protobuf) {
-    public_deps += [ ":rtc_event_log_parser" ]
+    deps += [ ":rtc_event_log_parser" ]
   }
 }
 
@@ -139,13 +139,17 @@
       "rtc_event_log/rtc_event_log_parser.h",
     ]
 
-    public_deps = [
+    deps = [
       ":rtc_event_log_api",
       ":rtc_event_log_proto",
       "..:webrtc_common",
+      "../call:video_stream_api",
       "../modules/audio_coding:audio_network_adaptor",
       "../modules/remote_bitrate_estimator:remote_bitrate_estimator",
       "../modules/rtp_rtcp",
+      "../modules/rtp_rtcp:rtp_rtcp_format",
+      "../rtc_base:protobuf_utils",
+      "../rtc_base:rtc_base_approved",
       "../system_wrappers",
     ]
 
@@ -153,12 +157,6 @@
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
-    deps = [
-      "../call:video_stream_api",
-      "../modules/rtp_rtcp:rtp_rtcp_format",
-      "../rtc_base:protobuf_utils",
-      "../rtc_base:rtc_base_approved",
-    ]
   }
 
   if (rtc_include_tests) {
@@ -177,8 +175,10 @@
         "rtc_event_log/rtc_event_log_unittest_helper.h",
       ]
       deps = [
+        ":rtc_event_log_api",
         ":rtc_event_log_impl",
         ":rtc_event_log_parser",
+        ":rtc_event_log_proto",
         "../api:libjingle_peerconnection_api",
         "../call",
         "../call:call_interfaces",
@@ -206,7 +206,9 @@
         ":rtc_event_log_api",
         ":rtc_event_log_impl",
         ":rtc_event_log_parser",
+        "../modules/rtp_rtcp",
         "../modules/rtp_rtcp:rtp_rtcp_format",
+        "../rtc_base:protobuf_utils",
         "../rtc_base:rtc_base_approved",
         "../system_wrappers:field_trial_default",
         "../system_wrappers:metrics_default",
@@ -228,8 +230,10 @@
         ":rtc_event_log_api",
         ":rtc_event_log_impl",
         ":rtc_event_log_parser",
+        "../:webrtc_common",
         "../call:video_stream_api",
         "../modules/rtp_rtcp:rtp_rtcp_format",
+        "../rtc_base:protobuf_utils",
         "../rtc_base:rtc_base_approved",
 
         # TODO(kwiberg): Remove this dependency.