commit | 81b9291dfddbfe1bd940ac7aab9a1b41c2b9c188 | [log] [tgz] |
---|---|---|
author | peah <peah@webrtc.org> | Thu Oct 06 06:46:20 2016 -0700 |
committer | Commit bot <commit-bot@chromium.org> | Thu Oct 06 13:46:27 2016 +0000 |
tree | eeb1d9c210c90a4550823199a82d16d3825dd2b6 | |
parent | 21a18ee267146c86e188d95edf6432f71dd53aeb [diff] |
The FFT functionality in aec_rdft* is based on legacy C code which is not thread-safe in the sense that the rdft_init method can only be run in a single-threaded. Currently, inside WebRTC multiple instances of the audio- processing module are set up which means that the init method may be run concurrently. In order to avoid having to protect the init method with a lock to ensure single-threaded behavior that, this CL places the FFT functionality inside a class so that there is no global component of the FFT functionality. Note that: 1) The nonstandard header for the ooura_fft.cc was copied from the aec_rdft.cc header, and augmented with a description of the changes introduced in this CL. 2) The clang warnings for the ooura_fft_sse2.cc, ooura_fft_neon.cc and ooura_fft_mips.cc were not addressed as this code was kept as it was before this CL 3) Clang-format was run on all files apart from ooura_fft_mips.cc (as that would change the format of the inline assempbly code). Adding bypass of presubmit to avoid code style and header errors caused by the fact that files with legacy code are being renamed. NOPRESUBMIT=true BUG=chromium:638583 Review-Url: https://codereview.webrtc.org/2348213002 Cr-Commit-Position: refs/heads/master@{#14554}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.