Fix pylint presubmit errors and warnings from untouched modules.
BUG=None
Change-Id: I619dab14875e19477beb8bfb566ed1f34009c025
Reviewed-on: https://webrtc-review.googlesource.com/85960
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23754}diff --git a/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_optimize.py b/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_optimize.py
index 7946fe2..3daf482 100644
--- a/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_optimize.py
+++ b/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_optimize.py
@@ -105,7 +105,7 @@
else:
result['params'][param] = config_json['-' + param]
- current_param_combination = param_combination( # pylint: disable=star-args
+ current_param_combination = param_combination(
**config_optimize_params)
results[current_param_combination].append(result)
return results
diff --git a/modules/audio_processing/test/py_quality_assessment/quality_assessment/annotations.py b/modules/audio_processing/test/py_quality_assessment/quality_assessment/annotations.py
index 5c8c8ba..ca5bd1f 100644
--- a/modules/audio_processing/test/py_quality_assessment/quality_assessment/annotations.py
+++ b/modules/audio_processing/test/py_quality_assessment/quality_assessment/annotations.py
@@ -181,7 +181,6 @@
ext_kwargs = {'extvad_conf-' + ext_vad:
self._external_vads[ext_vad].GetVadOutput()
for ext_vad in self._external_vads}
- # pylint: disable=star-args
np.savez_compressed(
file=os.path.join(
output_path,
diff --git a/tools_webrtc/android/build_aar.py b/tools_webrtc/android/build_aar.py
index 85bdea7..18b1eb5 100755
--- a/tools_webrtc/android/build_aar.py
+++ b/tools_webrtc/android/build_aar.py
@@ -103,9 +103,9 @@
def _EncodeForGN(value):
"""Encodes value as a GN literal."""
- if type(value) is str:
+ if isinstance(value, str):
return '"' + value + '"'
- elif type(value) is bool:
+ elif isinstance(value, bool):
return repr(value).lower()
else:
return repr(value)
diff --git a/tools_webrtc/autoroller/checkin_chromium_dep.py b/tools_webrtc/autoroller/checkin_chromium_dep.py
index 262f1cb..ba3b0a0 100755
--- a/tools_webrtc/autoroller/checkin_chromium_dep.py
+++ b/tools_webrtc/autoroller/checkin_chromium_dep.py
@@ -90,7 +90,7 @@
logging.debug('CMD: %s CWD: %s', ' '.join(command), working_dir)
env = os.environ.copy()
if extra_env:
- assert all(type(value) == str for value in extra_env.values())
+ assert all(isinstance(value, str) for value in extra_env.values())
logging.debug('extra env: %s', extra_env)
env.update(extra_env)
p = subprocess.Popen(command,
diff --git a/tools_webrtc/autoroller/roll_deps.py b/tools_webrtc/autoroller/roll_deps.py
index 63393f2..2da8987 100755
--- a/tools_webrtc/autoroller/roll_deps.py
+++ b/tools_webrtc/autoroller/roll_deps.py
@@ -124,7 +124,7 @@
logging.debug('CMD: %s CWD: %s', ' '.join(command), working_dir)
env = os.environ.copy()
if extra_env:
- assert all(type(value) == str for value in extra_env.values())
+ assert all(isinstance(value, str) for value in extra_env.values())
logging.debug('extra env: %s', extra_env)
env.update(extra_env)
p = subprocess.Popen(command,
diff --git a/tools_webrtc/presubmit_checks_lib/check_orphan_headers.py b/tools_webrtc/presubmit_checks_lib/check_orphan_headers.py
index 31be719..deb445c 100644
--- a/tools_webrtc/presubmit_checks_lib/check_orphan_headers.py
+++ b/tools_webrtc/presubmit_checks_lib/check_orphan_headers.py
@@ -114,7 +114,6 @@
source_file = source_file_match.group('source_file')
if source_file.endswith('.h'):
source_file_tokens = string.split(source_file, '/')
- # pylint: disable=star-args
headers_in_sources.add(os.path.join(target_abs_path,
*source_file_tokens))
return headers_in_sources