| commit | 82dda1af5e7401334b819a1b050be19660ace821 | [log] [tgz] |
|---|---|---|
| author | zijiehe <zijiehe@chromium.org> | Mon Aug 15 19:53:31 2016 -0700 |
| committer | Commit bot <commit-bot@chromium.org> | Tue Aug 16 02:53:40 2016 +0000 |
| tree | 0715073e209c6e9c315bb89d69a88475bfa6543f | |
| parent | e1b4d243e288b9517e9ea66596dae4e597a08f0a [diff] |
[WebRTC] Disable DirectX capturer tests if the system does not support it. A recent DrMemory failure has been detected after change 2099123002. After some investigation, an uninitialized read has been detected in NtUserGetThreadDesktop webrtc::Desktop::GetThreadDesktop webrtc::ScopedThreadDesktop::ScopedThreadDesktop webrtc::ScreenCapturerWinGdi::ScreenCapturerWinGdi webrtc::ScreenCapturer::Create webrtc::ScreenCapturerTest_UseDirectxCapturer_Test::TestBody So there are two issues, 1. The Directx capturer won't be triggered as the system does not support it. So these tests should be disabled in this scenario. 2. An uninitialized read in NtUserGetThreadDesktop -> ScopedThreadDesktop stacks, which should be suppressed. By default, these suppressions should be placed in chromium/external with other suppressions. So this change is a quick fix to the failure, do not use ScreenCapturerWinGdi in ScreenCaputrerWinDirectx tests. BUG= Review-Url: https://codereview.webrtc.org/2247943002 Cr-Commit-Position: refs/heads/master@{#13766}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.