| commit | 835cc0c646300bf8e237a53e551b3e94c456a225 | [log] [tgz] |
|---|---|---|
| author | Magnus Jedvert <magjed@webrtc.org> | Sat Sep 23 16:14:25 2017 +0200 |
| committer | Commit Bot <commit-bot@chromium.org> | Sat Sep 23 14:36:14 2017 +0000 |
| tree | b080f358843622e4d3f12ebb7d064da9f8aff610 | |
| parent | 73c81759cb07f1a68d907bc3f03d90d63aabfb10 [diff] |
Remove unnecessary audio references in PeerConnectionFactory We currently pass in a lot of audio parameters to PeerConnectionFactory which we never use. This CL removes them. All these parameters are reference counted, so they are not needed for lifetime management (unless we do something crazy). Even if we want to switch from reference counting to std::unique_ptrs in the future, the voice engine is a more suitable owner than PeerConnectionFactory. The PeerConnectionFactory already owns a MediaEngine which in turn owns a VoiceEngine. Bug: webrtc:7613 Change-Id: I393cf0d29ffa762a3a13475f6fbe00b8565f4c07 Reviewed-on: https://webrtc-review.googlesource.com/1600 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19931}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.