Use source_sets in component builds and static_library in release builds.
Static libraries don't guarantee that an exported symbol gets linked
into a shared library (and in order to support Chromium's component
build mode, WebRTC needs to be linked as a shared library).
Source sets always pass all the object files to the linker.
On the flip side, source_sets link more object files in release builds
and to avoid this, this CL introduces a the GN template "rtc_library" that
expands to static_library during release builds and to source_set during
component builds.
See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set
Bug: webrtc:9419
Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#29525}
diff --git a/audio/BUILD.gn b/audio/BUILD.gn
index ba4518d..5bb7b8c 100644
--- a/audio/BUILD.gn
+++ b/audio/BUILD.gn
@@ -12,7 +12,7 @@
import("//build/config/android/rules.gni")
}
-rtc_static_library("audio") {
+rtc_library("audio") {
sources = [
"audio_level.cc",
"audio_level.h",
@@ -92,7 +92,7 @@
]
}
if (rtc_include_tests) {
- rtc_source_set("audio_end_to_end_test") {
+ rtc_library("audio_end_to_end_test") {
testonly = true
sources = [
@@ -111,7 +111,7 @@
]
}
- rtc_source_set("audio_tests") {
+ rtc_library("audio_tests") {
testonly = true
sources = [
@@ -255,7 +255,7 @@
}
}
- rtc_source_set("audio_perf_tests") {
+ rtc_library("audio_perf_tests") {
testonly = true
sources = [