commit 8b0aed1dd62c09fa4567e7325b982c1ced682746
author Mirko Bonadei <mbonadei@webrtc.org> Fri Sep 07 16:23:41 2018 +0200
committer Commit Bot <commit-bot@chromium.org> Tue Sep 11 06:39:14 2018 +0000
tree fdc2cca972b26f7267a0955b1c9f4eebffac569d
parent 64ef4f7c9533e29ec2bb189852a688c37268dbcd

Fix no_global_constructors/no_exit_time_destructors in Neteq.

Bug: webrtc:9693
Change-Id: I0135e934c638ec391546928ba1e623d137b27b75
Reviewed-on: https://webrtc-review.googlesource.com/98600
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24668}

modules/audio_coding/BUILD.gn

diff --git a/modules/audio_coding/BUILD.gn b/modules/audio_coding/BUILD.gn
index a08bcf3..09b9df5 100644
--- a/modules/audio_coding/BUILD.gn
+++ b/modules/audio_coding/BUILD.gn
@@ -1156,10 +1156,6 @@
 
 rtc_source_set("neteq_tools") {
   visibility += webrtc_default_visibility
-  configs += [
-    "../..:no_exit_time_destructors",
-    "../..:no_global_constructors",
-  ]
   sources = [
     "neteq/tools/fake_decode_from_file.cc",
     "neteq/tools/fake_decode_from_file.h",
@@ -1187,6 +1183,7 @@
     "../../rtc_base:rtc_base_approved",
     "../rtp_rtcp",
     "../rtp_rtcp:rtp_rtcp_format",
+    "//third_party/abseil-cpp/absl/strings:strings",
     "//third_party/abseil-cpp/absl/types:optional",
   ]
 

modules/audio_coding/neteq/tools/neteq_delay_analyzer.cc

diff --git a/modules/audio_coding/neteq/tools/neteq_delay_analyzer.cc b/modules/audio_coding/neteq/tools/neteq_delay_analyzer.cc
index e5bd765..60e6902 100644
--- a/modules/audio_coding/neteq/tools/neteq_delay_analyzer.cc
+++ b/modules/audio_coding/neteq/tools/neteq_delay_analyzer.cc
@@ -17,18 +17,19 @@
 #include <limits>
 #include <utility>
 
+#include "absl/strings/string_view.h"
 #include "modules/include/module_common_types.h"
 #include "rtc_base/checks.h"
 
 namespace webrtc {
 namespace test {
 namespace {
-std::string kArrivalDelayX = "arrival_delay_x";
-std::string kArrivalDelayY = "arrival_delay_y";
-std::string kTargetDelayX = "target_delay_x";
-std::string kTargetDelayY = "target_delay_y";
-std::string kPlayoutDelayX = "playout_delay_x";
-std::string kPlayoutDelayY = "playout_delay_y";
+constexpr char kArrivalDelayX[] = "arrival_delay_x";
+constexpr char kArrivalDelayY[] = "arrival_delay_y";
+constexpr char kTargetDelayX[] = "target_delay_x";
+constexpr char kTargetDelayY[] = "target_delay_y";
+constexpr char kPlayoutDelayX[] = "playout_delay_x";
+constexpr char kPlayoutDelayY[] = "playout_delay_y";
 
 // Helper function for NetEqDelayAnalyzer::CreateGraphs. Returns the
 // interpolated value of a function at the point x. Vector x_vec contains the
@@ -64,8 +65,8 @@
 
 void PrintDelays(const NetEqDelayAnalyzer::Delays& delays,
                  int64_t ref_time_ms,
-                 const std::string& var_name_x,
-                 const std::string& var_name_y,
+                 absl::string_view var_name_x,
+                 absl::string_view var_name_y,
                  std::ofstream& output,
                  const std::string& terminator = "") {
   output << var_name_x << " = [ ";