commit 91d6edef35e7275879c30ce16ecb8b6dc73c6e4a
author henrikg <henrikg@webrtc.org> Thu Sep 17 00:24:34 2015 -0700
committer Commit bot <commit-bot@chromium.org> Thu Sep 17 07:24:51 2015 +0000
tree 313b64a3d88422a53f5b091f770a2d33dce823ce
parent c0ac6cad00f51b99fafaa7c19e2e63b3b542735b

Add RTC_ prefix to (D)CHECKs and related macros.

We must remove dependency on Chromium, i.e. we can't use Chromium's base/logging.h. That means we need to define these macros in WebRTC also when doing Chromium builds. And this causes redefinition.

Alternative solutions:
* Check if we already have defined e.g. CHECK, and don't define them in that case. This makes us depend on include order in Chromium, which is not acceptable.
* Don't allow using the macros in WebRTC headers. Error prone since if someone adds it there by mistake it may compile fine, but later break if a header in added or order is changed in Chromium. That will be confusing and hard to enforce.
* Ensure that headers that are included by an embedder don't include our macros. This would require some heavy refactoring to be maintainable and enforcable.
* Changes in Chromium for this is obviously not an option.

BUG=chromium:468375
NOTRY=true

Review URL: https://codereview.webrtc.org/1335923002

Cr-Commit-Position: refs/heads/master@{#9964}