| commit | af070d029991273298b8cba4efe55c0d9ebce683 | [log] [tgz] |
|---|---|---|
| author | henrika <henrika@webrtc.org> | Fri Nov 22 14:47:31 2019 +0100 |
| committer | Commit Bot <commit-bot@chromium.org> | Fri Nov 22 14:27:10 2019 +0000 |
| tree | b3ac26a3c5ca59a9d2360a229b8e7d03fe177ffb | |
| parent | e43b53126600d247fbfde8b5c29b22ee22e59c86 [diff] |
Improves device enumeration in ADM2 for Windows. Summary of changes/improvements and fixes: Changes container for list of devices from std::vector to std:deque to allow fast insertion and deletion at both its beginning and its end. This approach makes it easier to first build a list of all available devices and then check the size of the list. If size > 0 => two more devices are added at the front (Default and Default Communication). The old solution contained a risk of adding invalid Default and Default Communication devices in cases where not physical device could be found. Adds usage of |device_index_| in CoreAudioBase to ensure that the selected device is unique. The previous version used only an ID but that ID is not unique when e.g. only one device exists since it can have up to three different roles. Improves logging and comments. No-Try: True Tbr: thaloun@chromium.org Bug: webrtc:11107 Change-Id: I9a09f7716ed8d8858dcc6a5354b038fc06496166 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160050 Commit-Queue: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29874}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.