commit b5bb5130661441327104443630d96da372a7cb02
author Yves Gerey <yvesg@webrtc.org> Wed Nov 14 18:00:14 2018 +0100
committer Commit Bot <commit-bot@chromium.org> Fri Nov 16 17:13:40 2018 +0000
tree 87227e9fbc8ef27a88daea684f0ae26b519aafd1
parent 6eb8a16dbf1e679f9c62b261da7beecbdc7a3cdd

Disable RTCStatsIntegrationTest.GetsStatsWhileDestroyingPeerConnection

The current implementation triggers vptr race condition due to the
test setup itself (see bug for the glorious details).
Disabling the test reduces TSAN noise and will help to detect more
critical defects.

Bug: webrtc:9847
Change-Id: I4912b00f1faad5f41ccaa4b55bc21b5215b816c9
Reviewed-on: https://webrtc-review.googlesource.com/c/110907
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Yves Gerey <yvesg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25674}

pc/rtcstats_integrationtest.cc

diff --git a/pc/rtcstats_integrationtest.cc b/pc/rtcstats_integrationtest.cc
index 3c07e38..f9375f7 100644
--- a/pc/rtcstats_integrationtest.cc
+++ b/pc/rtcstats_integrationtest.cc
@@ -806,7 +806,11 @@
   EXPECT_FALSE(report->size());
 }
 
-TEST_F(RTCStatsIntegrationTest, GetsStatsWhileDestroyingPeerConnections) {
+// TODO(bugs.webrtc.org/9847) Remove this test altogether if a proper fix cannot
+// be found. For now it is lying, as we cannot safely gets stats while
+// destroying PeerConnection.
+TEST_F(RTCStatsIntegrationTest,
+       DISABLED_GetsStatsWhileDestroyingPeerConnection) {
   StartCall();
 
   rtc::scoped_refptr<RTCStatsObtainer> stats_obtainer =