GN hack to tag targets as poisonous (and use it with audio codecs)
Only specially taggged targets may transitively depend on poisonous
targets. We first apply it to audio codecs.
This makes it much clearer exactly what parts of the code still have
dependencies on the audio codecs (and we want to eventually get rid of
pretty much all of them).
Bug: webrtc:8396, webrtc:9121
Change-Id: Iba5c2e806c702b5cfe881022674705f647896d43
Reviewed-on: https://webrtc-review.googlesource.com/69520
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22979}diff --git a/api/audio_codecs/BUILD.gn b/api/audio_codecs/BUILD.gn
index fb033f2..ee943a1 100644
--- a/api/audio_codecs/BUILD.gn
+++ b/api/audio_codecs/BUILD.gn
@@ -44,6 +44,7 @@
rtc_static_library("builtin_audio_decoder_factory") {
visibility = [ "*" ]
+ allow_poison = [ "audio_codecs" ]
sources = [
"builtin_audio_decoder_factory.cc",
"builtin_audio_decoder_factory.h",
@@ -73,6 +74,7 @@
rtc_static_library("builtin_audio_encoder_factory") {
visibility = [ "*" ]
+ allow_poison = [ "audio_codecs" ]
sources = [
"builtin_audio_encoder_factory.cc",
"builtin_audio_encoder_factory.h",
diff --git a/api/audio_codecs/L16/BUILD.gn b/api/audio_codecs/L16/BUILD.gn
index f047bf1..01554aa 100644
--- a/api/audio_codecs/L16/BUILD.gn
+++ b/api/audio_codecs/L16/BUILD.gn
@@ -14,6 +14,7 @@
rtc_static_library("audio_encoder_L16") {
visibility = [ "*" ]
+ poisonous = [ "audio_codecs" ]
sources = [
"audio_encoder_L16.cc",
"audio_encoder_L16.h",
@@ -29,6 +30,7 @@
rtc_static_library("audio_decoder_L16") {
visibility = [ "*" ]
+ poisonous = [ "audio_codecs" ]
sources = [
"audio_decoder_L16.cc",
"audio_decoder_L16.h",
diff --git a/api/audio_codecs/g711/BUILD.gn b/api/audio_codecs/g711/BUILD.gn
index f28342f..7026abb 100644
--- a/api/audio_codecs/g711/BUILD.gn
+++ b/api/audio_codecs/g711/BUILD.gn
@@ -14,6 +14,7 @@
rtc_static_library("audio_encoder_g711") {
visibility = [ "*" ]
+ poisonous = [ "audio_codecs" ]
sources = [
"audio_encoder_g711.cc",
"audio_encoder_g711.h",
@@ -30,6 +31,7 @@
rtc_static_library("audio_decoder_g711") {
visibility = [ "*" ]
+ poisonous = [ "audio_codecs" ]
sources = [
"audio_decoder_g711.cc",
"audio_decoder_g711.h",
diff --git a/api/audio_codecs/g722/BUILD.gn b/api/audio_codecs/g722/BUILD.gn
index b3ef381..7078aa4 100644
--- a/api/audio_codecs/g722/BUILD.gn
+++ b/api/audio_codecs/g722/BUILD.gn
@@ -21,6 +21,7 @@
rtc_static_library("audio_encoder_g722") {
visibility = [ "*" ]
+ poisonous = [ "audio_codecs" ]
sources = [
"audio_encoder_g722.cc",
"audio_encoder_g722.h",
@@ -38,6 +39,7 @@
rtc_static_library("audio_decoder_g722") {
visibility = [ "*" ]
+ poisonous = [ "audio_codecs" ]
sources = [
"audio_decoder_g722.cc",
"audio_decoder_g722.h",
diff --git a/api/audio_codecs/ilbc/BUILD.gn b/api/audio_codecs/ilbc/BUILD.gn
index 765e279..52dac5f 100644
--- a/api/audio_codecs/ilbc/BUILD.gn
+++ b/api/audio_codecs/ilbc/BUILD.gn
@@ -21,6 +21,7 @@
rtc_static_library("audio_encoder_ilbc") {
visibility = [ "*" ]
+ poisonous = [ "audio_codecs" ]
sources = [
"audio_encoder_ilbc.cc",
"audio_encoder_ilbc.h",
@@ -38,6 +39,7 @@
rtc_static_library("audio_decoder_ilbc") {
visibility = [ "*" ]
+ poisonous = [ "audio_codecs" ]
sources = [
"audio_decoder_ilbc.cc",
"audio_decoder_ilbc.h",
diff --git a/api/audio_codecs/isac/BUILD.gn b/api/audio_codecs/isac/BUILD.gn
index f63435c..08cabc5 100644
--- a/api/audio_codecs/isac/BUILD.gn
+++ b/api/audio_codecs/isac/BUILD.gn
@@ -19,6 +19,7 @@
rtc_source_set("audio_encoder_isac") {
visibility = [ "*" ]
+ poisonous = [ "audio_codecs" ]
public = [
"audio_encoder_isac.h",
]
@@ -36,6 +37,7 @@
rtc_source_set("audio_decoder_isac") {
visibility = [ "*" ]
+ poisonous = [ "audio_codecs" ]
public = [
"audio_decoder_isac.h",
]
@@ -68,6 +70,7 @@
rtc_static_library("audio_encoder_isac_fix") {
visibility = [ "*" ]
+ poisonous = [ "audio_codecs" ]
sources = [
"audio_encoder_isac_fix.cc",
"audio_encoder_isac_fix.h",
@@ -83,6 +86,7 @@
rtc_static_library("audio_decoder_isac_fix") {
visibility = [ "*" ]
+ poisonous = [ "audio_codecs" ]
sources = [
"audio_decoder_isac_fix.cc",
"audio_decoder_isac_fix.h",
@@ -98,6 +102,7 @@
rtc_static_library("audio_encoder_isac_float") {
visibility = [ "*" ]
+ poisonous = [ "audio_codecs" ]
sources = [
"audio_encoder_isac_float.cc",
"audio_encoder_isac_float.h",
@@ -113,6 +118,7 @@
rtc_static_library("audio_decoder_isac_float") {
visibility = [ "*" ]
+ poisonous = [ "audio_codecs" ]
sources = [
"audio_decoder_isac_float.cc",
"audio_decoder_isac_float.h",
diff --git a/api/audio_codecs/opus/BUILD.gn b/api/audio_codecs/opus/BUILD.gn
index 934dbc2..d235d1a 100644
--- a/api/audio_codecs/opus/BUILD.gn
+++ b/api/audio_codecs/opus/BUILD.gn
@@ -32,6 +32,7 @@
rtc_source_set("audio_encoder_opus") {
visibility = [ "*" ]
+ poisonous = [ "audio_codecs" ]
public = [
"audio_encoder_opus.h",
]
@@ -49,6 +50,7 @@
rtc_static_library("audio_decoder_opus") {
visibility = [ "*" ]
+ poisonous = [ "audio_codecs" ]
sources = [
"audio_decoder_opus.cc",
"audio_decoder_opus.h",