commit bd27b14638e4d9ad4e394785defd09140b9293ef
author Mirko Bonadei <mbonadei@webrtc.org> Tue Nov 12 10:19:25 2019 +0000
committer Commit Bot <commit-bot@chromium.org> Tue Nov 12 10:19:34 2019 +0000
tree 9c6bd0a52afc0353d8b75d4aed17f7992f3539ae
parent ba916b7bd4e27cb93cad1e2bbefe337f2d38ae42

Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""

This reverts commit bcec8a7f0290709426ae08c5a1b1c9cff766e39b.

Reason for revert: This CL was just needed in order to
have a WebRTC commit to pin in Chromium to test the
component build (this CL enables symbol exports).

Original change's description:
> Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
> 
> This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed
> 
> I will revert this reland as soon as it lands because I just need
> to have a WebRTC commit to pin in Chromium in order to test the
> component build (this CL enables symbol exports).
> 
> Original change's description:
> > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.
> >
> > In order to land the component build support in Chromium, it is
> > easier to turn on symbols export every time that is_component_build=true
> > instead of setting rtc_enable_symbol_export=is_component_build in
> > Chromium (since is_component_build is not available in .gn).
> >
> > rtc_enable_symbol_export is still kept in the mix in order to turn
> > on symbol exports in any case a shared library will be added to the
> > WebRTC build.
> >
> > Bug: webrtc:9419
> > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#29540}
> 
> No-Try: True
> TBR: kwiberg@webrtc.org
> Bug: webrtc:9419
> Change-Id: I70fdee572082f65132f638bf6c1605c7b23a9efb
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159684
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29767}

TBR=mbonadei@webrtc.org,kwiberg@webrtc.org

Change-Id: Ic822b10e2474621306c3cce7ea96715953e487c5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9419
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159685
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29769}