Removes RPLR based FEC controller.
This is not used and adds a lot of maintenance overhead to
the code since it requires that the transport feedback adapter
communicates directly with audio send stream.
This also means that the packet loss tracker used as input for
this can be removed and a lot of wiring up code overall.
Bug: webrtc:9883
Change-Id: I25689fb622ed89cbb378c27212a159485f5f53be
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156502
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Reviewed-by: Minyue Li <minyue@webrtc.org>
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29667}
diff --git a/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc b/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc
index 8ca26bb..606237d 100644
--- a/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc
+++ b/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc
@@ -41,10 +41,7 @@
arg.target_audio_bitrate_bps == metric.target_audio_bitrate_bps &&
arg.rtt_ms == metric.rtt_ms &&
arg.overhead_bytes_per_packet == metric.overhead_bytes_per_packet &&
- arg.uplink_packet_loss_fraction ==
- metric.uplink_packet_loss_fraction &&
- arg.uplink_recoverable_packet_loss_fraction ==
- metric.uplink_recoverable_packet_loss_fraction;
+ arg.uplink_packet_loss_fraction == metric.uplink_packet_loss_fraction;
}
MATCHER_P(IsRtcEventAnaConfigEqualTo, config, "") {
@@ -139,17 +136,6 @@
states.audio_network_adaptor->SetUplinkPacketLossFraction(kPacketLoss);
}
-TEST(AudioNetworkAdaptorImplTest,
- UpdateNetworkMetricsIsCalledOnSetUplinkRecoverablePacketLossFraction) {
- auto states = CreateAudioNetworkAdaptor();
- constexpr float kRecoverablePacketLoss = 0.1f;
- Controller::NetworkMetrics check;
- check.uplink_recoverable_packet_loss_fraction = kRecoverablePacketLoss;
- SetExpectCallToUpdateNetworkMetrics(states.mock_controllers, check);
- states.audio_network_adaptor->SetUplinkRecoverablePacketLossFraction(
- kRecoverablePacketLoss);
-}
-
TEST(AudioNetworkAdaptorImplTest, UpdateNetworkMetricsIsCalledOnSetRtt) {
auto states = CreateAudioNetworkAdaptor();
constexpr int kRtt = 100;
@@ -216,7 +202,6 @@
constexpr int kBandwidth = 16000;
constexpr float kPacketLoss = 0.7f;
- const auto kRecoverablePacketLoss = 0.2f;
constexpr int kRtt = 100;
constexpr int kTargetAudioBitrate = 15000;
constexpr size_t kOverhead = 64;
@@ -238,11 +223,6 @@
fake_clock.AdvanceTime(TimeDelta::ms(50));
timestamp_check += 50;
- check.uplink_recoverable_packet_loss_fraction = kRecoverablePacketLoss;
- EXPECT_CALL(*states.mock_debug_dump_writer,
- DumpNetworkMetrics(NetworkMetricsIs(check), timestamp_check));
- states.audio_network_adaptor->SetUplinkRecoverablePacketLossFraction(
- kRecoverablePacketLoss);
fake_clock.AdvanceTime(TimeDelta::ms(200));
timestamp_check += 200;