Move video_replay under rtc_tools/.
As pointed out in [1], RTC public tools should live in rtc_tools.
[1] - https://webrtc-review.googlesource.com/c/src/+/168320/2#message-1f40103105ecb077aeec153c5270575138349a50
Bug: chromium:942546
Change-Id: Ic827d9b31ade9a32bf4ef24d020ef8c81d2c9a5b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168308
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30486}
diff --git a/BUILD.gn b/BUILD.gn
index 24dc067..12ba794 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -56,13 +56,13 @@
"pc:peerconnection_unittests",
"pc:rtc_pc_unittests",
"rtc_tools:rtp_generator",
+ "rtc_tools:video_replay",
"stats:rtc_stats_unittests",
"system_wrappers:system_wrappers_unittests",
"test",
"video:screenshare_loopback",
"video:sv_loopback",
"video:video_loopback",
- "video:video_replay",
]
if (!is_asan) {
# Do not build :webrtc_lib_link_test because lld complains on some OS
diff --git a/rtc_tools/BUILD.gn b/rtc_tools/BUILD.gn
index 30c0cf5..dbc163b 100644
--- a/rtc_tools/BUILD.gn
+++ b/rtc_tools/BUILD.gn
@@ -190,6 +190,50 @@
deps += [ "//third_party/webrtc_overrides:webrtc_component" ]
}
}
+
+ # This target can be built from Chromium but it doesn't support
+ # is_component_build=true because it depends on WebRTC testonly code
+ # which is not part of //third_party/webrtc_overrides:webrtc_component.
+ rtc_executable("video_replay") {
+ visibility = [ "*" ]
+ testonly = true
+ sources = [ "video_replay.cc" ]
+ deps = [
+ "../api/rtc_event_log",
+ "../api/task_queue:default_task_queue_factory",
+ "../api/test/video:function_video_factory",
+ "../api/transport:field_trial_based_config",
+ "../api/video_codecs:video_codecs_api",
+ "../call",
+ "../call:call_interfaces",
+ "../common_video",
+ "../media:rtc_internal_video_codecs",
+ "../rtc_base:checks",
+ "../rtc_base:rtc_json",
+ "../rtc_base:stringutils",
+ "../rtc_base:timeutils",
+ "../system_wrappers",
+ "../test:call_config_utils",
+ "../test:encoder_settings",
+ "../test:fake_video_codecs",
+ "../test:null_transport",
+ "../test:rtp_test_utils",
+ "../test:run_test",
+ "../test:run_test_interface",
+ "../test:test_common",
+ "../test:test_renderer",
+ "../test:test_support",
+ "../test:video_test_common",
+ "../test:video_test_support",
+ "//third_party/abseil-cpp/absl/flags:flag",
+ "//third_party/abseil-cpp/absl/flags:parse",
+ ]
+ if (build_with_chromium) {
+ # When building from Chromium, WebRTC's metrics and field trial
+ # implementations need to be replaced by the Chromium ones.
+ deps += [ "//third_party/webrtc_overrides:webrtc_component" ]
+ }
+ }
}
# Only expose the targets needed by Chromium (e.g. frame_analyzer) to avoid
diff --git a/video/video_replay.cc b/rtc_tools/video_replay.cc
similarity index 100%
rename from video/video_replay.cc
rename to rtc_tools/video_replay.cc
diff --git a/video/BUILD.gn b/video/BUILD.gn
index 1d89217..0653113 100644
--- a/video/BUILD.gn
+++ b/video/BUILD.gn
@@ -243,52 +243,6 @@
]
}
-if (!is_component_build) {
- # This target can be built from Chromium but it doesn't support
- # is_component_build=true because it depends on WebRTC testonly code
- # which is not part of //third_party/webrtc_overrides:webrtc_component.
- rtc_executable("video_replay") {
- visibility = [ "*" ]
- testonly = true
- sources = [ "video_replay.cc" ]
- deps = [
- "../api/rtc_event_log",
- "../api/task_queue:default_task_queue_factory",
- "../api/test/video:function_video_factory",
- "../api/transport:field_trial_based_config",
- "../api/video_codecs:video_codecs_api",
- "../call",
- "../call:call_interfaces",
- "../common_video",
- "../media:rtc_internal_video_codecs",
- "../rtc_base:checks",
- "../rtc_base:rtc_json",
- "../rtc_base:stringutils",
- "../rtc_base:timeutils",
- "../system_wrappers",
- "../test:call_config_utils",
- "../test:encoder_settings",
- "../test:fake_video_codecs",
- "../test:null_transport",
- "../test:rtp_test_utils",
- "../test:run_test",
- "../test:run_test_interface",
- "../test:test_common",
- "../test:test_renderer",
- "../test:test_support",
- "../test:video_test_common",
- "../test:video_test_support",
- "//third_party/abseil-cpp/absl/flags:flag",
- "//third_party/abseil-cpp/absl/flags:parse",
- ]
- if (build_with_chromium) {
- # When building from Chromium, WebRTC's metrics and field trial
- # implementations need to be replaced by the Chromium ones.
- deps += [ "//third_party/webrtc_overrides:webrtc_component" ]
- }
- }
-}
-
if (rtc_include_tests) {
rtc_library("video_mocks") {
testonly = true