commit | e4974953ce0d03a60fae7659b199a6a62a79fa30 | [log] [tgz] |
---|---|---|
author | kjellander <kjellander@google.com> | Thu Jan 26 13:22:37 2017 -0800 |
committer | Commit bot <commit-bot@chromium.org> | Thu Jan 26 21:22:37 2017 +0000 |
tree | b9767255433d9d16ff85900b7c15c455c2f308f5 | |
parent | 71ecaad3ea3fd3d9b0d9fa802b7ee86bd1bae3a1 [diff] |
Revert of Make RTX pt/apt reconfigurable by calling WebRtcVideoChannel2::SetRecvParameters. (patchset #7 id:160001 of https://codereview.webrtc.org/2646073004/ ) Reason for revert: Breaks internal downstream project. Original issue's description: > Make RTX pt/apt reconfigurable by calling WebRtcVideoChannel2::SetRecvParameters. > > Prior to this CL, received RTX (associated) payload types were only configured > when WebRtcVideoChannel2::AddRecvStream was called. In the same method, the RTX > SSRC was set up. > > After this CL, the RTX (associated) payload types are set in > WebRtcVideoChannel2::SetRecvParameters, which is the appropriate place to set > them. The RTX SSRC is still set in WebRtcVideoChannel2::AddRecvStream, since > that is the code path that sets other SSRCs. > > As part of this fix, the VideoReceiveStream::Config::Rtp struct is changed. > We remove the possibility for each video payload type to have an associated > specific RTX SSRC. Although the config previously allowed for this, all payload > types always had the same RTX SSRC set, and the underlying RtpPayloadRegistry > did not support multiple SSRCs. This change to the config struct should thus not > have any functional impact. The change does however affect the RtcEventLog, since > that is used for storing the VideoReceiveStream::Configs. For simplicity, > this CL does not change the event log proto definitions, instead duplicating > the serialized RTX SSRCs such that they fit in the existing proto definition. > > BUG=webrtc:7011 > > Review-Url: https://codereview.webrtc.org/2646073004 > Cr-Commit-Position: refs/heads/master@{#16302} > Committed: https://chromium.googlesource.com/external/webrtc/+/fe2bef39cd2a5c891a49f7320514fb04324dc66c TBR=stefan@webrtc.org,magjed@webrtc.org,terelius@webrtc.org,brandtr@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7011 Review-Url: https://codereview.webrtc.org/2649323010 Cr-Commit-Position: refs/heads/master@{#16307}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.