Minor fixes and refactoring for RtpTransport until the Demux.
This change fixes some inefficiencies and quirks in the code that
originates in RtpTransport leading up to the demux.
This work is in preparation for more refactoring of the Demux stage
onwards.
Bug: webrtc:10297
Change-Id: I7b8f00134657d62c722939618a55a91a2b6040bd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128220
Commit-Queue: Amit Hilbuch <amithi@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27185}diff --git a/pc/rtp_transport.h b/pc/rtp_transport.h
index f188a17..dfdabbc 100644
--- a/pc/rtp_transport.h
+++ b/pc/rtp_transport.h
@@ -87,7 +87,7 @@
RtpTransportAdapter* GetInternal() override;
// These methods will be used in the subclasses.
- void DemuxPacket(rtc::CopyOnWriteBuffer* packet, int64_t packet_time_us);
+ void DemuxPacket(rtc::CopyOnWriteBuffer packet, int64_t packet_time_us);
bool SendPacket(bool rtcp,
rtc::CopyOnWriteBuffer* packet,
@@ -97,9 +97,9 @@
// Overridden by SrtpTransport.
virtual void OnNetworkRouteChanged(
absl::optional<rtc::NetworkRoute> network_route);
- virtual void OnRtpPacketReceived(rtc::CopyOnWriteBuffer* packet,
+ virtual void OnRtpPacketReceived(rtc::CopyOnWriteBuffer packet,
int64_t packet_time_us);
- virtual void OnRtcpPacketReceived(rtc::CopyOnWriteBuffer* packet,
+ virtual void OnRtcpPacketReceived(rtc::CopyOnWriteBuffer packet,
int64_t packet_time_us);
// Overridden by SrtpTransport and DtlsSrtpTransport.
virtual void OnWritableState(rtc::PacketTransportInternal* packet_transport);