commit ef52d8b859a45ebc7989a73080cbb743309178e6
author Karl Wiberg <kwiberg@webrtc.org> Wed Oct 25 13:20:03 2017 +0200
committer Commit Bot <commit-bot@chromium.org> Wed Oct 25 11:53:16 2017 +0000
tree 95ffc23b52c4dc82af7188724944fff15d6bb01a
parent d71997941a5c1e76beb3206d7c25eff30fb8b73d

Presubmit: Don't forget to warn when changing headers in subdirs of api/

Unlike all the other API directories, api/ is the root of an entire
tree of directories that are also API directories.

BUG=webrtc:8445

Change-Id: I218befe6fb6113b95599512f062ebe63abc98889
Reviewed-on: https://webrtc-review.googlesource.com/15321
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20427}

PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 3ed3728..c72fc19 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -62,7 +62,7 @@
 #    webrtc-users@google.com (internal list).
 # 4. (later) The deprecated APIs are removed.
 NATIVE_API_DIRS = (
-  'api',
+  'api',  # All subdirectories of api/ are included as well.
   'media',
   'modules/audio_device/include',
   'pc',
@@ -160,8 +160,15 @@
   for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile):
     if f.LocalPath().endswith('.h'):
       for path in API_DIRS:
-        if os.path.dirname(f.LocalPath()) == path:
-          files.append(f)
+        dn = os.path.dirname(f.LocalPath())
+        if path == 'api':
+          # Special case: Subdirectories included.
+          if dn == 'api' or dn.startswith('api/'):
+            files.append(f)
+        else:
+          # Normal case: Subdirectories not included.
+          if dn == path:
+            files.append(f)
 
   if files:
     return [output_api.PresubmitNotifyResult(API_CHANGE_MSG, files)]